[MIG][10.0] website crm recaptcha - #268
Merged
Merged
Conversation
lasley
force-pushed
the
release/10.0/website_crm_recaptcha
branch
from
October 22, 2016 21:50
9208c64 to
2f3eb29
Compare
pedrobaeza
approved these changes
Nov 12, 2016
Contributor
Author
|
@tedsalmon please review |
tarteo
requested changes
Mar 20, 2017
tarteo
left a comment
Member
There was a problem hiding this comment.
Can you replace © with Copyright to comply the template?
Tested it on Runbot 👍
| var snippet_animation = require('web_editor.snippets.animation'); | ||
| var $ = require("$"); | ||
|
|
||
| snippet_animation.registry.form_builder_send = snippet_animation.registry.form_builder_send.extend({ |
Member
There was a problem hiding this comment.
Can you use snippet_animation.registry.form_builder_send.include here, please.
Contributor
Author
There was a problem hiding this comment.
I'll make this change in #267, which will then rebase here when it's merged - would you mind also dropping a review there seeing as you already technically reviewed the code?
tedsalmon
approved these changes
Mar 20, 2017
| @@ -6,7 +6,6 @@ odoo.define('website_form_recaptcha.recaptcha', function(require){ | |||
| "use strict"; | |||
There was a problem hiding this comment.
I know you didn't really create these warnings, but while here it might be nice to fix:
website_form_recaptcha/static/src/js/field_recaptcha.js:7: [W7903(javascript-lint), ] Trailing spaces not allowed. [Error/no-trailing-spaces]
website_form_recaptcha/static/src/js/field_recaptcha.js:9: [W7903(javascript-lint), ] Trailing spaces not allowed. [Error/no-trailing-spaces]
website_form_recaptcha/static/src/js/field_recaptcha.js:11: [W7903(javascript-lint), ] Trailing spaces not allowed. [Error/no-trailing-spaces]
website_form_recaptcha/static/src/js/field_recaptcha.js:20: [W7903(javascript-lint), ] Assignment to function parameter 'data'. [Error/no-param-reassign]
website_form_recaptcha/static/src/js/field_recaptcha.js:30: [W7903(javascript-lint), ] Trailing spaces not allowed. [Error/no-trailing-spaces]
website_form_recaptcha/static/src/js/field_recaptcha.js:32: [W7903(javascript-lint), ] Trailing spaces not allowed. [Error/no-trailing-spaces]
Contributor
Author
There was a problem hiding this comment.
Technically I did, because I created this module. Will fix, thanks
* Remove po files * Bump version in manifest and ReadMe * Installable to True * Update copyright headers
lasley
force-pushed
the
release/10.0/website_crm_recaptcha
branch
from
March 29, 2017 16:58
d90f561 to
c8b4039
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For functional review, you can use the following:
Site Key:
6Lc6IiYTAAAAADOJX1PtcR-b7cm-STCY2LT2qBQlSecret Key:
6Lc6IiYTAAAAAP_o_788-FI84b7zJMiax4SH_enFDepends: