chore(spec): sync to core 6ff1e1d, and close eleven fields of wire drift - #5
Merged
Merged
Conversation
The vendored snapshot moves from b463f19 to core main at 6ff1e1d, which carries the three core changes the webmail review produced (task counts on PIM collections, label rename/delete by id, and one refusal for an unverified forwarding destination) plus everything between. Two things this bump has to say beyond the copy: - main was already red. The previous sync (b5c22ee) updated the snapshot and CORE_REF alone, so TestWireStructsMatchOpenAPISnapshot has been failing since on four components: ApiKey.requireActingCredential, AppendResult's six fresh-store fields (blobHash, flags, keywords, modseq, receivedAt, size), EmailSearchResult.ids and WhoamiResult. permittedRecipients. Each now has its Go field, typed off the spec, with the absent-vs-empty convention the neighbouring fields already document where it applies (permittedRecipients follows domains). - The new snapshot adds PimCollection.taskCounts and PimSharedWithMe's objectCount + taskCounts, carried on a PimTaskCounts pair. Forwarding: core now answers `400 destination_unverified` (with `target`) for a destination that has not proved a code, the same word, shape and status its Sieve and rules surfaces use; it was `403 destination_not_ verified`. The two comments that named the old answer are corrected, and the CLI gains a sentence for the code, worded for every surface that answers it and naming the address and the two verbs that fix it. Verified: gofmt, go vet, go build, go test -race ./... (the contract test passes against the new snapshot; it fails on main today). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-vendors core's
openapi.snapshot.jsonat6ff1e1d(core main; PRs #30–#32 landed there today) and stampsCORE_REF.What the bump found
mainis already red. The previous sync (b5c22ee) updated the snapshot andCORE_REFalone, soTestWireStructsMatchOpenAPISnapshothas been failing since on four components. This PR gives each spec property its Go field, typed off the spec:ApiKeyrequireActingCredentialAppendResultblobHash,flags,keywords,modseq,receivedAt,size(fresh-store only)EmailSearchResultids(thefields: "ids"answer)WhoamiResultpermittedRecipients(nil = no list, thedomainsconvention)PimCollectiontaskCounts— new in this snapshotPimSharedWithMeobjectCount,taskCounts— new in this snapshotForwarding
Core now answers
400 destination_unverifiedwith the address astargetfor a destination that has not proved a code — the same word, shape and status its Sieve and rules surfaces use (it was403 destination_not_verified). The two comments inforwarding.gothat named the old answer are corrected, androot.gogains a sentence for the code: it names the address and the two verbs (forwarding add,forwarding verify) that fix it, worded for every surface that can answer it.Verification
gofmt -lclean,go vet,go build,go test -race ./...all pass. The contract test fails onmaintoday and passes here.