build: the sibling core checkout is ../core - #6
Merged
Merged
Conversation
CORE_DIR defaulted to `../openemail-core`, a directory name nothing uses: the repo is Open-Email/core and checks out as `core`. So both spec targets failed on the only layout there is, and `make sync-spec` had to be given CORE_DIR=../core by hand every time — which is how the vendored snapshot came to sit three core commits behind with the contract test red on main. A default that is never right is worse than no default: the snapshot was not refreshed and wrong, it was not refreshed at all, and nothing said so. CORE_DIR still overrides; CI passes `.core` and is unaffected. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CORE_DIRdefaulted to../openemail-core, a directory name nothing uses — the repo isOpen-Email/coreand checks out ascore.So
make sync-specandmake sync-spec-checkfailed on the only layout there is, and the sync had to be givenCORE_DIR=../coreby hand every time. That is how the vendored snapshot came to sit three core commits behind withTestWireStructsMatchOpenAPISnapshotred onmain(fixed in #5): a default that is never right is worse than no default, because the snapshot was not refreshed and wrong — it was not refreshed at all, and nothing said so.CORE_DIRstill overrides, and CI passes.core, so the workflow is unaffected.Verified:
gofmt -lclean,go build ./..., the contract test, andmake -n sync-spec(resolves to../core) /make -n sync-spec CORE_DIR=/tmp/elsewhere(override still wins).The same one-line default is fixed in the gateway, dav and webmail.
🤖 Generated with Claude Code