[WIP] Fix the StartMenuDLL for classic theme support on the taskbar

[OrthodoxWindows]

Fixed DLL code for classic theme support.

These changes add classic theme support to the taskbar, as discussed here and here. The original author of these modifications is valinet

[AppVeyorBot]

✅ Build Open-Shell-Menu 4.4.191-hlvioynt completed (commit e533cd3deb by @OrthodoxWindows)

[ge0rdi]

I'm sorry but this PR breaks functionality of Open-Shell, so it can't be merged in this state.

I have just installed in in Windows Sandbox (clean Win10) and enabled Customize taskbar option and here is the result:

You can try it for yourself.

Do you understand what those changes are about?
Or just created PR using patch that Valinet provided for single custom use case?

Because most of them just break existing functionality (Open-Shell has to support much more cases than just Classic theme with ExplorerPatcher).

[OrthodoxWindows]

Yes, I understand that in this state, it is not mergeable. On the other hand, I imagine that it is possible if it becomes configurable (a possible option which will leave the choice to activate it). However, it seems to me that it didn't break the installations in the original version, but maybe that's because it was a previous version. I will try to compare the current version to previous versions. When modifying the DLL, I noticed a change in line 2957 (among the lines modified by valinet). For the other lines, it was identical.
For use cases, it seems to be more than a single custom use case, quite a few people seem to be using it. Also, the usage is no longer specific to ExplorerPatcher, there is now a reproduction with a Windawk mods (which does the same thing as ExplorerPatcher for the taskbar in the classic theme).

[OrthodoxWindows]

I'll look at the display issues in more detail (that said, I understood most of what the changes seem to do, as valinet explained the changes pretty well), and come back here if I know more.

[ge0rdi]

It would be also great to describe what exactly is the issue and steps to replicate it.
I don't quite get what those changes are trying to solve.

[ge0rdi]

Cannot be merged in current state. See discussion above.

[Anixx]

Hello! Here is how the taskbar looks like without the patch compared to when using the patch:

OpenShell version: 4.4.169 (the last build for which the patched dll is available)
Explorer Patcher version: 22621.2361.58.1
Windows build: 10.0.22000.2176

[ge0rdi]

Please, don't add binary installer to PR changes. It won't get merged that way.
If you want to share installer for testing you can attach it here in comments.

[OrthodoxWindows]

Please, don't add binary installer to PR changes. It won't get merged that way.
If you want to share installer for testing you can attach it here in comments.

It wasn't on purpose, I wanted to add it to my fork, I didn't think it would add the file here. I'm deleting it right now.

[ge0rdi]

Since you have opened this PR, then all changes in the source branch of your fork are synced here.

I'd probably suggest to just close this PR and probably submit new one once you finish it?

[IRainman]

It's probably partially fixed by #2068.

[Anixx]

It's probably partially fixed by #2068.

Just tried your build, it does not fix this issue at all:

[Neustradamus]

@OrthodoxWindows: Have you progressed on it?

[ale5000-git]

@OrthodoxWindows
Isn't this already fixed by #2107

[Anixx]

EP cannot fix this. This is why the EP dev suggested and created the patch to OpenShell.

[Anixx]

The bug you linked only concerns the EP taskbar, which does not support the Classic theme at all.

[ge0rdi]

Replaced by PR #2369.