Support for unthemed taskbar

[Anixx]

See this discussion:
#2367

[AppVeyorBot]

✅ Build Open-Shell-Menu 4.4.197-lmbeyoav completed (commit 43f1f0c644 by @Anixx)

[AppVeyorBot]

✅ Build Open-Shell-Menu 4.4.197-yulsgqmy completed (commit 484846730a by @Anixx)

[ge0rdi]

@Anixx
I have pushed few fixes.
Once there is AppVeyor build available, please check if it works for you.

You should now use default taskbar color. So please remove "TaskbarColor"=dword:00000000 setting.

[AppVeyorBot]

✅ Build Open-Shell-Menu 4.4.197-vhvgvfue completed (commit 0d99e11892 by @ge0rdi)

[Anixx]

Okay, so I overcame the Explorer crashes and tested your modification. Here is the screenshot with the default color setting. It is not as expected:

[Anixx]

Here is how it looks with taskbar color black:

Only the tray area and a 1-px strip around Start button are looking wrong. Possibly, UpdateTaskbar is neded to refresh tray.

[ge0rdi]

Here is the screenshot with the default color setting. It is not as expected

What exactly is not expected?

How does it look like with your original changes in this PR?
Because I believe current PR changes should do exactly the same (when taskbar color is set to default).

[Anixx]

When the taskbar color is set to default, as you can see, it has wrong color:

• The text is not black
• The shadows are not black
• The taskbar color and the language indicator's color are wrong (not buttonface). In the tray area you can see icons of different color.

Basically, the AccentColor gets mixed into all taskbar colors.

[Anixx]

If the default color in the OpenShell settings is not black, it gets admixed to the taskbar.

[ge0rdi]

That is super weird. TaskbarColor setting is supposed to affect just taskbar background, not text.

How does it look like with your original changes in this PR?

Can you provide screenshot from original build in this PR?
https://ci.appveyor.com/project/passionate-coder/open-shell-menu/builds/53205973

[ge0rdi]

Don't you have some Win7 compatibility set for explorer, or so?

[Anixx]

It looks the same. This version though https://github.com/OrthodoxWindows/Open-Shell-Menu/blob/master/OpenShellSetup_4_4_191-hlvioynt.exe looks well if to set taskbar color to black. With non-black color it gets admixed to all the taskbar colors anyway.

[Anixx]

No, there are no compat layers set to explorer.exe.

[AppVeyorBot]

✅ Build Open-Shell-Menu 4.4.197-bisesytn completed (commit ac30362858 by @ge0rdi)

[ge0rdi]

Can you please test with latest build?
https://ci.appveyor.com/project/passionate-coder/open-shell-menu/builds/53209989

There was one more place that used TaskbarColor setting. I have disabled that for non-themed explorer.

[Anixx]

Yes, works, thank you! This is screenshot with default color in settings:

The only issue with classic theme in this build that remains is the shift of the start button to the right by 3px, making a non-clickable dead zone to the left of it and looking a bit wrong. And also, it fuses with the separator to the right of it if it exists.

[ge0rdi]

The only issue with classic theme in this build that remains is the shift of the start button to the right by 3px, making a non-clickable dead zone to the left of it and looking a bit wrong. And also, it fuses with the separator to the right of it if it exists.

Hmm, but this is most likely not related to changes in this PR.
Maybe it is caused by some changes that were done on master in the meantime?

Does it work correctly with https://github.com/OrthodoxWindows/Open-Shell-Menu/blob/master/OpenShellSetup_4_4_191-hlvioynt.exe build you mentioned?

[Anixx]

Yes, it is not related to this PR. The change was made earlier. But it is in StartMenuDLL because taking this file from an earlier version (I think, 191) fixes it...

[ge0rdi]

Can you provide log obtained using this guide?
https://github.com/Open-Shell/Open-Shell-Menu/wiki/How-to-obtain-advanced-Open-Shell-Menu-log

Ideally one with version from this PR and one with version that works correctly for you.

[Anixx]

StartMenuLogOld.zip
StartMenuLogLatest.zip

The button coordinates in the logs are the same, but the actual positions are different.

[ge0rdi]

This is from old (good) log:
Start Rect: 2, 744, 56, 766
And this from latest:
Start Rect: 2, 742, 60, 768

So indeed the start button is shifted up by 2px and 4px wider and higher.

[ge0rdi]

The horizontal shift is the result of bigger start button. Because we are centering button inside taskbar. And since taskbar had the same height in both cases, larger button had to go a bit higher.

So the only issue here seems to be that start button is a bit bigger in recent code than it was in older.

[Anixx]

Nope, the start buton is of the same size, the same height and the same width. It is only shifted to the right. And the space to the left of it is not clickable. This log is not reflecting reality.

[ge0rdi]

Well, in any case it would be rather hard for me to figure this out (as I don't have your environment).

I'd suggest you will compile StartMenuDLL.dll, commit by commit since 191 and try to determine what commit/change caused this issue.
We have build instructions in BUILDME.txt (basically you just need to open solution in Visual Studio and then just build StartMenuDLL project).

Once you know what commit caused this behavior, it may be easier to prepare some fix.

We can also merge this PR, I think it should be pretty safe and shouldn't cause any regressions to existing users.

[Neustradamus]

@Anixx: Thanks for your work!

[bonzibudd]

@ge0rdi would you like me to review this?

[ge0rdi]

@bonzibudd
Sure, no problem.

I have already approved it some time ago.
But @Anixx wrote that there is still some issue with classic theme and then didn't reply back anymore.
So I'm waiting for an information whether I should merge this or not.

[Anixx]

The issue that remains is with the positioning of the start button, not related to colors. Definitely, this should be merged. I thought is has been already.

[Neustradamus]

@Anixx: Good job, thanks!

It replaces:

• Patch for unthemed taskbar #2368

[Anixx]

For the reference, here is the issue regarding the button positioning:
#2379

[bonzibudd]

@Anixx Thanks, I'll check this out.

[ale5000-git]

@ge0rdi
Artifacts are expired, could you please generate a new one for the latest commit?

[ge0rdi]

@ale5000-git
I have created new release:
https://github.com/Open-Shell/Open-Shell-Menu/releases/tag/v4.4.197
You can get official installer from there.

[ale5000-git]

Thank you very much.