Skip setting readOnly properties with default values in model constructors

[code-lucidal58]

Fix#10195

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@antihax@grokify@kemokemo@jirikuncar@ph4r5h4d

[wing328]

@code-lucidal58 thanks for the PR. Instead of relying on an additional option, shall we simply rely on the readOnly attributes in the mustache templates ?

[code-lucidal58]

We can do that, i.e. relying only on readOny properties in the mustache files. However, to preserve the current behaviour I have added the configuration flag. I worked on the assumption that someone, who is using this generator, might want the constructors for other purposes where all default values are required to be pre-filled.

[wing328]

Understood. It's always a good idea to make changes backward compatible.

For this particular case, I would consider it as a bug fix for read only attributes.

I'll remove the option later and if someone prefers the old behaviour with a good reason, we can always add back the option.

[code-lucidal58]

Fix#10195

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@antihax@grokify@kemokemo@jirikuncar@ph4r5h4d

[wing328]

@code-lucidal58 thanks for the PR. Instead of relying on an additional option, shall we simply rely on the readOnly attributes in the mustache templates ?

[code-lucidal58]

We can do that, i.e. relying only on readOny properties in the mustache files. However, to preserve the current behaviour I have added the configuration flag. I worked on the assumption that someone, who is using this generator, might want the constructors for other purposes where all default values are required to be pre-filled.

[wing328]

Understood. It's always a good idea to make changes backward compatible.

For this particular case, I would consider it as a bug fix for read only attributes.

I'll remove the option later and if someone prefers the old behaviour with a good reason, we can always add back the option.

[code-lucidal58]

Fix#10195

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@antihax@grokify@kemokemo@jirikuncar@ph4r5h4d

[wing328]

@code-lucidal58 thanks for the PR. Instead of relying on an additional option, shall we simply rely on the readOnly attributes in the mustache templates ?

[code-lucidal58]

We can do that, i.e. relying only on readOny properties in the mustache files. However, to preserve the current behaviour I have added the configuration flag. I worked on the assumption that someone, who is using this generator, might want the constructors for other purposes where all default values are required to be pre-filled.

[wing328]

Understood. It's always a good idea to make changes backward compatible.

For this particular case, I would consider it as a bug fix for read only attributes.

I'll remove the option later and if someone prefers the old behaviour with a good reason, we can always add back the option.

[code-lucidal58]

Fix#10195

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@antihax@grokify@kemokemo@jirikuncar@ph4r5h4d

[wing328]

@code-lucidal58 thanks for the PR. Instead of relying on an additional option, shall we simply rely on the readOnly attributes in the mustache templates ?

[code-lucidal58]

We can do that, i.e. relying only on readOny properties in the mustache files. However, to preserve the current behaviour I have added the configuration flag. I worked on the assumption that someone, who is using this generator, might want the constructors for other purposes where all default values are required to be pre-filled.

[wing328]

Understood. It's always a good idea to make changes backward compatible.

For this particular case, I would consider it as a bug fix for read only attributes.

I'll remove the option later and if someone prefers the old behaviour with a good reason, we can always add back the option.

[code-lucidal58]

Fix#10195

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@antihax@grokify@kemokemo@jirikuncar@ph4r5h4d

[wing328]

@code-lucidal58 thanks for the PR. Instead of relying on an additional option, shall we simply rely on the readOnly attributes in the mustache templates ?

[code-lucidal58]

We can do that, i.e. relying only on readOny properties in the mustache files. However, to preserve the current behaviour I have added the configuration flag. I worked on the assumption that someone, who is using this generator, might want the constructors for other purposes where all default values are required to be pre-filled.

[wing328]

Understood. It's always a good idea to make changes backward compatible.

For this particular case, I would consider it as a bug fix for read only attributes.

I'll remove the option later and if someone prefers the old behaviour with a good reason, we can always add back the option.

[code-lucidal58]

Fix#10195

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@antihax@grokify@kemokemo@jirikuncar@ph4r5h4d

[wing328]

@code-lucidal58 thanks for the PR. Instead of relying on an additional option, shall we simply rely on the readOnly attributes in the mustache templates ?

[code-lucidal58]

We can do that, i.e. relying only on readOny properties in the mustache files. However, to preserve the current behaviour I have added the configuration flag. I worked on the assumption that someone, who is using this generator, might want the constructors for other purposes where all default values are required to be pre-filled.

[wing328]

Understood. It's always a good idea to make changes backward compatible.

For this particular case, I would consider it as a bug fix for read only attributes.

I'll remove the option later and if someone prefers the old behaviour with a good reason, we can always add back the option.

[code-lucidal58]

Fix#10195

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@antihax@grokify@kemokemo@jirikuncar@ph4r5h4d

[wing328]

@code-lucidal58 thanks for the PR. Instead of relying on an additional option, shall we simply rely on the readOnly attributes in the mustache templates ?

[code-lucidal58]

We can do that, i.e. relying only on readOny properties in the mustache files. However, to preserve the current behaviour I have added the configuration flag. I worked on the assumption that someone, who is using this generator, might want the constructors for other purposes where all default values are required to be pre-filled.

[wing328]

Understood. It's always a good idea to make changes backward compatible.

For this particular case, I would consider it as a bug fix for read only attributes.

I'll remove the option later and if someone prefers the old behaviour with a good reason, we can always add back the option.

[code-lucidal58]

Fix#10195

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@antihax@grokify@kemokemo@jirikuncar@ph4r5h4d

[wing328]

@code-lucidal58 thanks for the PR. Instead of relying on an additional option, shall we simply rely on the readOnly attributes in the mustache templates ?

[code-lucidal58]

We can do that, i.e. relying only on readOny properties in the mustache files. However, to preserve the current behaviour I have added the configuration flag. I worked on the assumption that someone, who is using this generator, might want the constructors for other purposes where all default values are required to be pre-filled.

[wing328]

Understood. It's always a good idea to make changes backward compatible.

For this particular case, I would consider it as a bug fix for read only attributes.

I'll remove the option later and if someone prefers the old behaviour with a good reason, we can always add back the option.