Remove skipReadonlyPropertiesInInit option

[wing328]

For #10196 (comment)

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04)

[vvb]

@wing328 This PR removes the conditional variable to skip readonly properties. As per your comment on the initial PR, I thought the intent is to make "skipping setting of read-only variables in init" by default. So, I would have expected some changes in the mustache file which checks for {#isReadOnly} and skips it from Init method.

The requirement is to have an init method, where read-only properties are not set. This PR does not seem to be doing that.
Are there more commits coming to this PR?

[wing328]

As discussed with @code-lucidal58, it looks like the definition of the option skipReadonlyPropertiesInInit is flipped. I've pushed some fixes and now there's no change to the samples.

[vvb]

@wing328 LGTM. Thanks

[wing328]

For #10196 (comment)

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04)

[vvb]

@wing328 This PR removes the conditional variable to skip readonly properties. As per your comment on the initial PR, I thought the intent is to make "skipping setting of read-only variables in init" by default. So, I would have expected some changes in the mustache file which checks for {#isReadOnly} and skips it from Init method.

The requirement is to have an init method, where read-only properties are not set. This PR does not seem to be doing that.
Are there more commits coming to this PR?

[wing328]

As discussed with @code-lucidal58, it looks like the definition of the option skipReadonlyPropertiesInInit is flipped. I've pushed some fixes and now there's no change to the samples.

[vvb]

@wing328 LGTM. Thanks

[wing328]

For #10196 (comment)

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04)

[vvb]

@wing328 This PR removes the conditional variable to skip readonly properties. As per your comment on the initial PR, I thought the intent is to make "skipping setting of read-only variables in init" by default. So, I would have expected some changes in the mustache file which checks for {#isReadOnly} and skips it from Init method.

The requirement is to have an init method, where read-only properties are not set. This PR does not seem to be doing that.
Are there more commits coming to this PR?

[wing328]

As discussed with @code-lucidal58, it looks like the definition of the option skipReadonlyPropertiesInInit is flipped. I've pushed some fixes and now there's no change to the samples.

[vvb]

@wing328 LGTM. Thanks

[wing328]

For #10196 (comment)

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04)

[vvb]

@wing328 This PR removes the conditional variable to skip readonly properties. As per your comment on the initial PR, I thought the intent is to make "skipping setting of read-only variables in init" by default. So, I would have expected some changes in the mustache file which checks for {#isReadOnly} and skips it from Init method.

The requirement is to have an init method, where read-only properties are not set. This PR does not seem to be doing that.
Are there more commits coming to this PR?

[wing328]

As discussed with @code-lucidal58, it looks like the definition of the option skipReadonlyPropertiesInInit is flipped. I've pushed some fixes and now there's no change to the samples.

[vvb]

@wing328 LGTM. Thanks

[wing328]

For #10196 (comment)

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04)

[vvb]

@wing328 This PR removes the conditional variable to skip readonly properties. As per your comment on the initial PR, I thought the intent is to make "skipping setting of read-only variables in init" by default. So, I would have expected some changes in the mustache file which checks for {#isReadOnly} and skips it from Init method.

The requirement is to have an init method, where read-only properties are not set. This PR does not seem to be doing that.
Are there more commits coming to this PR?

[wing328]

As discussed with @code-lucidal58, it looks like the definition of the option skipReadonlyPropertiesInInit is flipped. I've pushed some fixes and now there's no change to the samples.

[vvb]

@wing328 LGTM. Thanks

[wing328]

For #10196 (comment)

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04)

[vvb]

@wing328 This PR removes the conditional variable to skip readonly properties. As per your comment on the initial PR, I thought the intent is to make "skipping setting of read-only variables in init" by default. So, I would have expected some changes in the mustache file which checks for {#isReadOnly} and skips it from Init method.

The requirement is to have an init method, where read-only properties are not set. This PR does not seem to be doing that.
Are there more commits coming to this PR?

[wing328]

As discussed with @code-lucidal58, it looks like the definition of the option skipReadonlyPropertiesInInit is flipped. I've pushed some fixes and now there's no change to the samples.

[vvb]

@wing328 LGTM. Thanks

[wing328]

For #10196 (comment)

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04)

[vvb]

@wing328 This PR removes the conditional variable to skip readonly properties. As per your comment on the initial PR, I thought the intent is to make "skipping setting of read-only variables in init" by default. So, I would have expected some changes in the mustache file which checks for {#isReadOnly} and skips it from Init method.

The requirement is to have an init method, where read-only properties are not set. This PR does not seem to be doing that.
Are there more commits coming to this PR?

[wing328]

As discussed with @code-lucidal58, it looks like the definition of the option skipReadonlyPropertiesInInit is flipped. I've pushed some fixes and now there's no change to the samples.

[vvb]

@wing328 LGTM. Thanks

[wing328]

For #10196 (comment)

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04)

[vvb]

@wing328 This PR removes the conditional variable to skip readonly properties. As per your comment on the initial PR, I thought the intent is to make "skipping setting of read-only variables in init" by default. So, I would have expected some changes in the mustache file which checks for {#isReadOnly} and skips it from Init method.

The requirement is to have an init method, where read-only properties are not set. This PR does not seem to be doing that.
Are there more commits coming to this PR?

[wing328]

As discussed with @code-lucidal58, it looks like the definition of the option skipReadonlyPropertiesInInit is flipped. I've pushed some fixes and now there's no change to the samples.

[vvb]

@wing328 LGTM. Thanks