[Typescript] update addImport method (fix oneOf)

[ksvirkou-hubspot]

fixes#11679

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[ksvirkou-hubspot]

@TiFu@taxpon@sebastianhaas@kenisteward@Vrolijkx@macjohnny@topce@akehir@petejohansonxo@amakhrov

[macjohnny]

thanks for your contribution!

[macjohnny]

some unit tests would be nice in https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/TypeScriptClientCodegenTest.java

[ksvirkou-hubspot]

there are some tests https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/TypeScriptClientModelTest.java

[macjohnny]

can you add tests that are directly related to your code change? i.e. tests that would fail without your change.

[ksvirkou-hubspot]

Ok
I ll try to do something
but maybe it would be an example of this in the petstore and test there
I ll think over it

[akehir]

Would it make sense to have an example of this in the petstore yaml files? I've run in the bug myself, but it would be good to prevent regressions.

[macjohnny]

FYI see also #11719

[ksvirkou-hubspot]

Hi @macjohnny
I ve just tryed to add sample in the petstore but I can't build anything in the pestore
I see many errors
for example

The reason probably in this PR
code base was updated but sapmes don’t work
there are necessary update typescript version and fix some code
for example ?.was added in ts 3.7
but in package set "typescript": "^2.4.1"
that is why I can’t add tests
any ideas how to resolve it?

[macjohnny]

@ksvirkou-hubspot we recently dropped support for typescript below 4, see #12123

[ksvirkou-hubspot]

@macjohnny
This PR updated builds and mustaches but it didn't update tests
for example
"typescript": "^2.4.1"
https://github.com/OpenAPITools/openapi-generator/blob/master/samples/openapi3/client/petstore/typescript/tests/default/package.json

[macjohnny]

I wonder whether they are executed on the CI at all.
Do you want to update the tests and check their execution?

[ksvirkou-hubspot]

I wonder whether they are executed on the CI at all. Do you want to update the tests and check their execution?

No I have no time sorry
And I don’t know how to add here test
I ve try to add sample but now code changed and this function isn't use
we can close this pr but if the code will changed again we will have a problem

[ksvirkou-hubspot]

fixes#11679

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[ksvirkou-hubspot]

@TiFu@taxpon@sebastianhaas@kenisteward@Vrolijkx@macjohnny@topce@akehir@petejohansonxo@amakhrov

[macjohnny]

thanks for your contribution!

[macjohnny]

some unit tests would be nice in https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/TypeScriptClientCodegenTest.java

[ksvirkou-hubspot]

there are some tests https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/TypeScriptClientModelTest.java

[macjohnny]

can you add tests that are directly related to your code change? i.e. tests that would fail without your change.

[ksvirkou-hubspot]

Ok
I ll try to do something
but maybe it would be an example of this in the petstore and test there
I ll think over it

[akehir]

Would it make sense to have an example of this in the petstore yaml files? I've run in the bug myself, but it would be good to prevent regressions.

[macjohnny]

FYI see also #11719

[ksvirkou-hubspot]

Hi @macjohnny
I ve just tryed to add sample in the petstore but I can't build anything in the pestore
I see many errors
for example

The reason probably in this PR
code base was updated but sapmes don’t work
there are necessary update typescript version and fix some code
for example ?.was added in ts 3.7
but in package set "typescript": "^2.4.1"
that is why I can’t add tests
any ideas how to resolve it?

[macjohnny]

@ksvirkou-hubspot we recently dropped support for typescript below 4, see #12123

[ksvirkou-hubspot]

@macjohnny
This PR updated builds and mustaches but it didn't update tests
for example
"typescript": "^2.4.1"
https://github.com/OpenAPITools/openapi-generator/blob/master/samples/openapi3/client/petstore/typescript/tests/default/package.json

[macjohnny]

I wonder whether they are executed on the CI at all.
Do you want to update the tests and check their execution?

[ksvirkou-hubspot]

I wonder whether they are executed on the CI at all. Do you want to update the tests and check their execution?

No I have no time sorry
And I don’t know how to add here test
I ve try to add sample but now code changed and this function isn't use
we can close this pr but if the code will changed again we will have a problem

[ksvirkou-hubspot]

fixes#11679

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[ksvirkou-hubspot]

@TiFu@taxpon@sebastianhaas@kenisteward@Vrolijkx@macjohnny@topce@akehir@petejohansonxo@amakhrov

[macjohnny]

thanks for your contribution!

[macjohnny]

some unit tests would be nice in https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/TypeScriptClientCodegenTest.java

[ksvirkou-hubspot]

there are some tests https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/TypeScriptClientModelTest.java

[macjohnny]

can you add tests that are directly related to your code change? i.e. tests that would fail without your change.

[ksvirkou-hubspot]

Ok
I ll try to do something
but maybe it would be an example of this in the petstore and test there
I ll think over it

[akehir]

Would it make sense to have an example of this in the petstore yaml files? I've run in the bug myself, but it would be good to prevent regressions.

[macjohnny]

FYI see also #11719

[ksvirkou-hubspot]

Hi @macjohnny
I ve just tryed to add sample in the petstore but I can't build anything in the pestore
I see many errors
for example

The reason probably in this PR
code base was updated but sapmes don’t work
there are necessary update typescript version and fix some code
for example ?.was added in ts 3.7
but in package set "typescript": "^2.4.1"
that is why I can’t add tests
any ideas how to resolve it?

[macjohnny]

@ksvirkou-hubspot we recently dropped support for typescript below 4, see #12123

[ksvirkou-hubspot]

@macjohnny
This PR updated builds and mustaches but it didn't update tests
for example
"typescript": "^2.4.1"
https://github.com/OpenAPITools/openapi-generator/blob/master/samples/openapi3/client/petstore/typescript/tests/default/package.json

[macjohnny]

I wonder whether they are executed on the CI at all.
Do you want to update the tests and check their execution?

[ksvirkou-hubspot]

I wonder whether they are executed on the CI at all. Do you want to update the tests and check their execution?

No I have no time sorry
And I don’t know how to add here test
I ve try to add sample but now code changed and this function isn't use
we can close this pr but if the code will changed again we will have a problem

[ksvirkou-hubspot]

fixes#11679

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[ksvirkou-hubspot]

@TiFu@taxpon@sebastianhaas@kenisteward@Vrolijkx@macjohnny@topce@akehir@petejohansonxo@amakhrov

[macjohnny]

thanks for your contribution!

[macjohnny]

some unit tests would be nice in https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/TypeScriptClientCodegenTest.java

[ksvirkou-hubspot]

there are some tests https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/TypeScriptClientModelTest.java

[macjohnny]

can you add tests that are directly related to your code change? i.e. tests that would fail without your change.

[ksvirkou-hubspot]

Ok
I ll try to do something
but maybe it would be an example of this in the petstore and test there
I ll think over it

[akehir]

Would it make sense to have an example of this in the petstore yaml files? I've run in the bug myself, but it would be good to prevent regressions.

[macjohnny]

FYI see also #11719

[ksvirkou-hubspot]

Hi @macjohnny
I ve just tryed to add sample in the petstore but I can't build anything in the pestore
I see many errors
for example

The reason probably in this PR
code base was updated but sapmes don’t work
there are necessary update typescript version and fix some code
for example ?.was added in ts 3.7
but in package set "typescript": "^2.4.1"
that is why I can’t add tests
any ideas how to resolve it?

[macjohnny]

@ksvirkou-hubspot we recently dropped support for typescript below 4, see #12123

[ksvirkou-hubspot]

@macjohnny
This PR updated builds and mustaches but it didn't update tests
for example
"typescript": "^2.4.1"
https://github.com/OpenAPITools/openapi-generator/blob/master/samples/openapi3/client/petstore/typescript/tests/default/package.json

[macjohnny]

I wonder whether they are executed on the CI at all.
Do you want to update the tests and check their execution?

[ksvirkou-hubspot]

I wonder whether they are executed on the CI at all. Do you want to update the tests and check their execution?

No I have no time sorry
And I don’t know how to add here test
I ve try to add sample but now code changed and this function isn't use
we can close this pr but if the code will changed again we will have a problem

[ksvirkou-hubspot]

fixes#11679

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[ksvirkou-hubspot]

@TiFu@taxpon@sebastianhaas@kenisteward@Vrolijkx@macjohnny@topce@akehir@petejohansonxo@amakhrov

[macjohnny]

thanks for your contribution!

[macjohnny]

some unit tests would be nice in https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/TypeScriptClientCodegenTest.java

[ksvirkou-hubspot]

there are some tests https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/TypeScriptClientModelTest.java

[macjohnny]

can you add tests that are directly related to your code change? i.e. tests that would fail without your change.

[ksvirkou-hubspot]

Ok
I ll try to do something
but maybe it would be an example of this in the petstore and test there
I ll think over it

[akehir]

Would it make sense to have an example of this in the petstore yaml files? I've run in the bug myself, but it would be good to prevent regressions.

[macjohnny]

FYI see also #11719

[ksvirkou-hubspot]

Hi @macjohnny
I ve just tryed to add sample in the petstore but I can't build anything in the pestore
I see many errors
for example

The reason probably in this PR
code base was updated but sapmes don’t work
there are necessary update typescript version and fix some code
for example ?.was added in ts 3.7
but in package set "typescript": "^2.4.1"
that is why I can’t add tests
any ideas how to resolve it?

[macjohnny]

@ksvirkou-hubspot we recently dropped support for typescript below 4, see #12123

[ksvirkou-hubspot]

@macjohnny
This PR updated builds and mustaches but it didn't update tests
for example
"typescript": "^2.4.1"
https://github.com/OpenAPITools/openapi-generator/blob/master/samples/openapi3/client/petstore/typescript/tests/default/package.json

[macjohnny]

I wonder whether they are executed on the CI at all.
Do you want to update the tests and check their execution?

[ksvirkou-hubspot]

I wonder whether they are executed on the CI at all. Do you want to update the tests and check their execution?

No I have no time sorry
And I don’t know how to add here test
I ve try to add sample but now code changed and this function isn't use
we can close this pr but if the code will changed again we will have a problem

[ksvirkou-hubspot]

fixes#11679

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[ksvirkou-hubspot]

@TiFu@taxpon@sebastianhaas@kenisteward@Vrolijkx@macjohnny@topce@akehir@petejohansonxo@amakhrov

[macjohnny]

thanks for your contribution!

[macjohnny]

some unit tests would be nice in https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/TypeScriptClientCodegenTest.java

[ksvirkou-hubspot]

there are some tests https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/TypeScriptClientModelTest.java

[macjohnny]

can you add tests that are directly related to your code change? i.e. tests that would fail without your change.

[ksvirkou-hubspot]

Ok
I ll try to do something
but maybe it would be an example of this in the petstore and test there
I ll think over it

[akehir]

Would it make sense to have an example of this in the petstore yaml files? I've run in the bug myself, but it would be good to prevent regressions.

[macjohnny]

FYI see also #11719

[ksvirkou-hubspot]

Hi @macjohnny
I ve just tryed to add sample in the petstore but I can't build anything in the pestore
I see many errors
for example

The reason probably in this PR
code base was updated but sapmes don’t work
there are necessary update typescript version and fix some code
for example ?.was added in ts 3.7
but in package set "typescript": "^2.4.1"
that is why I can’t add tests
any ideas how to resolve it?

[macjohnny]

@ksvirkou-hubspot we recently dropped support for typescript below 4, see #12123

[ksvirkou-hubspot]

@macjohnny
This PR updated builds and mustaches but it didn't update tests
for example
"typescript": "^2.4.1"
https://github.com/OpenAPITools/openapi-generator/blob/master/samples/openapi3/client/petstore/typescript/tests/default/package.json

[macjohnny]

I wonder whether they are executed on the CI at all.
Do you want to update the tests and check their execution?

[ksvirkou-hubspot]

I wonder whether they are executed on the CI at all. Do you want to update the tests and check their execution?

No I have no time sorry
And I don’t know how to add here test
I ve try to add sample but now code changed and this function isn't use
we can close this pr but if the code will changed again we will have a problem

[ksvirkou-hubspot]

fixes#11679

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[ksvirkou-hubspot]

@TiFu@taxpon@sebastianhaas@kenisteward@Vrolijkx@macjohnny@topce@akehir@petejohansonxo@amakhrov

[macjohnny]

thanks for your contribution!

[macjohnny]

some unit tests would be nice in https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/TypeScriptClientCodegenTest.java

[ksvirkou-hubspot]

there are some tests https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/TypeScriptClientModelTest.java

[macjohnny]

can you add tests that are directly related to your code change? i.e. tests that would fail without your change.

[ksvirkou-hubspot]

Ok
I ll try to do something
but maybe it would be an example of this in the petstore and test there
I ll think over it

[akehir]

Would it make sense to have an example of this in the petstore yaml files? I've run in the bug myself, but it would be good to prevent regressions.

[macjohnny]

FYI see also #11719

[ksvirkou-hubspot]

Hi @macjohnny
I ve just tryed to add sample in the petstore but I can't build anything in the pestore
I see many errors
for example

The reason probably in this PR
code base was updated but sapmes don’t work
there are necessary update typescript version and fix some code
for example ?.was added in ts 3.7
but in package set "typescript": "^2.4.1"
that is why I can’t add tests
any ideas how to resolve it?

[macjohnny]

@ksvirkou-hubspot we recently dropped support for typescript below 4, see #12123

[ksvirkou-hubspot]

@macjohnny
This PR updated builds and mustaches but it didn't update tests
for example
"typescript": "^2.4.1"
https://github.com/OpenAPITools/openapi-generator/blob/master/samples/openapi3/client/petstore/typescript/tests/default/package.json

[macjohnny]

I wonder whether they are executed on the CI at all.
Do you want to update the tests and check their execution?

[ksvirkou-hubspot]

I wonder whether they are executed on the CI at all. Do you want to update the tests and check their execution?

No I have no time sorry
And I don’t know how to add here test
I ve try to add sample but now code changed and this function isn't use
we can close this pr but if the code will changed again we will have a problem

[ksvirkou-hubspot]

fixes#11679

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[ksvirkou-hubspot]

@TiFu@taxpon@sebastianhaas@kenisteward@Vrolijkx@macjohnny@topce@akehir@petejohansonxo@amakhrov

[macjohnny]

thanks for your contribution!

[macjohnny]

some unit tests would be nice in https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/TypeScriptClientCodegenTest.java

[ksvirkou-hubspot]

there are some tests https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/TypeScriptClientModelTest.java

[macjohnny]

can you add tests that are directly related to your code change? i.e. tests that would fail without your change.

[ksvirkou-hubspot]

Ok
I ll try to do something
but maybe it would be an example of this in the petstore and test there
I ll think over it

[akehir]

Would it make sense to have an example of this in the petstore yaml files? I've run in the bug myself, but it would be good to prevent regressions.

[macjohnny]

FYI see also #11719

[ksvirkou-hubspot]

Hi @macjohnny
I ve just tryed to add sample in the petstore but I can't build anything in the pestore
I see many errors
for example

The reason probably in this PR
code base was updated but sapmes don’t work
there are necessary update typescript version and fix some code
for example ?.was added in ts 3.7
but in package set "typescript": "^2.4.1"
that is why I can’t add tests
any ideas how to resolve it?

[macjohnny]

@ksvirkou-hubspot we recently dropped support for typescript below 4, see #12123

[ksvirkou-hubspot]

@macjohnny
This PR updated builds and mustaches but it didn't update tests
for example
"typescript": "^2.4.1"
https://github.com/OpenAPITools/openapi-generator/blob/master/samples/openapi3/client/petstore/typescript/tests/default/package.json

[macjohnny]

I wonder whether they are executed on the CI at all.
Do you want to update the tests and check their execution?

[ksvirkou-hubspot]

I wonder whether they are executed on the CI at all. Do you want to update the tests and check their execution?

No I have no time sorry
And I don’t know how to add here test
I ve try to add sample but now code changed and this function isn't use
we can close this pr but if the code will changed again we will have a problem