[ALL][CLIENT] Fix serialization for query params specified by ref

[sorin-florea]

Fixes#907

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[sorin-florea]

@wing328

[sorin-florea]

@wing328 pinging you again

[sorin-florea]

cc @bbdouglas@sreeshas@jfiala@lukoyanov@cbornet@jeff9finger@karismann@Zomzog@lwlee2608

[guylabs]

Hi,

Any update on this pull request? Would it be possible to add it to another upcoming 6.0.0 beta release?

Thanks and regards.

[wing328]

@sorin-florea thanks for the PR. Please resolve the merge conflicts when you've time.

[wing328]

Please also merge the latest master into your branch when you've time. Thank you.

[sorin-florea]

@wing328 done. Can you please re-review it?

[wing328]

@sorin-florea I tested with modules/openapi-generator/src/test/resources/3_0/issue907.yaml and noticed the following changes in openapi.yaml:

diff --git a/api/openapi.yaml b/api/openapi.yaml
index 998b576..cba8256 100644
--- a/api/openapi.yaml+++ b/api/openapi.yaml@@ -17,12 +17,33 @@ paths:
schema:
type: string
style: simple
- - explode: true+ - $ref: '#/components/schemas/BuildQuery'+ explode: true
in: query
name: BuildQuery
required: false
schema:
- $ref: '#/components/schemas/BuildQuery'+ properties:+ integerProp:+ format: int32+ minimum: 0+ type: integer+ stringProp:+ minLength: 1+ type: string+ booleanProp:+ type: boolean+ arrayProp:+ items:+ minLength: 1+ type: string+ type: array+ objectProp:+ type: object+ numberProp:+ minimum: 0+ type: number+ type: object
style: form
responses:
"200":

In the past few days, we've merged a few PRs to improve the inline model resolver that are doing it the other way around by creating the inline schemas separately and referencing it instead.

Can we keep $ref as it's instead expanding it into the actual schema?

(I'm working on a PR to improve the inline model resolver so that inline schemas defined in the parameters are created separately and referenced using $ref instead)

I'm free in the afternoon (next couple of hours) so feel free to DM me via Slack to discuss this further.

Thanks again for the PR.

Inline model resolver-related PRs merged recently:

• [Inline model resolver] minor enhancements/refactoring #12175
• New option to map inline schema names #12237
• [Inline model resolver] various improvements #12293
• Fix inline allOf in request body #12348
• [Inline model resolver] better handling of inline responses and bug fixes #12353

[wing328]

One more thing to add is that I don't see changes to the Java classes that fix the serialization for query parameter issue:

➜ java-query git:(master) ✗ git status
On branch master
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: .openapi-generator/FILES
modified: README.md
modified: api/openapi.yaml
modified: docs/DefaultApi.md
modified: src/main/java/org/openapitools/client/ApiException.java
modified: src/main/java/org/openapitools/client/Configuration.java
modified: src/main/java/org/openapitools/client/Pair.java
modified: src/main/java/org/openapitools/client/StringUtil.java
modified: src/main/java/org/openapitools/client/auth/ApiKeyAuth.java
modified: src/main/java/org/openapitools/client/auth/HttpBearerAuth.java
modified: src/main/java/org/openapitools/client/model/AbstractOpenApiSchema.java
modified: src/main/java/org/openapitools/client/model/BuildQuery.java
modified: src/main/java/org/openapitools/client/model/SomeReturnValue.java

All the changes to the Java files are due to timestamps change, e.g.

diff --git a/src/main/java/org/openapitools/client/model/BuildQuery.java b/src/main/java/org/openapitools/client/model/BuildQuery.java
index f6fd90d..518a520 100644
--- a/src/main/java/org/openapitools/client/model/BuildQuery.java+++ b/src/main/java/org/openapitools/client/model/BuildQuery.java@@ -50,7 +50,7 @@ import org.openapitools.client.JSON;
/**
* BuildQuery
*/
-@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaClientCodegen", date = "2022-05-13T13:18:02.304890+08:00[Asia/Hong_Kong]")+@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaClientCodegen", date = "2022-05-13T13:21:16.933465+08:00[Asia/Hong_Kong]")
public class BuildQuery {
public static final String SERIALIZED_NAME_INTEGER_PROP = "integerProp";
@SerializedName(SERIALIZED_NAME_INTEGER_PROP)

[wing328]

FYI. The issue is addressed by #12369 instead.

[newmen]

As I see, the original PR from @sorin-florea was not merged.
Instead, you referred to #12369, which is clearly not exactly the same as what @sorin-florea did. For example, I don't see the test that was added in #11864 (for issue 907) and nothing same in the master.

@wing328 could you please , instead of an incomprehensible link to another PR, somehow summarize the decision on this fix? Which version contains similar one?

[sorin-florea]

Fixes#907

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[sorin-florea]

@wing328

[sorin-florea]

@wing328 pinging you again

[sorin-florea]

cc @bbdouglas@sreeshas@jfiala@lukoyanov@cbornet@jeff9finger@karismann@Zomzog@lwlee2608

[guylabs]

Hi,

Any update on this pull request? Would it be possible to add it to another upcoming 6.0.0 beta release?

Thanks and regards.

[wing328]

@sorin-florea thanks for the PR. Please resolve the merge conflicts when you've time.

[wing328]

Please also merge the latest master into your branch when you've time. Thank you.

[sorin-florea]

@wing328 done. Can you please re-review it?

[wing328]

@sorin-florea I tested with modules/openapi-generator/src/test/resources/3_0/issue907.yaml and noticed the following changes in openapi.yaml:

diff --git a/api/openapi.yaml b/api/openapi.yaml
index 998b576..cba8256 100644
--- a/api/openapi.yaml+++ b/api/openapi.yaml@@ -17,12 +17,33 @@ paths:
schema:
type: string
style: simple
- - explode: true+ - $ref: '#/components/schemas/BuildQuery'+ explode: true
in: query
name: BuildQuery
required: false
schema:
- $ref: '#/components/schemas/BuildQuery'+ properties:+ integerProp:+ format: int32+ minimum: 0+ type: integer+ stringProp:+ minLength: 1+ type: string+ booleanProp:+ type: boolean+ arrayProp:+ items:+ minLength: 1+ type: string+ type: array+ objectProp:+ type: object+ numberProp:+ minimum: 0+ type: number+ type: object
style: form
responses:
"200":

In the past few days, we've merged a few PRs to improve the inline model resolver that are doing it the other way around by creating the inline schemas separately and referencing it instead.

Can we keep $ref as it's instead expanding it into the actual schema?

(I'm working on a PR to improve the inline model resolver so that inline schemas defined in the parameters are created separately and referenced using $ref instead)

I'm free in the afternoon (next couple of hours) so feel free to DM me via Slack to discuss this further.

Thanks again for the PR.

Inline model resolver-related PRs merged recently:

• [Inline model resolver] minor enhancements/refactoring #12175
• New option to map inline schema names #12237
• [Inline model resolver] various improvements #12293
• Fix inline allOf in request body #12348
• [Inline model resolver] better handling of inline responses and bug fixes #12353

[wing328]

One more thing to add is that I don't see changes to the Java classes that fix the serialization for query parameter issue:

➜ java-query git:(master) ✗ git status
On branch master
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: .openapi-generator/FILES
modified: README.md
modified: api/openapi.yaml
modified: docs/DefaultApi.md
modified: src/main/java/org/openapitools/client/ApiException.java
modified: src/main/java/org/openapitools/client/Configuration.java
modified: src/main/java/org/openapitools/client/Pair.java
modified: src/main/java/org/openapitools/client/StringUtil.java
modified: src/main/java/org/openapitools/client/auth/ApiKeyAuth.java
modified: src/main/java/org/openapitools/client/auth/HttpBearerAuth.java
modified: src/main/java/org/openapitools/client/model/AbstractOpenApiSchema.java
modified: src/main/java/org/openapitools/client/model/BuildQuery.java
modified: src/main/java/org/openapitools/client/model/SomeReturnValue.java

All the changes to the Java files are due to timestamps change, e.g.

diff --git a/src/main/java/org/openapitools/client/model/BuildQuery.java b/src/main/java/org/openapitools/client/model/BuildQuery.java
index f6fd90d..518a520 100644
--- a/src/main/java/org/openapitools/client/model/BuildQuery.java+++ b/src/main/java/org/openapitools/client/model/BuildQuery.java@@ -50,7 +50,7 @@ import org.openapitools.client.JSON;
/**
* BuildQuery
*/
-@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaClientCodegen", date = "2022-05-13T13:18:02.304890+08:00[Asia/Hong_Kong]")+@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaClientCodegen", date = "2022-05-13T13:21:16.933465+08:00[Asia/Hong_Kong]")
public class BuildQuery {
public static final String SERIALIZED_NAME_INTEGER_PROP = "integerProp";
@SerializedName(SERIALIZED_NAME_INTEGER_PROP)

[wing328]

FYI. The issue is addressed by #12369 instead.

[newmen]

As I see, the original PR from @sorin-florea was not merged.
Instead, you referred to #12369, which is clearly not exactly the same as what @sorin-florea did. For example, I don't see the test that was added in #11864 (for issue 907) and nothing same in the master.

@wing328 could you please , instead of an incomprehensible link to another PR, somehow summarize the decision on this fix? Which version contains similar one?

[sorin-florea]

Fixes#907

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[sorin-florea]

@wing328

[sorin-florea]

@wing328 pinging you again

[sorin-florea]

cc @bbdouglas@sreeshas@jfiala@lukoyanov@cbornet@jeff9finger@karismann@Zomzog@lwlee2608

[guylabs]

Hi,

Any update on this pull request? Would it be possible to add it to another upcoming 6.0.0 beta release?

Thanks and regards.

[wing328]

@sorin-florea thanks for the PR. Please resolve the merge conflicts when you've time.

[wing328]

Please also merge the latest master into your branch when you've time. Thank you.

[sorin-florea]

@wing328 done. Can you please re-review it?

[wing328]

@sorin-florea I tested with modules/openapi-generator/src/test/resources/3_0/issue907.yaml and noticed the following changes in openapi.yaml:

diff --git a/api/openapi.yaml b/api/openapi.yaml
index 998b576..cba8256 100644
--- a/api/openapi.yaml+++ b/api/openapi.yaml@@ -17,12 +17,33 @@ paths:
schema:
type: string
style: simple
- - explode: true+ - $ref: '#/components/schemas/BuildQuery'+ explode: true
in: query
name: BuildQuery
required: false
schema:
- $ref: '#/components/schemas/BuildQuery'+ properties:+ integerProp:+ format: int32+ minimum: 0+ type: integer+ stringProp:+ minLength: 1+ type: string+ booleanProp:+ type: boolean+ arrayProp:+ items:+ minLength: 1+ type: string+ type: array+ objectProp:+ type: object+ numberProp:+ minimum: 0+ type: number+ type: object
style: form
responses:
"200":

In the past few days, we've merged a few PRs to improve the inline model resolver that are doing it the other way around by creating the inline schemas separately and referencing it instead.

Can we keep $ref as it's instead expanding it into the actual schema?

(I'm working on a PR to improve the inline model resolver so that inline schemas defined in the parameters are created separately and referenced using $ref instead)

I'm free in the afternoon (next couple of hours) so feel free to DM me via Slack to discuss this further.

Thanks again for the PR.

Inline model resolver-related PRs merged recently:

• [Inline model resolver] minor enhancements/refactoring #12175
• New option to map inline schema names #12237
• [Inline model resolver] various improvements #12293
• Fix inline allOf in request body #12348
• [Inline model resolver] better handling of inline responses and bug fixes #12353

[wing328]

One more thing to add is that I don't see changes to the Java classes that fix the serialization for query parameter issue:

➜ java-query git:(master) ✗ git status
On branch master
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: .openapi-generator/FILES
modified: README.md
modified: api/openapi.yaml
modified: docs/DefaultApi.md
modified: src/main/java/org/openapitools/client/ApiException.java
modified: src/main/java/org/openapitools/client/Configuration.java
modified: src/main/java/org/openapitools/client/Pair.java
modified: src/main/java/org/openapitools/client/StringUtil.java
modified: src/main/java/org/openapitools/client/auth/ApiKeyAuth.java
modified: src/main/java/org/openapitools/client/auth/HttpBearerAuth.java
modified: src/main/java/org/openapitools/client/model/AbstractOpenApiSchema.java
modified: src/main/java/org/openapitools/client/model/BuildQuery.java
modified: src/main/java/org/openapitools/client/model/SomeReturnValue.java

All the changes to the Java files are due to timestamps change, e.g.

diff --git a/src/main/java/org/openapitools/client/model/BuildQuery.java b/src/main/java/org/openapitools/client/model/BuildQuery.java
index f6fd90d..518a520 100644
--- a/src/main/java/org/openapitools/client/model/BuildQuery.java+++ b/src/main/java/org/openapitools/client/model/BuildQuery.java@@ -50,7 +50,7 @@ import org.openapitools.client.JSON;
/**
* BuildQuery
*/
-@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaClientCodegen", date = "2022-05-13T13:18:02.304890+08:00[Asia/Hong_Kong]")+@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaClientCodegen", date = "2022-05-13T13:21:16.933465+08:00[Asia/Hong_Kong]")
public class BuildQuery {
public static final String SERIALIZED_NAME_INTEGER_PROP = "integerProp";
@SerializedName(SERIALIZED_NAME_INTEGER_PROP)

[wing328]

FYI. The issue is addressed by #12369 instead.

[newmen]

As I see, the original PR from @sorin-florea was not merged.
Instead, you referred to #12369, which is clearly not exactly the same as what @sorin-florea did. For example, I don't see the test that was added in #11864 (for issue 907) and nothing same in the master.

@wing328 could you please , instead of an incomprehensible link to another PR, somehow summarize the decision on this fix? Which version contains similar one?

[sorin-florea]

Fixes#907

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[sorin-florea]

@wing328

[sorin-florea]

@wing328 pinging you again

[sorin-florea]

cc @bbdouglas@sreeshas@jfiala@lukoyanov@cbornet@jeff9finger@karismann@Zomzog@lwlee2608

[guylabs]

Hi,

Any update on this pull request? Would it be possible to add it to another upcoming 6.0.0 beta release?

Thanks and regards.

[wing328]

@sorin-florea thanks for the PR. Please resolve the merge conflicts when you've time.

[wing328]

Please also merge the latest master into your branch when you've time. Thank you.

[sorin-florea]

@wing328 done. Can you please re-review it?

[wing328]

@sorin-florea I tested with modules/openapi-generator/src/test/resources/3_0/issue907.yaml and noticed the following changes in openapi.yaml:

diff --git a/api/openapi.yaml b/api/openapi.yaml
index 998b576..cba8256 100644
--- a/api/openapi.yaml+++ b/api/openapi.yaml@@ -17,12 +17,33 @@ paths:
schema:
type: string
style: simple
- - explode: true+ - $ref: '#/components/schemas/BuildQuery'+ explode: true
in: query
name: BuildQuery
required: false
schema:
- $ref: '#/components/schemas/BuildQuery'+ properties:+ integerProp:+ format: int32+ minimum: 0+ type: integer+ stringProp:+ minLength: 1+ type: string+ booleanProp:+ type: boolean+ arrayProp:+ items:+ minLength: 1+ type: string+ type: array+ objectProp:+ type: object+ numberProp:+ minimum: 0+ type: number+ type: object
style: form
responses:
"200":

In the past few days, we've merged a few PRs to improve the inline model resolver that are doing it the other way around by creating the inline schemas separately and referencing it instead.

Can we keep $ref as it's instead expanding it into the actual schema?

(I'm working on a PR to improve the inline model resolver so that inline schemas defined in the parameters are created separately and referenced using $ref instead)

I'm free in the afternoon (next couple of hours) so feel free to DM me via Slack to discuss this further.

Thanks again for the PR.

Inline model resolver-related PRs merged recently:

• [Inline model resolver] minor enhancements/refactoring #12175
• New option to map inline schema names #12237
• [Inline model resolver] various improvements #12293
• Fix inline allOf in request body #12348
• [Inline model resolver] better handling of inline responses and bug fixes #12353

[wing328]

One more thing to add is that I don't see changes to the Java classes that fix the serialization for query parameter issue:

➜ java-query git:(master) ✗ git status
On branch master
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: .openapi-generator/FILES
modified: README.md
modified: api/openapi.yaml
modified: docs/DefaultApi.md
modified: src/main/java/org/openapitools/client/ApiException.java
modified: src/main/java/org/openapitools/client/Configuration.java
modified: src/main/java/org/openapitools/client/Pair.java
modified: src/main/java/org/openapitools/client/StringUtil.java
modified: src/main/java/org/openapitools/client/auth/ApiKeyAuth.java
modified: src/main/java/org/openapitools/client/auth/HttpBearerAuth.java
modified: src/main/java/org/openapitools/client/model/AbstractOpenApiSchema.java
modified: src/main/java/org/openapitools/client/model/BuildQuery.java
modified: src/main/java/org/openapitools/client/model/SomeReturnValue.java

All the changes to the Java files are due to timestamps change, e.g.

diff --git a/src/main/java/org/openapitools/client/model/BuildQuery.java b/src/main/java/org/openapitools/client/model/BuildQuery.java
index f6fd90d..518a520 100644
--- a/src/main/java/org/openapitools/client/model/BuildQuery.java+++ b/src/main/java/org/openapitools/client/model/BuildQuery.java@@ -50,7 +50,7 @@ import org.openapitools.client.JSON;
/**
* BuildQuery
*/
-@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaClientCodegen", date = "2022-05-13T13:18:02.304890+08:00[Asia/Hong_Kong]")+@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaClientCodegen", date = "2022-05-13T13:21:16.933465+08:00[Asia/Hong_Kong]")
public class BuildQuery {
public static final String SERIALIZED_NAME_INTEGER_PROP = "integerProp";
@SerializedName(SERIALIZED_NAME_INTEGER_PROP)

[wing328]

FYI. The issue is addressed by #12369 instead.

[newmen]

As I see, the original PR from @sorin-florea was not merged.
Instead, you referred to #12369, which is clearly not exactly the same as what @sorin-florea did. For example, I don't see the test that was added in #11864 (for issue 907) and nothing same in the master.

@wing328 could you please , instead of an incomprehensible link to another PR, somehow summarize the decision on this fix? Which version contains similar one?

[sorin-florea]

Fixes#907

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[sorin-florea]

@wing328

[sorin-florea]

@wing328 pinging you again

[sorin-florea]

cc @bbdouglas@sreeshas@jfiala@lukoyanov@cbornet@jeff9finger@karismann@Zomzog@lwlee2608

[guylabs]

Hi,

Any update on this pull request? Would it be possible to add it to another upcoming 6.0.0 beta release?

Thanks and regards.

[wing328]

@sorin-florea thanks for the PR. Please resolve the merge conflicts when you've time.

[wing328]

Please also merge the latest master into your branch when you've time. Thank you.

[sorin-florea]

@wing328 done. Can you please re-review it?

[wing328]

@sorin-florea I tested with modules/openapi-generator/src/test/resources/3_0/issue907.yaml and noticed the following changes in openapi.yaml:

diff --git a/api/openapi.yaml b/api/openapi.yaml
index 998b576..cba8256 100644
--- a/api/openapi.yaml+++ b/api/openapi.yaml@@ -17,12 +17,33 @@ paths:
schema:
type: string
style: simple
- - explode: true+ - $ref: '#/components/schemas/BuildQuery'+ explode: true
in: query
name: BuildQuery
required: false
schema:
- $ref: '#/components/schemas/BuildQuery'+ properties:+ integerProp:+ format: int32+ minimum: 0+ type: integer+ stringProp:+ minLength: 1+ type: string+ booleanProp:+ type: boolean+ arrayProp:+ items:+ minLength: 1+ type: string+ type: array+ objectProp:+ type: object+ numberProp:+ minimum: 0+ type: number+ type: object
style: form
responses:
"200":

In the past few days, we've merged a few PRs to improve the inline model resolver that are doing it the other way around by creating the inline schemas separately and referencing it instead.

Can we keep $ref as it's instead expanding it into the actual schema?

(I'm working on a PR to improve the inline model resolver so that inline schemas defined in the parameters are created separately and referenced using $ref instead)

I'm free in the afternoon (next couple of hours) so feel free to DM me via Slack to discuss this further.

Thanks again for the PR.

Inline model resolver-related PRs merged recently:

• [Inline model resolver] minor enhancements/refactoring #12175
• New option to map inline schema names #12237
• [Inline model resolver] various improvements #12293
• Fix inline allOf in request body #12348
• [Inline model resolver] better handling of inline responses and bug fixes #12353

[wing328]

One more thing to add is that I don't see changes to the Java classes that fix the serialization for query parameter issue:

➜ java-query git:(master) ✗ git status
On branch master
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: .openapi-generator/FILES
modified: README.md
modified: api/openapi.yaml
modified: docs/DefaultApi.md
modified: src/main/java/org/openapitools/client/ApiException.java
modified: src/main/java/org/openapitools/client/Configuration.java
modified: src/main/java/org/openapitools/client/Pair.java
modified: src/main/java/org/openapitools/client/StringUtil.java
modified: src/main/java/org/openapitools/client/auth/ApiKeyAuth.java
modified: src/main/java/org/openapitools/client/auth/HttpBearerAuth.java
modified: src/main/java/org/openapitools/client/model/AbstractOpenApiSchema.java
modified: src/main/java/org/openapitools/client/model/BuildQuery.java
modified: src/main/java/org/openapitools/client/model/SomeReturnValue.java

All the changes to the Java files are due to timestamps change, e.g.

diff --git a/src/main/java/org/openapitools/client/model/BuildQuery.java b/src/main/java/org/openapitools/client/model/BuildQuery.java
index f6fd90d..518a520 100644
--- a/src/main/java/org/openapitools/client/model/BuildQuery.java+++ b/src/main/java/org/openapitools/client/model/BuildQuery.java@@ -50,7 +50,7 @@ import org.openapitools.client.JSON;
/**
* BuildQuery
*/
-@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaClientCodegen", date = "2022-05-13T13:18:02.304890+08:00[Asia/Hong_Kong]")+@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaClientCodegen", date = "2022-05-13T13:21:16.933465+08:00[Asia/Hong_Kong]")
public class BuildQuery {
public static final String SERIALIZED_NAME_INTEGER_PROP = "integerProp";
@SerializedName(SERIALIZED_NAME_INTEGER_PROP)

[wing328]

FYI. The issue is addressed by #12369 instead.

[newmen]

As I see, the original PR from @sorin-florea was not merged.
Instead, you referred to #12369, which is clearly not exactly the same as what @sorin-florea did. For example, I don't see the test that was added in #11864 (for issue 907) and nothing same in the master.

@wing328 could you please , instead of an incomprehensible link to another PR, somehow summarize the decision on this fix? Which version contains similar one?

[sorin-florea]

Fixes#907

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[sorin-florea]

@wing328

[sorin-florea]

@wing328 pinging you again

[sorin-florea]

cc @bbdouglas@sreeshas@jfiala@lukoyanov@cbornet@jeff9finger@karismann@Zomzog@lwlee2608

[guylabs]

Hi,

Any update on this pull request? Would it be possible to add it to another upcoming 6.0.0 beta release?

Thanks and regards.

[wing328]

@sorin-florea thanks for the PR. Please resolve the merge conflicts when you've time.

[wing328]

Please also merge the latest master into your branch when you've time. Thank you.

[sorin-florea]

@wing328 done. Can you please re-review it?

[wing328]

@sorin-florea I tested with modules/openapi-generator/src/test/resources/3_0/issue907.yaml and noticed the following changes in openapi.yaml:

diff --git a/api/openapi.yaml b/api/openapi.yaml
index 998b576..cba8256 100644
--- a/api/openapi.yaml+++ b/api/openapi.yaml@@ -17,12 +17,33 @@ paths:
schema:
type: string
style: simple
- - explode: true+ - $ref: '#/components/schemas/BuildQuery'+ explode: true
in: query
name: BuildQuery
required: false
schema:
- $ref: '#/components/schemas/BuildQuery'+ properties:+ integerProp:+ format: int32+ minimum: 0+ type: integer+ stringProp:+ minLength: 1+ type: string+ booleanProp:+ type: boolean+ arrayProp:+ items:+ minLength: 1+ type: string+ type: array+ objectProp:+ type: object+ numberProp:+ minimum: 0+ type: number+ type: object
style: form
responses:
"200":

In the past few days, we've merged a few PRs to improve the inline model resolver that are doing it the other way around by creating the inline schemas separately and referencing it instead.

Can we keep $ref as it's instead expanding it into the actual schema?

(I'm working on a PR to improve the inline model resolver so that inline schemas defined in the parameters are created separately and referenced using $ref instead)

I'm free in the afternoon (next couple of hours) so feel free to DM me via Slack to discuss this further.

Thanks again for the PR.

Inline model resolver-related PRs merged recently:

• [Inline model resolver] minor enhancements/refactoring #12175
• New option to map inline schema names #12237
• [Inline model resolver] various improvements #12293
• Fix inline allOf in request body #12348
• [Inline model resolver] better handling of inline responses and bug fixes #12353

[wing328]

One more thing to add is that I don't see changes to the Java classes that fix the serialization for query parameter issue:

➜ java-query git:(master) ✗ git status
On branch master
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: .openapi-generator/FILES
modified: README.md
modified: api/openapi.yaml
modified: docs/DefaultApi.md
modified: src/main/java/org/openapitools/client/ApiException.java
modified: src/main/java/org/openapitools/client/Configuration.java
modified: src/main/java/org/openapitools/client/Pair.java
modified: src/main/java/org/openapitools/client/StringUtil.java
modified: src/main/java/org/openapitools/client/auth/ApiKeyAuth.java
modified: src/main/java/org/openapitools/client/auth/HttpBearerAuth.java
modified: src/main/java/org/openapitools/client/model/AbstractOpenApiSchema.java
modified: src/main/java/org/openapitools/client/model/BuildQuery.java
modified: src/main/java/org/openapitools/client/model/SomeReturnValue.java

All the changes to the Java files are due to timestamps change, e.g.

diff --git a/src/main/java/org/openapitools/client/model/BuildQuery.java b/src/main/java/org/openapitools/client/model/BuildQuery.java
index f6fd90d..518a520 100644
--- a/src/main/java/org/openapitools/client/model/BuildQuery.java+++ b/src/main/java/org/openapitools/client/model/BuildQuery.java@@ -50,7 +50,7 @@ import org.openapitools.client.JSON;
/**
* BuildQuery
*/
-@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaClientCodegen", date = "2022-05-13T13:18:02.304890+08:00[Asia/Hong_Kong]")+@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaClientCodegen", date = "2022-05-13T13:21:16.933465+08:00[Asia/Hong_Kong]")
public class BuildQuery {
public static final String SERIALIZED_NAME_INTEGER_PROP = "integerProp";
@SerializedName(SERIALIZED_NAME_INTEGER_PROP)

[wing328]

FYI. The issue is addressed by #12369 instead.

[newmen]

As I see, the original PR from @sorin-florea was not merged.
Instead, you referred to #12369, which is clearly not exactly the same as what @sorin-florea did. For example, I don't see the test that was added in #11864 (for issue 907) and nothing same in the master.

@wing328 could you please , instead of an incomprehensible link to another PR, somehow summarize the decision on this fix? Which version contains similar one?

[sorin-florea]

Fixes#907

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[sorin-florea]

@wing328

[sorin-florea]

@wing328 pinging you again

[sorin-florea]

cc @bbdouglas@sreeshas@jfiala@lukoyanov@cbornet@jeff9finger@karismann@Zomzog@lwlee2608

[guylabs]

Hi,

Any update on this pull request? Would it be possible to add it to another upcoming 6.0.0 beta release?

Thanks and regards.

[wing328]

@sorin-florea thanks for the PR. Please resolve the merge conflicts when you've time.

[wing328]

Please also merge the latest master into your branch when you've time. Thank you.

[sorin-florea]

@wing328 done. Can you please re-review it?

[wing328]

@sorin-florea I tested with modules/openapi-generator/src/test/resources/3_0/issue907.yaml and noticed the following changes in openapi.yaml:

diff --git a/api/openapi.yaml b/api/openapi.yaml
index 998b576..cba8256 100644
--- a/api/openapi.yaml+++ b/api/openapi.yaml@@ -17,12 +17,33 @@ paths:
schema:
type: string
style: simple
- - explode: true+ - $ref: '#/components/schemas/BuildQuery'+ explode: true
in: query
name: BuildQuery
required: false
schema:
- $ref: '#/components/schemas/BuildQuery'+ properties:+ integerProp:+ format: int32+ minimum: 0+ type: integer+ stringProp:+ minLength: 1+ type: string+ booleanProp:+ type: boolean+ arrayProp:+ items:+ minLength: 1+ type: string+ type: array+ objectProp:+ type: object+ numberProp:+ minimum: 0+ type: number+ type: object
style: form
responses:
"200":

In the past few days, we've merged a few PRs to improve the inline model resolver that are doing it the other way around by creating the inline schemas separately and referencing it instead.

Can we keep $ref as it's instead expanding it into the actual schema?

(I'm working on a PR to improve the inline model resolver so that inline schemas defined in the parameters are created separately and referenced using $ref instead)

I'm free in the afternoon (next couple of hours) so feel free to DM me via Slack to discuss this further.

Thanks again for the PR.

Inline model resolver-related PRs merged recently:

• [Inline model resolver] minor enhancements/refactoring #12175
• New option to map inline schema names #12237
• [Inline model resolver] various improvements #12293
• Fix inline allOf in request body #12348
• [Inline model resolver] better handling of inline responses and bug fixes #12353

[wing328]

One more thing to add is that I don't see changes to the Java classes that fix the serialization for query parameter issue:

➜ java-query git:(master) ✗ git status
On branch master
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: .openapi-generator/FILES
modified: README.md
modified: api/openapi.yaml
modified: docs/DefaultApi.md
modified: src/main/java/org/openapitools/client/ApiException.java
modified: src/main/java/org/openapitools/client/Configuration.java
modified: src/main/java/org/openapitools/client/Pair.java
modified: src/main/java/org/openapitools/client/StringUtil.java
modified: src/main/java/org/openapitools/client/auth/ApiKeyAuth.java
modified: src/main/java/org/openapitools/client/auth/HttpBearerAuth.java
modified: src/main/java/org/openapitools/client/model/AbstractOpenApiSchema.java
modified: src/main/java/org/openapitools/client/model/BuildQuery.java
modified: src/main/java/org/openapitools/client/model/SomeReturnValue.java

All the changes to the Java files are due to timestamps change, e.g.

diff --git a/src/main/java/org/openapitools/client/model/BuildQuery.java b/src/main/java/org/openapitools/client/model/BuildQuery.java
index f6fd90d..518a520 100644
--- a/src/main/java/org/openapitools/client/model/BuildQuery.java+++ b/src/main/java/org/openapitools/client/model/BuildQuery.java@@ -50,7 +50,7 @@ import org.openapitools.client.JSON;
/**
* BuildQuery
*/
-@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaClientCodegen", date = "2022-05-13T13:18:02.304890+08:00[Asia/Hong_Kong]")+@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaClientCodegen", date = "2022-05-13T13:21:16.933465+08:00[Asia/Hong_Kong]")
public class BuildQuery {
public static final String SERIALIZED_NAME_INTEGER_PROP = "integerProp";
@SerializedName(SERIALIZED_NAME_INTEGER_PROP)

[wing328]

FYI. The issue is addressed by #12369 instead.

[newmen]

As I see, the original PR from @sorin-florea was not merged.
Instead, you referred to #12369, which is clearly not exactly the same as what @sorin-florea did. For example, I don't see the test that was added in #11864 (for issue 907) and nothing same in the master.

@wing328 could you please , instead of an incomprehensible link to another PR, somehow summarize the decision on this fix? Which version contains similar one?

[sorin-florea]

Fixes#907

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master (5.3.0), 6.0.x
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[sorin-florea]

@wing328

[sorin-florea]

@wing328 pinging you again

[sorin-florea]

cc @bbdouglas@sreeshas@jfiala@lukoyanov@cbornet@jeff9finger@karismann@Zomzog@lwlee2608

[guylabs]

Hi,

Any update on this pull request? Would it be possible to add it to another upcoming 6.0.0 beta release?

Thanks and regards.

[wing328]

@sorin-florea thanks for the PR. Please resolve the merge conflicts when you've time.

[wing328]

Please also merge the latest master into your branch when you've time. Thank you.

[sorin-florea]

@wing328 done. Can you please re-review it?

[wing328]

@sorin-florea I tested with modules/openapi-generator/src/test/resources/3_0/issue907.yaml and noticed the following changes in openapi.yaml:

diff --git a/api/openapi.yaml b/api/openapi.yaml
index 998b576..cba8256 100644
--- a/api/openapi.yaml+++ b/api/openapi.yaml@@ -17,12 +17,33 @@ paths:
schema:
type: string
style: simple
- - explode: true+ - $ref: '#/components/schemas/BuildQuery'+ explode: true
in: query
name: BuildQuery
required: false
schema:
- $ref: '#/components/schemas/BuildQuery'+ properties:+ integerProp:+ format: int32+ minimum: 0+ type: integer+ stringProp:+ minLength: 1+ type: string+ booleanProp:+ type: boolean+ arrayProp:+ items:+ minLength: 1+ type: string+ type: array+ objectProp:+ type: object+ numberProp:+ minimum: 0+ type: number+ type: object
style: form
responses:
"200":

In the past few days, we've merged a few PRs to improve the inline model resolver that are doing it the other way around by creating the inline schemas separately and referencing it instead.

Can we keep $ref as it's instead expanding it into the actual schema?

(I'm working on a PR to improve the inline model resolver so that inline schemas defined in the parameters are created separately and referenced using $ref instead)

I'm free in the afternoon (next couple of hours) so feel free to DM me via Slack to discuss this further.

Thanks again for the PR.

Inline model resolver-related PRs merged recently:

• [Inline model resolver] minor enhancements/refactoring #12175
• New option to map inline schema names #12237
• [Inline model resolver] various improvements #12293
• Fix inline allOf in request body #12348
• [Inline model resolver] better handling of inline responses and bug fixes #12353

[wing328]

One more thing to add is that I don't see changes to the Java classes that fix the serialization for query parameter issue:

➜ java-query git:(master) ✗ git status
On branch master
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: .openapi-generator/FILES
modified: README.md
modified: api/openapi.yaml
modified: docs/DefaultApi.md
modified: src/main/java/org/openapitools/client/ApiException.java
modified: src/main/java/org/openapitools/client/Configuration.java
modified: src/main/java/org/openapitools/client/Pair.java
modified: src/main/java/org/openapitools/client/StringUtil.java
modified: src/main/java/org/openapitools/client/auth/ApiKeyAuth.java
modified: src/main/java/org/openapitools/client/auth/HttpBearerAuth.java
modified: src/main/java/org/openapitools/client/model/AbstractOpenApiSchema.java
modified: src/main/java/org/openapitools/client/model/BuildQuery.java
modified: src/main/java/org/openapitools/client/model/SomeReturnValue.java

All the changes to the Java files are due to timestamps change, e.g.

diff --git a/src/main/java/org/openapitools/client/model/BuildQuery.java b/src/main/java/org/openapitools/client/model/BuildQuery.java
index f6fd90d..518a520 100644
--- a/src/main/java/org/openapitools/client/model/BuildQuery.java+++ b/src/main/java/org/openapitools/client/model/BuildQuery.java@@ -50,7 +50,7 @@ import org.openapitools.client.JSON;
/**
* BuildQuery
*/
-@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaClientCodegen", date = "2022-05-13T13:18:02.304890+08:00[Asia/Hong_Kong]")+@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaClientCodegen", date = "2022-05-13T13:21:16.933465+08:00[Asia/Hong_Kong]")
public class BuildQuery {
public static final String SERIALIZED_NAME_INTEGER_PROP = "integerProp";
@SerializedName(SERIALIZED_NAME_INTEGER_PROP)

[wing328]

FYI. The issue is addressed by #12369 instead.

[newmen]

As I see, the original PR from @sorin-florea was not merged.
Instead, you referred to #12369, which is clearly not exactly the same as what @sorin-florea did. For example, I don't see the test that was added in #11864 (for issue 907) and nothing same in the master.

@wing328 could you please , instead of an incomprehensible link to another PR, somehow summarize the decision on this fix? Which version contains similar one?