Skip to content

[PHP] Fix username and password check - #1892

Merged
wing328 merged 9 commits into
OpenAPITools:masterfrom
jfastnacht:1408-php-username-empty-check
Mar 7, 2019
Merged

[PHP] Fix username and password check#1892
wing328 merged 9 commits into
OpenAPITools:masterfrom
jfastnacht:1408-php-username-empty-check

Conversation

@jfastnacht

@jfastnachtjfastnacht commented Jan 11, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Trying to fix the issue #1408 . Intermediate result, WIP.

Had some problems with the test under Windows 8.1, so it might need a little more than the usual review.

@jebentier@dkarlovi@mandrean@jfastnacht@ackintosh@ybelenko@renepardon

@auto-labelerauto-labelerBot added the WIP Work in Progress label Jan 11, 2019
@auto-labeler

auto-labelerBot commented Jan 11, 2019

Copy link
Copy Markdown

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@jfastnacht
jfastnachtforce-pushed the 1408-php-username-empty-check branch from 6edbbc7 to 8a8a258CompareJanuary 14, 2019 15:38
@jfastnacht

jfastnacht commented Jan 27, 2019

Copy link
Copy Markdown
ContributorAuthor

Sometimes the builds are breaking on incomprehensible, random points. Things should be fixed, but this PR goes further than only #1408.
There is a lot of File.separator usage in the PHP projects where it is unnecessary. In PHP you should always use /, even on Windows. There are probably more of these left in other PHP generator files.

I also had to apply the fix in #1863 to make the build work on WIndows, I haven't pushed these changes, since they are already part of the master-branch.

The original issue should be solved now, but I'm not sure if it would be a better idea to split up this PR into seperate issues to discuss and PRs to pull.

@jfastnachtjfastnacht mentioned this pull request Jan 28, 2019
Closed
@wing328

wing328 commented Jan 30, 2019

Copy link
Copy Markdown
Member

Sometimes the builds are breaking on incomprehensible, random points. Things should be fixed, but this PR goes further than only #1408.

Yup, especially weekend as we saw issues downloading dependencies from time to time. Restarting the job (close and reopen the PR) usually fixes the problem

@jfastnacht

jfastnacht commented Jan 30, 2019

Copy link
Copy Markdown
ContributorAuthor

Restarting the job (close and reopen the PR) usually fixes the problem

I didn't knew that you can restart it this way, thanks.

@jfastnachtjfastnacht reopened this Jan 30, 2019
@jfastnacht
Reverted path changes. Removed additional files in php petstore-secur…
c4b0884
…ity-test folder. Generated new samples.
@jfastnacht
Batch and Shell scripts modified to use the same specification files …
b623d77
…for sample generation. Sample files generated.
@jfastnacht
Input file path in PHP client batch file equalized with the input pat…
13eec4f
…h in the shell script file. Samples generated.
@jfastnacht
Added a missing bracket in the PHP client mustache template.
f8d5f91
@jfastnacht
AbstractPhpCodegen apiDocPath and modelDocPath creation adjusted to a…
e944cb9
…lways use slash instead of system seperator, since the values will just be used in Markdown files.
@jfastnacht
Unnecessary samples removed.
624cd3a
@jfastnacht
Fixed unnecessary diversions between Windows and Linux/Mac paths in P…
efecb97
…HP codegen.
@jfastnacht
New samples generated after rebase.
33c23f1
@jfastnacht
jfastnachtforce-pushed the 1408-php-username-empty-check branch from cc25f5b to 33c23f1CompareFebruary 13, 2019 13:27
@jfastnachtjfastnacht reopened this Feb 15, 2019
@wing328

wing328 commented Feb 18, 2019

Copy link
Copy Markdown
Member

@jfastnacht is this PR ready for review? If yes, I'll remove WIP from the label and the title.

@jfastnachtjfastnacht changed the title [WIP][PHP] Username checks #1408[PHP] Username checks #1408Feb 18, 2019
@jfastnacht

jfastnacht commented Feb 18, 2019

Copy link
Copy Markdown
ContributorAuthor

@wing328 tbh, this PR is a mess, because it changes much more than the initial issue states. Not sure if this would be okay anyways, otherwise I'll break it up into seperate issues and PRs.

@wing328

wing328 commented Mar 7, 2019

Copy link
Copy Markdown
Member

@jfastnacht I'd a look and I think it's acceptable as your fix is essentially just one line: https://github.com/OpenAPITools/openapi-generator/pull/1892/files#diff-076573ccfdac2ab5af4dc1813e5ccee3R584

@wing328wing328 removed the WIP Work in Progress label Mar 7, 2019
@wing328wing328 added this to the 4.0.0 milestone Mar 7, 2019
@wing328
wing328 merged commit c00a439 into OpenAPITools:masterMar 7, 2019
@wing328wing328 changed the title [PHP] Username checks #1408[PHP] Fix username and password checkMar 7, 2019
@wing328wing328 mentioned this pull request Mar 7, 2019
Closed
jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Mar 9, 2019
@jimschubert
Merge branch 'master' into rienafairefr-templating
a55eee6
* master: (758 commits)
Add support for free form requests (OpenAPITools#2288)
[typescript-rxjs] drop unneeded function wrapping (OpenAPITools#2332)
[typescript-fetch] Guard array mapping against undefined on optional array model properties (OpenAPITools#2324)
Fix regex in Python server model code (OpenAPITools#2314)
Add .travis.yml and Gemfile.lock to ruby security test folder (OpenAPITools#2330)
Add a link to CSDN article (OpenAPITools#2331)
[Maven] fix Spaces in Windows user path breaks build on test goal (OpenAPITools#2318)
[PHP] fix bad links in Model docs (OpenAPITools#2316)
[java]: fix datatype for non-multipart file request body (OpenAPITools#2271)
Removed JFCote from core team (OpenAPITools#2315)
[R sample] fix CircleCI error of outdated sample (OpenAPITools#2313)
[Java] Bean Validation for decimalmin/max incorrect when exclusive set (OpenAPITools#2115)
Java Spring : fix defaultValue annotation double quoted in api operation (OpenAPITools#2267)
Java RESTEASY : fix defaultValue annotation double quoted in api operation (OpenAPITools#2268)
[PHP] Username checks OpenAPITools#1408 (OpenAPITools#1892)
[typescript-fetch] remove namespaces in enums (OpenAPITools#2123)
[java-server-msf4j] fix and upgrade (OpenAPITools#2303)
fix test script path in CONTRIBUTING.md (OpenAPITools#2290)
Dart queryargs (OpenAPITools#2250)
add Blueplanet language (OpenAPITools#2184)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Client: PHPIssue: Bug

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jfastnacht@wing328@ybelenko
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[PHP] Fix username and password check by jfastnacht · Pull Request #1892 · OpenAPITools/openapi-generator · GitHub
Skip to content
[PHP] Fix username and password check - #1892
Merged
wing328 merged 9 commits into
OpenAPITools:masterfrom 
jfastnacht:1408-php-username-empty-check
Mar 7, 2019
Merged
[PHP] Fix username and password check#1892
wing328 merged 9 commits into
OpenAPITools:masterfrom 
jfastnacht:1408-php-username-empty-check
Conversation
@jfastnacht
@jfastnachtjfastnacht
commented
Jan 11, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  •  Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
Trying to fix the issue #1408 . Intermediate result, WIP.
Had some problems with the test under Windows 8.1, so it might need a little more than the usual review.
@jebentier@dkarlovi@mandrean@jfastnacht@ackintosh@ybelenko@renepardon
@auto-labelerauto-labelerBot
added
the 
WIP
Work in Progress
label
Jan 11, 2019
@auto-labeler
auto-labelerBot
commented
Jan 11, 2019

Copy link


Copy Markdown

👍 Thanks for opening this issue!

🏷 I have applied any labels matching special text in your issue.
The team will review the labels and make any necessary changes.
@jfastnacht
jfastnachtforce-pushed
the
1408-php-username-empty-check
branch
from
6edbbc7 to
8a8a258CompareJanuary 14, 2019 15:38
@jfastnacht
jfastnacht
commented
Jan 27, 2019

Copy link


Copy Markdown

ContributorAuthor
Sometimes the builds are breaking on incomprehensible, random points. Things should be fixed, but this PR goes further than only #1408.

There is a lot of File.separator usage in the PHP projects where it is unnecessary. In PHP you should always use /, even on Windows. There are probably more of these left in other PHP generator files.
I also had to apply the fix in #1863 to make the build work on WIndows, I haven't pushed these changes, since they are already part of the master-branch.
The original issue should be solved now, but I'm not sure if it would be a better idea to split up this PR into seperate issues to discuss and PRs to pull.
@jfastnachtjfastnacht
mentioned this pull request
Jan 28, 2019

Closed

@wing328
wing328
commented
Jan 30, 2019

Copy link


Copy Markdown

Member
Sometimes the builds are breaking on incomprehensible, random points. Things should be fixed, but this PR goes further than only #1408.
Yup, especially weekend as we saw issues downloading dependencies from time to time. Restarting the job (close and reopen the PR) usually fixes the problem
@jfastnacht
jfastnacht
commented
Jan 30, 2019

Copy link


Copy Markdown

ContributorAuthor
Restarting the job (close and reopen the PR) usually fixes the problem
I didn't knew that you can restart it this way, thanks.
@jfastnachtjfastnacht
reopened this
Jan 30, 2019
@jfastnacht
Reverted path changes. Removed additional files in php petstore-secur…
c4b0884
…ity-test folder. Generated new samples.
@jfastnacht
Batch and Shell scripts modified to use the same specification files …
b623d77
…for sample generation. Sample files generated.
@jfastnacht
Input file path in PHP client batch file equalized with the input pat…
13eec4f
…h in the shell script file. Samples generated.
@jfastnacht
Added a missing bracket in the PHP client mustache template.
f8d5f91
@jfastnacht
AbstractPhpCodegen apiDocPath and modelDocPath creation adjusted to a…
e944cb9
…lways use slash instead of system seperator, since the values will just be used in Markdown files.
@jfastnacht
Unnecessary samples removed.
624cd3a
@jfastnacht
Fixed unnecessary diversions between Windows and Linux/Mac paths in P…
efecb97
…HP codegen.
@jfastnacht
New samples generated after rebase.
33c23f1
@jfastnacht
jfastnachtforce-pushed
the
1408-php-username-empty-check
branch
from
cc25f5b to
33c23f1CompareFebruary 13, 2019 13:27
@jfastnachtjfastnacht
reopened this
Feb 15, 2019
@wing328
wing328
commented
Feb 18, 2019

Copy link


Copy Markdown

Member
@jfastnacht is this PR ready for review? If yes, I'll remove WIP from the label and the title.
@jfastnachtjfastnacht
changed the title
[WIP][PHP] Username checks #1408[PHP] Username checks #1408Feb 18, 2019
@jfastnacht
jfastnacht
commented
Feb 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@wing328 tbh, this PR is a mess, because it changes much more than the initial issue states. Not sure if this would be okay anyways, otherwise I'll break it up into seperate issues and PRs.
@wing328
wing328
commented
Mar 7, 2019

Copy link


Copy Markdown

Member
@jfastnacht I'd a look and I think it's acceptable as your fix is essentially just one line: https://github.com/OpenAPITools/openapi-generator/pull/1892/files#diff-076573ccfdac2ab5af4dc1813e5ccee3R584
@wing328wing328
removed
the 
WIP
Work in Progress
label
Mar 7, 2019
@wing328wing328
added this to the 4.0.0 milestone
Mar 7, 2019
@wing328
wing328
merged commit c00a439
into
OpenAPITools:masterMar 7, 2019
@wing328wing328
changed the title
[PHP] Username checks #1408[PHP] Fix username and password checkMar 7, 2019
@wing328wing328
mentioned this pull request
Mar 7, 2019

Closed

jimschubert added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Mar 9, 2019
@jimschubert
Merge branch 'master' into rienafairefr-templating
a55eee6
* master: (758 commits)
Add support for free form requests (OpenAPITools#2288)
[typescript-rxjs] drop unneeded function wrapping (OpenAPITools#2332)
[typescript-fetch] Guard array mapping against undefined on optional array model properties (OpenAPITools#2324)
Fix regex in Python server model code (OpenAPITools#2314)
Add .travis.yml and Gemfile.lock to ruby security test folder (OpenAPITools#2330)
Add a link to CSDN article (OpenAPITools#2331)
[Maven] fix Spaces in Windows user path breaks build on test goal (OpenAPITools#2318)
[PHP] fix bad links in Model docs (OpenAPITools#2316)
[java]: fix datatype for non-multipart file request body (OpenAPITools#2271)
Removed JFCote from core team (OpenAPITools#2315)
[R sample] fix CircleCI error of outdated sample (OpenAPITools#2313)
[Java] Bean Validation for decimalmin/max incorrect when exclusive set (OpenAPITools#2115)
Java Spring : fix defaultValue annotation double quoted in api operation (OpenAPITools#2267)
Java RESTEASY : fix defaultValue annotation double quoted in api operation (OpenAPITools#2268)
[PHP] Username checks OpenAPITools#1408 (OpenAPITools#1892)
[typescript-fetch] remove namespaces in enums (OpenAPITools#2123)
[java-server-msf4j] fix and upgrade (OpenAPITools#2303)
fix test script path in CONTRIBUTING.md (OpenAPITools#2290)
Dart queryargs (OpenAPITools#2250)
add Blueplanet language (OpenAPITools#2184)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: PHPIssue: Bug

Projects


None yet


Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jfastnacht@wing328@ybelenko

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[PHP] Fix username and password check by jfastnacht · Pull Request #1892 · OpenAPITools/openapi-generator · GitHub
Skip to content
[PHP] Fix username and password check - #1892
Merged
wing328 merged 9 commits into
OpenAPITools:masterfrom 
jfastnacht:1408-php-username-empty-check
Mar 7, 2019
Merged
[PHP] Fix username and password check#1892
wing328 merged 9 commits into
OpenAPITools:masterfrom 
jfastnacht:1408-php-username-empty-check
Conversation
@jfastnacht
@jfastnachtjfastnacht
commented
Jan 11, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  •  Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
Trying to fix the issue #1408 . Intermediate result, WIP.
Had some problems with the test under Windows 8.1, so it might need a little more than the usual review.
@jebentier@dkarlovi@mandrean@jfastnacht@ackintosh@ybelenko@renepardon
@auto-labelerauto-labelerBot
added
the 
WIP
Work in Progress
label
Jan 11, 2019
@auto-labeler
auto-labelerBot
commented
Jan 11, 2019

Copy link


Copy Markdown

👍 Thanks for opening this issue!

🏷 I have applied any labels matching special text in your issue.
The team will review the labels and make any necessary changes.
@jfastnacht
jfastnachtforce-pushed
the
1408-php-username-empty-check
branch
from
6edbbc7 to
8a8a258CompareJanuary 14, 2019 15:38
@jfastnacht
jfastnacht
commented
Jan 27, 2019

Copy link


Copy Markdown

ContributorAuthor
Sometimes the builds are breaking on incomprehensible, random points. Things should be fixed, but this PR goes further than only #1408.

There is a lot of File.separator usage in the PHP projects where it is unnecessary. In PHP you should always use /, even on Windows. There are probably more of these left in other PHP generator files.
I also had to apply the fix in #1863 to make the build work on WIndows, I haven't pushed these changes, since they are already part of the master-branch.
The original issue should be solved now, but I'm not sure if it would be a better idea to split up this PR into seperate issues to discuss and PRs to pull.
@jfastnachtjfastnacht
mentioned this pull request
Jan 28, 2019

Closed

@wing328
wing328
commented
Jan 30, 2019

Copy link


Copy Markdown

Member
Sometimes the builds are breaking on incomprehensible, random points. Things should be fixed, but this PR goes further than only #1408.
Yup, especially weekend as we saw issues downloading dependencies from time to time. Restarting the job (close and reopen the PR) usually fixes the problem
@jfastnacht
jfastnacht
commented
Jan 30, 2019

Copy link


Copy Markdown

ContributorAuthor
Restarting the job (close and reopen the PR) usually fixes the problem
I didn't knew that you can restart it this way, thanks.
@jfastnachtjfastnacht
reopened this
Jan 30, 2019
@jfastnacht
Reverted path changes. Removed additional files in php petstore-secur…
c4b0884
…ity-test folder. Generated new samples.
@jfastnacht
Batch and Shell scripts modified to use the same specification files …
b623d77
…for sample generation. Sample files generated.
@jfastnacht
Input file path in PHP client batch file equalized with the input pat…
13eec4f
…h in the shell script file. Samples generated.
@jfastnacht
Added a missing bracket in the PHP client mustache template.
f8d5f91
@jfastnacht
AbstractPhpCodegen apiDocPath and modelDocPath creation adjusted to a…
e944cb9
…lways use slash instead of system seperator, since the values will just be used in Markdown files.
@jfastnacht
Unnecessary samples removed.
624cd3a
@jfastnacht
Fixed unnecessary diversions between Windows and Linux/Mac paths in P…
efecb97
…HP codegen.
@jfastnacht
New samples generated after rebase.
33c23f1
@jfastnacht
jfastnachtforce-pushed
the
1408-php-username-empty-check
branch
from
cc25f5b to
33c23f1CompareFebruary 13, 2019 13:27
@jfastnachtjfastnacht
reopened this
Feb 15, 2019
@wing328
wing328
commented
Feb 18, 2019

Copy link


Copy Markdown

Member
@jfastnacht is this PR ready for review? If yes, I'll remove WIP from the label and the title.
@jfastnachtjfastnacht
changed the title
[WIP][PHP] Username checks #1408[PHP] Username checks #1408Feb 18, 2019
@jfastnacht
jfastnacht
commented
Feb 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@wing328 tbh, this PR is a mess, because it changes much more than the initial issue states. Not sure if this would be okay anyways, otherwise I'll break it up into seperate issues and PRs.
@wing328
wing328
commented
Mar 7, 2019

Copy link


Copy Markdown

Member
@jfastnacht I'd a look and I think it's acceptable as your fix is essentially just one line: https://github.com/OpenAPITools/openapi-generator/pull/1892/files#diff-076573ccfdac2ab5af4dc1813e5ccee3R584
@wing328wing328
removed
the 
WIP
Work in Progress
label
Mar 7, 2019
@wing328wing328
added this to the 4.0.0 milestone
Mar 7, 2019
@wing328
wing328
merged commit c00a439
into
OpenAPITools:masterMar 7, 2019
@wing328wing328
changed the title
[PHP] Username checks #1408[PHP] Fix username and password checkMar 7, 2019
@wing328wing328
mentioned this pull request
Mar 7, 2019

Closed

jimschubert added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Mar 9, 2019
@jimschubert
Merge branch 'master' into rienafairefr-templating
a55eee6
* master: (758 commits)
Add support for free form requests (OpenAPITools#2288)
[typescript-rxjs] drop unneeded function wrapping (OpenAPITools#2332)
[typescript-fetch] Guard array mapping against undefined on optional array model properties (OpenAPITools#2324)
Fix regex in Python server model code (OpenAPITools#2314)
Add .travis.yml and Gemfile.lock to ruby security test folder (OpenAPITools#2330)
Add a link to CSDN article (OpenAPITools#2331)
[Maven] fix Spaces in Windows user path breaks build on test goal (OpenAPITools#2318)
[PHP] fix bad links in Model docs (OpenAPITools#2316)
[java]: fix datatype for non-multipart file request body (OpenAPITools#2271)
Removed JFCote from core team (OpenAPITools#2315)
[R sample] fix CircleCI error of outdated sample (OpenAPITools#2313)
[Java] Bean Validation for decimalmin/max incorrect when exclusive set (OpenAPITools#2115)
Java Spring : fix defaultValue annotation double quoted in api operation (OpenAPITools#2267)
Java RESTEASY : fix defaultValue annotation double quoted in api operation (OpenAPITools#2268)
[PHP] Username checks OpenAPITools#1408 (OpenAPITools#1892)
[typescript-fetch] remove namespaces in enums (OpenAPITools#2123)
[java-server-msf4j] fix and upgrade (OpenAPITools#2303)
fix test script path in CONTRIBUTING.md (OpenAPITools#2290)
Dart queryargs (OpenAPITools#2250)
add Blueplanet language (OpenAPITools#2184)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: PHPIssue: Bug

Projects


None yet


Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jfastnacht@wing328@ybelenko

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[PHP] Fix username and password check by jfastnacht · Pull Request #1892 · OpenAPITools/openapi-generator · GitHub
Skip to content
[PHP] Fix username and password check - #1892
Merged
wing328 merged 9 commits into
OpenAPITools:masterfrom 
jfastnacht:1408-php-username-empty-check
Mar 7, 2019
Merged
[PHP] Fix username and password check#1892
wing328 merged 9 commits into
OpenAPITools:masterfrom 
jfastnacht:1408-php-username-empty-check
Conversation
@jfastnacht
@jfastnachtjfastnacht
commented
Jan 11, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  •  Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
Trying to fix the issue #1408 . Intermediate result, WIP.
Had some problems with the test under Windows 8.1, so it might need a little more than the usual review.
@jebentier@dkarlovi@mandrean@jfastnacht@ackintosh@ybelenko@renepardon
@auto-labelerauto-labelerBot
added
the 
WIP
Work in Progress
label
Jan 11, 2019
@auto-labeler
auto-labelerBot
commented
Jan 11, 2019

Copy link


Copy Markdown

👍 Thanks for opening this issue!

🏷 I have applied any labels matching special text in your issue.
The team will review the labels and make any necessary changes.
@jfastnacht
jfastnachtforce-pushed
the
1408-php-username-empty-check
branch
from
6edbbc7 to
8a8a258CompareJanuary 14, 2019 15:38
@jfastnacht
jfastnacht
commented
Jan 27, 2019

Copy link


Copy Markdown

ContributorAuthor
Sometimes the builds are breaking on incomprehensible, random points. Things should be fixed, but this PR goes further than only #1408.

There is a lot of File.separator usage in the PHP projects where it is unnecessary. In PHP you should always use /, even on Windows. There are probably more of these left in other PHP generator files.
I also had to apply the fix in #1863 to make the build work on WIndows, I haven't pushed these changes, since they are already part of the master-branch.
The original issue should be solved now, but I'm not sure if it would be a better idea to split up this PR into seperate issues to discuss and PRs to pull.
@jfastnachtjfastnacht
mentioned this pull request
Jan 28, 2019

Closed

@wing328
wing328
commented
Jan 30, 2019

Copy link


Copy Markdown

Member
Sometimes the builds are breaking on incomprehensible, random points. Things should be fixed, but this PR goes further than only #1408.
Yup, especially weekend as we saw issues downloading dependencies from time to time. Restarting the job (close and reopen the PR) usually fixes the problem
@jfastnacht
jfastnacht
commented
Jan 30, 2019

Copy link


Copy Markdown

ContributorAuthor
Restarting the job (close and reopen the PR) usually fixes the problem
I didn't knew that you can restart it this way, thanks.
@jfastnachtjfastnacht
reopened this
Jan 30, 2019
@jfastnacht
Reverted path changes. Removed additional files in php petstore-secur…
c4b0884
…ity-test folder. Generated new samples.
@jfastnacht
Batch and Shell scripts modified to use the same specification files …
b623d77
…for sample generation. Sample files generated.
@jfastnacht
Input file path in PHP client batch file equalized with the input pat…
13eec4f
…h in the shell script file. Samples generated.
@jfastnacht
Added a missing bracket in the PHP client mustache template.
f8d5f91
@jfastnacht
AbstractPhpCodegen apiDocPath and modelDocPath creation adjusted to a…
e944cb9
…lways use slash instead of system seperator, since the values will just be used in Markdown files.
@jfastnacht
Unnecessary samples removed.
624cd3a
@jfastnacht
Fixed unnecessary diversions between Windows and Linux/Mac paths in P…
efecb97
…HP codegen.
@jfastnacht
New samples generated after rebase.
33c23f1
@jfastnacht
jfastnachtforce-pushed
the
1408-php-username-empty-check
branch
from
cc25f5b to
33c23f1CompareFebruary 13, 2019 13:27
@jfastnachtjfastnacht
reopened this
Feb 15, 2019
@wing328
wing328
commented
Feb 18, 2019

Copy link


Copy Markdown

Member
@jfastnacht is this PR ready for review? If yes, I'll remove WIP from the label and the title.
@jfastnachtjfastnacht
changed the title
[WIP][PHP] Username checks #1408[PHP] Username checks #1408Feb 18, 2019
@jfastnacht
jfastnacht
commented
Feb 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@wing328 tbh, this PR is a mess, because it changes much more than the initial issue states. Not sure if this would be okay anyways, otherwise I'll break it up into seperate issues and PRs.
@wing328
wing328
commented
Mar 7, 2019

Copy link


Copy Markdown

Member
@jfastnacht I'd a look and I think it's acceptable as your fix is essentially just one line: https://github.com/OpenAPITools/openapi-generator/pull/1892/files#diff-076573ccfdac2ab5af4dc1813e5ccee3R584
@wing328wing328
removed
the 
WIP
Work in Progress
label
Mar 7, 2019
@wing328wing328
added this to the 4.0.0 milestone
Mar 7, 2019
@wing328
wing328
merged commit c00a439
into
OpenAPITools:masterMar 7, 2019
@wing328wing328
changed the title
[PHP] Username checks #1408[PHP] Fix username and password checkMar 7, 2019
@wing328wing328
mentioned this pull request
Mar 7, 2019

Closed

jimschubert added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Mar 9, 2019
@jimschubert
Merge branch 'master' into rienafairefr-templating
a55eee6
* master: (758 commits)
Add support for free form requests (OpenAPITools#2288)
[typescript-rxjs] drop unneeded function wrapping (OpenAPITools#2332)
[typescript-fetch] Guard array mapping against undefined on optional array model properties (OpenAPITools#2324)
Fix regex in Python server model code (OpenAPITools#2314)
Add .travis.yml and Gemfile.lock to ruby security test folder (OpenAPITools#2330)
Add a link to CSDN article (OpenAPITools#2331)
[Maven] fix Spaces in Windows user path breaks build on test goal (OpenAPITools#2318)
[PHP] fix bad links in Model docs (OpenAPITools#2316)
[java]: fix datatype for non-multipart file request body (OpenAPITools#2271)
Removed JFCote from core team (OpenAPITools#2315)
[R sample] fix CircleCI error of outdated sample (OpenAPITools#2313)
[Java] Bean Validation for decimalmin/max incorrect when exclusive set (OpenAPITools#2115)
Java Spring : fix defaultValue annotation double quoted in api operation (OpenAPITools#2267)
Java RESTEASY : fix defaultValue annotation double quoted in api operation (OpenAPITools#2268)
[PHP] Username checks OpenAPITools#1408 (OpenAPITools#1892)
[typescript-fetch] remove namespaces in enums (OpenAPITools#2123)
[java-server-msf4j] fix and upgrade (OpenAPITools#2303)
fix test script path in CONTRIBUTING.md (OpenAPITools#2290)
Dart queryargs (OpenAPITools#2250)
add Blueplanet language (OpenAPITools#2184)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: PHPIssue: Bug

Projects


None yet


Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jfastnacht@wing328@ybelenko

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[PHP] Fix username and password check by jfastnacht · Pull Request #1892 · OpenAPITools/openapi-generator · GitHub
Skip to content
[PHP] Fix username and password check - #1892
Merged
wing328 merged 9 commits into
OpenAPITools:masterfrom 
jfastnacht:1408-php-username-empty-check
Mar 7, 2019
Merged
[PHP] Fix username and password check#1892
wing328 merged 9 commits into
OpenAPITools:masterfrom 
jfastnacht:1408-php-username-empty-check
Conversation
@jfastnacht
@jfastnachtjfastnacht
commented
Jan 11, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  •  Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
Trying to fix the issue #1408 . Intermediate result, WIP.
Had some problems with the test under Windows 8.1, so it might need a little more than the usual review.
@jebentier@dkarlovi@mandrean@jfastnacht@ackintosh@ybelenko@renepardon
@auto-labelerauto-labelerBot
added
the 
WIP
Work in Progress
label
Jan 11, 2019
@auto-labeler
auto-labelerBot
commented
Jan 11, 2019

Copy link


Copy Markdown

👍 Thanks for opening this issue!

🏷 I have applied any labels matching special text in your issue.
The team will review the labels and make any necessary changes.
@jfastnacht
jfastnachtforce-pushed
the
1408-php-username-empty-check
branch
from
6edbbc7 to
8a8a258CompareJanuary 14, 2019 15:38
@jfastnacht
jfastnacht
commented
Jan 27, 2019

Copy link


Copy Markdown

ContributorAuthor
Sometimes the builds are breaking on incomprehensible, random points. Things should be fixed, but this PR goes further than only #1408.

There is a lot of File.separator usage in the PHP projects where it is unnecessary. In PHP you should always use /, even on Windows. There are probably more of these left in other PHP generator files.
I also had to apply the fix in #1863 to make the build work on WIndows, I haven't pushed these changes, since they are already part of the master-branch.
The original issue should be solved now, but I'm not sure if it would be a better idea to split up this PR into seperate issues to discuss and PRs to pull.
@jfastnachtjfastnacht
mentioned this pull request
Jan 28, 2019

Closed

@wing328
wing328
commented
Jan 30, 2019

Copy link


Copy Markdown

Member
Sometimes the builds are breaking on incomprehensible, random points. Things should be fixed, but this PR goes further than only #1408.
Yup, especially weekend as we saw issues downloading dependencies from time to time. Restarting the job (close and reopen the PR) usually fixes the problem
@jfastnacht
jfastnacht
commented
Jan 30, 2019

Copy link


Copy Markdown

ContributorAuthor
Restarting the job (close and reopen the PR) usually fixes the problem
I didn't knew that you can restart it this way, thanks.
@jfastnachtjfastnacht
reopened this
Jan 30, 2019
@jfastnacht
Reverted path changes. Removed additional files in php petstore-secur…
c4b0884
…ity-test folder. Generated new samples.
@jfastnacht
Batch and Shell scripts modified to use the same specification files …
b623d77
…for sample generation. Sample files generated.
@jfastnacht
Input file path in PHP client batch file equalized with the input pat…
13eec4f
…h in the shell script file. Samples generated.
@jfastnacht
Added a missing bracket in the PHP client mustache template.
f8d5f91
@jfastnacht
AbstractPhpCodegen apiDocPath and modelDocPath creation adjusted to a…
e944cb9
…lways use slash instead of system seperator, since the values will just be used in Markdown files.
@jfastnacht
Unnecessary samples removed.
624cd3a
@jfastnacht
Fixed unnecessary diversions between Windows and Linux/Mac paths in P…
efecb97
…HP codegen.
@jfastnacht
New samples generated after rebase.
33c23f1
@jfastnacht
jfastnachtforce-pushed
the
1408-php-username-empty-check
branch
from
cc25f5b to
33c23f1CompareFebruary 13, 2019 13:27
@jfastnachtjfastnacht
reopened this
Feb 15, 2019
@wing328
wing328
commented
Feb 18, 2019

Copy link


Copy Markdown

Member
@jfastnacht is this PR ready for review? If yes, I'll remove WIP from the label and the title.
@jfastnachtjfastnacht
changed the title
[WIP][PHP] Username checks #1408[PHP] Username checks #1408Feb 18, 2019
@jfastnacht
jfastnacht
commented
Feb 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@wing328 tbh, this PR is a mess, because it changes much more than the initial issue states. Not sure if this would be okay anyways, otherwise I'll break it up into seperate issues and PRs.
@wing328
wing328
commented
Mar 7, 2019

Copy link


Copy Markdown

Member
@jfastnacht I'd a look and I think it's acceptable as your fix is essentially just one line: https://github.com/OpenAPITools/openapi-generator/pull/1892/files#diff-076573ccfdac2ab5af4dc1813e5ccee3R584
@wing328wing328
removed
the 
WIP
Work in Progress
label
Mar 7, 2019
@wing328wing328
added this to the 4.0.0 milestone
Mar 7, 2019
@wing328
wing328
merged commit c00a439
into
OpenAPITools:masterMar 7, 2019
@wing328wing328
changed the title
[PHP] Username checks #1408[PHP] Fix username and password checkMar 7, 2019
@wing328wing328
mentioned this pull request
Mar 7, 2019

Closed

jimschubert added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Mar 9, 2019
@jimschubert
Merge branch 'master' into rienafairefr-templating
a55eee6
* master: (758 commits)
Add support for free form requests (OpenAPITools#2288)
[typescript-rxjs] drop unneeded function wrapping (OpenAPITools#2332)
[typescript-fetch] Guard array mapping against undefined on optional array model properties (OpenAPITools#2324)
Fix regex in Python server model code (OpenAPITools#2314)
Add .travis.yml and Gemfile.lock to ruby security test folder (OpenAPITools#2330)
Add a link to CSDN article (OpenAPITools#2331)
[Maven] fix Spaces in Windows user path breaks build on test goal (OpenAPITools#2318)
[PHP] fix bad links in Model docs (OpenAPITools#2316)
[java]: fix datatype for non-multipart file request body (OpenAPITools#2271)
Removed JFCote from core team (OpenAPITools#2315)
[R sample] fix CircleCI error of outdated sample (OpenAPITools#2313)
[Java] Bean Validation for decimalmin/max incorrect when exclusive set (OpenAPITools#2115)
Java Spring : fix defaultValue annotation double quoted in api operation (OpenAPITools#2267)
Java RESTEASY : fix defaultValue annotation double quoted in api operation (OpenAPITools#2268)
[PHP] Username checks OpenAPITools#1408 (OpenAPITools#1892)
[typescript-fetch] remove namespaces in enums (OpenAPITools#2123)
[java-server-msf4j] fix and upgrade (OpenAPITools#2303)
fix test script path in CONTRIBUTING.md (OpenAPITools#2290)
Dart queryargs (OpenAPITools#2250)
add Blueplanet language (OpenAPITools#2184)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: PHPIssue: Bug

Projects


None yet


Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jfastnacht@wing328@ybelenko

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[PHP] Fix username and password check by jfastnacht · Pull Request #1892 · OpenAPITools/openapi-generator · GitHub
Skip to content
[PHP] Fix username and password check - #1892
Merged
wing328 merged 9 commits into
OpenAPITools:masterfrom 
jfastnacht:1408-php-username-empty-check
Mar 7, 2019
Merged
[PHP] Fix username and password check#1892
wing328 merged 9 commits into
OpenAPITools:masterfrom 
jfastnacht:1408-php-username-empty-check
Conversation
@jfastnacht
@jfastnachtjfastnacht
commented
Jan 11, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  •  Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
Trying to fix the issue #1408 . Intermediate result, WIP.
Had some problems with the test under Windows 8.1, so it might need a little more than the usual review.
@jebentier@dkarlovi@mandrean@jfastnacht@ackintosh@ybelenko@renepardon
@auto-labelerauto-labelerBot
added
the 
WIP
Work in Progress
label
Jan 11, 2019
@auto-labeler
auto-labelerBot
commented
Jan 11, 2019

Copy link


Copy Markdown

👍 Thanks for opening this issue!

🏷 I have applied any labels matching special text in your issue.
The team will review the labels and make any necessary changes.
@jfastnacht
jfastnachtforce-pushed
the
1408-php-username-empty-check
branch
from
6edbbc7 to
8a8a258CompareJanuary 14, 2019 15:38
@jfastnacht
jfastnacht
commented
Jan 27, 2019

Copy link


Copy Markdown

ContributorAuthor
Sometimes the builds are breaking on incomprehensible, random points. Things should be fixed, but this PR goes further than only #1408.

There is a lot of File.separator usage in the PHP projects where it is unnecessary. In PHP you should always use /, even on Windows. There are probably more of these left in other PHP generator files.
I also had to apply the fix in #1863 to make the build work on WIndows, I haven't pushed these changes, since they are already part of the master-branch.
The original issue should be solved now, but I'm not sure if it would be a better idea to split up this PR into seperate issues to discuss and PRs to pull.
@jfastnachtjfastnacht
mentioned this pull request
Jan 28, 2019

Closed

@wing328
wing328
commented
Jan 30, 2019

Copy link


Copy Markdown

Member
Sometimes the builds are breaking on incomprehensible, random points. Things should be fixed, but this PR goes further than only #1408.
Yup, especially weekend as we saw issues downloading dependencies from time to time. Restarting the job (close and reopen the PR) usually fixes the problem
@jfastnacht
jfastnacht
commented
Jan 30, 2019

Copy link


Copy Markdown

ContributorAuthor
Restarting the job (close and reopen the PR) usually fixes the problem
I didn't knew that you can restart it this way, thanks.
@jfastnachtjfastnacht
reopened this
Jan 30, 2019
@jfastnacht
Reverted path changes. Removed additional files in php petstore-secur…
c4b0884
…ity-test folder. Generated new samples.
@jfastnacht
Batch and Shell scripts modified to use the same specification files …
b623d77
…for sample generation. Sample files generated.
@jfastnacht
Input file path in PHP client batch file equalized with the input pat…
13eec4f
…h in the shell script file. Samples generated.
@jfastnacht
Added a missing bracket in the PHP client mustache template.
f8d5f91
@jfastnacht
AbstractPhpCodegen apiDocPath and modelDocPath creation adjusted to a…
e944cb9
…lways use slash instead of system seperator, since the values will just be used in Markdown files.
@jfastnacht
Unnecessary samples removed.
624cd3a
@jfastnacht
Fixed unnecessary diversions between Windows and Linux/Mac paths in P…
efecb97
…HP codegen.
@jfastnacht
New samples generated after rebase.
33c23f1
@jfastnacht
jfastnachtforce-pushed
the
1408-php-username-empty-check
branch
from
cc25f5b to
33c23f1CompareFebruary 13, 2019 13:27
@jfastnachtjfastnacht
reopened this
Feb 15, 2019
@wing328
wing328
commented
Feb 18, 2019

Copy link


Copy Markdown

Member
@jfastnacht is this PR ready for review? If yes, I'll remove WIP from the label and the title.
@jfastnachtjfastnacht
changed the title
[WIP][PHP] Username checks #1408[PHP] Username checks #1408Feb 18, 2019
@jfastnacht
jfastnacht
commented
Feb 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@wing328 tbh, this PR is a mess, because it changes much more than the initial issue states. Not sure if this would be okay anyways, otherwise I'll break it up into seperate issues and PRs.
@wing328
wing328
commented
Mar 7, 2019

Copy link


Copy Markdown

Member
@jfastnacht I'd a look and I think it's acceptable as your fix is essentially just one line: https://github.com/OpenAPITools/openapi-generator/pull/1892/files#diff-076573ccfdac2ab5af4dc1813e5ccee3R584
@wing328wing328
removed
the 
WIP
Work in Progress
label
Mar 7, 2019
@wing328wing328
added this to the 4.0.0 milestone
Mar 7, 2019
@wing328
wing328
merged commit c00a439
into
OpenAPITools:masterMar 7, 2019
@wing328wing328
changed the title
[PHP] Username checks #1408[PHP] Fix username and password checkMar 7, 2019
@wing328wing328
mentioned this pull request
Mar 7, 2019

Closed

jimschubert added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Mar 9, 2019
@jimschubert
Merge branch 'master' into rienafairefr-templating
a55eee6
* master: (758 commits)
Add support for free form requests (OpenAPITools#2288)
[typescript-rxjs] drop unneeded function wrapping (OpenAPITools#2332)
[typescript-fetch] Guard array mapping against undefined on optional array model properties (OpenAPITools#2324)
Fix regex in Python server model code (OpenAPITools#2314)
Add .travis.yml and Gemfile.lock to ruby security test folder (OpenAPITools#2330)
Add a link to CSDN article (OpenAPITools#2331)
[Maven] fix Spaces in Windows user path breaks build on test goal (OpenAPITools#2318)
[PHP] fix bad links in Model docs (OpenAPITools#2316)
[java]: fix datatype for non-multipart file request body (OpenAPITools#2271)
Removed JFCote from core team (OpenAPITools#2315)
[R sample] fix CircleCI error of outdated sample (OpenAPITools#2313)
[Java] Bean Validation for decimalmin/max incorrect when exclusive set (OpenAPITools#2115)
Java Spring : fix defaultValue annotation double quoted in api operation (OpenAPITools#2267)
Java RESTEASY : fix defaultValue annotation double quoted in api operation (OpenAPITools#2268)
[PHP] Username checks OpenAPITools#1408 (OpenAPITools#1892)
[typescript-fetch] remove namespaces in enums (OpenAPITools#2123)
[java-server-msf4j] fix and upgrade (OpenAPITools#2303)
fix test script path in CONTRIBUTING.md (OpenAPITools#2290)
Dart queryargs (OpenAPITools#2250)
add Blueplanet language (OpenAPITools#2184)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: PHPIssue: Bug

Projects


None yet


Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jfastnacht@wing328@ybelenko

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[PHP] Fix username and password check by jfastnacht · Pull Request #1892 · OpenAPITools/openapi-generator · GitHub
Skip to content
[PHP] Fix username and password check - #1892
Merged
wing328 merged 9 commits into
OpenAPITools:masterfrom 
jfastnacht:1408-php-username-empty-check
Mar 7, 2019
Merged
[PHP] Fix username and password check#1892
wing328 merged 9 commits into
OpenAPITools:masterfrom 
jfastnacht:1408-php-username-empty-check
Conversation
@jfastnacht
@jfastnachtjfastnacht
commented
Jan 11, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  •  Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
Trying to fix the issue #1408 . Intermediate result, WIP.
Had some problems with the test under Windows 8.1, so it might need a little more than the usual review.
@jebentier@dkarlovi@mandrean@jfastnacht@ackintosh@ybelenko@renepardon
@auto-labelerauto-labelerBot
added
the 
WIP
Work in Progress
label
Jan 11, 2019
@auto-labeler
auto-labelerBot
commented
Jan 11, 2019

Copy link


Copy Markdown

👍 Thanks for opening this issue!

🏷 I have applied any labels matching special text in your issue.
The team will review the labels and make any necessary changes.
@jfastnacht
jfastnachtforce-pushed
the
1408-php-username-empty-check
branch
from
6edbbc7 to
8a8a258CompareJanuary 14, 2019 15:38
@jfastnacht
jfastnacht
commented
Jan 27, 2019

Copy link


Copy Markdown

ContributorAuthor
Sometimes the builds are breaking on incomprehensible, random points. Things should be fixed, but this PR goes further than only #1408.

There is a lot of File.separator usage in the PHP projects where it is unnecessary. In PHP you should always use /, even on Windows. There are probably more of these left in other PHP generator files.
I also had to apply the fix in #1863 to make the build work on WIndows, I haven't pushed these changes, since they are already part of the master-branch.
The original issue should be solved now, but I'm not sure if it would be a better idea to split up this PR into seperate issues to discuss and PRs to pull.
@jfastnachtjfastnacht
mentioned this pull request
Jan 28, 2019

Closed

@wing328
wing328
commented
Jan 30, 2019

Copy link


Copy Markdown

Member
Sometimes the builds are breaking on incomprehensible, random points. Things should be fixed, but this PR goes further than only #1408.
Yup, especially weekend as we saw issues downloading dependencies from time to time. Restarting the job (close and reopen the PR) usually fixes the problem
@jfastnacht
jfastnacht
commented
Jan 30, 2019

Copy link


Copy Markdown

ContributorAuthor
Restarting the job (close and reopen the PR) usually fixes the problem
I didn't knew that you can restart it this way, thanks.
@jfastnachtjfastnacht
reopened this
Jan 30, 2019
@jfastnacht
Reverted path changes. Removed additional files in php petstore-secur…
c4b0884
…ity-test folder. Generated new samples.
@jfastnacht
Batch and Shell scripts modified to use the same specification files …
b623d77
…for sample generation. Sample files generated.
@jfastnacht
Input file path in PHP client batch file equalized with the input pat…
13eec4f
…h in the shell script file. Samples generated.
@jfastnacht
Added a missing bracket in the PHP client mustache template.
f8d5f91
@jfastnacht
AbstractPhpCodegen apiDocPath and modelDocPath creation adjusted to a…
e944cb9
…lways use slash instead of system seperator, since the values will just be used in Markdown files.
@jfastnacht
Unnecessary samples removed.
624cd3a
@jfastnacht
Fixed unnecessary diversions between Windows and Linux/Mac paths in P…
efecb97
…HP codegen.
@jfastnacht
New samples generated after rebase.
33c23f1
@jfastnacht
jfastnachtforce-pushed
the
1408-php-username-empty-check
branch
from
cc25f5b to
33c23f1CompareFebruary 13, 2019 13:27
@jfastnachtjfastnacht
reopened this
Feb 15, 2019
@wing328
wing328
commented
Feb 18, 2019

Copy link


Copy Markdown

Member
@jfastnacht is this PR ready for review? If yes, I'll remove WIP from the label and the title.
@jfastnachtjfastnacht
changed the title
[WIP][PHP] Username checks #1408[PHP] Username checks #1408Feb 18, 2019
@jfastnacht
jfastnacht
commented
Feb 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@wing328 tbh, this PR is a mess, because it changes much more than the initial issue states. Not sure if this would be okay anyways, otherwise I'll break it up into seperate issues and PRs.
@wing328
wing328
commented
Mar 7, 2019

Copy link


Copy Markdown

Member
@jfastnacht I'd a look and I think it's acceptable as your fix is essentially just one line: https://github.com/OpenAPITools/openapi-generator/pull/1892/files#diff-076573ccfdac2ab5af4dc1813e5ccee3R584
@wing328wing328
removed
the 
WIP
Work in Progress
label
Mar 7, 2019
@wing328wing328
added this to the 4.0.0 milestone
Mar 7, 2019
@wing328
wing328
merged commit c00a439
into
OpenAPITools:masterMar 7, 2019
@wing328wing328
changed the title
[PHP] Username checks #1408[PHP] Fix username and password checkMar 7, 2019
@wing328wing328
mentioned this pull request
Mar 7, 2019

Closed

jimschubert added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Mar 9, 2019
@jimschubert
Merge branch 'master' into rienafairefr-templating
a55eee6
* master: (758 commits)
Add support for free form requests (OpenAPITools#2288)
[typescript-rxjs] drop unneeded function wrapping (OpenAPITools#2332)
[typescript-fetch] Guard array mapping against undefined on optional array model properties (OpenAPITools#2324)
Fix regex in Python server model code (OpenAPITools#2314)
Add .travis.yml and Gemfile.lock to ruby security test folder (OpenAPITools#2330)
Add a link to CSDN article (OpenAPITools#2331)
[Maven] fix Spaces in Windows user path breaks build on test goal (OpenAPITools#2318)
[PHP] fix bad links in Model docs (OpenAPITools#2316)
[java]: fix datatype for non-multipart file request body (OpenAPITools#2271)
Removed JFCote from core team (OpenAPITools#2315)
[R sample] fix CircleCI error of outdated sample (OpenAPITools#2313)
[Java] Bean Validation for decimalmin/max incorrect when exclusive set (OpenAPITools#2115)
Java Spring : fix defaultValue annotation double quoted in api operation (OpenAPITools#2267)
Java RESTEASY : fix defaultValue annotation double quoted in api operation (OpenAPITools#2268)
[PHP] Username checks OpenAPITools#1408 (OpenAPITools#1892)
[typescript-fetch] remove namespaces in enums (OpenAPITools#2123)
[java-server-msf4j] fix and upgrade (OpenAPITools#2303)
fix test script path in CONTRIBUTING.md (OpenAPITools#2290)
Dart queryargs (OpenAPITools#2250)
add Blueplanet language (OpenAPITools#2184)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: PHPIssue: Bug

Projects


None yet


Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jfastnacht@wing328@ybelenko