Skip to content

[typescript-fetch] remove namespaces in enums - #2123

Merged
wing328 merged 8 commits into
OpenAPITools:masterfrom
cassinaooo:ts-fetch-namespaces
Mar 7, 2019
Merged

[typescript-fetch] remove namespaces in enums#2123
wing328 merged 8 commits into
OpenAPITools:masterfrom
cassinaooo:ts-fetch-namespaces

Conversation

@cassinaooo

@cassinaooocassinaooo commented Feb 11, 2019

Copy link
Copy Markdown
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fix behaviour of enums for typescript fetch, removing namespaces according to suggestions made in #1947.

@macjohnny

@cassinaooocassinaooo changed the title Ts fetch namespaces[typescript-fetch] remove namespaces in enumsFeb 11, 2019
@cassinaooo

cassinaooo commented Feb 11, 2019

Copy link
Copy Markdown
ContributorAuthor

Because of the failing tests I just realized that I messed up with AbstractTypescriptClientCodegen that is used by all typescript clients.

Should I modify all typescript templates using namespaces or should I override the postProcessModels method on TypeScriptFetchClientCodegen ?

Is there any other alternatives? Thank you in advance.

@wing328

wing328 commented Feb 13, 2019

Copy link
Copy Markdown
Member

Should I modify all typescript templates using namespaces or should I override the postProcessModels method on TypeScriptFetchClientCodegen ?

Please override postProcessModels in TypeScriptFetchClientCodegen for the time being.

@cassinaooo

cassinaooo commented Feb 13, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I don't know how to solve the Circle CI problem. From what I understand 'UNCOMMITTED CHANGES ERROR' refers to my branch being out of sync with some other one.

I tried pulling from upstream master, but it shows 'Already up to date'.

Any help is appreciated.

Thanks

@macjohnny

macjohnny commented Feb 14, 2019

Copy link
Copy Markdown
Member

@willianscfa

I don't know how to solve the Circle CI problem. From what I understand 'UNCOMMITTED CHANGES ERROR' refers to my branch being out of sync with some other one.

this error indicates that some samples need to be re-generated as they do not correspond to newly generated samples anymore.
in this case, it is due to my revert-commit #2128 that missed the examples, since they were generated in a different commit.
However, with #2149 the typescript angular examples should be in sync again.

in the meantime, you can simply run https://github.com/OpenAPITools/openapi-generator/blob/master/bin/typescript-angular-petstore-all.sh to re-generate the angular samples and pass CI

@macjohnny

macjohnny commented Feb 14, 2019

Copy link
Copy Markdown
Member

@wing328 could you please re-trigger CI? the out-of-date angular typescript samples problem should have been resolved with #2149

@cassinaooo

cassinaooo commented Feb 18, 2019

Copy link
Copy Markdown
ContributorAuthor

@macjohnny I did a git pull upstream master, hope that triggers the CI correctly.

@macjohnny

macjohnny commented Feb 18, 2019

Copy link
Copy Markdown
Member

ok, now the Go and Kotlin samples seem to be out of sync. but it should be possible to merge this PR anyway

@wing328wing328 added this to the 4.0.0 milestone Feb 19, 2019
@macjohnny

macjohnny commented Feb 19, 2019•
edited
Loading

Copy link
Copy Markdown
Member

cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10)

@wing328

wing328 commented Feb 19, 2019

Copy link
Copy Markdown
Member

ok, now the Go and Kotlin samples seem to be out of sync. but it should be possible to merge this PR anyway

That has been fixed in the master.

@denyodenyo mentioned this pull request Feb 26, 2019
Merged
4 tasks
@wing328
wing328 merged commit 8a0248e into OpenAPITools:masterMar 7, 2019
@wing328

wing328 commented Mar 7, 2019

Copy link
Copy Markdown
Member

Upgrade Note

The class name is added as a prefix to the enum naming:

Before: StatusEnum
After: PetStatusEnum

jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Mar 9, 2019
@jimschubert
Merge branch 'master' into rienafairefr-templating
a55eee6
* master: (758 commits)
Add support for free form requests (OpenAPITools#2288)
[typescript-rxjs] drop unneeded function wrapping (OpenAPITools#2332)
[typescript-fetch] Guard array mapping against undefined on optional array model properties (OpenAPITools#2324)
Fix regex in Python server model code (OpenAPITools#2314)
Add .travis.yml and Gemfile.lock to ruby security test folder (OpenAPITools#2330)
Add a link to CSDN article (OpenAPITools#2331)
[Maven] fix Spaces in Windows user path breaks build on test goal (OpenAPITools#2318)
[PHP] fix bad links in Model docs (OpenAPITools#2316)
[java]: fix datatype for non-multipart file request body (OpenAPITools#2271)
Removed JFCote from core team (OpenAPITools#2315)
[R sample] fix CircleCI error of outdated sample (OpenAPITools#2313)
[Java] Bean Validation for decimalmin/max incorrect when exclusive set (OpenAPITools#2115)
Java Spring : fix defaultValue annotation double quoted in api operation (OpenAPITools#2267)
Java RESTEASY : fix defaultValue annotation double quoted in api operation (OpenAPITools#2268)
[PHP] Username checks OpenAPITools#1408 (OpenAPITools#1892)
[typescript-fetch] remove namespaces in enums (OpenAPITools#2123)
[java-server-msf4j] fix and upgrade (OpenAPITools#2303)
fix test script path in CONTRIBUTING.md (OpenAPITools#2290)
Dart queryargs (OpenAPITools#2250)
add Blueplanet language (OpenAPITools#2184)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Breaking change (without fallback)Client: TypeScriptEnhancement: FeatureFeature: Enum

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@cassinaooo@wing328@macjohnny@jimschubert
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[typescript-fetch] remove namespaces in enums by cassinaooo · Pull Request #2123 · OpenAPITools/openapi-generator · GitHub
Skip to content
[typescript-fetch] remove namespaces in enums - #2123
Merged
wing328 merged 8 commits into
OpenAPITools:masterfrom 
cassinaooo:ts-fetch-namespaces
Mar 7, 2019
Merged
[typescript-fetch] remove namespaces in enums#2123
wing328 merged 8 commits into
OpenAPITools:masterfrom 
cassinaooo:ts-fetch-namespaces
Conversation
@cassinaooo
@cassinaooocassinaooo
commented
Feb 11, 2019

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  •  Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
Fix behaviour of enums for typescript fetch, removing namespaces according to suggestions made in #1947.
@macjohnny
@cassinaooocassinaooo
changed the title
Ts fetch namespaces[typescript-fetch] remove namespaces in enumsFeb 11, 2019
@cassinaooo
cassinaooo
commented
Feb 11, 2019

Copy link


Copy Markdown

ContributorAuthor
Because of the failing tests I just realized that I messed up with AbstractTypescriptClientCodegen that is used by all typescript clients.
Should I modify all typescript templates using namespaces or should I override the postProcessModels method on TypeScriptFetchClientCodegen ?
Is there any other alternatives? Thank you in advance.
@wing328
wing328
commented
Feb 13, 2019

Copy link


Copy Markdown

Member
Should I modify all typescript templates using namespaces or should I override the postProcessModels method on TypeScriptFetchClientCodegen ?
Please override postProcessModels in TypeScriptFetchClientCodegen for the time being.
@cassinaooo
cassinaooo
commented
Feb 13, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I don't know how to solve the Circle CI problem. From what I understand 'UNCOMMITTED CHANGES ERROR' refers to my branch being out of sync with some other one.
I tried pulling from upstream master, but it shows 'Already up to date'.
Any help is appreciated.
Thanks
@macjohnny
macjohnny
commented
Feb 14, 2019

Copy link


Copy Markdown

Member
@willianscfa
I don't know how to solve the Circle CI problem. From what I understand 'UNCOMMITTED CHANGES ERROR' refers to my branch being out of sync with some other one.
this error indicates that some samples need to be re-generated as they do not correspond to newly generated samples anymore.

in this case, it is due to my revert-commit #2128 that missed the examples, since they were generated in a different commit.

However, with #2149 the typescript angular examples should be in sync again.
in the meantime, you can simply run https://github.com/OpenAPITools/openapi-generator/blob/master/bin/typescript-angular-petstore-all.sh to re-generate the angular samples and pass CI
@macjohnny
macjohnny
commented
Feb 14, 2019

Copy link


Copy Markdown

Member
@wing328 could you please re-trigger CI? the out-of-date angular typescript samples problem should have been resolved with #2149
@cassinaooo
cassinaooo
commented
Feb 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@macjohnny I did a git pull upstream master, hope that triggers the CI correctly.
@macjohnny
macjohnny
commented
Feb 18, 2019

Copy link


Copy Markdown

Member
ok, now the Go and Kotlin samples seem to be out of sync. but it should be possible to merge this PR anyway
@wing328wing328
added this to the 4.0.0 milestone
Feb 19, 2019
@macjohnny
macjohnny
commented
Feb 19, 2019•

edited

Loading

Copy link


Copy Markdown

Member
cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10)
@wing328
wing328
commented
Feb 19, 2019

Copy link


Copy Markdown

Member
ok, now the Go and Kotlin samples seem to be out of sync. but it should be possible to merge this PR anyway
That has been fixed in the master.
@denyodenyo
mentioned this pull request
Feb 26, 2019
 Merged

4 tasks
@wing328
wing328
merged commit 8a0248e
into
OpenAPITools:masterMar 7, 2019
@wing328
wing328
commented
Mar 7, 2019

Copy link


Copy Markdown

Member
Upgrade Note
The class name is added as a prefix to the enum naming:
Before: StatusEnum

After: PetStatusEnum
jimschubert added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Mar 9, 2019
@jimschubert
Merge branch 'master' into rienafairefr-templating
a55eee6
* master: (758 commits)
Add support for free form requests (OpenAPITools#2288)
[typescript-rxjs] drop unneeded function wrapping (OpenAPITools#2332)
[typescript-fetch] Guard array mapping against undefined on optional array model properties (OpenAPITools#2324)
Fix regex in Python server model code (OpenAPITools#2314)
Add .travis.yml and Gemfile.lock to ruby security test folder (OpenAPITools#2330)
Add a link to CSDN article (OpenAPITools#2331)
[Maven] fix Spaces in Windows user path breaks build on test goal (OpenAPITools#2318)
[PHP] fix bad links in Model docs (OpenAPITools#2316)
[java]: fix datatype for non-multipart file request body (OpenAPITools#2271)
Removed JFCote from core team (OpenAPITools#2315)
[R sample] fix CircleCI error of outdated sample (OpenAPITools#2313)
[Java] Bean Validation for decimalmin/max incorrect when exclusive set (OpenAPITools#2115)
Java Spring : fix defaultValue annotation double quoted in api operation (OpenAPITools#2267)
Java RESTEASY : fix defaultValue annotation double quoted in api operation (OpenAPITools#2268)
[PHP] Username checks OpenAPITools#1408 (OpenAPITools#1892)
[typescript-fetch] remove namespaces in enums (OpenAPITools#2123)
[java-server-msf4j] fix and upgrade (OpenAPITools#2303)
fix test script path in CONTRIBUTING.md (OpenAPITools#2290)
Dart queryargs (OpenAPITools#2250)
add Blueplanet language (OpenAPITools#2184)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Breaking change (without fallback)Client: TypeScriptEnhancement: FeatureFeature: Enum

Projects


None yet


Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@cassinaooo@wing328@macjohnny@jimschubert

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[typescript-fetch] remove namespaces in enums by cassinaooo · Pull Request #2123 · OpenAPITools/openapi-generator · GitHub
Skip to content
[typescript-fetch] remove namespaces in enums - #2123
Merged
wing328 merged 8 commits into
OpenAPITools:masterfrom 
cassinaooo:ts-fetch-namespaces
Mar 7, 2019
Merged
[typescript-fetch] remove namespaces in enums#2123
wing328 merged 8 commits into
OpenAPITools:masterfrom 
cassinaooo:ts-fetch-namespaces
Conversation
@cassinaooo
@cassinaooocassinaooo
commented
Feb 11, 2019

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  •  Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
Fix behaviour of enums for typescript fetch, removing namespaces according to suggestions made in #1947.
@macjohnny
@cassinaooocassinaooo
changed the title
Ts fetch namespaces[typescript-fetch] remove namespaces in enumsFeb 11, 2019
@cassinaooo
cassinaooo
commented
Feb 11, 2019

Copy link


Copy Markdown

ContributorAuthor
Because of the failing tests I just realized that I messed up with AbstractTypescriptClientCodegen that is used by all typescript clients.
Should I modify all typescript templates using namespaces or should I override the postProcessModels method on TypeScriptFetchClientCodegen ?
Is there any other alternatives? Thank you in advance.
@wing328
wing328
commented
Feb 13, 2019

Copy link


Copy Markdown

Member
Should I modify all typescript templates using namespaces or should I override the postProcessModels method on TypeScriptFetchClientCodegen ?
Please override postProcessModels in TypeScriptFetchClientCodegen for the time being.
@cassinaooo
cassinaooo
commented
Feb 13, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I don't know how to solve the Circle CI problem. From what I understand 'UNCOMMITTED CHANGES ERROR' refers to my branch being out of sync with some other one.
I tried pulling from upstream master, but it shows 'Already up to date'.
Any help is appreciated.
Thanks
@macjohnny
macjohnny
commented
Feb 14, 2019

Copy link


Copy Markdown

Member
@willianscfa
I don't know how to solve the Circle CI problem. From what I understand 'UNCOMMITTED CHANGES ERROR' refers to my branch being out of sync with some other one.
this error indicates that some samples need to be re-generated as they do not correspond to newly generated samples anymore.

in this case, it is due to my revert-commit #2128 that missed the examples, since they were generated in a different commit.

However, with #2149 the typescript angular examples should be in sync again.
in the meantime, you can simply run https://github.com/OpenAPITools/openapi-generator/blob/master/bin/typescript-angular-petstore-all.sh to re-generate the angular samples and pass CI
@macjohnny
macjohnny
commented
Feb 14, 2019

Copy link


Copy Markdown

Member
@wing328 could you please re-trigger CI? the out-of-date angular typescript samples problem should have been resolved with #2149
@cassinaooo
cassinaooo
commented
Feb 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@macjohnny I did a git pull upstream master, hope that triggers the CI correctly.
@macjohnny
macjohnny
commented
Feb 18, 2019

Copy link


Copy Markdown

Member
ok, now the Go and Kotlin samples seem to be out of sync. but it should be possible to merge this PR anyway
@wing328wing328
added this to the 4.0.0 milestone
Feb 19, 2019
@macjohnny
macjohnny
commented
Feb 19, 2019•

edited

Loading

Copy link


Copy Markdown

Member
cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10)
@wing328
wing328
commented
Feb 19, 2019

Copy link


Copy Markdown

Member
ok, now the Go and Kotlin samples seem to be out of sync. but it should be possible to merge this PR anyway
That has been fixed in the master.
@denyodenyo
mentioned this pull request
Feb 26, 2019
 Merged

4 tasks
@wing328
wing328
merged commit 8a0248e
into
OpenAPITools:masterMar 7, 2019
@wing328
wing328
commented
Mar 7, 2019

Copy link


Copy Markdown

Member
Upgrade Note
The class name is added as a prefix to the enum naming:
Before: StatusEnum

After: PetStatusEnum
jimschubert added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Mar 9, 2019
@jimschubert
Merge branch 'master' into rienafairefr-templating
a55eee6
* master: (758 commits)
Add support for free form requests (OpenAPITools#2288)
[typescript-rxjs] drop unneeded function wrapping (OpenAPITools#2332)
[typescript-fetch] Guard array mapping against undefined on optional array model properties (OpenAPITools#2324)
Fix regex in Python server model code (OpenAPITools#2314)
Add .travis.yml and Gemfile.lock to ruby security test folder (OpenAPITools#2330)
Add a link to CSDN article (OpenAPITools#2331)
[Maven] fix Spaces in Windows user path breaks build on test goal (OpenAPITools#2318)
[PHP] fix bad links in Model docs (OpenAPITools#2316)
[java]: fix datatype for non-multipart file request body (OpenAPITools#2271)
Removed JFCote from core team (OpenAPITools#2315)
[R sample] fix CircleCI error of outdated sample (OpenAPITools#2313)
[Java] Bean Validation for decimalmin/max incorrect when exclusive set (OpenAPITools#2115)
Java Spring : fix defaultValue annotation double quoted in api operation (OpenAPITools#2267)
Java RESTEASY : fix defaultValue annotation double quoted in api operation (OpenAPITools#2268)
[PHP] Username checks OpenAPITools#1408 (OpenAPITools#1892)
[typescript-fetch] remove namespaces in enums (OpenAPITools#2123)
[java-server-msf4j] fix and upgrade (OpenAPITools#2303)
fix test script path in CONTRIBUTING.md (OpenAPITools#2290)
Dart queryargs (OpenAPITools#2250)
add Blueplanet language (OpenAPITools#2184)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Breaking change (without fallback)Client: TypeScriptEnhancement: FeatureFeature: Enum

Projects


None yet


Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@cassinaooo@wing328@macjohnny@jimschubert

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[typescript-fetch] remove namespaces in enums by cassinaooo · Pull Request #2123 · OpenAPITools/openapi-generator · GitHub
Skip to content
[typescript-fetch] remove namespaces in enums - #2123
Merged
wing328 merged 8 commits into
OpenAPITools:masterfrom 
cassinaooo:ts-fetch-namespaces
Mar 7, 2019
Merged
[typescript-fetch] remove namespaces in enums#2123
wing328 merged 8 commits into
OpenAPITools:masterfrom 
cassinaooo:ts-fetch-namespaces
Conversation
@cassinaooo
@cassinaooocassinaooo
commented
Feb 11, 2019

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  •  Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
Fix behaviour of enums for typescript fetch, removing namespaces according to suggestions made in #1947.
@macjohnny
@cassinaooocassinaooo
changed the title
Ts fetch namespaces[typescript-fetch] remove namespaces in enumsFeb 11, 2019
@cassinaooo
cassinaooo
commented
Feb 11, 2019

Copy link


Copy Markdown

ContributorAuthor
Because of the failing tests I just realized that I messed up with AbstractTypescriptClientCodegen that is used by all typescript clients.
Should I modify all typescript templates using namespaces or should I override the postProcessModels method on TypeScriptFetchClientCodegen ?
Is there any other alternatives? Thank you in advance.
@wing328
wing328
commented
Feb 13, 2019

Copy link


Copy Markdown

Member
Should I modify all typescript templates using namespaces or should I override the postProcessModels method on TypeScriptFetchClientCodegen ?
Please override postProcessModels in TypeScriptFetchClientCodegen for the time being.
@cassinaooo
cassinaooo
commented
Feb 13, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I don't know how to solve the Circle CI problem. From what I understand 'UNCOMMITTED CHANGES ERROR' refers to my branch being out of sync with some other one.
I tried pulling from upstream master, but it shows 'Already up to date'.
Any help is appreciated.
Thanks
@macjohnny
macjohnny
commented
Feb 14, 2019

Copy link


Copy Markdown

Member
@willianscfa
I don't know how to solve the Circle CI problem. From what I understand 'UNCOMMITTED CHANGES ERROR' refers to my branch being out of sync with some other one.
this error indicates that some samples need to be re-generated as they do not correspond to newly generated samples anymore.

in this case, it is due to my revert-commit #2128 that missed the examples, since they were generated in a different commit.

However, with #2149 the typescript angular examples should be in sync again.
in the meantime, you can simply run https://github.com/OpenAPITools/openapi-generator/blob/master/bin/typescript-angular-petstore-all.sh to re-generate the angular samples and pass CI
@macjohnny
macjohnny
commented
Feb 14, 2019

Copy link


Copy Markdown

Member
@wing328 could you please re-trigger CI? the out-of-date angular typescript samples problem should have been resolved with #2149
@cassinaooo
cassinaooo
commented
Feb 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@macjohnny I did a git pull upstream master, hope that triggers the CI correctly.
@macjohnny
macjohnny
commented
Feb 18, 2019

Copy link


Copy Markdown

Member
ok, now the Go and Kotlin samples seem to be out of sync. but it should be possible to merge this PR anyway
@wing328wing328
added this to the 4.0.0 milestone
Feb 19, 2019
@macjohnny
macjohnny
commented
Feb 19, 2019•

edited

Loading

Copy link


Copy Markdown

Member
cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10)
@wing328
wing328
commented
Feb 19, 2019

Copy link


Copy Markdown

Member
ok, now the Go and Kotlin samples seem to be out of sync. but it should be possible to merge this PR anyway
That has been fixed in the master.
@denyodenyo
mentioned this pull request
Feb 26, 2019
 Merged

4 tasks
@wing328
wing328
merged commit 8a0248e
into
OpenAPITools:masterMar 7, 2019
@wing328
wing328
commented
Mar 7, 2019

Copy link


Copy Markdown

Member
Upgrade Note
The class name is added as a prefix to the enum naming:
Before: StatusEnum

After: PetStatusEnum
jimschubert added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Mar 9, 2019
@jimschubert
Merge branch 'master' into rienafairefr-templating
a55eee6
* master: (758 commits)
Add support for free form requests (OpenAPITools#2288)
[typescript-rxjs] drop unneeded function wrapping (OpenAPITools#2332)
[typescript-fetch] Guard array mapping against undefined on optional array model properties (OpenAPITools#2324)
Fix regex in Python server model code (OpenAPITools#2314)
Add .travis.yml and Gemfile.lock to ruby security test folder (OpenAPITools#2330)
Add a link to CSDN article (OpenAPITools#2331)
[Maven] fix Spaces in Windows user path breaks build on test goal (OpenAPITools#2318)
[PHP] fix bad links in Model docs (OpenAPITools#2316)
[java]: fix datatype for non-multipart file request body (OpenAPITools#2271)
Removed JFCote from core team (OpenAPITools#2315)
[R sample] fix CircleCI error of outdated sample (OpenAPITools#2313)
[Java] Bean Validation for decimalmin/max incorrect when exclusive set (OpenAPITools#2115)
Java Spring : fix defaultValue annotation double quoted in api operation (OpenAPITools#2267)
Java RESTEASY : fix defaultValue annotation double quoted in api operation (OpenAPITools#2268)
[PHP] Username checks OpenAPITools#1408 (OpenAPITools#1892)
[typescript-fetch] remove namespaces in enums (OpenAPITools#2123)
[java-server-msf4j] fix and upgrade (OpenAPITools#2303)
fix test script path in CONTRIBUTING.md (OpenAPITools#2290)
Dart queryargs (OpenAPITools#2250)
add Blueplanet language (OpenAPITools#2184)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Breaking change (without fallback)Client: TypeScriptEnhancement: FeatureFeature: Enum

Projects


None yet


Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@cassinaooo@wing328@macjohnny@jimschubert

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[typescript-fetch] remove namespaces in enums by cassinaooo · Pull Request #2123 · OpenAPITools/openapi-generator · GitHub
Skip to content
[typescript-fetch] remove namespaces in enums - #2123
Merged
wing328 merged 8 commits into
OpenAPITools:masterfrom 
cassinaooo:ts-fetch-namespaces
Mar 7, 2019
Merged
[typescript-fetch] remove namespaces in enums#2123
wing328 merged 8 commits into
OpenAPITools:masterfrom 
cassinaooo:ts-fetch-namespaces
Conversation
@cassinaooo
@cassinaooocassinaooo
commented
Feb 11, 2019

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  •  Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
Fix behaviour of enums for typescript fetch, removing namespaces according to suggestions made in #1947.
@macjohnny
@cassinaooocassinaooo
changed the title
Ts fetch namespaces[typescript-fetch] remove namespaces in enumsFeb 11, 2019
@cassinaooo
cassinaooo
commented
Feb 11, 2019

Copy link


Copy Markdown

ContributorAuthor
Because of the failing tests I just realized that I messed up with AbstractTypescriptClientCodegen that is used by all typescript clients.
Should I modify all typescript templates using namespaces or should I override the postProcessModels method on TypeScriptFetchClientCodegen ?
Is there any other alternatives? Thank you in advance.
@wing328
wing328
commented
Feb 13, 2019

Copy link


Copy Markdown

Member
Should I modify all typescript templates using namespaces or should I override the postProcessModels method on TypeScriptFetchClientCodegen ?
Please override postProcessModels in TypeScriptFetchClientCodegen for the time being.
@cassinaooo
cassinaooo
commented
Feb 13, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I don't know how to solve the Circle CI problem. From what I understand 'UNCOMMITTED CHANGES ERROR' refers to my branch being out of sync with some other one.
I tried pulling from upstream master, but it shows 'Already up to date'.
Any help is appreciated.
Thanks
@macjohnny
macjohnny
commented
Feb 14, 2019

Copy link


Copy Markdown

Member
@willianscfa
I don't know how to solve the Circle CI problem. From what I understand 'UNCOMMITTED CHANGES ERROR' refers to my branch being out of sync with some other one.
this error indicates that some samples need to be re-generated as they do not correspond to newly generated samples anymore.

in this case, it is due to my revert-commit #2128 that missed the examples, since they were generated in a different commit.

However, with #2149 the typescript angular examples should be in sync again.
in the meantime, you can simply run https://github.com/OpenAPITools/openapi-generator/blob/master/bin/typescript-angular-petstore-all.sh to re-generate the angular samples and pass CI
@macjohnny
macjohnny
commented
Feb 14, 2019

Copy link


Copy Markdown

Member
@wing328 could you please re-trigger CI? the out-of-date angular typescript samples problem should have been resolved with #2149
@cassinaooo
cassinaooo
commented
Feb 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@macjohnny I did a git pull upstream master, hope that triggers the CI correctly.
@macjohnny
macjohnny
commented
Feb 18, 2019

Copy link


Copy Markdown

Member
ok, now the Go and Kotlin samples seem to be out of sync. but it should be possible to merge this PR anyway
@wing328wing328
added this to the 4.0.0 milestone
Feb 19, 2019
@macjohnny
macjohnny
commented
Feb 19, 2019•

edited

Loading

Copy link


Copy Markdown

Member
cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10)
@wing328
wing328
commented
Feb 19, 2019

Copy link


Copy Markdown

Member
ok, now the Go and Kotlin samples seem to be out of sync. but it should be possible to merge this PR anyway
That has been fixed in the master.
@denyodenyo
mentioned this pull request
Feb 26, 2019
 Merged

4 tasks
@wing328
wing328
merged commit 8a0248e
into
OpenAPITools:masterMar 7, 2019
@wing328
wing328
commented
Mar 7, 2019

Copy link


Copy Markdown

Member
Upgrade Note
The class name is added as a prefix to the enum naming:
Before: StatusEnum

After: PetStatusEnum
jimschubert added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Mar 9, 2019
@jimschubert
Merge branch 'master' into rienafairefr-templating
a55eee6
* master: (758 commits)
Add support for free form requests (OpenAPITools#2288)
[typescript-rxjs] drop unneeded function wrapping (OpenAPITools#2332)
[typescript-fetch] Guard array mapping against undefined on optional array model properties (OpenAPITools#2324)
Fix regex in Python server model code (OpenAPITools#2314)
Add .travis.yml and Gemfile.lock to ruby security test folder (OpenAPITools#2330)
Add a link to CSDN article (OpenAPITools#2331)
[Maven] fix Spaces in Windows user path breaks build on test goal (OpenAPITools#2318)
[PHP] fix bad links in Model docs (OpenAPITools#2316)
[java]: fix datatype for non-multipart file request body (OpenAPITools#2271)
Removed JFCote from core team (OpenAPITools#2315)
[R sample] fix CircleCI error of outdated sample (OpenAPITools#2313)
[Java] Bean Validation for decimalmin/max incorrect when exclusive set (OpenAPITools#2115)
Java Spring : fix defaultValue annotation double quoted in api operation (OpenAPITools#2267)
Java RESTEASY : fix defaultValue annotation double quoted in api operation (OpenAPITools#2268)
[PHP] Username checks OpenAPITools#1408 (OpenAPITools#1892)
[typescript-fetch] remove namespaces in enums (OpenAPITools#2123)
[java-server-msf4j] fix and upgrade (OpenAPITools#2303)
fix test script path in CONTRIBUTING.md (OpenAPITools#2290)
Dart queryargs (OpenAPITools#2250)
add Blueplanet language (OpenAPITools#2184)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Breaking change (without fallback)Client: TypeScriptEnhancement: FeatureFeature: Enum

Projects


None yet


Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@cassinaooo@wing328@macjohnny@jimschubert

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[typescript-fetch] remove namespaces in enums by cassinaooo · Pull Request #2123 · OpenAPITools/openapi-generator · GitHub
Skip to content
[typescript-fetch] remove namespaces in enums - #2123
Merged
wing328 merged 8 commits into
OpenAPITools:masterfrom 
cassinaooo:ts-fetch-namespaces
Mar 7, 2019
Merged
[typescript-fetch] remove namespaces in enums#2123
wing328 merged 8 commits into
OpenAPITools:masterfrom 
cassinaooo:ts-fetch-namespaces
Conversation
@cassinaooo
@cassinaooocassinaooo
commented
Feb 11, 2019

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  •  Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
Fix behaviour of enums for typescript fetch, removing namespaces according to suggestions made in #1947.
@macjohnny
@cassinaooocassinaooo
changed the title
Ts fetch namespaces[typescript-fetch] remove namespaces in enumsFeb 11, 2019
@cassinaooo
cassinaooo
commented
Feb 11, 2019

Copy link


Copy Markdown

ContributorAuthor
Because of the failing tests I just realized that I messed up with AbstractTypescriptClientCodegen that is used by all typescript clients.
Should I modify all typescript templates using namespaces or should I override the postProcessModels method on TypeScriptFetchClientCodegen ?
Is there any other alternatives? Thank you in advance.
@wing328
wing328
commented
Feb 13, 2019

Copy link


Copy Markdown

Member
Should I modify all typescript templates using namespaces or should I override the postProcessModels method on TypeScriptFetchClientCodegen ?
Please override postProcessModels in TypeScriptFetchClientCodegen for the time being.
@cassinaooo
cassinaooo
commented
Feb 13, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I don't know how to solve the Circle CI problem. From what I understand 'UNCOMMITTED CHANGES ERROR' refers to my branch being out of sync with some other one.
I tried pulling from upstream master, but it shows 'Already up to date'.
Any help is appreciated.
Thanks
@macjohnny
macjohnny
commented
Feb 14, 2019

Copy link


Copy Markdown

Member
@willianscfa
I don't know how to solve the Circle CI problem. From what I understand 'UNCOMMITTED CHANGES ERROR' refers to my branch being out of sync with some other one.
this error indicates that some samples need to be re-generated as they do not correspond to newly generated samples anymore.

in this case, it is due to my revert-commit #2128 that missed the examples, since they were generated in a different commit.

However, with #2149 the typescript angular examples should be in sync again.
in the meantime, you can simply run https://github.com/OpenAPITools/openapi-generator/blob/master/bin/typescript-angular-petstore-all.sh to re-generate the angular samples and pass CI
@macjohnny
macjohnny
commented
Feb 14, 2019

Copy link


Copy Markdown

Member
@wing328 could you please re-trigger CI? the out-of-date angular typescript samples problem should have been resolved with #2149
@cassinaooo
cassinaooo
commented
Feb 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@macjohnny I did a git pull upstream master, hope that triggers the CI correctly.
@macjohnny
macjohnny
commented
Feb 18, 2019

Copy link


Copy Markdown

Member
ok, now the Go and Kotlin samples seem to be out of sync. but it should be possible to merge this PR anyway
@wing328wing328
added this to the 4.0.0 milestone
Feb 19, 2019
@macjohnny
macjohnny
commented
Feb 19, 2019•

edited

Loading

Copy link


Copy Markdown

Member
cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10)
@wing328
wing328
commented
Feb 19, 2019

Copy link


Copy Markdown

Member
ok, now the Go and Kotlin samples seem to be out of sync. but it should be possible to merge this PR anyway
That has been fixed in the master.
@denyodenyo
mentioned this pull request
Feb 26, 2019
 Merged

4 tasks
@wing328
wing328
merged commit 8a0248e
into
OpenAPITools:masterMar 7, 2019
@wing328
wing328
commented
Mar 7, 2019

Copy link


Copy Markdown

Member
Upgrade Note
The class name is added as a prefix to the enum naming:
Before: StatusEnum

After: PetStatusEnum
jimschubert added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Mar 9, 2019
@jimschubert
Merge branch 'master' into rienafairefr-templating
a55eee6
* master: (758 commits)
Add support for free form requests (OpenAPITools#2288)
[typescript-rxjs] drop unneeded function wrapping (OpenAPITools#2332)
[typescript-fetch] Guard array mapping against undefined on optional array model properties (OpenAPITools#2324)
Fix regex in Python server model code (OpenAPITools#2314)
Add .travis.yml and Gemfile.lock to ruby security test folder (OpenAPITools#2330)
Add a link to CSDN article (OpenAPITools#2331)
[Maven] fix Spaces in Windows user path breaks build on test goal (OpenAPITools#2318)
[PHP] fix bad links in Model docs (OpenAPITools#2316)
[java]: fix datatype for non-multipart file request body (OpenAPITools#2271)
Removed JFCote from core team (OpenAPITools#2315)
[R sample] fix CircleCI error of outdated sample (OpenAPITools#2313)
[Java] Bean Validation for decimalmin/max incorrect when exclusive set (OpenAPITools#2115)
Java Spring : fix defaultValue annotation double quoted in api operation (OpenAPITools#2267)
Java RESTEASY : fix defaultValue annotation double quoted in api operation (OpenAPITools#2268)
[PHP] Username checks OpenAPITools#1408 (OpenAPITools#1892)
[typescript-fetch] remove namespaces in enums (OpenAPITools#2123)
[java-server-msf4j] fix and upgrade (OpenAPITools#2303)
fix test script path in CONTRIBUTING.md (OpenAPITools#2290)
Dart queryargs (OpenAPITools#2250)
add Blueplanet language (OpenAPITools#2184)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Breaking change (without fallback)Client: TypeScriptEnhancement: FeatureFeature: Enum

Projects


None yet


Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@cassinaooo@wing328@macjohnny@jimschubert

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[typescript-fetch] remove namespaces in enums by cassinaooo · Pull Request #2123 · OpenAPITools/openapi-generator · GitHub
Skip to content
[typescript-fetch] remove namespaces in enums - #2123
Merged
wing328 merged 8 commits into
OpenAPITools:masterfrom 
cassinaooo:ts-fetch-namespaces
Mar 7, 2019
Merged
[typescript-fetch] remove namespaces in enums#2123
wing328 merged 8 commits into
OpenAPITools:masterfrom 
cassinaooo:ts-fetch-namespaces
Conversation
@cassinaooo
@cassinaooocassinaooo
commented
Feb 11, 2019

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  •  Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
Fix behaviour of enums for typescript fetch, removing namespaces according to suggestions made in #1947.
@macjohnny
@cassinaooocassinaooo
changed the title
Ts fetch namespaces[typescript-fetch] remove namespaces in enumsFeb 11, 2019
@cassinaooo
cassinaooo
commented
Feb 11, 2019

Copy link


Copy Markdown

ContributorAuthor
Because of the failing tests I just realized that I messed up with AbstractTypescriptClientCodegen that is used by all typescript clients.
Should I modify all typescript templates using namespaces or should I override the postProcessModels method on TypeScriptFetchClientCodegen ?
Is there any other alternatives? Thank you in advance.
@wing328
wing328
commented
Feb 13, 2019

Copy link


Copy Markdown

Member
Should I modify all typescript templates using namespaces or should I override the postProcessModels method on TypeScriptFetchClientCodegen ?
Please override postProcessModels in TypeScriptFetchClientCodegen for the time being.
@cassinaooo
cassinaooo
commented
Feb 13, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I don't know how to solve the Circle CI problem. From what I understand 'UNCOMMITTED CHANGES ERROR' refers to my branch being out of sync with some other one.
I tried pulling from upstream master, but it shows 'Already up to date'.
Any help is appreciated.
Thanks
@macjohnny
macjohnny
commented
Feb 14, 2019

Copy link


Copy Markdown

Member
@willianscfa
I don't know how to solve the Circle CI problem. From what I understand 'UNCOMMITTED CHANGES ERROR' refers to my branch being out of sync with some other one.
this error indicates that some samples need to be re-generated as they do not correspond to newly generated samples anymore.

in this case, it is due to my revert-commit #2128 that missed the examples, since they were generated in a different commit.

However, with #2149 the typescript angular examples should be in sync again.
in the meantime, you can simply run https://github.com/OpenAPITools/openapi-generator/blob/master/bin/typescript-angular-petstore-all.sh to re-generate the angular samples and pass CI
@macjohnny
macjohnny
commented
Feb 14, 2019

Copy link


Copy Markdown

Member
@wing328 could you please re-trigger CI? the out-of-date angular typescript samples problem should have been resolved with #2149
@cassinaooo
cassinaooo
commented
Feb 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@macjohnny I did a git pull upstream master, hope that triggers the CI correctly.
@macjohnny
macjohnny
commented
Feb 18, 2019

Copy link


Copy Markdown

Member
ok, now the Go and Kotlin samples seem to be out of sync. but it should be possible to merge this PR anyway
@wing328wing328
added this to the 4.0.0 milestone
Feb 19, 2019
@macjohnny
macjohnny
commented
Feb 19, 2019•

edited

Loading

Copy link


Copy Markdown

Member
cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10)
@wing328
wing328
commented
Feb 19, 2019

Copy link


Copy Markdown

Member
ok, now the Go and Kotlin samples seem to be out of sync. but it should be possible to merge this PR anyway
That has been fixed in the master.
@denyodenyo
mentioned this pull request
Feb 26, 2019
 Merged

4 tasks
@wing328
wing328
merged commit 8a0248e
into
OpenAPITools:masterMar 7, 2019
@wing328
wing328
commented
Mar 7, 2019

Copy link


Copy Markdown

Member
Upgrade Note
The class name is added as a prefix to the enum naming:
Before: StatusEnum

After: PetStatusEnum
jimschubert added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Mar 9, 2019
@jimschubert
Merge branch 'master' into rienafairefr-templating
a55eee6
* master: (758 commits)
Add support for free form requests (OpenAPITools#2288)
[typescript-rxjs] drop unneeded function wrapping (OpenAPITools#2332)
[typescript-fetch] Guard array mapping against undefined on optional array model properties (OpenAPITools#2324)
Fix regex in Python server model code (OpenAPITools#2314)
Add .travis.yml and Gemfile.lock to ruby security test folder (OpenAPITools#2330)
Add a link to CSDN article (OpenAPITools#2331)
[Maven] fix Spaces in Windows user path breaks build on test goal (OpenAPITools#2318)
[PHP] fix bad links in Model docs (OpenAPITools#2316)
[java]: fix datatype for non-multipart file request body (OpenAPITools#2271)
Removed JFCote from core team (OpenAPITools#2315)
[R sample] fix CircleCI error of outdated sample (OpenAPITools#2313)
[Java] Bean Validation for decimalmin/max incorrect when exclusive set (OpenAPITools#2115)
Java Spring : fix defaultValue annotation double quoted in api operation (OpenAPITools#2267)
Java RESTEASY : fix defaultValue annotation double quoted in api operation (OpenAPITools#2268)
[PHP] Username checks OpenAPITools#1408 (OpenAPITools#1892)
[typescript-fetch] remove namespaces in enums (OpenAPITools#2123)
[java-server-msf4j] fix and upgrade (OpenAPITools#2303)
fix test script path in CONTRIBUTING.md (OpenAPITools#2290)
Dart queryargs (OpenAPITools#2250)
add Blueplanet language (OpenAPITools#2184)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Breaking change (without fallback)Client: TypeScriptEnhancement: FeatureFeature: Enum

Projects


None yet


Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@cassinaooo@wing328@macjohnny@jimschubert