Uh oh!
There was an error while loading. Please reload this page.
Add a new NodeJS Express server generator - #3567
Merged
Merged
Conversation
… loads properly. No real paths yet
… loads properly. No real paths yet (#2839)
…pi-generator into nodejs-express-server # Conflicts: # samples/server/petstore/nodejs-express-server/.eslintrc # samples/server/petstore/nodejs-express-server/config.js # samples/server/petstore/nodejs-express-server/expressServer.js # samples/server/petstore/nodejs-express-server/index.js # samples/server/petstore/nodejs-express-server/package.json # samples/server/petstore/nodejs-express-server/tests/serverTests.js
… and validation, and an internal router to pass arguments to controllers and services. /controllers/Pet.js and /services/PetService.js should be used for reverse engineering for future codegen script
…pi-generator into nodejs-express-server
…pi-generator into nodejs-express-server
…penapi-generator into YishTish-nodejs-express-server2
…s to swager); some work on handling file uploads; some work on tests
…into nodejs-express-server # Conflicts: # samples/server/petstore/nodejs-express-server/controllers/index.js
* update generator and template * update samples * more update * update service, controller * add vendor extensions * update doc
Each path operation has a 'x-openapi-router-controller' and 'x-openapi-router-service'. Automated files will be placed under /controllers and /services respectively. Controller file names will end with 'Controller.js'. Removed swaggerRouter, replaced it with openapiRouter Routing works and simple tests show a return of 200 to requests.
Merge remote-tracking branch 'upstream/nodejs-express-server' into nodejs-express-server # Conflicts: # modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/NodeJSExpressServerCodegen.java # samples/server/petstore/nodejs-express-server/controllers/StoreController.js # samples/server/petstore/nodejs-express-server/controllers/TestController.js # samples/server/petstore/nodejs-express-server/controllers/UserController.js # samples/server/petstore/nodejs-express-server/service/PetService.js # samples/server/petstore/nodejs-express-server/service/StoreService.js # samples/server/petstore/nodejs-express-server/service/UserService.js
* various fix * remove dot from service * add space * better method empty argument
…aml and tries calling them, expecting 200 in return. Currently not all tests pass - not supporting xml, and problems with formData 2. Removed old testing files. 3. Added model files - contain data and structure as defined in openapi.yaml. Model.js has static methods relevant to all model files. 4. Changed openapi.yaml to allow running tests easily.
…to nodejs-express-server
…aml and tries calling them, expecting 200 in return. Currently not all tests pass - not supporting xml, and problems with formData (#3442) 2. Removed old testing files. 3. Added model files - contain data and structure as defined in openapi.yaml. Model.js has static methods relevant to all model files. 4. Changed openapi.yaml to allow running tests easily.
Removed test files that are not needed. Removed utils/writer.js which is not needed, and the references to it in the codegen files
…t. index.js now calls ExpressServer.js directly. Updated files that used to call app.js. Updated README.md accordingly Added a path to call the openapi.yaml, and a test file for all endpoints that are not in the openapi.yaml, ensuring that they return 200. Updated README.md accordingly
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
* remove test controller * add back changes to templates * remove app.js
jimschubert added a commit
that referenced
this pull request
Aug 11, 2019
* master: (122 commits) Fix#3604 by adding undefined as return type to headers and credentials methods in runtime.ts (#3605) Prepare 4.1.1-SNAPSHOT (#3603) Prepare 4.1.0 release (#3597) [java][client][jax-rs] Add a constant for Jackson @JsonProperty (#3560) restore openapi3 petstore.yaml (#3590) Add a new NodeJS Express server generator (#3567) [C#][client][csharp-netcore] Fix csharp netcore defaultheaders (#3562) Fix issue deserializing to nullptr (#3572) [OCaml] Add file post-processing (#3583) [dart2] Fix up test code generation, double deserialization, 'new' keyword deprecation (#3576) Run Qt5 client sample test (#3415) typescript-fetch: allow configuration of headers and credentials (#3586) using partials in ruby api_client (#3564) [OCaml] Added optional params support in API operations (#3568) [Rust Server] Generate valid Rustdocs for lazy_static items (#3556) Fix NPM build for Typescript-fetch (#3403) Expand path templates via resttemplate's uriTemplateHandler (#3500) Readme updated with a new tutorial and company using OpenAPI Generator (#3566) Fix logic of `getNullableType` of csharp server and client. (#3537) [Ruby] clean up Ruby dev dependencies (#3551) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)