[dart2] Fix up test code generation, double deserialization, 'new' keyword deprecation by pmundt · Pull Request #3576 · OpenAPITools/openapi-generator

pmundt · 2019-08-07T09:26:21Z

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This PR fixes up a number of issues with the current dart2 generator:

The test code generator is currently broken due to not taking the targeted classname into account
Double deserialization in JSON is corrected to avoid int/double type mismatch exceptions
Use of the deprecated 'new' keyword is dropped in line with the official 'effective dart' guide, something that linters are now beginning to warn about.

At present test generation has a stray hard-coded reference to the pet store Pet() class, which should reflect the actual classname under test.

At present the generated code does not correctly handle transitioning to double when dealing with non-integer types in JSON deserialization. This ends up with dart raising an unhandled type mismatch exception: Unhandled exception: type 'int' is not a subtype of type 'double' where ... Using the .toDouble() conversion when a double type is expected fixes this up by making the typing explicit.

The use of the 'new' keyword in dart2 is deprecated and should be avoided, as per the official guidance of the dart2 authors: https://dart.dev/guides/language/effective-dart/usage#dont-use-new

wing328 · 2019-08-08T14:22:54Z


 # **updatePet**
-> updatePet(body)
+> updatePet(pet)


@pmundt Which version of OpenAPI Generator are you using when working on this PR?
If it's the latest version, body should be used instead of pet.

This was done with the current master from git shortly before the PR was created - with a full clean/install. I can attempt to wipe the tree and try it again in case this has accidentally cached some old build artifacts.

👌 let me pull the changes locally to test it out.

Your change looks good. I'll troubleshoot after merging your fix into master.

wing328 · 2019-08-08T16:16:06Z

Minor suggestion: please create a new branch for the change moving forward.

wing328 · 2019-08-10T07:55:50Z

@pmundt thanks for the PR, which has been included in the 4.1.0 release: https://twitter.com/oas_generator/status/1160000504455319553

@JsonProperty

* master: (122 commits) Fix#3604 by adding undefined as return type to headers and credentials methods in runtime.ts (#3605) Prepare 4.1.1-SNAPSHOT (#3603) Prepare 4.1.0 release (#3597) [java][client][jax-rs] Add a constant for Jackson @JsonProperty (#3560) restore openapi3 petstore.yaml (#3590) Add a new NodeJS Express server generator (#3567) [C#][client][csharp-netcore] Fix csharp netcore defaultheaders (#3562) Fix issue deserializing to nullptr (#3572) [OCaml] Add file post-processing (#3583) [dart2] Fix up test code generation, double deserialization, 'new' keyword deprecation (#3576) Run Qt5 client sample test (#3415) typescript-fetch: allow configuration of headers and credentials (#3586) using partials in ruby api_client (#3564) [OCaml] Added optional params support in API operations (#3568) [Rust Server] Generate valid Rustdocs for lazy_static items (#3556) Fix NPM build for Typescript-fetch (#3403) Expand path templates via resttemplate's uriTemplateHandler (#3500) Readme updated with a new tutorial and company using OpenAPI Generator (#3566) Fix logic of `getNullableType` of csharp server and client. (#3537) [Ruby] clean up Ruby dev dependencies (#3551) ...

pmundt · 2019-08-07T09:26:21Z

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This PR fixes up a number of issues with the current dart2 generator:

The test code generator is currently broken due to not taking the targeted classname into account
Double deserialization in JSON is corrected to avoid int/double type mismatch exceptions
Use of the deprecated 'new' keyword is dropped in line with the official 'effective dart' guide, something that linters are now beginning to warn about.

@ircecho @swipesight @jaumard

At present test generation has a stray hard-coded reference to the pet store Pet() class, which should reflect the actual classname under test.

At present the generated code does not correctly handle transitioning to double when dealing with non-integer types in JSON deserialization. This ends up with dart raising an unhandled type mismatch exception: Unhandled exception: type 'int' is not a subtype of type 'double' where ... Using the .toDouble() conversion when a double type is expected fixes this up by making the typing explicit.

The use of the 'new' keyword in dart2 is deprecated and should be avoided, as per the official guidance of the dart2 authors: https://dart.dev/guides/language/effective-dart/usage#dont-use-new

wing328 · 2019-08-08T14:22:54Z


 # **updatePet**
-> updatePet(body)
+> updatePet(pet)


@pmundt Which version of OpenAPI Generator are you using when working on this PR?
If it's the latest version, body should be used instead of pet.

This was done with the current master from git shortly before the PR was created - with a full clean/install. I can attempt to wipe the tree and try it again in case this has accidentally cached some old build artifacts.

👌 let me pull the changes locally to test it out.

Your change looks good. I'll troubleshoot after merging your fix into master.

wing328 · 2019-08-08T16:16:06Z

Minor suggestion: please create a new branch for the change moving forward.

wing328 · 2019-08-10T07:55:50Z

@pmundt thanks for the PR, which has been included in the 4.1.0 release: https://twitter.com/oas_generator/status/1160000504455319553

@JsonProperty

* master: (122 commits) Fix#3604 by adding undefined as return type to headers and credentials methods in runtime.ts (#3605) Prepare 4.1.1-SNAPSHOT (#3603) Prepare 4.1.0 release (#3597) [java][client][jax-rs] Add a constant for Jackson @JsonProperty (#3560) restore openapi3 petstore.yaml (#3590) Add a new NodeJS Express server generator (#3567) [C#][client][csharp-netcore] Fix csharp netcore defaultheaders (#3562) Fix issue deserializing to nullptr (#3572) [OCaml] Add file post-processing (#3583) [dart2] Fix up test code generation, double deserialization, 'new' keyword deprecation (#3576) Run Qt5 client sample test (#3415) typescript-fetch: allow configuration of headers and credentials (#3586) using partials in ruby api_client (#3564) [OCaml] Added optional params support in API operations (#3568) [Rust Server] Generate valid Rustdocs for lazy_static items (#3556) Fix NPM build for Typescript-fetch (#3403) Expand path templates via resttemplate's uriTemplateHandler (#3500) Readme updated with a new tutorial and company using OpenAPI Generator (#3566) Fix logic of `getNullableType` of csharp server and client. (#3537) [Ruby] clean up Ruby dev dependencies (#3551) ...

pmundt · 2019-08-07T09:26:21Z

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This PR fixes up a number of issues with the current dart2 generator:

The test code generator is currently broken due to not taking the targeted classname into account
Double deserialization in JSON is corrected to avoid int/double type mismatch exceptions
Use of the deprecated 'new' keyword is dropped in line with the official 'effective dart' guide, something that linters are now beginning to warn about.

@ircecho @swipesight @jaumard

At present test generation has a stray hard-coded reference to the pet store Pet() class, which should reflect the actual classname under test.

At present the generated code does not correctly handle transitioning to double when dealing with non-integer types in JSON deserialization. This ends up with dart raising an unhandled type mismatch exception: Unhandled exception: type 'int' is not a subtype of type 'double' where ... Using the .toDouble() conversion when a double type is expected fixes this up by making the typing explicit.

The use of the 'new' keyword in dart2 is deprecated and should be avoided, as per the official guidance of the dart2 authors: https://dart.dev/guides/language/effective-dart/usage#dont-use-new

wing328 · 2019-08-08T14:22:54Z


 # **updatePet**
-> updatePet(body)
+> updatePet(pet)


@pmundt Which version of OpenAPI Generator are you using when working on this PR?
If it's the latest version, body should be used instead of pet.

This was done with the current master from git shortly before the PR was created - with a full clean/install. I can attempt to wipe the tree and try it again in case this has accidentally cached some old build artifacts.

👌 let me pull the changes locally to test it out.

Your change looks good. I'll troubleshoot after merging your fix into master.

wing328 · 2019-08-08T16:16:06Z

Minor suggestion: please create a new branch for the change moving forward.

wing328 · 2019-08-10T07:55:50Z

@pmundt thanks for the PR, which has been included in the 4.1.0 release: https://twitter.com/oas_generator/status/1160000504455319553

@JsonProperty

* master: (122 commits) Fix#3604 by adding undefined as return type to headers and credentials methods in runtime.ts (#3605) Prepare 4.1.1-SNAPSHOT (#3603) Prepare 4.1.0 release (#3597) [java][client][jax-rs] Add a constant for Jackson @JsonProperty (#3560) restore openapi3 petstore.yaml (#3590) Add a new NodeJS Express server generator (#3567) [C#][client][csharp-netcore] Fix csharp netcore defaultheaders (#3562) Fix issue deserializing to nullptr (#3572) [OCaml] Add file post-processing (#3583) [dart2] Fix up test code generation, double deserialization, 'new' keyword deprecation (#3576) Run Qt5 client sample test (#3415) typescript-fetch: allow configuration of headers and credentials (#3586) using partials in ruby api_client (#3564) [OCaml] Added optional params support in API operations (#3568) [Rust Server] Generate valid Rustdocs for lazy_static items (#3556) Fix NPM build for Typescript-fetch (#3403) Expand path templates via resttemplate's uriTemplateHandler (#3500) Readme updated with a new tutorial and company using OpenAPI Generator (#3566) Fix logic of `getNullableType` of csharp server and client. (#3537) [Ruby] clean up Ruby dev dependencies (#3551) ...

pmundt · 2019-08-07T09:26:21Z

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This PR fixes up a number of issues with the current dart2 generator:

The test code generator is currently broken due to not taking the targeted classname into account
Double deserialization in JSON is corrected to avoid int/double type mismatch exceptions
Use of the deprecated 'new' keyword is dropped in line with the official 'effective dart' guide, something that linters are now beginning to warn about.

@ircecho @swipesight @jaumard

At present test generation has a stray hard-coded reference to the pet store Pet() class, which should reflect the actual classname under test.

At present the generated code does not correctly handle transitioning to double when dealing with non-integer types in JSON deserialization. This ends up with dart raising an unhandled type mismatch exception: Unhandled exception: type 'int' is not a subtype of type 'double' where ... Using the .toDouble() conversion when a double type is expected fixes this up by making the typing explicit.

The use of the 'new' keyword in dart2 is deprecated and should be avoided, as per the official guidance of the dart2 authors: https://dart.dev/guides/language/effective-dart/usage#dont-use-new

wing328 · 2019-08-08T14:22:54Z


 # **updatePet**
-> updatePet(body)
+> updatePet(pet)


@pmundt Which version of OpenAPI Generator are you using when working on this PR?
If it's the latest version, body should be used instead of pet.

This was done with the current master from git shortly before the PR was created - with a full clean/install. I can attempt to wipe the tree and try it again in case this has accidentally cached some old build artifacts.

👌 let me pull the changes locally to test it out.

Your change looks good. I'll troubleshoot after merging your fix into master.

wing328 · 2019-08-08T16:16:06Z

Minor suggestion: please create a new branch for the change moving forward.

wing328 · 2019-08-10T07:55:50Z

@pmundt thanks for the PR, which has been included in the 4.1.0 release: https://twitter.com/oas_generator/status/1160000504455319553

@JsonProperty

* master: (122 commits) Fix#3604 by adding undefined as return type to headers and credentials methods in runtime.ts (#3605) Prepare 4.1.1-SNAPSHOT (#3603) Prepare 4.1.0 release (#3597) [java][client][jax-rs] Add a constant for Jackson @JsonProperty (#3560) restore openapi3 petstore.yaml (#3590) Add a new NodeJS Express server generator (#3567) [C#][client][csharp-netcore] Fix csharp netcore defaultheaders (#3562) Fix issue deserializing to nullptr (#3572) [OCaml] Add file post-processing (#3583) [dart2] Fix up test code generation, double deserialization, 'new' keyword deprecation (#3576) Run Qt5 client sample test (#3415) typescript-fetch: allow configuration of headers and credentials (#3586) using partials in ruby api_client (#3564) [OCaml] Added optional params support in API operations (#3568) [Rust Server] Generate valid Rustdocs for lazy_static items (#3556) Fix NPM build for Typescript-fetch (#3403) Expand path templates via resttemplate's uriTemplateHandler (#3500) Readme updated with a new tutorial and company using OpenAPI Generator (#3566) Fix logic of `getNullableType` of csharp server and client. (#3537) [Ruby] clean up Ruby dev dependencies (#3551) ...

pmundt · 2019-08-07T09:26:21Z

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This PR fixes up a number of issues with the current dart2 generator:

The test code generator is currently broken due to not taking the targeted classname into account
Double deserialization in JSON is corrected to avoid int/double type mismatch exceptions
Use of the deprecated 'new' keyword is dropped in line with the official 'effective dart' guide, something that linters are now beginning to warn about.

@ircecho @swipesight @jaumard

At present test generation has a stray hard-coded reference to the pet store Pet() class, which should reflect the actual classname under test.

At present the generated code does not correctly handle transitioning to double when dealing with non-integer types in JSON deserialization. This ends up with dart raising an unhandled type mismatch exception: Unhandled exception: type 'int' is not a subtype of type 'double' where ... Using the .toDouble() conversion when a double type is expected fixes this up by making the typing explicit.

The use of the 'new' keyword in dart2 is deprecated and should be avoided, as per the official guidance of the dart2 authors: https://dart.dev/guides/language/effective-dart/usage#dont-use-new

wing328 · 2019-08-08T14:22:54Z


 # **updatePet**
-> updatePet(body)
+> updatePet(pet)


@pmundt Which version of OpenAPI Generator are you using when working on this PR?
If it's the latest version, body should be used instead of pet.

This was done with the current master from git shortly before the PR was created - with a full clean/install. I can attempt to wipe the tree and try it again in case this has accidentally cached some old build artifacts.

👌 let me pull the changes locally to test it out.

Your change looks good. I'll troubleshoot after merging your fix into master.

wing328 · 2019-08-08T16:16:06Z

Minor suggestion: please create a new branch for the change moving forward.

wing328 · 2019-08-10T07:55:50Z

@pmundt thanks for the PR, which has been included in the 4.1.0 release: https://twitter.com/oas_generator/status/1160000504455319553

@JsonProperty

* master: (122 commits) Fix#3604 by adding undefined as return type to headers and credentials methods in runtime.ts (#3605) Prepare 4.1.1-SNAPSHOT (#3603) Prepare 4.1.0 release (#3597) [java][client][jax-rs] Add a constant for Jackson @JsonProperty (#3560) restore openapi3 petstore.yaml (#3590) Add a new NodeJS Express server generator (#3567) [C#][client][csharp-netcore] Fix csharp netcore defaultheaders (#3562) Fix issue deserializing to nullptr (#3572) [OCaml] Add file post-processing (#3583) [dart2] Fix up test code generation, double deserialization, 'new' keyword deprecation (#3576) Run Qt5 client sample test (#3415) typescript-fetch: allow configuration of headers and credentials (#3586) using partials in ruby api_client (#3564) [OCaml] Added optional params support in API operations (#3568) [Rust Server] Generate valid Rustdocs for lazy_static items (#3556) Fix NPM build for Typescript-fetch (#3403) Expand path templates via resttemplate's uriTemplateHandler (#3500) Readme updated with a new tutorial and company using OpenAPI Generator (#3566) Fix logic of `getNullableType` of csharp server and client. (#3537) [Ruby] clean up Ruby dev dependencies (#3551) ...

pmundt · 2019-08-07T09:26:21Z

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This PR fixes up a number of issues with the current dart2 generator:

The test code generator is currently broken due to not taking the targeted classname into account
Double deserialization in JSON is corrected to avoid int/double type mismatch exceptions
Use of the deprecated 'new' keyword is dropped in line with the official 'effective dart' guide, something that linters are now beginning to warn about.

@ircecho @swipesight @jaumard

At present test generation has a stray hard-coded reference to the pet store Pet() class, which should reflect the actual classname under test.

At present the generated code does not correctly handle transitioning to double when dealing with non-integer types in JSON deserialization. This ends up with dart raising an unhandled type mismatch exception: Unhandled exception: type 'int' is not a subtype of type 'double' where ... Using the .toDouble() conversion when a double type is expected fixes this up by making the typing explicit.

The use of the 'new' keyword in dart2 is deprecated and should be avoided, as per the official guidance of the dart2 authors: https://dart.dev/guides/language/effective-dart/usage#dont-use-new

wing328 · 2019-08-08T14:22:54Z


 # **updatePet**
-> updatePet(body)
+> updatePet(pet)


@pmundt Which version of OpenAPI Generator are you using when working on this PR?
If it's the latest version, body should be used instead of pet.

This was done with the current master from git shortly before the PR was created - with a full clean/install. I can attempt to wipe the tree and try it again in case this has accidentally cached some old build artifacts.

👌 let me pull the changes locally to test it out.

Your change looks good. I'll troubleshoot after merging your fix into master.

wing328 · 2019-08-08T16:16:06Z

Minor suggestion: please create a new branch for the change moving forward.

wing328 · 2019-08-10T07:55:50Z

@pmundt thanks for the PR, which has been included in the 4.1.0 release: https://twitter.com/oas_generator/status/1160000504455319553

@JsonProperty

* master: (122 commits) Fix#3604 by adding undefined as return type to headers and credentials methods in runtime.ts (#3605) Prepare 4.1.1-SNAPSHOT (#3603) Prepare 4.1.0 release (#3597) [java][client][jax-rs] Add a constant for Jackson @JsonProperty (#3560) restore openapi3 petstore.yaml (#3590) Add a new NodeJS Express server generator (#3567) [C#][client][csharp-netcore] Fix csharp netcore defaultheaders (#3562) Fix issue deserializing to nullptr (#3572) [OCaml] Add file post-processing (#3583) [dart2] Fix up test code generation, double deserialization, 'new' keyword deprecation (#3576) Run Qt5 client sample test (#3415) typescript-fetch: allow configuration of headers and credentials (#3586) using partials in ruby api_client (#3564) [OCaml] Added optional params support in API operations (#3568) [Rust Server] Generate valid Rustdocs for lazy_static items (#3556) Fix NPM build for Typescript-fetch (#3403) Expand path templates via resttemplate's uriTemplateHandler (#3500) Readme updated with a new tutorial and company using OpenAPI Generator (#3566) Fix logic of `getNullableType` of csharp server and client. (#3537) [Ruby] clean up Ruby dev dependencies (#3551) ...

pmundt · 2019-08-07T09:26:21Z

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This PR fixes up a number of issues with the current dart2 generator:

The test code generator is currently broken due to not taking the targeted classname into account
Double deserialization in JSON is corrected to avoid int/double type mismatch exceptions
Use of the deprecated 'new' keyword is dropped in line with the official 'effective dart' guide, something that linters are now beginning to warn about.

@ircecho @swipesight @jaumard

At present test generation has a stray hard-coded reference to the pet store Pet() class, which should reflect the actual classname under test.

At present the generated code does not correctly handle transitioning to double when dealing with non-integer types in JSON deserialization. This ends up with dart raising an unhandled type mismatch exception: Unhandled exception: type 'int' is not a subtype of type 'double' where ... Using the .toDouble() conversion when a double type is expected fixes this up by making the typing explicit.

The use of the 'new' keyword in dart2 is deprecated and should be avoided, as per the official guidance of the dart2 authors: https://dart.dev/guides/language/effective-dart/usage#dont-use-new

wing328 · 2019-08-08T14:22:54Z


 # **updatePet**
-> updatePet(body)
+> updatePet(pet)


@pmundt Which version of OpenAPI Generator are you using when working on this PR?
If it's the latest version, body should be used instead of pet.

This was done with the current master from git shortly before the PR was created - with a full clean/install. I can attempt to wipe the tree and try it again in case this has accidentally cached some old build artifacts.

👌 let me pull the changes locally to test it out.

Your change looks good. I'll troubleshoot after merging your fix into master.

wing328 · 2019-08-08T16:16:06Z

Minor suggestion: please create a new branch for the change moving forward.

wing328 · 2019-08-10T07:55:50Z

@pmundt thanks for the PR, which has been included in the 4.1.0 release: https://twitter.com/oas_generator/status/1160000504455319553

@JsonProperty

* master: (122 commits) Fix#3604 by adding undefined as return type to headers and credentials methods in runtime.ts (#3605) Prepare 4.1.1-SNAPSHOT (#3603) Prepare 4.1.0 release (#3597) [java][client][jax-rs] Add a constant for Jackson @JsonProperty (#3560) restore openapi3 petstore.yaml (#3590) Add a new NodeJS Express server generator (#3567) [C#][client][csharp-netcore] Fix csharp netcore defaultheaders (#3562) Fix issue deserializing to nullptr (#3572) [OCaml] Add file post-processing (#3583) [dart2] Fix up test code generation, double deserialization, 'new' keyword deprecation (#3576) Run Qt5 client sample test (#3415) typescript-fetch: allow configuration of headers and credentials (#3586) using partials in ruby api_client (#3564) [OCaml] Added optional params support in API operations (#3568) [Rust Server] Generate valid Rustdocs for lazy_static items (#3556) Fix NPM build for Typescript-fetch (#3403) Expand path templates via resttemplate's uriTemplateHandler (#3500) Readme updated with a new tutorial and company using OpenAPI Generator (#3566) Fix logic of `getNullableType` of csharp server and client. (#3537) [Ruby] clean up Ruby dev dependencies (#3551) ...

pmundt · 2019-08-07T09:26:21Z

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This PR fixes up a number of issues with the current dart2 generator:

The test code generator is currently broken due to not taking the targeted classname into account
Double deserialization in JSON is corrected to avoid int/double type mismatch exceptions
Use of the deprecated 'new' keyword is dropped in line with the official 'effective dart' guide, something that linters are now beginning to warn about.

@ircecho @swipesight @jaumard

At present test generation has a stray hard-coded reference to the pet store Pet() class, which should reflect the actual classname under test.

At present the generated code does not correctly handle transitioning to double when dealing with non-integer types in JSON deserialization. This ends up with dart raising an unhandled type mismatch exception: Unhandled exception: type 'int' is not a subtype of type 'double' where ... Using the .toDouble() conversion when a double type is expected fixes this up by making the typing explicit.

The use of the 'new' keyword in dart2 is deprecated and should be avoided, as per the official guidance of the dart2 authors: https://dart.dev/guides/language/effective-dart/usage#dont-use-new

wing328 · 2019-08-08T14:22:54Z


 # **updatePet**
-> updatePet(body)
+> updatePet(pet)


@pmundt Which version of OpenAPI Generator are you using when working on this PR?
If it's the latest version, body should be used instead of pet.

This was done with the current master from git shortly before the PR was created - with a full clean/install. I can attempt to wipe the tree and try it again in case this has accidentally cached some old build artifacts.

👌 let me pull the changes locally to test it out.

Your change looks good. I'll troubleshoot after merging your fix into master.

wing328 · 2019-08-08T16:16:06Z

Minor suggestion: please create a new branch for the change moving forward.

wing328 · 2019-08-10T07:55:50Z

@pmundt thanks for the PR, which has been included in the 4.1.0 release: https://twitter.com/oas_generator/status/1160000504455319553

@JsonProperty

* master: (122 commits) Fix#3604 by adding undefined as return type to headers and credentials methods in runtime.ts (#3605) Prepare 4.1.1-SNAPSHOT (#3603) Prepare 4.1.0 release (#3597) [java][client][jax-rs] Add a constant for Jackson @JsonProperty (#3560) restore openapi3 petstore.yaml (#3590) Add a new NodeJS Express server generator (#3567) [C#][client][csharp-netcore] Fix csharp netcore defaultheaders (#3562) Fix issue deserializing to nullptr (#3572) [OCaml] Add file post-processing (#3583) [dart2] Fix up test code generation, double deserialization, 'new' keyword deprecation (#3576) Run Qt5 client sample test (#3415) typescript-fetch: allow configuration of headers and credentials (#3586) using partials in ruby api_client (#3564) [OCaml] Added optional params support in API operations (#3568) [Rust Server] Generate valid Rustdocs for lazy_static items (#3556) Fix NPM build for Typescript-fetch (#3403) Expand path templates via resttemplate's uriTemplateHandler (#3500) Readme updated with a new tutorial and company using OpenAPI Generator (#3566) Fix logic of `getNullableType` of csharp server and client. (#3537) [Ruby] clean up Ruby dev dependencies (#3551) ...

pmundt added 4 commits August 7, 2019 10:12

dart2: Use the correct classname in test generation
f2ffb7f
At present test generation has a stray hard-coded reference to the pet store Pet() class, which should reflect the actual classname under test.

dart2: Drop use of deprecated 'new' keyword in generated code
838359f
The use of the 'new' keyword in dart2 is deprecated and should be avoided, as per the official guidance of the dart2 authors: https://dart.dev/guides/language/effective-dart/usage#dont-use-new

dart2: Regenerate samples for mustache template changes
6b5770f

wing328 added Client: Dart Enhancement: CI/Test Issue: Bug labels Aug 7, 2019

wing328 added this to the 4.1.0 milestone Aug 7, 2019

wing328 reviewed Aug 8, 2019
View reviewed changes

wing328 merged commit 4b0fc30 into OpenAPITools:masterAug 8, 2019

pmundt added 4 commits August 7, 2019 10:12

dart2: Use the correct classname in test generation
f2ffb7f
At present test generation has a stray hard-coded reference to the pet store Pet() class, which should reflect the actual classname under test.

dart2: Drop use of deprecated 'new' keyword in generated code
838359f
The use of the 'new' keyword in dart2 is deprecated and should be avoided, as per the official guidance of the dart2 authors: https://dart.dev/guides/language/effective-dart/usage#dont-use-new

dart2: Regenerate samples for mustache template changes
6b5770f

wing328 added Client: Dart Enhancement: CI/Test Issue: Bug labels Aug 7, 2019

wing328 added this to the 4.1.0 milestone Aug 7, 2019

wing328 reviewed Aug 8, 2019
View reviewed changes

wing328 merged commit 4b0fc30 into OpenAPITools:masterAug 8, 2019

pmundt added 4 commits August 7, 2019 10:12

dart2: Use the correct classname in test generation
f2ffb7f
At present test generation has a stray hard-coded reference to the pet store Pet() class, which should reflect the actual classname under test.

dart2: Drop use of deprecated 'new' keyword in generated code
838359f
The use of the 'new' keyword in dart2 is deprecated and should be avoided, as per the official guidance of the dart2 authors: https://dart.dev/guides/language/effective-dart/usage#dont-use-new

dart2: Regenerate samples for mustache template changes
6b5770f

wing328 added Client: Dart Enhancement: CI/Test Issue: Bug labels Aug 7, 2019

wing328 added this to the 4.1.0 milestone Aug 7, 2019

wing328 reviewed Aug 8, 2019
View reviewed changes

wing328 merged commit 4b0fc30 into OpenAPITools:masterAug 8, 2019

pmundt added 4 commits August 7, 2019 10:12

dart2: Use the correct classname in test generation
f2ffb7f
At present test generation has a stray hard-coded reference to the pet store Pet() class, which should reflect the actual classname under test.

dart2: Drop use of deprecated 'new' keyword in generated code
838359f
The use of the 'new' keyword in dart2 is deprecated and should be avoided, as per the official guidance of the dart2 authors: https://dart.dev/guides/language/effective-dart/usage#dont-use-new

dart2: Regenerate samples for mustache template changes
6b5770f

wing328 added Client: Dart Enhancement: CI/Test Issue: Bug labels Aug 7, 2019

wing328 added this to the 4.1.0 milestone Aug 7, 2019

wing328 reviewed Aug 8, 2019
View reviewed changes

wing328 merged commit 4b0fc30 into OpenAPITools:masterAug 8, 2019

pmundt added 4 commits August 7, 2019 10:12

dart2: Use the correct classname in test generation
f2ffb7f
At present test generation has a stray hard-coded reference to the pet store Pet() class, which should reflect the actual classname under test.

dart2: Drop use of deprecated 'new' keyword in generated code
838359f
The use of the 'new' keyword in dart2 is deprecated and should be avoided, as per the official guidance of the dart2 authors: https://dart.dev/guides/language/effective-dart/usage#dont-use-new

dart2: Regenerate samples for mustache template changes
6b5770f

wing328 added Client: Dart Enhancement: CI/Test Issue: Bug labels Aug 7, 2019

wing328 added this to the 4.1.0 milestone Aug 7, 2019

wing328 reviewed Aug 8, 2019
View reviewed changes

wing328 merged commit 4b0fc30 into OpenAPITools:masterAug 8, 2019

pmundt added 4 commits August 7, 2019 10:12

dart2: Use the correct classname in test generation
f2ffb7f
At present test generation has a stray hard-coded reference to the pet store Pet() class, which should reflect the actual classname under test.

dart2: Drop use of deprecated 'new' keyword in generated code
838359f
The use of the 'new' keyword in dart2 is deprecated and should be avoided, as per the official guidance of the dart2 authors: https://dart.dev/guides/language/effective-dart/usage#dont-use-new

dart2: Regenerate samples for mustache template changes
6b5770f

wing328 added Client: Dart Enhancement: CI/Test Issue: Bug labels Aug 7, 2019

wing328 added this to the 4.1.0 milestone Aug 7, 2019

wing328 reviewed Aug 8, 2019
View reviewed changes

wing328 merged commit 4b0fc30 into OpenAPITools:masterAug 8, 2019

pmundt added 4 commits August 7, 2019 10:12

dart2: Use the correct classname in test generation
f2ffb7f
At present test generation has a stray hard-coded reference to the pet store Pet() class, which should reflect the actual classname under test.

dart2: Drop use of deprecated 'new' keyword in generated code
838359f
The use of the 'new' keyword in dart2 is deprecated and should be avoided, as per the official guidance of the dart2 authors: https://dart.dev/guides/language/effective-dart/usage#dont-use-new

dart2: Regenerate samples for mustache template changes
6b5770f

wing328 added Client: Dart Enhancement: CI/Test Issue: Bug labels Aug 7, 2019

wing328 added this to the 4.1.0 milestone Aug 7, 2019

wing328 reviewed Aug 8, 2019
View reviewed changes

wing328 merged commit 4b0fc30 into OpenAPITools:masterAug 8, 2019

pmundt added 4 commits August 7, 2019 10:12

dart2: Use the correct classname in test generation
f2ffb7f
At present test generation has a stray hard-coded reference to the pet store Pet() class, which should reflect the actual classname under test.

dart2: Drop use of deprecated 'new' keyword in generated code
838359f
The use of the 'new' keyword in dart2 is deprecated and should be avoided, as per the official guidance of the dart2 authors: https://dart.dev/guides/language/effective-dart/usage#dont-use-new

dart2: Regenerate samples for mustache template changes
6b5770f

wing328 added Client: Dart Enhancement: CI/Test Issue: Bug labels Aug 7, 2019

wing328 added this to the 4.1.0 milestone Aug 7, 2019

wing328 reviewed Aug 8, 2019
View reviewed changes

wing328 merged commit 4b0fc30 into OpenAPITools:masterAug 8, 2019

Uh oh!

Uh oh!

Conversation

pmundt commented Aug 7, 2019

PR checklist

Description of the PR

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wing328 commented Aug 8, 2019

Uh oh!

wing328 commented Aug 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

pmundt commented Aug 7, 2019

PR checklist

Description of the PR

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wing328 commented Aug 8, 2019

Uh oh!

wing328 commented Aug 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

pmundt commented Aug 7, 2019

PR checklist

Description of the PR

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wing328 commented Aug 8, 2019

Uh oh!

wing328 commented Aug 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!