[C++][Pistache] Add missing setter for arrays - #3837

Merged
etherealjoy merged 2 commits into
OpenAPITools:masterfrom
muttleyxd:pistache-is-set
Sep 7, 2019
Merged

[C++][Pistache] Add missing setter for arrays#3837
etherealjoy merged 2 commits into
OpenAPITools:masterfrom
muttleyxd:pistache-is-set

Conversation

@muttleyxd

@muttleyxdmuttleyxd commented Sep 5, 2019

Copy link
Copy Markdown
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@ravinikam@stkrwork@etherealjoy@MartinDelille@muttleyxd

Description of the PR

Fixes#3769
I would like to refactor this for 5.X releases with #3417

@muttleyxdmuttleyxd mentioned this pull request Sep 5, 2019
Closed
1 task
@muttleyxd

muttleyxd commented Sep 5, 2019

Copy link
Copy Markdown
ContributorAuthor

Shall we generate setter for required fields?

@etherealjoy

etherealjoy commented Sep 5, 2019

Copy link
Copy Markdown
Contributor

I think we need to do for all.

@muttleyxd

muttleyxd commented Sep 5, 2019

Copy link
Copy Markdown
ContributorAuthor

That's how it's done here, so I'm waiting for review 😄

etherealjoy
etherealjoy requested changes Sep 5, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/cpp-pistache-server/model-header.mustache
Comment threadmodules/openapi-generator/src/main/resources/cpp-pistache-server/model-source.mustache
@etherealjoyetherealjoy added this to the 4.1.2 milestone Sep 7, 2019
@etherealjoy
etherealjoy merged commit f2fe4fc into OpenAPITools:masterSep 7, 2019
hokamoto pushed a commit to hokamoto/openapi-generator that referenced this pull request Sep 12, 2019
@muttleyxd@hokamoto
[C++][Pistache] Add missing setter for arrays (OpenAPITools#3837)
86adb0a
* [C++][Pistache] Add missing setter for arrays
FixesOpenAPITools#3769
* [C++][Pistache] Update Petstore sample
@wing328

wing328 commented Sep 12, 2019

Copy link
Copy Markdown
Member

@muttleyxd thanks for the PR, which has been included in the v4.1.2 release: https://twitter.com/oas_generator/status/1172068944355528705

wing328 pushed a commit that referenced this pull request Sep 13, 2019
@hokamoto@wing328
Add Nim client code generator (#3879)
f15f814
* First version of Nim Client
* Add some codes
* Add some codes
* Add some codes
* Add some codes
* Add some codes
* First version of Nim Client
* Add some codes
* Add some codes
* [Dart] Fix README template and update testing doco (#3809)
* [Dart] Fix README template and update testing doco
- deleted redundant shell script
- fixed and updated README template
- updated test package and moved to a dev_dependency
- removed old unused dev_dependency packages
- updated testing documentation in petstore sample
* Remove references to dart-flutter-petstore.sh
* Fix typos
* Fix typo
* Support custom git repository (#3757)
* add gitHost param to GeneratorSettings and related
* parameterize gitHost in READMEs
* parameterize gitHost in go.mod
* parameterize gitHost in git_push
* update petstore samples
* run ./bin/utils/export_docs_generators.sh
* run meta-codehen.sh
* Revert "run meta-codehen.sh"
This reverts commit d6d579f.
* Revert "run ./bin/utils/export_docs_generators.sh"
This reverts commit 1b81538.
* Revert "update petstore samples"
This reverts commit f513add.
* run ensure-up-to-date
* Add links to article and video (#3820)
* Better Go code format (#3819)
* better varible naming
* better comments
* better code format for go experimental client
* better comment, update samples
* Add some codes
* Add some codes
* Add some codes
* Add gRPC Protobuf schema generator (#3818)
* add grpc protobuf generator
* update doc
* add new doc
* add windows batch, comment out root proto
* 1792 fix remote spec handling and hash calculation (#3440)
* fixed bug where nullApi.java would be generated. Instead, generated DefaultApi.java to match the default path /{pathParam} (#3821)
* Revert "1792 fix remote spec handling and hash calculation (#3440)"
This reverts commit 2a2eefe.
* Add nickmeinhold to Dart technical committee (#3830)
* Bug #2845 typescript angular inheritance (#3812)
* issue #2845: enable 'supportsMultipleInheritance' on typescript angular client codegen
- note I reran ./bin/openapi3/typescript-angular-petstore-all.sh and no changes occurred.
this suggests to me that the petstore.yaml sample should be improved to make use of the
anyOf / allOf / oneOf keywords, in order to better show the effects of changes on generated code.
* issue #2845: run ./bin/openapi3/typescript-angular-petstore-all.sh
* run `mvn clean package && ./bin/typescript-angular-petstore-all.sh`
* revert extranous files
* fix warnings in csharp-netcore client (#3831)
* Add missing files to the form request (#3834)
* [client][go] avoid duplicated reflect imports (#3847)
* Following up for #3440 (1792 fix remote spec handling and hash calculation) (#3826)
* This patch fixes the bug that we cannot access to remote files when checking file updates.
Following up #3440, supporting auth.
* 1792 fix remote spec handling and hash calculation (#3440)
(cherry picked from commit 2a2eefe)
* fix detecting remote file / local file logic while finding the hash file, taking care of IllegalArgumentException for local files.
* add testcase
* Add a link (#3850)
* Add Element AI to the list (#3856)
* maven-plugin-plugin 3.6.0 (#3854)
* [Java][okhttp-gson] fix failure to deserialize floats (#3846)
* fixed bug where nullApi.java would be generated. Instead, generated DefaultApi.java to match the default path /{pathParam}
* fix to bug #3157
* update samples
* Adds Http Info To Dart Api (#3851)
* [C++][Pistache] Add missing setter for arrays (#3837)
* [C++][Pistache] Add missing setter for arrays
Fixes#3769
* [C++][Pistache] Update Petstore sample
* typescript-inversify: improve check for required parameters, support multiple media types (#3849)
* [typescript-inversify] Allow falsy parameters
A required parameter to an api method must not be `null` or `undefined`.
It can be any other falsy value, e.g. `""`, `0` or `false` though. This
change makes sure an error is only thrown in the former case and not in
the latter.
* [typescript-inversify] Handle multiple media types
The Accept and Content-Type HTTP headers can contain a list of media
types. Previously all but the first media type in the api definition
were ignored. Now the headers are properly generated.
* [typescript-inversify] Fix http client interface
The api service methods allow the `body` parameter to be optional. The
parameter is then passed to an `IHttpClient`. So it needs to be optional
there as well.
Also fixed the sample implementation `HttpClient`.
Fixes#3618.
* [typescript-inversify] Regenerate Petstore sample
* [typescript-inversify] Use more explicit null check
This does not change the semantic of the generated code, but makes it more explicit.
Co-Authored-By: Esteban Gehring <esteban.gehring@gmail.com>
* [typescript-angular] allow empty string basePath (#3489)
* [typescript-angular] Fixing #2731 - empty string basePath
* typescript-angular: refactor base path configuration
* typescript-angular: refactor base path configuration
* Fix/r/serialization fix and minor 3xx resp fix (#3817)
* fix(qlik): fix for minor serialization bug
* fix(r): add petsore generated classes
* fix(r): indendation fixes
* typescript-axios: Fix baseoptions (#3866)
* Fixed missing baseOptions of typescript-axios.
The typescript-axios template was missing the baseOptions setting when building an API Configuration. Set it.
* update sample.
* re-generate typescript axios samples
* Rename gRPC generator to "protobuf-schema" (#3864)
* rename grpc generator to protobuf-schema
* update doc
* Prepare v4.1.2 release (#3873)
* update samples
* update date
* fix version in readme
* BugFix #2053 Spring Boot fails to parse LocalDate query parameter (#3860)
Adds the format annotation so that Spring is able to serialize OpenApi date/date-time format into LocalDate/OffsetDateTime.
* update doc, samples (#3875)
* update stable release
* Update the batch for Windows
* Add a test snippet
* Update ensure-up-to-date
* Add Nim to README.md
* Ran ensure-up-to-date to pass CircleCI tests
jimschubert added a commit that referenced this pull request Sep 13, 2019
@jimschubert
Merge branch 'master' into spring-requestparam-regression
3e2ec0b
* master: (22 commits)
various minor improvements to nim generator (#3883)
Add Nim client code generator (#3879)
updated google-api-client version from 1.23.0 to 1.30.2. Bugfix #3625 (#3882)
typescript-fetch: fix missing comma in multiple imports (#3881)
[scala][client] add Scala code generation test (#3859)
typescript-node: Use HttpError class when rejecting promises (#3876)
update stable release
update doc, samples (#3875)
BugFix #2053 Spring Boot fails to parse LocalDate query parameter (#3860)
fix version in readme
Prepare v4.1.2 release (#3873)
Rename gRPC generator to "protobuf-schema" (#3864)
typescript-axios: Fix baseoptions (#3866)
Fix/r/serialization fix and minor 3xx resp fix (#3817)
[typescript-angular] allow empty string basePath (#3489)
typescript-inversify: improve check for required parameters, support multiple media types (#3849)
[C++][Pistache] Add missing setter for arrays (#3837)
Adds Http Info To Dart Api (#3851)
[Java][okhttp-gson] fix failure to deserialize floats (#3846)
maven-plugin-plugin 3.6.0 (#3854)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etherealjoyetherealjoyetherealjoy approved these changes

Assignees

No one assigned

Labels

Enhancement: GeneralServer: C++

Projects

None yet

Milestone

4.1.2

Development

Successfully merging this pull request may close these issues.

[BUG] No setter function generated for arrays

3 participants

@muttleyxd@etherealjoy@wing328
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[C++][Pistache] Add missing setter for arrays - #3837
Merged
etherealjoy merged 2 commits into
OpenAPITools:masterfrom 
muttleyxd:pistache-is-set
Sep 7, 2019
Merged
[C++][Pistache] Add missing setter for arrays#3837
etherealjoy merged 2 commits into
OpenAPITools:masterfrom 
muttleyxd:pistache-is-set
Conversation
@muttleyxd
@muttleyxdmuttleyxd
commented
Sep 5, 2019

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  •  Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
@ravinikam@stkrwork@etherealjoy@MartinDelille@muttleyxd
Description of the PR
Fixes#3769

I would like to refactor this for 5.X releases with #3417
@muttleyxdmuttleyxd
mentioned this pull request
Sep 5, 2019

Closed

1 task
@muttleyxd
muttleyxd
commented
Sep 5, 2019

Copy link


Copy Markdown

ContributorAuthor
Shall we generate setter for required fields?
@etherealjoy
etherealjoy
commented
Sep 5, 2019

Copy link


Copy Markdown

Contributor
I think we need to do for all.
@muttleyxd
muttleyxd
commented
Sep 5, 2019

Copy link


Copy Markdown

ContributorAuthor
That's how it's done here, so I'm waiting for review 😄
etherealjoy
etherealjoy
requested changes
Sep 5, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/cpp-pistache-server/model-header.mustache
Comment threadmodules/openapi-generator/src/main/resources/cpp-pistache-server/model-source.mustache
@etherealjoyetherealjoy
added this to the 4.1.2 milestone
Sep 7, 2019
@etherealjoy
etherealjoy
merged commit f2fe4fc
into
OpenAPITools:masterSep 7, 2019
hokamoto pushed a commit
to hokamoto/openapi-generator
that referenced
this pull request
Sep 12, 2019
@muttleyxd@hokamoto
[C++][Pistache] Add missing setter for arrays (OpenAPITools#3837)
86adb0a
* [C++][Pistache] Add missing setter for arrays
FixesOpenAPITools#3769
* [C++][Pistache] Update Petstore sample
@wing328
wing328
commented
Sep 12, 2019

Copy link


Copy Markdown

Member
@muttleyxd thanks for the PR, which has been included in the v4.1.2 release: https://twitter.com/oas_generator/status/1172068944355528705
wing328 pushed a commit
that referenced
this pull request
Sep 13, 2019
@hokamoto@wing328
Add Nim client code generator (#3879)
f15f814
* First version of Nim Client
* Add some codes
* Add some codes
* Add some codes
* Add some codes
* Add some codes
* First version of Nim Client
* Add some codes
* Add some codes
* [Dart] Fix README template and update testing doco (#3809)
* [Dart] Fix README template and update testing doco
- deleted redundant shell script
- fixed and updated README template
- updated test package and moved to a dev_dependency
- removed old unused dev_dependency packages
- updated testing documentation in petstore sample
* Remove references to dart-flutter-petstore.sh
* Fix typos
* Fix typo
* Support custom git repository (#3757)
* add gitHost param to GeneratorSettings and related
* parameterize gitHost in READMEs
* parameterize gitHost in go.mod
* parameterize gitHost in git_push
* update petstore samples
* run ./bin/utils/export_docs_generators.sh
* run meta-codehen.sh
* Revert "run meta-codehen.sh"
This reverts commit d6d579f.
* Revert "run ./bin/utils/export_docs_generators.sh"
This reverts commit 1b81538.
* Revert "update petstore samples"
This reverts commit f513add.
* run ensure-up-to-date
* Add links to article and video (#3820)
* Better Go code format (#3819)
* better varible naming
* better comments
* better code format for go experimental client
* better comment, update samples
* Add some codes
* Add some codes
* Add some codes
* Add gRPC Protobuf schema generator (#3818)
* add grpc protobuf generator
* update doc
* add new doc
* add windows batch, comment out root proto
* 1792 fix remote spec handling and hash calculation (#3440)
* fixed bug where nullApi.java would be generated. Instead, generated DefaultApi.java to match the default path /{pathParam} (#3821)
* Revert "1792 fix remote spec handling and hash calculation (#3440)"
This reverts commit 2a2eefe.
* Add nickmeinhold to Dart technical committee (#3830)
* Bug #2845 typescript angular inheritance (#3812)
* issue #2845: enable 'supportsMultipleInheritance' on typescript angular client codegen
- note I reran ./bin/openapi3/typescript-angular-petstore-all.sh and no changes occurred.
this suggests to me that the petstore.yaml sample should be improved to make use of the
anyOf / allOf / oneOf keywords, in order to better show the effects of changes on generated code.
* issue #2845: run ./bin/openapi3/typescript-angular-petstore-all.sh
* run `mvn clean package && ./bin/typescript-angular-petstore-all.sh`
* revert extranous files
* fix warnings in csharp-netcore client (#3831)
* Add missing files to the form request (#3834)
* [client][go] avoid duplicated reflect imports (#3847)
* Following up for #3440 (1792 fix remote spec handling and hash calculation) (#3826)
* This patch fixes the bug that we cannot access to remote files when checking file updates.
Following up #3440, supporting auth.
* 1792 fix remote spec handling and hash calculation (#3440)
(cherry picked from commit 2a2eefe)
* fix detecting remote file / local file logic while finding the hash file, taking care of IllegalArgumentException for local files.
* add testcase
* Add a link (#3850)
* Add Element AI to the list (#3856)
* maven-plugin-plugin 3.6.0 (#3854)
* [Java][okhttp-gson] fix failure to deserialize floats (#3846)
* fixed bug where nullApi.java would be generated. Instead, generated DefaultApi.java to match the default path /{pathParam}
* fix to bug #3157
* update samples
* Adds Http Info To Dart Api (#3851)
* [C++][Pistache] Add missing setter for arrays (#3837)
* [C++][Pistache] Add missing setter for arrays
Fixes#3769
* [C++][Pistache] Update Petstore sample
* typescript-inversify: improve check for required parameters, support multiple media types (#3849)
* [typescript-inversify] Allow falsy parameters
A required parameter to an api method must not be `null` or `undefined`.
It can be any other falsy value, e.g. `""`, `0` or `false` though. This
change makes sure an error is only thrown in the former case and not in
the latter.
* [typescript-inversify] Handle multiple media types
The Accept and Content-Type HTTP headers can contain a list of media
types. Previously all but the first media type in the api definition
were ignored. Now the headers are properly generated.
* [typescript-inversify] Fix http client interface
The api service methods allow the `body` parameter to be optional. The
parameter is then passed to an `IHttpClient`. So it needs to be optional
there as well.
Also fixed the sample implementation `HttpClient`.
Fixes#3618.
* [typescript-inversify] Regenerate Petstore sample
* [typescript-inversify] Use more explicit null check
This does not change the semantic of the generated code, but makes it more explicit.
Co-Authored-By: Esteban Gehring <esteban.gehring@gmail.com>
* [typescript-angular] allow empty string basePath (#3489)
* [typescript-angular] Fixing #2731 - empty string basePath
* typescript-angular: refactor base path configuration
* typescript-angular: refactor base path configuration
* Fix/r/serialization fix and minor 3xx resp fix (#3817)
* fix(qlik): fix for minor serialization bug
* fix(r): add petsore generated classes
* fix(r): indendation fixes
* typescript-axios: Fix baseoptions (#3866)
* Fixed missing baseOptions of typescript-axios.
The typescript-axios template was missing the baseOptions setting when building an API Configuration. Set it.
* update sample.
* re-generate typescript axios samples
* Rename gRPC generator to "protobuf-schema" (#3864)
* rename grpc generator to protobuf-schema
* update doc
* Prepare v4.1.2 release (#3873)
* update samples
* update date
* fix version in readme
* BugFix #2053 Spring Boot fails to parse LocalDate query parameter (#3860)
Adds the format annotation so that Spring is able to serialize OpenApi date/date-time format into LocalDate/OffsetDateTime.
* update doc, samples (#3875)
* update stable release
* Update the batch for Windows
* Add a test snippet
* Update ensure-up-to-date
* Add Nim to README.md
* Ran ensure-up-to-date to pass CircleCI tests
jimschubert added a commit
that referenced
this pull request
Sep 13, 2019
@jimschubert
Merge branch 'master' into spring-requestparam-regression
3e2ec0b
* master: (22 commits)
various minor improvements to nim generator (#3883)
Add Nim client code generator (#3879)
updated google-api-client version from 1.23.0 to 1.30.2. Bugfix #3625 (#3882)
typescript-fetch: fix missing comma in multiple imports (#3881)
[scala][client] add Scala code generation test (#3859)
typescript-node: Use HttpError class when rejecting promises (#3876)
update stable release
update doc, samples (#3875)
BugFix #2053 Spring Boot fails to parse LocalDate query parameter (#3860)
fix version in readme
Prepare v4.1.2 release (#3873)
Rename gRPC generator to "protobuf-schema" (#3864)
typescript-axios: Fix baseoptions (#3866)
Fix/r/serialization fix and minor 3xx resp fix (#3817)
[typescript-angular] allow empty string basePath (#3489)
typescript-inversify: improve check for required parameters, support multiple media types (#3849)
[C++][Pistache] Add missing setter for arrays (#3837)
Adds Http Info To Dart Api (#3851)
[Java][okhttp-gson] fix failure to deserialize floats (#3846)
maven-plugin-plugin 3.6.0 (#3854)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@etherealjoyetherealjoyetherealjoy approved these changes

Assignees


No one assigned


Labels

Enhancement: GeneralServer: C++

Projects


None yet


Milestone

4.1.2

Development

Successfully merging this pull request may close these issues.

[BUG] No setter function generated for arrays


3 participants

@muttleyxd@etherealjoy@wing328

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[C++][Pistache] Add missing setter for arrays - #3837
Merged
etherealjoy merged 2 commits into
OpenAPITools:masterfrom 
muttleyxd:pistache-is-set
Sep 7, 2019
Merged
[C++][Pistache] Add missing setter for arrays#3837
etherealjoy merged 2 commits into
OpenAPITools:masterfrom 
muttleyxd:pistache-is-set
Conversation
@muttleyxd
@muttleyxdmuttleyxd
commented
Sep 5, 2019

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  •  Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
@ravinikam@stkrwork@etherealjoy@MartinDelille@muttleyxd
Description of the PR
Fixes#3769

I would like to refactor this for 5.X releases with #3417
@muttleyxdmuttleyxd
mentioned this pull request
Sep 5, 2019

Closed

1 task
@muttleyxd
muttleyxd
commented
Sep 5, 2019

Copy link


Copy Markdown

ContributorAuthor
Shall we generate setter for required fields?
@etherealjoy
etherealjoy
commented
Sep 5, 2019

Copy link


Copy Markdown

Contributor
I think we need to do for all.
@muttleyxd
muttleyxd
commented
Sep 5, 2019

Copy link


Copy Markdown

ContributorAuthor
That's how it's done here, so I'm waiting for review 😄
etherealjoy
etherealjoy
requested changes
Sep 5, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/cpp-pistache-server/model-header.mustache
Comment threadmodules/openapi-generator/src/main/resources/cpp-pistache-server/model-source.mustache
@etherealjoyetherealjoy
added this to the 4.1.2 milestone
Sep 7, 2019
@etherealjoy
etherealjoy
merged commit f2fe4fc
into
OpenAPITools:masterSep 7, 2019
hokamoto pushed a commit
to hokamoto/openapi-generator
that referenced
this pull request
Sep 12, 2019
@muttleyxd@hokamoto
[C++][Pistache] Add missing setter for arrays (OpenAPITools#3837)
86adb0a
* [C++][Pistache] Add missing setter for arrays
FixesOpenAPITools#3769
* [C++][Pistache] Update Petstore sample
@wing328
wing328
commented
Sep 12, 2019

Copy link


Copy Markdown

Member
@muttleyxd thanks for the PR, which has been included in the v4.1.2 release: https://twitter.com/oas_generator/status/1172068944355528705
wing328 pushed a commit
that referenced
this pull request
Sep 13, 2019
@hokamoto@wing328
Add Nim client code generator (#3879)
f15f814
* First version of Nim Client
* Add some codes
* Add some codes
* Add some codes
* Add some codes
* Add some codes
* First version of Nim Client
* Add some codes
* Add some codes
* [Dart] Fix README template and update testing doco (#3809)
* [Dart] Fix README template and update testing doco
- deleted redundant shell script
- fixed and updated README template
- updated test package and moved to a dev_dependency
- removed old unused dev_dependency packages
- updated testing documentation in petstore sample
* Remove references to dart-flutter-petstore.sh
* Fix typos
* Fix typo
* Support custom git repository (#3757)
* add gitHost param to GeneratorSettings and related
* parameterize gitHost in READMEs
* parameterize gitHost in go.mod
* parameterize gitHost in git_push
* update petstore samples
* run ./bin/utils/export_docs_generators.sh
* run meta-codehen.sh
* Revert "run meta-codehen.sh"
This reverts commit d6d579f.
* Revert "run ./bin/utils/export_docs_generators.sh"
This reverts commit 1b81538.
* Revert "update petstore samples"
This reverts commit f513add.
* run ensure-up-to-date
* Add links to article and video (#3820)
* Better Go code format (#3819)
* better varible naming
* better comments
* better code format for go experimental client
* better comment, update samples
* Add some codes
* Add some codes
* Add some codes
* Add gRPC Protobuf schema generator (#3818)
* add grpc protobuf generator
* update doc
* add new doc
* add windows batch, comment out root proto
* 1792 fix remote spec handling and hash calculation (#3440)
* fixed bug where nullApi.java would be generated. Instead, generated DefaultApi.java to match the default path /{pathParam} (#3821)
* Revert "1792 fix remote spec handling and hash calculation (#3440)"
This reverts commit 2a2eefe.
* Add nickmeinhold to Dart technical committee (#3830)
* Bug #2845 typescript angular inheritance (#3812)
* issue #2845: enable 'supportsMultipleInheritance' on typescript angular client codegen
- note I reran ./bin/openapi3/typescript-angular-petstore-all.sh and no changes occurred.
this suggests to me that the petstore.yaml sample should be improved to make use of the
anyOf / allOf / oneOf keywords, in order to better show the effects of changes on generated code.
* issue #2845: run ./bin/openapi3/typescript-angular-petstore-all.sh
* run `mvn clean package && ./bin/typescript-angular-petstore-all.sh`
* revert extranous files
* fix warnings in csharp-netcore client (#3831)
* Add missing files to the form request (#3834)
* [client][go] avoid duplicated reflect imports (#3847)
* Following up for #3440 (1792 fix remote spec handling and hash calculation) (#3826)
* This patch fixes the bug that we cannot access to remote files when checking file updates.
Following up #3440, supporting auth.
* 1792 fix remote spec handling and hash calculation (#3440)
(cherry picked from commit 2a2eefe)
* fix detecting remote file / local file logic while finding the hash file, taking care of IllegalArgumentException for local files.
* add testcase
* Add a link (#3850)
* Add Element AI to the list (#3856)
* maven-plugin-plugin 3.6.0 (#3854)
* [Java][okhttp-gson] fix failure to deserialize floats (#3846)
* fixed bug where nullApi.java would be generated. Instead, generated DefaultApi.java to match the default path /{pathParam}
* fix to bug #3157
* update samples
* Adds Http Info To Dart Api (#3851)
* [C++][Pistache] Add missing setter for arrays (#3837)
* [C++][Pistache] Add missing setter for arrays
Fixes#3769
* [C++][Pistache] Update Petstore sample
* typescript-inversify: improve check for required parameters, support multiple media types (#3849)
* [typescript-inversify] Allow falsy parameters
A required parameter to an api method must not be `null` or `undefined`.
It can be any other falsy value, e.g. `""`, `0` or `false` though. This
change makes sure an error is only thrown in the former case and not in
the latter.
* [typescript-inversify] Handle multiple media types
The Accept and Content-Type HTTP headers can contain a list of media
types. Previously all but the first media type in the api definition
were ignored. Now the headers are properly generated.
* [typescript-inversify] Fix http client interface
The api service methods allow the `body` parameter to be optional. The
parameter is then passed to an `IHttpClient`. So it needs to be optional
there as well.
Also fixed the sample implementation `HttpClient`.
Fixes#3618.
* [typescript-inversify] Regenerate Petstore sample
* [typescript-inversify] Use more explicit null check
This does not change the semantic of the generated code, but makes it more explicit.
Co-Authored-By: Esteban Gehring <esteban.gehring@gmail.com>
* [typescript-angular] allow empty string basePath (#3489)
* [typescript-angular] Fixing #2731 - empty string basePath
* typescript-angular: refactor base path configuration
* typescript-angular: refactor base path configuration
* Fix/r/serialization fix and minor 3xx resp fix (#3817)
* fix(qlik): fix for minor serialization bug
* fix(r): add petsore generated classes
* fix(r): indendation fixes
* typescript-axios: Fix baseoptions (#3866)
* Fixed missing baseOptions of typescript-axios.
The typescript-axios template was missing the baseOptions setting when building an API Configuration. Set it.
* update sample.
* re-generate typescript axios samples
* Rename gRPC generator to "protobuf-schema" (#3864)
* rename grpc generator to protobuf-schema
* update doc
* Prepare v4.1.2 release (#3873)
* update samples
* update date
* fix version in readme
* BugFix #2053 Spring Boot fails to parse LocalDate query parameter (#3860)
Adds the format annotation so that Spring is able to serialize OpenApi date/date-time format into LocalDate/OffsetDateTime.
* update doc, samples (#3875)
* update stable release
* Update the batch for Windows
* Add a test snippet
* Update ensure-up-to-date
* Add Nim to README.md
* Ran ensure-up-to-date to pass CircleCI tests
jimschubert added a commit
that referenced
this pull request
Sep 13, 2019
@jimschubert
Merge branch 'master' into spring-requestparam-regression
3e2ec0b
* master: (22 commits)
various minor improvements to nim generator (#3883)
Add Nim client code generator (#3879)
updated google-api-client version from 1.23.0 to 1.30.2. Bugfix #3625 (#3882)
typescript-fetch: fix missing comma in multiple imports (#3881)
[scala][client] add Scala code generation test (#3859)
typescript-node: Use HttpError class when rejecting promises (#3876)
update stable release
update doc, samples (#3875)
BugFix #2053 Spring Boot fails to parse LocalDate query parameter (#3860)
fix version in readme
Prepare v4.1.2 release (#3873)
Rename gRPC generator to "protobuf-schema" (#3864)
typescript-axios: Fix baseoptions (#3866)
Fix/r/serialization fix and minor 3xx resp fix (#3817)
[typescript-angular] allow empty string basePath (#3489)
typescript-inversify: improve check for required parameters, support multiple media types (#3849)
[C++][Pistache] Add missing setter for arrays (#3837)
Adds Http Info To Dart Api (#3851)
[Java][okhttp-gson] fix failure to deserialize floats (#3846)
maven-plugin-plugin 3.6.0 (#3854)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@etherealjoyetherealjoyetherealjoy approved these changes

Assignees


No one assigned


Labels

Enhancement: GeneralServer: C++

Projects


None yet


Milestone

4.1.2

Development

Successfully merging this pull request may close these issues.

[BUG] No setter function generated for arrays


3 participants

@muttleyxd@etherealjoy@wing328

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[C++][Pistache] Add missing setter for arrays - #3837
Merged
etherealjoy merged 2 commits into
OpenAPITools:masterfrom 
muttleyxd:pistache-is-set
Sep 7, 2019
Merged
[C++][Pistache] Add missing setter for arrays#3837
etherealjoy merged 2 commits into
OpenAPITools:masterfrom 
muttleyxd:pistache-is-set
Conversation
@muttleyxd
@muttleyxdmuttleyxd
commented
Sep 5, 2019

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  •  Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
@ravinikam@stkrwork@etherealjoy@MartinDelille@muttleyxd
Description of the PR
Fixes#3769

I would like to refactor this for 5.X releases with #3417
@muttleyxdmuttleyxd
mentioned this pull request
Sep 5, 2019

Closed

1 task
@muttleyxd
muttleyxd
commented
Sep 5, 2019

Copy link


Copy Markdown

ContributorAuthor
Shall we generate setter for required fields?
@etherealjoy
etherealjoy
commented
Sep 5, 2019

Copy link


Copy Markdown

Contributor
I think we need to do for all.
@muttleyxd
muttleyxd
commented
Sep 5, 2019

Copy link


Copy Markdown

ContributorAuthor
That's how it's done here, so I'm waiting for review 😄
etherealjoy
etherealjoy
requested changes
Sep 5, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/cpp-pistache-server/model-header.mustache
Comment threadmodules/openapi-generator/src/main/resources/cpp-pistache-server/model-source.mustache
@etherealjoyetherealjoy
added this to the 4.1.2 milestone
Sep 7, 2019
@etherealjoy
etherealjoy
merged commit f2fe4fc
into
OpenAPITools:masterSep 7, 2019
hokamoto pushed a commit
to hokamoto/openapi-generator
that referenced
this pull request
Sep 12, 2019
@muttleyxd@hokamoto
[C++][Pistache] Add missing setter for arrays (OpenAPITools#3837)
86adb0a
* [C++][Pistache] Add missing setter for arrays
FixesOpenAPITools#3769
* [C++][Pistache] Update Petstore sample
@wing328
wing328
commented
Sep 12, 2019

Copy link


Copy Markdown

Member
@muttleyxd thanks for the PR, which has been included in the v4.1.2 release: https://twitter.com/oas_generator/status/1172068944355528705
wing328 pushed a commit
that referenced
this pull request
Sep 13, 2019
@hokamoto@wing328
Add Nim client code generator (#3879)
f15f814
* First version of Nim Client
* Add some codes
* Add some codes
* Add some codes
* Add some codes
* Add some codes
* First version of Nim Client
* Add some codes
* Add some codes
* [Dart] Fix README template and update testing doco (#3809)
* [Dart] Fix README template and update testing doco
- deleted redundant shell script
- fixed and updated README template
- updated test package and moved to a dev_dependency
- removed old unused dev_dependency packages
- updated testing documentation in petstore sample
* Remove references to dart-flutter-petstore.sh
* Fix typos
* Fix typo
* Support custom git repository (#3757)
* add gitHost param to GeneratorSettings and related
* parameterize gitHost in READMEs
* parameterize gitHost in go.mod
* parameterize gitHost in git_push
* update petstore samples
* run ./bin/utils/export_docs_generators.sh
* run meta-codehen.sh
* Revert "run meta-codehen.sh"
This reverts commit d6d579f.
* Revert "run ./bin/utils/export_docs_generators.sh"
This reverts commit 1b81538.
* Revert "update petstore samples"
This reverts commit f513add.
* run ensure-up-to-date
* Add links to article and video (#3820)
* Better Go code format (#3819)
* better varible naming
* better comments
* better code format for go experimental client
* better comment, update samples
* Add some codes
* Add some codes
* Add some codes
* Add gRPC Protobuf schema generator (#3818)
* add grpc protobuf generator
* update doc
* add new doc
* add windows batch, comment out root proto
* 1792 fix remote spec handling and hash calculation (#3440)
* fixed bug where nullApi.java would be generated. Instead, generated DefaultApi.java to match the default path /{pathParam} (#3821)
* Revert "1792 fix remote spec handling and hash calculation (#3440)"
This reverts commit 2a2eefe.
* Add nickmeinhold to Dart technical committee (#3830)
* Bug #2845 typescript angular inheritance (#3812)
* issue #2845: enable 'supportsMultipleInheritance' on typescript angular client codegen
- note I reran ./bin/openapi3/typescript-angular-petstore-all.sh and no changes occurred.
this suggests to me that the petstore.yaml sample should be improved to make use of the
anyOf / allOf / oneOf keywords, in order to better show the effects of changes on generated code.
* issue #2845: run ./bin/openapi3/typescript-angular-petstore-all.sh
* run `mvn clean package && ./bin/typescript-angular-petstore-all.sh`
* revert extranous files
* fix warnings in csharp-netcore client (#3831)
* Add missing files to the form request (#3834)
* [client][go] avoid duplicated reflect imports (#3847)
* Following up for #3440 (1792 fix remote spec handling and hash calculation) (#3826)
* This patch fixes the bug that we cannot access to remote files when checking file updates.
Following up #3440, supporting auth.
* 1792 fix remote spec handling and hash calculation (#3440)
(cherry picked from commit 2a2eefe)
* fix detecting remote file / local file logic while finding the hash file, taking care of IllegalArgumentException for local files.
* add testcase
* Add a link (#3850)
* Add Element AI to the list (#3856)
* maven-plugin-plugin 3.6.0 (#3854)
* [Java][okhttp-gson] fix failure to deserialize floats (#3846)
* fixed bug where nullApi.java would be generated. Instead, generated DefaultApi.java to match the default path /{pathParam}
* fix to bug #3157
* update samples
* Adds Http Info To Dart Api (#3851)
* [C++][Pistache] Add missing setter for arrays (#3837)
* [C++][Pistache] Add missing setter for arrays
Fixes#3769
* [C++][Pistache] Update Petstore sample
* typescript-inversify: improve check for required parameters, support multiple media types (#3849)
* [typescript-inversify] Allow falsy parameters
A required parameter to an api method must not be `null` or `undefined`.
It can be any other falsy value, e.g. `""`, `0` or `false` though. This
change makes sure an error is only thrown in the former case and not in
the latter.
* [typescript-inversify] Handle multiple media types
The Accept and Content-Type HTTP headers can contain a list of media
types. Previously all but the first media type in the api definition
were ignored. Now the headers are properly generated.
* [typescript-inversify] Fix http client interface
The api service methods allow the `body` parameter to be optional. The
parameter is then passed to an `IHttpClient`. So it needs to be optional
there as well.
Also fixed the sample implementation `HttpClient`.
Fixes#3618.
* [typescript-inversify] Regenerate Petstore sample
* [typescript-inversify] Use more explicit null check
This does not change the semantic of the generated code, but makes it more explicit.
Co-Authored-By: Esteban Gehring <esteban.gehring@gmail.com>
* [typescript-angular] allow empty string basePath (#3489)
* [typescript-angular] Fixing #2731 - empty string basePath
* typescript-angular: refactor base path configuration
* typescript-angular: refactor base path configuration
* Fix/r/serialization fix and minor 3xx resp fix (#3817)
* fix(qlik): fix for minor serialization bug
* fix(r): add petsore generated classes
* fix(r): indendation fixes
* typescript-axios: Fix baseoptions (#3866)
* Fixed missing baseOptions of typescript-axios.
The typescript-axios template was missing the baseOptions setting when building an API Configuration. Set it.
* update sample.
* re-generate typescript axios samples
* Rename gRPC generator to "protobuf-schema" (#3864)
* rename grpc generator to protobuf-schema
* update doc
* Prepare v4.1.2 release (#3873)
* update samples
* update date
* fix version in readme
* BugFix #2053 Spring Boot fails to parse LocalDate query parameter (#3860)
Adds the format annotation so that Spring is able to serialize OpenApi date/date-time format into LocalDate/OffsetDateTime.
* update doc, samples (#3875)
* update stable release
* Update the batch for Windows
* Add a test snippet
* Update ensure-up-to-date
* Add Nim to README.md
* Ran ensure-up-to-date to pass CircleCI tests
jimschubert added a commit
that referenced
this pull request
Sep 13, 2019
@jimschubert
Merge branch 'master' into spring-requestparam-regression
3e2ec0b
* master: (22 commits)
various minor improvements to nim generator (#3883)
Add Nim client code generator (#3879)
updated google-api-client version from 1.23.0 to 1.30.2. Bugfix #3625 (#3882)
typescript-fetch: fix missing comma in multiple imports (#3881)
[scala][client] add Scala code generation test (#3859)
typescript-node: Use HttpError class when rejecting promises (#3876)
update stable release
update doc, samples (#3875)
BugFix #2053 Spring Boot fails to parse LocalDate query parameter (#3860)
fix version in readme
Prepare v4.1.2 release (#3873)
Rename gRPC generator to "protobuf-schema" (#3864)
typescript-axios: Fix baseoptions (#3866)
Fix/r/serialization fix and minor 3xx resp fix (#3817)
[typescript-angular] allow empty string basePath (#3489)
typescript-inversify: improve check for required parameters, support multiple media types (#3849)
[C++][Pistache] Add missing setter for arrays (#3837)
Adds Http Info To Dart Api (#3851)
[Java][okhttp-gson] fix failure to deserialize floats (#3846)
maven-plugin-plugin 3.6.0 (#3854)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@etherealjoyetherealjoyetherealjoy approved these changes

Assignees


No one assigned


Labels

Enhancement: GeneralServer: C++

Projects


None yet


Milestone

4.1.2

Development

Successfully merging this pull request may close these issues.

[BUG] No setter function generated for arrays


3 participants

@muttleyxd@etherealjoy@wing328

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[C++][Pistache] Add missing setter for arrays - #3837
Merged
etherealjoy merged 2 commits into
OpenAPITools:masterfrom 
muttleyxd:pistache-is-set
Sep 7, 2019
Merged
[C++][Pistache] Add missing setter for arrays#3837
etherealjoy merged 2 commits into
OpenAPITools:masterfrom 
muttleyxd:pistache-is-set
Conversation
@muttleyxd
@muttleyxdmuttleyxd
commented
Sep 5, 2019

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  •  Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
@ravinikam@stkrwork@etherealjoy@MartinDelille@muttleyxd
Description of the PR
Fixes#3769

I would like to refactor this for 5.X releases with #3417
@muttleyxdmuttleyxd
mentioned this pull request
Sep 5, 2019

Closed

1 task
@muttleyxd
muttleyxd
commented
Sep 5, 2019

Copy link


Copy Markdown

ContributorAuthor
Shall we generate setter for required fields?
@etherealjoy
etherealjoy
commented
Sep 5, 2019

Copy link


Copy Markdown

Contributor
I think we need to do for all.
@muttleyxd
muttleyxd
commented
Sep 5, 2019

Copy link


Copy Markdown

ContributorAuthor
That's how it's done here, so I'm waiting for review 😄
etherealjoy
etherealjoy
requested changes
Sep 5, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/cpp-pistache-server/model-header.mustache
Comment threadmodules/openapi-generator/src/main/resources/cpp-pistache-server/model-source.mustache
@etherealjoyetherealjoy
added this to the 4.1.2 milestone
Sep 7, 2019
@etherealjoy
etherealjoy
merged commit f2fe4fc
into
OpenAPITools:masterSep 7, 2019
hokamoto pushed a commit
to hokamoto/openapi-generator
that referenced
this pull request
Sep 12, 2019
@muttleyxd@hokamoto
[C++][Pistache] Add missing setter for arrays (OpenAPITools#3837)
86adb0a
* [C++][Pistache] Add missing setter for arrays
FixesOpenAPITools#3769
* [C++][Pistache] Update Petstore sample
@wing328
wing328
commented
Sep 12, 2019

Copy link


Copy Markdown

Member
@muttleyxd thanks for the PR, which has been included in the v4.1.2 release: https://twitter.com/oas_generator/status/1172068944355528705
wing328 pushed a commit
that referenced
this pull request
Sep 13, 2019
@hokamoto@wing328
Add Nim client code generator (#3879)
f15f814
* First version of Nim Client
* Add some codes
* Add some codes
* Add some codes
* Add some codes
* Add some codes
* First version of Nim Client
* Add some codes
* Add some codes
* [Dart] Fix README template and update testing doco (#3809)
* [Dart] Fix README template and update testing doco
- deleted redundant shell script
- fixed and updated README template
- updated test package and moved to a dev_dependency
- removed old unused dev_dependency packages
- updated testing documentation in petstore sample
* Remove references to dart-flutter-petstore.sh
* Fix typos
* Fix typo
* Support custom git repository (#3757)
* add gitHost param to GeneratorSettings and related
* parameterize gitHost in READMEs
* parameterize gitHost in go.mod
* parameterize gitHost in git_push
* update petstore samples
* run ./bin/utils/export_docs_generators.sh
* run meta-codehen.sh
* Revert "run meta-codehen.sh"
This reverts commit d6d579f.
* Revert "run ./bin/utils/export_docs_generators.sh"
This reverts commit 1b81538.
* Revert "update petstore samples"
This reverts commit f513add.
* run ensure-up-to-date
* Add links to article and video (#3820)
* Better Go code format (#3819)
* better varible naming
* better comments
* better code format for go experimental client
* better comment, update samples
* Add some codes
* Add some codes
* Add some codes
* Add gRPC Protobuf schema generator (#3818)
* add grpc protobuf generator
* update doc
* add new doc
* add windows batch, comment out root proto
* 1792 fix remote spec handling and hash calculation (#3440)
* fixed bug where nullApi.java would be generated. Instead, generated DefaultApi.java to match the default path /{pathParam} (#3821)
* Revert "1792 fix remote spec handling and hash calculation (#3440)"
This reverts commit 2a2eefe.
* Add nickmeinhold to Dart technical committee (#3830)
* Bug #2845 typescript angular inheritance (#3812)
* issue #2845: enable 'supportsMultipleInheritance' on typescript angular client codegen
- note I reran ./bin/openapi3/typescript-angular-petstore-all.sh and no changes occurred.
this suggests to me that the petstore.yaml sample should be improved to make use of the
anyOf / allOf / oneOf keywords, in order to better show the effects of changes on generated code.
* issue #2845: run ./bin/openapi3/typescript-angular-petstore-all.sh
* run `mvn clean package && ./bin/typescript-angular-petstore-all.sh`
* revert extranous files
* fix warnings in csharp-netcore client (#3831)
* Add missing files to the form request (#3834)
* [client][go] avoid duplicated reflect imports (#3847)
* Following up for #3440 (1792 fix remote spec handling and hash calculation) (#3826)
* This patch fixes the bug that we cannot access to remote files when checking file updates.
Following up #3440, supporting auth.
* 1792 fix remote spec handling and hash calculation (#3440)
(cherry picked from commit 2a2eefe)
* fix detecting remote file / local file logic while finding the hash file, taking care of IllegalArgumentException for local files.
* add testcase
* Add a link (#3850)
* Add Element AI to the list (#3856)
* maven-plugin-plugin 3.6.0 (#3854)
* [Java][okhttp-gson] fix failure to deserialize floats (#3846)
* fixed bug where nullApi.java would be generated. Instead, generated DefaultApi.java to match the default path /{pathParam}
* fix to bug #3157
* update samples
* Adds Http Info To Dart Api (#3851)
* [C++][Pistache] Add missing setter for arrays (#3837)
* [C++][Pistache] Add missing setter for arrays
Fixes#3769
* [C++][Pistache] Update Petstore sample
* typescript-inversify: improve check for required parameters, support multiple media types (#3849)
* [typescript-inversify] Allow falsy parameters
A required parameter to an api method must not be `null` or `undefined`.
It can be any other falsy value, e.g. `""`, `0` or `false` though. This
change makes sure an error is only thrown in the former case and not in
the latter.
* [typescript-inversify] Handle multiple media types
The Accept and Content-Type HTTP headers can contain a list of media
types. Previously all but the first media type in the api definition
were ignored. Now the headers are properly generated.
* [typescript-inversify] Fix http client interface
The api service methods allow the `body` parameter to be optional. The
parameter is then passed to an `IHttpClient`. So it needs to be optional
there as well.
Also fixed the sample implementation `HttpClient`.
Fixes#3618.
* [typescript-inversify] Regenerate Petstore sample
* [typescript-inversify] Use more explicit null check
This does not change the semantic of the generated code, but makes it more explicit.
Co-Authored-By: Esteban Gehring <esteban.gehring@gmail.com>
* [typescript-angular] allow empty string basePath (#3489)
* [typescript-angular] Fixing #2731 - empty string basePath
* typescript-angular: refactor base path configuration
* typescript-angular: refactor base path configuration
* Fix/r/serialization fix and minor 3xx resp fix (#3817)
* fix(qlik): fix for minor serialization bug
* fix(r): add petsore generated classes
* fix(r): indendation fixes
* typescript-axios: Fix baseoptions (#3866)
* Fixed missing baseOptions of typescript-axios.
The typescript-axios template was missing the baseOptions setting when building an API Configuration. Set it.
* update sample.
* re-generate typescript axios samples
* Rename gRPC generator to "protobuf-schema" (#3864)
* rename grpc generator to protobuf-schema
* update doc
* Prepare v4.1.2 release (#3873)
* update samples
* update date
* fix version in readme
* BugFix #2053 Spring Boot fails to parse LocalDate query parameter (#3860)
Adds the format annotation so that Spring is able to serialize OpenApi date/date-time format into LocalDate/OffsetDateTime.
* update doc, samples (#3875)
* update stable release
* Update the batch for Windows
* Add a test snippet
* Update ensure-up-to-date
* Add Nim to README.md
* Ran ensure-up-to-date to pass CircleCI tests
jimschubert added a commit
that referenced
this pull request
Sep 13, 2019
@jimschubert
Merge branch 'master' into spring-requestparam-regression
3e2ec0b
* master: (22 commits)
various minor improvements to nim generator (#3883)
Add Nim client code generator (#3879)
updated google-api-client version from 1.23.0 to 1.30.2. Bugfix #3625 (#3882)
typescript-fetch: fix missing comma in multiple imports (#3881)
[scala][client] add Scala code generation test (#3859)
typescript-node: Use HttpError class when rejecting promises (#3876)
update stable release
update doc, samples (#3875)
BugFix #2053 Spring Boot fails to parse LocalDate query parameter (#3860)
fix version in readme
Prepare v4.1.2 release (#3873)
Rename gRPC generator to "protobuf-schema" (#3864)
typescript-axios: Fix baseoptions (#3866)
Fix/r/serialization fix and minor 3xx resp fix (#3817)
[typescript-angular] allow empty string basePath (#3489)
typescript-inversify: improve check for required parameters, support multiple media types (#3849)
[C++][Pistache] Add missing setter for arrays (#3837)
Adds Http Info To Dart Api (#3851)
[Java][okhttp-gson] fix failure to deserialize floats (#3846)
maven-plugin-plugin 3.6.0 (#3854)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@etherealjoyetherealjoyetherealjoy approved these changes

Assignees


No one assigned


Labels

Enhancement: GeneralServer: C++

Projects


None yet


Milestone

4.1.2

Development

Successfully merging this pull request may close these issues.

[BUG] No setter function generated for arrays


3 participants

@muttleyxd@etherealjoy@wing328

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[C++][Pistache] Add missing setter for arrays - #3837
Merged
etherealjoy merged 2 commits into
OpenAPITools:masterfrom 
muttleyxd:pistache-is-set
Sep 7, 2019
Merged
[C++][Pistache] Add missing setter for arrays#3837
etherealjoy merged 2 commits into
OpenAPITools:masterfrom 
muttleyxd:pistache-is-set
Conversation
@muttleyxd
@muttleyxdmuttleyxd
commented
Sep 5, 2019

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  •  Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
@ravinikam@stkrwork@etherealjoy@MartinDelille@muttleyxd
Description of the PR
Fixes#3769

I would like to refactor this for 5.X releases with #3417
@muttleyxdmuttleyxd
mentioned this pull request
Sep 5, 2019

Closed

1 task
@muttleyxd
muttleyxd
commented
Sep 5, 2019

Copy link


Copy Markdown

ContributorAuthor
Shall we generate setter for required fields?
@etherealjoy
etherealjoy
commented
Sep 5, 2019

Copy link


Copy Markdown

Contributor
I think we need to do for all.
@muttleyxd
muttleyxd
commented
Sep 5, 2019

Copy link


Copy Markdown

ContributorAuthor
That's how it's done here, so I'm waiting for review 😄
etherealjoy
etherealjoy
requested changes
Sep 5, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/cpp-pistache-server/model-header.mustache
Comment threadmodules/openapi-generator/src/main/resources/cpp-pistache-server/model-source.mustache
@etherealjoyetherealjoy
added this to the 4.1.2 milestone
Sep 7, 2019
@etherealjoy
etherealjoy
merged commit f2fe4fc
into
OpenAPITools:masterSep 7, 2019
hokamoto pushed a commit
to hokamoto/openapi-generator
that referenced
this pull request
Sep 12, 2019
@muttleyxd@hokamoto
[C++][Pistache] Add missing setter for arrays (OpenAPITools#3837)
86adb0a
* [C++][Pistache] Add missing setter for arrays
FixesOpenAPITools#3769
* [C++][Pistache] Update Petstore sample
@wing328
wing328
commented
Sep 12, 2019

Copy link


Copy Markdown

Member
@muttleyxd thanks for the PR, which has been included in the v4.1.2 release: https://twitter.com/oas_generator/status/1172068944355528705
wing328 pushed a commit
that referenced
this pull request
Sep 13, 2019
@hokamoto@wing328
Add Nim client code generator (#3879)
f15f814
* First version of Nim Client
* Add some codes
* Add some codes
* Add some codes
* Add some codes
* Add some codes
* First version of Nim Client
* Add some codes
* Add some codes
* [Dart] Fix README template and update testing doco (#3809)
* [Dart] Fix README template and update testing doco
- deleted redundant shell script
- fixed and updated README template
- updated test package and moved to a dev_dependency
- removed old unused dev_dependency packages
- updated testing documentation in petstore sample
* Remove references to dart-flutter-petstore.sh
* Fix typos
* Fix typo
* Support custom git repository (#3757)
* add gitHost param to GeneratorSettings and related
* parameterize gitHost in READMEs
* parameterize gitHost in go.mod
* parameterize gitHost in git_push
* update petstore samples
* run ./bin/utils/export_docs_generators.sh
* run meta-codehen.sh
* Revert "run meta-codehen.sh"
This reverts commit d6d579f.
* Revert "run ./bin/utils/export_docs_generators.sh"
This reverts commit 1b81538.
* Revert "update petstore samples"
This reverts commit f513add.
* run ensure-up-to-date
* Add links to article and video (#3820)
* Better Go code format (#3819)
* better varible naming
* better comments
* better code format for go experimental client
* better comment, update samples
* Add some codes
* Add some codes
* Add some codes
* Add gRPC Protobuf schema generator (#3818)
* add grpc protobuf generator
* update doc
* add new doc
* add windows batch, comment out root proto
* 1792 fix remote spec handling and hash calculation (#3440)
* fixed bug where nullApi.java would be generated. Instead, generated DefaultApi.java to match the default path /{pathParam} (#3821)
* Revert "1792 fix remote spec handling and hash calculation (#3440)"
This reverts commit 2a2eefe.
* Add nickmeinhold to Dart technical committee (#3830)
* Bug #2845 typescript angular inheritance (#3812)
* issue #2845: enable 'supportsMultipleInheritance' on typescript angular client codegen
- note I reran ./bin/openapi3/typescript-angular-petstore-all.sh and no changes occurred.
this suggests to me that the petstore.yaml sample should be improved to make use of the
anyOf / allOf / oneOf keywords, in order to better show the effects of changes on generated code.
* issue #2845: run ./bin/openapi3/typescript-angular-petstore-all.sh
* run `mvn clean package && ./bin/typescript-angular-petstore-all.sh`
* revert extranous files
* fix warnings in csharp-netcore client (#3831)
* Add missing files to the form request (#3834)
* [client][go] avoid duplicated reflect imports (#3847)
* Following up for #3440 (1792 fix remote spec handling and hash calculation) (#3826)
* This patch fixes the bug that we cannot access to remote files when checking file updates.
Following up #3440, supporting auth.
* 1792 fix remote spec handling and hash calculation (#3440)
(cherry picked from commit 2a2eefe)
* fix detecting remote file / local file logic while finding the hash file, taking care of IllegalArgumentException for local files.
* add testcase
* Add a link (#3850)
* Add Element AI to the list (#3856)
* maven-plugin-plugin 3.6.0 (#3854)
* [Java][okhttp-gson] fix failure to deserialize floats (#3846)
* fixed bug where nullApi.java would be generated. Instead, generated DefaultApi.java to match the default path /{pathParam}
* fix to bug #3157
* update samples
* Adds Http Info To Dart Api (#3851)
* [C++][Pistache] Add missing setter for arrays (#3837)
* [C++][Pistache] Add missing setter for arrays
Fixes#3769
* [C++][Pistache] Update Petstore sample
* typescript-inversify: improve check for required parameters, support multiple media types (#3849)
* [typescript-inversify] Allow falsy parameters
A required parameter to an api method must not be `null` or `undefined`.
It can be any other falsy value, e.g. `""`, `0` or `false` though. This
change makes sure an error is only thrown in the former case and not in
the latter.
* [typescript-inversify] Handle multiple media types
The Accept and Content-Type HTTP headers can contain a list of media
types. Previously all but the first media type in the api definition
were ignored. Now the headers are properly generated.
* [typescript-inversify] Fix http client interface
The api service methods allow the `body` parameter to be optional. The
parameter is then passed to an `IHttpClient`. So it needs to be optional
there as well.
Also fixed the sample implementation `HttpClient`.
Fixes#3618.
* [typescript-inversify] Regenerate Petstore sample
* [typescript-inversify] Use more explicit null check
This does not change the semantic of the generated code, but makes it more explicit.
Co-Authored-By: Esteban Gehring <esteban.gehring@gmail.com>
* [typescript-angular] allow empty string basePath (#3489)
* [typescript-angular] Fixing #2731 - empty string basePath
* typescript-angular: refactor base path configuration
* typescript-angular: refactor base path configuration
* Fix/r/serialization fix and minor 3xx resp fix (#3817)
* fix(qlik): fix for minor serialization bug
* fix(r): add petsore generated classes
* fix(r): indendation fixes
* typescript-axios: Fix baseoptions (#3866)
* Fixed missing baseOptions of typescript-axios.
The typescript-axios template was missing the baseOptions setting when building an API Configuration. Set it.
* update sample.
* re-generate typescript axios samples
* Rename gRPC generator to "protobuf-schema" (#3864)
* rename grpc generator to protobuf-schema
* update doc
* Prepare v4.1.2 release (#3873)
* update samples
* update date
* fix version in readme
* BugFix #2053 Spring Boot fails to parse LocalDate query parameter (#3860)
Adds the format annotation so that Spring is able to serialize OpenApi date/date-time format into LocalDate/OffsetDateTime.
* update doc, samples (#3875)
* update stable release
* Update the batch for Windows
* Add a test snippet
* Update ensure-up-to-date
* Add Nim to README.md
* Ran ensure-up-to-date to pass CircleCI tests
jimschubert added a commit
that referenced
this pull request
Sep 13, 2019
@jimschubert
Merge branch 'master' into spring-requestparam-regression
3e2ec0b
* master: (22 commits)
various minor improvements to nim generator (#3883)
Add Nim client code generator (#3879)
updated google-api-client version from 1.23.0 to 1.30.2. Bugfix #3625 (#3882)
typescript-fetch: fix missing comma in multiple imports (#3881)
[scala][client] add Scala code generation test (#3859)
typescript-node: Use HttpError class when rejecting promises (#3876)
update stable release
update doc, samples (#3875)
BugFix #2053 Spring Boot fails to parse LocalDate query parameter (#3860)
fix version in readme
Prepare v4.1.2 release (#3873)
Rename gRPC generator to "protobuf-schema" (#3864)
typescript-axios: Fix baseoptions (#3866)
Fix/r/serialization fix and minor 3xx resp fix (#3817)
[typescript-angular] allow empty string basePath (#3489)
typescript-inversify: improve check for required parameters, support multiple media types (#3849)
[C++][Pistache] Add missing setter for arrays (#3837)
Adds Http Info To Dart Api (#3851)
[Java][okhttp-gson] fix failure to deserialize floats (#3846)
maven-plugin-plugin 3.6.0 (#3854)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@etherealjoyetherealjoyetherealjoy approved these changes

Assignees


No one assigned


Labels

Enhancement: GeneralServer: C++

Projects


None yet


Milestone

4.1.2

Development

Successfully merging this pull request may close these issues.

[BUG] No setter function generated for arrays


3 participants

@muttleyxd@etherealjoy@wing328

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[C++][Pistache] Add missing setter for arrays - #3837
Merged
etherealjoy merged 2 commits into
OpenAPITools:masterfrom 
muttleyxd:pistache-is-set
Sep 7, 2019
Merged
[C++][Pistache] Add missing setter for arrays#3837
etherealjoy merged 2 commits into
OpenAPITools:masterfrom 
muttleyxd:pistache-is-set
Conversation
@muttleyxd
@muttleyxdmuttleyxd
commented
Sep 5, 2019

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  •  Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
@ravinikam@stkrwork@etherealjoy@MartinDelille@muttleyxd
Description of the PR
Fixes#3769

I would like to refactor this for 5.X releases with #3417
@muttleyxdmuttleyxd
mentioned this pull request
Sep 5, 2019

Closed

1 task
@muttleyxd
muttleyxd
commented
Sep 5, 2019

Copy link


Copy Markdown

ContributorAuthor
Shall we generate setter for required fields?
@etherealjoy
etherealjoy
commented
Sep 5, 2019

Copy link


Copy Markdown

Contributor
I think we need to do for all.
@muttleyxd
muttleyxd
commented
Sep 5, 2019

Copy link


Copy Markdown

ContributorAuthor
That's how it's done here, so I'm waiting for review 😄
etherealjoy
etherealjoy
requested changes
Sep 5, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/cpp-pistache-server/model-header.mustache
Comment threadmodules/openapi-generator/src/main/resources/cpp-pistache-server/model-source.mustache
@etherealjoyetherealjoy
added this to the 4.1.2 milestone
Sep 7, 2019
@etherealjoy
etherealjoy
merged commit f2fe4fc
into
OpenAPITools:masterSep 7, 2019
hokamoto pushed a commit
to hokamoto/openapi-generator
that referenced
this pull request
Sep 12, 2019
@muttleyxd@hokamoto
[C++][Pistache] Add missing setter for arrays (OpenAPITools#3837)
86adb0a
* [C++][Pistache] Add missing setter for arrays
FixesOpenAPITools#3769
* [C++][Pistache] Update Petstore sample
@wing328
wing328
commented
Sep 12, 2019

Copy link


Copy Markdown

Member
@muttleyxd thanks for the PR, which has been included in the v4.1.2 release: https://twitter.com/oas_generator/status/1172068944355528705
wing328 pushed a commit
that referenced
this pull request
Sep 13, 2019
@hokamoto@wing328
Add Nim client code generator (#3879)
f15f814
* First version of Nim Client
* Add some codes
* Add some codes
* Add some codes
* Add some codes
* Add some codes
* First version of Nim Client
* Add some codes
* Add some codes
* [Dart] Fix README template and update testing doco (#3809)
* [Dart] Fix README template and update testing doco
- deleted redundant shell script
- fixed and updated README template
- updated test package and moved to a dev_dependency
- removed old unused dev_dependency packages
- updated testing documentation in petstore sample
* Remove references to dart-flutter-petstore.sh
* Fix typos
* Fix typo
* Support custom git repository (#3757)
* add gitHost param to GeneratorSettings and related
* parameterize gitHost in READMEs
* parameterize gitHost in go.mod
* parameterize gitHost in git_push
* update petstore samples
* run ./bin/utils/export_docs_generators.sh
* run meta-codehen.sh
* Revert "run meta-codehen.sh"
This reverts commit d6d579f.
* Revert "run ./bin/utils/export_docs_generators.sh"
This reverts commit 1b81538.
* Revert "update petstore samples"
This reverts commit f513add.
* run ensure-up-to-date
* Add links to article and video (#3820)
* Better Go code format (#3819)
* better varible naming
* better comments
* better code format for go experimental client
* better comment, update samples
* Add some codes
* Add some codes
* Add some codes
* Add gRPC Protobuf schema generator (#3818)
* add grpc protobuf generator
* update doc
* add new doc
* add windows batch, comment out root proto
* 1792 fix remote spec handling and hash calculation (#3440)
* fixed bug where nullApi.java would be generated. Instead, generated DefaultApi.java to match the default path /{pathParam} (#3821)
* Revert "1792 fix remote spec handling and hash calculation (#3440)"
This reverts commit 2a2eefe.
* Add nickmeinhold to Dart technical committee (#3830)
* Bug #2845 typescript angular inheritance (#3812)
* issue #2845: enable 'supportsMultipleInheritance' on typescript angular client codegen
- note I reran ./bin/openapi3/typescript-angular-petstore-all.sh and no changes occurred.
this suggests to me that the petstore.yaml sample should be improved to make use of the
anyOf / allOf / oneOf keywords, in order to better show the effects of changes on generated code.
* issue #2845: run ./bin/openapi3/typescript-angular-petstore-all.sh
* run `mvn clean package && ./bin/typescript-angular-petstore-all.sh`
* revert extranous files
* fix warnings in csharp-netcore client (#3831)
* Add missing files to the form request (#3834)
* [client][go] avoid duplicated reflect imports (#3847)
* Following up for #3440 (1792 fix remote spec handling and hash calculation) (#3826)
* This patch fixes the bug that we cannot access to remote files when checking file updates.
Following up #3440, supporting auth.
* 1792 fix remote spec handling and hash calculation (#3440)
(cherry picked from commit 2a2eefe)
* fix detecting remote file / local file logic while finding the hash file, taking care of IllegalArgumentException for local files.
* add testcase
* Add a link (#3850)
* Add Element AI to the list (#3856)
* maven-plugin-plugin 3.6.0 (#3854)
* [Java][okhttp-gson] fix failure to deserialize floats (#3846)
* fixed bug where nullApi.java would be generated. Instead, generated DefaultApi.java to match the default path /{pathParam}
* fix to bug #3157
* update samples
* Adds Http Info To Dart Api (#3851)
* [C++][Pistache] Add missing setter for arrays (#3837)
* [C++][Pistache] Add missing setter for arrays
Fixes#3769
* [C++][Pistache] Update Petstore sample
* typescript-inversify: improve check for required parameters, support multiple media types (#3849)
* [typescript-inversify] Allow falsy parameters
A required parameter to an api method must not be `null` or `undefined`.
It can be any other falsy value, e.g. `""`, `0` or `false` though. This
change makes sure an error is only thrown in the former case and not in
the latter.
* [typescript-inversify] Handle multiple media types
The Accept and Content-Type HTTP headers can contain a list of media
types. Previously all but the first media type in the api definition
were ignored. Now the headers are properly generated.
* [typescript-inversify] Fix http client interface
The api service methods allow the `body` parameter to be optional. The
parameter is then passed to an `IHttpClient`. So it needs to be optional
there as well.
Also fixed the sample implementation `HttpClient`.
Fixes#3618.
* [typescript-inversify] Regenerate Petstore sample
* [typescript-inversify] Use more explicit null check
This does not change the semantic of the generated code, but makes it more explicit.
Co-Authored-By: Esteban Gehring <esteban.gehring@gmail.com>
* [typescript-angular] allow empty string basePath (#3489)
* [typescript-angular] Fixing #2731 - empty string basePath
* typescript-angular: refactor base path configuration
* typescript-angular: refactor base path configuration
* Fix/r/serialization fix and minor 3xx resp fix (#3817)
* fix(qlik): fix for minor serialization bug
* fix(r): add petsore generated classes
* fix(r): indendation fixes
* typescript-axios: Fix baseoptions (#3866)
* Fixed missing baseOptions of typescript-axios.
The typescript-axios template was missing the baseOptions setting when building an API Configuration. Set it.
* update sample.
* re-generate typescript axios samples
* Rename gRPC generator to "protobuf-schema" (#3864)
* rename grpc generator to protobuf-schema
* update doc
* Prepare v4.1.2 release (#3873)
* update samples
* update date
* fix version in readme
* BugFix #2053 Spring Boot fails to parse LocalDate query parameter (#3860)
Adds the format annotation so that Spring is able to serialize OpenApi date/date-time format into LocalDate/OffsetDateTime.
* update doc, samples (#3875)
* update stable release
* Update the batch for Windows
* Add a test snippet
* Update ensure-up-to-date
* Add Nim to README.md
* Ran ensure-up-to-date to pass CircleCI tests
jimschubert added a commit
that referenced
this pull request
Sep 13, 2019
@jimschubert
Merge branch 'master' into spring-requestparam-regression
3e2ec0b
* master: (22 commits)
various minor improvements to nim generator (#3883)
Add Nim client code generator (#3879)
updated google-api-client version from 1.23.0 to 1.30.2. Bugfix #3625 (#3882)
typescript-fetch: fix missing comma in multiple imports (#3881)
[scala][client] add Scala code generation test (#3859)
typescript-node: Use HttpError class when rejecting promises (#3876)
update stable release
update doc, samples (#3875)
BugFix #2053 Spring Boot fails to parse LocalDate query parameter (#3860)
fix version in readme
Prepare v4.1.2 release (#3873)
Rename gRPC generator to "protobuf-schema" (#3864)
typescript-axios: Fix baseoptions (#3866)
Fix/r/serialization fix and minor 3xx resp fix (#3817)
[typescript-angular] allow empty string basePath (#3489)
typescript-inversify: improve check for required parameters, support multiple media types (#3849)
[C++][Pistache] Add missing setter for arrays (#3837)
Adds Http Info To Dart Api (#3851)
[Java][okhttp-gson] fix failure to deserialize floats (#3846)
maven-plugin-plugin 3.6.0 (#3854)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@etherealjoyetherealjoyetherealjoy approved these changes

Assignees


No one assigned


Labels

Enhancement: GeneralServer: C++

Projects


None yet


Milestone

4.1.2

Development

Successfully merging this pull request may close these issues.

[BUG] No setter function generated for arrays


3 participants

@muttleyxd@etherealjoy@wing328

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[C++][Pistache] Add missing setter for arrays - #3837
Merged
etherealjoy merged 2 commits into
OpenAPITools:masterfrom 
muttleyxd:pistache-is-set
Sep 7, 2019
Merged
[C++][Pistache] Add missing setter for arrays#3837
etherealjoy merged 2 commits into
OpenAPITools:masterfrom 
muttleyxd:pistache-is-set
Conversation
@muttleyxd
@muttleyxdmuttleyxd
commented
Sep 5, 2019

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  •  Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
@ravinikam@stkrwork@etherealjoy@MartinDelille@muttleyxd
Description of the PR
Fixes#3769

I would like to refactor this for 5.X releases with #3417
@muttleyxdmuttleyxd
mentioned this pull request
Sep 5, 2019

Closed

1 task
@muttleyxd
muttleyxd
commented
Sep 5, 2019

Copy link


Copy Markdown

ContributorAuthor
Shall we generate setter for required fields?
@etherealjoy
etherealjoy
commented
Sep 5, 2019

Copy link


Copy Markdown

Contributor
I think we need to do for all.
@muttleyxd
muttleyxd
commented
Sep 5, 2019

Copy link


Copy Markdown

ContributorAuthor
That's how it's done here, so I'm waiting for review 😄
etherealjoy
etherealjoy
requested changes
Sep 5, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/cpp-pistache-server/model-header.mustache
Comment threadmodules/openapi-generator/src/main/resources/cpp-pistache-server/model-source.mustache
@etherealjoyetherealjoy
added this to the 4.1.2 milestone
Sep 7, 2019
@etherealjoy
etherealjoy
merged commit f2fe4fc
into
OpenAPITools:masterSep 7, 2019
hokamoto pushed a commit
to hokamoto/openapi-generator
that referenced
this pull request
Sep 12, 2019
@muttleyxd@hokamoto
[C++][Pistache] Add missing setter for arrays (OpenAPITools#3837)
86adb0a
* [C++][Pistache] Add missing setter for arrays
FixesOpenAPITools#3769
* [C++][Pistache] Update Petstore sample
@wing328
wing328
commented
Sep 12, 2019

Copy link


Copy Markdown

Member
@muttleyxd thanks for the PR, which has been included in the v4.1.2 release: https://twitter.com/oas_generator/status/1172068944355528705
wing328 pushed a commit
that referenced
this pull request
Sep 13, 2019
@hokamoto@wing328
Add Nim client code generator (#3879)
f15f814
* First version of Nim Client
* Add some codes
* Add some codes
* Add some codes
* Add some codes
* Add some codes
* First version of Nim Client
* Add some codes
* Add some codes
* [Dart] Fix README template and update testing doco (#3809)
* [Dart] Fix README template and update testing doco
- deleted redundant shell script
- fixed and updated README template
- updated test package and moved to a dev_dependency
- removed old unused dev_dependency packages
- updated testing documentation in petstore sample
* Remove references to dart-flutter-petstore.sh
* Fix typos
* Fix typo
* Support custom git repository (#3757)
* add gitHost param to GeneratorSettings and related
* parameterize gitHost in READMEs
* parameterize gitHost in go.mod
* parameterize gitHost in git_push
* update petstore samples
* run ./bin/utils/export_docs_generators.sh
* run meta-codehen.sh
* Revert "run meta-codehen.sh"
This reverts commit d6d579f.
* Revert "run ./bin/utils/export_docs_generators.sh"
This reverts commit 1b81538.
* Revert "update petstore samples"
This reverts commit f513add.
* run ensure-up-to-date
* Add links to article and video (#3820)
* Better Go code format (#3819)
* better varible naming
* better comments
* better code format for go experimental client
* better comment, update samples
* Add some codes
* Add some codes
* Add some codes
* Add gRPC Protobuf schema generator (#3818)
* add grpc protobuf generator
* update doc
* add new doc
* add windows batch, comment out root proto
* 1792 fix remote spec handling and hash calculation (#3440)
* fixed bug where nullApi.java would be generated. Instead, generated DefaultApi.java to match the default path /{pathParam} (#3821)
* Revert "1792 fix remote spec handling and hash calculation (#3440)"
This reverts commit 2a2eefe.
* Add nickmeinhold to Dart technical committee (#3830)
* Bug #2845 typescript angular inheritance (#3812)
* issue #2845: enable 'supportsMultipleInheritance' on typescript angular client codegen
- note I reran ./bin/openapi3/typescript-angular-petstore-all.sh and no changes occurred.
this suggests to me that the petstore.yaml sample should be improved to make use of the
anyOf / allOf / oneOf keywords, in order to better show the effects of changes on generated code.
* issue #2845: run ./bin/openapi3/typescript-angular-petstore-all.sh
* run `mvn clean package && ./bin/typescript-angular-petstore-all.sh`
* revert extranous files
* fix warnings in csharp-netcore client (#3831)
* Add missing files to the form request (#3834)
* [client][go] avoid duplicated reflect imports (#3847)
* Following up for #3440 (1792 fix remote spec handling and hash calculation) (#3826)
* This patch fixes the bug that we cannot access to remote files when checking file updates.
Following up #3440, supporting auth.
* 1792 fix remote spec handling and hash calculation (#3440)
(cherry picked from commit 2a2eefe)
* fix detecting remote file / local file logic while finding the hash file, taking care of IllegalArgumentException for local files.
* add testcase
* Add a link (#3850)
* Add Element AI to the list (#3856)
* maven-plugin-plugin 3.6.0 (#3854)
* [Java][okhttp-gson] fix failure to deserialize floats (#3846)
* fixed bug where nullApi.java would be generated. Instead, generated DefaultApi.java to match the default path /{pathParam}
* fix to bug #3157
* update samples
* Adds Http Info To Dart Api (#3851)
* [C++][Pistache] Add missing setter for arrays (#3837)
* [C++][Pistache] Add missing setter for arrays
Fixes#3769
* [C++][Pistache] Update Petstore sample
* typescript-inversify: improve check for required parameters, support multiple media types (#3849)
* [typescript-inversify] Allow falsy parameters
A required parameter to an api method must not be `null` or `undefined`.
It can be any other falsy value, e.g. `""`, `0` or `false` though. This
change makes sure an error is only thrown in the former case and not in
the latter.
* [typescript-inversify] Handle multiple media types
The Accept and Content-Type HTTP headers can contain a list of media
types. Previously all but the first media type in the api definition
were ignored. Now the headers are properly generated.
* [typescript-inversify] Fix http client interface
The api service methods allow the `body` parameter to be optional. The
parameter is then passed to an `IHttpClient`. So it needs to be optional
there as well.
Also fixed the sample implementation `HttpClient`.
Fixes#3618.
* [typescript-inversify] Regenerate Petstore sample
* [typescript-inversify] Use more explicit null check
This does not change the semantic of the generated code, but makes it more explicit.
Co-Authored-By: Esteban Gehring <esteban.gehring@gmail.com>
* [typescript-angular] allow empty string basePath (#3489)
* [typescript-angular] Fixing #2731 - empty string basePath
* typescript-angular: refactor base path configuration
* typescript-angular: refactor base path configuration
* Fix/r/serialization fix and minor 3xx resp fix (#3817)
* fix(qlik): fix for minor serialization bug
* fix(r): add petsore generated classes
* fix(r): indendation fixes
* typescript-axios: Fix baseoptions (#3866)
* Fixed missing baseOptions of typescript-axios.
The typescript-axios template was missing the baseOptions setting when building an API Configuration. Set it.
* update sample.
* re-generate typescript axios samples
* Rename gRPC generator to "protobuf-schema" (#3864)
* rename grpc generator to protobuf-schema
* update doc
* Prepare v4.1.2 release (#3873)
* update samples
* update date
* fix version in readme
* BugFix #2053 Spring Boot fails to parse LocalDate query parameter (#3860)
Adds the format annotation so that Spring is able to serialize OpenApi date/date-time format into LocalDate/OffsetDateTime.
* update doc, samples (#3875)
* update stable release
* Update the batch for Windows
* Add a test snippet
* Update ensure-up-to-date
* Add Nim to README.md
* Ran ensure-up-to-date to pass CircleCI tests
jimschubert added a commit
that referenced
this pull request
Sep 13, 2019
@jimschubert
Merge branch 'master' into spring-requestparam-regression
3e2ec0b
* master: (22 commits)
various minor improvements to nim generator (#3883)
Add Nim client code generator (#3879)
updated google-api-client version from 1.23.0 to 1.30.2. Bugfix #3625 (#3882)
typescript-fetch: fix missing comma in multiple imports (#3881)
[scala][client] add Scala code generation test (#3859)
typescript-node: Use HttpError class when rejecting promises (#3876)
update stable release
update doc, samples (#3875)
BugFix #2053 Spring Boot fails to parse LocalDate query parameter (#3860)
fix version in readme
Prepare v4.1.2 release (#3873)
Rename gRPC generator to "protobuf-schema" (#3864)
typescript-axios: Fix baseoptions (#3866)
Fix/r/serialization fix and minor 3xx resp fix (#3817)
[typescript-angular] allow empty string basePath (#3489)
typescript-inversify: improve check for required parameters, support multiple media types (#3849)
[C++][Pistache] Add missing setter for arrays (#3837)
Adds Http Info To Dart Api (#3851)
[Java][okhttp-gson] fix failure to deserialize floats (#3846)
maven-plugin-plugin 3.6.0 (#3854)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@etherealjoyetherealjoyetherealjoy approved these changes

Assignees


No one assigned


Labels

Enhancement: GeneralServer: C++

Projects


None yet


Milestone

4.1.2

Development

Successfully merging this pull request may close these issues.

[BUG] No setter function generated for arrays


3 participants

@muttleyxd@etherealjoy@wing328