Skip to content

typescript-node: Use HttpError class when rejecting promises - #3876

Merged
macjohnny merged 3 commits into
masterfrom
unknown repository
Sep 12, 2019
Merged

typescript-node: Use HttpError class when rejecting promises#3876
macjohnny merged 3 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghostghost commented Sep 11, 2019•
edited by ghost
Loading

Copy link
Copy Markdown

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Use a HttpError class instead of plain objects when rejecting promises.
Fixes#3872

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @akehir (2019/07)

@auto-labelerauto-labelerBot added the WIP Work in Progress label Sep 11, 2019
@auto-labeler

auto-labelerBot commented Sep 11, 2019

Copy link
Copy Markdown

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@ghostghost changed the title WIP: Use HttpError class when rejecting promisesUse HttpError class when rejecting promisesSep 12, 2019
macjohnny
macjohnny reviewed Sep 12, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-node/api-all.mustache Outdated
macjohnny
macjohnny reviewed Sep 12, 2019
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/typescript-node/api-all.mustache Outdated
@macjohnny

macjohnny commented Sep 12, 2019•
edited
Loading

Copy link
Copy Markdown
Member

please update the samples with https://github.com/OpenAPITools/openapi-generator/blob/master/bin/typescript-node-petstore-all.sh

@macjohnnymacjohnny added Client: TypeScript and removed WIP Work in Progress labels Sep 12, 2019
@macjohnnymacjohnny changed the title Use HttpError class when rejecting promisestypescript-node: Use HttpError class when rejecting promisesSep 12, 2019
@macjohnnymacjohnny added this to the 4.1.3 milestone Sep 12, 2019
macjohnny
macjohnny reviewed Sep 12, 2019
View reviewed changes
Comment threadsamples/client/petstore/typescript-node/default/api/apis.ts Outdated
@macjohnny

macjohnny commented Sep 12, 2019

Copy link
Copy Markdown
Member

@aeb-sia did you successfully test the generated code? does it fix the issue?

macjohnny
macjohnny approved these changes Sep 12, 2019
View reviewed changes

@macjohnnymacjohnny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost

ghost commented Sep 12, 2019

Copy link
Copy Markdown
Author

@macjohnny here's what I tested. Is it ok to push that?

macjohnny
macjohnny approved these changes Sep 12, 2019
View reviewed changes

@macjohnnymacjohnny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny
macjohnny merged commit dc2907a into OpenAPITools:masterSep 12, 2019
@ghost
ghost deleted the reject-using-error-instances branch September 12, 2019 14:03
jimschubert added a commit that referenced this pull request Sep 13, 2019
@jimschubert
Merge branch 'master' into spring-requestparam-regression
3e2ec0b
* master: (22 commits)
various minor improvements to nim generator (#3883)
Add Nim client code generator (#3879)
updated google-api-client version from 1.23.0 to 1.30.2. Bugfix #3625 (#3882)
typescript-fetch: fix missing comma in multiple imports (#3881)
[scala][client] add Scala code generation test (#3859)
typescript-node: Use HttpError class when rejecting promises (#3876)
update stable release
update doc, samples (#3875)
BugFix #2053 Spring Boot fails to parse LocalDate query parameter (#3860)
fix version in readme
Prepare v4.1.2 release (#3873)
Rename gRPC generator to "protobuf-schema" (#3864)
typescript-axios: Fix baseoptions (#3866)
Fix/r/serialization fix and minor 3xx resp fix (#3817)
[typescript-angular] allow empty string basePath (#3489)
typescript-inversify: improve check for required parameters, support multiple media types (#3849)
[C++][Pistache] Add missing setter for arrays (#3837)
Adds Http Info To Dart Api (#3851)
[Java][okhttp-gson] fix failure to deserialize floats (#3846)
maven-plugin-plugin 3.6.0 (#3854)
...
@ddgenomeddgenome mentioned this pull request Sep 26, 2019
Closed
@wing328

wing328 commented Oct 4, 2019

Copy link
Copy Markdown
Member

@aeb-sia thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Client: TypeScript

Projects

None yet

Milestone

4.1.3

Development

Successfully merging this pull request may close these issues.

typescript-node: Reject Promises in using Error instances instead of plain objects

3 participants

@macjohnny@wing328@simhnna