Skip to content

add gradle repository for using gralde dependency in plugin - #3867

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
fuj1g0n:feature/add-gradle-repository
Sep 27, 2019
Merged

add gradle repository for using gralde dependency in plugin#3867
wing328 merged 1 commit into
OpenAPITools:masterfrom
fuj1g0n:feature/add-gradle-repository

Conversation

@fuj1g0n

@fuj1g0nfuj1g0n commented Sep 10, 2019•
edited
Loading

Copy link
Copy Markdown

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

org.gradle:gradle-tooling-api is on Gradle Releases repository (cf. https://mvnrepository.com/artifact/org.gradle/gradle-tooling-api/4.10.2)

So, we need to add this repository to pluginManagement.

Without this setting, following error will occur in some environment.

[INFO] --- gradle-maven-plugin:1.0.8:invoke (default) @ openapi-generator-gradle-plugin-mvn-wrapper ---
[WARNING] The POM for org.gradle:gradle-tooling-api:jar:4.10.2 is missing, no dependency information available
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] [INFO] openapi-generator-project .......................... SUCCESS [ 3.859 s]
[INFO] openapi-generator-core ............................. SUCCESS [ 3.680 s]
[INFO] openapi-generator (core library) ................... SUCCESS [ 50.943 s]
[INFO] openapi-generator (executable) ..................... SUCCESS [ 17.679 s]
[INFO] openapi-generator (maven-plugin) ................... SUCCESS [ 6.745 s]
[INFO] openapi-generator-gradle-plugin (maven wrapper) .... FAILURE [ 0.061 s]
[INFO] openapi-generator-online ........................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:23 min
[INFO] Finished at: 2019-09-10T05:05:53+00:00
[INFO] Final Memory: 69M/1395M
[INFO] ------------------------------------------------------------------------

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

@fuj1g0nfuj1g0n changed the title add gradle repositoryadd gradle repository for using gralde pluginSep 10, 2019
@fuj1g0nfuj1g0n changed the title add gradle repository for using gralde pluginadd gradle repository for using gralde dependency in pluginSep 10, 2019
@jimschubert

jimschubert commented Sep 10, 2019

Copy link
Copy Markdown
Member

@fujigon what are the conditions that might cause this? Do you have a modified Maven settings.xml? And what version of Maven?

We don't really build the Gradle plugin via Maven, so it might be better to remove it and just rely on CI to report build issues in the plugin.

@wing328 any thoughts? If no concerns, we may want to merge after 4.1.2 is released. Workaround for whatever environment conditions cause this would be for the user to manually add the above configuration locally.

@wing328wing328 added this to the 4.1.2 milestone Sep 10, 2019
@fuj1g0n

fuj1g0n commented Sep 11, 2019

Copy link
Copy Markdown
Author

I'm still gathering the facts, please give me a moment.

@wing328wing328 modified the milestones: 4.1.2, 4.1.3Sep 11, 2019
@fuj1g0n

fuj1g0n commented Sep 12, 2019•
edited
Loading

Copy link
Copy Markdown
Author

can reproduce the error in some environments, cannot do in other environments.

Following command will reproduce the error though I found the issue while I run my complicated mvn commands for my internal package release to my private maven repository.

mvn install

I confirmed that all my trial invoke gradle-maven-plugin:1.0.8:invoke, and the error is produced by it (if error occurs).
But results varies in environments.

When succeeds, I get

[INFO] --- gradle-maven-plugin:1.0.8:invoke (default) @ openapi-generator-gradle-plugin-mvn-wrapper ---
[INFO] jvmArgs: [Ljava.lang.String;@1841d013
[INFO] gradleProjectDirectory: /mnt/c/publicgithub/openapi-generator/modules/openapi-generator-gradle-plugin
[INFO] Build
[INFO] Connecting to Gradle Daemon
...
[INFO] Task :publishPluginMavenPublicationToMavenLocal
> Task :publishMavenJavaPublicationToMavenLocal
> Task :generatePomFileForOpenApiGeneratorPluginMarkerMavenPublication[INFO] Run tasks
> Task :publishOpenApiGeneratorPluginMarkerMavenPublicationToMavenLocal
> Task :generatePomFileForPluginMavenPublication
[INFO] Task :publishToMavenLocal
[INFO] Run tasks
[INFO] Run build
[INFO] Build
[INFO] Deleting unused version-specific caches in /mnt/c/publicgithub/openapi-generator/modules/openapi-generator-gradle-plugin/.gradle
[INFO] Build
> Task :publishPluginMavenPublicationToMavenLocal
> Task :publishToMavenLocal
BUILD SUCCESSFUL in 6s
14 actionable tasks: 14 executed
[INFO]
[INFO] gradle execution complete

When fails, I get

[INFO] --- gradle-maven-plugin:1.0.8:invoke (default) @ openapi-generator-gradle-plugin-mvn-wrapper ---
[WARNING] The POM for org.gradle:gradle-tooling-api:jar:4.10.2 is missing, no dependency information available

environment 1 error occurs

(I challenged all combination, i.e. 8 patterns)

  • CentOS 6.6
  • maven 3.3.3 / maven 3.5.3
  • java 1.8.0_66, oracle / java 1.8.0_22 openjdk
  • with my local settings.xml / with no settings.xml

environment 2 error occurs

  • CentOS 6.10
  • maven 3.3.9
  • java 1.8.0_212, amazon correto
  • with my local settings.xml

environment 3 no error

  • Windows Subsystem for Linux Ubuntu 1804 on Windows 10
  • maven 3.6.0
  • java 1.8.0_222 openjdk
  • with my local settings.xml / with no settings.xml

environment 4 no error

  • Windows 10
  • maven 3.3.9 (IntelliJ build-in)
  • java 1.8.0_212, amazon correto
  • with my local settings.xml
  • command executed via IntelliJ GUI

@fuj1g0n

fuj1g0n commented Sep 12, 2019

Copy link
Copy Markdown
Author

@jimschubert could you please check my error environment report please? thanks! :)

@fuj1g0n

fuj1g0n commented Sep 26, 2019

Copy link
Copy Markdown
Author

confirmed this PR will

  • environment 1 succeeds (only limited patterns checked)
    • maven 3.5.3
    • java 1.8.0_66 oracle / java 1.8.0_222 openjdk
    • with my local settings.xml / with no settings.xml
  • environment 2 succeeds
  • environment 3 still succeeds
  • environment 4 still succeeds

jmini
jmini approved these changes Sep 27, 2019
View reviewed changes

@jminijmini left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pom file:

 <groupId>org.openapitools</groupId>
<artifactId>openapi-generator-gradle-plugin-mvn-wrapper</artifactId>
<version>4.1.2-SNAPSHOT</version>

Is not something we release. It is only here to trigger gradle as part of the maven build.

It does not seems to hurt to give maven an additional way to fetch the dependencies requested for one of the plugins used in this pom.

@wing328
wing328 merged commit 2664c62 into OpenAPITools:masterSep 27, 2019
jimschubert added a commit that referenced this pull request Sep 30, 2019
@jimschubert
Merge branch 'master' into feature-sets-meta
7700e6e
* master: (207 commits)
Add missing enum processing in C++ codegen, already present for Qt5 (#3986)
[C++] [Pistache] Removed deprecated warnings (#3985)
[C++][Pistache] Simplified model template (#3417)
add go oas3 petstore to ensure up-to-date (#3979)
replace gitter with slack in the doc (#3977)
Fix wrong variable name in LessThan and LessThanOrEqual asserts (#3971)
#3957 - Removed hardcoded baseUrl (#3964)
Regenerate go openapi3 samples (#3975)
[rust] Make it easier to test rust client generator (#3543)
Fix issue3635 (#3948)
add gradle repository (#3867)
[java] allow to use setArtifactVersion() programmatically (#3907)
Add a link to DevRelCon SF 2019 (#3961)
Add a link to a medium blog post (#3960)
update maven-compiler-plugin version (#3956)
fix generateAliasAsModels in default generator (#3951)
Implement BigDecimal to Decimal in swift4 for currency data as type=string format=number (#3910)
Add F# Functions server generator (#3933)
[python-experimental] generate model if type != object if enums/validations exist (#2757)
[scala] add [date-time] field to codegen unit test (#3939)
...
Jesse0Michael pushed a commit to Jesse0Michael/openapi-generator that referenced this pull request Oct 3, 2019
Dec12 | FujigonJesse Michael
add gradle repository (OpenAPITools#3867)
a6a6984
jimschubert added a commit that referenced this pull request Oct 4, 2019
@jimschubert
Merge branch 'master' into batch-generation
92d7b9f
* master: (110 commits)
[golang] Regenerate all go samples (#3988)
Better tests for string (number) (#3953)
Add missing enum processing in C++ codegen, already present for Qt5 (#3986)
[C++] [Pistache] Removed deprecated warnings (#3985)
[C++][Pistache] Simplified model template (#3417)
add go oas3 petstore to ensure up-to-date (#3979)
replace gitter with slack in the doc (#3977)
Fix wrong variable name in LessThan and LessThanOrEqual asserts (#3971)
#3957 - Removed hardcoded baseUrl (#3964)
Regenerate go openapi3 samples (#3975)
[rust] Make it easier to test rust client generator (#3543)
Fix issue3635 (#3948)
add gradle repository (#3867)
[java] allow to use setArtifactVersion() programmatically (#3907)
Add a link to DevRelCon SF 2019 (#3961)
Add a link to a medium blog post (#3960)
update maven-compiler-plugin version (#3956)
fix generateAliasAsModels in default generator (#3951)
Implement BigDecimal to Decimal in swift4 for currency data as type=string format=number (#3910)
Add F# Functions server generator (#3933)
...
@wing328

wing328 commented Oct 4, 2019

Copy link
Copy Markdown
Member

@fujigon thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jminijminijmini approved these changes
@jimschubertjimschubertAwaiting requested review from jimschubert

Assignees

No one assigned

Labels

Enhancement: GeneralOpenAPI Generator Gradle Plugin

Projects

None yet

Milestone

4.1.3

Development

Successfully merging this pull request may close these issues.

4 participants

@fuj1g0n@jimschubert@wing328@jmini
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
add gradle repository for using gralde dependency in plugin by fuj1g0n · Pull Request #3867 · OpenAPITools/openapi-generator · GitHub
Skip to content
add gradle repository for using gralde dependency in plugin - #3867
Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom 
fuj1g0n:feature/add-gradle-repository
Sep 27, 2019
Merged
add gradle repository for using gralde dependency in plugin#3867
wing328 merged 1 commit into
OpenAPITools:masterfrom 
fuj1g0n:feature/add-gradle-repository
Conversation
@fuj1g0n
@fuj1g0nfuj1g0n
commented
Sep 10, 2019•

edited

Loading

Copy link


Copy Markdown

PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  •  Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
org.gradle:gradle-tooling-api is on Gradle Releases repository (cf. https://mvnrepository.com/artifact/org.gradle/gradle-tooling-api/4.10.2)
So, we need to add this repository to pluginManagement.
Without this setting, following error will occur in some environment.
[INFO] --- gradle-maven-plugin:1.0.8:invoke (default) @ openapi-generator-gradle-plugin-mvn-wrapper ---
[WARNING] The POM for org.gradle:gradle-tooling-api:jar:4.10.2 is missing, no dependency information available
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] [INFO] openapi-generator-project .......................... SUCCESS [ 3.859 s]
[INFO] openapi-generator-core ............................. SUCCESS [ 3.680 s]
[INFO] openapi-generator (core library) ................... SUCCESS [ 50.943 s]
[INFO] openapi-generator (executable) ..................... SUCCESS [ 17.679 s]
[INFO] openapi-generator (maven-plugin) ................... SUCCESS [ 6.745 s]
[INFO] openapi-generator-gradle-plugin (maven wrapper) .... FAILURE [ 0.061 s]
[INFO] openapi-generator-online ........................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:23 min
[INFO] Finished at: 2019-09-10T05:05:53+00:00
[INFO] Final Memory: 69M/1395M
[INFO] ------------------------------------------------------------------------

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
@fuj1g0nfuj1g0n
changed the title
add gradle repositoryadd gradle repository for using gralde pluginSep 10, 2019
@fuj1g0nfuj1g0n
changed the title
add gradle repository for using gralde pluginadd gradle repository for using gralde dependency in pluginSep 10, 2019
@jimschubert
jimschubert
commented
Sep 10, 2019

Copy link


Copy Markdown

Member
@fujigon what are the conditions that might cause this? Do you have a modified Maven settings.xml? And what version of Maven?
We don't really build the Gradle plugin via Maven, so it might be better to remove it and just rely on CI to report build issues in the plugin.
@wing328 any thoughts? If no concerns, we may want to merge after 4.1.2 is released. Workaround for whatever environment conditions cause this would be for the user to manually add the above configuration locally.
@wing328wing328
added this to the 4.1.2 milestone
Sep 10, 2019
@fuj1g0n
fuj1g0n
commented
Sep 11, 2019

Copy link


Copy Markdown

Author
I'm still gathering the facts, please give me a moment.
@wing328wing328
modified the milestones:
4.1.2, 4.1.3Sep 11, 2019
@fuj1g0n
fuj1g0n
commented
Sep 12, 2019•

edited

Loading

Copy link


Copy Markdown

Author
can reproduce the error in some environments, cannot do in other environments.
Following command will reproduce the error though I found the issue while I run my complicated mvn commands for my internal package release to my private maven repository.
mvn install

I confirmed that all my trial invoke gradle-maven-plugin:1.0.8:invoke, and the error is produced by it (if error occurs).

But results varies in environments.
When succeeds, I get
[INFO] --- gradle-maven-plugin:1.0.8:invoke (default) @ openapi-generator-gradle-plugin-mvn-wrapper ---
[INFO] jvmArgs: [Ljava.lang.String;@1841d013
[INFO] gradleProjectDirectory: /mnt/c/publicgithub/openapi-generator/modules/openapi-generator-gradle-plugin
[INFO] Build
[INFO] Connecting to Gradle Daemon
...
[INFO] Task :publishPluginMavenPublicationToMavenLocal
> Task :publishMavenJavaPublicationToMavenLocal
> Task :generatePomFileForOpenApiGeneratorPluginMarkerMavenPublication[INFO] Run tasks
> Task :publishOpenApiGeneratorPluginMarkerMavenPublicationToMavenLocal
> Task :generatePomFileForPluginMavenPublication
[INFO] Task :publishToMavenLocal
[INFO] Run tasks
[INFO] Run build
[INFO] Build
[INFO] Deleting unused version-specific caches in /mnt/c/publicgithub/openapi-generator/modules/openapi-generator-gradle-plugin/.gradle
[INFO] Build
> Task :publishPluginMavenPublicationToMavenLocal
> Task :publishToMavenLocal
BUILD SUCCESSFUL in 6s
14 actionable tasks: 14 executed
[INFO]
[INFO] gradle execution complete

When fails, I get
[INFO] --- gradle-maven-plugin:1.0.8:invoke (default) @ openapi-generator-gradle-plugin-mvn-wrapper ---
[WARNING] The POM for org.gradle:gradle-tooling-api:jar:4.10.2 is missing, no dependency information available

environment 1 error occurs
(I challenged all combination, i.e. 8 patterns)
  • CentOS 6.6
  • maven 3.3.3 / maven 3.5.3
  • java 1.8.0_66, oracle / java 1.8.0_22 openjdk
  • with my local settings.xml / with no settings.xml
environment 2 error occurs
  • CentOS 6.10
  • maven 3.3.9
  • java 1.8.0_212, amazon correto
  • with my local settings.xml
environment 3 no error
  • Windows Subsystem for Linux Ubuntu 1804 on Windows 10
  • maven 3.6.0
  • java 1.8.0_222 openjdk
  • with my local settings.xml / with no settings.xml
environment 4 no error
  • Windows 10
  • maven 3.3.9 (IntelliJ build-in)
  • java 1.8.0_212, amazon correto
  • with my local settings.xml
  • command executed via IntelliJ GUI
@fuj1g0n
fuj1g0n
commented
Sep 12, 2019

Copy link


Copy Markdown

Author
@jimschubert could you please check my error environment report please? thanks! :)
@fuj1g0n
fuj1g0n
commented
Sep 26, 2019

Copy link


Copy Markdown

Author
confirmed this PR will
  • environment 1 succeeds (only limited patterns checked)

    • maven 3.5.3
    • java 1.8.0_66 oracle / java 1.8.0_222 openjdk
    • with my local settings.xml / with no settings.xml
  • environment 2 succeeds
  • environment 3 still succeeds
  • environment 4 still succeeds
jmini
jmini
approved these changes
Sep 27, 2019
View reviewed changes
@jminijmini
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pom file:
 <groupId>org.openapitools</groupId>
<artifactId>openapi-generator-gradle-plugin-mvn-wrapper</artifactId>
<version>4.1.2-SNAPSHOT</version>
Is not something we release. It is only here to trigger gradle as part of the maven build.
It does not seems to hurt to give maven an additional way to fetch the dependencies requested for one of the plugins used in this pom.
@wing328
wing328
merged commit 2664c62
into
OpenAPITools:masterSep 27, 2019
jimschubert added a commit
that referenced
this pull request
Sep 30, 2019
@jimschubert
Merge branch 'master' into feature-sets-meta
7700e6e
* master: (207 commits)
Add missing enum processing in C++ codegen, already present for Qt5 (#3986)
[C++] [Pistache] Removed deprecated warnings (#3985)
[C++][Pistache] Simplified model template (#3417)
add go oas3 petstore to ensure up-to-date (#3979)
replace gitter with slack in the doc (#3977)
Fix wrong variable name in LessThan and LessThanOrEqual asserts (#3971)
#3957 - Removed hardcoded baseUrl (#3964)
Regenerate go openapi3 samples (#3975)
[rust] Make it easier to test rust client generator (#3543)
Fix issue3635 (#3948)
add gradle repository (#3867)
[java] allow to use setArtifactVersion() programmatically (#3907)
Add a link to DevRelCon SF 2019 (#3961)
Add a link to a medium blog post (#3960)
update maven-compiler-plugin version (#3956)
fix generateAliasAsModels in default generator (#3951)
Implement BigDecimal to Decimal in swift4 for currency data as type=string format=number (#3910)
Add F# Functions server generator (#3933)
[python-experimental] generate model if type != object if enums/validations exist (#2757)
[scala] add [date-time] field to codegen unit test (#3939)
...
Jesse0Michael pushed a commit
to Jesse0Michael/openapi-generator
that referenced
this pull request
Oct 3, 2019
Dec12 | FujigonJesse Michael
add gradle repository (OpenAPITools#3867)
a6a6984
jimschubert added a commit
that referenced
this pull request
Oct 4, 2019
@jimschubert
Merge branch 'master' into batch-generation
92d7b9f
* master: (110 commits)
[golang] Regenerate all go samples (#3988)
Better tests for string (number) (#3953)
Add missing enum processing in C++ codegen, already present for Qt5 (#3986)
[C++] [Pistache] Removed deprecated warnings (#3985)
[C++][Pistache] Simplified model template (#3417)
add go oas3 petstore to ensure up-to-date (#3979)
replace gitter with slack in the doc (#3977)
Fix wrong variable name in LessThan and LessThanOrEqual asserts (#3971)
#3957 - Removed hardcoded baseUrl (#3964)
Regenerate go openapi3 samples (#3975)
[rust] Make it easier to test rust client generator (#3543)
Fix issue3635 (#3948)
add gradle repository (#3867)
[java] allow to use setArtifactVersion() programmatically (#3907)
Add a link to DevRelCon SF 2019 (#3961)
Add a link to a medium blog post (#3960)
update maven-compiler-plugin version (#3956)
fix generateAliasAsModels in default generator (#3951)
Implement BigDecimal to Decimal in swift4 for currency data as type=string format=number (#3910)
Add F# Functions server generator (#3933)
...
@wing328
wing328
commented
Oct 4, 2019

Copy link


Copy Markdown

Member
@fujigon thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jminijminijmini approved these changes
@jimschubertjimschubertAwaiting requested review from jimschubert

Assignees


No one assigned


Labels

Enhancement: GeneralOpenAPI Generator Gradle Plugin

Projects


None yet


Milestone

4.1.3

Development

Successfully merging this pull request may close these issues.

4 participants

@fuj1g0n@jimschubert@wing328@jmini

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
add gradle repository for using gralde dependency in plugin by fuj1g0n · Pull Request #3867 · OpenAPITools/openapi-generator · GitHub
Skip to content
add gradle repository for using gralde dependency in plugin - #3867
Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom 
fuj1g0n:feature/add-gradle-repository
Sep 27, 2019
Merged
add gradle repository for using gralde dependency in plugin#3867
wing328 merged 1 commit into
OpenAPITools:masterfrom 
fuj1g0n:feature/add-gradle-repository
Conversation
@fuj1g0n
@fuj1g0nfuj1g0n
commented
Sep 10, 2019•

edited

Loading

Copy link


Copy Markdown

PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  •  Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
org.gradle:gradle-tooling-api is on Gradle Releases repository (cf. https://mvnrepository.com/artifact/org.gradle/gradle-tooling-api/4.10.2)
So, we need to add this repository to pluginManagement.
Without this setting, following error will occur in some environment.
[INFO] --- gradle-maven-plugin:1.0.8:invoke (default) @ openapi-generator-gradle-plugin-mvn-wrapper ---
[WARNING] The POM for org.gradle:gradle-tooling-api:jar:4.10.2 is missing, no dependency information available
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] [INFO] openapi-generator-project .......................... SUCCESS [ 3.859 s]
[INFO] openapi-generator-core ............................. SUCCESS [ 3.680 s]
[INFO] openapi-generator (core library) ................... SUCCESS [ 50.943 s]
[INFO] openapi-generator (executable) ..................... SUCCESS [ 17.679 s]
[INFO] openapi-generator (maven-plugin) ................... SUCCESS [ 6.745 s]
[INFO] openapi-generator-gradle-plugin (maven wrapper) .... FAILURE [ 0.061 s]
[INFO] openapi-generator-online ........................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:23 min
[INFO] Finished at: 2019-09-10T05:05:53+00:00
[INFO] Final Memory: 69M/1395M
[INFO] ------------------------------------------------------------------------

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
@fuj1g0nfuj1g0n
changed the title
add gradle repositoryadd gradle repository for using gralde pluginSep 10, 2019
@fuj1g0nfuj1g0n
changed the title
add gradle repository for using gralde pluginadd gradle repository for using gralde dependency in pluginSep 10, 2019
@jimschubert
jimschubert
commented
Sep 10, 2019

Copy link


Copy Markdown

Member
@fujigon what are the conditions that might cause this? Do you have a modified Maven settings.xml? And what version of Maven?
We don't really build the Gradle plugin via Maven, so it might be better to remove it and just rely on CI to report build issues in the plugin.
@wing328 any thoughts? If no concerns, we may want to merge after 4.1.2 is released. Workaround for whatever environment conditions cause this would be for the user to manually add the above configuration locally.
@wing328wing328
added this to the 4.1.2 milestone
Sep 10, 2019
@fuj1g0n
fuj1g0n
commented
Sep 11, 2019

Copy link


Copy Markdown

Author
I'm still gathering the facts, please give me a moment.
@wing328wing328
modified the milestones:
4.1.2, 4.1.3Sep 11, 2019
@fuj1g0n
fuj1g0n
commented
Sep 12, 2019•

edited

Loading

Copy link


Copy Markdown

Author
can reproduce the error in some environments, cannot do in other environments.
Following command will reproduce the error though I found the issue while I run my complicated mvn commands for my internal package release to my private maven repository.
mvn install

I confirmed that all my trial invoke gradle-maven-plugin:1.0.8:invoke, and the error is produced by it (if error occurs).

But results varies in environments.
When succeeds, I get
[INFO] --- gradle-maven-plugin:1.0.8:invoke (default) @ openapi-generator-gradle-plugin-mvn-wrapper ---
[INFO] jvmArgs: [Ljava.lang.String;@1841d013
[INFO] gradleProjectDirectory: /mnt/c/publicgithub/openapi-generator/modules/openapi-generator-gradle-plugin
[INFO] Build
[INFO] Connecting to Gradle Daemon
...
[INFO] Task :publishPluginMavenPublicationToMavenLocal
> Task :publishMavenJavaPublicationToMavenLocal
> Task :generatePomFileForOpenApiGeneratorPluginMarkerMavenPublication[INFO] Run tasks
> Task :publishOpenApiGeneratorPluginMarkerMavenPublicationToMavenLocal
> Task :generatePomFileForPluginMavenPublication
[INFO] Task :publishToMavenLocal
[INFO] Run tasks
[INFO] Run build
[INFO] Build
[INFO] Deleting unused version-specific caches in /mnt/c/publicgithub/openapi-generator/modules/openapi-generator-gradle-plugin/.gradle
[INFO] Build
> Task :publishPluginMavenPublicationToMavenLocal
> Task :publishToMavenLocal
BUILD SUCCESSFUL in 6s
14 actionable tasks: 14 executed
[INFO]
[INFO] gradle execution complete

When fails, I get
[INFO] --- gradle-maven-plugin:1.0.8:invoke (default) @ openapi-generator-gradle-plugin-mvn-wrapper ---
[WARNING] The POM for org.gradle:gradle-tooling-api:jar:4.10.2 is missing, no dependency information available

environment 1 error occurs
(I challenged all combination, i.e. 8 patterns)
  • CentOS 6.6
  • maven 3.3.3 / maven 3.5.3
  • java 1.8.0_66, oracle / java 1.8.0_22 openjdk
  • with my local settings.xml / with no settings.xml
environment 2 error occurs
  • CentOS 6.10
  • maven 3.3.9
  • java 1.8.0_212, amazon correto
  • with my local settings.xml
environment 3 no error
  • Windows Subsystem for Linux Ubuntu 1804 on Windows 10
  • maven 3.6.0
  • java 1.8.0_222 openjdk
  • with my local settings.xml / with no settings.xml
environment 4 no error
  • Windows 10
  • maven 3.3.9 (IntelliJ build-in)
  • java 1.8.0_212, amazon correto
  • with my local settings.xml
  • command executed via IntelliJ GUI
@fuj1g0n
fuj1g0n
commented
Sep 12, 2019

Copy link


Copy Markdown

Author
@jimschubert could you please check my error environment report please? thanks! :)
@fuj1g0n
fuj1g0n
commented
Sep 26, 2019

Copy link


Copy Markdown

Author
confirmed this PR will
  • environment 1 succeeds (only limited patterns checked)

    • maven 3.5.3
    • java 1.8.0_66 oracle / java 1.8.0_222 openjdk
    • with my local settings.xml / with no settings.xml
  • environment 2 succeeds
  • environment 3 still succeeds
  • environment 4 still succeeds
jmini
jmini
approved these changes
Sep 27, 2019
View reviewed changes
@jminijmini
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pom file:
 <groupId>org.openapitools</groupId>
<artifactId>openapi-generator-gradle-plugin-mvn-wrapper</artifactId>
<version>4.1.2-SNAPSHOT</version>
Is not something we release. It is only here to trigger gradle as part of the maven build.
It does not seems to hurt to give maven an additional way to fetch the dependencies requested for one of the plugins used in this pom.
@wing328
wing328
merged commit 2664c62
into
OpenAPITools:masterSep 27, 2019
jimschubert added a commit
that referenced
this pull request
Sep 30, 2019
@jimschubert
Merge branch 'master' into feature-sets-meta
7700e6e
* master: (207 commits)
Add missing enum processing in C++ codegen, already present for Qt5 (#3986)
[C++] [Pistache] Removed deprecated warnings (#3985)
[C++][Pistache] Simplified model template (#3417)
add go oas3 petstore to ensure up-to-date (#3979)
replace gitter with slack in the doc (#3977)
Fix wrong variable name in LessThan and LessThanOrEqual asserts (#3971)
#3957 - Removed hardcoded baseUrl (#3964)
Regenerate go openapi3 samples (#3975)
[rust] Make it easier to test rust client generator (#3543)
Fix issue3635 (#3948)
add gradle repository (#3867)
[java] allow to use setArtifactVersion() programmatically (#3907)
Add a link to DevRelCon SF 2019 (#3961)
Add a link to a medium blog post (#3960)
update maven-compiler-plugin version (#3956)
fix generateAliasAsModels in default generator (#3951)
Implement BigDecimal to Decimal in swift4 for currency data as type=string format=number (#3910)
Add F# Functions server generator (#3933)
[python-experimental] generate model if type != object if enums/validations exist (#2757)
[scala] add [date-time] field to codegen unit test (#3939)
...
Jesse0Michael pushed a commit
to Jesse0Michael/openapi-generator
that referenced
this pull request
Oct 3, 2019
Dec12 | FujigonJesse Michael
add gradle repository (OpenAPITools#3867)
a6a6984
jimschubert added a commit
that referenced
this pull request
Oct 4, 2019
@jimschubert
Merge branch 'master' into batch-generation
92d7b9f
* master: (110 commits)
[golang] Regenerate all go samples (#3988)
Better tests for string (number) (#3953)
Add missing enum processing in C++ codegen, already present for Qt5 (#3986)
[C++] [Pistache] Removed deprecated warnings (#3985)
[C++][Pistache] Simplified model template (#3417)
add go oas3 petstore to ensure up-to-date (#3979)
replace gitter with slack in the doc (#3977)
Fix wrong variable name in LessThan and LessThanOrEqual asserts (#3971)
#3957 - Removed hardcoded baseUrl (#3964)
Regenerate go openapi3 samples (#3975)
[rust] Make it easier to test rust client generator (#3543)
Fix issue3635 (#3948)
add gradle repository (#3867)
[java] allow to use setArtifactVersion() programmatically (#3907)
Add a link to DevRelCon SF 2019 (#3961)
Add a link to a medium blog post (#3960)
update maven-compiler-plugin version (#3956)
fix generateAliasAsModels in default generator (#3951)
Implement BigDecimal to Decimal in swift4 for currency data as type=string format=number (#3910)
Add F# Functions server generator (#3933)
...
@wing328
wing328
commented
Oct 4, 2019

Copy link


Copy Markdown

Member
@fujigon thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jminijminijmini approved these changes
@jimschubertjimschubertAwaiting requested review from jimschubert

Assignees


No one assigned


Labels

Enhancement: GeneralOpenAPI Generator Gradle Plugin

Projects


None yet


Milestone

4.1.3

Development

Successfully merging this pull request may close these issues.

4 participants

@fuj1g0n@jimschubert@wing328@jmini

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
add gradle repository for using gralde dependency in plugin by fuj1g0n · Pull Request #3867 · OpenAPITools/openapi-generator · GitHub
Skip to content
add gradle repository for using gralde dependency in plugin - #3867
Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom 
fuj1g0n:feature/add-gradle-repository
Sep 27, 2019
Merged
add gradle repository for using gralde dependency in plugin#3867
wing328 merged 1 commit into
OpenAPITools:masterfrom 
fuj1g0n:feature/add-gradle-repository
Conversation
@fuj1g0n
@fuj1g0nfuj1g0n
commented
Sep 10, 2019•

edited

Loading

Copy link


Copy Markdown

PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  •  Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
org.gradle:gradle-tooling-api is on Gradle Releases repository (cf. https://mvnrepository.com/artifact/org.gradle/gradle-tooling-api/4.10.2)
So, we need to add this repository to pluginManagement.
Without this setting, following error will occur in some environment.
[INFO] --- gradle-maven-plugin:1.0.8:invoke (default) @ openapi-generator-gradle-plugin-mvn-wrapper ---
[WARNING] The POM for org.gradle:gradle-tooling-api:jar:4.10.2 is missing, no dependency information available
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] [INFO] openapi-generator-project .......................... SUCCESS [ 3.859 s]
[INFO] openapi-generator-core ............................. SUCCESS [ 3.680 s]
[INFO] openapi-generator (core library) ................... SUCCESS [ 50.943 s]
[INFO] openapi-generator (executable) ..................... SUCCESS [ 17.679 s]
[INFO] openapi-generator (maven-plugin) ................... SUCCESS [ 6.745 s]
[INFO] openapi-generator-gradle-plugin (maven wrapper) .... FAILURE [ 0.061 s]
[INFO] openapi-generator-online ........................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:23 min
[INFO] Finished at: 2019-09-10T05:05:53+00:00
[INFO] Final Memory: 69M/1395M
[INFO] ------------------------------------------------------------------------

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
@fuj1g0nfuj1g0n
changed the title
add gradle repositoryadd gradle repository for using gralde pluginSep 10, 2019
@fuj1g0nfuj1g0n
changed the title
add gradle repository for using gralde pluginadd gradle repository for using gralde dependency in pluginSep 10, 2019
@jimschubert
jimschubert
commented
Sep 10, 2019

Copy link


Copy Markdown

Member
@fujigon what are the conditions that might cause this? Do you have a modified Maven settings.xml? And what version of Maven?
We don't really build the Gradle plugin via Maven, so it might be better to remove it and just rely on CI to report build issues in the plugin.
@wing328 any thoughts? If no concerns, we may want to merge after 4.1.2 is released. Workaround for whatever environment conditions cause this would be for the user to manually add the above configuration locally.
@wing328wing328
added this to the 4.1.2 milestone
Sep 10, 2019
@fuj1g0n
fuj1g0n
commented
Sep 11, 2019

Copy link


Copy Markdown

Author
I'm still gathering the facts, please give me a moment.
@wing328wing328
modified the milestones:
4.1.2, 4.1.3Sep 11, 2019
@fuj1g0n
fuj1g0n
commented
Sep 12, 2019•

edited

Loading

Copy link


Copy Markdown

Author
can reproduce the error in some environments, cannot do in other environments.
Following command will reproduce the error though I found the issue while I run my complicated mvn commands for my internal package release to my private maven repository.
mvn install

I confirmed that all my trial invoke gradle-maven-plugin:1.0.8:invoke, and the error is produced by it (if error occurs).

But results varies in environments.
When succeeds, I get
[INFO] --- gradle-maven-plugin:1.0.8:invoke (default) @ openapi-generator-gradle-plugin-mvn-wrapper ---
[INFO] jvmArgs: [Ljava.lang.String;@1841d013
[INFO] gradleProjectDirectory: /mnt/c/publicgithub/openapi-generator/modules/openapi-generator-gradle-plugin
[INFO] Build
[INFO] Connecting to Gradle Daemon
...
[INFO] Task :publishPluginMavenPublicationToMavenLocal
> Task :publishMavenJavaPublicationToMavenLocal
> Task :generatePomFileForOpenApiGeneratorPluginMarkerMavenPublication[INFO] Run tasks
> Task :publishOpenApiGeneratorPluginMarkerMavenPublicationToMavenLocal
> Task :generatePomFileForPluginMavenPublication
[INFO] Task :publishToMavenLocal
[INFO] Run tasks
[INFO] Run build
[INFO] Build
[INFO] Deleting unused version-specific caches in /mnt/c/publicgithub/openapi-generator/modules/openapi-generator-gradle-plugin/.gradle
[INFO] Build
> Task :publishPluginMavenPublicationToMavenLocal
> Task :publishToMavenLocal
BUILD SUCCESSFUL in 6s
14 actionable tasks: 14 executed
[INFO]
[INFO] gradle execution complete

When fails, I get
[INFO] --- gradle-maven-plugin:1.0.8:invoke (default) @ openapi-generator-gradle-plugin-mvn-wrapper ---
[WARNING] The POM for org.gradle:gradle-tooling-api:jar:4.10.2 is missing, no dependency information available

environment 1 error occurs
(I challenged all combination, i.e. 8 patterns)
  • CentOS 6.6
  • maven 3.3.3 / maven 3.5.3
  • java 1.8.0_66, oracle / java 1.8.0_22 openjdk
  • with my local settings.xml / with no settings.xml
environment 2 error occurs
  • CentOS 6.10
  • maven 3.3.9
  • java 1.8.0_212, amazon correto
  • with my local settings.xml
environment 3 no error
  • Windows Subsystem for Linux Ubuntu 1804 on Windows 10
  • maven 3.6.0
  • java 1.8.0_222 openjdk
  • with my local settings.xml / with no settings.xml
environment 4 no error
  • Windows 10
  • maven 3.3.9 (IntelliJ build-in)
  • java 1.8.0_212, amazon correto
  • with my local settings.xml
  • command executed via IntelliJ GUI
@fuj1g0n
fuj1g0n
commented
Sep 12, 2019

Copy link


Copy Markdown

Author
@jimschubert could you please check my error environment report please? thanks! :)
@fuj1g0n
fuj1g0n
commented
Sep 26, 2019

Copy link


Copy Markdown

Author
confirmed this PR will
  • environment 1 succeeds (only limited patterns checked)

    • maven 3.5.3
    • java 1.8.0_66 oracle / java 1.8.0_222 openjdk
    • with my local settings.xml / with no settings.xml
  • environment 2 succeeds
  • environment 3 still succeeds
  • environment 4 still succeeds
jmini
jmini
approved these changes
Sep 27, 2019
View reviewed changes
@jminijmini
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pom file:
 <groupId>org.openapitools</groupId>
<artifactId>openapi-generator-gradle-plugin-mvn-wrapper</artifactId>
<version>4.1.2-SNAPSHOT</version>
Is not something we release. It is only here to trigger gradle as part of the maven build.
It does not seems to hurt to give maven an additional way to fetch the dependencies requested for one of the plugins used in this pom.
@wing328
wing328
merged commit 2664c62
into
OpenAPITools:masterSep 27, 2019
jimschubert added a commit
that referenced
this pull request
Sep 30, 2019
@jimschubert
Merge branch 'master' into feature-sets-meta
7700e6e
* master: (207 commits)
Add missing enum processing in C++ codegen, already present for Qt5 (#3986)
[C++] [Pistache] Removed deprecated warnings (#3985)
[C++][Pistache] Simplified model template (#3417)
add go oas3 petstore to ensure up-to-date (#3979)
replace gitter with slack in the doc (#3977)
Fix wrong variable name in LessThan and LessThanOrEqual asserts (#3971)
#3957 - Removed hardcoded baseUrl (#3964)
Regenerate go openapi3 samples (#3975)
[rust] Make it easier to test rust client generator (#3543)
Fix issue3635 (#3948)
add gradle repository (#3867)
[java] allow to use setArtifactVersion() programmatically (#3907)
Add a link to DevRelCon SF 2019 (#3961)
Add a link to a medium blog post (#3960)
update maven-compiler-plugin version (#3956)
fix generateAliasAsModels in default generator (#3951)
Implement BigDecimal to Decimal in swift4 for currency data as type=string format=number (#3910)
Add F# Functions server generator (#3933)
[python-experimental] generate model if type != object if enums/validations exist (#2757)
[scala] add [date-time] field to codegen unit test (#3939)
...
Jesse0Michael pushed a commit
to Jesse0Michael/openapi-generator
that referenced
this pull request
Oct 3, 2019
Dec12 | FujigonJesse Michael
add gradle repository (OpenAPITools#3867)
a6a6984
jimschubert added a commit
that referenced
this pull request
Oct 4, 2019
@jimschubert
Merge branch 'master' into batch-generation
92d7b9f
* master: (110 commits)
[golang] Regenerate all go samples (#3988)
Better tests for string (number) (#3953)
Add missing enum processing in C++ codegen, already present for Qt5 (#3986)
[C++] [Pistache] Removed deprecated warnings (#3985)
[C++][Pistache] Simplified model template (#3417)
add go oas3 petstore to ensure up-to-date (#3979)
replace gitter with slack in the doc (#3977)
Fix wrong variable name in LessThan and LessThanOrEqual asserts (#3971)
#3957 - Removed hardcoded baseUrl (#3964)
Regenerate go openapi3 samples (#3975)
[rust] Make it easier to test rust client generator (#3543)
Fix issue3635 (#3948)
add gradle repository (#3867)
[java] allow to use setArtifactVersion() programmatically (#3907)
Add a link to DevRelCon SF 2019 (#3961)
Add a link to a medium blog post (#3960)
update maven-compiler-plugin version (#3956)
fix generateAliasAsModels in default generator (#3951)
Implement BigDecimal to Decimal in swift4 for currency data as type=string format=number (#3910)
Add F# Functions server generator (#3933)
...
@wing328
wing328
commented
Oct 4, 2019

Copy link


Copy Markdown

Member
@fujigon thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jminijminijmini approved these changes
@jimschubertjimschubertAwaiting requested review from jimschubert

Assignees


No one assigned


Labels

Enhancement: GeneralOpenAPI Generator Gradle Plugin

Projects


None yet


Milestone

4.1.3

Development

Successfully merging this pull request may close these issues.

4 participants

@fuj1g0n@jimschubert@wing328@jmini

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
add gradle repository for using gralde dependency in plugin by fuj1g0n · Pull Request #3867 · OpenAPITools/openapi-generator · GitHub
Skip to content
add gradle repository for using gralde dependency in plugin - #3867
Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom 
fuj1g0n:feature/add-gradle-repository
Sep 27, 2019
Merged
add gradle repository for using gralde dependency in plugin#3867
wing328 merged 1 commit into
OpenAPITools:masterfrom 
fuj1g0n:feature/add-gradle-repository
Conversation
@fuj1g0n
@fuj1g0nfuj1g0n
commented
Sep 10, 2019•

edited

Loading

Copy link


Copy Markdown

PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  •  Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
org.gradle:gradle-tooling-api is on Gradle Releases repository (cf. https://mvnrepository.com/artifact/org.gradle/gradle-tooling-api/4.10.2)
So, we need to add this repository to pluginManagement.
Without this setting, following error will occur in some environment.
[INFO] --- gradle-maven-plugin:1.0.8:invoke (default) @ openapi-generator-gradle-plugin-mvn-wrapper ---
[WARNING] The POM for org.gradle:gradle-tooling-api:jar:4.10.2 is missing, no dependency information available
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] [INFO] openapi-generator-project .......................... SUCCESS [ 3.859 s]
[INFO] openapi-generator-core ............................. SUCCESS [ 3.680 s]
[INFO] openapi-generator (core library) ................... SUCCESS [ 50.943 s]
[INFO] openapi-generator (executable) ..................... SUCCESS [ 17.679 s]
[INFO] openapi-generator (maven-plugin) ................... SUCCESS [ 6.745 s]
[INFO] openapi-generator-gradle-plugin (maven wrapper) .... FAILURE [ 0.061 s]
[INFO] openapi-generator-online ........................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:23 min
[INFO] Finished at: 2019-09-10T05:05:53+00:00
[INFO] Final Memory: 69M/1395M
[INFO] ------------------------------------------------------------------------

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
@fuj1g0nfuj1g0n
changed the title
add gradle repositoryadd gradle repository for using gralde pluginSep 10, 2019
@fuj1g0nfuj1g0n
changed the title
add gradle repository for using gralde pluginadd gradle repository for using gralde dependency in pluginSep 10, 2019
@jimschubert
jimschubert
commented
Sep 10, 2019

Copy link


Copy Markdown

Member
@fujigon what are the conditions that might cause this? Do you have a modified Maven settings.xml? And what version of Maven?
We don't really build the Gradle plugin via Maven, so it might be better to remove it and just rely on CI to report build issues in the plugin.
@wing328 any thoughts? If no concerns, we may want to merge after 4.1.2 is released. Workaround for whatever environment conditions cause this would be for the user to manually add the above configuration locally.
@wing328wing328
added this to the 4.1.2 milestone
Sep 10, 2019
@fuj1g0n
fuj1g0n
commented
Sep 11, 2019

Copy link


Copy Markdown

Author
I'm still gathering the facts, please give me a moment.
@wing328wing328
modified the milestones:
4.1.2, 4.1.3Sep 11, 2019
@fuj1g0n
fuj1g0n
commented
Sep 12, 2019•

edited

Loading

Copy link


Copy Markdown

Author
can reproduce the error in some environments, cannot do in other environments.
Following command will reproduce the error though I found the issue while I run my complicated mvn commands for my internal package release to my private maven repository.
mvn install

I confirmed that all my trial invoke gradle-maven-plugin:1.0.8:invoke, and the error is produced by it (if error occurs).

But results varies in environments.
When succeeds, I get
[INFO] --- gradle-maven-plugin:1.0.8:invoke (default) @ openapi-generator-gradle-plugin-mvn-wrapper ---
[INFO] jvmArgs: [Ljava.lang.String;@1841d013
[INFO] gradleProjectDirectory: /mnt/c/publicgithub/openapi-generator/modules/openapi-generator-gradle-plugin
[INFO] Build
[INFO] Connecting to Gradle Daemon
...
[INFO] Task :publishPluginMavenPublicationToMavenLocal
> Task :publishMavenJavaPublicationToMavenLocal
> Task :generatePomFileForOpenApiGeneratorPluginMarkerMavenPublication[INFO] Run tasks
> Task :publishOpenApiGeneratorPluginMarkerMavenPublicationToMavenLocal
> Task :generatePomFileForPluginMavenPublication
[INFO] Task :publishToMavenLocal
[INFO] Run tasks
[INFO] Run build
[INFO] Build
[INFO] Deleting unused version-specific caches in /mnt/c/publicgithub/openapi-generator/modules/openapi-generator-gradle-plugin/.gradle
[INFO] Build
> Task :publishPluginMavenPublicationToMavenLocal
> Task :publishToMavenLocal
BUILD SUCCESSFUL in 6s
14 actionable tasks: 14 executed
[INFO]
[INFO] gradle execution complete

When fails, I get
[INFO] --- gradle-maven-plugin:1.0.8:invoke (default) @ openapi-generator-gradle-plugin-mvn-wrapper ---
[WARNING] The POM for org.gradle:gradle-tooling-api:jar:4.10.2 is missing, no dependency information available

environment 1 error occurs
(I challenged all combination, i.e. 8 patterns)
  • CentOS 6.6
  • maven 3.3.3 / maven 3.5.3
  • java 1.8.0_66, oracle / java 1.8.0_22 openjdk
  • with my local settings.xml / with no settings.xml
environment 2 error occurs
  • CentOS 6.10
  • maven 3.3.9
  • java 1.8.0_212, amazon correto
  • with my local settings.xml
environment 3 no error
  • Windows Subsystem for Linux Ubuntu 1804 on Windows 10
  • maven 3.6.0
  • java 1.8.0_222 openjdk
  • with my local settings.xml / with no settings.xml
environment 4 no error
  • Windows 10
  • maven 3.3.9 (IntelliJ build-in)
  • java 1.8.0_212, amazon correto
  • with my local settings.xml
  • command executed via IntelliJ GUI
@fuj1g0n
fuj1g0n
commented
Sep 12, 2019

Copy link


Copy Markdown

Author
@jimschubert could you please check my error environment report please? thanks! :)
@fuj1g0n
fuj1g0n
commented
Sep 26, 2019

Copy link


Copy Markdown

Author
confirmed this PR will
  • environment 1 succeeds (only limited patterns checked)

    • maven 3.5.3
    • java 1.8.0_66 oracle / java 1.8.0_222 openjdk
    • with my local settings.xml / with no settings.xml
  • environment 2 succeeds
  • environment 3 still succeeds
  • environment 4 still succeeds
jmini
jmini
approved these changes
Sep 27, 2019
View reviewed changes
@jminijmini
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pom file:
 <groupId>org.openapitools</groupId>
<artifactId>openapi-generator-gradle-plugin-mvn-wrapper</artifactId>
<version>4.1.2-SNAPSHOT</version>
Is not something we release. It is only here to trigger gradle as part of the maven build.
It does not seems to hurt to give maven an additional way to fetch the dependencies requested for one of the plugins used in this pom.
@wing328
wing328
merged commit 2664c62
into
OpenAPITools:masterSep 27, 2019
jimschubert added a commit
that referenced
this pull request
Sep 30, 2019
@jimschubert
Merge branch 'master' into feature-sets-meta
7700e6e
* master: (207 commits)
Add missing enum processing in C++ codegen, already present for Qt5 (#3986)
[C++] [Pistache] Removed deprecated warnings (#3985)
[C++][Pistache] Simplified model template (#3417)
add go oas3 petstore to ensure up-to-date (#3979)
replace gitter with slack in the doc (#3977)
Fix wrong variable name in LessThan and LessThanOrEqual asserts (#3971)
#3957 - Removed hardcoded baseUrl (#3964)
Regenerate go openapi3 samples (#3975)
[rust] Make it easier to test rust client generator (#3543)
Fix issue3635 (#3948)
add gradle repository (#3867)
[java] allow to use setArtifactVersion() programmatically (#3907)
Add a link to DevRelCon SF 2019 (#3961)
Add a link to a medium blog post (#3960)
update maven-compiler-plugin version (#3956)
fix generateAliasAsModels in default generator (#3951)
Implement BigDecimal to Decimal in swift4 for currency data as type=string format=number (#3910)
Add F# Functions server generator (#3933)
[python-experimental] generate model if type != object if enums/validations exist (#2757)
[scala] add [date-time] field to codegen unit test (#3939)
...
Jesse0Michael pushed a commit
to Jesse0Michael/openapi-generator
that referenced
this pull request
Oct 3, 2019
Dec12 | FujigonJesse Michael
add gradle repository (OpenAPITools#3867)
a6a6984
jimschubert added a commit
that referenced
this pull request
Oct 4, 2019
@jimschubert
Merge branch 'master' into batch-generation
92d7b9f
* master: (110 commits)
[golang] Regenerate all go samples (#3988)
Better tests for string (number) (#3953)
Add missing enum processing in C++ codegen, already present for Qt5 (#3986)
[C++] [Pistache] Removed deprecated warnings (#3985)
[C++][Pistache] Simplified model template (#3417)
add go oas3 petstore to ensure up-to-date (#3979)
replace gitter with slack in the doc (#3977)
Fix wrong variable name in LessThan and LessThanOrEqual asserts (#3971)
#3957 - Removed hardcoded baseUrl (#3964)
Regenerate go openapi3 samples (#3975)
[rust] Make it easier to test rust client generator (#3543)
Fix issue3635 (#3948)
add gradle repository (#3867)
[java] allow to use setArtifactVersion() programmatically (#3907)
Add a link to DevRelCon SF 2019 (#3961)
Add a link to a medium blog post (#3960)
update maven-compiler-plugin version (#3956)
fix generateAliasAsModels in default generator (#3951)
Implement BigDecimal to Decimal in swift4 for currency data as type=string format=number (#3910)
Add F# Functions server generator (#3933)
...
@wing328
wing328
commented
Oct 4, 2019

Copy link


Copy Markdown

Member
@fujigon thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jminijminijmini approved these changes
@jimschubertjimschubertAwaiting requested review from jimschubert

Assignees


No one assigned


Labels

Enhancement: GeneralOpenAPI Generator Gradle Plugin

Projects


None yet


Milestone

4.1.3

Development

Successfully merging this pull request may close these issues.

4 participants

@fuj1g0n@jimschubert@wing328@jmini

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
add gradle repository for using gralde dependency in plugin by fuj1g0n · Pull Request #3867 · OpenAPITools/openapi-generator · GitHub
Skip to content
add gradle repository for using gralde dependency in plugin - #3867
Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom 
fuj1g0n:feature/add-gradle-repository
Sep 27, 2019
Merged
add gradle repository for using gralde dependency in plugin#3867
wing328 merged 1 commit into
OpenAPITools:masterfrom 
fuj1g0n:feature/add-gradle-repository
Conversation
@fuj1g0n
@fuj1g0nfuj1g0n
commented
Sep 10, 2019•

edited

Loading

Copy link


Copy Markdown

PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  •  Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
org.gradle:gradle-tooling-api is on Gradle Releases repository (cf. https://mvnrepository.com/artifact/org.gradle/gradle-tooling-api/4.10.2)
So, we need to add this repository to pluginManagement.
Without this setting, following error will occur in some environment.
[INFO] --- gradle-maven-plugin:1.0.8:invoke (default) @ openapi-generator-gradle-plugin-mvn-wrapper ---
[WARNING] The POM for org.gradle:gradle-tooling-api:jar:4.10.2 is missing, no dependency information available
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] [INFO] openapi-generator-project .......................... SUCCESS [ 3.859 s]
[INFO] openapi-generator-core ............................. SUCCESS [ 3.680 s]
[INFO] openapi-generator (core library) ................... SUCCESS [ 50.943 s]
[INFO] openapi-generator (executable) ..................... SUCCESS [ 17.679 s]
[INFO] openapi-generator (maven-plugin) ................... SUCCESS [ 6.745 s]
[INFO] openapi-generator-gradle-plugin (maven wrapper) .... FAILURE [ 0.061 s]
[INFO] openapi-generator-online ........................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:23 min
[INFO] Finished at: 2019-09-10T05:05:53+00:00
[INFO] Final Memory: 69M/1395M
[INFO] ------------------------------------------------------------------------

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
@fuj1g0nfuj1g0n
changed the title
add gradle repositoryadd gradle repository for using gralde pluginSep 10, 2019
@fuj1g0nfuj1g0n
changed the title
add gradle repository for using gralde pluginadd gradle repository for using gralde dependency in pluginSep 10, 2019
@jimschubert
jimschubert
commented
Sep 10, 2019

Copy link


Copy Markdown

Member
@fujigon what are the conditions that might cause this? Do you have a modified Maven settings.xml? And what version of Maven?
We don't really build the Gradle plugin via Maven, so it might be better to remove it and just rely on CI to report build issues in the plugin.
@wing328 any thoughts? If no concerns, we may want to merge after 4.1.2 is released. Workaround for whatever environment conditions cause this would be for the user to manually add the above configuration locally.
@wing328wing328
added this to the 4.1.2 milestone
Sep 10, 2019
@fuj1g0n
fuj1g0n
commented
Sep 11, 2019

Copy link


Copy Markdown

Author
I'm still gathering the facts, please give me a moment.
@wing328wing328
modified the milestones:
4.1.2, 4.1.3Sep 11, 2019
@fuj1g0n
fuj1g0n
commented
Sep 12, 2019•

edited

Loading

Copy link


Copy Markdown

Author
can reproduce the error in some environments, cannot do in other environments.
Following command will reproduce the error though I found the issue while I run my complicated mvn commands for my internal package release to my private maven repository.
mvn install

I confirmed that all my trial invoke gradle-maven-plugin:1.0.8:invoke, and the error is produced by it (if error occurs).

But results varies in environments.
When succeeds, I get
[INFO] --- gradle-maven-plugin:1.0.8:invoke (default) @ openapi-generator-gradle-plugin-mvn-wrapper ---
[INFO] jvmArgs: [Ljava.lang.String;@1841d013
[INFO] gradleProjectDirectory: /mnt/c/publicgithub/openapi-generator/modules/openapi-generator-gradle-plugin
[INFO] Build
[INFO] Connecting to Gradle Daemon
...
[INFO] Task :publishPluginMavenPublicationToMavenLocal
> Task :publishMavenJavaPublicationToMavenLocal
> Task :generatePomFileForOpenApiGeneratorPluginMarkerMavenPublication[INFO] Run tasks
> Task :publishOpenApiGeneratorPluginMarkerMavenPublicationToMavenLocal
> Task :generatePomFileForPluginMavenPublication
[INFO] Task :publishToMavenLocal
[INFO] Run tasks
[INFO] Run build
[INFO] Build
[INFO] Deleting unused version-specific caches in /mnt/c/publicgithub/openapi-generator/modules/openapi-generator-gradle-plugin/.gradle
[INFO] Build
> Task :publishPluginMavenPublicationToMavenLocal
> Task :publishToMavenLocal
BUILD SUCCESSFUL in 6s
14 actionable tasks: 14 executed
[INFO]
[INFO] gradle execution complete

When fails, I get
[INFO] --- gradle-maven-plugin:1.0.8:invoke (default) @ openapi-generator-gradle-plugin-mvn-wrapper ---
[WARNING] The POM for org.gradle:gradle-tooling-api:jar:4.10.2 is missing, no dependency information available

environment 1 error occurs
(I challenged all combination, i.e. 8 patterns)
  • CentOS 6.6
  • maven 3.3.3 / maven 3.5.3
  • java 1.8.0_66, oracle / java 1.8.0_22 openjdk
  • with my local settings.xml / with no settings.xml
environment 2 error occurs
  • CentOS 6.10
  • maven 3.3.9
  • java 1.8.0_212, amazon correto
  • with my local settings.xml
environment 3 no error
  • Windows Subsystem for Linux Ubuntu 1804 on Windows 10
  • maven 3.6.0
  • java 1.8.0_222 openjdk
  • with my local settings.xml / with no settings.xml
environment 4 no error
  • Windows 10
  • maven 3.3.9 (IntelliJ build-in)
  • java 1.8.0_212, amazon correto
  • with my local settings.xml
  • command executed via IntelliJ GUI
@fuj1g0n
fuj1g0n
commented
Sep 12, 2019

Copy link


Copy Markdown

Author
@jimschubert could you please check my error environment report please? thanks! :)
@fuj1g0n
fuj1g0n
commented
Sep 26, 2019

Copy link


Copy Markdown

Author
confirmed this PR will
  • environment 1 succeeds (only limited patterns checked)

    • maven 3.5.3
    • java 1.8.0_66 oracle / java 1.8.0_222 openjdk
    • with my local settings.xml / with no settings.xml
  • environment 2 succeeds
  • environment 3 still succeeds
  • environment 4 still succeeds
jmini
jmini
approved these changes
Sep 27, 2019
View reviewed changes
@jminijmini
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pom file:
 <groupId>org.openapitools</groupId>
<artifactId>openapi-generator-gradle-plugin-mvn-wrapper</artifactId>
<version>4.1.2-SNAPSHOT</version>
Is not something we release. It is only here to trigger gradle as part of the maven build.
It does not seems to hurt to give maven an additional way to fetch the dependencies requested for one of the plugins used in this pom.
@wing328
wing328
merged commit 2664c62
into
OpenAPITools:masterSep 27, 2019
jimschubert added a commit
that referenced
this pull request
Sep 30, 2019
@jimschubert
Merge branch 'master' into feature-sets-meta
7700e6e
* master: (207 commits)
Add missing enum processing in C++ codegen, already present for Qt5 (#3986)
[C++] [Pistache] Removed deprecated warnings (#3985)
[C++][Pistache] Simplified model template (#3417)
add go oas3 petstore to ensure up-to-date (#3979)
replace gitter with slack in the doc (#3977)
Fix wrong variable name in LessThan and LessThanOrEqual asserts (#3971)
#3957 - Removed hardcoded baseUrl (#3964)
Regenerate go openapi3 samples (#3975)
[rust] Make it easier to test rust client generator (#3543)
Fix issue3635 (#3948)
add gradle repository (#3867)
[java] allow to use setArtifactVersion() programmatically (#3907)
Add a link to DevRelCon SF 2019 (#3961)
Add a link to a medium blog post (#3960)
update maven-compiler-plugin version (#3956)
fix generateAliasAsModels in default generator (#3951)
Implement BigDecimal to Decimal in swift4 for currency data as type=string format=number (#3910)
Add F# Functions server generator (#3933)
[python-experimental] generate model if type != object if enums/validations exist (#2757)
[scala] add [date-time] field to codegen unit test (#3939)
...
Jesse0Michael pushed a commit
to Jesse0Michael/openapi-generator
that referenced
this pull request
Oct 3, 2019
Dec12 | FujigonJesse Michael
add gradle repository (OpenAPITools#3867)
a6a6984
jimschubert added a commit
that referenced
this pull request
Oct 4, 2019
@jimschubert
Merge branch 'master' into batch-generation
92d7b9f
* master: (110 commits)
[golang] Regenerate all go samples (#3988)
Better tests for string (number) (#3953)
Add missing enum processing in C++ codegen, already present for Qt5 (#3986)
[C++] [Pistache] Removed deprecated warnings (#3985)
[C++][Pistache] Simplified model template (#3417)
add go oas3 petstore to ensure up-to-date (#3979)
replace gitter with slack in the doc (#3977)
Fix wrong variable name in LessThan and LessThanOrEqual asserts (#3971)
#3957 - Removed hardcoded baseUrl (#3964)
Regenerate go openapi3 samples (#3975)
[rust] Make it easier to test rust client generator (#3543)
Fix issue3635 (#3948)
add gradle repository (#3867)
[java] allow to use setArtifactVersion() programmatically (#3907)
Add a link to DevRelCon SF 2019 (#3961)
Add a link to a medium blog post (#3960)
update maven-compiler-plugin version (#3956)
fix generateAliasAsModels in default generator (#3951)
Implement BigDecimal to Decimal in swift4 for currency data as type=string format=number (#3910)
Add F# Functions server generator (#3933)
...
@wing328
wing328
commented
Oct 4, 2019

Copy link


Copy Markdown

Member
@fujigon thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jminijminijmini approved these changes
@jimschubertjimschubertAwaiting requested review from jimschubert

Assignees


No one assigned


Labels

Enhancement: GeneralOpenAPI Generator Gradle Plugin

Projects


None yet


Milestone

4.1.3

Development

Successfully merging this pull request may close these issues.

4 participants

@fuj1g0n@jimschubert@wing328@jmini

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
add gradle repository for using gralde dependency in plugin by fuj1g0n · Pull Request #3867 · OpenAPITools/openapi-generator · GitHub
Skip to content
add gradle repository for using gralde dependency in plugin - #3867
Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom 
fuj1g0n:feature/add-gradle-repository
Sep 27, 2019
Merged
add gradle repository for using gralde dependency in plugin#3867
wing328 merged 1 commit into
OpenAPITools:masterfrom 
fuj1g0n:feature/add-gradle-repository
Conversation
@fuj1g0n
@fuj1g0nfuj1g0n
commented
Sep 10, 2019•

edited

Loading

Copy link


Copy Markdown

PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  •  Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
org.gradle:gradle-tooling-api is on Gradle Releases repository (cf. https://mvnrepository.com/artifact/org.gradle/gradle-tooling-api/4.10.2)
So, we need to add this repository to pluginManagement.
Without this setting, following error will occur in some environment.
[INFO] --- gradle-maven-plugin:1.0.8:invoke (default) @ openapi-generator-gradle-plugin-mvn-wrapper ---
[WARNING] The POM for org.gradle:gradle-tooling-api:jar:4.10.2 is missing, no dependency information available
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] [INFO] openapi-generator-project .......................... SUCCESS [ 3.859 s]
[INFO] openapi-generator-core ............................. SUCCESS [ 3.680 s]
[INFO] openapi-generator (core library) ................... SUCCESS [ 50.943 s]
[INFO] openapi-generator (executable) ..................... SUCCESS [ 17.679 s]
[INFO] openapi-generator (maven-plugin) ................... SUCCESS [ 6.745 s]
[INFO] openapi-generator-gradle-plugin (maven wrapper) .... FAILURE [ 0.061 s]
[INFO] openapi-generator-online ........................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:23 min
[INFO] Finished at: 2019-09-10T05:05:53+00:00
[INFO] Final Memory: 69M/1395M
[INFO] ------------------------------------------------------------------------

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
@fuj1g0nfuj1g0n
changed the title
add gradle repositoryadd gradle repository for using gralde pluginSep 10, 2019
@fuj1g0nfuj1g0n
changed the title
add gradle repository for using gralde pluginadd gradle repository for using gralde dependency in pluginSep 10, 2019
@jimschubert
jimschubert
commented
Sep 10, 2019

Copy link


Copy Markdown

Member
@fujigon what are the conditions that might cause this? Do you have a modified Maven settings.xml? And what version of Maven?
We don't really build the Gradle plugin via Maven, so it might be better to remove it and just rely on CI to report build issues in the plugin.
@wing328 any thoughts? If no concerns, we may want to merge after 4.1.2 is released. Workaround for whatever environment conditions cause this would be for the user to manually add the above configuration locally.
@wing328wing328
added this to the 4.1.2 milestone
Sep 10, 2019
@fuj1g0n
fuj1g0n
commented
Sep 11, 2019

Copy link


Copy Markdown

Author
I'm still gathering the facts, please give me a moment.
@wing328wing328
modified the milestones:
4.1.2, 4.1.3Sep 11, 2019
@fuj1g0n
fuj1g0n
commented
Sep 12, 2019•

edited

Loading

Copy link


Copy Markdown

Author
can reproduce the error in some environments, cannot do in other environments.
Following command will reproduce the error though I found the issue while I run my complicated mvn commands for my internal package release to my private maven repository.
mvn install

I confirmed that all my trial invoke gradle-maven-plugin:1.0.8:invoke, and the error is produced by it (if error occurs).

But results varies in environments.
When succeeds, I get
[INFO] --- gradle-maven-plugin:1.0.8:invoke (default) @ openapi-generator-gradle-plugin-mvn-wrapper ---
[INFO] jvmArgs: [Ljava.lang.String;@1841d013
[INFO] gradleProjectDirectory: /mnt/c/publicgithub/openapi-generator/modules/openapi-generator-gradle-plugin
[INFO] Build
[INFO] Connecting to Gradle Daemon
...
[INFO] Task :publishPluginMavenPublicationToMavenLocal
> Task :publishMavenJavaPublicationToMavenLocal
> Task :generatePomFileForOpenApiGeneratorPluginMarkerMavenPublication[INFO] Run tasks
> Task :publishOpenApiGeneratorPluginMarkerMavenPublicationToMavenLocal
> Task :generatePomFileForPluginMavenPublication
[INFO] Task :publishToMavenLocal
[INFO] Run tasks
[INFO] Run build
[INFO] Build
[INFO] Deleting unused version-specific caches in /mnt/c/publicgithub/openapi-generator/modules/openapi-generator-gradle-plugin/.gradle
[INFO] Build
> Task :publishPluginMavenPublicationToMavenLocal
> Task :publishToMavenLocal
BUILD SUCCESSFUL in 6s
14 actionable tasks: 14 executed
[INFO]
[INFO] gradle execution complete

When fails, I get
[INFO] --- gradle-maven-plugin:1.0.8:invoke (default) @ openapi-generator-gradle-plugin-mvn-wrapper ---
[WARNING] The POM for org.gradle:gradle-tooling-api:jar:4.10.2 is missing, no dependency information available

environment 1 error occurs
(I challenged all combination, i.e. 8 patterns)
  • CentOS 6.6
  • maven 3.3.3 / maven 3.5.3
  • java 1.8.0_66, oracle / java 1.8.0_22 openjdk
  • with my local settings.xml / with no settings.xml
environment 2 error occurs
  • CentOS 6.10
  • maven 3.3.9
  • java 1.8.0_212, amazon correto
  • with my local settings.xml
environment 3 no error
  • Windows Subsystem for Linux Ubuntu 1804 on Windows 10
  • maven 3.6.0
  • java 1.8.0_222 openjdk
  • with my local settings.xml / with no settings.xml
environment 4 no error
  • Windows 10
  • maven 3.3.9 (IntelliJ build-in)
  • java 1.8.0_212, amazon correto
  • with my local settings.xml
  • command executed via IntelliJ GUI
@fuj1g0n
fuj1g0n
commented
Sep 12, 2019

Copy link


Copy Markdown

Author
@jimschubert could you please check my error environment report please? thanks! :)
@fuj1g0n
fuj1g0n
commented
Sep 26, 2019

Copy link


Copy Markdown

Author
confirmed this PR will
  • environment 1 succeeds (only limited patterns checked)

    • maven 3.5.3
    • java 1.8.0_66 oracle / java 1.8.0_222 openjdk
    • with my local settings.xml / with no settings.xml
  • environment 2 succeeds
  • environment 3 still succeeds
  • environment 4 still succeeds
jmini
jmini
approved these changes
Sep 27, 2019
View reviewed changes
@jminijmini
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pom file:
 <groupId>org.openapitools</groupId>
<artifactId>openapi-generator-gradle-plugin-mvn-wrapper</artifactId>
<version>4.1.2-SNAPSHOT</version>
Is not something we release. It is only here to trigger gradle as part of the maven build.
It does not seems to hurt to give maven an additional way to fetch the dependencies requested for one of the plugins used in this pom.
@wing328
wing328
merged commit 2664c62
into
OpenAPITools:masterSep 27, 2019
jimschubert added a commit
that referenced
this pull request
Sep 30, 2019
@jimschubert
Merge branch 'master' into feature-sets-meta
7700e6e
* master: (207 commits)
Add missing enum processing in C++ codegen, already present for Qt5 (#3986)
[C++] [Pistache] Removed deprecated warnings (#3985)
[C++][Pistache] Simplified model template (#3417)
add go oas3 petstore to ensure up-to-date (#3979)
replace gitter with slack in the doc (#3977)
Fix wrong variable name in LessThan and LessThanOrEqual asserts (#3971)
#3957 - Removed hardcoded baseUrl (#3964)
Regenerate go openapi3 samples (#3975)
[rust] Make it easier to test rust client generator (#3543)
Fix issue3635 (#3948)
add gradle repository (#3867)
[java] allow to use setArtifactVersion() programmatically (#3907)
Add a link to DevRelCon SF 2019 (#3961)
Add a link to a medium blog post (#3960)
update maven-compiler-plugin version (#3956)
fix generateAliasAsModels in default generator (#3951)
Implement BigDecimal to Decimal in swift4 for currency data as type=string format=number (#3910)
Add F# Functions server generator (#3933)
[python-experimental] generate model if type != object if enums/validations exist (#2757)
[scala] add [date-time] field to codegen unit test (#3939)
...
Jesse0Michael pushed a commit
to Jesse0Michael/openapi-generator
that referenced
this pull request
Oct 3, 2019
Dec12 | FujigonJesse Michael
add gradle repository (OpenAPITools#3867)
a6a6984
jimschubert added a commit
that referenced
this pull request
Oct 4, 2019
@jimschubert
Merge branch 'master' into batch-generation
92d7b9f
* master: (110 commits)
[golang] Regenerate all go samples (#3988)
Better tests for string (number) (#3953)
Add missing enum processing in C++ codegen, already present for Qt5 (#3986)
[C++] [Pistache] Removed deprecated warnings (#3985)
[C++][Pistache] Simplified model template (#3417)
add go oas3 petstore to ensure up-to-date (#3979)
replace gitter with slack in the doc (#3977)
Fix wrong variable name in LessThan and LessThanOrEqual asserts (#3971)
#3957 - Removed hardcoded baseUrl (#3964)
Regenerate go openapi3 samples (#3975)
[rust] Make it easier to test rust client generator (#3543)
Fix issue3635 (#3948)
add gradle repository (#3867)
[java] allow to use setArtifactVersion() programmatically (#3907)
Add a link to DevRelCon SF 2019 (#3961)
Add a link to a medium blog post (#3960)
update maven-compiler-plugin version (#3956)
fix generateAliasAsModels in default generator (#3951)
Implement BigDecimal to Decimal in swift4 for currency data as type=string format=number (#3910)
Add F# Functions server generator (#3933)
...
@wing328
wing328
commented
Oct 4, 2019

Copy link


Copy Markdown

Member
@fujigon thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jminijminijmini approved these changes
@jimschubertjimschubertAwaiting requested review from jimschubert

Assignees


No one assigned


Labels

Enhancement: GeneralOpenAPI Generator Gradle Plugin

Projects


None yet


Milestone

4.1.3

Development

Successfully merging this pull request may close these issues.

4 participants

@fuj1g0n@jimschubert@wing328@jmini

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
add gradle repository for using gralde dependency in plugin by fuj1g0n · Pull Request #3867 · OpenAPITools/openapi-generator · GitHub
Skip to content
add gradle repository for using gralde dependency in plugin - #3867
Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom 
fuj1g0n:feature/add-gradle-repository
Sep 27, 2019
Merged
add gradle repository for using gralde dependency in plugin#3867
wing328 merged 1 commit into
OpenAPITools:masterfrom 
fuj1g0n:feature/add-gradle-repository
Conversation
@fuj1g0n
@fuj1g0nfuj1g0n
commented
Sep 10, 2019•

edited

Loading

Copy link


Copy Markdown

PR checklist
  •  Read the contribution guidelines.
  •  Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  •  Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
org.gradle:gradle-tooling-api is on Gradle Releases repository (cf. https://mvnrepository.com/artifact/org.gradle/gradle-tooling-api/4.10.2)
So, we need to add this repository to pluginManagement.
Without this setting, following error will occur in some environment.
[INFO] --- gradle-maven-plugin:1.0.8:invoke (default) @ openapi-generator-gradle-plugin-mvn-wrapper ---
[WARNING] The POM for org.gradle:gradle-tooling-api:jar:4.10.2 is missing, no dependency information available
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] [INFO] openapi-generator-project .......................... SUCCESS [ 3.859 s]
[INFO] openapi-generator-core ............................. SUCCESS [ 3.680 s]
[INFO] openapi-generator (core library) ................... SUCCESS [ 50.943 s]
[INFO] openapi-generator (executable) ..................... SUCCESS [ 17.679 s]
[INFO] openapi-generator (maven-plugin) ................... SUCCESS [ 6.745 s]
[INFO] openapi-generator-gradle-plugin (maven wrapper) .... FAILURE [ 0.061 s]
[INFO] openapi-generator-online ........................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:23 min
[INFO] Finished at: 2019-09-10T05:05:53+00:00
[INFO] Final Memory: 69M/1395M
[INFO] ------------------------------------------------------------------------

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
@fuj1g0nfuj1g0n
changed the title
add gradle repositoryadd gradle repository for using gralde pluginSep 10, 2019
@fuj1g0nfuj1g0n
changed the title
add gradle repository for using gralde pluginadd gradle repository for using gralde dependency in pluginSep 10, 2019
@jimschubert
jimschubert
commented
Sep 10, 2019

Copy link


Copy Markdown

Member
@fujigon what are the conditions that might cause this? Do you have a modified Maven settings.xml? And what version of Maven?
We don't really build the Gradle plugin via Maven, so it might be better to remove it and just rely on CI to report build issues in the plugin.
@wing328 any thoughts? If no concerns, we may want to merge after 4.1.2 is released. Workaround for whatever environment conditions cause this would be for the user to manually add the above configuration locally.
@wing328wing328
added this to the 4.1.2 milestone
Sep 10, 2019
@fuj1g0n
fuj1g0n
commented
Sep 11, 2019

Copy link


Copy Markdown

Author
I'm still gathering the facts, please give me a moment.
@wing328wing328
modified the milestones:
4.1.2, 4.1.3Sep 11, 2019
@fuj1g0n
fuj1g0n
commented
Sep 12, 2019•

edited

Loading

Copy link


Copy Markdown

Author
can reproduce the error in some environments, cannot do in other environments.
Following command will reproduce the error though I found the issue while I run my complicated mvn commands for my internal package release to my private maven repository.
mvn install

I confirmed that all my trial invoke gradle-maven-plugin:1.0.8:invoke, and the error is produced by it (if error occurs).

But results varies in environments.
When succeeds, I get
[INFO] --- gradle-maven-plugin:1.0.8:invoke (default) @ openapi-generator-gradle-plugin-mvn-wrapper ---
[INFO] jvmArgs: [Ljava.lang.String;@1841d013
[INFO] gradleProjectDirectory: /mnt/c/publicgithub/openapi-generator/modules/openapi-generator-gradle-plugin
[INFO] Build
[INFO] Connecting to Gradle Daemon
...
[INFO] Task :publishPluginMavenPublicationToMavenLocal
> Task :publishMavenJavaPublicationToMavenLocal
> Task :generatePomFileForOpenApiGeneratorPluginMarkerMavenPublication[INFO] Run tasks
> Task :publishOpenApiGeneratorPluginMarkerMavenPublicationToMavenLocal
> Task :generatePomFileForPluginMavenPublication
[INFO] Task :publishToMavenLocal
[INFO] Run tasks
[INFO] Run build
[INFO] Build
[INFO] Deleting unused version-specific caches in /mnt/c/publicgithub/openapi-generator/modules/openapi-generator-gradle-plugin/.gradle
[INFO] Build
> Task :publishPluginMavenPublicationToMavenLocal
> Task :publishToMavenLocal
BUILD SUCCESSFUL in 6s
14 actionable tasks: 14 executed
[INFO]
[INFO] gradle execution complete

When fails, I get
[INFO] --- gradle-maven-plugin:1.0.8:invoke (default) @ openapi-generator-gradle-plugin-mvn-wrapper ---
[WARNING] The POM for org.gradle:gradle-tooling-api:jar:4.10.2 is missing, no dependency information available

environment 1 error occurs
(I challenged all combination, i.e. 8 patterns)
  • CentOS 6.6
  • maven 3.3.3 / maven 3.5.3
  • java 1.8.0_66, oracle / java 1.8.0_22 openjdk
  • with my local settings.xml / with no settings.xml
environment 2 error occurs
  • CentOS 6.10
  • maven 3.3.9
  • java 1.8.0_212, amazon correto
  • with my local settings.xml
environment 3 no error
  • Windows Subsystem for Linux Ubuntu 1804 on Windows 10
  • maven 3.6.0
  • java 1.8.0_222 openjdk
  • with my local settings.xml / with no settings.xml
environment 4 no error
  • Windows 10
  • maven 3.3.9 (IntelliJ build-in)
  • java 1.8.0_212, amazon correto
  • with my local settings.xml
  • command executed via IntelliJ GUI
@fuj1g0n
fuj1g0n
commented
Sep 12, 2019

Copy link


Copy Markdown

Author
@jimschubert could you please check my error environment report please? thanks! :)
@fuj1g0n
fuj1g0n
commented
Sep 26, 2019

Copy link


Copy Markdown

Author
confirmed this PR will
  • environment 1 succeeds (only limited patterns checked)

    • maven 3.5.3
    • java 1.8.0_66 oracle / java 1.8.0_222 openjdk
    • with my local settings.xml / with no settings.xml
  • environment 2 succeeds
  • environment 3 still succeeds
  • environment 4 still succeeds
jmini
jmini
approved these changes
Sep 27, 2019
View reviewed changes
@jminijmini
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pom file:
 <groupId>org.openapitools</groupId>
<artifactId>openapi-generator-gradle-plugin-mvn-wrapper</artifactId>
<version>4.1.2-SNAPSHOT</version>
Is not something we release. It is only here to trigger gradle as part of the maven build.
It does not seems to hurt to give maven an additional way to fetch the dependencies requested for one of the plugins used in this pom.
@wing328
wing328
merged commit 2664c62
into
OpenAPITools:masterSep 27, 2019
jimschubert added a commit
that referenced
this pull request
Sep 30, 2019
@jimschubert
Merge branch 'master' into feature-sets-meta
7700e6e
* master: (207 commits)
Add missing enum processing in C++ codegen, already present for Qt5 (#3986)
[C++] [Pistache] Removed deprecated warnings (#3985)
[C++][Pistache] Simplified model template (#3417)
add go oas3 petstore to ensure up-to-date (#3979)
replace gitter with slack in the doc (#3977)
Fix wrong variable name in LessThan and LessThanOrEqual asserts (#3971)
#3957 - Removed hardcoded baseUrl (#3964)
Regenerate go openapi3 samples (#3975)
[rust] Make it easier to test rust client generator (#3543)
Fix issue3635 (#3948)
add gradle repository (#3867)
[java] allow to use setArtifactVersion() programmatically (#3907)
Add a link to DevRelCon SF 2019 (#3961)
Add a link to a medium blog post (#3960)
update maven-compiler-plugin version (#3956)
fix generateAliasAsModels in default generator (#3951)
Implement BigDecimal to Decimal in swift4 for currency data as type=string format=number (#3910)
Add F# Functions server generator (#3933)
[python-experimental] generate model if type != object if enums/validations exist (#2757)
[scala] add [date-time] field to codegen unit test (#3939)
...
Jesse0Michael pushed a commit
to Jesse0Michael/openapi-generator
that referenced
this pull request
Oct 3, 2019
Dec12 | FujigonJesse Michael
add gradle repository (OpenAPITools#3867)
a6a6984
jimschubert added a commit
that referenced
this pull request
Oct 4, 2019
@jimschubert
Merge branch 'master' into batch-generation
92d7b9f
* master: (110 commits)
[golang] Regenerate all go samples (#3988)
Better tests for string (number) (#3953)
Add missing enum processing in C++ codegen, already present for Qt5 (#3986)
[C++] [Pistache] Removed deprecated warnings (#3985)
[C++][Pistache] Simplified model template (#3417)
add go oas3 petstore to ensure up-to-date (#3979)
replace gitter with slack in the doc (#3977)
Fix wrong variable name in LessThan and LessThanOrEqual asserts (#3971)
#3957 - Removed hardcoded baseUrl (#3964)
Regenerate go openapi3 samples (#3975)
[rust] Make it easier to test rust client generator (#3543)
Fix issue3635 (#3948)
add gradle repository (#3867)
[java] allow to use setArtifactVersion() programmatically (#3907)
Add a link to DevRelCon SF 2019 (#3961)
Add a link to a medium blog post (#3960)
update maven-compiler-plugin version (#3956)
fix generateAliasAsModels in default generator (#3951)
Implement BigDecimal to Decimal in swift4 for currency data as type=string format=number (#3910)
Add F# Functions server generator (#3933)
...
@wing328
wing328
commented
Oct 4, 2019

Copy link


Copy Markdown

Member
@fujigon thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jminijminijmini approved these changes
@jimschubertjimschubertAwaiting requested review from jimschubert

Assignees


No one assigned


Labels

Enhancement: GeneralOpenAPI Generator Gradle Plugin

Projects


None yet


Milestone

4.1.3

Development

Successfully merging this pull request may close these issues.

4 participants

@fuj1g0n@jimschubert@wing328@jmini