[scala][akka] #3957 - Removed hardcoded baseUrl

[aneksamun]

PR checklist

• Read the contribution guidelines.
• Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
• Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

I found a bug in scala-akka-client module. The baseUrl is been ignored In the api.mustache file, as result I always getting localhost called instead actual URL. Please check example below:

object DefaultApi {
def apply(baseUrl: String = "http://localhost/some-api") = new DefaultApi(baseUrl)
}
class DefaultApi(baseUrl: String) {
def getSomeDetails(id: String): ApiRequest[SomeDetails] =
// Please note basePath is hardcoded - it is always localhost!
ApiRequest[SomeDetails](ApiMethods.GET, "http://localhost/some-api", "/v1/fetch/{id}", "application/json")
.withPathParam("id", id)
.withSuccessResponse[SomeDetails](200)
.withErrorResponse[ErrorResponse](400)
.withErrorResponse[ErrorResponse](404)
.withErrorResponse[ErrorResponse](500)
}

@clasnake (2017/07), @jimschubert (2017/09) ❤️, @shijinkui (2018/01), @ramzimaalej (2018/03)

[wing328]

Thanks for the fix, which looks good to me. I'll merge it tomorrow if no one has further feedback.

[ramzimaalej]

LGTM

[wing328]

@aneksamun thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456

[aneksamun]

PR checklist

• Read the contribution guidelines.
• Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
• Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

I found a bug in scala-akka-client module. The baseUrl is been ignored In the api.mustache file, as result I always getting localhost called instead actual URL. Please check example below:

object DefaultApi {
def apply(baseUrl: String = "http://localhost/some-api") = new DefaultApi(baseUrl)
}
class DefaultApi(baseUrl: String) {
def getSomeDetails(id: String): ApiRequest[SomeDetails] =
// Please note basePath is hardcoded - it is always localhost!
ApiRequest[SomeDetails](ApiMethods.GET, "http://localhost/some-api", "/v1/fetch/{id}", "application/json")
.withPathParam("id", id)
.withSuccessResponse[SomeDetails](200)
.withErrorResponse[ErrorResponse](400)
.withErrorResponse[ErrorResponse](404)
.withErrorResponse[ErrorResponse](500)
}

@clasnake (2017/07), @jimschubert (2017/09) ❤️, @shijinkui (2018/01), @ramzimaalej (2018/03)

[wing328]

Thanks for the fix, which looks good to me. I'll merge it tomorrow if no one has further feedback.

[ramzimaalej]

LGTM

[wing328]

@aneksamun thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456

[aneksamun]

PR checklist

• Read the contribution guidelines.
• Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
• Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

I found a bug in scala-akka-client module. The baseUrl is been ignored In the api.mustache file, as result I always getting localhost called instead actual URL. Please check example below:

object DefaultApi {
def apply(baseUrl: String = "http://localhost/some-api") = new DefaultApi(baseUrl)
}
class DefaultApi(baseUrl: String) {
def getSomeDetails(id: String): ApiRequest[SomeDetails] =
// Please note basePath is hardcoded - it is always localhost!
ApiRequest[SomeDetails](ApiMethods.GET, "http://localhost/some-api", "/v1/fetch/{id}", "application/json")
.withPathParam("id", id)
.withSuccessResponse[SomeDetails](200)
.withErrorResponse[ErrorResponse](400)
.withErrorResponse[ErrorResponse](404)
.withErrorResponse[ErrorResponse](500)
}

@clasnake (2017/07), @jimschubert (2017/09) ❤️, @shijinkui (2018/01), @ramzimaalej (2018/03)

[wing328]

Thanks for the fix, which looks good to me. I'll merge it tomorrow if no one has further feedback.

[ramzimaalej]

LGTM

[wing328]

@aneksamun thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456

[aneksamun]

PR checklist

• Read the contribution guidelines.
• Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
• Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

I found a bug in scala-akka-client module. The baseUrl is been ignored In the api.mustache file, as result I always getting localhost called instead actual URL. Please check example below:

object DefaultApi {
def apply(baseUrl: String = "http://localhost/some-api") = new DefaultApi(baseUrl)
}
class DefaultApi(baseUrl: String) {
def getSomeDetails(id: String): ApiRequest[SomeDetails] =
// Please note basePath is hardcoded - it is always localhost!
ApiRequest[SomeDetails](ApiMethods.GET, "http://localhost/some-api", "/v1/fetch/{id}", "application/json")
.withPathParam("id", id)
.withSuccessResponse[SomeDetails](200)
.withErrorResponse[ErrorResponse](400)
.withErrorResponse[ErrorResponse](404)
.withErrorResponse[ErrorResponse](500)
}

@clasnake (2017/07), @jimschubert (2017/09) ❤️, @shijinkui (2018/01), @ramzimaalej (2018/03)

[wing328]

Thanks for the fix, which looks good to me. I'll merge it tomorrow if no one has further feedback.

[ramzimaalej]

LGTM

[wing328]

@aneksamun thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456

[aneksamun]

PR checklist

• Read the contribution guidelines.
• Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
• Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

I found a bug in scala-akka-client module. The baseUrl is been ignored In the api.mustache file, as result I always getting localhost called instead actual URL. Please check example below:

object DefaultApi {
def apply(baseUrl: String = "http://localhost/some-api") = new DefaultApi(baseUrl)
}
class DefaultApi(baseUrl: String) {
def getSomeDetails(id: String): ApiRequest[SomeDetails] =
// Please note basePath is hardcoded - it is always localhost!
ApiRequest[SomeDetails](ApiMethods.GET, "http://localhost/some-api", "/v1/fetch/{id}", "application/json")
.withPathParam("id", id)
.withSuccessResponse[SomeDetails](200)
.withErrorResponse[ErrorResponse](400)
.withErrorResponse[ErrorResponse](404)
.withErrorResponse[ErrorResponse](500)
}

@clasnake (2017/07), @jimschubert (2017/09) ❤️, @shijinkui (2018/01), @ramzimaalej (2018/03)

[wing328]

Thanks for the fix, which looks good to me. I'll merge it tomorrow if no one has further feedback.

[ramzimaalej]

LGTM

[wing328]

@aneksamun thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456

[aneksamun]

PR checklist

• Read the contribution guidelines.
• Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
• Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

I found a bug in scala-akka-client module. The baseUrl is been ignored In the api.mustache file, as result I always getting localhost called instead actual URL. Please check example below:

object DefaultApi {
def apply(baseUrl: String = "http://localhost/some-api") = new DefaultApi(baseUrl)
}
class DefaultApi(baseUrl: String) {
def getSomeDetails(id: String): ApiRequest[SomeDetails] =
// Please note basePath is hardcoded - it is always localhost!
ApiRequest[SomeDetails](ApiMethods.GET, "http://localhost/some-api", "/v1/fetch/{id}", "application/json")
.withPathParam("id", id)
.withSuccessResponse[SomeDetails](200)
.withErrorResponse[ErrorResponse](400)
.withErrorResponse[ErrorResponse](404)
.withErrorResponse[ErrorResponse](500)
}

@clasnake (2017/07), @jimschubert (2017/09) ❤️, @shijinkui (2018/01), @ramzimaalej (2018/03)

[wing328]

Thanks for the fix, which looks good to me. I'll merge it tomorrow if no one has further feedback.

[ramzimaalej]

LGTM

[wing328]

@aneksamun thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456

[aneksamun]

PR checklist

• Read the contribution guidelines.
• Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
• Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

I found a bug in scala-akka-client module. The baseUrl is been ignored In the api.mustache file, as result I always getting localhost called instead actual URL. Please check example below:

object DefaultApi {
def apply(baseUrl: String = "http://localhost/some-api") = new DefaultApi(baseUrl)
}
class DefaultApi(baseUrl: String) {
def getSomeDetails(id: String): ApiRequest[SomeDetails] =
// Please note basePath is hardcoded - it is always localhost!
ApiRequest[SomeDetails](ApiMethods.GET, "http://localhost/some-api", "/v1/fetch/{id}", "application/json")
.withPathParam("id", id)
.withSuccessResponse[SomeDetails](200)
.withErrorResponse[ErrorResponse](400)
.withErrorResponse[ErrorResponse](404)
.withErrorResponse[ErrorResponse](500)
}

@clasnake (2017/07), @jimschubert (2017/09) ❤️, @shijinkui (2018/01), @ramzimaalej (2018/03)

[wing328]

Thanks for the fix, which looks good to me. I'll merge it tomorrow if no one has further feedback.

[ramzimaalej]

LGTM

[wing328]

@aneksamun thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456

[aneksamun]

PR checklist

• Read the contribution guidelines.
• Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
• Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

I found a bug in scala-akka-client module. The baseUrl is been ignored In the api.mustache file, as result I always getting localhost called instead actual URL. Please check example below:

object DefaultApi {
def apply(baseUrl: String = "http://localhost/some-api") = new DefaultApi(baseUrl)
}
class DefaultApi(baseUrl: String) {
def getSomeDetails(id: String): ApiRequest[SomeDetails] =
// Please note basePath is hardcoded - it is always localhost!
ApiRequest[SomeDetails](ApiMethods.GET, "http://localhost/some-api", "/v1/fetch/{id}", "application/json")
.withPathParam("id", id)
.withSuccessResponse[SomeDetails](200)
.withErrorResponse[ErrorResponse](400)
.withErrorResponse[ErrorResponse](404)
.withErrorResponse[ErrorResponse](500)
}

@clasnake (2017/07), @jimschubert (2017/09) ❤️, @shijinkui (2018/01), @ramzimaalej (2018/03)

[wing328]

Thanks for the fix, which looks good to me. I'll merge it tomorrow if no one has further feedback.

[ramzimaalej]

LGTM

[wing328]

@aneksamun thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456