Skip to content

[C] Update build-and-test.bash for CI errors - #4312

Merged
wing328 merged 3 commits into
OpenAPITools:masterfrom
zhemant:master
Oct 30, 2019
Merged

[C] Update build-and-test.bash for CI errors#4312
wing328 merged 3 commits into
OpenAPITools:masterfrom
zhemant:master

Conversation

@zhemant

@zhemantzhemant commented Oct 29, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328

@zhemant
Update build-and-test.bash
54c794a
add check for non autogenerated test file
@zhemant
Update README.md.mustache
83f7765
Add instructions on how to test petstore sample manual tests.
@zhemant
remove petstore sample from readme
dcd1057
@auto-labeler

auto-labelerBot commented Oct 29, 2019

Copy link
Copy Markdown

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@zhemantzhemant mentioned this pull request Oct 29, 2019
Closed
1 task
@wing328

wing328 commented Oct 30, 2019

Copy link
Copy Markdown
Member

CircleCI failure not related to this PR.

@wing328
wing328 merged commit 6795434 into OpenAPITools:masterOct 30, 2019
@wing328wing328 added this to the 4.2.0 milestone Oct 30, 2019
michelealbano added a commit to michelealbano/openapi-generator that referenced this pull request Oct 30, 2019
@michelealbano
Merge branch 'CadditionalProperties' ofhttps://github.com/michelealb…
ae258e3
…ano/openapi-generator into CadditionalProperties
Merged with new generated test files, after improvements of Pull Request OpenAPITools#4312.
Removed anything not related to C additional properties.
@wing328

wing328 commented Oct 31, 2019•
edited
Loading

Copy link
Copy Markdown
Member

@zhemant thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Client: CEnhancement: CI/Test

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@zhemant@wing328
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[C] Update build-and-test.bash for CI errors by zhemant · Pull Request #4312 · OpenAPITools/openapi-generator · GitHub
Skip to content
[C] Update build-and-test.bash for CI errors - #4312
Merged
wing328 merged 3 commits into
OpenAPITools:masterfrom 
zhemant:master
Oct 30, 2019
Merged
[C] Update build-and-test.bash for CI errors#4312
wing328 merged 3 commits into
OpenAPITools:masterfrom 
zhemant:master
Conversation
@zhemant
@zhemantzhemant
commented
Oct 29, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@wing328
@zhemant
Update build-and-test.bash
54c794a
add check for non autogenerated test file
@zhemant
Update README.md.mustache
83f7765
Add instructions on how to test petstore sample manual tests.
@zhemant
remove petstore sample from readme
dcd1057
@auto-labeler
auto-labelerBot
commented
Oct 29, 2019

Copy link


Copy Markdown

👍 Thanks for opening this issue!

🏷 I have applied any labels matching special text in your issue.
The team will review the labels and make any necessary changes.
@zhemantzhemant
mentioned this pull request
Oct 29, 2019
 Closed

1 task
@wing328
wing328
commented
Oct 30, 2019

Copy link


Copy Markdown

Member
CircleCI failure not related to this PR.
@wing328
wing328
merged commit 6795434
into
OpenAPITools:masterOct 30, 2019
@wing328wing328
added this to the 4.2.0 milestone
Oct 30, 2019
michelealbano added a commit
to michelealbano/openapi-generator
that referenced
this pull request
Oct 30, 2019
@michelealbano
Merge branch 'CadditionalProperties' ofhttps://github.com/michelealb…
ae258e3
…ano/openapi-generator into CadditionalProperties
Merged with new generated test files, after improvements of Pull Request OpenAPITools#4312.
Removed anything not related to C additional properties.
@wing328
wing328
commented
Oct 31, 2019•

edited

Loading

Copy link


Copy Markdown

Member
@zhemant thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: CEnhancement: CI/Test

Projects


None yet


Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@zhemant@wing328

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[C] Update build-and-test.bash for CI errors by zhemant · Pull Request #4312 · OpenAPITools/openapi-generator · GitHub
Skip to content
[C] Update build-and-test.bash for CI errors - #4312
Merged
wing328 merged 3 commits into
OpenAPITools:masterfrom 
zhemant:master
Oct 30, 2019
Merged
[C] Update build-and-test.bash for CI errors#4312
wing328 merged 3 commits into
OpenAPITools:masterfrom 
zhemant:master
Conversation
@zhemant
@zhemantzhemant
commented
Oct 29, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@wing328
@zhemant
Update build-and-test.bash
54c794a
add check for non autogenerated test file
@zhemant
Update README.md.mustache
83f7765
Add instructions on how to test petstore sample manual tests.
@zhemant
remove petstore sample from readme
dcd1057
@auto-labeler
auto-labelerBot
commented
Oct 29, 2019

Copy link


Copy Markdown

👍 Thanks for opening this issue!

🏷 I have applied any labels matching special text in your issue.
The team will review the labels and make any necessary changes.
@zhemantzhemant
mentioned this pull request
Oct 29, 2019
 Closed

1 task
@wing328
wing328
commented
Oct 30, 2019

Copy link


Copy Markdown

Member
CircleCI failure not related to this PR.
@wing328
wing328
merged commit 6795434
into
OpenAPITools:masterOct 30, 2019
@wing328wing328
added this to the 4.2.0 milestone
Oct 30, 2019
michelealbano added a commit
to michelealbano/openapi-generator
that referenced
this pull request
Oct 30, 2019
@michelealbano
Merge branch 'CadditionalProperties' ofhttps://github.com/michelealb…
ae258e3
…ano/openapi-generator into CadditionalProperties
Merged with new generated test files, after improvements of Pull Request OpenAPITools#4312.
Removed anything not related to C additional properties.
@wing328
wing328
commented
Oct 31, 2019•

edited

Loading

Copy link


Copy Markdown

Member
@zhemant thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: CEnhancement: CI/Test

Projects


None yet


Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@zhemant@wing328

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[C] Update build-and-test.bash for CI errors by zhemant · Pull Request #4312 · OpenAPITools/openapi-generator · GitHub
Skip to content
[C] Update build-and-test.bash for CI errors - #4312
Merged
wing328 merged 3 commits into
OpenAPITools:masterfrom 
zhemant:master
Oct 30, 2019
Merged
[C] Update build-and-test.bash for CI errors#4312
wing328 merged 3 commits into
OpenAPITools:masterfrom 
zhemant:master
Conversation
@zhemant
@zhemantzhemant
commented
Oct 29, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@wing328
@zhemant
Update build-and-test.bash
54c794a
add check for non autogenerated test file
@zhemant
Update README.md.mustache
83f7765
Add instructions on how to test petstore sample manual tests.
@zhemant
remove petstore sample from readme
dcd1057
@auto-labeler
auto-labelerBot
commented
Oct 29, 2019

Copy link


Copy Markdown

👍 Thanks for opening this issue!

🏷 I have applied any labels matching special text in your issue.
The team will review the labels and make any necessary changes.
@zhemantzhemant
mentioned this pull request
Oct 29, 2019
 Closed

1 task
@wing328
wing328
commented
Oct 30, 2019

Copy link


Copy Markdown

Member
CircleCI failure not related to this PR.
@wing328
wing328
merged commit 6795434
into
OpenAPITools:masterOct 30, 2019
@wing328wing328
added this to the 4.2.0 milestone
Oct 30, 2019
michelealbano added a commit
to michelealbano/openapi-generator
that referenced
this pull request
Oct 30, 2019
@michelealbano
Merge branch 'CadditionalProperties' ofhttps://github.com/michelealb…
ae258e3
…ano/openapi-generator into CadditionalProperties
Merged with new generated test files, after improvements of Pull Request OpenAPITools#4312.
Removed anything not related to C additional properties.
@wing328
wing328
commented
Oct 31, 2019•

edited

Loading

Copy link


Copy Markdown

Member
@zhemant thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: CEnhancement: CI/Test

Projects


None yet


Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@zhemant@wing328

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[C] Update build-and-test.bash for CI errors by zhemant · Pull Request #4312 · OpenAPITools/openapi-generator · GitHub
Skip to content
[C] Update build-and-test.bash for CI errors - #4312
Merged
wing328 merged 3 commits into
OpenAPITools:masterfrom 
zhemant:master
Oct 30, 2019
Merged
[C] Update build-and-test.bash for CI errors#4312
wing328 merged 3 commits into
OpenAPITools:masterfrom 
zhemant:master
Conversation
@zhemant
@zhemantzhemant
commented
Oct 29, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@wing328
@zhemant
Update build-and-test.bash
54c794a
add check for non autogenerated test file
@zhemant
Update README.md.mustache
83f7765
Add instructions on how to test petstore sample manual tests.
@zhemant
remove petstore sample from readme
dcd1057
@auto-labeler
auto-labelerBot
commented
Oct 29, 2019

Copy link


Copy Markdown

👍 Thanks for opening this issue!

🏷 I have applied any labels matching special text in your issue.
The team will review the labels and make any necessary changes.
@zhemantzhemant
mentioned this pull request
Oct 29, 2019
 Closed

1 task
@wing328
wing328
commented
Oct 30, 2019

Copy link


Copy Markdown

Member
CircleCI failure not related to this PR.
@wing328
wing328
merged commit 6795434
into
OpenAPITools:masterOct 30, 2019
@wing328wing328
added this to the 4.2.0 milestone
Oct 30, 2019
michelealbano added a commit
to michelealbano/openapi-generator
that referenced
this pull request
Oct 30, 2019
@michelealbano
Merge branch 'CadditionalProperties' ofhttps://github.com/michelealb…
ae258e3
…ano/openapi-generator into CadditionalProperties
Merged with new generated test files, after improvements of Pull Request OpenAPITools#4312.
Removed anything not related to C additional properties.
@wing328
wing328
commented
Oct 31, 2019•

edited

Loading

Copy link


Copy Markdown

Member
@zhemant thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: CEnhancement: CI/Test

Projects


None yet


Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@zhemant@wing328

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[C] Update build-and-test.bash for CI errors by zhemant · Pull Request #4312 · OpenAPITools/openapi-generator · GitHub
Skip to content
[C] Update build-and-test.bash for CI errors - #4312
Merged
wing328 merged 3 commits into
OpenAPITools:masterfrom 
zhemant:master
Oct 30, 2019
Merged
[C] Update build-and-test.bash for CI errors#4312
wing328 merged 3 commits into
OpenAPITools:masterfrom 
zhemant:master
Conversation
@zhemant
@zhemantzhemant
commented
Oct 29, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@wing328
@zhemant
Update build-and-test.bash
54c794a
add check for non autogenerated test file
@zhemant
Update README.md.mustache
83f7765
Add instructions on how to test petstore sample manual tests.
@zhemant
remove petstore sample from readme
dcd1057
@auto-labeler
auto-labelerBot
commented
Oct 29, 2019

Copy link


Copy Markdown

👍 Thanks for opening this issue!

🏷 I have applied any labels matching special text in your issue.
The team will review the labels and make any necessary changes.
@zhemantzhemant
mentioned this pull request
Oct 29, 2019
 Closed

1 task
@wing328
wing328
commented
Oct 30, 2019

Copy link


Copy Markdown

Member
CircleCI failure not related to this PR.
@wing328
wing328
merged commit 6795434
into
OpenAPITools:masterOct 30, 2019
@wing328wing328
added this to the 4.2.0 milestone
Oct 30, 2019
michelealbano added a commit
to michelealbano/openapi-generator
that referenced
this pull request
Oct 30, 2019
@michelealbano
Merge branch 'CadditionalProperties' ofhttps://github.com/michelealb…
ae258e3
…ano/openapi-generator into CadditionalProperties
Merged with new generated test files, after improvements of Pull Request OpenAPITools#4312.
Removed anything not related to C additional properties.
@wing328
wing328
commented
Oct 31, 2019•

edited

Loading

Copy link


Copy Markdown

Member
@zhemant thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: CEnhancement: CI/Test

Projects


None yet


Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@zhemant@wing328

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[C] Update build-and-test.bash for CI errors by zhemant · Pull Request #4312 · OpenAPITools/openapi-generator · GitHub
Skip to content
[C] Update build-and-test.bash for CI errors - #4312
Merged
wing328 merged 3 commits into
OpenAPITools:masterfrom 
zhemant:master
Oct 30, 2019
Merged
[C] Update build-and-test.bash for CI errors#4312
wing328 merged 3 commits into
OpenAPITools:masterfrom 
zhemant:master
Conversation
@zhemant
@zhemantzhemant
commented
Oct 29, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@wing328
@zhemant
Update build-and-test.bash
54c794a
add check for non autogenerated test file
@zhemant
Update README.md.mustache
83f7765
Add instructions on how to test petstore sample manual tests.
@zhemant
remove petstore sample from readme
dcd1057
@auto-labeler
auto-labelerBot
commented
Oct 29, 2019

Copy link


Copy Markdown

👍 Thanks for opening this issue!

🏷 I have applied any labels matching special text in your issue.
The team will review the labels and make any necessary changes.
@zhemantzhemant
mentioned this pull request
Oct 29, 2019
 Closed

1 task
@wing328
wing328
commented
Oct 30, 2019

Copy link


Copy Markdown

Member
CircleCI failure not related to this PR.
@wing328
wing328
merged commit 6795434
into
OpenAPITools:masterOct 30, 2019
@wing328wing328
added this to the 4.2.0 milestone
Oct 30, 2019
michelealbano added a commit
to michelealbano/openapi-generator
that referenced
this pull request
Oct 30, 2019
@michelealbano
Merge branch 'CadditionalProperties' ofhttps://github.com/michelealb…
ae258e3
…ano/openapi-generator into CadditionalProperties
Merged with new generated test files, after improvements of Pull Request OpenAPITools#4312.
Removed anything not related to C additional properties.
@wing328
wing328
commented
Oct 31, 2019•

edited

Loading

Copy link


Copy Markdown

Member
@zhemant thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: CEnhancement: CI/Test

Projects


None yet


Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@zhemant@wing328