Skip to content

C additional properties fix #4289 - #4292

Closed
michelealbano wants to merge 22 commits into
OpenAPITools:masterfrom
michelealbano:CadditionalProperties
Closed

C additional properties fix #4289#4292
michelealbano wants to merge 22 commits into
OpenAPITools:masterfrom
michelealbano:CadditionalProperties

Conversation

@michelealbano

@michelealbanomichelealbano commented Oct 28, 2019

Copy link
Copy Markdown
Contributor

Solved #4289.

PR checklist

  • [ X ] Read the contribution guidelines.
  • [ X ] If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • [ X ] Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • [ X ] File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328wing328 changed the title Cadditional properties fix #4289C additional properties fix #4289Oct 29, 2019
@wing328

wing328 commented Oct 29, 2019

Copy link
Copy Markdown
Member

cc @zhemant

@wing328

wing328 commented Oct 29, 2019

Copy link
Copy Markdown
Member

Travis CI reports the following error:

[ 78%] Building C object CMakeFiles/openapi_petstore.dir/api/PetAPI.c.o
[ 85%] Building C object CMakeFiles/openapi_petstore.dir/api/StoreAPI.c.o
[ 92%] Building C object CMakeFiles/openapi_petstore.dir/api/UserAPI.c.o
[100%] Linking C shared library libopenapi_petstore.so
[100%] Built target openapi_petstore
./build-and-test.bash: line 19: ./unit-manual-PetAPI: No such file or directory
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (pet-test) on project CPetstoreClientTests: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1]
[ERROR]

michelealbanoand others added 5 commits October 29, 2019 05:59
@michelealbano
Merge remote-tracking branch 'upstream/master' into CadditionalProper…
e9da137
…ties
@wing328
Add arduino.cc to the user list (OpenAPITools#4307)
ae798d9
* Add arduino.cc to the user list
* Add Arduino logo
* add logo
Arun@wing328
[Python] [Bug] Correct typo in the word datetime (OpenAPITools#4304)
c8465c4
@andrewemery@wing328
Kotlin query collection format (OpenAPITools#4248)
a2b37d6
* Fixes incorrect query header collection constants
The OpenApi codegen converts OpenApi v2 documents into an OpenApi v3
representation. The query parameter collection formats are squeezed
into different values from the raw OpenApi 2 collection format values.
For example: csv -> space
See: DefaultCodegen#getCollectionFormat
* Updates kotlin samples
@michelealbano
Improved support for enums for C client generator
3f6c5b8
@michelealbano

michelealbano commented Oct 29, 2019

Copy link
Copy Markdown
ContributorAuthor

Travis CI reports the following error:

[ 78%] Building C object CMakeFiles/openapi_petstore.dir/api/PetAPI.c.o
[ 85%] Building C object CMakeFiles/openapi_petstore.dir/api/StoreAPI.c.o
[ 92%] Building C object CMakeFiles/openapi_petstore.dir/api/UserAPI.c.o
[100%] Linking C shared library libopenapi_petstore.so
[100%] Built target openapi_petstore
./build-and-test.bash: line 19: ./unit-manual-PetAPI: No such file or directory
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (pet-test) on project CPetstoreClientTests: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1]
[ERROR]

How can I solve this? What is unit-manual-PetAPI?

@wing328

wing328 commented Oct 29, 2019

Copy link
Copy Markdown
Member

I think those are unit tests. I noticed that you've commented out part of the CMakefile: https://github.com/OpenAPITools/openapi-generator/pull/4292/files#diff-bc97688208c58aee3233d8e276aef6ecR67

Not sure if it's related.

@michelealbano

michelealbano commented Oct 29, 2019

Copy link
Copy Markdown
ContributorAuthor

The changed to the test files were done automatically, by means of :
./bin/c-petstore.sh

@michelealbano

michelealbano commented Oct 29, 2019

Copy link
Copy Markdown
ContributorAuthor

I re-cloned a fresh master, mvn install is fine, when I do ./bin/c-petstore.sh the amples/client/petstore/c/CMakeLists.txt gets like win328 says, thus samples/client/petstore/c/build-and-test.bash will try to execute files that are not compiled.

I will open a bug report.

@zhemant

zhemant commented Oct 29, 2019

Copy link
Copy Markdown
Contributor

I know how to fix this, I fixed it in the one merge request, but couldnt update some other stuff so it was closed. I will create another merge request with a fix

@zhemant

zhemant commented Oct 29, 2019

Copy link
Copy Markdown
Contributor

#4312 should fix the issue

@michelealbano

michelealbano commented Oct 30, 2019

Copy link
Copy Markdown
ContributorAuthor

Thank you zhemant!

zhemantand others added 11 commits October 30, 2019 15:31
@zhemant@wing328
[C] Update build-and-test.bash for CI errors (OpenAPITools#4312)
6795434
* Update build-and-test.bash
add check for non autogenerated test file
* Update README.md.mustache
Add instructions on how to test petstore sample manual tests.
* remove petstore sample from readme
@josh-burton@wing328
[dart-dio] Correctly handles import of Uint8List (OpenAPITools#4313)
9c46973
* [dart-dio] Correctly handles import of Uint8List
- updates dio and built_value dependencies
* [dart-dio] Updates sample
@alavkx@macjohnny
[TS] Fixes typescript-axios "File custom.d.ts not found" when buildin…
b1984f3
…g consumer TS project (OpenAPITools#4230)
* remove unused file
* build(package.json): update node and ts
* remove ref to ambient declaration
* remove other ref to ambient declaration
* remove all references to custom.d.ts, rebuild
* regenerate typescript axios samples
Arun@wing328
[Python] Remove redundant else statement (OpenAPITools#4311)
eaca7b8
* [Python] Remove redundant else condition
* Add indentation
* Reduce extra indent
* Avoid longer than 79 chars
* Remove trailing space after response_body
* [Python] Fix pep8 violation in imports
* Revert "[Python] Fix pep8 violation in imports"
This reverts commit bc69aaa.
@saigiridhar21@wing328
[r][documentation]: Adding model summary to model documentation files. (
3082eda
OpenAPITools#4310)
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
@saigiridhar21@wing328
feat(documentation): Adding model documentation (OpenAPITools#4309)
73db23a
@saigiridhar21@wing328
feat(documentation): Adding model documentation (OpenAPITools#4308)
284c9dc
@saigiridhar21@wing328
[python][fix] Adding model summary to model documentation files (Open…
ec3569e
…APITools#4306)
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
@saigiridhar21@wing328
[r][license]: Fixing license and contact information (OpenAPITools#4317)
2188e0f
* fix(license): Fixing the license information
* fix(license): Fixing the license information
@michelealbano
changed C client generator to support additionalProperties
9bde492
@michelealbano
changed test files to support additionalProperties for C generator
e339baa
@michelealbano
Improved support for enums for C client generator
0717f33
@michelealbano
Revert "Improved support for enums for C client generator"
62bed01
This reverts commit 3f6c5b8.
Better to consider one problem at a time.
@michelealbano
Merge branch 'CadditionalProperties' ofhttps://github.com/michelealb…
ae258e3
…ano/openapi-generator into CadditionalProperties
Merged with new generated test files, after improvements of Pull Request OpenAPITools#4312.
Removed anything not related to C additional properties.
@zhemant

zhemant commented Oct 30, 2019

Copy link
Copy Markdown
Contributor

@michelealbano which version of openapi spec are you using with the generator v2 or v3?

@michelealbano

michelealbano commented Oct 30, 2019

Copy link
Copy Markdown
ContributorAuthor

@zhemant I am using v3

@zhemant

zhemant commented Oct 30, 2019

Copy link
Copy Markdown
Contributor

@michelealbano are you on gitter? May be we could add more updated parameters support to C if you are interested in helping out.

@michelealbano

michelealbano commented Oct 30, 2019

Copy link
Copy Markdown
ContributorAuthor

I am very interested. I have opened an issue regarding enums, and I will submit a PR tomorrow. I should also add _with_HTTP_headers methods in the future

@zhemant

zhemant commented Oct 30, 2019

Copy link
Copy Markdown
Contributor

I will also recommend modifying the values in the enum to something like {{projectName}}{{classVarName}}{{{value}}} which will make them unique in the complete project, because when you have two enums with the same values, C creates problem in compiling. I have faced these issues.

@michelealbano

michelealbano commented Oct 31, 2019

Copy link
Copy Markdown
ContributorAuthor

There is also the matter of the enum itself, since it generates _ToString and _FromString functions. Let us talk on gitter.

@wing328

wing328 commented Nov 1, 2019

Copy link
Copy Markdown
Member

There is also the matter of the enum itself, since it generates _ToString and _FromString functions. Let us talk on gitter.

Please use Slack instead as we've made the switch already.

@michelealbano

michelealbano commented Nov 1, 2019

Copy link
Copy Markdown
ContributorAuthor

I did another pull request with a cleaner set of commits

@michelealbano
michelealbano deleted the CadditionalProperties branch November 1, 2019 17:21
@michelealbano
michelealbano restored the CadditionalProperties branch November 1, 2019 17:21
@michelealbano
michelealbano deleted the CadditionalProperties branch April 5, 2020 23:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Client: CIssue: Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@michelealbano@wing328@zhemant@andrewemery@josh-burton@alavkx@saigiridhar21
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
C additional properties fix #4289 by michelealbano · Pull Request #4292 · OpenAPITools/openapi-generator · GitHub
Skip to content
C additional properties fix #4289 - #4292
Closed
michelealbano wants to merge 22 commits into
OpenAPITools:masterfrom 
michelealbano:CadditionalProperties
Closed
C additional properties fix #4289#4292
michelealbano wants to merge 22 commits into
OpenAPITools:masterfrom 
michelealbano:CadditionalProperties
Conversation
@michelealbano
@michelealbanomichelealbano
commented
Oct 28, 2019

Copy link


Copy Markdown

Contributor
Solved #4289.
PR checklist
  • [ X ] Read the contribution guidelines.
  • [ X ] If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • [ X ] Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • [ X ] File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@wing328wing328
changed the title
Cadditional properties fix #4289C additional properties fix #4289Oct 29, 2019
@wing328
wing328
commented
Oct 29, 2019

Copy link


Copy Markdown

Member
cc @zhemant
@wing328
wing328
commented
Oct 29, 2019

Copy link


Copy Markdown

Member
Travis CI reports the following error:
[ 78%] Building C object CMakeFiles/openapi_petstore.dir/api/PetAPI.c.o
[ 85%] Building C object CMakeFiles/openapi_petstore.dir/api/StoreAPI.c.o
[ 92%] Building C object CMakeFiles/openapi_petstore.dir/api/UserAPI.c.o
[100%] Linking C shared library libopenapi_petstore.so
[100%] Built target openapi_petstore
./build-and-test.bash: line 19: ./unit-manual-PetAPI: No such file or directory
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (pet-test) on project CPetstoreClientTests: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1]
[ERROR] 
michelealbanoand others
added 5 commits
October 29, 2019 05:59
@michelealbano
Merge remote-tracking branch 'upstream/master' into CadditionalProper…
e9da137
…ties
@wing328
Add arduino.cc to the user list (OpenAPITools#4307)
ae798d9
* Add arduino.cc to the user list
* Add Arduino logo
* add logo
Arun@wing328
[Python] [Bug] Correct typo in the word datetime (OpenAPITools#4304)
c8465c4
@andrewemery@wing328
Kotlin query collection format (OpenAPITools#4248)
a2b37d6
* Fixes incorrect query header collection constants
The OpenApi codegen converts OpenApi v2 documents into an OpenApi v3
representation. The query parameter collection formats are squeezed
into different values from the raw OpenApi 2 collection format values.
For example: csv -> space
See: DefaultCodegen#getCollectionFormat
* Updates kotlin samples
@michelealbano
Improved support for enums for C client generator
3f6c5b8
@michelealbano
michelealbano
commented
Oct 29, 2019

Copy link


Copy Markdown

ContributorAuthor
Travis CI reports the following error:
[ 78%] Building C object CMakeFiles/openapi_petstore.dir/api/PetAPI.c.o
[ 85%] Building C object CMakeFiles/openapi_petstore.dir/api/StoreAPI.c.o
[ 92%] Building C object CMakeFiles/openapi_petstore.dir/api/UserAPI.c.o
[100%] Linking C shared library libopenapi_petstore.so
[100%] Built target openapi_petstore
./build-and-test.bash: line 19: ./unit-manual-PetAPI: No such file or directory
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (pet-test) on project CPetstoreClientTests: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1]
[ERROR] 
How can I solve this? What is unit-manual-PetAPI?
@wing328
wing328
commented
Oct 29, 2019

Copy link


Copy Markdown

Member
I think those are unit tests. I noticed that you've commented out part of the CMakefile: https://github.com/OpenAPITools/openapi-generator/pull/4292/files#diff-bc97688208c58aee3233d8e276aef6ecR67
Not sure if it's related.
@michelealbano
michelealbano
commented
Oct 29, 2019

Copy link


Copy Markdown

ContributorAuthor
The changed to the test files were done automatically, by means of :

./bin/c-petstore.sh
@michelealbano
michelealbano
commented
Oct 29, 2019

Copy link


Copy Markdown

ContributorAuthor
I re-cloned a fresh master, mvn install is fine, when I do ./bin/c-petstore.sh the amples/client/petstore/c/CMakeLists.txt gets like win328 says, thus samples/client/petstore/c/build-and-test.bash will try to execute files that are not compiled.
I will open a bug report.
@zhemant
zhemant
commented
Oct 29, 2019

Copy link


Copy Markdown

Contributor
I know how to fix this, I fixed it in the one merge request, but couldnt update some other stuff so it was closed. I will create another merge request with a fix
@zhemant
zhemant
commented
Oct 29, 2019

Copy link


Copy Markdown

Contributor
#4312 should fix the issue
@michelealbano
michelealbano
commented
Oct 30, 2019

Copy link


Copy Markdown

ContributorAuthor
Thank you zhemant!
zhemantand others
added 11 commits
October 30, 2019 15:31
@zhemant@wing328
[C] Update build-and-test.bash for CI errors (OpenAPITools#4312)
6795434
* Update build-and-test.bash
add check for non autogenerated test file
* Update README.md.mustache
Add instructions on how to test petstore sample manual tests.
* remove petstore sample from readme
@josh-burton@wing328
[dart-dio] Correctly handles import of Uint8List (OpenAPITools#4313)
9c46973
* [dart-dio] Correctly handles import of Uint8List
- updates dio and built_value dependencies
* [dart-dio] Updates sample
@alavkx@macjohnny
[TS] Fixes typescript-axios "File custom.d.ts not found" when buildin…
b1984f3
…g consumer TS project (OpenAPITools#4230)
* remove unused file
* build(package.json): update node and ts
* remove ref to ambient declaration
* remove other ref to ambient declaration
* remove all references to custom.d.ts, rebuild
* regenerate typescript axios samples
Arun@wing328
[Python] Remove redundant else statement (OpenAPITools#4311)
eaca7b8
* [Python] Remove redundant else condition
* Add indentation
* Reduce extra indent
* Avoid longer than 79 chars
* Remove trailing space after response_body
* [Python] Fix pep8 violation in imports
* Revert "[Python] Fix pep8 violation in imports"
This reverts commit bc69aaa.
@saigiridhar21@wing328
[r][documentation]: Adding model summary to model documentation files. (
3082eda
OpenAPITools#4310)
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
@saigiridhar21@wing328
feat(documentation): Adding model documentation (OpenAPITools#4309)
73db23a
@saigiridhar21@wing328
feat(documentation): Adding model documentation (OpenAPITools#4308)
284c9dc
@saigiridhar21@wing328
[python][fix] Adding model summary to model documentation files (Open…
ec3569e
…APITools#4306)
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
@saigiridhar21@wing328
[r][license]: Fixing license and contact information (OpenAPITools#4317)
2188e0f
* fix(license): Fixing the license information
* fix(license): Fixing the license information
@michelealbano
changed C client generator to support additionalProperties
9bde492
@michelealbano
changed test files to support additionalProperties for C generator
e339baa
@michelealbano
Improved support for enums for C client generator
0717f33
@michelealbano
Revert "Improved support for enums for C client generator"
62bed01
This reverts commit 3f6c5b8.
Better to consider one problem at a time.
@michelealbano
Merge branch 'CadditionalProperties' ofhttps://github.com/michelealb…
ae258e3
…ano/openapi-generator into CadditionalProperties
Merged with new generated test files, after improvements of Pull Request OpenAPITools#4312.
Removed anything not related to C additional properties.
@zhemant
zhemant
commented
Oct 30, 2019

Copy link


Copy Markdown

Contributor
@michelealbano which version of openapi spec are you using with the generator v2 or v3?
@michelealbano
michelealbano
commented
Oct 30, 2019

Copy link


Copy Markdown

ContributorAuthor
@zhemant I am using v3
@zhemant
zhemant
commented
Oct 30, 2019

Copy link


Copy Markdown

Contributor
@michelealbano are you on gitter? May be we could add more updated parameters support to C if you are interested in helping out.
@michelealbano
michelealbano
commented
Oct 30, 2019

Copy link


Copy Markdown

ContributorAuthor
I am very interested. I have opened an issue regarding enums, and I will submit a PR tomorrow. I should also add _with_HTTP_headers methods in the future
@zhemant
zhemant
commented
Oct 30, 2019

Copy link


Copy Markdown

Contributor
I will also recommend modifying the values in the enum to something like {{projectName}}{{classVarName}}{{{value}}} which will make them unique in the complete project, because when you have two enums with the same values, C creates problem in compiling. I have faced these issues.
@michelealbano
michelealbano
commented
Oct 31, 2019

Copy link


Copy Markdown

ContributorAuthor
There is also the matter of the enum itself, since it generates _ToString and _FromString functions. Let us talk on gitter.
@wing328
wing328
commented
Nov 1, 2019

Copy link


Copy Markdown

Member
There is also the matter of the enum itself, since it generates _ToString and _FromString functions. Let us talk on gitter.
Please use Slack instead as we've made the switch already.
@michelealbano
michelealbano
commented
Nov 1, 2019

Copy link


Copy Markdown

ContributorAuthor
I did another pull request with a cleaner set of commits
@michelealbano
michelealbano
deleted the

CadditionalProperties

branch
November 1, 2019 17:21
@michelealbano
michelealbano
restored the

CadditionalProperties

branch
November 1, 2019 17:21
@michelealbano
michelealbano
deleted the

CadditionalProperties

branch
April 5, 2020 23:00
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: CIssue: Bug

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@michelealbano@wing328@zhemant@andrewemery@josh-burton@alavkx@saigiridhar21

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
C additional properties fix #4289 by michelealbano · Pull Request #4292 · OpenAPITools/openapi-generator · GitHub
Skip to content
C additional properties fix #4289 - #4292
Closed
michelealbano wants to merge 22 commits into
OpenAPITools:masterfrom 
michelealbano:CadditionalProperties
Closed
C additional properties fix #4289#4292
michelealbano wants to merge 22 commits into
OpenAPITools:masterfrom 
michelealbano:CadditionalProperties
Conversation
@michelealbano
@michelealbanomichelealbano
commented
Oct 28, 2019

Copy link


Copy Markdown

Contributor
Solved #4289.
PR checklist
  • [ X ] Read the contribution guidelines.
  • [ X ] If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • [ X ] Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • [ X ] File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@wing328wing328
changed the title
Cadditional properties fix #4289C additional properties fix #4289Oct 29, 2019
@wing328
wing328
commented
Oct 29, 2019

Copy link


Copy Markdown

Member
cc @zhemant
@wing328
wing328
commented
Oct 29, 2019

Copy link


Copy Markdown

Member
Travis CI reports the following error:
[ 78%] Building C object CMakeFiles/openapi_petstore.dir/api/PetAPI.c.o
[ 85%] Building C object CMakeFiles/openapi_petstore.dir/api/StoreAPI.c.o
[ 92%] Building C object CMakeFiles/openapi_petstore.dir/api/UserAPI.c.o
[100%] Linking C shared library libopenapi_petstore.so
[100%] Built target openapi_petstore
./build-and-test.bash: line 19: ./unit-manual-PetAPI: No such file or directory
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (pet-test) on project CPetstoreClientTests: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1]
[ERROR] 
michelealbanoand others
added 5 commits
October 29, 2019 05:59
@michelealbano
Merge remote-tracking branch 'upstream/master' into CadditionalProper…
e9da137
…ties
@wing328
Add arduino.cc to the user list (OpenAPITools#4307)
ae798d9
* Add arduino.cc to the user list
* Add Arduino logo
* add logo
Arun@wing328
[Python] [Bug] Correct typo in the word datetime (OpenAPITools#4304)
c8465c4
@andrewemery@wing328
Kotlin query collection format (OpenAPITools#4248)
a2b37d6
* Fixes incorrect query header collection constants
The OpenApi codegen converts OpenApi v2 documents into an OpenApi v3
representation. The query parameter collection formats are squeezed
into different values from the raw OpenApi 2 collection format values.
For example: csv -> space
See: DefaultCodegen#getCollectionFormat
* Updates kotlin samples
@michelealbano
Improved support for enums for C client generator
3f6c5b8
@michelealbano
michelealbano
commented
Oct 29, 2019

Copy link


Copy Markdown

ContributorAuthor
Travis CI reports the following error:
[ 78%] Building C object CMakeFiles/openapi_petstore.dir/api/PetAPI.c.o
[ 85%] Building C object CMakeFiles/openapi_petstore.dir/api/StoreAPI.c.o
[ 92%] Building C object CMakeFiles/openapi_petstore.dir/api/UserAPI.c.o
[100%] Linking C shared library libopenapi_petstore.so
[100%] Built target openapi_petstore
./build-and-test.bash: line 19: ./unit-manual-PetAPI: No such file or directory
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (pet-test) on project CPetstoreClientTests: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1]
[ERROR] 
How can I solve this? What is unit-manual-PetAPI?
@wing328
wing328
commented
Oct 29, 2019

Copy link


Copy Markdown

Member
I think those are unit tests. I noticed that you've commented out part of the CMakefile: https://github.com/OpenAPITools/openapi-generator/pull/4292/files#diff-bc97688208c58aee3233d8e276aef6ecR67
Not sure if it's related.
@michelealbano
michelealbano
commented
Oct 29, 2019

Copy link


Copy Markdown

ContributorAuthor
The changed to the test files were done automatically, by means of :

./bin/c-petstore.sh
@michelealbano
michelealbano
commented
Oct 29, 2019

Copy link


Copy Markdown

ContributorAuthor
I re-cloned a fresh master, mvn install is fine, when I do ./bin/c-petstore.sh the amples/client/petstore/c/CMakeLists.txt gets like win328 says, thus samples/client/petstore/c/build-and-test.bash will try to execute files that are not compiled.
I will open a bug report.
@zhemant
zhemant
commented
Oct 29, 2019

Copy link


Copy Markdown

Contributor
I know how to fix this, I fixed it in the one merge request, but couldnt update some other stuff so it was closed. I will create another merge request with a fix
@zhemant
zhemant
commented
Oct 29, 2019

Copy link


Copy Markdown

Contributor
#4312 should fix the issue
@michelealbano
michelealbano
commented
Oct 30, 2019

Copy link


Copy Markdown

ContributorAuthor
Thank you zhemant!
zhemantand others
added 11 commits
October 30, 2019 15:31
@zhemant@wing328
[C] Update build-and-test.bash for CI errors (OpenAPITools#4312)
6795434
* Update build-and-test.bash
add check for non autogenerated test file
* Update README.md.mustache
Add instructions on how to test petstore sample manual tests.
* remove petstore sample from readme
@josh-burton@wing328
[dart-dio] Correctly handles import of Uint8List (OpenAPITools#4313)
9c46973
* [dart-dio] Correctly handles import of Uint8List
- updates dio and built_value dependencies
* [dart-dio] Updates sample
@alavkx@macjohnny
[TS] Fixes typescript-axios "File custom.d.ts not found" when buildin…
b1984f3
…g consumer TS project (OpenAPITools#4230)
* remove unused file
* build(package.json): update node and ts
* remove ref to ambient declaration
* remove other ref to ambient declaration
* remove all references to custom.d.ts, rebuild
* regenerate typescript axios samples
Arun@wing328
[Python] Remove redundant else statement (OpenAPITools#4311)
eaca7b8
* [Python] Remove redundant else condition
* Add indentation
* Reduce extra indent
* Avoid longer than 79 chars
* Remove trailing space after response_body
* [Python] Fix pep8 violation in imports
* Revert "[Python] Fix pep8 violation in imports"
This reverts commit bc69aaa.
@saigiridhar21@wing328
[r][documentation]: Adding model summary to model documentation files. (
3082eda
OpenAPITools#4310)
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
@saigiridhar21@wing328
feat(documentation): Adding model documentation (OpenAPITools#4309)
73db23a
@saigiridhar21@wing328
feat(documentation): Adding model documentation (OpenAPITools#4308)
284c9dc
@saigiridhar21@wing328
[python][fix] Adding model summary to model documentation files (Open…
ec3569e
…APITools#4306)
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
@saigiridhar21@wing328
[r][license]: Fixing license and contact information (OpenAPITools#4317)
2188e0f
* fix(license): Fixing the license information
* fix(license): Fixing the license information
@michelealbano
changed C client generator to support additionalProperties
9bde492
@michelealbano
changed test files to support additionalProperties for C generator
e339baa
@michelealbano
Improved support for enums for C client generator
0717f33
@michelealbano
Revert "Improved support for enums for C client generator"
62bed01
This reverts commit 3f6c5b8.
Better to consider one problem at a time.
@michelealbano
Merge branch 'CadditionalProperties' ofhttps://github.com/michelealb…
ae258e3
…ano/openapi-generator into CadditionalProperties
Merged with new generated test files, after improvements of Pull Request OpenAPITools#4312.
Removed anything not related to C additional properties.
@zhemant
zhemant
commented
Oct 30, 2019

Copy link


Copy Markdown

Contributor
@michelealbano which version of openapi spec are you using with the generator v2 or v3?
@michelealbano
michelealbano
commented
Oct 30, 2019

Copy link


Copy Markdown

ContributorAuthor
@zhemant I am using v3
@zhemant
zhemant
commented
Oct 30, 2019

Copy link


Copy Markdown

Contributor
@michelealbano are you on gitter? May be we could add more updated parameters support to C if you are interested in helping out.
@michelealbano
michelealbano
commented
Oct 30, 2019

Copy link


Copy Markdown

ContributorAuthor
I am very interested. I have opened an issue regarding enums, and I will submit a PR tomorrow. I should also add _with_HTTP_headers methods in the future
@zhemant
zhemant
commented
Oct 30, 2019

Copy link


Copy Markdown

Contributor
I will also recommend modifying the values in the enum to something like {{projectName}}{{classVarName}}{{{value}}} which will make them unique in the complete project, because when you have two enums with the same values, C creates problem in compiling. I have faced these issues.
@michelealbano
michelealbano
commented
Oct 31, 2019

Copy link


Copy Markdown

ContributorAuthor
There is also the matter of the enum itself, since it generates _ToString and _FromString functions. Let us talk on gitter.
@wing328
wing328
commented
Nov 1, 2019

Copy link


Copy Markdown

Member
There is also the matter of the enum itself, since it generates _ToString and _FromString functions. Let us talk on gitter.
Please use Slack instead as we've made the switch already.
@michelealbano
michelealbano
commented
Nov 1, 2019

Copy link


Copy Markdown

ContributorAuthor
I did another pull request with a cleaner set of commits
@michelealbano
michelealbano
deleted the

CadditionalProperties

branch
November 1, 2019 17:21
@michelealbano
michelealbano
restored the

CadditionalProperties

branch
November 1, 2019 17:21
@michelealbano
michelealbano
deleted the

CadditionalProperties

branch
April 5, 2020 23:00
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: CIssue: Bug

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@michelealbano@wing328@zhemant@andrewemery@josh-burton@alavkx@saigiridhar21

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
C additional properties fix #4289 by michelealbano · Pull Request #4292 · OpenAPITools/openapi-generator · GitHub
Skip to content
C additional properties fix #4289 - #4292
Closed
michelealbano wants to merge 22 commits into
OpenAPITools:masterfrom 
michelealbano:CadditionalProperties
Closed
C additional properties fix #4289#4292
michelealbano wants to merge 22 commits into
OpenAPITools:masterfrom 
michelealbano:CadditionalProperties
Conversation
@michelealbano
@michelealbanomichelealbano
commented
Oct 28, 2019

Copy link


Copy Markdown

Contributor
Solved #4289.
PR checklist
  • [ X ] Read the contribution guidelines.
  • [ X ] If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • [ X ] Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • [ X ] File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@wing328wing328
changed the title
Cadditional properties fix #4289C additional properties fix #4289Oct 29, 2019
@wing328
wing328
commented
Oct 29, 2019

Copy link


Copy Markdown

Member
cc @zhemant
@wing328
wing328
commented
Oct 29, 2019

Copy link


Copy Markdown

Member
Travis CI reports the following error:
[ 78%] Building C object CMakeFiles/openapi_petstore.dir/api/PetAPI.c.o
[ 85%] Building C object CMakeFiles/openapi_petstore.dir/api/StoreAPI.c.o
[ 92%] Building C object CMakeFiles/openapi_petstore.dir/api/UserAPI.c.o
[100%] Linking C shared library libopenapi_petstore.so
[100%] Built target openapi_petstore
./build-and-test.bash: line 19: ./unit-manual-PetAPI: No such file or directory
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (pet-test) on project CPetstoreClientTests: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1]
[ERROR] 
michelealbanoand others
added 5 commits
October 29, 2019 05:59
@michelealbano
Merge remote-tracking branch 'upstream/master' into CadditionalProper…
e9da137
…ties
@wing328
Add arduino.cc to the user list (OpenAPITools#4307)
ae798d9
* Add arduino.cc to the user list
* Add Arduino logo
* add logo
Arun@wing328
[Python] [Bug] Correct typo in the word datetime (OpenAPITools#4304)
c8465c4
@andrewemery@wing328
Kotlin query collection format (OpenAPITools#4248)
a2b37d6
* Fixes incorrect query header collection constants
The OpenApi codegen converts OpenApi v2 documents into an OpenApi v3
representation. The query parameter collection formats are squeezed
into different values from the raw OpenApi 2 collection format values.
For example: csv -> space
See: DefaultCodegen#getCollectionFormat
* Updates kotlin samples
@michelealbano
Improved support for enums for C client generator
3f6c5b8
@michelealbano
michelealbano
commented
Oct 29, 2019

Copy link


Copy Markdown

ContributorAuthor
Travis CI reports the following error:
[ 78%] Building C object CMakeFiles/openapi_petstore.dir/api/PetAPI.c.o
[ 85%] Building C object CMakeFiles/openapi_petstore.dir/api/StoreAPI.c.o
[ 92%] Building C object CMakeFiles/openapi_petstore.dir/api/UserAPI.c.o
[100%] Linking C shared library libopenapi_petstore.so
[100%] Built target openapi_petstore
./build-and-test.bash: line 19: ./unit-manual-PetAPI: No such file or directory
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (pet-test) on project CPetstoreClientTests: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1]
[ERROR] 
How can I solve this? What is unit-manual-PetAPI?
@wing328
wing328
commented
Oct 29, 2019

Copy link


Copy Markdown

Member
I think those are unit tests. I noticed that you've commented out part of the CMakefile: https://github.com/OpenAPITools/openapi-generator/pull/4292/files#diff-bc97688208c58aee3233d8e276aef6ecR67
Not sure if it's related.
@michelealbano
michelealbano
commented
Oct 29, 2019

Copy link


Copy Markdown

ContributorAuthor
The changed to the test files were done automatically, by means of :

./bin/c-petstore.sh
@michelealbano
michelealbano
commented
Oct 29, 2019

Copy link


Copy Markdown

ContributorAuthor
I re-cloned a fresh master, mvn install is fine, when I do ./bin/c-petstore.sh the amples/client/petstore/c/CMakeLists.txt gets like win328 says, thus samples/client/petstore/c/build-and-test.bash will try to execute files that are not compiled.
I will open a bug report.
@zhemant
zhemant
commented
Oct 29, 2019

Copy link


Copy Markdown

Contributor
I know how to fix this, I fixed it in the one merge request, but couldnt update some other stuff so it was closed. I will create another merge request with a fix
@zhemant
zhemant
commented
Oct 29, 2019

Copy link


Copy Markdown

Contributor
#4312 should fix the issue
@michelealbano
michelealbano
commented
Oct 30, 2019

Copy link


Copy Markdown

ContributorAuthor
Thank you zhemant!
zhemantand others
added 11 commits
October 30, 2019 15:31
@zhemant@wing328
[C] Update build-and-test.bash for CI errors (OpenAPITools#4312)
6795434
* Update build-and-test.bash
add check for non autogenerated test file
* Update README.md.mustache
Add instructions on how to test petstore sample manual tests.
* remove petstore sample from readme
@josh-burton@wing328
[dart-dio] Correctly handles import of Uint8List (OpenAPITools#4313)
9c46973
* [dart-dio] Correctly handles import of Uint8List
- updates dio and built_value dependencies
* [dart-dio] Updates sample
@alavkx@macjohnny
[TS] Fixes typescript-axios "File custom.d.ts not found" when buildin…
b1984f3
…g consumer TS project (OpenAPITools#4230)
* remove unused file
* build(package.json): update node and ts
* remove ref to ambient declaration
* remove other ref to ambient declaration
* remove all references to custom.d.ts, rebuild
* regenerate typescript axios samples
Arun@wing328
[Python] Remove redundant else statement (OpenAPITools#4311)
eaca7b8
* [Python] Remove redundant else condition
* Add indentation
* Reduce extra indent
* Avoid longer than 79 chars
* Remove trailing space after response_body
* [Python] Fix pep8 violation in imports
* Revert "[Python] Fix pep8 violation in imports"
This reverts commit bc69aaa.
@saigiridhar21@wing328
[r][documentation]: Adding model summary to model documentation files. (
3082eda
OpenAPITools#4310)
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
@saigiridhar21@wing328
feat(documentation): Adding model documentation (OpenAPITools#4309)
73db23a
@saigiridhar21@wing328
feat(documentation): Adding model documentation (OpenAPITools#4308)
284c9dc
@saigiridhar21@wing328
[python][fix] Adding model summary to model documentation files (Open…
ec3569e
…APITools#4306)
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
@saigiridhar21@wing328
[r][license]: Fixing license and contact information (OpenAPITools#4317)
2188e0f
* fix(license): Fixing the license information
* fix(license): Fixing the license information
@michelealbano
changed C client generator to support additionalProperties
9bde492
@michelealbano
changed test files to support additionalProperties for C generator
e339baa
@michelealbano
Improved support for enums for C client generator
0717f33
@michelealbano
Revert "Improved support for enums for C client generator"
62bed01
This reverts commit 3f6c5b8.
Better to consider one problem at a time.
@michelealbano
Merge branch 'CadditionalProperties' ofhttps://github.com/michelealb…
ae258e3
…ano/openapi-generator into CadditionalProperties
Merged with new generated test files, after improvements of Pull Request OpenAPITools#4312.
Removed anything not related to C additional properties.
@zhemant
zhemant
commented
Oct 30, 2019

Copy link


Copy Markdown

Contributor
@michelealbano which version of openapi spec are you using with the generator v2 or v3?
@michelealbano
michelealbano
commented
Oct 30, 2019

Copy link


Copy Markdown

ContributorAuthor
@zhemant I am using v3
@zhemant
zhemant
commented
Oct 30, 2019

Copy link


Copy Markdown

Contributor
@michelealbano are you on gitter? May be we could add more updated parameters support to C if you are interested in helping out.
@michelealbano
michelealbano
commented
Oct 30, 2019

Copy link


Copy Markdown

ContributorAuthor
I am very interested. I have opened an issue regarding enums, and I will submit a PR tomorrow. I should also add _with_HTTP_headers methods in the future
@zhemant
zhemant
commented
Oct 30, 2019

Copy link


Copy Markdown

Contributor
I will also recommend modifying the values in the enum to something like {{projectName}}{{classVarName}}{{{value}}} which will make them unique in the complete project, because when you have two enums with the same values, C creates problem in compiling. I have faced these issues.
@michelealbano
michelealbano
commented
Oct 31, 2019

Copy link


Copy Markdown

ContributorAuthor
There is also the matter of the enum itself, since it generates _ToString and _FromString functions. Let us talk on gitter.
@wing328
wing328
commented
Nov 1, 2019

Copy link


Copy Markdown

Member
There is also the matter of the enum itself, since it generates _ToString and _FromString functions. Let us talk on gitter.
Please use Slack instead as we've made the switch already.
@michelealbano
michelealbano
commented
Nov 1, 2019

Copy link


Copy Markdown

ContributorAuthor
I did another pull request with a cleaner set of commits
@michelealbano
michelealbano
deleted the

CadditionalProperties

branch
November 1, 2019 17:21
@michelealbano
michelealbano
restored the

CadditionalProperties

branch
November 1, 2019 17:21
@michelealbano
michelealbano
deleted the

CadditionalProperties

branch
April 5, 2020 23:00
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: CIssue: Bug

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@michelealbano@wing328@zhemant@andrewemery@josh-burton@alavkx@saigiridhar21

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
C additional properties fix #4289 by michelealbano · Pull Request #4292 · OpenAPITools/openapi-generator · GitHub
Skip to content
C additional properties fix #4289 - #4292
Closed
michelealbano wants to merge 22 commits into
OpenAPITools:masterfrom 
michelealbano:CadditionalProperties
Closed
C additional properties fix #4289#4292
michelealbano wants to merge 22 commits into
OpenAPITools:masterfrom 
michelealbano:CadditionalProperties
Conversation
@michelealbano
@michelealbanomichelealbano
commented
Oct 28, 2019

Copy link


Copy Markdown

Contributor
Solved #4289.
PR checklist
  • [ X ] Read the contribution guidelines.
  • [ X ] If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • [ X ] Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • [ X ] File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@wing328wing328
changed the title
Cadditional properties fix #4289C additional properties fix #4289Oct 29, 2019
@wing328
wing328
commented
Oct 29, 2019

Copy link


Copy Markdown

Member
cc @zhemant
@wing328
wing328
commented
Oct 29, 2019

Copy link


Copy Markdown

Member
Travis CI reports the following error:
[ 78%] Building C object CMakeFiles/openapi_petstore.dir/api/PetAPI.c.o
[ 85%] Building C object CMakeFiles/openapi_petstore.dir/api/StoreAPI.c.o
[ 92%] Building C object CMakeFiles/openapi_petstore.dir/api/UserAPI.c.o
[100%] Linking C shared library libopenapi_petstore.so
[100%] Built target openapi_petstore
./build-and-test.bash: line 19: ./unit-manual-PetAPI: No such file or directory
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (pet-test) on project CPetstoreClientTests: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1]
[ERROR] 
michelealbanoand others
added 5 commits
October 29, 2019 05:59
@michelealbano
Merge remote-tracking branch 'upstream/master' into CadditionalProper…
e9da137
…ties
@wing328
Add arduino.cc to the user list (OpenAPITools#4307)
ae798d9
* Add arduino.cc to the user list
* Add Arduino logo
* add logo
Arun@wing328
[Python] [Bug] Correct typo in the word datetime (OpenAPITools#4304)
c8465c4
@andrewemery@wing328
Kotlin query collection format (OpenAPITools#4248)
a2b37d6
* Fixes incorrect query header collection constants
The OpenApi codegen converts OpenApi v2 documents into an OpenApi v3
representation. The query parameter collection formats are squeezed
into different values from the raw OpenApi 2 collection format values.
For example: csv -> space
See: DefaultCodegen#getCollectionFormat
* Updates kotlin samples
@michelealbano
Improved support for enums for C client generator
3f6c5b8
@michelealbano
michelealbano
commented
Oct 29, 2019

Copy link


Copy Markdown

ContributorAuthor
Travis CI reports the following error:
[ 78%] Building C object CMakeFiles/openapi_petstore.dir/api/PetAPI.c.o
[ 85%] Building C object CMakeFiles/openapi_petstore.dir/api/StoreAPI.c.o
[ 92%] Building C object CMakeFiles/openapi_petstore.dir/api/UserAPI.c.o
[100%] Linking C shared library libopenapi_petstore.so
[100%] Built target openapi_petstore
./build-and-test.bash: line 19: ./unit-manual-PetAPI: No such file or directory
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (pet-test) on project CPetstoreClientTests: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1]
[ERROR] 
How can I solve this? What is unit-manual-PetAPI?
@wing328
wing328
commented
Oct 29, 2019

Copy link


Copy Markdown

Member
I think those are unit tests. I noticed that you've commented out part of the CMakefile: https://github.com/OpenAPITools/openapi-generator/pull/4292/files#diff-bc97688208c58aee3233d8e276aef6ecR67
Not sure if it's related.
@michelealbano
michelealbano
commented
Oct 29, 2019

Copy link


Copy Markdown

ContributorAuthor
The changed to the test files were done automatically, by means of :

./bin/c-petstore.sh
@michelealbano
michelealbano
commented
Oct 29, 2019

Copy link


Copy Markdown

ContributorAuthor
I re-cloned a fresh master, mvn install is fine, when I do ./bin/c-petstore.sh the amples/client/petstore/c/CMakeLists.txt gets like win328 says, thus samples/client/petstore/c/build-and-test.bash will try to execute files that are not compiled.
I will open a bug report.
@zhemant
zhemant
commented
Oct 29, 2019

Copy link


Copy Markdown

Contributor
I know how to fix this, I fixed it in the one merge request, but couldnt update some other stuff so it was closed. I will create another merge request with a fix
@zhemant
zhemant
commented
Oct 29, 2019

Copy link


Copy Markdown

Contributor
#4312 should fix the issue
@michelealbano
michelealbano
commented
Oct 30, 2019

Copy link


Copy Markdown

ContributorAuthor
Thank you zhemant!
zhemantand others
added 11 commits
October 30, 2019 15:31
@zhemant@wing328
[C] Update build-and-test.bash for CI errors (OpenAPITools#4312)
6795434
* Update build-and-test.bash
add check for non autogenerated test file
* Update README.md.mustache
Add instructions on how to test petstore sample manual tests.
* remove petstore sample from readme
@josh-burton@wing328
[dart-dio] Correctly handles import of Uint8List (OpenAPITools#4313)
9c46973
* [dart-dio] Correctly handles import of Uint8List
- updates dio and built_value dependencies
* [dart-dio] Updates sample
@alavkx@macjohnny
[TS] Fixes typescript-axios "File custom.d.ts not found" when buildin…
b1984f3
…g consumer TS project (OpenAPITools#4230)
* remove unused file
* build(package.json): update node and ts
* remove ref to ambient declaration
* remove other ref to ambient declaration
* remove all references to custom.d.ts, rebuild
* regenerate typescript axios samples
Arun@wing328
[Python] Remove redundant else statement (OpenAPITools#4311)
eaca7b8
* [Python] Remove redundant else condition
* Add indentation
* Reduce extra indent
* Avoid longer than 79 chars
* Remove trailing space after response_body
* [Python] Fix pep8 violation in imports
* Revert "[Python] Fix pep8 violation in imports"
This reverts commit bc69aaa.
@saigiridhar21@wing328
[r][documentation]: Adding model summary to model documentation files. (
3082eda
OpenAPITools#4310)
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
@saigiridhar21@wing328
feat(documentation): Adding model documentation (OpenAPITools#4309)
73db23a
@saigiridhar21@wing328
feat(documentation): Adding model documentation (OpenAPITools#4308)
284c9dc
@saigiridhar21@wing328
[python][fix] Adding model summary to model documentation files (Open…
ec3569e
…APITools#4306)
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
@saigiridhar21@wing328
[r][license]: Fixing license and contact information (OpenAPITools#4317)
2188e0f
* fix(license): Fixing the license information
* fix(license): Fixing the license information
@michelealbano
changed C client generator to support additionalProperties
9bde492
@michelealbano
changed test files to support additionalProperties for C generator
e339baa
@michelealbano
Improved support for enums for C client generator
0717f33
@michelealbano
Revert "Improved support for enums for C client generator"
62bed01
This reverts commit 3f6c5b8.
Better to consider one problem at a time.
@michelealbano
Merge branch 'CadditionalProperties' ofhttps://github.com/michelealb…
ae258e3
…ano/openapi-generator into CadditionalProperties
Merged with new generated test files, after improvements of Pull Request OpenAPITools#4312.
Removed anything not related to C additional properties.
@zhemant
zhemant
commented
Oct 30, 2019

Copy link


Copy Markdown

Contributor
@michelealbano which version of openapi spec are you using with the generator v2 or v3?
@michelealbano
michelealbano
commented
Oct 30, 2019

Copy link


Copy Markdown

ContributorAuthor
@zhemant I am using v3
@zhemant
zhemant
commented
Oct 30, 2019

Copy link


Copy Markdown

Contributor
@michelealbano are you on gitter? May be we could add more updated parameters support to C if you are interested in helping out.
@michelealbano
michelealbano
commented
Oct 30, 2019

Copy link


Copy Markdown

ContributorAuthor
I am very interested. I have opened an issue regarding enums, and I will submit a PR tomorrow. I should also add _with_HTTP_headers methods in the future
@zhemant
zhemant
commented
Oct 30, 2019

Copy link


Copy Markdown

Contributor
I will also recommend modifying the values in the enum to something like {{projectName}}{{classVarName}}{{{value}}} which will make them unique in the complete project, because when you have two enums with the same values, C creates problem in compiling. I have faced these issues.
@michelealbano
michelealbano
commented
Oct 31, 2019

Copy link


Copy Markdown

ContributorAuthor
There is also the matter of the enum itself, since it generates _ToString and _FromString functions. Let us talk on gitter.
@wing328
wing328
commented
Nov 1, 2019

Copy link


Copy Markdown

Member
There is also the matter of the enum itself, since it generates _ToString and _FromString functions. Let us talk on gitter.
Please use Slack instead as we've made the switch already.
@michelealbano
michelealbano
commented
Nov 1, 2019

Copy link


Copy Markdown

ContributorAuthor
I did another pull request with a cleaner set of commits
@michelealbano
michelealbano
deleted the

CadditionalProperties

branch
November 1, 2019 17:21
@michelealbano
michelealbano
restored the

CadditionalProperties

branch
November 1, 2019 17:21
@michelealbano
michelealbano
deleted the

CadditionalProperties

branch
April 5, 2020 23:00
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: CIssue: Bug

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@michelealbano@wing328@zhemant@andrewemery@josh-burton@alavkx@saigiridhar21

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
C additional properties fix #4289 by michelealbano · Pull Request #4292 · OpenAPITools/openapi-generator · GitHub
Skip to content
C additional properties fix #4289 - #4292
Closed
michelealbano wants to merge 22 commits into
OpenAPITools:masterfrom 
michelealbano:CadditionalProperties
Closed
C additional properties fix #4289#4292
michelealbano wants to merge 22 commits into
OpenAPITools:masterfrom 
michelealbano:CadditionalProperties
Conversation
@michelealbano
@michelealbanomichelealbano
commented
Oct 28, 2019

Copy link


Copy Markdown

Contributor
Solved #4289.
PR checklist
  • [ X ] Read the contribution guidelines.
  • [ X ] If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • [ X ] Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • [ X ] File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@wing328wing328
changed the title
Cadditional properties fix #4289C additional properties fix #4289Oct 29, 2019
@wing328
wing328
commented
Oct 29, 2019

Copy link


Copy Markdown

Member
cc @zhemant
@wing328
wing328
commented
Oct 29, 2019

Copy link


Copy Markdown

Member
Travis CI reports the following error:
[ 78%] Building C object CMakeFiles/openapi_petstore.dir/api/PetAPI.c.o
[ 85%] Building C object CMakeFiles/openapi_petstore.dir/api/StoreAPI.c.o
[ 92%] Building C object CMakeFiles/openapi_petstore.dir/api/UserAPI.c.o
[100%] Linking C shared library libopenapi_petstore.so
[100%] Built target openapi_petstore
./build-and-test.bash: line 19: ./unit-manual-PetAPI: No such file or directory
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (pet-test) on project CPetstoreClientTests: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1]
[ERROR] 
michelealbanoand others
added 5 commits
October 29, 2019 05:59
@michelealbano
Merge remote-tracking branch 'upstream/master' into CadditionalProper…
e9da137
…ties
@wing328
Add arduino.cc to the user list (OpenAPITools#4307)
ae798d9
* Add arduino.cc to the user list
* Add Arduino logo
* add logo
Arun@wing328
[Python] [Bug] Correct typo in the word datetime (OpenAPITools#4304)
c8465c4
@andrewemery@wing328
Kotlin query collection format (OpenAPITools#4248)
a2b37d6
* Fixes incorrect query header collection constants
The OpenApi codegen converts OpenApi v2 documents into an OpenApi v3
representation. The query parameter collection formats are squeezed
into different values from the raw OpenApi 2 collection format values.
For example: csv -> space
See: DefaultCodegen#getCollectionFormat
* Updates kotlin samples
@michelealbano
Improved support for enums for C client generator
3f6c5b8
@michelealbano
michelealbano
commented
Oct 29, 2019

Copy link


Copy Markdown

ContributorAuthor
Travis CI reports the following error:
[ 78%] Building C object CMakeFiles/openapi_petstore.dir/api/PetAPI.c.o
[ 85%] Building C object CMakeFiles/openapi_petstore.dir/api/StoreAPI.c.o
[ 92%] Building C object CMakeFiles/openapi_petstore.dir/api/UserAPI.c.o
[100%] Linking C shared library libopenapi_petstore.so
[100%] Built target openapi_petstore
./build-and-test.bash: line 19: ./unit-manual-PetAPI: No such file or directory
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (pet-test) on project CPetstoreClientTests: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1]
[ERROR] 
How can I solve this? What is unit-manual-PetAPI?
@wing328
wing328
commented
Oct 29, 2019

Copy link


Copy Markdown

Member
I think those are unit tests. I noticed that you've commented out part of the CMakefile: https://github.com/OpenAPITools/openapi-generator/pull/4292/files#diff-bc97688208c58aee3233d8e276aef6ecR67
Not sure if it's related.
@michelealbano
michelealbano
commented
Oct 29, 2019

Copy link


Copy Markdown

ContributorAuthor
The changed to the test files were done automatically, by means of :

./bin/c-petstore.sh
@michelealbano
michelealbano
commented
Oct 29, 2019

Copy link


Copy Markdown

ContributorAuthor
I re-cloned a fresh master, mvn install is fine, when I do ./bin/c-petstore.sh the amples/client/petstore/c/CMakeLists.txt gets like win328 says, thus samples/client/petstore/c/build-and-test.bash will try to execute files that are not compiled.
I will open a bug report.
@zhemant
zhemant
commented
Oct 29, 2019

Copy link


Copy Markdown

Contributor
I know how to fix this, I fixed it in the one merge request, but couldnt update some other stuff so it was closed. I will create another merge request with a fix
@zhemant
zhemant
commented
Oct 29, 2019

Copy link


Copy Markdown

Contributor
#4312 should fix the issue
@michelealbano
michelealbano
commented
Oct 30, 2019

Copy link


Copy Markdown

ContributorAuthor
Thank you zhemant!
zhemantand others
added 11 commits
October 30, 2019 15:31
@zhemant@wing328
[C] Update build-and-test.bash for CI errors (OpenAPITools#4312)
6795434
* Update build-and-test.bash
add check for non autogenerated test file
* Update README.md.mustache
Add instructions on how to test petstore sample manual tests.
* remove petstore sample from readme
@josh-burton@wing328
[dart-dio] Correctly handles import of Uint8List (OpenAPITools#4313)
9c46973
* [dart-dio] Correctly handles import of Uint8List
- updates dio and built_value dependencies
* [dart-dio] Updates sample
@alavkx@macjohnny
[TS] Fixes typescript-axios "File custom.d.ts not found" when buildin…
b1984f3
…g consumer TS project (OpenAPITools#4230)
* remove unused file
* build(package.json): update node and ts
* remove ref to ambient declaration
* remove other ref to ambient declaration
* remove all references to custom.d.ts, rebuild
* regenerate typescript axios samples
Arun@wing328
[Python] Remove redundant else statement (OpenAPITools#4311)
eaca7b8
* [Python] Remove redundant else condition
* Add indentation
* Reduce extra indent
* Avoid longer than 79 chars
* Remove trailing space after response_body
* [Python] Fix pep8 violation in imports
* Revert "[Python] Fix pep8 violation in imports"
This reverts commit bc69aaa.
@saigiridhar21@wing328
[r][documentation]: Adding model summary to model documentation files. (
3082eda
OpenAPITools#4310)
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
@saigiridhar21@wing328
feat(documentation): Adding model documentation (OpenAPITools#4309)
73db23a
@saigiridhar21@wing328
feat(documentation): Adding model documentation (OpenAPITools#4308)
284c9dc
@saigiridhar21@wing328
[python][fix] Adding model summary to model documentation files (Open…
ec3569e
…APITools#4306)
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
@saigiridhar21@wing328
[r][license]: Fixing license and contact information (OpenAPITools#4317)
2188e0f
* fix(license): Fixing the license information
* fix(license): Fixing the license information
@michelealbano
changed C client generator to support additionalProperties
9bde492
@michelealbano
changed test files to support additionalProperties for C generator
e339baa
@michelealbano
Improved support for enums for C client generator
0717f33
@michelealbano
Revert "Improved support for enums for C client generator"
62bed01
This reverts commit 3f6c5b8.
Better to consider one problem at a time.
@michelealbano
Merge branch 'CadditionalProperties' ofhttps://github.com/michelealb…
ae258e3
…ano/openapi-generator into CadditionalProperties
Merged with new generated test files, after improvements of Pull Request OpenAPITools#4312.
Removed anything not related to C additional properties.
@zhemant
zhemant
commented
Oct 30, 2019

Copy link


Copy Markdown

Contributor
@michelealbano which version of openapi spec are you using with the generator v2 or v3?
@michelealbano
michelealbano
commented
Oct 30, 2019

Copy link


Copy Markdown

ContributorAuthor
@zhemant I am using v3
@zhemant
zhemant
commented
Oct 30, 2019

Copy link


Copy Markdown

Contributor
@michelealbano are you on gitter? May be we could add more updated parameters support to C if you are interested in helping out.
@michelealbano
michelealbano
commented
Oct 30, 2019

Copy link


Copy Markdown

ContributorAuthor
I am very interested. I have opened an issue regarding enums, and I will submit a PR tomorrow. I should also add _with_HTTP_headers methods in the future
@zhemant
zhemant
commented
Oct 30, 2019

Copy link


Copy Markdown

Contributor
I will also recommend modifying the values in the enum to something like {{projectName}}{{classVarName}}{{{value}}} which will make them unique in the complete project, because when you have two enums with the same values, C creates problem in compiling. I have faced these issues.
@michelealbano
michelealbano
commented
Oct 31, 2019

Copy link


Copy Markdown

ContributorAuthor
There is also the matter of the enum itself, since it generates _ToString and _FromString functions. Let us talk on gitter.
@wing328
wing328
commented
Nov 1, 2019

Copy link


Copy Markdown

Member
There is also the matter of the enum itself, since it generates _ToString and _FromString functions. Let us talk on gitter.
Please use Slack instead as we've made the switch already.
@michelealbano
michelealbano
commented
Nov 1, 2019

Copy link


Copy Markdown

ContributorAuthor
I did another pull request with a cleaner set of commits
@michelealbano
michelealbano
deleted the

CadditionalProperties

branch
November 1, 2019 17:21
@michelealbano
michelealbano
restored the

CadditionalProperties

branch
November 1, 2019 17:21
@michelealbano
michelealbano
deleted the

CadditionalProperties

branch
April 5, 2020 23:00
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: CIssue: Bug

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@michelealbano@wing328@zhemant@andrewemery@josh-burton@alavkx@saigiridhar21

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
C additional properties fix #4289 by michelealbano · Pull Request #4292 · OpenAPITools/openapi-generator · GitHub
Skip to content
C additional properties fix #4289 - #4292
Closed
michelealbano wants to merge 22 commits into
OpenAPITools:masterfrom 
michelealbano:CadditionalProperties
Closed
C additional properties fix #4289#4292
michelealbano wants to merge 22 commits into
OpenAPITools:masterfrom 
michelealbano:CadditionalProperties
Conversation
@michelealbano
@michelealbanomichelealbano
commented
Oct 28, 2019

Copy link


Copy Markdown

Contributor
Solved #4289.
PR checklist
  • [ X ] Read the contribution guidelines.
  • [ X ] If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • [ X ] Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • [ X ] File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@wing328wing328
changed the title
Cadditional properties fix #4289C additional properties fix #4289Oct 29, 2019
@wing328
wing328
commented
Oct 29, 2019

Copy link


Copy Markdown

Member
cc @zhemant
@wing328
wing328
commented
Oct 29, 2019

Copy link


Copy Markdown

Member
Travis CI reports the following error:
[ 78%] Building C object CMakeFiles/openapi_petstore.dir/api/PetAPI.c.o
[ 85%] Building C object CMakeFiles/openapi_petstore.dir/api/StoreAPI.c.o
[ 92%] Building C object CMakeFiles/openapi_petstore.dir/api/UserAPI.c.o
[100%] Linking C shared library libopenapi_petstore.so
[100%] Built target openapi_petstore
./build-and-test.bash: line 19: ./unit-manual-PetAPI: No such file or directory
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (pet-test) on project CPetstoreClientTests: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1]
[ERROR] 
michelealbanoand others
added 5 commits
October 29, 2019 05:59
@michelealbano
Merge remote-tracking branch 'upstream/master' into CadditionalProper…
e9da137
…ties
@wing328
Add arduino.cc to the user list (OpenAPITools#4307)
ae798d9
* Add arduino.cc to the user list
* Add Arduino logo
* add logo
Arun@wing328
[Python] [Bug] Correct typo in the word datetime (OpenAPITools#4304)
c8465c4
@andrewemery@wing328
Kotlin query collection format (OpenAPITools#4248)
a2b37d6
* Fixes incorrect query header collection constants
The OpenApi codegen converts OpenApi v2 documents into an OpenApi v3
representation. The query parameter collection formats are squeezed
into different values from the raw OpenApi 2 collection format values.
For example: csv -> space
See: DefaultCodegen#getCollectionFormat
* Updates kotlin samples
@michelealbano
Improved support for enums for C client generator
3f6c5b8
@michelealbano
michelealbano
commented
Oct 29, 2019

Copy link


Copy Markdown

ContributorAuthor
Travis CI reports the following error:
[ 78%] Building C object CMakeFiles/openapi_petstore.dir/api/PetAPI.c.o
[ 85%] Building C object CMakeFiles/openapi_petstore.dir/api/StoreAPI.c.o
[ 92%] Building C object CMakeFiles/openapi_petstore.dir/api/UserAPI.c.o
[100%] Linking C shared library libopenapi_petstore.so
[100%] Built target openapi_petstore
./build-and-test.bash: line 19: ./unit-manual-PetAPI: No such file or directory
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (pet-test) on project CPetstoreClientTests: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1]
[ERROR] 
How can I solve this? What is unit-manual-PetAPI?
@wing328
wing328
commented
Oct 29, 2019

Copy link


Copy Markdown

Member
I think those are unit tests. I noticed that you've commented out part of the CMakefile: https://github.com/OpenAPITools/openapi-generator/pull/4292/files#diff-bc97688208c58aee3233d8e276aef6ecR67
Not sure if it's related.
@michelealbano
michelealbano
commented
Oct 29, 2019

Copy link


Copy Markdown

ContributorAuthor
The changed to the test files were done automatically, by means of :

./bin/c-petstore.sh
@michelealbano
michelealbano
commented
Oct 29, 2019

Copy link


Copy Markdown

ContributorAuthor
I re-cloned a fresh master, mvn install is fine, when I do ./bin/c-petstore.sh the amples/client/petstore/c/CMakeLists.txt gets like win328 says, thus samples/client/petstore/c/build-and-test.bash will try to execute files that are not compiled.
I will open a bug report.
@zhemant
zhemant
commented
Oct 29, 2019

Copy link


Copy Markdown

Contributor
I know how to fix this, I fixed it in the one merge request, but couldnt update some other stuff so it was closed. I will create another merge request with a fix
@zhemant
zhemant
commented
Oct 29, 2019

Copy link


Copy Markdown

Contributor
#4312 should fix the issue
@michelealbano
michelealbano
commented
Oct 30, 2019

Copy link


Copy Markdown

ContributorAuthor
Thank you zhemant!
zhemantand others
added 11 commits
October 30, 2019 15:31
@zhemant@wing328
[C] Update build-and-test.bash for CI errors (OpenAPITools#4312)
6795434
* Update build-and-test.bash
add check for non autogenerated test file
* Update README.md.mustache
Add instructions on how to test petstore sample manual tests.
* remove petstore sample from readme
@josh-burton@wing328
[dart-dio] Correctly handles import of Uint8List (OpenAPITools#4313)
9c46973
* [dart-dio] Correctly handles import of Uint8List
- updates dio and built_value dependencies
* [dart-dio] Updates sample
@alavkx@macjohnny
[TS] Fixes typescript-axios "File custom.d.ts not found" when buildin…
b1984f3
…g consumer TS project (OpenAPITools#4230)
* remove unused file
* build(package.json): update node and ts
* remove ref to ambient declaration
* remove other ref to ambient declaration
* remove all references to custom.d.ts, rebuild
* regenerate typescript axios samples
Arun@wing328
[Python] Remove redundant else statement (OpenAPITools#4311)
eaca7b8
* [Python] Remove redundant else condition
* Add indentation
* Reduce extra indent
* Avoid longer than 79 chars
* Remove trailing space after response_body
* [Python] Fix pep8 violation in imports
* Revert "[Python] Fix pep8 violation in imports"
This reverts commit bc69aaa.
@saigiridhar21@wing328
[r][documentation]: Adding model summary to model documentation files. (
3082eda
OpenAPITools#4310)
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
@saigiridhar21@wing328
feat(documentation): Adding model documentation (OpenAPITools#4309)
73db23a
@saigiridhar21@wing328
feat(documentation): Adding model documentation (OpenAPITools#4308)
284c9dc
@saigiridhar21@wing328
[python][fix] Adding model summary to model documentation files (Open…
ec3569e
…APITools#4306)
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
@saigiridhar21@wing328
[r][license]: Fixing license and contact information (OpenAPITools#4317)
2188e0f
* fix(license): Fixing the license information
* fix(license): Fixing the license information
@michelealbano
changed C client generator to support additionalProperties
9bde492
@michelealbano
changed test files to support additionalProperties for C generator
e339baa
@michelealbano
Improved support for enums for C client generator
0717f33
@michelealbano
Revert "Improved support for enums for C client generator"
62bed01
This reverts commit 3f6c5b8.
Better to consider one problem at a time.
@michelealbano
Merge branch 'CadditionalProperties' ofhttps://github.com/michelealb…
ae258e3
…ano/openapi-generator into CadditionalProperties
Merged with new generated test files, after improvements of Pull Request OpenAPITools#4312.
Removed anything not related to C additional properties.
@zhemant
zhemant
commented
Oct 30, 2019

Copy link


Copy Markdown

Contributor
@michelealbano which version of openapi spec are you using with the generator v2 or v3?
@michelealbano
michelealbano
commented
Oct 30, 2019

Copy link


Copy Markdown

ContributorAuthor
@zhemant I am using v3
@zhemant
zhemant
commented
Oct 30, 2019

Copy link


Copy Markdown

Contributor
@michelealbano are you on gitter? May be we could add more updated parameters support to C if you are interested in helping out.
@michelealbano
michelealbano
commented
Oct 30, 2019

Copy link


Copy Markdown

ContributorAuthor
I am very interested. I have opened an issue regarding enums, and I will submit a PR tomorrow. I should also add _with_HTTP_headers methods in the future
@zhemant
zhemant
commented
Oct 30, 2019

Copy link


Copy Markdown

Contributor
I will also recommend modifying the values in the enum to something like {{projectName}}{{classVarName}}{{{value}}} which will make them unique in the complete project, because when you have two enums with the same values, C creates problem in compiling. I have faced these issues.
@michelealbano
michelealbano
commented
Oct 31, 2019

Copy link


Copy Markdown

ContributorAuthor
There is also the matter of the enum itself, since it generates _ToString and _FromString functions. Let us talk on gitter.
@wing328
wing328
commented
Nov 1, 2019

Copy link


Copy Markdown

Member
There is also the matter of the enum itself, since it generates _ToString and _FromString functions. Let us talk on gitter.
Please use Slack instead as we've made the switch already.
@michelealbano
michelealbano
commented
Nov 1, 2019

Copy link


Copy Markdown

ContributorAuthor
I did another pull request with a cleaner set of commits
@michelealbano
michelealbano
deleted the

CadditionalProperties

branch
November 1, 2019 17:21
@michelealbano
michelealbano
restored the

CadditionalProperties

branch
November 1, 2019 17:21
@michelealbano
michelealbano
deleted the

CadditionalProperties

branch
April 5, 2020 23:00
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: CIssue: Bug

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@michelealbano@wing328@zhemant@andrewemery@josh-burton@alavkx@saigiridhar21

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
C additional properties fix #4289 by michelealbano · Pull Request #4292 · OpenAPITools/openapi-generator · GitHub
Skip to content
C additional properties fix #4289 - #4292
Closed
michelealbano wants to merge 22 commits into
OpenAPITools:masterfrom 
michelealbano:CadditionalProperties
Closed
C additional properties fix #4289#4292
michelealbano wants to merge 22 commits into
OpenAPITools:masterfrom 
michelealbano:CadditionalProperties
Conversation
@michelealbano
@michelealbanomichelealbano
commented
Oct 28, 2019

Copy link


Copy Markdown

Contributor
Solved #4289.
PR checklist
  • [ X ] Read the contribution guidelines.
  • [ X ] If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • [ X ] Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • [ X ] File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@wing328wing328
changed the title
Cadditional properties fix #4289C additional properties fix #4289Oct 29, 2019
@wing328
wing328
commented
Oct 29, 2019

Copy link


Copy Markdown

Member
cc @zhemant
@wing328
wing328
commented
Oct 29, 2019

Copy link


Copy Markdown

Member
Travis CI reports the following error:
[ 78%] Building C object CMakeFiles/openapi_petstore.dir/api/PetAPI.c.o
[ 85%] Building C object CMakeFiles/openapi_petstore.dir/api/StoreAPI.c.o
[ 92%] Building C object CMakeFiles/openapi_petstore.dir/api/UserAPI.c.o
[100%] Linking C shared library libopenapi_petstore.so
[100%] Built target openapi_petstore
./build-and-test.bash: line 19: ./unit-manual-PetAPI: No such file or directory
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (pet-test) on project CPetstoreClientTests: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1]
[ERROR] 
michelealbanoand others
added 5 commits
October 29, 2019 05:59
@michelealbano
Merge remote-tracking branch 'upstream/master' into CadditionalProper…
e9da137
…ties
@wing328
Add arduino.cc to the user list (OpenAPITools#4307)
ae798d9
* Add arduino.cc to the user list
* Add Arduino logo
* add logo
Arun@wing328
[Python] [Bug] Correct typo in the word datetime (OpenAPITools#4304)
c8465c4
@andrewemery@wing328
Kotlin query collection format (OpenAPITools#4248)
a2b37d6
* Fixes incorrect query header collection constants
The OpenApi codegen converts OpenApi v2 documents into an OpenApi v3
representation. The query parameter collection formats are squeezed
into different values from the raw OpenApi 2 collection format values.
For example: csv -> space
See: DefaultCodegen#getCollectionFormat
* Updates kotlin samples
@michelealbano
Improved support for enums for C client generator
3f6c5b8
@michelealbano
michelealbano
commented
Oct 29, 2019

Copy link


Copy Markdown

ContributorAuthor
Travis CI reports the following error:
[ 78%] Building C object CMakeFiles/openapi_petstore.dir/api/PetAPI.c.o
[ 85%] Building C object CMakeFiles/openapi_petstore.dir/api/StoreAPI.c.o
[ 92%] Building C object CMakeFiles/openapi_petstore.dir/api/UserAPI.c.o
[100%] Linking C shared library libopenapi_petstore.so
[100%] Built target openapi_petstore
./build-and-test.bash: line 19: ./unit-manual-PetAPI: No such file or directory
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (pet-test) on project CPetstoreClientTests: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1]
[ERROR] 
How can I solve this? What is unit-manual-PetAPI?
@wing328
wing328
commented
Oct 29, 2019

Copy link


Copy Markdown

Member
I think those are unit tests. I noticed that you've commented out part of the CMakefile: https://github.com/OpenAPITools/openapi-generator/pull/4292/files#diff-bc97688208c58aee3233d8e276aef6ecR67
Not sure if it's related.
@michelealbano
michelealbano
commented
Oct 29, 2019

Copy link


Copy Markdown

ContributorAuthor
The changed to the test files were done automatically, by means of :

./bin/c-petstore.sh
@michelealbano
michelealbano
commented
Oct 29, 2019

Copy link


Copy Markdown

ContributorAuthor
I re-cloned a fresh master, mvn install is fine, when I do ./bin/c-petstore.sh the amples/client/petstore/c/CMakeLists.txt gets like win328 says, thus samples/client/petstore/c/build-and-test.bash will try to execute files that are not compiled.
I will open a bug report.
@zhemant
zhemant
commented
Oct 29, 2019

Copy link


Copy Markdown

Contributor
I know how to fix this, I fixed it in the one merge request, but couldnt update some other stuff so it was closed. I will create another merge request with a fix
@zhemant
zhemant
commented
Oct 29, 2019

Copy link


Copy Markdown

Contributor
#4312 should fix the issue
@michelealbano
michelealbano
commented
Oct 30, 2019

Copy link


Copy Markdown

ContributorAuthor
Thank you zhemant!
zhemantand others
added 11 commits
October 30, 2019 15:31
@zhemant@wing328
[C] Update build-and-test.bash for CI errors (OpenAPITools#4312)
6795434
* Update build-and-test.bash
add check for non autogenerated test file
* Update README.md.mustache
Add instructions on how to test petstore sample manual tests.
* remove petstore sample from readme
@josh-burton@wing328
[dart-dio] Correctly handles import of Uint8List (OpenAPITools#4313)
9c46973
* [dart-dio] Correctly handles import of Uint8List
- updates dio and built_value dependencies
* [dart-dio] Updates sample
@alavkx@macjohnny
[TS] Fixes typescript-axios "File custom.d.ts not found" when buildin…
b1984f3
…g consumer TS project (OpenAPITools#4230)
* remove unused file
* build(package.json): update node and ts
* remove ref to ambient declaration
* remove other ref to ambient declaration
* remove all references to custom.d.ts, rebuild
* regenerate typescript axios samples
Arun@wing328
[Python] Remove redundant else statement (OpenAPITools#4311)
eaca7b8
* [Python] Remove redundant else condition
* Add indentation
* Reduce extra indent
* Avoid longer than 79 chars
* Remove trailing space after response_body
* [Python] Fix pep8 violation in imports
* Revert "[Python] Fix pep8 violation in imports"
This reverts commit bc69aaa.
@saigiridhar21@wing328
[r][documentation]: Adding model summary to model documentation files. (
3082eda
OpenAPITools#4310)
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
@saigiridhar21@wing328
feat(documentation): Adding model documentation (OpenAPITools#4309)
73db23a
@saigiridhar21@wing328
feat(documentation): Adding model documentation (OpenAPITools#4308)
284c9dc
@saigiridhar21@wing328
[python][fix] Adding model summary to model documentation files (Open…
ec3569e
…APITools#4306)
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
* feat(documentation): Adding model documentation
@saigiridhar21@wing328
[r][license]: Fixing license and contact information (OpenAPITools#4317)
2188e0f
* fix(license): Fixing the license information
* fix(license): Fixing the license information
@michelealbano
changed C client generator to support additionalProperties
9bde492
@michelealbano
changed test files to support additionalProperties for C generator
e339baa
@michelealbano
Improved support for enums for C client generator
0717f33
@michelealbano
Revert "Improved support for enums for C client generator"
62bed01
This reverts commit 3f6c5b8.
Better to consider one problem at a time.
@michelealbano
Merge branch 'CadditionalProperties' ofhttps://github.com/michelealb…
ae258e3
…ano/openapi-generator into CadditionalProperties
Merged with new generated test files, after improvements of Pull Request OpenAPITools#4312.
Removed anything not related to C additional properties.
@zhemant
zhemant
commented
Oct 30, 2019

Copy link


Copy Markdown

Contributor
@michelealbano which version of openapi spec are you using with the generator v2 or v3?
@michelealbano
michelealbano
commented
Oct 30, 2019

Copy link


Copy Markdown

ContributorAuthor
@zhemant I am using v3
@zhemant
zhemant
commented
Oct 30, 2019

Copy link


Copy Markdown

Contributor
@michelealbano are you on gitter? May be we could add more updated parameters support to C if you are interested in helping out.
@michelealbano
michelealbano
commented
Oct 30, 2019

Copy link


Copy Markdown

ContributorAuthor
I am very interested. I have opened an issue regarding enums, and I will submit a PR tomorrow. I should also add _with_HTTP_headers methods in the future
@zhemant
zhemant
commented
Oct 30, 2019

Copy link


Copy Markdown

Contributor
I will also recommend modifying the values in the enum to something like {{projectName}}{{classVarName}}{{{value}}} which will make them unique in the complete project, because when you have two enums with the same values, C creates problem in compiling. I have faced these issues.
@michelealbano
michelealbano
commented
Oct 31, 2019

Copy link


Copy Markdown

ContributorAuthor
There is also the matter of the enum itself, since it generates _ToString and _FromString functions. Let us talk on gitter.
@wing328
wing328
commented
Nov 1, 2019

Copy link


Copy Markdown

Member
There is also the matter of the enum itself, since it generates _ToString and _FromString functions. Let us talk on gitter.
Please use Slack instead as we've made the switch already.
@michelealbano
michelealbano
commented
Nov 1, 2019

Copy link


Copy Markdown

ContributorAuthor
I did another pull request with a cleaner set of commits
@michelealbano
michelealbano
deleted the

CadditionalProperties

branch
November 1, 2019 17:21
@michelealbano
michelealbano
restored the

CadditionalProperties

branch
November 1, 2019 17:21
@michelealbano
michelealbano
deleted the

CadditionalProperties

branch
April 5, 2020 23:00
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Client: CIssue: Bug

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@michelealbano@wing328@zhemant@andrewemery@josh-burton@alavkx@saigiridhar21