[Dart] Treat float as double by sbu-WBT · Pull Request #6924 · OpenAPITools/openapi-generator

sbu-WBT · 2020-07-13T19:11:47Z

Double gets special special treatment in the mustache to prevent some errors like type 'int' is not a subtype of type 'double'.

openapi-generator/modules/openapi-generator/src/main/resources/dart2/class.mustache

Lines 75 to 82 in dad931a

{{#isDouble}} 
{{name}} = (json['{{baseName}}'] == null) ? 
 null : 
 json['{{baseName}}'].toDouble(); 
{{/isDouble}} 
{{^isDouble}} 
{{name}} = json['{{baseName}}']; 
{{/isDouble}} 

Dart has no floats so they are replaced with doubles. Before this fix, it wasn't the case inside the mustache file so the floats had the type double in the class, but not the code from the isDouble block inside the mustache because only isFloat was true.

PR checklist

Read the contribution guidelines.
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09) @athornz (2019/12) @amondnet (2019/12)

agilob · 2020-07-21T17:20:53Z

Can we get a test for it pls?

wing328 · 2020-07-30T01:54:27Z

 {{#isDouble}} {{name}} = (json['{{baseName}}'] == null) ? null : json['{{baseName}}'].toDouble(); {{/isDouble}} {{^isDouble}} {{name}} = json['{{baseName}}']; {{/isDouble}}

What about using {{#isNumber}} ... {{/isNumber}} instead, which returns true for both double and float?

sbu-WBT · 2020-07-30T10:26:05Z

Good idea, but would {{#isNumber}} ... {{/isNumber}} return true with an int? If not, I think it's the way to go @wing328

wing328 · 2020-07-30T10:39:24Z

isNumber will return false if it's integer or long.

FYI. isNumeric will return true if it's integer/long/double/float.

…uble-dart # Conflicts: # modules/openapi-generator/src/main/resources/dart2/class.mustache

sbu-WBT · 2020-07-30T13:23:17Z

@wing328 Replaced. I think the failing CI is not my fault because the master branch is also failing

wing328 · 2020-08-02T08:46:31Z

Shippable CI failure not related to this PR.

wing328 · 2020-08-02T08:47:37Z

LGTM. We'll add tests after the dart2 client is ready to make the switch to use fake petstore

* master: (121 commits) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108) [MARKDOWN] Fix issue 6089 with property and parameter names (#6105) [BUG] Multi-Part content type in response ignores properties of composed schema (allOf/oneOf) (#6073) [online] Fix for version conflicts with springfox/boot (#7102) skip some installations to shorten build time [Go][Exp] better code format (#7088) Fix Shippable CI (#7097) typescript-node: clean up require and import (#6947) commented out perl, bash tests to reduce build time Add a link to conference paper (#7086) Add a link to the blog post at qiita (#7084) migrate typescript.sh to new config format (#7078) ...

* master: [core] Add type and format properties to model of inline response (#6153) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108)

sbu-WBT · 2020-07-13T19:11:47Z

Double gets special special treatment in the mustache to prevent some errors like type 'int' is not a subtype of type 'double'.

openapi-generator/modules/openapi-generator/src/main/resources/dart2/class.mustache

Lines 75 to 82 in dad931a

{{#isDouble}} 
{{name}} = (json['{{baseName}}'] == null) ? 
 null : 
 json['{{baseName}}'].toDouble(); 
{{/isDouble}} 
{{^isDouble}} 
{{name}} = json['{{baseName}}']; 
{{/isDouble}} 

Dart has no floats so they are replaced with doubles. Before this fix, it wasn't the case inside the mustache file so the floats had the type double in the class, but not the code from the isDouble block inside the mustache because only isFloat was true.

PR checklist

Read the contribution guidelines.
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09) @athornz (2019/12) @amondnet (2019/12)

agilob · 2020-07-21T17:20:53Z

Can we get a test for it pls?

wing328 · 2020-07-30T01:54:27Z

 {{#isDouble}} {{name}} = (json['{{baseName}}'] == null) ? null : json['{{baseName}}'].toDouble(); {{/isDouble}} {{^isDouble}} {{name}} = json['{{baseName}}']; {{/isDouble}}

What about using {{#isNumber}} ... {{/isNumber}} instead, which returns true for both double and float?

sbu-WBT · 2020-07-30T10:26:05Z

Good idea, but would {{#isNumber}} ... {{/isNumber}} return true with an int? If not, I think it's the way to go @wing328

wing328 · 2020-07-30T10:39:24Z

isNumber will return false if it's integer or long.

FYI. isNumeric will return true if it's integer/long/double/float.

…uble-dart # Conflicts: # modules/openapi-generator/src/main/resources/dart2/class.mustache

sbu-WBT · 2020-07-30T13:23:17Z

@wing328 Replaced. I think the failing CI is not my fault because the master branch is also failing

wing328 · 2020-08-02T08:46:31Z

Shippable CI failure not related to this PR.

wing328 · 2020-08-02T08:47:37Z

LGTM. We'll add tests after the dart2 client is ready to make the switch to use fake petstore

* master: (121 commits) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108) [MARKDOWN] Fix issue 6089 with property and parameter names (#6105) [BUG] Multi-Part content type in response ignores properties of composed schema (allOf/oneOf) (#6073) [online] Fix for version conflicts with springfox/boot (#7102) skip some installations to shorten build time [Go][Exp] better code format (#7088) Fix Shippable CI (#7097) typescript-node: clean up require and import (#6947) commented out perl, bash tests to reduce build time Add a link to conference paper (#7086) Add a link to the blog post at qiita (#7084) migrate typescript.sh to new config format (#7078) ...

* master: [core] Add type and format properties to model of inline response (#6153) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108)

sbu-WBT · 2020-07-13T19:11:47Z

Double gets special special treatment in the mustache to prevent some errors like type 'int' is not a subtype of type 'double'.

openapi-generator/modules/openapi-generator/src/main/resources/dart2/class.mustache

Lines 75 to 82 in dad931a

{{#isDouble}} 
{{name}} = (json['{{baseName}}'] == null) ? 
 null : 
 json['{{baseName}}'].toDouble(); 
{{/isDouble}} 
{{^isDouble}} 
{{name}} = json['{{baseName}}']; 
{{/isDouble}} 

Dart has no floats so they are replaced with doubles. Before this fix, it wasn't the case inside the mustache file so the floats had the type double in the class, but not the code from the isDouble block inside the mustache because only isFloat was true.

PR checklist

Read the contribution guidelines.
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09) @athornz (2019/12) @amondnet (2019/12)

agilob · 2020-07-21T17:20:53Z

Can we get a test for it pls?

wing328 · 2020-07-30T01:54:27Z

 {{#isDouble}} {{name}} = (json['{{baseName}}'] == null) ? null : json['{{baseName}}'].toDouble(); {{/isDouble}} {{^isDouble}} {{name}} = json['{{baseName}}']; {{/isDouble}}

What about using {{#isNumber}} ... {{/isNumber}} instead, which returns true for both double and float?

sbu-WBT · 2020-07-30T10:26:05Z

Good idea, but would {{#isNumber}} ... {{/isNumber}} return true with an int? If not, I think it's the way to go @wing328

wing328 · 2020-07-30T10:39:24Z

isNumber will return false if it's integer or long.

FYI. isNumeric will return true if it's integer/long/double/float.

…uble-dart # Conflicts: # modules/openapi-generator/src/main/resources/dart2/class.mustache

sbu-WBT · 2020-07-30T13:23:17Z

@wing328 Replaced. I think the failing CI is not my fault because the master branch is also failing

wing328 · 2020-08-02T08:46:31Z

Shippable CI failure not related to this PR.

wing328 · 2020-08-02T08:47:37Z

LGTM. We'll add tests after the dart2 client is ready to make the switch to use fake petstore

* master: (121 commits) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108) [MARKDOWN] Fix issue 6089 with property and parameter names (#6105) [BUG] Multi-Part content type in response ignores properties of composed schema (allOf/oneOf) (#6073) [online] Fix for version conflicts with springfox/boot (#7102) skip some installations to shorten build time [Go][Exp] better code format (#7088) Fix Shippable CI (#7097) typescript-node: clean up require and import (#6947) commented out perl, bash tests to reduce build time Add a link to conference paper (#7086) Add a link to the blog post at qiita (#7084) migrate typescript.sh to new config format (#7078) ...

* master: [core] Add type and format properties to model of inline response (#6153) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108)

sbu-WBT · 2020-07-13T19:11:47Z

Double gets special special treatment in the mustache to prevent some errors like type 'int' is not a subtype of type 'double'.

openapi-generator/modules/openapi-generator/src/main/resources/dart2/class.mustache

Lines 75 to 82 in dad931a

{{#isDouble}} 
{{name}} = (json['{{baseName}}'] == null) ? 
 null : 
 json['{{baseName}}'].toDouble(); 
{{/isDouble}} 
{{^isDouble}} 
{{name}} = json['{{baseName}}']; 
{{/isDouble}} 

Dart has no floats so they are replaced with doubles. Before this fix, it wasn't the case inside the mustache file so the floats had the type double in the class, but not the code from the isDouble block inside the mustache because only isFloat was true.

PR checklist

Read the contribution guidelines.
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09) @athornz (2019/12) @amondnet (2019/12)

agilob · 2020-07-21T17:20:53Z

Can we get a test for it pls?

wing328 · 2020-07-30T01:54:27Z

 {{#isDouble}} {{name}} = (json['{{baseName}}'] == null) ? null : json['{{baseName}}'].toDouble(); {{/isDouble}} {{^isDouble}} {{name}} = json['{{baseName}}']; {{/isDouble}}

What about using {{#isNumber}} ... {{/isNumber}} instead, which returns true for both double and float?

sbu-WBT · 2020-07-30T10:26:05Z

Good idea, but would {{#isNumber}} ... {{/isNumber}} return true with an int? If not, I think it's the way to go @wing328

wing328 · 2020-07-30T10:39:24Z

isNumber will return false if it's integer or long.

FYI. isNumeric will return true if it's integer/long/double/float.

…uble-dart # Conflicts: # modules/openapi-generator/src/main/resources/dart2/class.mustache

sbu-WBT · 2020-07-30T13:23:17Z

@wing328 Replaced. I think the failing CI is not my fault because the master branch is also failing

wing328 · 2020-08-02T08:46:31Z

Shippable CI failure not related to this PR.

wing328 · 2020-08-02T08:47:37Z

LGTM. We'll add tests after the dart2 client is ready to make the switch to use fake petstore

* master: (121 commits) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108) [MARKDOWN] Fix issue 6089 with property and parameter names (#6105) [BUG] Multi-Part content type in response ignores properties of composed schema (allOf/oneOf) (#6073) [online] Fix for version conflicts with springfox/boot (#7102) skip some installations to shorten build time [Go][Exp] better code format (#7088) Fix Shippable CI (#7097) typescript-node: clean up require and import (#6947) commented out perl, bash tests to reduce build time Add a link to conference paper (#7086) Add a link to the blog post at qiita (#7084) migrate typescript.sh to new config format (#7078) ...

* master: [core] Add type and format properties to model of inline response (#6153) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108)

sbu-WBT · 2020-07-13T19:11:47Z

Double gets special special treatment in the mustache to prevent some errors like type 'int' is not a subtype of type 'double'.

openapi-generator/modules/openapi-generator/src/main/resources/dart2/class.mustache

Lines 75 to 82 in dad931a

{{#isDouble}} 
{{name}} = (json['{{baseName}}'] == null) ? 
 null : 
 json['{{baseName}}'].toDouble(); 
{{/isDouble}} 
{{^isDouble}} 
{{name}} = json['{{baseName}}']; 
{{/isDouble}} 

Dart has no floats so they are replaced with doubles. Before this fix, it wasn't the case inside the mustache file so the floats had the type double in the class, but not the code from the isDouble block inside the mustache because only isFloat was true.

PR checklist

Read the contribution guidelines.
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09) @athornz (2019/12) @amondnet (2019/12)

agilob · 2020-07-21T17:20:53Z

Can we get a test for it pls?

wing328 · 2020-07-30T01:54:27Z

 {{#isDouble}} {{name}} = (json['{{baseName}}'] == null) ? null : json['{{baseName}}'].toDouble(); {{/isDouble}} {{^isDouble}} {{name}} = json['{{baseName}}']; {{/isDouble}}

What about using {{#isNumber}} ... {{/isNumber}} instead, which returns true for both double and float?

sbu-WBT · 2020-07-30T10:26:05Z

Good idea, but would {{#isNumber}} ... {{/isNumber}} return true with an int? If not, I think it's the way to go @wing328

wing328 · 2020-07-30T10:39:24Z

isNumber will return false if it's integer or long.

FYI. isNumeric will return true if it's integer/long/double/float.

…uble-dart # Conflicts: # modules/openapi-generator/src/main/resources/dart2/class.mustache

sbu-WBT · 2020-07-30T13:23:17Z

@wing328 Replaced. I think the failing CI is not my fault because the master branch is also failing

wing328 · 2020-08-02T08:46:31Z

Shippable CI failure not related to this PR.

wing328 · 2020-08-02T08:47:37Z

LGTM. We'll add tests after the dart2 client is ready to make the switch to use fake petstore

* master: (121 commits) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108) [MARKDOWN] Fix issue 6089 with property and parameter names (#6105) [BUG] Multi-Part content type in response ignores properties of composed schema (allOf/oneOf) (#6073) [online] Fix for version conflicts with springfox/boot (#7102) skip some installations to shorten build time [Go][Exp] better code format (#7088) Fix Shippable CI (#7097) typescript-node: clean up require and import (#6947) commented out perl, bash tests to reduce build time Add a link to conference paper (#7086) Add a link to the blog post at qiita (#7084) migrate typescript.sh to new config format (#7078) ...

* master: [core] Add type and format properties to model of inline response (#6153) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108)

sbu-WBT · 2020-07-13T19:11:47Z

Double gets special special treatment in the mustache to prevent some errors like type 'int' is not a subtype of type 'double'.

openapi-generator/modules/openapi-generator/src/main/resources/dart2/class.mustache

Lines 75 to 82 in dad931a

{{#isDouble}} 
{{name}} = (json['{{baseName}}'] == null) ? 
 null : 
 json['{{baseName}}'].toDouble(); 
{{/isDouble}} 
{{^isDouble}} 
{{name}} = json['{{baseName}}']; 
{{/isDouble}} 

Dart has no floats so they are replaced with doubles. Before this fix, it wasn't the case inside the mustache file so the floats had the type double in the class, but not the code from the isDouble block inside the mustache because only isFloat was true.

PR checklist

Read the contribution guidelines.
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09) @athornz (2019/12) @amondnet (2019/12)

agilob · 2020-07-21T17:20:53Z

Can we get a test for it pls?

wing328 · 2020-07-30T01:54:27Z

 {{#isDouble}} {{name}} = (json['{{baseName}}'] == null) ? null : json['{{baseName}}'].toDouble(); {{/isDouble}} {{^isDouble}} {{name}} = json['{{baseName}}']; {{/isDouble}}

What about using {{#isNumber}} ... {{/isNumber}} instead, which returns true for both double and float?

sbu-WBT · 2020-07-30T10:26:05Z

Good idea, but would {{#isNumber}} ... {{/isNumber}} return true with an int? If not, I think it's the way to go @wing328

wing328 · 2020-07-30T10:39:24Z

isNumber will return false if it's integer or long.

FYI. isNumeric will return true if it's integer/long/double/float.

…uble-dart # Conflicts: # modules/openapi-generator/src/main/resources/dart2/class.mustache

sbu-WBT · 2020-07-30T13:23:17Z

@wing328 Replaced. I think the failing CI is not my fault because the master branch is also failing

wing328 · 2020-08-02T08:46:31Z

Shippable CI failure not related to this PR.

wing328 · 2020-08-02T08:47:37Z

LGTM. We'll add tests after the dart2 client is ready to make the switch to use fake petstore

* master: (121 commits) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108) [MARKDOWN] Fix issue 6089 with property and parameter names (#6105) [BUG] Multi-Part content type in response ignores properties of composed schema (allOf/oneOf) (#6073) [online] Fix for version conflicts with springfox/boot (#7102) skip some installations to shorten build time [Go][Exp] better code format (#7088) Fix Shippable CI (#7097) typescript-node: clean up require and import (#6947) commented out perl, bash tests to reduce build time Add a link to conference paper (#7086) Add a link to the blog post at qiita (#7084) migrate typescript.sh to new config format (#7078) ...

* master: [core] Add type and format properties to model of inline response (#6153) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108)

sbu-WBT · 2020-07-13T19:11:47Z

Double gets special special treatment in the mustache to prevent some errors like type 'int' is not a subtype of type 'double'.

openapi-generator/modules/openapi-generator/src/main/resources/dart2/class.mustache

Lines 75 to 82 in dad931a

{{#isDouble}} 
{{name}} = (json['{{baseName}}'] == null) ? 
 null : 
 json['{{baseName}}'].toDouble(); 
{{/isDouble}} 
{{^isDouble}} 
{{name}} = json['{{baseName}}']; 
{{/isDouble}} 

Dart has no floats so they are replaced with doubles. Before this fix, it wasn't the case inside the mustache file so the floats had the type double in the class, but not the code from the isDouble block inside the mustache because only isFloat was true.

PR checklist

Read the contribution guidelines.
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09) @athornz (2019/12) @amondnet (2019/12)

agilob · 2020-07-21T17:20:53Z

Can we get a test for it pls?

wing328 · 2020-07-30T01:54:27Z

 {{#isDouble}} {{name}} = (json['{{baseName}}'] == null) ? null : json['{{baseName}}'].toDouble(); {{/isDouble}} {{^isDouble}} {{name}} = json['{{baseName}}']; {{/isDouble}}

What about using {{#isNumber}} ... {{/isNumber}} instead, which returns true for both double and float?

sbu-WBT · 2020-07-30T10:26:05Z

Good idea, but would {{#isNumber}} ... {{/isNumber}} return true with an int? If not, I think it's the way to go @wing328

wing328 · 2020-07-30T10:39:24Z

isNumber will return false if it's integer or long.

FYI. isNumeric will return true if it's integer/long/double/float.

…uble-dart # Conflicts: # modules/openapi-generator/src/main/resources/dart2/class.mustache

sbu-WBT · 2020-07-30T13:23:17Z

@wing328 Replaced. I think the failing CI is not my fault because the master branch is also failing

wing328 · 2020-08-02T08:46:31Z

Shippable CI failure not related to this PR.

wing328 · 2020-08-02T08:47:37Z

LGTM. We'll add tests after the dart2 client is ready to make the switch to use fake petstore

* master: (121 commits) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108) [MARKDOWN] Fix issue 6089 with property and parameter names (#6105) [BUG] Multi-Part content type in response ignores properties of composed schema (allOf/oneOf) (#6073) [online] Fix for version conflicts with springfox/boot (#7102) skip some installations to shorten build time [Go][Exp] better code format (#7088) Fix Shippable CI (#7097) typescript-node: clean up require and import (#6947) commented out perl, bash tests to reduce build time Add a link to conference paper (#7086) Add a link to the blog post at qiita (#7084) migrate typescript.sh to new config format (#7078) ...

* master: [core] Add type and format properties to model of inline response (#6153) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108)

sbu-WBT · 2020-07-13T19:11:47Z

Double gets special special treatment in the mustache to prevent some errors like type 'int' is not a subtype of type 'double'.

openapi-generator/modules/openapi-generator/src/main/resources/dart2/class.mustache

Lines 75 to 82 in dad931a

{{#isDouble}} 
{{name}} = (json['{{baseName}}'] == null) ? 
 null : 
 json['{{baseName}}'].toDouble(); 
{{/isDouble}} 
{{^isDouble}} 
{{name}} = json['{{baseName}}']; 
{{/isDouble}} 

Dart has no floats so they are replaced with doubles. Before this fix, it wasn't the case inside the mustache file so the floats had the type double in the class, but not the code from the isDouble block inside the mustache because only isFloat was true.

PR checklist

Read the contribution guidelines.
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09) @athornz (2019/12) @amondnet (2019/12)

agilob · 2020-07-21T17:20:53Z

Can we get a test for it pls?

wing328 · 2020-07-30T01:54:27Z

 {{#isDouble}} {{name}} = (json['{{baseName}}'] == null) ? null : json['{{baseName}}'].toDouble(); {{/isDouble}} {{^isDouble}} {{name}} = json['{{baseName}}']; {{/isDouble}}

What about using {{#isNumber}} ... {{/isNumber}} instead, which returns true for both double and float?

sbu-WBT · 2020-07-30T10:26:05Z

Good idea, but would {{#isNumber}} ... {{/isNumber}} return true with an int? If not, I think it's the way to go @wing328

wing328 · 2020-07-30T10:39:24Z

isNumber will return false if it's integer or long.

FYI. isNumeric will return true if it's integer/long/double/float.

…uble-dart # Conflicts: # modules/openapi-generator/src/main/resources/dart2/class.mustache

sbu-WBT · 2020-07-30T13:23:17Z

@wing328 Replaced. I think the failing CI is not my fault because the master branch is also failing

wing328 · 2020-08-02T08:46:31Z

Shippable CI failure not related to this PR.

wing328 · 2020-08-02T08:47:37Z

LGTM. We'll add tests after the dart2 client is ready to make the switch to use fake petstore

* master: (121 commits) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108) [MARKDOWN] Fix issue 6089 with property and parameter names (#6105) [BUG] Multi-Part content type in response ignores properties of composed schema (allOf/oneOf) (#6073) [online] Fix for version conflicts with springfox/boot (#7102) skip some installations to shorten build time [Go][Exp] better code format (#7088) Fix Shippable CI (#7097) typescript-node: clean up require and import (#6947) commented out perl, bash tests to reduce build time Add a link to conference paper (#7086) Add a link to the blog post at qiita (#7084) migrate typescript.sh to new config format (#7078) ...

* master: [core] Add type and format properties to model of inline response (#6153) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108)

[Dart] Treat float as double
5c73334

wing328 added Client: Dart Enhancement: General labels Jul 30, 2020

sbu-WBT added 2 commits July 30, 2020 14:14

[Dart] Treat float as double in mustache with isNumber
73d3e1e

Merge remote-tracking branch 'upstream/master' into treat-float-as-do…
46cd57d
…uble-dart # Conflicts: # modules/openapi-generator/src/main/resources/dart2/class.mustache

wing328 merged commit 647d253 into OpenAPITools:masterAug 2, 2020

wing328 added this to the 5.0.0 milestone Aug 2, 2020

sbu-WBT deleted the treat-float-as-double-dart branch August 9, 2020 18:21

[Dart] Treat float as double
5c73334

wing328 added Client: Dart Enhancement: General labels Jul 30, 2020

sbu-WBT added 2 commits July 30, 2020 14:14

[Dart] Treat float as double in mustache with isNumber
73d3e1e

Merge remote-tracking branch 'upstream/master' into treat-float-as-do…
46cd57d
…uble-dart # Conflicts: # modules/openapi-generator/src/main/resources/dart2/class.mustache

wing328 merged commit 647d253 into OpenAPITools:masterAug 2, 2020

wing328 added this to the 5.0.0 milestone Aug 2, 2020

sbu-WBT deleted the treat-float-as-double-dart branch August 9, 2020 18:21

[Dart] Treat float as double
5c73334

wing328 added Client: Dart Enhancement: General labels Jul 30, 2020

sbu-WBT added 2 commits July 30, 2020 14:14

[Dart] Treat float as double in mustache with isNumber
73d3e1e

Merge remote-tracking branch 'upstream/master' into treat-float-as-do…
46cd57d
…uble-dart # Conflicts: # modules/openapi-generator/src/main/resources/dart2/class.mustache

wing328 merged commit 647d253 into OpenAPITools:masterAug 2, 2020

wing328 added this to the 5.0.0 milestone Aug 2, 2020

sbu-WBT deleted the treat-float-as-double-dart branch August 9, 2020 18:21

[Dart] Treat float as double
5c73334

wing328 added Client: Dart Enhancement: General labels Jul 30, 2020

sbu-WBT added 2 commits July 30, 2020 14:14

[Dart] Treat float as double in mustache with isNumber
73d3e1e

Merge remote-tracking branch 'upstream/master' into treat-float-as-do…
46cd57d
…uble-dart # Conflicts: # modules/openapi-generator/src/main/resources/dart2/class.mustache

wing328 merged commit 647d253 into OpenAPITools:masterAug 2, 2020

wing328 added this to the 5.0.0 milestone Aug 2, 2020

sbu-WBT deleted the treat-float-as-double-dart branch August 9, 2020 18:21

[Dart] Treat float as double
5c73334

wing328 added Client: Dart Enhancement: General labels Jul 30, 2020

sbu-WBT added 2 commits July 30, 2020 14:14

[Dart] Treat float as double in mustache with isNumber
73d3e1e

Merge remote-tracking branch 'upstream/master' into treat-float-as-do…
46cd57d
…uble-dart # Conflicts: # modules/openapi-generator/src/main/resources/dart2/class.mustache

wing328 merged commit 647d253 into OpenAPITools:masterAug 2, 2020

wing328 added this to the 5.0.0 milestone Aug 2, 2020

sbu-WBT deleted the treat-float-as-double-dart branch August 9, 2020 18:21

[Dart] Treat float as double
5c73334

wing328 added Client: Dart Enhancement: General labels Jul 30, 2020

sbu-WBT added 2 commits July 30, 2020 14:14

[Dart] Treat float as double in mustache with isNumber
73d3e1e

Merge remote-tracking branch 'upstream/master' into treat-float-as-do…
46cd57d
…uble-dart # Conflicts: # modules/openapi-generator/src/main/resources/dart2/class.mustache

wing328 merged commit 647d253 into OpenAPITools:masterAug 2, 2020

wing328 added this to the 5.0.0 milestone Aug 2, 2020

sbu-WBT deleted the treat-float-as-double-dart branch August 9, 2020 18:21

[Dart] Treat float as double
5c73334

wing328 added Client: Dart Enhancement: General labels Jul 30, 2020

sbu-WBT added 2 commits July 30, 2020 14:14

[Dart] Treat float as double in mustache with isNumber
73d3e1e

Merge remote-tracking branch 'upstream/master' into treat-float-as-do…
46cd57d
…uble-dart # Conflicts: # modules/openapi-generator/src/main/resources/dart2/class.mustache

wing328 merged commit 647d253 into OpenAPITools:masterAug 2, 2020

wing328 added this to the 5.0.0 milestone Aug 2, 2020

sbu-WBT deleted the treat-float-as-double-dart branch August 9, 2020 18:21

[Dart] Treat float as double
5c73334

wing328 added Client: Dart Enhancement: General labels Jul 30, 2020

sbu-WBT added 2 commits July 30, 2020 14:14

[Dart] Treat float as double in mustache with isNumber
73d3e1e

Merge remote-tracking branch 'upstream/master' into treat-float-as-do…
46cd57d
…uble-dart # Conflicts: # modules/openapi-generator/src/main/resources/dart2/class.mustache

wing328 merged commit 647d253 into OpenAPITools:masterAug 2, 2020

wing328 added this to the 5.0.0 milestone Aug 2, 2020

sbu-WBT deleted the treat-float-as-double-dart branch August 9, 2020 18:21

	{{#isDouble}}
	{{name}} = (json['{{baseName}}'] == null) ?
	null :
	json['{{baseName}}'].toDouble();
	{{/isDouble}}
	{{^isDouble}}
	{{name}} = json['{{baseName}}'];
	{{/isDouble}}

Uh oh!

Uh oh!

Conversation

sbu-WBT commented Jul 13, 2020

PR checklist

Uh oh!

agilob commented Jul 21, 2020

Uh oh!

wing328 commented Jul 30, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sbu-WBT commented Jul 30, 2020

Uh oh!

wing328 commented Jul 30, 2020

Uh oh!

sbu-WBT commented Jul 30, 2020

Uh oh!

wing328 commented Aug 2, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wing328 commented Aug 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

sbu-WBT commented Jul 13, 2020

PR checklist

Uh oh!

agilob commented Jul 21, 2020

Uh oh!

wing328 commented Jul 30, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sbu-WBT commented Jul 30, 2020

Uh oh!

wing328 commented Jul 30, 2020

Uh oh!

sbu-WBT commented Jul 30, 2020

Uh oh!

wing328 commented Aug 2, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wing328 commented Aug 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

sbu-WBT commented Jul 13, 2020

PR checklist

Uh oh!

agilob commented Jul 21, 2020

Uh oh!

wing328 commented Jul 30, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sbu-WBT commented Jul 30, 2020

Uh oh!

wing328 commented Jul 30, 2020

Uh oh!

sbu-WBT commented Jul 30, 2020

Uh oh!

wing328 commented Aug 2, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wing328 commented Jul 30, 2020•
edited
Loading

wing328 commented Aug 2, 2020•
edited
Loading

wing328 commented Jul 30, 2020•
edited
Loading

wing328 commented Aug 2, 2020•
edited
Loading

wing328 commented Jul 30, 2020•
edited
Loading

wing328 commented Aug 2, 2020•
edited
Loading

wing328 commented Jul 30, 2020•
edited
Loading

wing328 commented Aug 2, 2020•
edited
Loading