typescript-node: clean up require and import by laubfall · Pull Request #6947 · OpenAPITools/openapi-generator

laubfall · 2020-07-15T14:28:05Z

… instead of import statement

Resolves[BUG] typescript-node mixes require and import #4656
Fixed broken link in CONTRIBUTING.md

PR checklist

Read the contribution guidelines.
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

… instead of import statement

macjohnny

LGTM

DanielRuf · 2020-07-15T16:32:55Z

+import http from 'http';
+{{/supportsES6}}
+{{^supportsES6}}
 import localVarRequest = require('request');


The import var = require does not make much sense to me. This should be probably const localVarRequest = require('request').
Or did I oversee something?

Same for the other parts.

Yeah thats right, i'll fix it :)

I'm getting some typescript errors with const http = require. These are "TS2503: Cannot find namespace 'http'." and "error TS4055: Return type of public method from exported class has or is using private name 'http'.". As described here: https://stackoverflow.com/questions/31173738/typescript-getting-error-ts2304-cannot-find-name-require there are some ways to make this work, but to be honest i don't see a reason why to make a difference at this point. All other modules are imported with the "import .. from" stmt independent of the ES6 flag. So i removed the switch and changed the tsconfig to make the imports http/request work. What do you think about this solution?

For TypeScript to use these you need the types for the Nodejs internal ones. Basically @types/node.

The current solution should be fine.

DanielRuf · 2020-07-15T16:34:37Z

[ x]

You might want to remove the space inside the square brackets (it is either a space or x as single character) ;-)

macjohnny · 2020-07-16T13:36:53Z

@laubfall could you please fix the CI issues?

DanielRuf

See my remarks / comments =)

wing328 · 2020-07-28T02:37:52Z

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

wing328 · 2020-07-28T02:38:13Z

I just pushed 547e305 to fix the CI failure. Let's see how that goes.

DanielRuf · 2020-07-28T06:46:43Z

-model/pet.ts
-model/tag.ts
-model/user.ts
+model/./apiResponse.ts


Why this change? ./ makes not much sense in my opinion.

Agreed ./ is not needed. We'll tackle it separately.

Ok, so there is nothing left here to todo for the PR?

laubfall · 2020-07-31T09:26:24Z

I just pushed 547e305 to fix the CI failure. Let's see how that goes.

Thanks, i looked into the CI Failure but did not saw the reason why the build failed

wing328 · 2020-07-31T09:58:38Z

Shippable CI failure not related to this PR.

* master: (121 commits) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108) [MARKDOWN] Fix issue 6089 with property and parameter names (#6105) [BUG] Multi-Part content type in response ignores properties of composed schema (allOf/oneOf) (#6073) [online] Fix for version conflicts with springfox/boot (#7102) skip some installations to shorten build time [Go][Exp] better code format (#7088) Fix Shippable CI (#7097) typescript-node: clean up require and import (#6947) commented out perl, bash tests to reduce build time Add a link to conference paper (#7086) Add a link to the blog post at qiita (#7084) migrate typescript.sh to new config format (#7078) ...

laubfall · 2020-07-15T14:28:05Z

… instead of import statement

Resolves[BUG] typescript-node mixes require and import #4656
Fixed broken link in CONTRIBUTING.md

PR checklist

Read the contribution guidelines.
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

… instead of import statement

macjohnny

LGTM

DanielRuf · 2020-07-15T16:32:55Z

+import http from 'http';
+{{/supportsES6}}
+{{^supportsES6}}
 import localVarRequest = require('request');


The import var = require does not make much sense to me. This should be probably const localVarRequest = require('request').
Or did I oversee something?

Same for the other parts.

Yeah thats right, i'll fix it :)

I'm getting some typescript errors with const http = require. These are "TS2503: Cannot find namespace 'http'." and "error TS4055: Return type of public method from exported class has or is using private name 'http'.". As described here: https://stackoverflow.com/questions/31173738/typescript-getting-error-ts2304-cannot-find-name-require there are some ways to make this work, but to be honest i don't see a reason why to make a difference at this point. All other modules are imported with the "import .. from" stmt independent of the ES6 flag. So i removed the switch and changed the tsconfig to make the imports http/request work. What do you think about this solution?

For TypeScript to use these you need the types for the Nodejs internal ones. Basically @types/node.

The current solution should be fine.

DanielRuf · 2020-07-15T16:34:37Z

[ x]

You might want to remove the space inside the square brackets (it is either a space or x as single character) ;-)

macjohnny · 2020-07-16T13:36:53Z

@laubfall could you please fix the CI issues?

DanielRuf

See my remarks / comments =)

wing328 · 2020-07-28T02:37:52Z

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

wing328 · 2020-07-28T02:38:13Z

I just pushed 547e305 to fix the CI failure. Let's see how that goes.

DanielRuf · 2020-07-28T06:46:43Z

-model/pet.ts
-model/tag.ts
-model/user.ts
+model/./apiResponse.ts


Why this change? ./ makes not much sense in my opinion.

Agreed ./ is not needed. We'll tackle it separately.

Ok, so there is nothing left here to todo for the PR?

laubfall · 2020-07-31T09:26:24Z

I just pushed 547e305 to fix the CI failure. Let's see how that goes.

Thanks, i looked into the CI Failure but did not saw the reason why the build failed

wing328 · 2020-07-31T09:58:38Z

Shippable CI failure not related to this PR.

* master: (121 commits) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108) [MARKDOWN] Fix issue 6089 with property and parameter names (#6105) [BUG] Multi-Part content type in response ignores properties of composed schema (allOf/oneOf) (#6073) [online] Fix for version conflicts with springfox/boot (#7102) skip some installations to shorten build time [Go][Exp] better code format (#7088) Fix Shippable CI (#7097) typescript-node: clean up require and import (#6947) commented out perl, bash tests to reduce build time Add a link to conference paper (#7086) Add a link to the blog post at qiita (#7084) migrate typescript.sh to new config format (#7078) ...

laubfall · 2020-07-15T14:28:05Z

… instead of import statement

Resolves[BUG] typescript-node mixes require and import #4656
Fixed broken link in CONTRIBUTING.md

PR checklist

Read the contribution guidelines.
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

… instead of import statement

macjohnny

LGTM

DanielRuf · 2020-07-15T16:32:55Z

+import http from 'http';
+{{/supportsES6}}
+{{^supportsES6}}
 import localVarRequest = require('request');


The import var = require does not make much sense to me. This should be probably const localVarRequest = require('request').
Or did I oversee something?

Same for the other parts.

Yeah thats right, i'll fix it :)

I'm getting some typescript errors with const http = require. These are "TS2503: Cannot find namespace 'http'." and "error TS4055: Return type of public method from exported class has or is using private name 'http'.". As described here: https://stackoverflow.com/questions/31173738/typescript-getting-error-ts2304-cannot-find-name-require there are some ways to make this work, but to be honest i don't see a reason why to make a difference at this point. All other modules are imported with the "import .. from" stmt independent of the ES6 flag. So i removed the switch and changed the tsconfig to make the imports http/request work. What do you think about this solution?

For TypeScript to use these you need the types for the Nodejs internal ones. Basically @types/node.

The current solution should be fine.

DanielRuf · 2020-07-15T16:34:37Z

[ x]

You might want to remove the space inside the square brackets (it is either a space or x as single character) ;-)

macjohnny · 2020-07-16T13:36:53Z

@laubfall could you please fix the CI issues?

DanielRuf

See my remarks / comments =)

wing328 · 2020-07-28T02:37:52Z

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

wing328 · 2020-07-28T02:38:13Z

I just pushed 547e305 to fix the CI failure. Let's see how that goes.

DanielRuf · 2020-07-28T06:46:43Z

-model/pet.ts
-model/tag.ts
-model/user.ts
+model/./apiResponse.ts


Why this change? ./ makes not much sense in my opinion.

Agreed ./ is not needed. We'll tackle it separately.

Ok, so there is nothing left here to todo for the PR?

laubfall · 2020-07-31T09:26:24Z

I just pushed 547e305 to fix the CI failure. Let's see how that goes.

Thanks, i looked into the CI Failure but did not saw the reason why the build failed

wing328 · 2020-07-31T09:58:38Z

Shippable CI failure not related to this PR.

* master: (121 commits) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108) [MARKDOWN] Fix issue 6089 with property and parameter names (#6105) [BUG] Multi-Part content type in response ignores properties of composed schema (allOf/oneOf) (#6073) [online] Fix for version conflicts with springfox/boot (#7102) skip some installations to shorten build time [Go][Exp] better code format (#7088) Fix Shippable CI (#7097) typescript-node: clean up require and import (#6947) commented out perl, bash tests to reduce build time Add a link to conference paper (#7086) Add a link to the blog post at qiita (#7084) migrate typescript.sh to new config format (#7078) ...

laubfall · 2020-07-15T14:28:05Z

… instead of import statement

Resolves[BUG] typescript-node mixes require and import #4656
Fixed broken link in CONTRIBUTING.md

PR checklist

Read the contribution guidelines.
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

… instead of import statement

macjohnny

LGTM

DanielRuf · 2020-07-15T16:32:55Z

+import http from 'http';
+{{/supportsES6}}
+{{^supportsES6}}
 import localVarRequest = require('request');


The import var = require does not make much sense to me. This should be probably const localVarRequest = require('request').
Or did I oversee something?

Same for the other parts.

Yeah thats right, i'll fix it :)

I'm getting some typescript errors with const http = require. These are "TS2503: Cannot find namespace 'http'." and "error TS4055: Return type of public method from exported class has or is using private name 'http'.". As described here: https://stackoverflow.com/questions/31173738/typescript-getting-error-ts2304-cannot-find-name-require there are some ways to make this work, but to be honest i don't see a reason why to make a difference at this point. All other modules are imported with the "import .. from" stmt independent of the ES6 flag. So i removed the switch and changed the tsconfig to make the imports http/request work. What do you think about this solution?

For TypeScript to use these you need the types for the Nodejs internal ones. Basically @types/node.

The current solution should be fine.

DanielRuf · 2020-07-15T16:34:37Z

[ x]

You might want to remove the space inside the square brackets (it is either a space or x as single character) ;-)

macjohnny · 2020-07-16T13:36:53Z

@laubfall could you please fix the CI issues?

DanielRuf

See my remarks / comments =)

wing328 · 2020-07-28T02:37:52Z

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

wing328 · 2020-07-28T02:38:13Z

I just pushed 547e305 to fix the CI failure. Let's see how that goes.

DanielRuf · 2020-07-28T06:46:43Z

-model/pet.ts
-model/tag.ts
-model/user.ts
+model/./apiResponse.ts


Why this change? ./ makes not much sense in my opinion.

Agreed ./ is not needed. We'll tackle it separately.

Ok, so there is nothing left here to todo for the PR?

laubfall · 2020-07-31T09:26:24Z

I just pushed 547e305 to fix the CI failure. Let's see how that goes.

Thanks, i looked into the CI Failure but did not saw the reason why the build failed

wing328 · 2020-07-31T09:58:38Z

Shippable CI failure not related to this PR.

* master: (121 commits) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108) [MARKDOWN] Fix issue 6089 with property and parameter names (#6105) [BUG] Multi-Part content type in response ignores properties of composed schema (allOf/oneOf) (#6073) [online] Fix for version conflicts with springfox/boot (#7102) skip some installations to shorten build time [Go][Exp] better code format (#7088) Fix Shippable CI (#7097) typescript-node: clean up require and import (#6947) commented out perl, bash tests to reduce build time Add a link to conference paper (#7086) Add a link to the blog post at qiita (#7084) migrate typescript.sh to new config format (#7078) ...

laubfall · 2020-07-15T14:28:05Z

… instead of import statement

Resolves[BUG] typescript-node mixes require and import #4656
Fixed broken link in CONTRIBUTING.md

PR checklist

Read the contribution guidelines.
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

… instead of import statement

macjohnny

LGTM

DanielRuf · 2020-07-15T16:32:55Z

+import http from 'http';
+{{/supportsES6}}
+{{^supportsES6}}
 import localVarRequest = require('request');


The import var = require does not make much sense to me. This should be probably const localVarRequest = require('request').
Or did I oversee something?

Same for the other parts.

Yeah thats right, i'll fix it :)

I'm getting some typescript errors with const http = require. These are "TS2503: Cannot find namespace 'http'." and "error TS4055: Return type of public method from exported class has or is using private name 'http'.". As described here: https://stackoverflow.com/questions/31173738/typescript-getting-error-ts2304-cannot-find-name-require there are some ways to make this work, but to be honest i don't see a reason why to make a difference at this point. All other modules are imported with the "import .. from" stmt independent of the ES6 flag. So i removed the switch and changed the tsconfig to make the imports http/request work. What do you think about this solution?

For TypeScript to use these you need the types for the Nodejs internal ones. Basically @types/node.

The current solution should be fine.

DanielRuf · 2020-07-15T16:34:37Z

[ x]

You might want to remove the space inside the square brackets (it is either a space or x as single character) ;-)

macjohnny · 2020-07-16T13:36:53Z

@laubfall could you please fix the CI issues?

DanielRuf

See my remarks / comments =)

wing328 · 2020-07-28T02:37:52Z

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

wing328 · 2020-07-28T02:38:13Z

I just pushed 547e305 to fix the CI failure. Let's see how that goes.

DanielRuf · 2020-07-28T06:46:43Z

-model/pet.ts
-model/tag.ts
-model/user.ts
+model/./apiResponse.ts


Why this change? ./ makes not much sense in my opinion.

Agreed ./ is not needed. We'll tackle it separately.

Ok, so there is nothing left here to todo for the PR?

laubfall · 2020-07-31T09:26:24Z

I just pushed 547e305 to fix the CI failure. Let's see how that goes.

Thanks, i looked into the CI Failure but did not saw the reason why the build failed

wing328 · 2020-07-31T09:58:38Z

Shippable CI failure not related to this PR.

* master: (121 commits) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108) [MARKDOWN] Fix issue 6089 with property and parameter names (#6105) [BUG] Multi-Part content type in response ignores properties of composed schema (allOf/oneOf) (#6073) [online] Fix for version conflicts with springfox/boot (#7102) skip some installations to shorten build time [Go][Exp] better code format (#7088) Fix Shippable CI (#7097) typescript-node: clean up require and import (#6947) commented out perl, bash tests to reduce build time Add a link to conference paper (#7086) Add a link to the blog post at qiita (#7084) migrate typescript.sh to new config format (#7078) ...

laubfall · 2020-07-15T14:28:05Z

… instead of import statement

Resolves[BUG] typescript-node mixes require and import #4656
Fixed broken link in CONTRIBUTING.md

PR checklist

Read the contribution guidelines.
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

… instead of import statement

macjohnny

LGTM

DanielRuf · 2020-07-15T16:32:55Z

+import http from 'http';
+{{/supportsES6}}
+{{^supportsES6}}
 import localVarRequest = require('request');


The import var = require does not make much sense to me. This should be probably const localVarRequest = require('request').
Or did I oversee something?

Same for the other parts.

Yeah thats right, i'll fix it :)

I'm getting some typescript errors with const http = require. These are "TS2503: Cannot find namespace 'http'." and "error TS4055: Return type of public method from exported class has or is using private name 'http'.". As described here: https://stackoverflow.com/questions/31173738/typescript-getting-error-ts2304-cannot-find-name-require there are some ways to make this work, but to be honest i don't see a reason why to make a difference at this point. All other modules are imported with the "import .. from" stmt independent of the ES6 flag. So i removed the switch and changed the tsconfig to make the imports http/request work. What do you think about this solution?

For TypeScript to use these you need the types for the Nodejs internal ones. Basically @types/node.

The current solution should be fine.

DanielRuf · 2020-07-15T16:34:37Z

[ x]

You might want to remove the space inside the square brackets (it is either a space or x as single character) ;-)

macjohnny · 2020-07-16T13:36:53Z

@laubfall could you please fix the CI issues?

DanielRuf

See my remarks / comments =)

wing328 · 2020-07-28T02:37:52Z

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

wing328 · 2020-07-28T02:38:13Z

I just pushed 547e305 to fix the CI failure. Let's see how that goes.

DanielRuf · 2020-07-28T06:46:43Z

-model/pet.ts
-model/tag.ts
-model/user.ts
+model/./apiResponse.ts


Why this change? ./ makes not much sense in my opinion.

Agreed ./ is not needed. We'll tackle it separately.

Ok, so there is nothing left here to todo for the PR?

laubfall · 2020-07-31T09:26:24Z

I just pushed 547e305 to fix the CI failure. Let's see how that goes.

Thanks, i looked into the CI Failure but did not saw the reason why the build failed

wing328 · 2020-07-31T09:58:38Z

Shippable CI failure not related to this PR.

* master: (121 commits) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108) [MARKDOWN] Fix issue 6089 with property and parameter names (#6105) [BUG] Multi-Part content type in response ignores properties of composed schema (allOf/oneOf) (#6073) [online] Fix for version conflicts with springfox/boot (#7102) skip some installations to shorten build time [Go][Exp] better code format (#7088) Fix Shippable CI (#7097) typescript-node: clean up require and import (#6947) commented out perl, bash tests to reduce build time Add a link to conference paper (#7086) Add a link to the blog post at qiita (#7084) migrate typescript.sh to new config format (#7078) ...

laubfall · 2020-07-15T14:28:05Z

… instead of import statement

Resolves[BUG] typescript-node mixes require and import #4656
Fixed broken link in CONTRIBUTING.md

PR checklist

Read the contribution guidelines.
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

… instead of import statement

macjohnny

LGTM

DanielRuf · 2020-07-15T16:32:55Z

+import http from 'http';
+{{/supportsES6}}
+{{^supportsES6}}
 import localVarRequest = require('request');


The import var = require does not make much sense to me. This should be probably const localVarRequest = require('request').
Or did I oversee something?

Same for the other parts.

Yeah thats right, i'll fix it :)

I'm getting some typescript errors with const http = require. These are "TS2503: Cannot find namespace 'http'." and "error TS4055: Return type of public method from exported class has or is using private name 'http'.". As described here: https://stackoverflow.com/questions/31173738/typescript-getting-error-ts2304-cannot-find-name-require there are some ways to make this work, but to be honest i don't see a reason why to make a difference at this point. All other modules are imported with the "import .. from" stmt independent of the ES6 flag. So i removed the switch and changed the tsconfig to make the imports http/request work. What do you think about this solution?

For TypeScript to use these you need the types for the Nodejs internal ones. Basically @types/node.

The current solution should be fine.

DanielRuf · 2020-07-15T16:34:37Z

[ x]

You might want to remove the space inside the square brackets (it is either a space or x as single character) ;-)

macjohnny · 2020-07-16T13:36:53Z

@laubfall could you please fix the CI issues?

DanielRuf

See my remarks / comments =)

wing328 · 2020-07-28T02:37:52Z

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

wing328 · 2020-07-28T02:38:13Z

I just pushed 547e305 to fix the CI failure. Let's see how that goes.

DanielRuf · 2020-07-28T06:46:43Z

-model/pet.ts
-model/tag.ts
-model/user.ts
+model/./apiResponse.ts


Why this change? ./ makes not much sense in my opinion.

Agreed ./ is not needed. We'll tackle it separately.

Ok, so there is nothing left here to todo for the PR?

laubfall · 2020-07-31T09:26:24Z

I just pushed 547e305 to fix the CI failure. Let's see how that goes.

Thanks, i looked into the CI Failure but did not saw the reason why the build failed

wing328 · 2020-07-31T09:58:38Z

Shippable CI failure not related to this PR.

* master: (121 commits) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108) [MARKDOWN] Fix issue 6089 with property and parameter names (#6105) [BUG] Multi-Part content type in response ignores properties of composed schema (allOf/oneOf) (#6073) [online] Fix for version conflicts with springfox/boot (#7102) skip some installations to shorten build time [Go][Exp] better code format (#7088) Fix Shippable CI (#7097) typescript-node: clean up require and import (#6947) commented out perl, bash tests to reduce build time Add a link to conference paper (#7086) Add a link to the blog post at qiita (#7084) migrate typescript.sh to new config format (#7078) ...

laubfall · 2020-07-15T14:28:05Z

… instead of import statement

Resolves[BUG] typescript-node mixes require and import #4656
Fixed broken link in CONTRIBUTING.md

PR checklist

Read the contribution guidelines.
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

… instead of import statement

macjohnny

LGTM

DanielRuf · 2020-07-15T16:32:55Z

+import http from 'http';
+{{/supportsES6}}
+{{^supportsES6}}
 import localVarRequest = require('request');


The import var = require does not make much sense to me. This should be probably const localVarRequest = require('request').
Or did I oversee something?

Same for the other parts.

Yeah thats right, i'll fix it :)

I'm getting some typescript errors with const http = require. These are "TS2503: Cannot find namespace 'http'." and "error TS4055: Return type of public method from exported class has or is using private name 'http'.". As described here: https://stackoverflow.com/questions/31173738/typescript-getting-error-ts2304-cannot-find-name-require there are some ways to make this work, but to be honest i don't see a reason why to make a difference at this point. All other modules are imported with the "import .. from" stmt independent of the ES6 flag. So i removed the switch and changed the tsconfig to make the imports http/request work. What do you think about this solution?

For TypeScript to use these you need the types for the Nodejs internal ones. Basically @types/node.

The current solution should be fine.

DanielRuf · 2020-07-15T16:34:37Z

[ x]

You might want to remove the space inside the square brackets (it is either a space or x as single character) ;-)

macjohnny · 2020-07-16T13:36:53Z

@laubfall could you please fix the CI issues?

DanielRuf

See my remarks / comments =)

wing328 · 2020-07-28T02:37:52Z

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

wing328 · 2020-07-28T02:38:13Z

I just pushed 547e305 to fix the CI failure. Let's see how that goes.

DanielRuf · 2020-07-28T06:46:43Z

-model/pet.ts
-model/tag.ts
-model/user.ts
+model/./apiResponse.ts


Why this change? ./ makes not much sense in my opinion.

Agreed ./ is not needed. We'll tackle it separately.

Ok, so there is nothing left here to todo for the PR?

laubfall · 2020-07-31T09:26:24Z

I just pushed 547e305 to fix the CI failure. Let's see how that goes.

Thanks, i looked into the CI Failure but did not saw the reason why the build failed

wing328 · 2020-07-31T09:58:38Z

Shippable CI failure not related to this PR.

* master: (121 commits) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108) [MARKDOWN] Fix issue 6089 with property and parameter names (#6105) [BUG] Multi-Part content type in response ignores properties of composed schema (allOf/oneOf) (#6073) [online] Fix for version conflicts with springfox/boot (#7102) skip some installations to shorten build time [Go][Exp] better code format (#7088) Fix Shippable CI (#7097) typescript-node: clean up require and import (#6947) commented out perl, bash tests to reduce build time Add a link to conference paper (#7086) Add a link to the blog post at qiita (#7084) migrate typescript.sh to new config format (#7078) ...

laubfall added 5 commits July 15, 2020 11:22

Fix for issue 4656 typescript-node generate invalid require statement…
0f96c39
… instead of import statement

Fixed broken link under testing templates
0b1d179

Result of run generate-samples.sh / typescript-node*
dd86be3

import stmt depending on flag supportsES6
b03d632

Update petstore sample for typescript-node
660e78c

laubfall mentioned this pull request Jul 15, 2020
[BUG] typescript-node mixes require and import #4656
Closed
6 tasks

macjohnny changed the title ~~Typescript node mixes require and import 4656~~typescript-node: clean up require and importJul 15, 2020

macjohnny approved these changes Jul 15, 2020
View reviewed changes

macjohnny added the Client: TypeScript label Jul 15, 2020

macjohnny added this to the 5.0.0 milestone Jul 15, 2020

DanielRuf reviewed Jul 15, 2020
View reviewed changes

DanielRuf suggested changes Jul 16, 2020
View reviewed changes

laubfalland others added 2 commits July 27, 2020 11:00

import ... from stmt for http/request module
ad3cde0

update samples
547e305

DanielRuf reviewed Jul 28, 2020
View reviewed changes

wing328 added the Enhancement: General label Jul 30, 2020

update doc
b09227c

wing328 merged commit b838e18 into OpenAPITools:masterJul 31, 2020

laubfall added 5 commits July 15, 2020 11:22

Fix for issue 4656 typescript-node generate invalid require statement…
0f96c39
… instead of import statement

Fixed broken link under testing templates
0b1d179

Result of run generate-samples.sh / typescript-node*
dd86be3

import stmt depending on flag supportsES6
b03d632

Update petstore sample for typescript-node
660e78c

laubfall mentioned this pull request Jul 15, 2020
[BUG] typescript-node mixes require and import #4656
Closed
6 tasks

macjohnny changed the title ~~Typescript node mixes require and import 4656~~typescript-node: clean up require and importJul 15, 2020

macjohnny approved these changes Jul 15, 2020
View reviewed changes

macjohnny added the Client: TypeScript label Jul 15, 2020

macjohnny added this to the 5.0.0 milestone Jul 15, 2020

DanielRuf reviewed Jul 15, 2020
View reviewed changes

DanielRuf suggested changes Jul 16, 2020
View reviewed changes

laubfalland others added 2 commits July 27, 2020 11:00

import ... from stmt for http/request module
ad3cde0

update samples
547e305

DanielRuf reviewed Jul 28, 2020
View reviewed changes

wing328 added the Enhancement: General label Jul 30, 2020

update doc
b09227c

wing328 merged commit b838e18 into OpenAPITools:masterJul 31, 2020

laubfall added 5 commits July 15, 2020 11:22

Fix for issue 4656 typescript-node generate invalid require statement…
0f96c39
… instead of import statement

Fixed broken link under testing templates
0b1d179

Result of run generate-samples.sh / typescript-node*
dd86be3

import stmt depending on flag supportsES6
b03d632

Update petstore sample for typescript-node
660e78c

laubfall mentioned this pull request Jul 15, 2020
[BUG] typescript-node mixes require and import #4656
Closed
6 tasks

macjohnny changed the title ~~Typescript node mixes require and import 4656~~typescript-node: clean up require and importJul 15, 2020

macjohnny approved these changes Jul 15, 2020
View reviewed changes

macjohnny added the Client: TypeScript label Jul 15, 2020

macjohnny added this to the 5.0.0 milestone Jul 15, 2020

DanielRuf reviewed Jul 15, 2020
View reviewed changes

DanielRuf suggested changes Jul 16, 2020
View reviewed changes

laubfalland others added 2 commits July 27, 2020 11:00

import ... from stmt for http/request module
ad3cde0

update samples
547e305

DanielRuf reviewed Jul 28, 2020
View reviewed changes

wing328 added the Enhancement: General label Jul 30, 2020

update doc
b09227c

wing328 merged commit b838e18 into OpenAPITools:masterJul 31, 2020

laubfall added 5 commits July 15, 2020 11:22

Fix for issue 4656 typescript-node generate invalid require statement…
0f96c39
… instead of import statement

Fixed broken link under testing templates
0b1d179

Result of run generate-samples.sh / typescript-node*
dd86be3

import stmt depending on flag supportsES6
b03d632

Update petstore sample for typescript-node
660e78c

laubfall mentioned this pull request Jul 15, 2020
[BUG] typescript-node mixes require and import #4656
Closed
6 tasks

macjohnny changed the title ~~Typescript node mixes require and import 4656~~typescript-node: clean up require and importJul 15, 2020

macjohnny approved these changes Jul 15, 2020
View reviewed changes

macjohnny added the Client: TypeScript label Jul 15, 2020

macjohnny added this to the 5.0.0 milestone Jul 15, 2020

DanielRuf reviewed Jul 15, 2020
View reviewed changes

DanielRuf suggested changes Jul 16, 2020
View reviewed changes

laubfalland others added 2 commits July 27, 2020 11:00

import ... from stmt for http/request module
ad3cde0

update samples
547e305

DanielRuf reviewed Jul 28, 2020
View reviewed changes

wing328 added the Enhancement: General label Jul 30, 2020

update doc
b09227c

wing328 merged commit b838e18 into OpenAPITools:masterJul 31, 2020

laubfall added 5 commits July 15, 2020 11:22

Fix for issue 4656 typescript-node generate invalid require statement…
0f96c39
… instead of import statement

Fixed broken link under testing templates
0b1d179

Result of run generate-samples.sh / typescript-node*
dd86be3

import stmt depending on flag supportsES6
b03d632

Update petstore sample for typescript-node
660e78c

laubfall mentioned this pull request Jul 15, 2020
[BUG] typescript-node mixes require and import #4656
Closed
6 tasks

macjohnny changed the title ~~Typescript node mixes require and import 4656~~typescript-node: clean up require and importJul 15, 2020

macjohnny approved these changes Jul 15, 2020
View reviewed changes

macjohnny added the Client: TypeScript label Jul 15, 2020

macjohnny added this to the 5.0.0 milestone Jul 15, 2020

DanielRuf reviewed Jul 15, 2020
View reviewed changes

DanielRuf suggested changes Jul 16, 2020
View reviewed changes

laubfalland others added 2 commits July 27, 2020 11:00

import ... from stmt for http/request module
ad3cde0

update samples
547e305

DanielRuf reviewed Jul 28, 2020
View reviewed changes

wing328 added the Enhancement: General label Jul 30, 2020

update doc
b09227c

wing328 merged commit b838e18 into OpenAPITools:masterJul 31, 2020

laubfall added 5 commits July 15, 2020 11:22

Fix for issue 4656 typescript-node generate invalid require statement…
0f96c39
… instead of import statement

Fixed broken link under testing templates
0b1d179

Result of run generate-samples.sh / typescript-node*
dd86be3

import stmt depending on flag supportsES6
b03d632

Update petstore sample for typescript-node
660e78c

laubfall mentioned this pull request Jul 15, 2020
[BUG] typescript-node mixes require and import #4656
Closed
6 tasks

macjohnny changed the title ~~Typescript node mixes require and import 4656~~typescript-node: clean up require and importJul 15, 2020

macjohnny approved these changes Jul 15, 2020
View reviewed changes

macjohnny added the Client: TypeScript label Jul 15, 2020

macjohnny added this to the 5.0.0 milestone Jul 15, 2020

DanielRuf reviewed Jul 15, 2020
View reviewed changes

DanielRuf suggested changes Jul 16, 2020
View reviewed changes

laubfalland others added 2 commits July 27, 2020 11:00

import ... from stmt for http/request module
ad3cde0

update samples
547e305

DanielRuf reviewed Jul 28, 2020
View reviewed changes

wing328 added the Enhancement: General label Jul 30, 2020

update doc
b09227c

wing328 merged commit b838e18 into OpenAPITools:masterJul 31, 2020

laubfall added 5 commits July 15, 2020 11:22

Fix for issue 4656 typescript-node generate invalid require statement…
0f96c39
… instead of import statement

Fixed broken link under testing templates
0b1d179

Result of run generate-samples.sh / typescript-node*
dd86be3

import stmt depending on flag supportsES6
b03d632

Update petstore sample for typescript-node
660e78c

laubfall mentioned this pull request Jul 15, 2020
[BUG] typescript-node mixes require and import #4656
Closed
6 tasks

macjohnny changed the title ~~Typescript node mixes require and import 4656~~typescript-node: clean up require and importJul 15, 2020

macjohnny approved these changes Jul 15, 2020
View reviewed changes

macjohnny added the Client: TypeScript label Jul 15, 2020

macjohnny added this to the 5.0.0 milestone Jul 15, 2020

DanielRuf reviewed Jul 15, 2020
View reviewed changes

DanielRuf suggested changes Jul 16, 2020
View reviewed changes

laubfalland others added 2 commits July 27, 2020 11:00

import ... from stmt for http/request module
ad3cde0

update samples
547e305

DanielRuf reviewed Jul 28, 2020
View reviewed changes

wing328 added the Enhancement: General label Jul 30, 2020

update doc
b09227c

wing328 merged commit b838e18 into OpenAPITools:masterJul 31, 2020

laubfall added 5 commits July 15, 2020 11:22

Fix for issue 4656 typescript-node generate invalid require statement…
0f96c39
… instead of import statement

Fixed broken link under testing templates
0b1d179

Result of run generate-samples.sh / typescript-node*
dd86be3

import stmt depending on flag supportsES6
b03d632

Update petstore sample for typescript-node
660e78c

laubfall mentioned this pull request Jul 15, 2020
[BUG] typescript-node mixes require and import #4656
Closed
6 tasks

macjohnny changed the title ~~Typescript node mixes require and import 4656~~typescript-node: clean up require and importJul 15, 2020

macjohnny approved these changes Jul 15, 2020
View reviewed changes

macjohnny added the Client: TypeScript label Jul 15, 2020

macjohnny added this to the 5.0.0 milestone Jul 15, 2020

DanielRuf reviewed Jul 15, 2020
View reviewed changes

DanielRuf suggested changes Jul 16, 2020
View reviewed changes

laubfalland others added 2 commits July 27, 2020 11:00

import ... from stmt for http/request module
ad3cde0

update samples
547e305

DanielRuf reviewed Jul 28, 2020
View reviewed changes

wing328 added the Enhancement: General label Jul 30, 2020

update doc
b09227c

wing328 merged commit b838e18 into OpenAPITools:masterJul 31, 2020

Uh oh!

Uh oh!

Conversation

laubfall commented Jul 15, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist

Uh oh!

macjohnny left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DanielRuf commented Jul 15, 2020

Uh oh!

macjohnny commented Jul 16, 2020

Uh oh!

DanielRuf left a comment

Choose a reason for hiding this comment

Uh oh!

wing328 commented Jul 28, 2020

Uh oh!

wing328 commented Jul 28, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

laubfall commented Jul 31, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wing328 commented Jul 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

laubfall commented Jul 15, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist

Uh oh!

macjohnny left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DanielRuf commented Jul 15, 2020

Uh oh!

macjohnny commented Jul 16, 2020

Uh oh!

DanielRuf left a comment

Choose a reason for hiding this comment

laubfall commented Jul 15, 2020•
edited
Loading

laubfall commented Jul 31, 2020•
edited
Loading

laubfall commented Jul 15, 2020•
edited
Loading

laubfall commented Jul 31, 2020•
edited
Loading

laubfall commented Jul 15, 2020•
edited
Loading