Skip to content

review/open_MODEX base scenario datapackage - #73

Open
jh-RLI wants to merge 70 commits into
masterfrom
review/open_MODEX-base_scenario#71
Open

review/open_MODEX base scenario datapackage#73
jh-RLI wants to merge 70 commits into
masterfrom
review/open_MODEX-base_scenario#71

Conversation

@jh-RLI

@jh-RLIjh-RLI commented Oct 14, 2020

Copy link
Copy Markdown
Contributor

Closing #71

@jh-RLI
Add first kinda complete metadata draft, include all reviewd souces, …
daafcc1
…add general information, add metainformation in description field
@jh-RLIjh-RLI self-assigned this Oct 14, 2020
@jh-RLIjh-RLI added the feedback wanted What's your opinion? label Oct 14, 2020
@jh-RLIjh-RLI linked an issue Oct 14, 2020 that may be closed by this pull request
Review: open_MODEX-base_scenario #71
Open
15 tasks
@jh-RLIjh-RLI added review Data and Metadata review review-process Suggestions to change the review process and removed feedback wanted What's your opinion? labels Mar 29, 2021
@jh-RLI
jh-RLI requested a review from chrwmMay 26, 2021 11:55
@chrwm
chrwm removed the request for review from christian-rliFebruary 28, 2022 15:18
@chrwm

chrwm commented Feb 28, 2022

Copy link
Copy Markdown
Member

@jh-RLI

  • I grouped the open_MODEX metadata as you did once here

@chrwm

chrwm commented Mar 22, 2022

Copy link
Copy Markdown
Member

Can this be merged?

@jh-RLI

jh-RLI commented Mar 22, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

The tables are still in the model draft schema. The problem is that moving them would lead to the oedatamodel api and dashboard no longer working. Adjustments would have to be made there. A solution for the moment would be to move the tables into the schema scenario and to keep the tables in the model draft for the time being. In addition, issues should then be created in the repos of the oedatamodel_api and dashboard.

I have not done the moving of tables via the API yet and do not know the function. @Ludee would have to provide some hint on how to do it.

@chrwmchrwm mentioned this pull request Mar 22, 2022
Merged
@Ludee

Ludee commented Mar 30, 2022

Copy link
Copy Markdown
Member

I have this on my list now.
The table names are not following the OEP naming conventions and there are some minor issues with the metadata.
I suggest to create a copy of the tables and and include all corrections and move. Then adjust the API to new ones and delete the old in model_draft!?

@jh-RLI

jh-RLI commented Mar 30, 2022

Copy link
Copy Markdown
ContributorAuthor

good catch! I overlooked the upper case words in the table names 👍

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrwmchrwmchrwm approved these changes
@LudeeLudeeAwaiting requested review from Ludee

Assignees

@jh-RLIjh-RLI

Labels

reviewData and Metadata reviewreview-processSuggestions to change the review process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Review: open_MODEX-base_scenario

5 participants

@jh-RLI@chrwm@Ludee@christian-rli@steull