Uh oh!
There was an error while loading. Please reload this page.
Review/modex consortium - #95
Conversation
jh-RLI
left a comment
There was a problem hiding this comment.
I´m not sure if it is good practice to publish actual data (CSV files) on GitHub. IMO the current workflow suggests uploading the data to the table on the OEP (I thought the consortium tables will be empty?). Or is there any reason to include the csv files I´m not aware of? @chrwm
Files:
oed_scalar_publish.csv
open_MODEX_base_check.csv
jh-RLI
commented
Mar 23, 2022
OH just noticed that GitHub showed these files to me, but they actually don't exist in the folder ?! I'm experiencing some issues with GitHub in the previous days. @chrwm can you check if the files still exists? Otherwise, I approve this PR. |
Hi @jh-RLI, thanks for the review. The csv files should not be part of the pull request, I deleted them (which is part of the PR). |
chrwm
commented
Mar 23, 2022
Alright, I created all tables in model_draft and attached the correct metadata (incl. |
Ludee
commented
Mar 30, 2022
The PR created the files in the wrong folder containing a space. |
Closes#88
Cheery-picked grouped open_MODEX sources from #73
Should have been added the this PR #87