Skip to content

Fix two faults that stop a saved world from ever loading#23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Makkkkus merged 3 commits into from
Aug 23, 2026
Merged

Fix two faults that stop a saved world from ever loading #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
937be51
Fix two faults that stop a saved world from ever loading
o885407257-png Aug 19, 2026
33a7e23
Merge branch 'main' into fix/loading-a-saved-world
Makkkkus Aug 23, 2026
ccfa0bc
Replace error log with warning for missing prefabs
Makkkkus Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Assets/Scripts/QuestIndicators.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,6 +42,12 @@ private void Awake()

public void AddQuestIndicator(SceneQuestTrigger sceneQuestTrigger)
{
if (IndicatorPrefab == null)
{
Debug.LogWarning("QuestIndicators.IndicatorPrefab is not assigned; skipping quest indicator.");
return;
}

if (!SceneQuestTriggers.ContainsKey(sceneQuestTrigger) && sceneQuestTrigger.Visibility != 0 &&
sceneQuestTrigger.gameObject.activeInHierarchy)
{
Expand All@@ -60,6 +66,12 @@ public void AddQuestIndicator(SceneQuestTrigger sceneQuestTrigger)

public void AddAvailableQuestIndicator(SceneQuestTrigger sceneQuestTrigger)
{
if (NewQuestIndicatorPrefab == null)
{
Debug.LogWarning("QuestIndicators.NewQuestIndicatorPrefab is not assigned; skipping it.");
return;
}

if (!SceneQuestTriggers.ContainsKey(sceneQuestTrigger) && sceneQuestTrigger.Visibility != 0 &&
sceneQuestTrigger.gameObject.activeInHierarchy)
{
Expand Down
1 change: 0 additions & 1 deletion Assets/Scripts/ZeroGravity/Objects/Ship.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -216,7 +216,6 @@ protected override void FixedUpdate()
};
_shipStatsChanged = false;
}

}

public Vector3 DampenRotationPrediction(float timeDelta, bool dampen, float stabilizationMultiplier = 1.0f)
Expand Down