Skip to content

Test - #275

Closed
syntron wants to merge 61 commits into
OpenModelica:masterfrom
syntron:test
Closed

Test#275
syntron wants to merge 61 commits into
OpenModelica:masterfrom
syntron:test

Conversation

@syntron

@syntronsyntron commented Apr 26, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

This is just a draft of ideas to further work on ...

... will be splitted into separate PRs if ready ...

@syntron
syntronforce-pushed the test branch 4 times, most recently from 0389dfe to 1712a85CompareApril 26, 2025 21:28
@ondras12345

ondras12345 commented Apr 26, 2025

Copy link
Copy Markdown
Contributor

@syntron Just a note: it is easy to run tests locally:

# git clone ....
cd OMPython
python3 -m venv venv
. ./venv/bin/activate
pip3 install --editable .
pip3 install pytest
pytest

When you push a commit to this pull request, it has to create a new virtual machine, install all dependencies in it, and then run the tests and delete the VM. And it does this for two versions of python and for both linux and Windows. If you run tests locally, you won't have to wait as long for them to finish.

@syntron

syntron commented Apr 28, 2025

Copy link
Copy Markdown
ContributorAuthor

@ondras12345 thanks for the hint; the problem is that I'm limited due to the distribution I use: no package for opensuse available ... thus, I have to run testing on a different computer (or on github)

syntronand others added 24 commits April 29, 2025 18:52
@syntron
[ModelicaSystem] simplify subprocess.Popen() => use subprocess.run()
ba103d7
@syntron
[ModelicaSystem] add timeout to subprocess.run() in _run_cmd()
78e7ae2
@syntron
[ModelicaSystem._run_cmd()] differentiate between OM error and nonzer…
b93f121
…o return code
@syntron
[ModelicaSystem.linearize()] fix docstring / add description for timeout
2b92216
@syntron
[ModelicaSystem] simplify code in xmlparse()
64b72f3
@syntron
[ModelicaSystem] add ModelicaSystemError() for unhandled final else c…
d9643e5
…ases
there are a lot of functions which check the type of the input; this is
done by if ... elif ... - however, invalid input is not catched, i.e. there
is *NO* return value define (would be None) if the input is not matching
any of the if branches
@syntron
[ModelicaSystem.getSolution()] do not try to continue on error but fail
41f9876
Rule: fail early, fail hard - tell the user that something is wrong!
In this case, the user ask for the solution but could get None (= plain
'return') - this would case hard to track errors later (if verbose==False
and raiseerrors==False)
@syntron
[ModelicaSystem] remove redundant parentheses (type hint by PyCharm)
d066548
@syntron
[OMCSessionException] add exception handling for OMCSession*
87a58b7
@syntron
[OMCSessionZMQ] use specific exceptions instead of generic Exception …
e609860
…where possible
@syntron
[OMCSessionBase] use OMCSessionException instead of generic Exception
0293214
@syntron
[OMParser] use a single entry point for OMParser
0135cdc
@syntron
[OMTypedParser] use a single entry point for OMTypedParser
e0ff3ed
@syntron
[OMCSessionBase] fix exception handling for pyparsing.ParseException
8d642d5
* fix ex.message => ex.msg
@syntron
[OMCSessionBase] simplify the two use cases of OMParser.om_parse_basic()
f16e486
@syntron
Merge branch 'fix_ModelicaSystem' into merge
7f423be
@syntron
Merge branch 'parser' into merge
b9a70c0
@syntron
Merge branch 'use_subprocess.run' into merge
9b81f3d
@syntron
[DummyPopen] remove redundant parentheses
4c66612
@ondras12345@syntron
Fix two spaces in simflags causing error
30dbf35
@syntron
[ModelicaSystem] remove not needed variables
ebe6961
@syntron
[ModelicaSystem] csvFile
882b127
@syntron
[ModelicaSystem] tempdir
3662fd5
@syntron
[ModelicaSystem] batFilePath
52df1d8
syntron added 21 commits April 29, 2025 21:07
@syntron
[OMCSessionCmd] restore test_ZMQ - move execute() back into OMCSessio…
8b20545
…nZMQ
@syntron
[OMCSessionCmd] make sendExpression() available
ca41560
@syntron
[tests] new test for OMCSessionCmd
b06d28a
@syntron
Merge branch 'update_DummyPopen' into merge2
e4d95ef
@syntron
Merge branch 'update_OMCSession' into merge2
621b7aa
@syntron
[OMCSessionZMQ] allways check for errors if using sendExpression()
7c1575b
needs the preparation / additional changes in OMCSession* and ModelicaSystem
@syntron
[OMCSession*] move logging into OMCSessionZMQ.sendExpression()
fb239c2
@syntron
[ModelicaSystem] exception handling for sendExpression()
02a7989
@syntron
[ModelicaSystem] remove last call to getErrorString()
3dd1ba8
this is handled in OMCSessionZMQ.sendExpression()
@syntron
[ModelicaSystemCmd] draft
6547f14
@syntron
[ModelicaSystemCmd] define and use it - needs cleanup!
b9c04b2
@syntron
[ModelicaSystemCmd] update handling of simargs
5cc7fa5
@syntron
[ModelicaSystemCmd] move handling of simflags info this class
e680f1f
@syntron
[ModelicaSystemCmd] cleanup / docstrings
066fc03
@syntron
[ModelicaSystemCmd] simplify
e23dfec
@syntron
[__init__] make ModelicaSystemCmd available
4b0faba
@syntron
[ModelicaSystemCmd] special handling for override in simflags / simargs
2bd6754
@syntron
[ModelicaSystemCmd] split run() - create command in get_cmd() and get…
308eb3b
…_exe()
@syntron
[ModelicaSystem] use pathlib.Path() / simplify
6bfecef
@syntron
[ModelicaSystemCmd] do *NOT* raise error if returncode != 0
2d0c3d0
could be a simulation which stoped before the final time ...
@syntron
[tests] for ModelicaSystemCmd
d6fd226
@syntron
[ModelicaSystem] fix flake8 error
ae5d6c4
./OMPython/ModelicaSystem.py:1236:72: E999 SyntaxError: f-string: unmatched '['
@syntron

syntron commented Apr 29, 2025

Copy link
Copy Markdown
ContributorAuthor

this draft PR is (kind of) ready ... I will split it in smaller parts; however, as there are dependencies between the elements some PR will depend on each other ...

This was referenced Apr 30, 2025
Merged
Closed
@syntron

syntron commented May 1, 2025

Copy link
Copy Markdown
ContributorAuthor

Defined via PR #270, #271, #272, #273, #277#278 and #279

@syntronsyntron closed this May 1, 2025
@syntron
syntron deleted the test branch May 1, 2025 15:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@syntron@ondras12345