Update modelica system

[syntron]

Update ModelicaSystem on top of PR #273

Changes:

• remove verbose - use logger.debug()
• remove raiseerror - use raise ModelicaSystemException()
• use pathlib.Path() if possible
• enforce lmodel is a list
• use exceptions if possible

[syntron]

This needs PR #272 - removed this dependency and solved the dependency problem by a temporary solution - use Exception instead of OMCSessionException for now ...

[adeas31]

Seems this one is next in line. Please rebase it so I can start reviewing it.

[syntron]

Seems this one is next in line. Please rebase it so I can start reviewing it.

@adeas31 done

[adeas31]

LGTM.

However, the verbose flag calls getErrorString() which is useful in some cases to show the compiler notifications to the user. For example, if you call this,

loadString("model M annotation (uses(Modelica(version=\"4.0.0\"))); end M;");

You will not get the notifications that the Modelica package is loaded due to uses annotation unless you call ``getErrorString()`.

I suggest we always call getErrorString() inside sendExpression and logs it using the logger. To further enhance this, we can use getMessagesStringInternal() instead of getErrorString() since getErrorString() returns string without any structure you don't know if its an error, warning or a notification. If we use getMessagesStringInternal() we can properly log using error, warning and info.

[syntron]

I suggest we always call getErrorString() inside sendExpression and logs it using the logger. To further enhance this, we can use getMessagesStringInternal() instead of getErrorString() since getErrorString() returns string without any structure you don't know if its an error, warning or a notification. If we use getMessagesStringInternal() we can properly log using error, warning and info.

This is done in PR #278; please check mainly 7658886; I will check the usage of getMessagesStringInternal()