Uh oh!
There was an error while loading. Please reload this page.
feat(i18n): Portuguese localization for app chrome, cards, dialogs and pages - #194
Merged
Conversation
…d pages Adds a locale preference (en/pt, persisted, browser-detected on first run) with a shared dictionary and English fallback, a globe dropdown in the sidebar plus a Language card in Settings, and EN|PT toggles on the standalone pages. Covers sidebar, settings, tabs, overview, pending bar, toasts, device cards, Logitech/Keychron editors, support/capture/share dialogs, landing, FAQ, device check, supported list, donate, admin console and controller status/error messages. Device-provided values, hardware-written option values and server-bound fields stay untouched.
The full en+pt dictionary pushed the JS aggregate ~82 kB over budget (873 kB vs 790 kB). Split pt into its own chunk (i18n-pt-*.js) loaded on demand: t() falls back to English until ensureLocale() resolves, locale switches await the table before committing (no fallback flash), and a stored non-English locale re-renders once after first paint. Raise the JS budget to 885 kB with headroom for the remaining dictionary weight.
# Conflicts: # build/check-bundle-size.ts # src/app/InterfaceSettings.tsx # src/interface-preferences.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge of #185 onto current control-panel, resolving conflicts against #182/#183's motion/toggle work and #159's ATK bundle-budget raise (build/check-bundle-size.ts got two independent raises stacked cumulatively: 800 kB for ATK ZERO, then 895 kB on top for the pt dictionary). Kept the translated strings on the animations SwitchCard over the plain-English version another PR had reintroduced there. Closes#185.