Refactor spawn scripts with shared library and OAuth fallback - #1

Merged
louisgv merged 1 commit into
mainfrom
refactor/shared-lib-oauth-fallback
Feb 7, 2026
Merged

Refactor spawn scripts with shared library and OAuth fallback#1
louisgv merged 1 commit into
mainfrom
refactor/shared-lib-oauth-fallback

Conversation

@louisgv

Copy link
Copy Markdown
Collaborator

Summary

Major refactoring to improve code maintainability, reliability, and user experience:

🏗️ Shared Library Architecture

  • Created sprite/lib/common.sh with 12 reusable bash functions
  • openclaw.sh: 258 lines → 93 lines (-64%)
  • claude.sh: 272 lines → 101 lines (-63%)
  • Total: Eliminated ~330 lines of duplicate code

🔄 OAuth Fallback Mechanism

  • Automatic fallback to manual API key entry when OAuth fails
  • Handles missing netcat (nc) gracefully
  • Handles port conflicts and OAuth timeouts
  • API key format validation with override option
  • Works in headless and minimal environments

🌐 Dual Execution Mode

  • Local: bash sprite/openclaw.sh
  • Remote: curl URL | bash
  • Auto-detects execution context and sources library appropriately

New Shared Functions

Logging:

  • log_info(), log_warn(), log_error()

Sprite Setup:

  • ensure_sprite_installed() - Install sprite CLI if needed
  • ensure_sprite_authenticated() - Check/prompt for auth
  • ensure_sprite_exists() - Create sprite if doesn't exist
  • verify_sprite_connectivity() - Test sprite connection
  • run_sprite() - Execute commands on sprite

Environment:

  • setup_shell_environment() - Configure PATH and zsh

OAuth:

  • get_openrouter_api_key_oauth() - OAuth with fallback
  • try_oauth_flow() - Attempt OAuth (can fail gracefully)
  • get_openrouter_api_key_manual() - Manual API key entry

Utilities:

  • open_browser() - Cross-platform browser launch

Failure Scenarios Handled

✅ Missing netcat (nc)
✅ Port already in use
✅ OAuth server startup failure
✅ OAuth timeout (2 minute default)
✅ OAuth code exchange failure
✅ No browser available
✅ User cancellation

Documentation

  • REFACTORING.md - Architecture overview and benefits
  • OAUTH_FALLBACK.md - Fallback mechanism guide
  • CURL_BASH_SOLUTION.md - Execution mode details
  • EXAMPLES.md - Real-world usage scenarios
  • CHANGELOG.md - Complete change history

Test Plan

  • Syntax validation: All scripts pass bash -n
  • Local execution: Scripts work when run locally
  • Remote execution: Test curl | bash after merge
  • OAuth success: Verify OAuth flow completes
  • OAuth fallback: Test with missing nc
  • Manual entry: Test API key validation

Breaking Changes

None - scripts maintain identical functionality and command-line interface.

Benefits

  1. Maintainability: Common logic in one place
  2. Reliability: Graceful degradation when OAuth fails
  3. Extensibility: Future scripts can reuse all functions
  4. User Experience: Works in more environments
  5. Code Quality: DRY principle, better organization

🤖 Generated with Claude Code

Major refactoring to improve code maintainability and reliability:
## Shared Library Architecture
- Created sprite/lib/common.sh with reusable bash functions
- Reduced openclaw.sh from 258 to 93 lines (-64%)
- Reduced claude.sh from 272 to 101 lines (-63%)
- Eliminated ~330 lines of duplicate code
## OAuth Fallback Mechanism
- Added automatic fallback to manual API key entry
- Handles missing netcat (nc) gracefully
- Handles port conflicts and timeouts
- Validates API key format with override option
- Works in headless and minimal environments
## Dual Execution Support
- Local: bash sprite/openclaw.sh
- Remote: curl URL | bash
- Auto-detects context and sources library appropriately
## New Shared Functions
- Logging: log_info(), log_warn(), log_error()
- Sprite setup: ensure_sprite_installed/authenticated/exists()
- Environment: setup_shell_environment()
- OAuth: get_openrouter_api_key_oauth() with fallback
- Utilities: run_sprite(), verify_sprite_connectivity()
## Documentation
- REFACTORING.md - Architecture and benefits
- OAUTH_FALLBACK.md - Fallback mechanism guide
- CURL_BASH_SOLUTION.md - Execution mode details
- EXAMPLES.md - Usage scenarios
- CHANGELOG.md - Complete change history
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@louisgv
louisgv merged commit c0536e3 into mainFeb 7, 2026
louisgv pushed a commit that referenced this pull request Feb 8, 2026
Completed ENV_TEMP pattern extraction across remaining providers:
1. Modal: gptme.sh (1 script) - uses inject_env_vars_local
2. GCP: all 10 agent scripts - uses inject_env_vars_ssh
3. Fly.io: all 11 agent scripts - uses new inject_env_vars_fly
- Added inject_env_vars_fly() to fly/lib/common.sh
- Handles both .bashrc and .zshrc (Fly-specific requirement)
4. Sprite: amazonq, cline, gemini (3 scripts) - uses inject_env_vars_sprite
Total scripts converted in this commit: 25
Total scripts converted in Round 25 Task #1: 78 scripts
Each conversion replaces 11-15 lines of temp file management with a single
function call that handles creation, permissions, content generation, upload,
sourcing, and cleanup.
The only remaining ENV_TEMP patterns are DOTENV_TEMP in nanoclaw scripts,
which are agent-specific .env files and should remain as-is.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@louisgv
louisgv deleted the refactor/shared-lib-oauth-fallback branch February 8, 2026 05:15
la14-1 pushed a commit that referenced this pull request Feb 11, 2026
Add `spawn rerun [#]` to quickly relaunch a previous spawn by its
history number. The list view now shows row numbers (#1, #2, ...) and
relative timestamps ("2h ago", "3d ago") alongside absolute dates for
better scannability. Partially addresses #492.
Agent: ux-engineer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@louisgvlouisgv mentioned this pull request Feb 19, 2026
6 tasks
la14-1 pushed a commit that referenced this pull request May 2, 2026
… parses (#3384)
Reproduces with: any staged file matching the secret regex (e.g. a test
fixture containing an OpenRouter / Anthropic / OpenAI key shape).
The redact step ran:
sed -i -E "s|${SECRET_REGEX}|${REDACT_PLACEHOLDER}|g" "$f"
SECRET_REGEX is itself a `|`-separated alternation of provider patterns
(`(sk-or-v1-...)|(sk-ant-api...)|(...)`). After bash expansion, sed sees
multiple fields where it expected three, and bails with:
sed: -e expression #1, char 67: unknown option to `s'
The export then fails on the VM ("sprite exec failed (exit 1)") even
though the user already approved the redaction in the host prompt.
Fix: switch the sed delimiter to '#'. None of the regex tokens
(provider prefixes, char classes, quantifiers, PEM marker) contain '#',
and neither does the placeholder, so the substitution is unambiguous.
'|' inside the pattern is now correctly interpreted by sed -E as
alternation, which is what we wanted all along.
Adds a regression test asserting the script uses 's#...#...#g' and
not 's|...|...|g'.
Bumps CLI 1.0.35 -> 1.0.36.
la14-1 pushed a commit that referenced this pull request May 4, 2026
Numeric targets (target 140, cap 180) just become the new goal. The model
will pad to hit them instead of writing a punchy 40-char banger. Remove
all char-count anchors from the brevity guidance and let the good/bad
examples carry the signal.
- Rename section from 'BREVITY IS THE #1 RULE' to 'Keep it short'
- Drop 80-140 target, 180 cap, char-count example annotations
- Drop Chars line from output format and charCount from JSON
- Keep only the qualitative rules: don't pad, don't explain twice,
prefer one sentence, cut what isn't pulling weight
- Platform 280 cap mentioned once as a ceiling, not a goal
AhmedTMM pushed a commit that referenced this pull request May 4, 2026
#3390)
* fix(growth): enforce brevity in tweet prompt (target ≤140, hard cap 180)
Recent posted tweets were running 170-200 chars and reading as long-form
marketing copy. Tighten the tweet drafting prompt:
- Add a dedicated "BREVITY IS THE #1 RULE" section at the top
- Target 80-140 chars, hard cap 180 chars (down from the 280 platform limit)
- Good/bad length examples drawn from actual prior drafts
- Require a trim pass before output
- Update output format and rules to reflect the new caps
* fix(growth): drop numeric char targets, lean on taste
Numeric targets (target 140, cap 180) just become the new goal. The model
will pad to hit them instead of writing a punchy 40-char banger. Remove
all char-count anchors from the brevity guidance and let the good/bad
examples carry the signal.
- Rename section from 'BREVITY IS THE #1 RULE' to 'Keep it short'
- Drop 80-140 target, 180 cap, char-count example annotations
- Drop Chars line from output format and charCount from JSON
- Keep only the qualitative rules: don't pad, don't explain twice,
prefer one sentence, cut what isn't pulling weight
- Platform 280 cap mentioned once as a ceiling, not a goal
* fix(growth): strip all length references from tweet prompt
Even mentioning '280 char limit' or 'platform limit' anchors the model
to the wrong end of the range. Remove both remaining length references
so the prompt is purely about taste: say less, don't pad, cut what
isn't pulling weight. The platform enforces its own limit.
- Drop the 'platform 280 char limit is a ceiling' paragraph
- Drop 'Must fit in a tweet (under the platform limit)' from rules
---------
Co-authored-by: Claude <claude@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@louisgv
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Refactor spawn scripts with shared library and OAuth fallback - #1

Merged
louisgv merged 1 commit into
mainfrom
refactor/shared-lib-oauth-fallback
Feb 7, 2026
Merged

Refactor spawn scripts with shared library and OAuth fallback#1
louisgv merged 1 commit into
mainfrom
refactor/shared-lib-oauth-fallback

Conversation

@louisgv

Copy link
Copy Markdown
Collaborator

Summary

Major refactoring to improve code maintainability, reliability, and user experience:

🏗️ Shared Library Architecture

  • Created sprite/lib/common.sh with 12 reusable bash functions
  • openclaw.sh: 258 lines → 93 lines (-64%)
  • claude.sh: 272 lines → 101 lines (-63%)
  • Total: Eliminated ~330 lines of duplicate code

🔄 OAuth Fallback Mechanism

  • Automatic fallback to manual API key entry when OAuth fails
  • Handles missing netcat (nc) gracefully
  • Handles port conflicts and OAuth timeouts
  • API key format validation with override option
  • Works in headless and minimal environments

🌐 Dual Execution Mode

  • Local: bash sprite/openclaw.sh
  • Remote: curl URL | bash
  • Auto-detects execution context and sources library appropriately

New Shared Functions

Logging:

  • log_info(), log_warn(), log_error()

Sprite Setup:

  • ensure_sprite_installed() - Install sprite CLI if needed
  • ensure_sprite_authenticated() - Check/prompt for auth
  • ensure_sprite_exists() - Create sprite if doesn't exist
  • verify_sprite_connectivity() - Test sprite connection
  • run_sprite() - Execute commands on sprite

Environment:

  • setup_shell_environment() - Configure PATH and zsh

OAuth:

  • get_openrouter_api_key_oauth() - OAuth with fallback
  • try_oauth_flow() - Attempt OAuth (can fail gracefully)
  • get_openrouter_api_key_manual() - Manual API key entry

Utilities:

  • open_browser() - Cross-platform browser launch

Failure Scenarios Handled

✅ Missing netcat (nc)
✅ Port already in use
✅ OAuth server startup failure
✅ OAuth timeout (2 minute default)
✅ OAuth code exchange failure
✅ No browser available
✅ User cancellation

Documentation

  • REFACTORING.md - Architecture overview and benefits
  • OAUTH_FALLBACK.md - Fallback mechanism guide
  • CURL_BASH_SOLUTION.md - Execution mode details
  • EXAMPLES.md - Real-world usage scenarios
  • CHANGELOG.md - Complete change history

Test Plan

  • Syntax validation: All scripts pass bash -n
  • Local execution: Scripts work when run locally
  • Remote execution: Test curl | bash after merge
  • OAuth success: Verify OAuth flow completes
  • OAuth fallback: Test with missing nc
  • Manual entry: Test API key validation

Breaking Changes

None - scripts maintain identical functionality and command-line interface.

Benefits

  1. Maintainability: Common logic in one place
  2. Reliability: Graceful degradation when OAuth fails
  3. Extensibility: Future scripts can reuse all functions
  4. User Experience: Works in more environments
  5. Code Quality: DRY principle, better organization

🤖 Generated with Claude Code

Major refactoring to improve code maintainability and reliability:
## Shared Library Architecture
- Created sprite/lib/common.sh with reusable bash functions
- Reduced openclaw.sh from 258 to 93 lines (-64%)
- Reduced claude.sh from 272 to 101 lines (-63%)
- Eliminated ~330 lines of duplicate code
## OAuth Fallback Mechanism
- Added automatic fallback to manual API key entry
- Handles missing netcat (nc) gracefully
- Handles port conflicts and timeouts
- Validates API key format with override option
- Works in headless and minimal environments
## Dual Execution Support
- Local: bash sprite/openclaw.sh
- Remote: curl URL | bash
- Auto-detects context and sources library appropriately
## New Shared Functions
- Logging: log_info(), log_warn(), log_error()
- Sprite setup: ensure_sprite_installed/authenticated/exists()
- Environment: setup_shell_environment()
- OAuth: get_openrouter_api_key_oauth() with fallback
- Utilities: run_sprite(), verify_sprite_connectivity()
## Documentation
- REFACTORING.md - Architecture and benefits
- OAUTH_FALLBACK.md - Fallback mechanism guide
- CURL_BASH_SOLUTION.md - Execution mode details
- EXAMPLES.md - Usage scenarios
- CHANGELOG.md - Complete change history
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@louisgv
louisgv merged commit c0536e3 into mainFeb 7, 2026
louisgv pushed a commit that referenced this pull request Feb 8, 2026
Completed ENV_TEMP pattern extraction across remaining providers:
1. Modal: gptme.sh (1 script) - uses inject_env_vars_local
2. GCP: all 10 agent scripts - uses inject_env_vars_ssh
3. Fly.io: all 11 agent scripts - uses new inject_env_vars_fly
- Added inject_env_vars_fly() to fly/lib/common.sh
- Handles both .bashrc and .zshrc (Fly-specific requirement)
4. Sprite: amazonq, cline, gemini (3 scripts) - uses inject_env_vars_sprite
Total scripts converted in this commit: 25
Total scripts converted in Round 25 Task #1: 78 scripts
Each conversion replaces 11-15 lines of temp file management with a single
function call that handles creation, permissions, content generation, upload,
sourcing, and cleanup.
The only remaining ENV_TEMP patterns are DOTENV_TEMP in nanoclaw scripts,
which are agent-specific .env files and should remain as-is.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@louisgv
louisgv deleted the refactor/shared-lib-oauth-fallback branch February 8, 2026 05:15
la14-1 pushed a commit that referenced this pull request Feb 11, 2026
Add `spawn rerun [#]` to quickly relaunch a previous spawn by its
history number. The list view now shows row numbers (#1, #2, ...) and
relative timestamps ("2h ago", "3d ago") alongside absolute dates for
better scannability. Partially addresses #492.
Agent: ux-engineer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@louisgvlouisgv mentioned this pull request Feb 19, 2026
6 tasks
la14-1 pushed a commit that referenced this pull request May 2, 2026
… parses (#3384)
Reproduces with: any staged file matching the secret regex (e.g. a test
fixture containing an OpenRouter / Anthropic / OpenAI key shape).
The redact step ran:
sed -i -E "s|${SECRET_REGEX}|${REDACT_PLACEHOLDER}|g" "$f"
SECRET_REGEX is itself a `|`-separated alternation of provider patterns
(`(sk-or-v1-...)|(sk-ant-api...)|(...)`). After bash expansion, sed sees
multiple fields where it expected three, and bails with:
sed: -e expression #1, char 67: unknown option to `s'
The export then fails on the VM ("sprite exec failed (exit 1)") even
though the user already approved the redaction in the host prompt.
Fix: switch the sed delimiter to '#'. None of the regex tokens
(provider prefixes, char classes, quantifiers, PEM marker) contain '#',
and neither does the placeholder, so the substitution is unambiguous.
'|' inside the pattern is now correctly interpreted by sed -E as
alternation, which is what we wanted all along.
Adds a regression test asserting the script uses 's#...#...#g' and
not 's|...|...|g'.
Bumps CLI 1.0.35 -> 1.0.36.
la14-1 pushed a commit that referenced this pull request May 4, 2026
Numeric targets (target 140, cap 180) just become the new goal. The model
will pad to hit them instead of writing a punchy 40-char banger. Remove
all char-count anchors from the brevity guidance and let the good/bad
examples carry the signal.
- Rename section from 'BREVITY IS THE #1 RULE' to 'Keep it short'
- Drop 80-140 target, 180 cap, char-count example annotations
- Drop Chars line from output format and charCount from JSON
- Keep only the qualitative rules: don't pad, don't explain twice,
prefer one sentence, cut what isn't pulling weight
- Platform 280 cap mentioned once as a ceiling, not a goal
AhmedTMM pushed a commit that referenced this pull request May 4, 2026
#3390)
* fix(growth): enforce brevity in tweet prompt (target ≤140, hard cap 180)
Recent posted tweets were running 170-200 chars and reading as long-form
marketing copy. Tighten the tweet drafting prompt:
- Add a dedicated "BREVITY IS THE #1 RULE" section at the top
- Target 80-140 chars, hard cap 180 chars (down from the 280 platform limit)
- Good/bad length examples drawn from actual prior drafts
- Require a trim pass before output
- Update output format and rules to reflect the new caps
* fix(growth): drop numeric char targets, lean on taste
Numeric targets (target 140, cap 180) just become the new goal. The model
will pad to hit them instead of writing a punchy 40-char banger. Remove
all char-count anchors from the brevity guidance and let the good/bad
examples carry the signal.
- Rename section from 'BREVITY IS THE #1 RULE' to 'Keep it short'
- Drop 80-140 target, 180 cap, char-count example annotations
- Drop Chars line from output format and charCount from JSON
- Keep only the qualitative rules: don't pad, don't explain twice,
prefer one sentence, cut what isn't pulling weight
- Platform 280 cap mentioned once as a ceiling, not a goal
* fix(growth): strip all length references from tweet prompt
Even mentioning '280 char limit' or 'platform limit' anchors the model
to the wrong end of the range. Remove both remaining length references
so the prompt is purely about taste: say less, don't pad, cut what
isn't pulling weight. The platform enforces its own limit.
- Drop the 'platform 280 char limit is a ceiling' paragraph
- Drop 'Must fit in a tweet (under the platform limit)' from rules
---------
Co-authored-by: Claude <claude@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@louisgv
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Refactor spawn scripts with shared library and OAuth fallback - #1

Merged
louisgv merged 1 commit into
mainfrom
refactor/shared-lib-oauth-fallback
Feb 7, 2026
Merged

Refactor spawn scripts with shared library and OAuth fallback#1
louisgv merged 1 commit into
mainfrom
refactor/shared-lib-oauth-fallback

Conversation

@louisgv

Copy link
Copy Markdown
Collaborator

Summary

Major refactoring to improve code maintainability, reliability, and user experience:

🏗️ Shared Library Architecture

  • Created sprite/lib/common.sh with 12 reusable bash functions
  • openclaw.sh: 258 lines → 93 lines (-64%)
  • claude.sh: 272 lines → 101 lines (-63%)
  • Total: Eliminated ~330 lines of duplicate code

🔄 OAuth Fallback Mechanism

  • Automatic fallback to manual API key entry when OAuth fails
  • Handles missing netcat (nc) gracefully
  • Handles port conflicts and OAuth timeouts
  • API key format validation with override option
  • Works in headless and minimal environments

🌐 Dual Execution Mode

  • Local: bash sprite/openclaw.sh
  • Remote: curl URL | bash
  • Auto-detects execution context and sources library appropriately

New Shared Functions

Logging:

  • log_info(), log_warn(), log_error()

Sprite Setup:

  • ensure_sprite_installed() - Install sprite CLI if needed
  • ensure_sprite_authenticated() - Check/prompt for auth
  • ensure_sprite_exists() - Create sprite if doesn't exist
  • verify_sprite_connectivity() - Test sprite connection
  • run_sprite() - Execute commands on sprite

Environment:

  • setup_shell_environment() - Configure PATH and zsh

OAuth:

  • get_openrouter_api_key_oauth() - OAuth with fallback
  • try_oauth_flow() - Attempt OAuth (can fail gracefully)
  • get_openrouter_api_key_manual() - Manual API key entry

Utilities:

  • open_browser() - Cross-platform browser launch

Failure Scenarios Handled

✅ Missing netcat (nc)
✅ Port already in use
✅ OAuth server startup failure
✅ OAuth timeout (2 minute default)
✅ OAuth code exchange failure
✅ No browser available
✅ User cancellation

Documentation

  • REFACTORING.md - Architecture overview and benefits
  • OAUTH_FALLBACK.md - Fallback mechanism guide
  • CURL_BASH_SOLUTION.md - Execution mode details
  • EXAMPLES.md - Real-world usage scenarios
  • CHANGELOG.md - Complete change history

Test Plan

  • Syntax validation: All scripts pass bash -n
  • Local execution: Scripts work when run locally
  • Remote execution: Test curl | bash after merge
  • OAuth success: Verify OAuth flow completes
  • OAuth fallback: Test with missing nc
  • Manual entry: Test API key validation

Breaking Changes

None - scripts maintain identical functionality and command-line interface.

Benefits

  1. Maintainability: Common logic in one place
  2. Reliability: Graceful degradation when OAuth fails
  3. Extensibility: Future scripts can reuse all functions
  4. User Experience: Works in more environments
  5. Code Quality: DRY principle, better organization

🤖 Generated with Claude Code

Major refactoring to improve code maintainability and reliability:
## Shared Library Architecture
- Created sprite/lib/common.sh with reusable bash functions
- Reduced openclaw.sh from 258 to 93 lines (-64%)
- Reduced claude.sh from 272 to 101 lines (-63%)
- Eliminated ~330 lines of duplicate code
## OAuth Fallback Mechanism
- Added automatic fallback to manual API key entry
- Handles missing netcat (nc) gracefully
- Handles port conflicts and timeouts
- Validates API key format with override option
- Works in headless and minimal environments
## Dual Execution Support
- Local: bash sprite/openclaw.sh
- Remote: curl URL | bash
- Auto-detects context and sources library appropriately
## New Shared Functions
- Logging: log_info(), log_warn(), log_error()
- Sprite setup: ensure_sprite_installed/authenticated/exists()
- Environment: setup_shell_environment()
- OAuth: get_openrouter_api_key_oauth() with fallback
- Utilities: run_sprite(), verify_sprite_connectivity()
## Documentation
- REFACTORING.md - Architecture and benefits
- OAUTH_FALLBACK.md - Fallback mechanism guide
- CURL_BASH_SOLUTION.md - Execution mode details
- EXAMPLES.md - Usage scenarios
- CHANGELOG.md - Complete change history
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@louisgv
louisgv merged commit c0536e3 into mainFeb 7, 2026
louisgv pushed a commit that referenced this pull request Feb 8, 2026
Completed ENV_TEMP pattern extraction across remaining providers:
1. Modal: gptme.sh (1 script) - uses inject_env_vars_local
2. GCP: all 10 agent scripts - uses inject_env_vars_ssh
3. Fly.io: all 11 agent scripts - uses new inject_env_vars_fly
- Added inject_env_vars_fly() to fly/lib/common.sh
- Handles both .bashrc and .zshrc (Fly-specific requirement)
4. Sprite: amazonq, cline, gemini (3 scripts) - uses inject_env_vars_sprite
Total scripts converted in this commit: 25
Total scripts converted in Round 25 Task #1: 78 scripts
Each conversion replaces 11-15 lines of temp file management with a single
function call that handles creation, permissions, content generation, upload,
sourcing, and cleanup.
The only remaining ENV_TEMP patterns are DOTENV_TEMP in nanoclaw scripts,
which are agent-specific .env files and should remain as-is.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@louisgv
louisgv deleted the refactor/shared-lib-oauth-fallback branch February 8, 2026 05:15
la14-1 pushed a commit that referenced this pull request Feb 11, 2026
Add `spawn rerun [#]` to quickly relaunch a previous spawn by its
history number. The list view now shows row numbers (#1, #2, ...) and
relative timestamps ("2h ago", "3d ago") alongside absolute dates for
better scannability. Partially addresses #492.
Agent: ux-engineer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@louisgvlouisgv mentioned this pull request Feb 19, 2026
6 tasks
la14-1 pushed a commit that referenced this pull request May 2, 2026
… parses (#3384)
Reproduces with: any staged file matching the secret regex (e.g. a test
fixture containing an OpenRouter / Anthropic / OpenAI key shape).
The redact step ran:
sed -i -E "s|${SECRET_REGEX}|${REDACT_PLACEHOLDER}|g" "$f"
SECRET_REGEX is itself a `|`-separated alternation of provider patterns
(`(sk-or-v1-...)|(sk-ant-api...)|(...)`). After bash expansion, sed sees
multiple fields where it expected three, and bails with:
sed: -e expression #1, char 67: unknown option to `s'
The export then fails on the VM ("sprite exec failed (exit 1)") even
though the user already approved the redaction in the host prompt.
Fix: switch the sed delimiter to '#'. None of the regex tokens
(provider prefixes, char classes, quantifiers, PEM marker) contain '#',
and neither does the placeholder, so the substitution is unambiguous.
'|' inside the pattern is now correctly interpreted by sed -E as
alternation, which is what we wanted all along.
Adds a regression test asserting the script uses 's#...#...#g' and
not 's|...|...|g'.
Bumps CLI 1.0.35 -> 1.0.36.
la14-1 pushed a commit that referenced this pull request May 4, 2026
Numeric targets (target 140, cap 180) just become the new goal. The model
will pad to hit them instead of writing a punchy 40-char banger. Remove
all char-count anchors from the brevity guidance and let the good/bad
examples carry the signal.
- Rename section from 'BREVITY IS THE #1 RULE' to 'Keep it short'
- Drop 80-140 target, 180 cap, char-count example annotations
- Drop Chars line from output format and charCount from JSON
- Keep only the qualitative rules: don't pad, don't explain twice,
prefer one sentence, cut what isn't pulling weight
- Platform 280 cap mentioned once as a ceiling, not a goal
AhmedTMM pushed a commit that referenced this pull request May 4, 2026
#3390)
* fix(growth): enforce brevity in tweet prompt (target ≤140, hard cap 180)
Recent posted tweets were running 170-200 chars and reading as long-form
marketing copy. Tighten the tweet drafting prompt:
- Add a dedicated "BREVITY IS THE #1 RULE" section at the top
- Target 80-140 chars, hard cap 180 chars (down from the 280 platform limit)
- Good/bad length examples drawn from actual prior drafts
- Require a trim pass before output
- Update output format and rules to reflect the new caps
* fix(growth): drop numeric char targets, lean on taste
Numeric targets (target 140, cap 180) just become the new goal. The model
will pad to hit them instead of writing a punchy 40-char banger. Remove
all char-count anchors from the brevity guidance and let the good/bad
examples carry the signal.
- Rename section from 'BREVITY IS THE #1 RULE' to 'Keep it short'
- Drop 80-140 target, 180 cap, char-count example annotations
- Drop Chars line from output format and charCount from JSON
- Keep only the qualitative rules: don't pad, don't explain twice,
prefer one sentence, cut what isn't pulling weight
- Platform 280 cap mentioned once as a ceiling, not a goal
* fix(growth): strip all length references from tweet prompt
Even mentioning '280 char limit' or 'platform limit' anchors the model
to the wrong end of the range. Remove both remaining length references
so the prompt is purely about taste: say less, don't pad, cut what
isn't pulling weight. The platform enforces its own limit.
- Drop the 'platform 280 char limit is a ceiling' paragraph
- Drop 'Must fit in a tweet (under the platform limit)' from rules
---------
Co-authored-by: Claude <claude@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@louisgv
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Refactor spawn scripts with shared library and OAuth fallback - #1

Merged
louisgv merged 1 commit into
mainfrom
refactor/shared-lib-oauth-fallback
Feb 7, 2026
Merged

Refactor spawn scripts with shared library and OAuth fallback#1
louisgv merged 1 commit into
mainfrom
refactor/shared-lib-oauth-fallback

Conversation

@louisgv

Copy link
Copy Markdown
Collaborator

Summary

Major refactoring to improve code maintainability, reliability, and user experience:

🏗️ Shared Library Architecture

  • Created sprite/lib/common.sh with 12 reusable bash functions
  • openclaw.sh: 258 lines → 93 lines (-64%)
  • claude.sh: 272 lines → 101 lines (-63%)
  • Total: Eliminated ~330 lines of duplicate code

🔄 OAuth Fallback Mechanism

  • Automatic fallback to manual API key entry when OAuth fails
  • Handles missing netcat (nc) gracefully
  • Handles port conflicts and OAuth timeouts
  • API key format validation with override option
  • Works in headless and minimal environments

🌐 Dual Execution Mode

  • Local: bash sprite/openclaw.sh
  • Remote: curl URL | bash
  • Auto-detects execution context and sources library appropriately

New Shared Functions

Logging:

  • log_info(), log_warn(), log_error()

Sprite Setup:

  • ensure_sprite_installed() - Install sprite CLI if needed
  • ensure_sprite_authenticated() - Check/prompt for auth
  • ensure_sprite_exists() - Create sprite if doesn't exist
  • verify_sprite_connectivity() - Test sprite connection
  • run_sprite() - Execute commands on sprite

Environment:

  • setup_shell_environment() - Configure PATH and zsh

OAuth:

  • get_openrouter_api_key_oauth() - OAuth with fallback
  • try_oauth_flow() - Attempt OAuth (can fail gracefully)
  • get_openrouter_api_key_manual() - Manual API key entry

Utilities:

  • open_browser() - Cross-platform browser launch

Failure Scenarios Handled

✅ Missing netcat (nc)
✅ Port already in use
✅ OAuth server startup failure
✅ OAuth timeout (2 minute default)
✅ OAuth code exchange failure
✅ No browser available
✅ User cancellation

Documentation

  • REFACTORING.md - Architecture overview and benefits
  • OAUTH_FALLBACK.md - Fallback mechanism guide
  • CURL_BASH_SOLUTION.md - Execution mode details
  • EXAMPLES.md - Real-world usage scenarios
  • CHANGELOG.md - Complete change history

Test Plan

  • Syntax validation: All scripts pass bash -n
  • Local execution: Scripts work when run locally
  • Remote execution: Test curl | bash after merge
  • OAuth success: Verify OAuth flow completes
  • OAuth fallback: Test with missing nc
  • Manual entry: Test API key validation

Breaking Changes

None - scripts maintain identical functionality and command-line interface.

Benefits

  1. Maintainability: Common logic in one place
  2. Reliability: Graceful degradation when OAuth fails
  3. Extensibility: Future scripts can reuse all functions
  4. User Experience: Works in more environments
  5. Code Quality: DRY principle, better organization

🤖 Generated with Claude Code

Major refactoring to improve code maintainability and reliability:
## Shared Library Architecture
- Created sprite/lib/common.sh with reusable bash functions
- Reduced openclaw.sh from 258 to 93 lines (-64%)
- Reduced claude.sh from 272 to 101 lines (-63%)
- Eliminated ~330 lines of duplicate code
## OAuth Fallback Mechanism
- Added automatic fallback to manual API key entry
- Handles missing netcat (nc) gracefully
- Handles port conflicts and timeouts
- Validates API key format with override option
- Works in headless and minimal environments
## Dual Execution Support
- Local: bash sprite/openclaw.sh
- Remote: curl URL | bash
- Auto-detects context and sources library appropriately
## New Shared Functions
- Logging: log_info(), log_warn(), log_error()
- Sprite setup: ensure_sprite_installed/authenticated/exists()
- Environment: setup_shell_environment()
- OAuth: get_openrouter_api_key_oauth() with fallback
- Utilities: run_sprite(), verify_sprite_connectivity()
## Documentation
- REFACTORING.md - Architecture and benefits
- OAUTH_FALLBACK.md - Fallback mechanism guide
- CURL_BASH_SOLUTION.md - Execution mode details
- EXAMPLES.md - Usage scenarios
- CHANGELOG.md - Complete change history
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@louisgv
louisgv merged commit c0536e3 into mainFeb 7, 2026
louisgv pushed a commit that referenced this pull request Feb 8, 2026
Completed ENV_TEMP pattern extraction across remaining providers:
1. Modal: gptme.sh (1 script) - uses inject_env_vars_local
2. GCP: all 10 agent scripts - uses inject_env_vars_ssh
3. Fly.io: all 11 agent scripts - uses new inject_env_vars_fly
- Added inject_env_vars_fly() to fly/lib/common.sh
- Handles both .bashrc and .zshrc (Fly-specific requirement)
4. Sprite: amazonq, cline, gemini (3 scripts) - uses inject_env_vars_sprite
Total scripts converted in this commit: 25
Total scripts converted in Round 25 Task #1: 78 scripts
Each conversion replaces 11-15 lines of temp file management with a single
function call that handles creation, permissions, content generation, upload,
sourcing, and cleanup.
The only remaining ENV_TEMP patterns are DOTENV_TEMP in nanoclaw scripts,
which are agent-specific .env files and should remain as-is.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@louisgv
louisgv deleted the refactor/shared-lib-oauth-fallback branch February 8, 2026 05:15
la14-1 pushed a commit that referenced this pull request Feb 11, 2026
Add `spawn rerun [#]` to quickly relaunch a previous spawn by its
history number. The list view now shows row numbers (#1, #2, ...) and
relative timestamps ("2h ago", "3d ago") alongside absolute dates for
better scannability. Partially addresses #492.
Agent: ux-engineer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@louisgvlouisgv mentioned this pull request Feb 19, 2026
6 tasks
la14-1 pushed a commit that referenced this pull request May 2, 2026
… parses (#3384)
Reproduces with: any staged file matching the secret regex (e.g. a test
fixture containing an OpenRouter / Anthropic / OpenAI key shape).
The redact step ran:
sed -i -E "s|${SECRET_REGEX}|${REDACT_PLACEHOLDER}|g" "$f"
SECRET_REGEX is itself a `|`-separated alternation of provider patterns
(`(sk-or-v1-...)|(sk-ant-api...)|(...)`). After bash expansion, sed sees
multiple fields where it expected three, and bails with:
sed: -e expression #1, char 67: unknown option to `s'
The export then fails on the VM ("sprite exec failed (exit 1)") even
though the user already approved the redaction in the host prompt.
Fix: switch the sed delimiter to '#'. None of the regex tokens
(provider prefixes, char classes, quantifiers, PEM marker) contain '#',
and neither does the placeholder, so the substitution is unambiguous.
'|' inside the pattern is now correctly interpreted by sed -E as
alternation, which is what we wanted all along.
Adds a regression test asserting the script uses 's#...#...#g' and
not 's|...|...|g'.
Bumps CLI 1.0.35 -> 1.0.36.
la14-1 pushed a commit that referenced this pull request May 4, 2026
Numeric targets (target 140, cap 180) just become the new goal. The model
will pad to hit them instead of writing a punchy 40-char banger. Remove
all char-count anchors from the brevity guidance and let the good/bad
examples carry the signal.
- Rename section from 'BREVITY IS THE #1 RULE' to 'Keep it short'
- Drop 80-140 target, 180 cap, char-count example annotations
- Drop Chars line from output format and charCount from JSON
- Keep only the qualitative rules: don't pad, don't explain twice,
prefer one sentence, cut what isn't pulling weight
- Platform 280 cap mentioned once as a ceiling, not a goal
AhmedTMM pushed a commit that referenced this pull request May 4, 2026
#3390)
* fix(growth): enforce brevity in tweet prompt (target ≤140, hard cap 180)
Recent posted tweets were running 170-200 chars and reading as long-form
marketing copy. Tighten the tweet drafting prompt:
- Add a dedicated "BREVITY IS THE #1 RULE" section at the top
- Target 80-140 chars, hard cap 180 chars (down from the 280 platform limit)
- Good/bad length examples drawn from actual prior drafts
- Require a trim pass before output
- Update output format and rules to reflect the new caps
* fix(growth): drop numeric char targets, lean on taste
Numeric targets (target 140, cap 180) just become the new goal. The model
will pad to hit them instead of writing a punchy 40-char banger. Remove
all char-count anchors from the brevity guidance and let the good/bad
examples carry the signal.
- Rename section from 'BREVITY IS THE #1 RULE' to 'Keep it short'
- Drop 80-140 target, 180 cap, char-count example annotations
- Drop Chars line from output format and charCount from JSON
- Keep only the qualitative rules: don't pad, don't explain twice,
prefer one sentence, cut what isn't pulling weight
- Platform 280 cap mentioned once as a ceiling, not a goal
* fix(growth): strip all length references from tweet prompt
Even mentioning '280 char limit' or 'platform limit' anchors the model
to the wrong end of the range. Remove both remaining length references
so the prompt is purely about taste: say less, don't pad, cut what
isn't pulling weight. The platform enforces its own limit.
- Drop the 'platform 280 char limit is a ceiling' paragraph
- Drop 'Must fit in a tweet (under the platform limit)' from rules
---------
Co-authored-by: Claude <claude@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@louisgv
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Refactor spawn scripts with shared library and OAuth fallback - #1

Merged
louisgv merged 1 commit into
mainfrom
refactor/shared-lib-oauth-fallback
Feb 7, 2026
Merged

Refactor spawn scripts with shared library and OAuth fallback#1
louisgv merged 1 commit into
mainfrom
refactor/shared-lib-oauth-fallback

Conversation

@louisgv

Copy link
Copy Markdown
Collaborator

Summary

Major refactoring to improve code maintainability, reliability, and user experience:

🏗️ Shared Library Architecture

  • Created sprite/lib/common.sh with 12 reusable bash functions
  • openclaw.sh: 258 lines → 93 lines (-64%)
  • claude.sh: 272 lines → 101 lines (-63%)
  • Total: Eliminated ~330 lines of duplicate code

🔄 OAuth Fallback Mechanism

  • Automatic fallback to manual API key entry when OAuth fails
  • Handles missing netcat (nc) gracefully
  • Handles port conflicts and OAuth timeouts
  • API key format validation with override option
  • Works in headless and minimal environments

🌐 Dual Execution Mode

  • Local: bash sprite/openclaw.sh
  • Remote: curl URL | bash
  • Auto-detects execution context and sources library appropriately

New Shared Functions

Logging:

  • log_info(), log_warn(), log_error()

Sprite Setup:

  • ensure_sprite_installed() - Install sprite CLI if needed
  • ensure_sprite_authenticated() - Check/prompt for auth
  • ensure_sprite_exists() - Create sprite if doesn't exist
  • verify_sprite_connectivity() - Test sprite connection
  • run_sprite() - Execute commands on sprite

Environment:

  • setup_shell_environment() - Configure PATH and zsh

OAuth:

  • get_openrouter_api_key_oauth() - OAuth with fallback
  • try_oauth_flow() - Attempt OAuth (can fail gracefully)
  • get_openrouter_api_key_manual() - Manual API key entry

Utilities:

  • open_browser() - Cross-platform browser launch

Failure Scenarios Handled

✅ Missing netcat (nc)
✅ Port already in use
✅ OAuth server startup failure
✅ OAuth timeout (2 minute default)
✅ OAuth code exchange failure
✅ No browser available
✅ User cancellation

Documentation

  • REFACTORING.md - Architecture overview and benefits
  • OAUTH_FALLBACK.md - Fallback mechanism guide
  • CURL_BASH_SOLUTION.md - Execution mode details
  • EXAMPLES.md - Real-world usage scenarios
  • CHANGELOG.md - Complete change history

Test Plan

  • Syntax validation: All scripts pass bash -n
  • Local execution: Scripts work when run locally
  • Remote execution: Test curl | bash after merge
  • OAuth success: Verify OAuth flow completes
  • OAuth fallback: Test with missing nc
  • Manual entry: Test API key validation

Breaking Changes

None - scripts maintain identical functionality and command-line interface.

Benefits

  1. Maintainability: Common logic in one place
  2. Reliability: Graceful degradation when OAuth fails
  3. Extensibility: Future scripts can reuse all functions
  4. User Experience: Works in more environments
  5. Code Quality: DRY principle, better organization

🤖 Generated with Claude Code

Major refactoring to improve code maintainability and reliability:
## Shared Library Architecture
- Created sprite/lib/common.sh with reusable bash functions
- Reduced openclaw.sh from 258 to 93 lines (-64%)
- Reduced claude.sh from 272 to 101 lines (-63%)
- Eliminated ~330 lines of duplicate code
## OAuth Fallback Mechanism
- Added automatic fallback to manual API key entry
- Handles missing netcat (nc) gracefully
- Handles port conflicts and timeouts
- Validates API key format with override option
- Works in headless and minimal environments
## Dual Execution Support
- Local: bash sprite/openclaw.sh
- Remote: curl URL | bash
- Auto-detects context and sources library appropriately
## New Shared Functions
- Logging: log_info(), log_warn(), log_error()
- Sprite setup: ensure_sprite_installed/authenticated/exists()
- Environment: setup_shell_environment()
- OAuth: get_openrouter_api_key_oauth() with fallback
- Utilities: run_sprite(), verify_sprite_connectivity()
## Documentation
- REFACTORING.md - Architecture and benefits
- OAUTH_FALLBACK.md - Fallback mechanism guide
- CURL_BASH_SOLUTION.md - Execution mode details
- EXAMPLES.md - Usage scenarios
- CHANGELOG.md - Complete change history
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@louisgv
louisgv merged commit c0536e3 into mainFeb 7, 2026
louisgv pushed a commit that referenced this pull request Feb 8, 2026
Completed ENV_TEMP pattern extraction across remaining providers:
1. Modal: gptme.sh (1 script) - uses inject_env_vars_local
2. GCP: all 10 agent scripts - uses inject_env_vars_ssh
3. Fly.io: all 11 agent scripts - uses new inject_env_vars_fly
- Added inject_env_vars_fly() to fly/lib/common.sh
- Handles both .bashrc and .zshrc (Fly-specific requirement)
4. Sprite: amazonq, cline, gemini (3 scripts) - uses inject_env_vars_sprite
Total scripts converted in this commit: 25
Total scripts converted in Round 25 Task #1: 78 scripts
Each conversion replaces 11-15 lines of temp file management with a single
function call that handles creation, permissions, content generation, upload,
sourcing, and cleanup.
The only remaining ENV_TEMP patterns are DOTENV_TEMP in nanoclaw scripts,
which are agent-specific .env files and should remain as-is.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@louisgv
louisgv deleted the refactor/shared-lib-oauth-fallback branch February 8, 2026 05:15
la14-1 pushed a commit that referenced this pull request Feb 11, 2026
Add `spawn rerun [#]` to quickly relaunch a previous spawn by its
history number. The list view now shows row numbers (#1, #2, ...) and
relative timestamps ("2h ago", "3d ago") alongside absolute dates for
better scannability. Partially addresses #492.
Agent: ux-engineer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@louisgvlouisgv mentioned this pull request Feb 19, 2026
6 tasks
la14-1 pushed a commit that referenced this pull request May 2, 2026
… parses (#3384)
Reproduces with: any staged file matching the secret regex (e.g. a test
fixture containing an OpenRouter / Anthropic / OpenAI key shape).
The redact step ran:
sed -i -E "s|${SECRET_REGEX}|${REDACT_PLACEHOLDER}|g" "$f"
SECRET_REGEX is itself a `|`-separated alternation of provider patterns
(`(sk-or-v1-...)|(sk-ant-api...)|(...)`). After bash expansion, sed sees
multiple fields where it expected three, and bails with:
sed: -e expression #1, char 67: unknown option to `s'
The export then fails on the VM ("sprite exec failed (exit 1)") even
though the user already approved the redaction in the host prompt.
Fix: switch the sed delimiter to '#'. None of the regex tokens
(provider prefixes, char classes, quantifiers, PEM marker) contain '#',
and neither does the placeholder, so the substitution is unambiguous.
'|' inside the pattern is now correctly interpreted by sed -E as
alternation, which is what we wanted all along.
Adds a regression test asserting the script uses 's#...#...#g' and
not 's|...|...|g'.
Bumps CLI 1.0.35 -> 1.0.36.
la14-1 pushed a commit that referenced this pull request May 4, 2026
Numeric targets (target 140, cap 180) just become the new goal. The model
will pad to hit them instead of writing a punchy 40-char banger. Remove
all char-count anchors from the brevity guidance and let the good/bad
examples carry the signal.
- Rename section from 'BREVITY IS THE #1 RULE' to 'Keep it short'
- Drop 80-140 target, 180 cap, char-count example annotations
- Drop Chars line from output format and charCount from JSON
- Keep only the qualitative rules: don't pad, don't explain twice,
prefer one sentence, cut what isn't pulling weight
- Platform 280 cap mentioned once as a ceiling, not a goal
AhmedTMM pushed a commit that referenced this pull request May 4, 2026
#3390)
* fix(growth): enforce brevity in tweet prompt (target ≤140, hard cap 180)
Recent posted tweets were running 170-200 chars and reading as long-form
marketing copy. Tighten the tweet drafting prompt:
- Add a dedicated "BREVITY IS THE #1 RULE" section at the top
- Target 80-140 chars, hard cap 180 chars (down from the 280 platform limit)
- Good/bad length examples drawn from actual prior drafts
- Require a trim pass before output
- Update output format and rules to reflect the new caps
* fix(growth): drop numeric char targets, lean on taste
Numeric targets (target 140, cap 180) just become the new goal. The model
will pad to hit them instead of writing a punchy 40-char banger. Remove
all char-count anchors from the brevity guidance and let the good/bad
examples carry the signal.
- Rename section from 'BREVITY IS THE #1 RULE' to 'Keep it short'
- Drop 80-140 target, 180 cap, char-count example annotations
- Drop Chars line from output format and charCount from JSON
- Keep only the qualitative rules: don't pad, don't explain twice,
prefer one sentence, cut what isn't pulling weight
- Platform 280 cap mentioned once as a ceiling, not a goal
* fix(growth): strip all length references from tweet prompt
Even mentioning '280 char limit' or 'platform limit' anchors the model
to the wrong end of the range. Remove both remaining length references
so the prompt is purely about taste: say less, don't pad, cut what
isn't pulling weight. The platform enforces its own limit.
- Drop the 'platform 280 char limit is a ceiling' paragraph
- Drop 'Must fit in a tweet (under the platform limit)' from rules
---------
Co-authored-by: Claude <claude@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@louisgv
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Refactor spawn scripts with shared library and OAuth fallback - #1

Merged
louisgv merged 1 commit into
mainfrom
refactor/shared-lib-oauth-fallback
Feb 7, 2026
Merged

Refactor spawn scripts with shared library and OAuth fallback#1
louisgv merged 1 commit into
mainfrom
refactor/shared-lib-oauth-fallback

Conversation

@louisgv

Copy link
Copy Markdown
Collaborator

Summary

Major refactoring to improve code maintainability, reliability, and user experience:

🏗️ Shared Library Architecture

  • Created sprite/lib/common.sh with 12 reusable bash functions
  • openclaw.sh: 258 lines → 93 lines (-64%)
  • claude.sh: 272 lines → 101 lines (-63%)
  • Total: Eliminated ~330 lines of duplicate code

🔄 OAuth Fallback Mechanism

  • Automatic fallback to manual API key entry when OAuth fails
  • Handles missing netcat (nc) gracefully
  • Handles port conflicts and OAuth timeouts
  • API key format validation with override option
  • Works in headless and minimal environments

🌐 Dual Execution Mode

  • Local: bash sprite/openclaw.sh
  • Remote: curl URL | bash
  • Auto-detects execution context and sources library appropriately

New Shared Functions

Logging:

  • log_info(), log_warn(), log_error()

Sprite Setup:

  • ensure_sprite_installed() - Install sprite CLI if needed
  • ensure_sprite_authenticated() - Check/prompt for auth
  • ensure_sprite_exists() - Create sprite if doesn't exist
  • verify_sprite_connectivity() - Test sprite connection
  • run_sprite() - Execute commands on sprite

Environment:

  • setup_shell_environment() - Configure PATH and zsh

OAuth:

  • get_openrouter_api_key_oauth() - OAuth with fallback
  • try_oauth_flow() - Attempt OAuth (can fail gracefully)
  • get_openrouter_api_key_manual() - Manual API key entry

Utilities:

  • open_browser() - Cross-platform browser launch

Failure Scenarios Handled

✅ Missing netcat (nc)
✅ Port already in use
✅ OAuth server startup failure
✅ OAuth timeout (2 minute default)
✅ OAuth code exchange failure
✅ No browser available
✅ User cancellation

Documentation

  • REFACTORING.md - Architecture overview and benefits
  • OAUTH_FALLBACK.md - Fallback mechanism guide
  • CURL_BASH_SOLUTION.md - Execution mode details
  • EXAMPLES.md - Real-world usage scenarios
  • CHANGELOG.md - Complete change history

Test Plan

  • Syntax validation: All scripts pass bash -n
  • Local execution: Scripts work when run locally
  • Remote execution: Test curl | bash after merge
  • OAuth success: Verify OAuth flow completes
  • OAuth fallback: Test with missing nc
  • Manual entry: Test API key validation

Breaking Changes

None - scripts maintain identical functionality and command-line interface.

Benefits

  1. Maintainability: Common logic in one place
  2. Reliability: Graceful degradation when OAuth fails
  3. Extensibility: Future scripts can reuse all functions
  4. User Experience: Works in more environments
  5. Code Quality: DRY principle, better organization

🤖 Generated with Claude Code

Major refactoring to improve code maintainability and reliability:
## Shared Library Architecture
- Created sprite/lib/common.sh with reusable bash functions
- Reduced openclaw.sh from 258 to 93 lines (-64%)
- Reduced claude.sh from 272 to 101 lines (-63%)
- Eliminated ~330 lines of duplicate code
## OAuth Fallback Mechanism
- Added automatic fallback to manual API key entry
- Handles missing netcat (nc) gracefully
- Handles port conflicts and timeouts
- Validates API key format with override option
- Works in headless and minimal environments
## Dual Execution Support
- Local: bash sprite/openclaw.sh
- Remote: curl URL | bash
- Auto-detects context and sources library appropriately
## New Shared Functions
- Logging: log_info(), log_warn(), log_error()
- Sprite setup: ensure_sprite_installed/authenticated/exists()
- Environment: setup_shell_environment()
- OAuth: get_openrouter_api_key_oauth() with fallback
- Utilities: run_sprite(), verify_sprite_connectivity()
## Documentation
- REFACTORING.md - Architecture and benefits
- OAUTH_FALLBACK.md - Fallback mechanism guide
- CURL_BASH_SOLUTION.md - Execution mode details
- EXAMPLES.md - Usage scenarios
- CHANGELOG.md - Complete change history
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@louisgv
louisgv merged commit c0536e3 into mainFeb 7, 2026
louisgv pushed a commit that referenced this pull request Feb 8, 2026
Completed ENV_TEMP pattern extraction across remaining providers:
1. Modal: gptme.sh (1 script) - uses inject_env_vars_local
2. GCP: all 10 agent scripts - uses inject_env_vars_ssh
3. Fly.io: all 11 agent scripts - uses new inject_env_vars_fly
- Added inject_env_vars_fly() to fly/lib/common.sh
- Handles both .bashrc and .zshrc (Fly-specific requirement)
4. Sprite: amazonq, cline, gemini (3 scripts) - uses inject_env_vars_sprite
Total scripts converted in this commit: 25
Total scripts converted in Round 25 Task #1: 78 scripts
Each conversion replaces 11-15 lines of temp file management with a single
function call that handles creation, permissions, content generation, upload,
sourcing, and cleanup.
The only remaining ENV_TEMP patterns are DOTENV_TEMP in nanoclaw scripts,
which are agent-specific .env files and should remain as-is.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@louisgv
louisgv deleted the refactor/shared-lib-oauth-fallback branch February 8, 2026 05:15
la14-1 pushed a commit that referenced this pull request Feb 11, 2026
Add `spawn rerun [#]` to quickly relaunch a previous spawn by its
history number. The list view now shows row numbers (#1, #2, ...) and
relative timestamps ("2h ago", "3d ago") alongside absolute dates for
better scannability. Partially addresses #492.
Agent: ux-engineer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@louisgvlouisgv mentioned this pull request Feb 19, 2026
6 tasks
la14-1 pushed a commit that referenced this pull request May 2, 2026
… parses (#3384)
Reproduces with: any staged file matching the secret regex (e.g. a test
fixture containing an OpenRouter / Anthropic / OpenAI key shape).
The redact step ran:
sed -i -E "s|${SECRET_REGEX}|${REDACT_PLACEHOLDER}|g" "$f"
SECRET_REGEX is itself a `|`-separated alternation of provider patterns
(`(sk-or-v1-...)|(sk-ant-api...)|(...)`). After bash expansion, sed sees
multiple fields where it expected three, and bails with:
sed: -e expression #1, char 67: unknown option to `s'
The export then fails on the VM ("sprite exec failed (exit 1)") even
though the user already approved the redaction in the host prompt.
Fix: switch the sed delimiter to '#'. None of the regex tokens
(provider prefixes, char classes, quantifiers, PEM marker) contain '#',
and neither does the placeholder, so the substitution is unambiguous.
'|' inside the pattern is now correctly interpreted by sed -E as
alternation, which is what we wanted all along.
Adds a regression test asserting the script uses 's#...#...#g' and
not 's|...|...|g'.
Bumps CLI 1.0.35 -> 1.0.36.
la14-1 pushed a commit that referenced this pull request May 4, 2026
Numeric targets (target 140, cap 180) just become the new goal. The model
will pad to hit them instead of writing a punchy 40-char banger. Remove
all char-count anchors from the brevity guidance and let the good/bad
examples carry the signal.
- Rename section from 'BREVITY IS THE #1 RULE' to 'Keep it short'
- Drop 80-140 target, 180 cap, char-count example annotations
- Drop Chars line from output format and charCount from JSON
- Keep only the qualitative rules: don't pad, don't explain twice,
prefer one sentence, cut what isn't pulling weight
- Platform 280 cap mentioned once as a ceiling, not a goal
AhmedTMM pushed a commit that referenced this pull request May 4, 2026
#3390)
* fix(growth): enforce brevity in tweet prompt (target ≤140, hard cap 180)
Recent posted tweets were running 170-200 chars and reading as long-form
marketing copy. Tighten the tweet drafting prompt:
- Add a dedicated "BREVITY IS THE #1 RULE" section at the top
- Target 80-140 chars, hard cap 180 chars (down from the 280 platform limit)
- Good/bad length examples drawn from actual prior drafts
- Require a trim pass before output
- Update output format and rules to reflect the new caps
* fix(growth): drop numeric char targets, lean on taste
Numeric targets (target 140, cap 180) just become the new goal. The model
will pad to hit them instead of writing a punchy 40-char banger. Remove
all char-count anchors from the brevity guidance and let the good/bad
examples carry the signal.
- Rename section from 'BREVITY IS THE #1 RULE' to 'Keep it short'
- Drop 80-140 target, 180 cap, char-count example annotations
- Drop Chars line from output format and charCount from JSON
- Keep only the qualitative rules: don't pad, don't explain twice,
prefer one sentence, cut what isn't pulling weight
- Platform 280 cap mentioned once as a ceiling, not a goal
* fix(growth): strip all length references from tweet prompt
Even mentioning '280 char limit' or 'platform limit' anchors the model
to the wrong end of the range. Remove both remaining length references
so the prompt is purely about taste: say less, don't pad, cut what
isn't pulling weight. The platform enforces its own limit.
- Drop the 'platform 280 char limit is a ceiling' paragraph
- Drop 'Must fit in a tweet (under the platform limit)' from rules
---------
Co-authored-by: Claude <claude@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@louisgv
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Refactor spawn scripts with shared library and OAuth fallback - #1

Merged
louisgv merged 1 commit into
mainfrom
refactor/shared-lib-oauth-fallback
Feb 7, 2026
Merged

Refactor spawn scripts with shared library and OAuth fallback#1
louisgv merged 1 commit into
mainfrom
refactor/shared-lib-oauth-fallback

Conversation

@louisgv

Copy link
Copy Markdown
Collaborator

Summary

Major refactoring to improve code maintainability, reliability, and user experience:

🏗️ Shared Library Architecture

  • Created sprite/lib/common.sh with 12 reusable bash functions
  • openclaw.sh: 258 lines → 93 lines (-64%)
  • claude.sh: 272 lines → 101 lines (-63%)
  • Total: Eliminated ~330 lines of duplicate code

🔄 OAuth Fallback Mechanism

  • Automatic fallback to manual API key entry when OAuth fails
  • Handles missing netcat (nc) gracefully
  • Handles port conflicts and OAuth timeouts
  • API key format validation with override option
  • Works in headless and minimal environments

🌐 Dual Execution Mode

  • Local: bash sprite/openclaw.sh
  • Remote: curl URL | bash
  • Auto-detects execution context and sources library appropriately

New Shared Functions

Logging:

  • log_info(), log_warn(), log_error()

Sprite Setup:

  • ensure_sprite_installed() - Install sprite CLI if needed
  • ensure_sprite_authenticated() - Check/prompt for auth
  • ensure_sprite_exists() - Create sprite if doesn't exist
  • verify_sprite_connectivity() - Test sprite connection
  • run_sprite() - Execute commands on sprite

Environment:

  • setup_shell_environment() - Configure PATH and zsh

OAuth:

  • get_openrouter_api_key_oauth() - OAuth with fallback
  • try_oauth_flow() - Attempt OAuth (can fail gracefully)
  • get_openrouter_api_key_manual() - Manual API key entry

Utilities:

  • open_browser() - Cross-platform browser launch

Failure Scenarios Handled

✅ Missing netcat (nc)
✅ Port already in use
✅ OAuth server startup failure
✅ OAuth timeout (2 minute default)
✅ OAuth code exchange failure
✅ No browser available
✅ User cancellation

Documentation

  • REFACTORING.md - Architecture overview and benefits
  • OAUTH_FALLBACK.md - Fallback mechanism guide
  • CURL_BASH_SOLUTION.md - Execution mode details
  • EXAMPLES.md - Real-world usage scenarios
  • CHANGELOG.md - Complete change history

Test Plan

  • Syntax validation: All scripts pass bash -n
  • Local execution: Scripts work when run locally
  • Remote execution: Test curl | bash after merge
  • OAuth success: Verify OAuth flow completes
  • OAuth fallback: Test with missing nc
  • Manual entry: Test API key validation

Breaking Changes

None - scripts maintain identical functionality and command-line interface.

Benefits

  1. Maintainability: Common logic in one place
  2. Reliability: Graceful degradation when OAuth fails
  3. Extensibility: Future scripts can reuse all functions
  4. User Experience: Works in more environments
  5. Code Quality: DRY principle, better organization

🤖 Generated with Claude Code

Major refactoring to improve code maintainability and reliability:
## Shared Library Architecture
- Created sprite/lib/common.sh with reusable bash functions
- Reduced openclaw.sh from 258 to 93 lines (-64%)
- Reduced claude.sh from 272 to 101 lines (-63%)
- Eliminated ~330 lines of duplicate code
## OAuth Fallback Mechanism
- Added automatic fallback to manual API key entry
- Handles missing netcat (nc) gracefully
- Handles port conflicts and timeouts
- Validates API key format with override option
- Works in headless and minimal environments
## Dual Execution Support
- Local: bash sprite/openclaw.sh
- Remote: curl URL | bash
- Auto-detects context and sources library appropriately
## New Shared Functions
- Logging: log_info(), log_warn(), log_error()
- Sprite setup: ensure_sprite_installed/authenticated/exists()
- Environment: setup_shell_environment()
- OAuth: get_openrouter_api_key_oauth() with fallback
- Utilities: run_sprite(), verify_sprite_connectivity()
## Documentation
- REFACTORING.md - Architecture and benefits
- OAUTH_FALLBACK.md - Fallback mechanism guide
- CURL_BASH_SOLUTION.md - Execution mode details
- EXAMPLES.md - Usage scenarios
- CHANGELOG.md - Complete change history
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@louisgv
louisgv merged commit c0536e3 into mainFeb 7, 2026
louisgv pushed a commit that referenced this pull request Feb 8, 2026
Completed ENV_TEMP pattern extraction across remaining providers:
1. Modal: gptme.sh (1 script) - uses inject_env_vars_local
2. GCP: all 10 agent scripts - uses inject_env_vars_ssh
3. Fly.io: all 11 agent scripts - uses new inject_env_vars_fly
- Added inject_env_vars_fly() to fly/lib/common.sh
- Handles both .bashrc and .zshrc (Fly-specific requirement)
4. Sprite: amazonq, cline, gemini (3 scripts) - uses inject_env_vars_sprite
Total scripts converted in this commit: 25
Total scripts converted in Round 25 Task #1: 78 scripts
Each conversion replaces 11-15 lines of temp file management with a single
function call that handles creation, permissions, content generation, upload,
sourcing, and cleanup.
The only remaining ENV_TEMP patterns are DOTENV_TEMP in nanoclaw scripts,
which are agent-specific .env files and should remain as-is.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@louisgv
louisgv deleted the refactor/shared-lib-oauth-fallback branch February 8, 2026 05:15
la14-1 pushed a commit that referenced this pull request Feb 11, 2026
Add `spawn rerun [#]` to quickly relaunch a previous spawn by its
history number. The list view now shows row numbers (#1, #2, ...) and
relative timestamps ("2h ago", "3d ago") alongside absolute dates for
better scannability. Partially addresses #492.
Agent: ux-engineer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@louisgvlouisgv mentioned this pull request Feb 19, 2026
6 tasks
la14-1 pushed a commit that referenced this pull request May 2, 2026
… parses (#3384)
Reproduces with: any staged file matching the secret regex (e.g. a test
fixture containing an OpenRouter / Anthropic / OpenAI key shape).
The redact step ran:
sed -i -E "s|${SECRET_REGEX}|${REDACT_PLACEHOLDER}|g" "$f"
SECRET_REGEX is itself a `|`-separated alternation of provider patterns
(`(sk-or-v1-...)|(sk-ant-api...)|(...)`). After bash expansion, sed sees
multiple fields where it expected three, and bails with:
sed: -e expression #1, char 67: unknown option to `s'
The export then fails on the VM ("sprite exec failed (exit 1)") even
though the user already approved the redaction in the host prompt.
Fix: switch the sed delimiter to '#'. None of the regex tokens
(provider prefixes, char classes, quantifiers, PEM marker) contain '#',
and neither does the placeholder, so the substitution is unambiguous.
'|' inside the pattern is now correctly interpreted by sed -E as
alternation, which is what we wanted all along.
Adds a regression test asserting the script uses 's#...#...#g' and
not 's|...|...|g'.
Bumps CLI 1.0.35 -> 1.0.36.
la14-1 pushed a commit that referenced this pull request May 4, 2026
Numeric targets (target 140, cap 180) just become the new goal. The model
will pad to hit them instead of writing a punchy 40-char banger. Remove
all char-count anchors from the brevity guidance and let the good/bad
examples carry the signal.
- Rename section from 'BREVITY IS THE #1 RULE' to 'Keep it short'
- Drop 80-140 target, 180 cap, char-count example annotations
- Drop Chars line from output format and charCount from JSON
- Keep only the qualitative rules: don't pad, don't explain twice,
prefer one sentence, cut what isn't pulling weight
- Platform 280 cap mentioned once as a ceiling, not a goal
AhmedTMM pushed a commit that referenced this pull request May 4, 2026
#3390)
* fix(growth): enforce brevity in tweet prompt (target ≤140, hard cap 180)
Recent posted tweets were running 170-200 chars and reading as long-form
marketing copy. Tighten the tweet drafting prompt:
- Add a dedicated "BREVITY IS THE #1 RULE" section at the top
- Target 80-140 chars, hard cap 180 chars (down from the 280 platform limit)
- Good/bad length examples drawn from actual prior drafts
- Require a trim pass before output
- Update output format and rules to reflect the new caps
* fix(growth): drop numeric char targets, lean on taste
Numeric targets (target 140, cap 180) just become the new goal. The model
will pad to hit them instead of writing a punchy 40-char banger. Remove
all char-count anchors from the brevity guidance and let the good/bad
examples carry the signal.
- Rename section from 'BREVITY IS THE #1 RULE' to 'Keep it short'
- Drop 80-140 target, 180 cap, char-count example annotations
- Drop Chars line from output format and charCount from JSON
- Keep only the qualitative rules: don't pad, don't explain twice,
prefer one sentence, cut what isn't pulling weight
- Platform 280 cap mentioned once as a ceiling, not a goal
* fix(growth): strip all length references from tweet prompt
Even mentioning '280 char limit' or 'platform limit' anchors the model
to the wrong end of the range. Remove both remaining length references
so the prompt is purely about taste: say less, don't pad, cut what
isn't pulling weight. The platform enforces its own limit.
- Drop the 'platform 280 char limit is a ceiling' paragraph
- Drop 'Must fit in a tweet (under the platform limit)' from rules
---------
Co-authored-by: Claude <claude@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@louisgv
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Refactor spawn scripts with shared library and OAuth fallback - #1

Merged
louisgv merged 1 commit into
mainfrom
refactor/shared-lib-oauth-fallback
Feb 7, 2026
Merged

Refactor spawn scripts with shared library and OAuth fallback#1
louisgv merged 1 commit into
mainfrom
refactor/shared-lib-oauth-fallback

Conversation

@louisgv

Copy link
Copy Markdown
Collaborator

Summary

Major refactoring to improve code maintainability, reliability, and user experience:

🏗️ Shared Library Architecture

  • Created sprite/lib/common.sh with 12 reusable bash functions
  • openclaw.sh: 258 lines → 93 lines (-64%)
  • claude.sh: 272 lines → 101 lines (-63%)
  • Total: Eliminated ~330 lines of duplicate code

🔄 OAuth Fallback Mechanism

  • Automatic fallback to manual API key entry when OAuth fails
  • Handles missing netcat (nc) gracefully
  • Handles port conflicts and OAuth timeouts
  • API key format validation with override option
  • Works in headless and minimal environments

🌐 Dual Execution Mode

  • Local: bash sprite/openclaw.sh
  • Remote: curl URL | bash
  • Auto-detects execution context and sources library appropriately

New Shared Functions

Logging:

  • log_info(), log_warn(), log_error()

Sprite Setup:

  • ensure_sprite_installed() - Install sprite CLI if needed
  • ensure_sprite_authenticated() - Check/prompt for auth
  • ensure_sprite_exists() - Create sprite if doesn't exist
  • verify_sprite_connectivity() - Test sprite connection
  • run_sprite() - Execute commands on sprite

Environment:

  • setup_shell_environment() - Configure PATH and zsh

OAuth:

  • get_openrouter_api_key_oauth() - OAuth with fallback
  • try_oauth_flow() - Attempt OAuth (can fail gracefully)
  • get_openrouter_api_key_manual() - Manual API key entry

Utilities:

  • open_browser() - Cross-platform browser launch

Failure Scenarios Handled

✅ Missing netcat (nc)
✅ Port already in use
✅ OAuth server startup failure
✅ OAuth timeout (2 minute default)
✅ OAuth code exchange failure
✅ No browser available
✅ User cancellation

Documentation

  • REFACTORING.md - Architecture overview and benefits
  • OAUTH_FALLBACK.md - Fallback mechanism guide
  • CURL_BASH_SOLUTION.md - Execution mode details
  • EXAMPLES.md - Real-world usage scenarios
  • CHANGELOG.md - Complete change history

Test Plan

  • Syntax validation: All scripts pass bash -n
  • Local execution: Scripts work when run locally
  • Remote execution: Test curl | bash after merge
  • OAuth success: Verify OAuth flow completes
  • OAuth fallback: Test with missing nc
  • Manual entry: Test API key validation

Breaking Changes

None - scripts maintain identical functionality and command-line interface.

Benefits

  1. Maintainability: Common logic in one place
  2. Reliability: Graceful degradation when OAuth fails
  3. Extensibility: Future scripts can reuse all functions
  4. User Experience: Works in more environments
  5. Code Quality: DRY principle, better organization

🤖 Generated with Claude Code

Major refactoring to improve code maintainability and reliability:
## Shared Library Architecture
- Created sprite/lib/common.sh with reusable bash functions
- Reduced openclaw.sh from 258 to 93 lines (-64%)
- Reduced claude.sh from 272 to 101 lines (-63%)
- Eliminated ~330 lines of duplicate code
## OAuth Fallback Mechanism
- Added automatic fallback to manual API key entry
- Handles missing netcat (nc) gracefully
- Handles port conflicts and timeouts
- Validates API key format with override option
- Works in headless and minimal environments
## Dual Execution Support
- Local: bash sprite/openclaw.sh
- Remote: curl URL | bash
- Auto-detects context and sources library appropriately
## New Shared Functions
- Logging: log_info(), log_warn(), log_error()
- Sprite setup: ensure_sprite_installed/authenticated/exists()
- Environment: setup_shell_environment()
- OAuth: get_openrouter_api_key_oauth() with fallback
- Utilities: run_sprite(), verify_sprite_connectivity()
## Documentation
- REFACTORING.md - Architecture and benefits
- OAUTH_FALLBACK.md - Fallback mechanism guide
- CURL_BASH_SOLUTION.md - Execution mode details
- EXAMPLES.md - Usage scenarios
- CHANGELOG.md - Complete change history
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@louisgv
louisgv merged commit c0536e3 into mainFeb 7, 2026
louisgv pushed a commit that referenced this pull request Feb 8, 2026
Completed ENV_TEMP pattern extraction across remaining providers:
1. Modal: gptme.sh (1 script) - uses inject_env_vars_local
2. GCP: all 10 agent scripts - uses inject_env_vars_ssh
3. Fly.io: all 11 agent scripts - uses new inject_env_vars_fly
- Added inject_env_vars_fly() to fly/lib/common.sh
- Handles both .bashrc and .zshrc (Fly-specific requirement)
4. Sprite: amazonq, cline, gemini (3 scripts) - uses inject_env_vars_sprite
Total scripts converted in this commit: 25
Total scripts converted in Round 25 Task #1: 78 scripts
Each conversion replaces 11-15 lines of temp file management with a single
function call that handles creation, permissions, content generation, upload,
sourcing, and cleanup.
The only remaining ENV_TEMP patterns are DOTENV_TEMP in nanoclaw scripts,
which are agent-specific .env files and should remain as-is.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@louisgv
louisgv deleted the refactor/shared-lib-oauth-fallback branch February 8, 2026 05:15
la14-1 pushed a commit that referenced this pull request Feb 11, 2026
Add `spawn rerun [#]` to quickly relaunch a previous spawn by its
history number. The list view now shows row numbers (#1, #2, ...) and
relative timestamps ("2h ago", "3d ago") alongside absolute dates for
better scannability. Partially addresses #492.
Agent: ux-engineer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@louisgvlouisgv mentioned this pull request Feb 19, 2026
6 tasks
la14-1 pushed a commit that referenced this pull request May 2, 2026
… parses (#3384)
Reproduces with: any staged file matching the secret regex (e.g. a test
fixture containing an OpenRouter / Anthropic / OpenAI key shape).
The redact step ran:
sed -i -E "s|${SECRET_REGEX}|${REDACT_PLACEHOLDER}|g" "$f"
SECRET_REGEX is itself a `|`-separated alternation of provider patterns
(`(sk-or-v1-...)|(sk-ant-api...)|(...)`). After bash expansion, sed sees
multiple fields where it expected three, and bails with:
sed: -e expression #1, char 67: unknown option to `s'
The export then fails on the VM ("sprite exec failed (exit 1)") even
though the user already approved the redaction in the host prompt.
Fix: switch the sed delimiter to '#'. None of the regex tokens
(provider prefixes, char classes, quantifiers, PEM marker) contain '#',
and neither does the placeholder, so the substitution is unambiguous.
'|' inside the pattern is now correctly interpreted by sed -E as
alternation, which is what we wanted all along.
Adds a regression test asserting the script uses 's#...#...#g' and
not 's|...|...|g'.
Bumps CLI 1.0.35 -> 1.0.36.
la14-1 pushed a commit that referenced this pull request May 4, 2026
Numeric targets (target 140, cap 180) just become the new goal. The model
will pad to hit them instead of writing a punchy 40-char banger. Remove
all char-count anchors from the brevity guidance and let the good/bad
examples carry the signal.
- Rename section from 'BREVITY IS THE #1 RULE' to 'Keep it short'
- Drop 80-140 target, 180 cap, char-count example annotations
- Drop Chars line from output format and charCount from JSON
- Keep only the qualitative rules: don't pad, don't explain twice,
prefer one sentence, cut what isn't pulling weight
- Platform 280 cap mentioned once as a ceiling, not a goal
AhmedTMM pushed a commit that referenced this pull request May 4, 2026
#3390)
* fix(growth): enforce brevity in tweet prompt (target ≤140, hard cap 180)
Recent posted tweets were running 170-200 chars and reading as long-form
marketing copy. Tighten the tweet drafting prompt:
- Add a dedicated "BREVITY IS THE #1 RULE" section at the top
- Target 80-140 chars, hard cap 180 chars (down from the 280 platform limit)
- Good/bad length examples drawn from actual prior drafts
- Require a trim pass before output
- Update output format and rules to reflect the new caps
* fix(growth): drop numeric char targets, lean on taste
Numeric targets (target 140, cap 180) just become the new goal. The model
will pad to hit them instead of writing a punchy 40-char banger. Remove
all char-count anchors from the brevity guidance and let the good/bad
examples carry the signal.
- Rename section from 'BREVITY IS THE #1 RULE' to 'Keep it short'
- Drop 80-140 target, 180 cap, char-count example annotations
- Drop Chars line from output format and charCount from JSON
- Keep only the qualitative rules: don't pad, don't explain twice,
prefer one sentence, cut what isn't pulling weight
- Platform 280 cap mentioned once as a ceiling, not a goal
* fix(growth): strip all length references from tweet prompt
Even mentioning '280 char limit' or 'platform limit' anchors the model
to the wrong end of the range. Remove both remaining length references
so the prompt is purely about taste: say less, don't pad, cut what
isn't pulling weight. The platform enforces its own limit.
- Drop the 'platform 280 char limit is a ceiling' paragraph
- Drop 'Must fit in a tweet (under the platform limit)' from rules
---------
Co-authored-by: Claude <claude@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@louisgv