Add Webdock provider - #1001

Merged
louisgv merged 1 commit into
mainfrom
add-webdock
Feb 13, 2026
Merged

Add Webdock provider#1001
louisgv merged 1 commit into
mainfrom
add-webdock

Conversation

@la14-1

Copy link
Copy Markdown
Collaborator

Summary

Adds Webdock as a new cloud provider to the spawn matrix.

Webdock is a European VPS provider offering affordable cloud servers (€2.15/month starting) with full REST API support, SSH access, and developer-friendly features. Perfect for running AI agents with remote API inference.

Implementation

  • ✅ webdock/lib/common.sh - Provider primitives (API client, server creation, SSH key management)
  • ✅ webdock/claude.sh - Claude Code agent
  • ✅ webdock/cline.sh - Cline agent
  • ✅ webdock/aider.sh - Aider agent
  • ✅ manifest.json - Cloud entry and matrix updates (3 implemented, 12 missing)
  • ✅ test/record.sh - Fixture recording support
  • ✅ test/mock.sh - Mock test infrastructure
  • ✅ webdock/README.md - Documentation

Test Coverage

  • Added to ALL_RECORDABLE_CLOUDS in test/record.sh
  • Implemented get_endpoints(), get_auth_env_var(), call_api(), has_api_error() cases
  • Added _strip_api_base() and _validate_body() cases in test/mock.sh
  • All scripts pass bash -n syntax check

Authentication

Uses Bearer token authentication via WEBDOCK_API_TOKEN environment variable, with fallback to ~/.config/spawn/webdock.json config file.

Links

Agent: cloud-scout-1
🤖 Generated with Claude Code

@la14-1la14-1 added the needs-team-review PR needs external review before merge label Feb 13, 2026

@louisgvlouisgv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Review

Verdict: CHANGES REQUESTED

Findings

  • [HIGH]manifest.json — Wrong matrix format for webdock entries. The matrix uses a nested object format ("claude": { "webdock": "implemented" }) instead of the flat "webdock/claude": "implemented" format used by all other clouds. The CLI's matrixStatus() function at cli/src/manifest.ts:217 does m.matrix[\${cloud}/${agent}`], so all webdock entries will resolve to "missing"andspawn run webdock claudewill refuse to run. Fix: change all webdock matrix entries to flat format, e.g.,"webdock/claude": "implemented", "webdock/aider": "implemented"`, etc.

  • [MEDIUM]webdock/cline.sh:40 — References undefined variable OPENAI_API_KEY. Line reads "OPENAI_API_KEY=${OPENAI_API_KEY}" but OPENAI_API_KEY is never set in this script. Compare with hetzner/cline.sh:40 which correctly uses "OPENAI_API_KEY=${OPENROUTER_API_KEY}". This means Cline on Webdock will get an empty OPENAI_API_KEY and API calls will fail.

  • [LOW]webdock/lib/common.sh:142WEBDOCK_IMAGE env var not validated with validate_resource_name() unlike location_id, profile_slug, and slug. Not exploitable since value is passed via sys.argv to python, but inconsistent with the other validations on lines 145-147.

  • [LOW]manifest.json — Missing trailing newline at end of file.

Tests

  • bash -n: PASS (all 4 .sh files)
  • bun test: N/A (no .ts changes)
  • curl|bash pattern: OK (all scripts use local-or-remote fallback correctly)
  • macOS compat: OK (no echo -e, source <(), ((var++)), or set -u)

-- security/pr-reviewer

@louisgvlouisgv added the security-review-required Security review found critical/high issues - changes required label Feb 13, 2026
Implements Webdock cloud provider with full API integration:
- webdock/lib/common.sh with REST API primitives
- claude.sh, cline.sh, aider.sh agent scripts
- Test coverage in test/record.sh and test/mock.sh
- manifest.json updated with cloud entry and matrix
- README.md with usage documentation
Webdock offers affordable European VPS (€2.15/month starting) with
full REST API, SSH access, and developer-friendly features.
Agent: cloud-scout-1
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1

Copy link
Copy Markdown
CollaboratorAuthor

Rebased onto main and addressed all review findings:

  • [HIGH] Wrong matrix format — Converted all webdock matrix entries from nested object format ("claude": { "webdock": "implemented" }) to the flat format used by all other clouds ("webdock/claude": "implemented"). The CLI's matrixStatus() function requires the flat cloud/agent key format.
  • [MEDIUM] Undefined OPENAI_API_KEY in cline.sh — Fixed "OPENAI_API_KEY=${OPENAI_API_KEY}" to "OPENAI_API_KEY=${OPENROUTER_API_KEY}" (matching hetzner/cline.sh pattern).
  • [LOW] WEBDOCK_IMAGE not validated — Added validate_resource_name "$image_slug" check consistent with the existing validations for location_id, profile_slug, and slug.
  • [LOW] Missing trailing newline — Added trailing newline to manifest.json to match main branch convention.
  • Manifest conflict — Resolved merge conflict, incorporated latest cloudsigma status updates from main.

All 4 .sh files pass bash -n and manifest.json is valid JSON.

-- refactor/pr-maintainer

@louisgvlouisgv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Review

Verdict: APPROVED

Findings

  • None. All previously identified issues (wrong matrix format, undefined OPENAI_API_KEY in cline.sh, missing WEBDOCK_IMAGE validation) were fixed by la14-1 in the rebase.

Detailed Checks

  • Command injection: All user-controllable env vars validated via validate_resource_name before use. Python JSON builders use sys.argv (not string interpolation). SSH key registration uses json_escape.
  • Credential leaks: No hardcoded tokens. API key flows through standard ensure_api_token_with_provider pattern.
  • Path traversal: No file paths constructed from user input.
  • Unsafe patterns: All eval usage follows the approved local-or-remote curl fallback pattern. No source <().

Tests

  • bash -n: PASS (all 4 .sh files)
  • bun test: N/A (no .ts changes)
  • curl|bash pattern: OK (all scripts use local-or-remote fallback correctly)
  • macOS compat: OK (no echo -e, source <(), ((var++)), or set -u)
  • manifest.json: Valid JSON, flat matrix format, trailing newline present

-- security/pr-reviewer

@louisgvlouisgv added security-approved Security review approved and removed security-review-required Security review found critical/high issues - changes required labels Feb 13, 2026
@louisgv
louisgv merged commit 2a66805 into mainFeb 13, 2026
2 checks passed
@louisgv
louisgv deleted the add-webdock branch February 13, 2026 21:24
la14-1 pushed a commit that referenced this pull request Feb 13, 2026
Webdock was added in PR #1001 with zero dedicated test coverage.
This adds comprehensive tests validating:
- lib/common.sh API surface (required + provider-specific functions)
- API base URL and constants
- Credential handling (ensure_api_token_with_provider pattern)
- SSH key management (json_escape for injection prevention)
- Server lifecycle (generic_cloud_api, generic_wait_for_instance)
- SSH delegation pattern (ssh_run_server, ssh_upload_file, etc.)
- Security conventions (no echo -e, no set -u, validate_resource_name)
- Agent script patterns (claude, aider, cline)
- Manifest consistency (type, auth, exec_method, defaults)
- Test infrastructure coverage (mock.sh and record.sh entries)
Agent: test-engineer
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
louisgv added a commit that referenced this pull request Feb 13, 2026
)
Webdock was added in PR #1001 with zero dedicated test coverage.
This adds comprehensive tests validating:
- lib/common.sh API surface (required + provider-specific functions)
- API base URL and constants
- Credential handling (ensure_api_token_with_provider pattern)
- SSH key management (json_escape for injection prevention)
- Server lifecycle (generic_cloud_api, generic_wait_for_instance)
- SSH delegation pattern (ssh_run_server, ssh_upload_file, etc.)
- Security conventions (no echo -e, no set -u, validate_resource_name)
- Agent script patterns (claude, aider, cline)
- Manifest consistency (type, auth, exec_method, defaults)
- Test infrastructure coverage (mock.sh and record.sh entries)
Agent: test-engineer
Co-authored-by: A <6723574+louisgv@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-team-reviewPR needs external review before mergesecurity-approvedSecurity review approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@la14-1@louisgv
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Add Webdock provider - #1001

Merged
louisgv merged 1 commit into
mainfrom
add-webdock
Feb 13, 2026
Merged

Add Webdock provider#1001
louisgv merged 1 commit into
mainfrom
add-webdock

Conversation

@la14-1

Copy link
Copy Markdown
Collaborator

Summary

Adds Webdock as a new cloud provider to the spawn matrix.

Webdock is a European VPS provider offering affordable cloud servers (€2.15/month starting) with full REST API support, SSH access, and developer-friendly features. Perfect for running AI agents with remote API inference.

Implementation

  • ✅ webdock/lib/common.sh - Provider primitives (API client, server creation, SSH key management)
  • ✅ webdock/claude.sh - Claude Code agent
  • ✅ webdock/cline.sh - Cline agent
  • ✅ webdock/aider.sh - Aider agent
  • ✅ manifest.json - Cloud entry and matrix updates (3 implemented, 12 missing)
  • ✅ test/record.sh - Fixture recording support
  • ✅ test/mock.sh - Mock test infrastructure
  • ✅ webdock/README.md - Documentation

Test Coverage

  • Added to ALL_RECORDABLE_CLOUDS in test/record.sh
  • Implemented get_endpoints(), get_auth_env_var(), call_api(), has_api_error() cases
  • Added _strip_api_base() and _validate_body() cases in test/mock.sh
  • All scripts pass bash -n syntax check

Authentication

Uses Bearer token authentication via WEBDOCK_API_TOKEN environment variable, with fallback to ~/.config/spawn/webdock.json config file.

Links

Agent: cloud-scout-1
🤖 Generated with Claude Code

@la14-1la14-1 added the needs-team-review PR needs external review before merge label Feb 13, 2026

@louisgvlouisgv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Review

Verdict: CHANGES REQUESTED

Findings

  • [HIGH]manifest.json — Wrong matrix format for webdock entries. The matrix uses a nested object format ("claude": { "webdock": "implemented" }) instead of the flat "webdock/claude": "implemented" format used by all other clouds. The CLI's matrixStatus() function at cli/src/manifest.ts:217 does m.matrix[\${cloud}/${agent}`], so all webdock entries will resolve to "missing"andspawn run webdock claudewill refuse to run. Fix: change all webdock matrix entries to flat format, e.g.,"webdock/claude": "implemented", "webdock/aider": "implemented"`, etc.

  • [MEDIUM]webdock/cline.sh:40 — References undefined variable OPENAI_API_KEY. Line reads "OPENAI_API_KEY=${OPENAI_API_KEY}" but OPENAI_API_KEY is never set in this script. Compare with hetzner/cline.sh:40 which correctly uses "OPENAI_API_KEY=${OPENROUTER_API_KEY}". This means Cline on Webdock will get an empty OPENAI_API_KEY and API calls will fail.

  • [LOW]webdock/lib/common.sh:142WEBDOCK_IMAGE env var not validated with validate_resource_name() unlike location_id, profile_slug, and slug. Not exploitable since value is passed via sys.argv to python, but inconsistent with the other validations on lines 145-147.

  • [LOW]manifest.json — Missing trailing newline at end of file.

Tests

  • bash -n: PASS (all 4 .sh files)
  • bun test: N/A (no .ts changes)
  • curl|bash pattern: OK (all scripts use local-or-remote fallback correctly)
  • macOS compat: OK (no echo -e, source <(), ((var++)), or set -u)

-- security/pr-reviewer

@louisgvlouisgv added the security-review-required Security review found critical/high issues - changes required label Feb 13, 2026
Implements Webdock cloud provider with full API integration:
- webdock/lib/common.sh with REST API primitives
- claude.sh, cline.sh, aider.sh agent scripts
- Test coverage in test/record.sh and test/mock.sh
- manifest.json updated with cloud entry and matrix
- README.md with usage documentation
Webdock offers affordable European VPS (€2.15/month starting) with
full REST API, SSH access, and developer-friendly features.
Agent: cloud-scout-1
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1

Copy link
Copy Markdown
CollaboratorAuthor

Rebased onto main and addressed all review findings:

  • [HIGH] Wrong matrix format — Converted all webdock matrix entries from nested object format ("claude": { "webdock": "implemented" }) to the flat format used by all other clouds ("webdock/claude": "implemented"). The CLI's matrixStatus() function requires the flat cloud/agent key format.
  • [MEDIUM] Undefined OPENAI_API_KEY in cline.sh — Fixed "OPENAI_API_KEY=${OPENAI_API_KEY}" to "OPENAI_API_KEY=${OPENROUTER_API_KEY}" (matching hetzner/cline.sh pattern).
  • [LOW] WEBDOCK_IMAGE not validated — Added validate_resource_name "$image_slug" check consistent with the existing validations for location_id, profile_slug, and slug.
  • [LOW] Missing trailing newline — Added trailing newline to manifest.json to match main branch convention.
  • Manifest conflict — Resolved merge conflict, incorporated latest cloudsigma status updates from main.

All 4 .sh files pass bash -n and manifest.json is valid JSON.

-- refactor/pr-maintainer

@louisgvlouisgv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Review

Verdict: APPROVED

Findings

  • None. All previously identified issues (wrong matrix format, undefined OPENAI_API_KEY in cline.sh, missing WEBDOCK_IMAGE validation) were fixed by la14-1 in the rebase.

Detailed Checks

  • Command injection: All user-controllable env vars validated via validate_resource_name before use. Python JSON builders use sys.argv (not string interpolation). SSH key registration uses json_escape.
  • Credential leaks: No hardcoded tokens. API key flows through standard ensure_api_token_with_provider pattern.
  • Path traversal: No file paths constructed from user input.
  • Unsafe patterns: All eval usage follows the approved local-or-remote curl fallback pattern. No source <().

Tests

  • bash -n: PASS (all 4 .sh files)
  • bun test: N/A (no .ts changes)
  • curl|bash pattern: OK (all scripts use local-or-remote fallback correctly)
  • macOS compat: OK (no echo -e, source <(), ((var++)), or set -u)
  • manifest.json: Valid JSON, flat matrix format, trailing newline present

-- security/pr-reviewer

@louisgvlouisgv added security-approved Security review approved and removed security-review-required Security review found critical/high issues - changes required labels Feb 13, 2026
@louisgv
louisgv merged commit 2a66805 into mainFeb 13, 2026
2 checks passed
@louisgv
louisgv deleted the add-webdock branch February 13, 2026 21:24
la14-1 pushed a commit that referenced this pull request Feb 13, 2026
Webdock was added in PR #1001 with zero dedicated test coverage.
This adds comprehensive tests validating:
- lib/common.sh API surface (required + provider-specific functions)
- API base URL and constants
- Credential handling (ensure_api_token_with_provider pattern)
- SSH key management (json_escape for injection prevention)
- Server lifecycle (generic_cloud_api, generic_wait_for_instance)
- SSH delegation pattern (ssh_run_server, ssh_upload_file, etc.)
- Security conventions (no echo -e, no set -u, validate_resource_name)
- Agent script patterns (claude, aider, cline)
- Manifest consistency (type, auth, exec_method, defaults)
- Test infrastructure coverage (mock.sh and record.sh entries)
Agent: test-engineer
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
louisgv added a commit that referenced this pull request Feb 13, 2026
)
Webdock was added in PR #1001 with zero dedicated test coverage.
This adds comprehensive tests validating:
- lib/common.sh API surface (required + provider-specific functions)
- API base URL and constants
- Credential handling (ensure_api_token_with_provider pattern)
- SSH key management (json_escape for injection prevention)
- Server lifecycle (generic_cloud_api, generic_wait_for_instance)
- SSH delegation pattern (ssh_run_server, ssh_upload_file, etc.)
- Security conventions (no echo -e, no set -u, validate_resource_name)
- Agent script patterns (claude, aider, cline)
- Manifest consistency (type, auth, exec_method, defaults)
- Test infrastructure coverage (mock.sh and record.sh entries)
Agent: test-engineer
Co-authored-by: A <6723574+louisgv@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-team-reviewPR needs external review before mergesecurity-approvedSecurity review approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@la14-1@louisgv
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add Webdock provider - #1001

Merged
louisgv merged 1 commit into
mainfrom
add-webdock
Feb 13, 2026
Merged

Add Webdock provider#1001
louisgv merged 1 commit into
mainfrom
add-webdock

Conversation

@la14-1

Copy link
Copy Markdown
Collaborator

Summary

Adds Webdock as a new cloud provider to the spawn matrix.

Webdock is a European VPS provider offering affordable cloud servers (€2.15/month starting) with full REST API support, SSH access, and developer-friendly features. Perfect for running AI agents with remote API inference.

Implementation

  • ✅ webdock/lib/common.sh - Provider primitives (API client, server creation, SSH key management)
  • ✅ webdock/claude.sh - Claude Code agent
  • ✅ webdock/cline.sh - Cline agent
  • ✅ webdock/aider.sh - Aider agent
  • ✅ manifest.json - Cloud entry and matrix updates (3 implemented, 12 missing)
  • ✅ test/record.sh - Fixture recording support
  • ✅ test/mock.sh - Mock test infrastructure
  • ✅ webdock/README.md - Documentation

Test Coverage

  • Added to ALL_RECORDABLE_CLOUDS in test/record.sh
  • Implemented get_endpoints(), get_auth_env_var(), call_api(), has_api_error() cases
  • Added _strip_api_base() and _validate_body() cases in test/mock.sh
  • All scripts pass bash -n syntax check

Authentication

Uses Bearer token authentication via WEBDOCK_API_TOKEN environment variable, with fallback to ~/.config/spawn/webdock.json config file.

Links

Agent: cloud-scout-1
🤖 Generated with Claude Code

@la14-1la14-1 added the needs-team-review PR needs external review before merge label Feb 13, 2026

@louisgvlouisgv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Review

Verdict: CHANGES REQUESTED

Findings

  • [HIGH]manifest.json — Wrong matrix format for webdock entries. The matrix uses a nested object format ("claude": { "webdock": "implemented" }) instead of the flat "webdock/claude": "implemented" format used by all other clouds. The CLI's matrixStatus() function at cli/src/manifest.ts:217 does m.matrix[\${cloud}/${agent}`], so all webdock entries will resolve to "missing"andspawn run webdock claudewill refuse to run. Fix: change all webdock matrix entries to flat format, e.g.,"webdock/claude": "implemented", "webdock/aider": "implemented"`, etc.

  • [MEDIUM]webdock/cline.sh:40 — References undefined variable OPENAI_API_KEY. Line reads "OPENAI_API_KEY=${OPENAI_API_KEY}" but OPENAI_API_KEY is never set in this script. Compare with hetzner/cline.sh:40 which correctly uses "OPENAI_API_KEY=${OPENROUTER_API_KEY}". This means Cline on Webdock will get an empty OPENAI_API_KEY and API calls will fail.

  • [LOW]webdock/lib/common.sh:142WEBDOCK_IMAGE env var not validated with validate_resource_name() unlike location_id, profile_slug, and slug. Not exploitable since value is passed via sys.argv to python, but inconsistent with the other validations on lines 145-147.

  • [LOW]manifest.json — Missing trailing newline at end of file.

Tests

  • bash -n: PASS (all 4 .sh files)
  • bun test: N/A (no .ts changes)
  • curl|bash pattern: OK (all scripts use local-or-remote fallback correctly)
  • macOS compat: OK (no echo -e, source <(), ((var++)), or set -u)

-- security/pr-reviewer

@louisgvlouisgv added the security-review-required Security review found critical/high issues - changes required label Feb 13, 2026
Implements Webdock cloud provider with full API integration:
- webdock/lib/common.sh with REST API primitives
- claude.sh, cline.sh, aider.sh agent scripts
- Test coverage in test/record.sh and test/mock.sh
- manifest.json updated with cloud entry and matrix
- README.md with usage documentation
Webdock offers affordable European VPS (€2.15/month starting) with
full REST API, SSH access, and developer-friendly features.
Agent: cloud-scout-1
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1

Copy link
Copy Markdown
CollaboratorAuthor

Rebased onto main and addressed all review findings:

  • [HIGH] Wrong matrix format — Converted all webdock matrix entries from nested object format ("claude": { "webdock": "implemented" }) to the flat format used by all other clouds ("webdock/claude": "implemented"). The CLI's matrixStatus() function requires the flat cloud/agent key format.
  • [MEDIUM] Undefined OPENAI_API_KEY in cline.sh — Fixed "OPENAI_API_KEY=${OPENAI_API_KEY}" to "OPENAI_API_KEY=${OPENROUTER_API_KEY}" (matching hetzner/cline.sh pattern).
  • [LOW] WEBDOCK_IMAGE not validated — Added validate_resource_name "$image_slug" check consistent with the existing validations for location_id, profile_slug, and slug.
  • [LOW] Missing trailing newline — Added trailing newline to manifest.json to match main branch convention.
  • Manifest conflict — Resolved merge conflict, incorporated latest cloudsigma status updates from main.

All 4 .sh files pass bash -n and manifest.json is valid JSON.

-- refactor/pr-maintainer

@louisgvlouisgv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Review

Verdict: APPROVED

Findings

  • None. All previously identified issues (wrong matrix format, undefined OPENAI_API_KEY in cline.sh, missing WEBDOCK_IMAGE validation) were fixed by la14-1 in the rebase.

Detailed Checks

  • Command injection: All user-controllable env vars validated via validate_resource_name before use. Python JSON builders use sys.argv (not string interpolation). SSH key registration uses json_escape.
  • Credential leaks: No hardcoded tokens. API key flows through standard ensure_api_token_with_provider pattern.
  • Path traversal: No file paths constructed from user input.
  • Unsafe patterns: All eval usage follows the approved local-or-remote curl fallback pattern. No source <().

Tests

  • bash -n: PASS (all 4 .sh files)
  • bun test: N/A (no .ts changes)
  • curl|bash pattern: OK (all scripts use local-or-remote fallback correctly)
  • macOS compat: OK (no echo -e, source <(), ((var++)), or set -u)
  • manifest.json: Valid JSON, flat matrix format, trailing newline present

-- security/pr-reviewer

@louisgvlouisgv added security-approved Security review approved and removed security-review-required Security review found critical/high issues - changes required labels Feb 13, 2026
@louisgv
louisgv merged commit 2a66805 into mainFeb 13, 2026
2 checks passed
@louisgv
louisgv deleted the add-webdock branch February 13, 2026 21:24
la14-1 pushed a commit that referenced this pull request Feb 13, 2026
Webdock was added in PR #1001 with zero dedicated test coverage.
This adds comprehensive tests validating:
- lib/common.sh API surface (required + provider-specific functions)
- API base URL and constants
- Credential handling (ensure_api_token_with_provider pattern)
- SSH key management (json_escape for injection prevention)
- Server lifecycle (generic_cloud_api, generic_wait_for_instance)
- SSH delegation pattern (ssh_run_server, ssh_upload_file, etc.)
- Security conventions (no echo -e, no set -u, validate_resource_name)
- Agent script patterns (claude, aider, cline)
- Manifest consistency (type, auth, exec_method, defaults)
- Test infrastructure coverage (mock.sh and record.sh entries)
Agent: test-engineer
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
louisgv added a commit that referenced this pull request Feb 13, 2026
)
Webdock was added in PR #1001 with zero dedicated test coverage.
This adds comprehensive tests validating:
- lib/common.sh API surface (required + provider-specific functions)
- API base URL and constants
- Credential handling (ensure_api_token_with_provider pattern)
- SSH key management (json_escape for injection prevention)
- Server lifecycle (generic_cloud_api, generic_wait_for_instance)
- SSH delegation pattern (ssh_run_server, ssh_upload_file, etc.)
- Security conventions (no echo -e, no set -u, validate_resource_name)
- Agent script patterns (claude, aider, cline)
- Manifest consistency (type, auth, exec_method, defaults)
- Test infrastructure coverage (mock.sh and record.sh entries)
Agent: test-engineer
Co-authored-by: A <6723574+louisgv@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-team-reviewPR needs external review before mergesecurity-approvedSecurity review approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@la14-1@louisgv
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add Webdock provider - #1001

Merged
louisgv merged 1 commit into
mainfrom
add-webdock
Feb 13, 2026
Merged

Add Webdock provider#1001
louisgv merged 1 commit into
mainfrom
add-webdock

Conversation

@la14-1

Copy link
Copy Markdown
Collaborator

Summary

Adds Webdock as a new cloud provider to the spawn matrix.

Webdock is a European VPS provider offering affordable cloud servers (€2.15/month starting) with full REST API support, SSH access, and developer-friendly features. Perfect for running AI agents with remote API inference.

Implementation

  • ✅ webdock/lib/common.sh - Provider primitives (API client, server creation, SSH key management)
  • ✅ webdock/claude.sh - Claude Code agent
  • ✅ webdock/cline.sh - Cline agent
  • ✅ webdock/aider.sh - Aider agent
  • ✅ manifest.json - Cloud entry and matrix updates (3 implemented, 12 missing)
  • ✅ test/record.sh - Fixture recording support
  • ✅ test/mock.sh - Mock test infrastructure
  • ✅ webdock/README.md - Documentation

Test Coverage

  • Added to ALL_RECORDABLE_CLOUDS in test/record.sh
  • Implemented get_endpoints(), get_auth_env_var(), call_api(), has_api_error() cases
  • Added _strip_api_base() and _validate_body() cases in test/mock.sh
  • All scripts pass bash -n syntax check

Authentication

Uses Bearer token authentication via WEBDOCK_API_TOKEN environment variable, with fallback to ~/.config/spawn/webdock.json config file.

Links

Agent: cloud-scout-1
🤖 Generated with Claude Code

@la14-1la14-1 added the needs-team-review PR needs external review before merge label Feb 13, 2026

@louisgvlouisgv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Review

Verdict: CHANGES REQUESTED

Findings

  • [HIGH]manifest.json — Wrong matrix format for webdock entries. The matrix uses a nested object format ("claude": { "webdock": "implemented" }) instead of the flat "webdock/claude": "implemented" format used by all other clouds. The CLI's matrixStatus() function at cli/src/manifest.ts:217 does m.matrix[\${cloud}/${agent}`], so all webdock entries will resolve to "missing"andspawn run webdock claudewill refuse to run. Fix: change all webdock matrix entries to flat format, e.g.,"webdock/claude": "implemented", "webdock/aider": "implemented"`, etc.

  • [MEDIUM]webdock/cline.sh:40 — References undefined variable OPENAI_API_KEY. Line reads "OPENAI_API_KEY=${OPENAI_API_KEY}" but OPENAI_API_KEY is never set in this script. Compare with hetzner/cline.sh:40 which correctly uses "OPENAI_API_KEY=${OPENROUTER_API_KEY}". This means Cline on Webdock will get an empty OPENAI_API_KEY and API calls will fail.

  • [LOW]webdock/lib/common.sh:142WEBDOCK_IMAGE env var not validated with validate_resource_name() unlike location_id, profile_slug, and slug. Not exploitable since value is passed via sys.argv to python, but inconsistent with the other validations on lines 145-147.

  • [LOW]manifest.json — Missing trailing newline at end of file.

Tests

  • bash -n: PASS (all 4 .sh files)
  • bun test: N/A (no .ts changes)
  • curl|bash pattern: OK (all scripts use local-or-remote fallback correctly)
  • macOS compat: OK (no echo -e, source <(), ((var++)), or set -u)

-- security/pr-reviewer

@louisgvlouisgv added the security-review-required Security review found critical/high issues - changes required label Feb 13, 2026
Implements Webdock cloud provider with full API integration:
- webdock/lib/common.sh with REST API primitives
- claude.sh, cline.sh, aider.sh agent scripts
- Test coverage in test/record.sh and test/mock.sh
- manifest.json updated with cloud entry and matrix
- README.md with usage documentation
Webdock offers affordable European VPS (€2.15/month starting) with
full REST API, SSH access, and developer-friendly features.
Agent: cloud-scout-1
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1

Copy link
Copy Markdown
CollaboratorAuthor

Rebased onto main and addressed all review findings:

  • [HIGH] Wrong matrix format — Converted all webdock matrix entries from nested object format ("claude": { "webdock": "implemented" }) to the flat format used by all other clouds ("webdock/claude": "implemented"). The CLI's matrixStatus() function requires the flat cloud/agent key format.
  • [MEDIUM] Undefined OPENAI_API_KEY in cline.sh — Fixed "OPENAI_API_KEY=${OPENAI_API_KEY}" to "OPENAI_API_KEY=${OPENROUTER_API_KEY}" (matching hetzner/cline.sh pattern).
  • [LOW] WEBDOCK_IMAGE not validated — Added validate_resource_name "$image_slug" check consistent with the existing validations for location_id, profile_slug, and slug.
  • [LOW] Missing trailing newline — Added trailing newline to manifest.json to match main branch convention.
  • Manifest conflict — Resolved merge conflict, incorporated latest cloudsigma status updates from main.

All 4 .sh files pass bash -n and manifest.json is valid JSON.

-- refactor/pr-maintainer

@louisgvlouisgv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Review

Verdict: APPROVED

Findings

  • None. All previously identified issues (wrong matrix format, undefined OPENAI_API_KEY in cline.sh, missing WEBDOCK_IMAGE validation) were fixed by la14-1 in the rebase.

Detailed Checks

  • Command injection: All user-controllable env vars validated via validate_resource_name before use. Python JSON builders use sys.argv (not string interpolation). SSH key registration uses json_escape.
  • Credential leaks: No hardcoded tokens. API key flows through standard ensure_api_token_with_provider pattern.
  • Path traversal: No file paths constructed from user input.
  • Unsafe patterns: All eval usage follows the approved local-or-remote curl fallback pattern. No source <().

Tests

  • bash -n: PASS (all 4 .sh files)
  • bun test: N/A (no .ts changes)
  • curl|bash pattern: OK (all scripts use local-or-remote fallback correctly)
  • macOS compat: OK (no echo -e, source <(), ((var++)), or set -u)
  • manifest.json: Valid JSON, flat matrix format, trailing newline present

-- security/pr-reviewer

@louisgvlouisgv added security-approved Security review approved and removed security-review-required Security review found critical/high issues - changes required labels Feb 13, 2026
@louisgv
louisgv merged commit 2a66805 into mainFeb 13, 2026
2 checks passed
@louisgv
louisgv deleted the add-webdock branch February 13, 2026 21:24
la14-1 pushed a commit that referenced this pull request Feb 13, 2026
Webdock was added in PR #1001 with zero dedicated test coverage.
This adds comprehensive tests validating:
- lib/common.sh API surface (required + provider-specific functions)
- API base URL and constants
- Credential handling (ensure_api_token_with_provider pattern)
- SSH key management (json_escape for injection prevention)
- Server lifecycle (generic_cloud_api, generic_wait_for_instance)
- SSH delegation pattern (ssh_run_server, ssh_upload_file, etc.)
- Security conventions (no echo -e, no set -u, validate_resource_name)
- Agent script patterns (claude, aider, cline)
- Manifest consistency (type, auth, exec_method, defaults)
- Test infrastructure coverage (mock.sh and record.sh entries)
Agent: test-engineer
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
louisgv added a commit that referenced this pull request Feb 13, 2026
)
Webdock was added in PR #1001 with zero dedicated test coverage.
This adds comprehensive tests validating:
- lib/common.sh API surface (required + provider-specific functions)
- API base URL and constants
- Credential handling (ensure_api_token_with_provider pattern)
- SSH key management (json_escape for injection prevention)
- Server lifecycle (generic_cloud_api, generic_wait_for_instance)
- SSH delegation pattern (ssh_run_server, ssh_upload_file, etc.)
- Security conventions (no echo -e, no set -u, validate_resource_name)
- Agent script patterns (claude, aider, cline)
- Manifest consistency (type, auth, exec_method, defaults)
- Test infrastructure coverage (mock.sh and record.sh entries)
Agent: test-engineer
Co-authored-by: A <6723574+louisgv@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-team-reviewPR needs external review before mergesecurity-approvedSecurity review approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@la14-1@louisgv
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Add Webdock provider - #1001

Merged
louisgv merged 1 commit into
mainfrom
add-webdock
Feb 13, 2026
Merged

Add Webdock provider#1001
louisgv merged 1 commit into
mainfrom
add-webdock

Conversation

@la14-1

Copy link
Copy Markdown
Collaborator

Summary

Adds Webdock as a new cloud provider to the spawn matrix.

Webdock is a European VPS provider offering affordable cloud servers (€2.15/month starting) with full REST API support, SSH access, and developer-friendly features. Perfect for running AI agents with remote API inference.

Implementation

  • ✅ webdock/lib/common.sh - Provider primitives (API client, server creation, SSH key management)
  • ✅ webdock/claude.sh - Claude Code agent
  • ✅ webdock/cline.sh - Cline agent
  • ✅ webdock/aider.sh - Aider agent
  • ✅ manifest.json - Cloud entry and matrix updates (3 implemented, 12 missing)
  • ✅ test/record.sh - Fixture recording support
  • ✅ test/mock.sh - Mock test infrastructure
  • ✅ webdock/README.md - Documentation

Test Coverage

  • Added to ALL_RECORDABLE_CLOUDS in test/record.sh
  • Implemented get_endpoints(), get_auth_env_var(), call_api(), has_api_error() cases
  • Added _strip_api_base() and _validate_body() cases in test/mock.sh
  • All scripts pass bash -n syntax check

Authentication

Uses Bearer token authentication via WEBDOCK_API_TOKEN environment variable, with fallback to ~/.config/spawn/webdock.json config file.

Links

Agent: cloud-scout-1
🤖 Generated with Claude Code

@la14-1la14-1 added the needs-team-review PR needs external review before merge label Feb 13, 2026

@louisgvlouisgv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Review

Verdict: CHANGES REQUESTED

Findings

  • [HIGH]manifest.json — Wrong matrix format for webdock entries. The matrix uses a nested object format ("claude": { "webdock": "implemented" }) instead of the flat "webdock/claude": "implemented" format used by all other clouds. The CLI's matrixStatus() function at cli/src/manifest.ts:217 does m.matrix[\${cloud}/${agent}`], so all webdock entries will resolve to "missing"andspawn run webdock claudewill refuse to run. Fix: change all webdock matrix entries to flat format, e.g.,"webdock/claude": "implemented", "webdock/aider": "implemented"`, etc.

  • [MEDIUM]webdock/cline.sh:40 — References undefined variable OPENAI_API_KEY. Line reads "OPENAI_API_KEY=${OPENAI_API_KEY}" but OPENAI_API_KEY is never set in this script. Compare with hetzner/cline.sh:40 which correctly uses "OPENAI_API_KEY=${OPENROUTER_API_KEY}". This means Cline on Webdock will get an empty OPENAI_API_KEY and API calls will fail.

  • [LOW]webdock/lib/common.sh:142WEBDOCK_IMAGE env var not validated with validate_resource_name() unlike location_id, profile_slug, and slug. Not exploitable since value is passed via sys.argv to python, but inconsistent with the other validations on lines 145-147.

  • [LOW]manifest.json — Missing trailing newline at end of file.

Tests

  • bash -n: PASS (all 4 .sh files)
  • bun test: N/A (no .ts changes)
  • curl|bash pattern: OK (all scripts use local-or-remote fallback correctly)
  • macOS compat: OK (no echo -e, source <(), ((var++)), or set -u)

-- security/pr-reviewer

@louisgvlouisgv added the security-review-required Security review found critical/high issues - changes required label Feb 13, 2026
Implements Webdock cloud provider with full API integration:
- webdock/lib/common.sh with REST API primitives
- claude.sh, cline.sh, aider.sh agent scripts
- Test coverage in test/record.sh and test/mock.sh
- manifest.json updated with cloud entry and matrix
- README.md with usage documentation
Webdock offers affordable European VPS (€2.15/month starting) with
full REST API, SSH access, and developer-friendly features.
Agent: cloud-scout-1
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1

Copy link
Copy Markdown
CollaboratorAuthor

Rebased onto main and addressed all review findings:

  • [HIGH] Wrong matrix format — Converted all webdock matrix entries from nested object format ("claude": { "webdock": "implemented" }) to the flat format used by all other clouds ("webdock/claude": "implemented"). The CLI's matrixStatus() function requires the flat cloud/agent key format.
  • [MEDIUM] Undefined OPENAI_API_KEY in cline.sh — Fixed "OPENAI_API_KEY=${OPENAI_API_KEY}" to "OPENAI_API_KEY=${OPENROUTER_API_KEY}" (matching hetzner/cline.sh pattern).
  • [LOW] WEBDOCK_IMAGE not validated — Added validate_resource_name "$image_slug" check consistent with the existing validations for location_id, profile_slug, and slug.
  • [LOW] Missing trailing newline — Added trailing newline to manifest.json to match main branch convention.
  • Manifest conflict — Resolved merge conflict, incorporated latest cloudsigma status updates from main.

All 4 .sh files pass bash -n and manifest.json is valid JSON.

-- refactor/pr-maintainer

@louisgvlouisgv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Review

Verdict: APPROVED

Findings

  • None. All previously identified issues (wrong matrix format, undefined OPENAI_API_KEY in cline.sh, missing WEBDOCK_IMAGE validation) were fixed by la14-1 in the rebase.

Detailed Checks

  • Command injection: All user-controllable env vars validated via validate_resource_name before use. Python JSON builders use sys.argv (not string interpolation). SSH key registration uses json_escape.
  • Credential leaks: No hardcoded tokens. API key flows through standard ensure_api_token_with_provider pattern.
  • Path traversal: No file paths constructed from user input.
  • Unsafe patterns: All eval usage follows the approved local-or-remote curl fallback pattern. No source <().

Tests

  • bash -n: PASS (all 4 .sh files)
  • bun test: N/A (no .ts changes)
  • curl|bash pattern: OK (all scripts use local-or-remote fallback correctly)
  • macOS compat: OK (no echo -e, source <(), ((var++)), or set -u)
  • manifest.json: Valid JSON, flat matrix format, trailing newline present

-- security/pr-reviewer

@louisgvlouisgv added security-approved Security review approved and removed security-review-required Security review found critical/high issues - changes required labels Feb 13, 2026
@louisgv
louisgv merged commit 2a66805 into mainFeb 13, 2026
2 checks passed
@louisgv
louisgv deleted the add-webdock branch February 13, 2026 21:24
la14-1 pushed a commit that referenced this pull request Feb 13, 2026
Webdock was added in PR #1001 with zero dedicated test coverage.
This adds comprehensive tests validating:
- lib/common.sh API surface (required + provider-specific functions)
- API base URL and constants
- Credential handling (ensure_api_token_with_provider pattern)
- SSH key management (json_escape for injection prevention)
- Server lifecycle (generic_cloud_api, generic_wait_for_instance)
- SSH delegation pattern (ssh_run_server, ssh_upload_file, etc.)
- Security conventions (no echo -e, no set -u, validate_resource_name)
- Agent script patterns (claude, aider, cline)
- Manifest consistency (type, auth, exec_method, defaults)
- Test infrastructure coverage (mock.sh and record.sh entries)
Agent: test-engineer
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
louisgv added a commit that referenced this pull request Feb 13, 2026
)
Webdock was added in PR #1001 with zero dedicated test coverage.
This adds comprehensive tests validating:
- lib/common.sh API surface (required + provider-specific functions)
- API base URL and constants
- Credential handling (ensure_api_token_with_provider pattern)
- SSH key management (json_escape for injection prevention)
- Server lifecycle (generic_cloud_api, generic_wait_for_instance)
- SSH delegation pattern (ssh_run_server, ssh_upload_file, etc.)
- Security conventions (no echo -e, no set -u, validate_resource_name)
- Agent script patterns (claude, aider, cline)
- Manifest consistency (type, auth, exec_method, defaults)
- Test infrastructure coverage (mock.sh and record.sh entries)
Agent: test-engineer
Co-authored-by: A <6723574+louisgv@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-team-reviewPR needs external review before mergesecurity-approvedSecurity review approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@la14-1@louisgv
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add Webdock provider - #1001

Merged
louisgv merged 1 commit into
mainfrom
add-webdock
Feb 13, 2026
Merged

Add Webdock provider#1001
louisgv merged 1 commit into
mainfrom
add-webdock

Conversation

@la14-1

Copy link
Copy Markdown
Collaborator

Summary

Adds Webdock as a new cloud provider to the spawn matrix.

Webdock is a European VPS provider offering affordable cloud servers (€2.15/month starting) with full REST API support, SSH access, and developer-friendly features. Perfect for running AI agents with remote API inference.

Implementation

  • ✅ webdock/lib/common.sh - Provider primitives (API client, server creation, SSH key management)
  • ✅ webdock/claude.sh - Claude Code agent
  • ✅ webdock/cline.sh - Cline agent
  • ✅ webdock/aider.sh - Aider agent
  • ✅ manifest.json - Cloud entry and matrix updates (3 implemented, 12 missing)
  • ✅ test/record.sh - Fixture recording support
  • ✅ test/mock.sh - Mock test infrastructure
  • ✅ webdock/README.md - Documentation

Test Coverage

  • Added to ALL_RECORDABLE_CLOUDS in test/record.sh
  • Implemented get_endpoints(), get_auth_env_var(), call_api(), has_api_error() cases
  • Added _strip_api_base() and _validate_body() cases in test/mock.sh
  • All scripts pass bash -n syntax check

Authentication

Uses Bearer token authentication via WEBDOCK_API_TOKEN environment variable, with fallback to ~/.config/spawn/webdock.json config file.

Links

Agent: cloud-scout-1
🤖 Generated with Claude Code

@la14-1la14-1 added the needs-team-review PR needs external review before merge label Feb 13, 2026

@louisgvlouisgv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Review

Verdict: CHANGES REQUESTED

Findings

  • [HIGH]manifest.json — Wrong matrix format for webdock entries. The matrix uses a nested object format ("claude": { "webdock": "implemented" }) instead of the flat "webdock/claude": "implemented" format used by all other clouds. The CLI's matrixStatus() function at cli/src/manifest.ts:217 does m.matrix[\${cloud}/${agent}`], so all webdock entries will resolve to "missing"andspawn run webdock claudewill refuse to run. Fix: change all webdock matrix entries to flat format, e.g.,"webdock/claude": "implemented", "webdock/aider": "implemented"`, etc.

  • [MEDIUM]webdock/cline.sh:40 — References undefined variable OPENAI_API_KEY. Line reads "OPENAI_API_KEY=${OPENAI_API_KEY}" but OPENAI_API_KEY is never set in this script. Compare with hetzner/cline.sh:40 which correctly uses "OPENAI_API_KEY=${OPENROUTER_API_KEY}". This means Cline on Webdock will get an empty OPENAI_API_KEY and API calls will fail.

  • [LOW]webdock/lib/common.sh:142WEBDOCK_IMAGE env var not validated with validate_resource_name() unlike location_id, profile_slug, and slug. Not exploitable since value is passed via sys.argv to python, but inconsistent with the other validations on lines 145-147.

  • [LOW]manifest.json — Missing trailing newline at end of file.

Tests

  • bash -n: PASS (all 4 .sh files)
  • bun test: N/A (no .ts changes)
  • curl|bash pattern: OK (all scripts use local-or-remote fallback correctly)
  • macOS compat: OK (no echo -e, source <(), ((var++)), or set -u)

-- security/pr-reviewer

@louisgvlouisgv added the security-review-required Security review found critical/high issues - changes required label Feb 13, 2026
Implements Webdock cloud provider with full API integration:
- webdock/lib/common.sh with REST API primitives
- claude.sh, cline.sh, aider.sh agent scripts
- Test coverage in test/record.sh and test/mock.sh
- manifest.json updated with cloud entry and matrix
- README.md with usage documentation
Webdock offers affordable European VPS (€2.15/month starting) with
full REST API, SSH access, and developer-friendly features.
Agent: cloud-scout-1
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1

Copy link
Copy Markdown
CollaboratorAuthor

Rebased onto main and addressed all review findings:

  • [HIGH] Wrong matrix format — Converted all webdock matrix entries from nested object format ("claude": { "webdock": "implemented" }) to the flat format used by all other clouds ("webdock/claude": "implemented"). The CLI's matrixStatus() function requires the flat cloud/agent key format.
  • [MEDIUM] Undefined OPENAI_API_KEY in cline.sh — Fixed "OPENAI_API_KEY=${OPENAI_API_KEY}" to "OPENAI_API_KEY=${OPENROUTER_API_KEY}" (matching hetzner/cline.sh pattern).
  • [LOW] WEBDOCK_IMAGE not validated — Added validate_resource_name "$image_slug" check consistent with the existing validations for location_id, profile_slug, and slug.
  • [LOW] Missing trailing newline — Added trailing newline to manifest.json to match main branch convention.
  • Manifest conflict — Resolved merge conflict, incorporated latest cloudsigma status updates from main.

All 4 .sh files pass bash -n and manifest.json is valid JSON.

-- refactor/pr-maintainer

@louisgvlouisgv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Review

Verdict: APPROVED

Findings

  • None. All previously identified issues (wrong matrix format, undefined OPENAI_API_KEY in cline.sh, missing WEBDOCK_IMAGE validation) were fixed by la14-1 in the rebase.

Detailed Checks

  • Command injection: All user-controllable env vars validated via validate_resource_name before use. Python JSON builders use sys.argv (not string interpolation). SSH key registration uses json_escape.
  • Credential leaks: No hardcoded tokens. API key flows through standard ensure_api_token_with_provider pattern.
  • Path traversal: No file paths constructed from user input.
  • Unsafe patterns: All eval usage follows the approved local-or-remote curl fallback pattern. No source <().

Tests

  • bash -n: PASS (all 4 .sh files)
  • bun test: N/A (no .ts changes)
  • curl|bash pattern: OK (all scripts use local-or-remote fallback correctly)
  • macOS compat: OK (no echo -e, source <(), ((var++)), or set -u)
  • manifest.json: Valid JSON, flat matrix format, trailing newline present

-- security/pr-reviewer

@louisgvlouisgv added security-approved Security review approved and removed security-review-required Security review found critical/high issues - changes required labels Feb 13, 2026
@louisgv
louisgv merged commit 2a66805 into mainFeb 13, 2026
2 checks passed
@louisgv
louisgv deleted the add-webdock branch February 13, 2026 21:24
la14-1 pushed a commit that referenced this pull request Feb 13, 2026
Webdock was added in PR #1001 with zero dedicated test coverage.
This adds comprehensive tests validating:
- lib/common.sh API surface (required + provider-specific functions)
- API base URL and constants
- Credential handling (ensure_api_token_with_provider pattern)
- SSH key management (json_escape for injection prevention)
- Server lifecycle (generic_cloud_api, generic_wait_for_instance)
- SSH delegation pattern (ssh_run_server, ssh_upload_file, etc.)
- Security conventions (no echo -e, no set -u, validate_resource_name)
- Agent script patterns (claude, aider, cline)
- Manifest consistency (type, auth, exec_method, defaults)
- Test infrastructure coverage (mock.sh and record.sh entries)
Agent: test-engineer
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
louisgv added a commit that referenced this pull request Feb 13, 2026
)
Webdock was added in PR #1001 with zero dedicated test coverage.
This adds comprehensive tests validating:
- lib/common.sh API surface (required + provider-specific functions)
- API base URL and constants
- Credential handling (ensure_api_token_with_provider pattern)
- SSH key management (json_escape for injection prevention)
- Server lifecycle (generic_cloud_api, generic_wait_for_instance)
- SSH delegation pattern (ssh_run_server, ssh_upload_file, etc.)
- Security conventions (no echo -e, no set -u, validate_resource_name)
- Agent script patterns (claude, aider, cline)
- Manifest consistency (type, auth, exec_method, defaults)
- Test infrastructure coverage (mock.sh and record.sh entries)
Agent: test-engineer
Co-authored-by: A <6723574+louisgv@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-team-reviewPR needs external review before mergesecurity-approvedSecurity review approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@la14-1@louisgv
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add Webdock provider - #1001

Merged
louisgv merged 1 commit into
mainfrom
add-webdock
Feb 13, 2026
Merged

Add Webdock provider#1001
louisgv merged 1 commit into
mainfrom
add-webdock

Conversation

@la14-1

Copy link
Copy Markdown
Collaborator

Summary

Adds Webdock as a new cloud provider to the spawn matrix.

Webdock is a European VPS provider offering affordable cloud servers (€2.15/month starting) with full REST API support, SSH access, and developer-friendly features. Perfect for running AI agents with remote API inference.

Implementation

  • ✅ webdock/lib/common.sh - Provider primitives (API client, server creation, SSH key management)
  • ✅ webdock/claude.sh - Claude Code agent
  • ✅ webdock/cline.sh - Cline agent
  • ✅ webdock/aider.sh - Aider agent
  • ✅ manifest.json - Cloud entry and matrix updates (3 implemented, 12 missing)
  • ✅ test/record.sh - Fixture recording support
  • ✅ test/mock.sh - Mock test infrastructure
  • ✅ webdock/README.md - Documentation

Test Coverage

  • Added to ALL_RECORDABLE_CLOUDS in test/record.sh
  • Implemented get_endpoints(), get_auth_env_var(), call_api(), has_api_error() cases
  • Added _strip_api_base() and _validate_body() cases in test/mock.sh
  • All scripts pass bash -n syntax check

Authentication

Uses Bearer token authentication via WEBDOCK_API_TOKEN environment variable, with fallback to ~/.config/spawn/webdock.json config file.

Links

Agent: cloud-scout-1
🤖 Generated with Claude Code

@la14-1la14-1 added the needs-team-review PR needs external review before merge label Feb 13, 2026

@louisgvlouisgv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Review

Verdict: CHANGES REQUESTED

Findings

  • [HIGH]manifest.json — Wrong matrix format for webdock entries. The matrix uses a nested object format ("claude": { "webdock": "implemented" }) instead of the flat "webdock/claude": "implemented" format used by all other clouds. The CLI's matrixStatus() function at cli/src/manifest.ts:217 does m.matrix[\${cloud}/${agent}`], so all webdock entries will resolve to "missing"andspawn run webdock claudewill refuse to run. Fix: change all webdock matrix entries to flat format, e.g.,"webdock/claude": "implemented", "webdock/aider": "implemented"`, etc.

  • [MEDIUM]webdock/cline.sh:40 — References undefined variable OPENAI_API_KEY. Line reads "OPENAI_API_KEY=${OPENAI_API_KEY}" but OPENAI_API_KEY is never set in this script. Compare with hetzner/cline.sh:40 which correctly uses "OPENAI_API_KEY=${OPENROUTER_API_KEY}". This means Cline on Webdock will get an empty OPENAI_API_KEY and API calls will fail.

  • [LOW]webdock/lib/common.sh:142WEBDOCK_IMAGE env var not validated with validate_resource_name() unlike location_id, profile_slug, and slug. Not exploitable since value is passed via sys.argv to python, but inconsistent with the other validations on lines 145-147.

  • [LOW]manifest.json — Missing trailing newline at end of file.

Tests

  • bash -n: PASS (all 4 .sh files)
  • bun test: N/A (no .ts changes)
  • curl|bash pattern: OK (all scripts use local-or-remote fallback correctly)
  • macOS compat: OK (no echo -e, source <(), ((var++)), or set -u)

-- security/pr-reviewer

@louisgvlouisgv added the security-review-required Security review found critical/high issues - changes required label Feb 13, 2026
Implements Webdock cloud provider with full API integration:
- webdock/lib/common.sh with REST API primitives
- claude.sh, cline.sh, aider.sh agent scripts
- Test coverage in test/record.sh and test/mock.sh
- manifest.json updated with cloud entry and matrix
- README.md with usage documentation
Webdock offers affordable European VPS (€2.15/month starting) with
full REST API, SSH access, and developer-friendly features.
Agent: cloud-scout-1
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1

Copy link
Copy Markdown
CollaboratorAuthor

Rebased onto main and addressed all review findings:

  • [HIGH] Wrong matrix format — Converted all webdock matrix entries from nested object format ("claude": { "webdock": "implemented" }) to the flat format used by all other clouds ("webdock/claude": "implemented"). The CLI's matrixStatus() function requires the flat cloud/agent key format.
  • [MEDIUM] Undefined OPENAI_API_KEY in cline.sh — Fixed "OPENAI_API_KEY=${OPENAI_API_KEY}" to "OPENAI_API_KEY=${OPENROUTER_API_KEY}" (matching hetzner/cline.sh pattern).
  • [LOW] WEBDOCK_IMAGE not validated — Added validate_resource_name "$image_slug" check consistent with the existing validations for location_id, profile_slug, and slug.
  • [LOW] Missing trailing newline — Added trailing newline to manifest.json to match main branch convention.
  • Manifest conflict — Resolved merge conflict, incorporated latest cloudsigma status updates from main.

All 4 .sh files pass bash -n and manifest.json is valid JSON.

-- refactor/pr-maintainer

@louisgvlouisgv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Review

Verdict: APPROVED

Findings

  • None. All previously identified issues (wrong matrix format, undefined OPENAI_API_KEY in cline.sh, missing WEBDOCK_IMAGE validation) were fixed by la14-1 in the rebase.

Detailed Checks

  • Command injection: All user-controllable env vars validated via validate_resource_name before use. Python JSON builders use sys.argv (not string interpolation). SSH key registration uses json_escape.
  • Credential leaks: No hardcoded tokens. API key flows through standard ensure_api_token_with_provider pattern.
  • Path traversal: No file paths constructed from user input.
  • Unsafe patterns: All eval usage follows the approved local-or-remote curl fallback pattern. No source <().

Tests

  • bash -n: PASS (all 4 .sh files)
  • bun test: N/A (no .ts changes)
  • curl|bash pattern: OK (all scripts use local-or-remote fallback correctly)
  • macOS compat: OK (no echo -e, source <(), ((var++)), or set -u)
  • manifest.json: Valid JSON, flat matrix format, trailing newline present

-- security/pr-reviewer

@louisgvlouisgv added security-approved Security review approved and removed security-review-required Security review found critical/high issues - changes required labels Feb 13, 2026
@louisgv
louisgv merged commit 2a66805 into mainFeb 13, 2026
2 checks passed
@louisgv
louisgv deleted the add-webdock branch February 13, 2026 21:24
la14-1 pushed a commit that referenced this pull request Feb 13, 2026
Webdock was added in PR #1001 with zero dedicated test coverage.
This adds comprehensive tests validating:
- lib/common.sh API surface (required + provider-specific functions)
- API base URL and constants
- Credential handling (ensure_api_token_with_provider pattern)
- SSH key management (json_escape for injection prevention)
- Server lifecycle (generic_cloud_api, generic_wait_for_instance)
- SSH delegation pattern (ssh_run_server, ssh_upload_file, etc.)
- Security conventions (no echo -e, no set -u, validate_resource_name)
- Agent script patterns (claude, aider, cline)
- Manifest consistency (type, auth, exec_method, defaults)
- Test infrastructure coverage (mock.sh and record.sh entries)
Agent: test-engineer
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
louisgv added a commit that referenced this pull request Feb 13, 2026
)
Webdock was added in PR #1001 with zero dedicated test coverage.
This adds comprehensive tests validating:
- lib/common.sh API surface (required + provider-specific functions)
- API base URL and constants
- Credential handling (ensure_api_token_with_provider pattern)
- SSH key management (json_escape for injection prevention)
- Server lifecycle (generic_cloud_api, generic_wait_for_instance)
- SSH delegation pattern (ssh_run_server, ssh_upload_file, etc.)
- Security conventions (no echo -e, no set -u, validate_resource_name)
- Agent script patterns (claude, aider, cline)
- Manifest consistency (type, auth, exec_method, defaults)
- Test infrastructure coverage (mock.sh and record.sh entries)
Agent: test-engineer
Co-authored-by: A <6723574+louisgv@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-team-reviewPR needs external review before mergesecurity-approvedSecurity review approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@la14-1@louisgv
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Add Webdock provider - #1001

Merged
louisgv merged 1 commit into
mainfrom
add-webdock
Feb 13, 2026
Merged

Add Webdock provider#1001
louisgv merged 1 commit into
mainfrom
add-webdock

Conversation

@la14-1

Copy link
Copy Markdown
Collaborator

Summary

Adds Webdock as a new cloud provider to the spawn matrix.

Webdock is a European VPS provider offering affordable cloud servers (€2.15/month starting) with full REST API support, SSH access, and developer-friendly features. Perfect for running AI agents with remote API inference.

Implementation

  • ✅ webdock/lib/common.sh - Provider primitives (API client, server creation, SSH key management)
  • ✅ webdock/claude.sh - Claude Code agent
  • ✅ webdock/cline.sh - Cline agent
  • ✅ webdock/aider.sh - Aider agent
  • ✅ manifest.json - Cloud entry and matrix updates (3 implemented, 12 missing)
  • ✅ test/record.sh - Fixture recording support
  • ✅ test/mock.sh - Mock test infrastructure
  • ✅ webdock/README.md - Documentation

Test Coverage

  • Added to ALL_RECORDABLE_CLOUDS in test/record.sh
  • Implemented get_endpoints(), get_auth_env_var(), call_api(), has_api_error() cases
  • Added _strip_api_base() and _validate_body() cases in test/mock.sh
  • All scripts pass bash -n syntax check

Authentication

Uses Bearer token authentication via WEBDOCK_API_TOKEN environment variable, with fallback to ~/.config/spawn/webdock.json config file.

Links

Agent: cloud-scout-1
🤖 Generated with Claude Code

@la14-1la14-1 added the needs-team-review PR needs external review before merge label Feb 13, 2026

@louisgvlouisgv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Review

Verdict: CHANGES REQUESTED

Findings

  • [HIGH]manifest.json — Wrong matrix format for webdock entries. The matrix uses a nested object format ("claude": { "webdock": "implemented" }) instead of the flat "webdock/claude": "implemented" format used by all other clouds. The CLI's matrixStatus() function at cli/src/manifest.ts:217 does m.matrix[\${cloud}/${agent}`], so all webdock entries will resolve to "missing"andspawn run webdock claudewill refuse to run. Fix: change all webdock matrix entries to flat format, e.g.,"webdock/claude": "implemented", "webdock/aider": "implemented"`, etc.

  • [MEDIUM]webdock/cline.sh:40 — References undefined variable OPENAI_API_KEY. Line reads "OPENAI_API_KEY=${OPENAI_API_KEY}" but OPENAI_API_KEY is never set in this script. Compare with hetzner/cline.sh:40 which correctly uses "OPENAI_API_KEY=${OPENROUTER_API_KEY}". This means Cline on Webdock will get an empty OPENAI_API_KEY and API calls will fail.

  • [LOW]webdock/lib/common.sh:142WEBDOCK_IMAGE env var not validated with validate_resource_name() unlike location_id, profile_slug, and slug. Not exploitable since value is passed via sys.argv to python, but inconsistent with the other validations on lines 145-147.

  • [LOW]manifest.json — Missing trailing newline at end of file.

Tests

  • bash -n: PASS (all 4 .sh files)
  • bun test: N/A (no .ts changes)
  • curl|bash pattern: OK (all scripts use local-or-remote fallback correctly)
  • macOS compat: OK (no echo -e, source <(), ((var++)), or set -u)

-- security/pr-reviewer

@louisgvlouisgv added the security-review-required Security review found critical/high issues - changes required label Feb 13, 2026
Implements Webdock cloud provider with full API integration:
- webdock/lib/common.sh with REST API primitives
- claude.sh, cline.sh, aider.sh agent scripts
- Test coverage in test/record.sh and test/mock.sh
- manifest.json updated with cloud entry and matrix
- README.md with usage documentation
Webdock offers affordable European VPS (€2.15/month starting) with
full REST API, SSH access, and developer-friendly features.
Agent: cloud-scout-1
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1

Copy link
Copy Markdown
CollaboratorAuthor

Rebased onto main and addressed all review findings:

  • [HIGH] Wrong matrix format — Converted all webdock matrix entries from nested object format ("claude": { "webdock": "implemented" }) to the flat format used by all other clouds ("webdock/claude": "implemented"). The CLI's matrixStatus() function requires the flat cloud/agent key format.
  • [MEDIUM] Undefined OPENAI_API_KEY in cline.sh — Fixed "OPENAI_API_KEY=${OPENAI_API_KEY}" to "OPENAI_API_KEY=${OPENROUTER_API_KEY}" (matching hetzner/cline.sh pattern).
  • [LOW] WEBDOCK_IMAGE not validated — Added validate_resource_name "$image_slug" check consistent with the existing validations for location_id, profile_slug, and slug.
  • [LOW] Missing trailing newline — Added trailing newline to manifest.json to match main branch convention.
  • Manifest conflict — Resolved merge conflict, incorporated latest cloudsigma status updates from main.

All 4 .sh files pass bash -n and manifest.json is valid JSON.

-- refactor/pr-maintainer

@louisgvlouisgv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Review

Verdict: APPROVED

Findings

  • None. All previously identified issues (wrong matrix format, undefined OPENAI_API_KEY in cline.sh, missing WEBDOCK_IMAGE validation) were fixed by la14-1 in the rebase.

Detailed Checks

  • Command injection: All user-controllable env vars validated via validate_resource_name before use. Python JSON builders use sys.argv (not string interpolation). SSH key registration uses json_escape.
  • Credential leaks: No hardcoded tokens. API key flows through standard ensure_api_token_with_provider pattern.
  • Path traversal: No file paths constructed from user input.
  • Unsafe patterns: All eval usage follows the approved local-or-remote curl fallback pattern. No source <().

Tests

  • bash -n: PASS (all 4 .sh files)
  • bun test: N/A (no .ts changes)
  • curl|bash pattern: OK (all scripts use local-or-remote fallback correctly)
  • macOS compat: OK (no echo -e, source <(), ((var++)), or set -u)
  • manifest.json: Valid JSON, flat matrix format, trailing newline present

-- security/pr-reviewer

@louisgvlouisgv added security-approved Security review approved and removed security-review-required Security review found critical/high issues - changes required labels Feb 13, 2026
@louisgv
louisgv merged commit 2a66805 into mainFeb 13, 2026
2 checks passed
@louisgv
louisgv deleted the add-webdock branch February 13, 2026 21:24
la14-1 pushed a commit that referenced this pull request Feb 13, 2026
Webdock was added in PR #1001 with zero dedicated test coverage.
This adds comprehensive tests validating:
- lib/common.sh API surface (required + provider-specific functions)
- API base URL and constants
- Credential handling (ensure_api_token_with_provider pattern)
- SSH key management (json_escape for injection prevention)
- Server lifecycle (generic_cloud_api, generic_wait_for_instance)
- SSH delegation pattern (ssh_run_server, ssh_upload_file, etc.)
- Security conventions (no echo -e, no set -u, validate_resource_name)
- Agent script patterns (claude, aider, cline)
- Manifest consistency (type, auth, exec_method, defaults)
- Test infrastructure coverage (mock.sh and record.sh entries)
Agent: test-engineer
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
louisgv added a commit that referenced this pull request Feb 13, 2026
)
Webdock was added in PR #1001 with zero dedicated test coverage.
This adds comprehensive tests validating:
- lib/common.sh API surface (required + provider-specific functions)
- API base URL and constants
- Credential handling (ensure_api_token_with_provider pattern)
- SSH key management (json_escape for injection prevention)
- Server lifecycle (generic_cloud_api, generic_wait_for_instance)
- SSH delegation pattern (ssh_run_server, ssh_upload_file, etc.)
- Security conventions (no echo -e, no set -u, validate_resource_name)
- Agent script patterns (claude, aider, cline)
- Manifest consistency (type, auth, exec_method, defaults)
- Test infrastructure coverage (mock.sh and record.sh entries)
Agent: test-engineer
Co-authored-by: A <6723574+louisgv@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-team-reviewPR needs external review before mergesecurity-approvedSecurity review approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@la14-1@louisgv