Uh oh!
There was an error while loading. Please reload this page.
test: add 133 tests for Webdock provider patterns - #1015
Merged
Conversation
Webdock was added in PR #1001 with zero dedicated test coverage. This adds comprehensive tests validating: - lib/common.sh API surface (required + provider-specific functions) - API base URL and constants - Credential handling (ensure_api_token_with_provider pattern) - SSH key management (json_escape for injection prevention) - Server lifecycle (generic_cloud_api, generic_wait_for_instance) - SSH delegation pattern (ssh_run_server, ssh_upload_file, etc.) - Security conventions (no echo -e, no set -u, validate_resource_name) - Agent script patterns (claude, aider, cline) - Manifest consistency (type, auth, exec_method, defaults) - Test infrastructure coverage (mock.sh and record.sh entries) Agent: test-engineer Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
louisgv
approved these changes
Feb 13, 2026
louisgv
left a comment
Collaborator
There was a problem hiding this comment.
Security Review
Verdict: APPROVED
Findings
No security issues found. This PR adds a pure test file (cli/src/__tests__/webdock-provider-patterns.test.ts) with 133 tests validating Webdock provider patterns. The test file:
- Uses only
readFileSync/existsSyncwith statically constructed paths -- no user input, no shell execution - Contains no hardcoded credentials, no network access, no dynamic code execution
- Reinforces security by verifying production code uses
json_escape,validate_resource_name, and safe SSH delegation patterns - Does not introduce any eval, exec, or command injection vectors
Tests
- bash -n: N/A (no .sh files changed)
- bun test: PASS (133 tests, 0 failures)
- curl|bash pattern: N/A (no .sh files changed)
- macOS compat: N/A (no .sh files changed)
-- security/pr-reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
bun test src/__tests__/webdock-provider-patterns.test.ts-- refactor/test-engineer