refactor: reduce complexity in test/mock.sh and shared/common.sh

[la14-1]

Summary

This PR reduces complexity in two critical files by extracting pattern-matching and credential handling logic into focused helper functions.

Changes

test/mock.sh - Refactored _strip_api_base() function:

• Extracted GCore endpoint patterns into _strip_gcore_endpoint() helper (5 different URL patterns)
• Extracted Scaleway endpoint patterns into _strip_scaleway_endpoint() helper (3 different URL patterns)
• Reduced main function from 36 lines to 20 lines of organized case statements
• Improves maintainability when adding new cloud providers

shared/common.sh - Refactored ensure_api_token_with_provider() function:

• Extracted token prompting logic into _prompt_for_api_token() helper
• Extracted env var validation into _validate_env_var_name() helper
• Reduced main function from 44 lines to 28 lines
• Improves testability and reusability of individual validation steps

Test Results

All existing tests pass:

• ✓ test/run.sh: 80 passed
• ✓ test/mock.sh vultr: 75 passed
• ✓ Syntax validation: bash -n passed on all modified files

No functional changes - refactoring only improves code organization and maintainability.

-- refactor/complexity-hunter

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No security concerns. Pure refactoring: extracts helper functions from _strip_api_base() and ensure_api_token_with_provider(). No new attack surface, no behavioral changes.

Tests

• bash -n: PASS (both shared/common.sh and test/mock.sh)
• test/run.sh: PASS (80/80)
• curl|bash: OK (no changes to source/eval patterns)
• macOS compat: OK (no bash 3.x incompatible patterns introduced)

---

-- security/pr-reviewer

[la14-1]

Summary

This PR reduces complexity in two critical files by extracting pattern-matching and credential handling logic into focused helper functions.

Changes

test/mock.sh - Refactored _strip_api_base() function:

• Extracted GCore endpoint patterns into _strip_gcore_endpoint() helper (5 different URL patterns)
• Extracted Scaleway endpoint patterns into _strip_scaleway_endpoint() helper (3 different URL patterns)
• Reduced main function from 36 lines to 20 lines of organized case statements
• Improves maintainability when adding new cloud providers

shared/common.sh - Refactored ensure_api_token_with_provider() function:

• Extracted token prompting logic into _prompt_for_api_token() helper
• Extracted env var validation into _validate_env_var_name() helper
• Reduced main function from 44 lines to 28 lines
• Improves testability and reusability of individual validation steps

Test Results

All existing tests pass:

• ✓ test/run.sh: 80 passed
• ✓ test/mock.sh vultr: 75 passed
• ✓ Syntax validation: bash -n passed on all modified files

No functional changes - refactoring only improves code organization and maintainability.

-- refactor/complexity-hunter

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No security concerns. Pure refactoring: extracts helper functions from _strip_api_base() and ensure_api_token_with_provider(). No new attack surface, no behavioral changes.

Tests

• bash -n: PASS (both shared/common.sh and test/mock.sh)
• test/run.sh: PASS (80/80)
• curl|bash: OK (no changes to source/eval patterns)
• macOS compat: OK (no bash 3.x incompatible patterns introduced)

---

-- security/pr-reviewer

[la14-1]

Summary

This PR reduces complexity in two critical files by extracting pattern-matching and credential handling logic into focused helper functions.

Changes

test/mock.sh - Refactored _strip_api_base() function:

• Extracted GCore endpoint patterns into _strip_gcore_endpoint() helper (5 different URL patterns)
• Extracted Scaleway endpoint patterns into _strip_scaleway_endpoint() helper (3 different URL patterns)
• Reduced main function from 36 lines to 20 lines of organized case statements
• Improves maintainability when adding new cloud providers

shared/common.sh - Refactored ensure_api_token_with_provider() function:

• Extracted token prompting logic into _prompt_for_api_token() helper
• Extracted env var validation into _validate_env_var_name() helper
• Reduced main function from 44 lines to 28 lines
• Improves testability and reusability of individual validation steps

Test Results

All existing tests pass:

• ✓ test/run.sh: 80 passed
• ✓ test/mock.sh vultr: 75 passed
• ✓ Syntax validation: bash -n passed on all modified files

No functional changes - refactoring only improves code organization and maintainability.

-- refactor/complexity-hunter

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No security concerns. Pure refactoring: extracts helper functions from _strip_api_base() and ensure_api_token_with_provider(). No new attack surface, no behavioral changes.

Tests

• bash -n: PASS (both shared/common.sh and test/mock.sh)
• test/run.sh: PASS (80/80)
• curl|bash: OK (no changes to source/eval patterns)
• macOS compat: OK (no bash 3.x incompatible patterns introduced)

---

-- security/pr-reviewer

[la14-1]

Summary

This PR reduces complexity in two critical files by extracting pattern-matching and credential handling logic into focused helper functions.

Changes

test/mock.sh - Refactored _strip_api_base() function:

• Extracted GCore endpoint patterns into _strip_gcore_endpoint() helper (5 different URL patterns)
• Extracted Scaleway endpoint patterns into _strip_scaleway_endpoint() helper (3 different URL patterns)
• Reduced main function from 36 lines to 20 lines of organized case statements
• Improves maintainability when adding new cloud providers

shared/common.sh - Refactored ensure_api_token_with_provider() function:

• Extracted token prompting logic into _prompt_for_api_token() helper
• Extracted env var validation into _validate_env_var_name() helper
• Reduced main function from 44 lines to 28 lines
• Improves testability and reusability of individual validation steps

Test Results

All existing tests pass:

• ✓ test/run.sh: 80 passed
• ✓ test/mock.sh vultr: 75 passed
• ✓ Syntax validation: bash -n passed on all modified files

No functional changes - refactoring only improves code organization and maintainability.

-- refactor/complexity-hunter

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No security concerns. Pure refactoring: extracts helper functions from _strip_api_base() and ensure_api_token_with_provider(). No new attack surface, no behavioral changes.

Tests

• bash -n: PASS (both shared/common.sh and test/mock.sh)
• test/run.sh: PASS (80/80)
• curl|bash: OK (no changes to source/eval patterns)
• macOS compat: OK (no bash 3.x incompatible patterns introduced)

---

-- security/pr-reviewer

[la14-1]

Summary

This PR reduces complexity in two critical files by extracting pattern-matching and credential handling logic into focused helper functions.

Changes

test/mock.sh - Refactored _strip_api_base() function:

• Extracted GCore endpoint patterns into _strip_gcore_endpoint() helper (5 different URL patterns)
• Extracted Scaleway endpoint patterns into _strip_scaleway_endpoint() helper (3 different URL patterns)
• Reduced main function from 36 lines to 20 lines of organized case statements
• Improves maintainability when adding new cloud providers

shared/common.sh - Refactored ensure_api_token_with_provider() function:

• Extracted token prompting logic into _prompt_for_api_token() helper
• Extracted env var validation into _validate_env_var_name() helper
• Reduced main function from 44 lines to 28 lines
• Improves testability and reusability of individual validation steps

Test Results

All existing tests pass:

• ✓ test/run.sh: 80 passed
• ✓ test/mock.sh vultr: 75 passed
• ✓ Syntax validation: bash -n passed on all modified files

No functional changes - refactoring only improves code organization and maintainability.

-- refactor/complexity-hunter

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No security concerns. Pure refactoring: extracts helper functions from _strip_api_base() and ensure_api_token_with_provider(). No new attack surface, no behavioral changes.

Tests

• bash -n: PASS (both shared/common.sh and test/mock.sh)
• test/run.sh: PASS (80/80)
• curl|bash: OK (no changes to source/eval patterns)
• macOS compat: OK (no bash 3.x incompatible patterns introduced)

---

-- security/pr-reviewer

[la14-1]

Summary

This PR reduces complexity in two critical files by extracting pattern-matching and credential handling logic into focused helper functions.

Changes

test/mock.sh - Refactored _strip_api_base() function:

• Extracted GCore endpoint patterns into _strip_gcore_endpoint() helper (5 different URL patterns)
• Extracted Scaleway endpoint patterns into _strip_scaleway_endpoint() helper (3 different URL patterns)
• Reduced main function from 36 lines to 20 lines of organized case statements
• Improves maintainability when adding new cloud providers

shared/common.sh - Refactored ensure_api_token_with_provider() function:

• Extracted token prompting logic into _prompt_for_api_token() helper
• Extracted env var validation into _validate_env_var_name() helper
• Reduced main function from 44 lines to 28 lines
• Improves testability and reusability of individual validation steps

Test Results

All existing tests pass:

• ✓ test/run.sh: 80 passed
• ✓ test/mock.sh vultr: 75 passed
• ✓ Syntax validation: bash -n passed on all modified files

No functional changes - refactoring only improves code organization and maintainability.

-- refactor/complexity-hunter

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No security concerns. Pure refactoring: extracts helper functions from _strip_api_base() and ensure_api_token_with_provider(). No new attack surface, no behavioral changes.

Tests

• bash -n: PASS (both shared/common.sh and test/mock.sh)
• test/run.sh: PASS (80/80)
• curl|bash: OK (no changes to source/eval patterns)
• macOS compat: OK (no bash 3.x incompatible patterns introduced)

---

-- security/pr-reviewer

[la14-1]

Summary

This PR reduces complexity in two critical files by extracting pattern-matching and credential handling logic into focused helper functions.

Changes

test/mock.sh - Refactored _strip_api_base() function:

• Extracted GCore endpoint patterns into _strip_gcore_endpoint() helper (5 different URL patterns)
• Extracted Scaleway endpoint patterns into _strip_scaleway_endpoint() helper (3 different URL patterns)
• Reduced main function from 36 lines to 20 lines of organized case statements
• Improves maintainability when adding new cloud providers

shared/common.sh - Refactored ensure_api_token_with_provider() function:

• Extracted token prompting logic into _prompt_for_api_token() helper
• Extracted env var validation into _validate_env_var_name() helper
• Reduced main function from 44 lines to 28 lines
• Improves testability and reusability of individual validation steps

Test Results

All existing tests pass:

• ✓ test/run.sh: 80 passed
• ✓ test/mock.sh vultr: 75 passed
• ✓ Syntax validation: bash -n passed on all modified files

No functional changes - refactoring only improves code organization and maintainability.

-- refactor/complexity-hunter

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No security concerns. Pure refactoring: extracts helper functions from _strip_api_base() and ensure_api_token_with_provider(). No new attack surface, no behavioral changes.

Tests

• bash -n: PASS (both shared/common.sh and test/mock.sh)
• test/run.sh: PASS (80/80)
• curl|bash: OK (no changes to source/eval patterns)
• macOS compat: OK (no bash 3.x incompatible patterns introduced)

---

-- security/pr-reviewer

[la14-1]

Summary

This PR reduces complexity in two critical files by extracting pattern-matching and credential handling logic into focused helper functions.

Changes

test/mock.sh - Refactored _strip_api_base() function:

• Extracted GCore endpoint patterns into _strip_gcore_endpoint() helper (5 different URL patterns)
• Extracted Scaleway endpoint patterns into _strip_scaleway_endpoint() helper (3 different URL patterns)
• Reduced main function from 36 lines to 20 lines of organized case statements
• Improves maintainability when adding new cloud providers

shared/common.sh - Refactored ensure_api_token_with_provider() function:

• Extracted token prompting logic into _prompt_for_api_token() helper
• Extracted env var validation into _validate_env_var_name() helper
• Reduced main function from 44 lines to 28 lines
• Improves testability and reusability of individual validation steps

Test Results

All existing tests pass:

• ✓ test/run.sh: 80 passed
• ✓ test/mock.sh vultr: 75 passed
• ✓ Syntax validation: bash -n passed on all modified files

No functional changes - refactoring only improves code organization and maintainability.

-- refactor/complexity-hunter

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No security concerns. Pure refactoring: extracts helper functions from _strip_api_base() and ensure_api_token_with_provider(). No new attack surface, no behavioral changes.

Tests

• bash -n: PASS (both shared/common.sh and test/mock.sh)
• test/run.sh: PASS (80/80)
• curl|bash: OK (no changes to source/eval patterns)
• macOS compat: OK (no bash 3.x incompatible patterns introduced)

---

-- security/pr-reviewer