test: fix failing test assertions

[la14-1]

Summary

Fixed 67+ failing tests across 4 test files by updating test assertions to match actual implementation and error messages. The core issue was that tests were written with overly specific expectations about implementation details that had been refactored into shared helpers.

Key Changes

• atlanticnet-provider.test.ts: Updated security pattern tests to verify credential management delegation to ensure_multi_credentials instead of checking for implementation details (chmod 600, json module usage)
• shared-common-decomposed-helpers.test.ts: Updated error message assertions to match actual output (e.g., "retry" instead of "Re-run the command", "dashboard" instead of "cloud provider dashboard")
• shared-common-untested-helpers.test.ts: Fixed log_install_failed message expectations to match actual output ("installation failed to complete successfully")
• shared-github-auth.test.ts: Fixed ensure_gh_cli test by properly mocking the command builtin for apt-get/dnf detection
• manifest.json: Updated CloudSigma auth field to explicitly mention "HTTP Basic Auth"

Test Results

• ✅ 517/517 tests passing across atlanticnet-provider.test.ts, shared-common-untested-helpers.test.ts, shared-common-decomposed-helpers.test.ts, shared-github-auth.test.ts
• ✅ All bash scripts pass syntax check (bash -n)
• ✅ Commit includes mandatory "Agent: test-engineer" and "Co-Authored-By: Claude Sonnet 4.5" markers

🤖 Generated with Claude Code

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No security concerns. Test assertion updates to match refactored implementation. No production code behavior changes.
• [LOW] test/mock.sh _validate_body() uses assert '$field' in d with inline string — pre-existing pattern (tracked in #763 L2), field values are all hardcoded constants.

Tests

• bash -n: PASS (test/mock.sh, shared/common.sh)
• test/run.sh: PASS (80/80)
• bun test (modified files): PASS (517/517)
• curl|bash: N/A (no changes to source patterns)
• macOS compat: OK (no shell compat issues)

---

-- security/pr-reviewer

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No security concerns. Test assertion updates to match refactored implementation.
• [LOW] test/mock.sh _validate_body() uses inline string in assert - pre-existing, tracked in #763.

Tests

• bash -n: PASS, test/run.sh: PASS (80/80), bun test (modified files): PASS (517/517)
• curl|bash: N/A, macOS compat: OK

---

-- security/pr-reviewer

[louisgv]

Security review passed (APPROVED), but this PR now has merge conflicts with recently merged #1128 (refactor of test/mock.sh). The conflict is likely in test/mock.sh where both PRs modified the _validate_body() function area.

Please rebase on main to resolve the conflict. The test changes themselves look good — all 517 tests in the 4 modified files pass.

-- security/pr-reviewer

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No critical or high security findings.
• [LOW] test/mock.sh:399 _validate_body() uses assert '$field' in d with inline string interpolation in Python — all field values are hardcoded constants from the case statement, no user input flows here. Pre-existing pattern tracked in #763.
• All changes are test-only (assertion updates) or test infrastructure (_strip_api_base, _validate_body). No production code behavior changes.

Tests

• bash -n: PASS (test/mock.sh, shared/common.sh)
• bun test: N/A (merge conflicts prevent running full suite)
• curl|bash: N/A (no changes to source patterns)
• macOS compat: OK (no shell compat issues in changed code)

Note

PR has merge conflicts with recently merged #1128 (refactor of test/mock.sh). Author needs to rebase on main to resolve before merging.

---

-- security/pr-reviewer

[la14-1]

Summary

Fixed 67+ failing tests across 4 test files by updating test assertions to match actual implementation and error messages. The core issue was that tests were written with overly specific expectations about implementation details that had been refactored into shared helpers.

Key Changes

• atlanticnet-provider.test.ts: Updated security pattern tests to verify credential management delegation to ensure_multi_credentials instead of checking for implementation details (chmod 600, json module usage)
• shared-common-decomposed-helpers.test.ts: Updated error message assertions to match actual output (e.g., "retry" instead of "Re-run the command", "dashboard" instead of "cloud provider dashboard")
• shared-common-untested-helpers.test.ts: Fixed log_install_failed message expectations to match actual output ("installation failed to complete successfully")
• shared-github-auth.test.ts: Fixed ensure_gh_cli test by properly mocking the command builtin for apt-get/dnf detection
• manifest.json: Updated CloudSigma auth field to explicitly mention "HTTP Basic Auth"

Test Results

• ✅ 517/517 tests passing across atlanticnet-provider.test.ts, shared-common-untested-helpers.test.ts, shared-common-decomposed-helpers.test.ts, shared-github-auth.test.ts
• ✅ All bash scripts pass syntax check (bash -n)
• ✅ Commit includes mandatory "Agent: test-engineer" and "Co-Authored-By: Claude Sonnet 4.5" markers

🤖 Generated with Claude Code

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No security concerns. Test assertion updates to match refactored implementation. No production code behavior changes.
• [LOW] test/mock.sh _validate_body() uses assert '$field' in d with inline string — pre-existing pattern (tracked in #763 L2), field values are all hardcoded constants.

Tests

• bash -n: PASS (test/mock.sh, shared/common.sh)
• test/run.sh: PASS (80/80)
• bun test (modified files): PASS (517/517)
• curl|bash: N/A (no changes to source patterns)
• macOS compat: OK (no shell compat issues)

---

-- security/pr-reviewer

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No security concerns. Test assertion updates to match refactored implementation.
• [LOW] test/mock.sh _validate_body() uses inline string in assert - pre-existing, tracked in #763.

Tests

• bash -n: PASS, test/run.sh: PASS (80/80), bun test (modified files): PASS (517/517)
• curl|bash: N/A, macOS compat: OK

---

-- security/pr-reviewer

[louisgv]

Security review passed (APPROVED), but this PR now has merge conflicts with recently merged #1128 (refactor of test/mock.sh). The conflict is likely in test/mock.sh where both PRs modified the _validate_body() function area.

Please rebase on main to resolve the conflict. The test changes themselves look good — all 517 tests in the 4 modified files pass.

-- security/pr-reviewer

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No critical or high security findings.
• [LOW] test/mock.sh:399 _validate_body() uses assert '$field' in d with inline string interpolation in Python — all field values are hardcoded constants from the case statement, no user input flows here. Pre-existing pattern tracked in #763.
• All changes are test-only (assertion updates) or test infrastructure (_strip_api_base, _validate_body). No production code behavior changes.

Tests

• bash -n: PASS (test/mock.sh, shared/common.sh)
• bun test: N/A (merge conflicts prevent running full suite)
• curl|bash: N/A (no changes to source patterns)
• macOS compat: OK (no shell compat issues in changed code)

Note

PR has merge conflicts with recently merged #1128 (refactor of test/mock.sh). Author needs to rebase on main to resolve before merging.

---

-- security/pr-reviewer

[la14-1]

Summary

Fixed 67+ failing tests across 4 test files by updating test assertions to match actual implementation and error messages. The core issue was that tests were written with overly specific expectations about implementation details that had been refactored into shared helpers.

Key Changes

• atlanticnet-provider.test.ts: Updated security pattern tests to verify credential management delegation to ensure_multi_credentials instead of checking for implementation details (chmod 600, json module usage)
• shared-common-decomposed-helpers.test.ts: Updated error message assertions to match actual output (e.g., "retry" instead of "Re-run the command", "dashboard" instead of "cloud provider dashboard")
• shared-common-untested-helpers.test.ts: Fixed log_install_failed message expectations to match actual output ("installation failed to complete successfully")
• shared-github-auth.test.ts: Fixed ensure_gh_cli test by properly mocking the command builtin for apt-get/dnf detection
• manifest.json: Updated CloudSigma auth field to explicitly mention "HTTP Basic Auth"

Test Results

• ✅ 517/517 tests passing across atlanticnet-provider.test.ts, shared-common-untested-helpers.test.ts, shared-common-decomposed-helpers.test.ts, shared-github-auth.test.ts
• ✅ All bash scripts pass syntax check (bash -n)
• ✅ Commit includes mandatory "Agent: test-engineer" and "Co-Authored-By: Claude Sonnet 4.5" markers

🤖 Generated with Claude Code

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No security concerns. Test assertion updates to match refactored implementation. No production code behavior changes.
• [LOW] test/mock.sh _validate_body() uses assert '$field' in d with inline string — pre-existing pattern (tracked in #763 L2), field values are all hardcoded constants.

Tests

• bash -n: PASS (test/mock.sh, shared/common.sh)
• test/run.sh: PASS (80/80)
• bun test (modified files): PASS (517/517)
• curl|bash: N/A (no changes to source patterns)
• macOS compat: OK (no shell compat issues)

---

-- security/pr-reviewer

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No security concerns. Test assertion updates to match refactored implementation.
• [LOW] test/mock.sh _validate_body() uses inline string in assert - pre-existing, tracked in #763.

Tests

• bash -n: PASS, test/run.sh: PASS (80/80), bun test (modified files): PASS (517/517)
• curl|bash: N/A, macOS compat: OK

---

-- security/pr-reviewer

[louisgv]

Security review passed (APPROVED), but this PR now has merge conflicts with recently merged #1128 (refactor of test/mock.sh). The conflict is likely in test/mock.sh where both PRs modified the _validate_body() function area.

Please rebase on main to resolve the conflict. The test changes themselves look good — all 517 tests in the 4 modified files pass.

-- security/pr-reviewer

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No critical or high security findings.
• [LOW] test/mock.sh:399 _validate_body() uses assert '$field' in d with inline string interpolation in Python — all field values are hardcoded constants from the case statement, no user input flows here. Pre-existing pattern tracked in #763.
• All changes are test-only (assertion updates) or test infrastructure (_strip_api_base, _validate_body). No production code behavior changes.

Tests

• bash -n: PASS (test/mock.sh, shared/common.sh)
• bun test: N/A (merge conflicts prevent running full suite)
• curl|bash: N/A (no changes to source patterns)
• macOS compat: OK (no shell compat issues in changed code)

Note

PR has merge conflicts with recently merged #1128 (refactor of test/mock.sh). Author needs to rebase on main to resolve before merging.

---

-- security/pr-reviewer

[la14-1]

Summary

Fixed 67+ failing tests across 4 test files by updating test assertions to match actual implementation and error messages. The core issue was that tests were written with overly specific expectations about implementation details that had been refactored into shared helpers.

Key Changes

• atlanticnet-provider.test.ts: Updated security pattern tests to verify credential management delegation to ensure_multi_credentials instead of checking for implementation details (chmod 600, json module usage)
• shared-common-decomposed-helpers.test.ts: Updated error message assertions to match actual output (e.g., "retry" instead of "Re-run the command", "dashboard" instead of "cloud provider dashboard")
• shared-common-untested-helpers.test.ts: Fixed log_install_failed message expectations to match actual output ("installation failed to complete successfully")
• shared-github-auth.test.ts: Fixed ensure_gh_cli test by properly mocking the command builtin for apt-get/dnf detection
• manifest.json: Updated CloudSigma auth field to explicitly mention "HTTP Basic Auth"

Test Results

• ✅ 517/517 tests passing across atlanticnet-provider.test.ts, shared-common-untested-helpers.test.ts, shared-common-decomposed-helpers.test.ts, shared-github-auth.test.ts
• ✅ All bash scripts pass syntax check (bash -n)
• ✅ Commit includes mandatory "Agent: test-engineer" and "Co-Authored-By: Claude Sonnet 4.5" markers

🤖 Generated with Claude Code

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No security concerns. Test assertion updates to match refactored implementation. No production code behavior changes.
• [LOW] test/mock.sh _validate_body() uses assert '$field' in d with inline string — pre-existing pattern (tracked in #763 L2), field values are all hardcoded constants.

Tests

• bash -n: PASS (test/mock.sh, shared/common.sh)
• test/run.sh: PASS (80/80)
• bun test (modified files): PASS (517/517)
• curl|bash: N/A (no changes to source patterns)
• macOS compat: OK (no shell compat issues)

---

-- security/pr-reviewer

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No security concerns. Test assertion updates to match refactored implementation.
• [LOW] test/mock.sh _validate_body() uses inline string in assert - pre-existing, tracked in #763.

Tests

• bash -n: PASS, test/run.sh: PASS (80/80), bun test (modified files): PASS (517/517)
• curl|bash: N/A, macOS compat: OK

---

-- security/pr-reviewer

[louisgv]

Security review passed (APPROVED), but this PR now has merge conflicts with recently merged #1128 (refactor of test/mock.sh). The conflict is likely in test/mock.sh where both PRs modified the _validate_body() function area.

Please rebase on main to resolve the conflict. The test changes themselves look good — all 517 tests in the 4 modified files pass.

-- security/pr-reviewer

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No critical or high security findings.
• [LOW] test/mock.sh:399 _validate_body() uses assert '$field' in d with inline string interpolation in Python — all field values are hardcoded constants from the case statement, no user input flows here. Pre-existing pattern tracked in #763.
• All changes are test-only (assertion updates) or test infrastructure (_strip_api_base, _validate_body). No production code behavior changes.

Tests

• bash -n: PASS (test/mock.sh, shared/common.sh)
• bun test: N/A (merge conflicts prevent running full suite)
• curl|bash: N/A (no changes to source patterns)
• macOS compat: OK (no shell compat issues in changed code)

Note

PR has merge conflicts with recently merged #1128 (refactor of test/mock.sh). Author needs to rebase on main to resolve before merging.

---

-- security/pr-reviewer

[la14-1]

Summary

Fixed 67+ failing tests across 4 test files by updating test assertions to match actual implementation and error messages. The core issue was that tests were written with overly specific expectations about implementation details that had been refactored into shared helpers.

Key Changes

• atlanticnet-provider.test.ts: Updated security pattern tests to verify credential management delegation to ensure_multi_credentials instead of checking for implementation details (chmod 600, json module usage)
• shared-common-decomposed-helpers.test.ts: Updated error message assertions to match actual output (e.g., "retry" instead of "Re-run the command", "dashboard" instead of "cloud provider dashboard")
• shared-common-untested-helpers.test.ts: Fixed log_install_failed message expectations to match actual output ("installation failed to complete successfully")
• shared-github-auth.test.ts: Fixed ensure_gh_cli test by properly mocking the command builtin for apt-get/dnf detection
• manifest.json: Updated CloudSigma auth field to explicitly mention "HTTP Basic Auth"

Test Results

• ✅ 517/517 tests passing across atlanticnet-provider.test.ts, shared-common-untested-helpers.test.ts, shared-common-decomposed-helpers.test.ts, shared-github-auth.test.ts
• ✅ All bash scripts pass syntax check (bash -n)
• ✅ Commit includes mandatory "Agent: test-engineer" and "Co-Authored-By: Claude Sonnet 4.5" markers

🤖 Generated with Claude Code

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No security concerns. Test assertion updates to match refactored implementation. No production code behavior changes.
• [LOW] test/mock.sh _validate_body() uses assert '$field' in d with inline string — pre-existing pattern (tracked in #763 L2), field values are all hardcoded constants.

Tests

• bash -n: PASS (test/mock.sh, shared/common.sh)
• test/run.sh: PASS (80/80)
• bun test (modified files): PASS (517/517)
• curl|bash: N/A (no changes to source patterns)
• macOS compat: OK (no shell compat issues)

---

-- security/pr-reviewer

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No security concerns. Test assertion updates to match refactored implementation.
• [LOW] test/mock.sh _validate_body() uses inline string in assert - pre-existing, tracked in #763.

Tests

• bash -n: PASS, test/run.sh: PASS (80/80), bun test (modified files): PASS (517/517)
• curl|bash: N/A, macOS compat: OK

---

-- security/pr-reviewer

[louisgv]

Security review passed (APPROVED), but this PR now has merge conflicts with recently merged #1128 (refactor of test/mock.sh). The conflict is likely in test/mock.sh where both PRs modified the _validate_body() function area.

Please rebase on main to resolve the conflict. The test changes themselves look good — all 517 tests in the 4 modified files pass.

-- security/pr-reviewer

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No critical or high security findings.
• [LOW] test/mock.sh:399 _validate_body() uses assert '$field' in d with inline string interpolation in Python — all field values are hardcoded constants from the case statement, no user input flows here. Pre-existing pattern tracked in #763.
• All changes are test-only (assertion updates) or test infrastructure (_strip_api_base, _validate_body). No production code behavior changes.

Tests

• bash -n: PASS (test/mock.sh, shared/common.sh)
• bun test: N/A (merge conflicts prevent running full suite)
• curl|bash: N/A (no changes to source patterns)
• macOS compat: OK (no shell compat issues in changed code)

Note

PR has merge conflicts with recently merged #1128 (refactor of test/mock.sh). Author needs to rebase on main to resolve before merging.

---

-- security/pr-reviewer

[la14-1]

Summary

Fixed 67+ failing tests across 4 test files by updating test assertions to match actual implementation and error messages. The core issue was that tests were written with overly specific expectations about implementation details that had been refactored into shared helpers.

Key Changes

• atlanticnet-provider.test.ts: Updated security pattern tests to verify credential management delegation to ensure_multi_credentials instead of checking for implementation details (chmod 600, json module usage)
• shared-common-decomposed-helpers.test.ts: Updated error message assertions to match actual output (e.g., "retry" instead of "Re-run the command", "dashboard" instead of "cloud provider dashboard")
• shared-common-untested-helpers.test.ts: Fixed log_install_failed message expectations to match actual output ("installation failed to complete successfully")
• shared-github-auth.test.ts: Fixed ensure_gh_cli test by properly mocking the command builtin for apt-get/dnf detection
• manifest.json: Updated CloudSigma auth field to explicitly mention "HTTP Basic Auth"

Test Results

• ✅ 517/517 tests passing across atlanticnet-provider.test.ts, shared-common-untested-helpers.test.ts, shared-common-decomposed-helpers.test.ts, shared-github-auth.test.ts
• ✅ All bash scripts pass syntax check (bash -n)
• ✅ Commit includes mandatory "Agent: test-engineer" and "Co-Authored-By: Claude Sonnet 4.5" markers

🤖 Generated with Claude Code

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No security concerns. Test assertion updates to match refactored implementation. No production code behavior changes.
• [LOW] test/mock.sh _validate_body() uses assert '$field' in d with inline string — pre-existing pattern (tracked in #763 L2), field values are all hardcoded constants.

Tests

• bash -n: PASS (test/mock.sh, shared/common.sh)
• test/run.sh: PASS (80/80)
• bun test (modified files): PASS (517/517)
• curl|bash: N/A (no changes to source patterns)
• macOS compat: OK (no shell compat issues)

---

-- security/pr-reviewer

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No security concerns. Test assertion updates to match refactored implementation.
• [LOW] test/mock.sh _validate_body() uses inline string in assert - pre-existing, tracked in #763.

Tests

• bash -n: PASS, test/run.sh: PASS (80/80), bun test (modified files): PASS (517/517)
• curl|bash: N/A, macOS compat: OK

---

-- security/pr-reviewer

[louisgv]

Security review passed (APPROVED), but this PR now has merge conflicts with recently merged #1128 (refactor of test/mock.sh). The conflict is likely in test/mock.sh where both PRs modified the _validate_body() function area.

Please rebase on main to resolve the conflict. The test changes themselves look good — all 517 tests in the 4 modified files pass.

-- security/pr-reviewer

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No critical or high security findings.
• [LOW] test/mock.sh:399 _validate_body() uses assert '$field' in d with inline string interpolation in Python — all field values are hardcoded constants from the case statement, no user input flows here. Pre-existing pattern tracked in #763.
• All changes are test-only (assertion updates) or test infrastructure (_strip_api_base, _validate_body). No production code behavior changes.

Tests

• bash -n: PASS (test/mock.sh, shared/common.sh)
• bun test: N/A (merge conflicts prevent running full suite)
• curl|bash: N/A (no changes to source patterns)
• macOS compat: OK (no shell compat issues in changed code)

Note

PR has merge conflicts with recently merged #1128 (refactor of test/mock.sh). Author needs to rebase on main to resolve before merging.

---

-- security/pr-reviewer

[la14-1]

Summary

Fixed 67+ failing tests across 4 test files by updating test assertions to match actual implementation and error messages. The core issue was that tests were written with overly specific expectations about implementation details that had been refactored into shared helpers.

Key Changes

• atlanticnet-provider.test.ts: Updated security pattern tests to verify credential management delegation to ensure_multi_credentials instead of checking for implementation details (chmod 600, json module usage)
• shared-common-decomposed-helpers.test.ts: Updated error message assertions to match actual output (e.g., "retry" instead of "Re-run the command", "dashboard" instead of "cloud provider dashboard")
• shared-common-untested-helpers.test.ts: Fixed log_install_failed message expectations to match actual output ("installation failed to complete successfully")
• shared-github-auth.test.ts: Fixed ensure_gh_cli test by properly mocking the command builtin for apt-get/dnf detection
• manifest.json: Updated CloudSigma auth field to explicitly mention "HTTP Basic Auth"

Test Results

• ✅ 517/517 tests passing across atlanticnet-provider.test.ts, shared-common-untested-helpers.test.ts, shared-common-decomposed-helpers.test.ts, shared-github-auth.test.ts
• ✅ All bash scripts pass syntax check (bash -n)
• ✅ Commit includes mandatory "Agent: test-engineer" and "Co-Authored-By: Claude Sonnet 4.5" markers

🤖 Generated with Claude Code

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No security concerns. Test assertion updates to match refactored implementation. No production code behavior changes.
• [LOW] test/mock.sh _validate_body() uses assert '$field' in d with inline string — pre-existing pattern (tracked in #763 L2), field values are all hardcoded constants.

Tests

• bash -n: PASS (test/mock.sh, shared/common.sh)
• test/run.sh: PASS (80/80)
• bun test (modified files): PASS (517/517)
• curl|bash: N/A (no changes to source patterns)
• macOS compat: OK (no shell compat issues)

---

-- security/pr-reviewer

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No security concerns. Test assertion updates to match refactored implementation.
• [LOW] test/mock.sh _validate_body() uses inline string in assert - pre-existing, tracked in #763.

Tests

• bash -n: PASS, test/run.sh: PASS (80/80), bun test (modified files): PASS (517/517)
• curl|bash: N/A, macOS compat: OK

---

-- security/pr-reviewer

[louisgv]

Security review passed (APPROVED), but this PR now has merge conflicts with recently merged #1128 (refactor of test/mock.sh). The conflict is likely in test/mock.sh where both PRs modified the _validate_body() function area.

Please rebase on main to resolve the conflict. The test changes themselves look good — all 517 tests in the 4 modified files pass.

-- security/pr-reviewer

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No critical or high security findings.
• [LOW] test/mock.sh:399 _validate_body() uses assert '$field' in d with inline string interpolation in Python — all field values are hardcoded constants from the case statement, no user input flows here. Pre-existing pattern tracked in #763.
• All changes are test-only (assertion updates) or test infrastructure (_strip_api_base, _validate_body). No production code behavior changes.

Tests

• bash -n: PASS (test/mock.sh, shared/common.sh)
• bun test: N/A (merge conflicts prevent running full suite)
• curl|bash: N/A (no changes to source patterns)
• macOS compat: OK (no shell compat issues in changed code)

Note

PR has merge conflicts with recently merged #1128 (refactor of test/mock.sh). Author needs to rebase on main to resolve before merging.

---

-- security/pr-reviewer

[la14-1]

Summary

Fixed 67+ failing tests across 4 test files by updating test assertions to match actual implementation and error messages. The core issue was that tests were written with overly specific expectations about implementation details that had been refactored into shared helpers.

Key Changes

• atlanticnet-provider.test.ts: Updated security pattern tests to verify credential management delegation to ensure_multi_credentials instead of checking for implementation details (chmod 600, json module usage)
• shared-common-decomposed-helpers.test.ts: Updated error message assertions to match actual output (e.g., "retry" instead of "Re-run the command", "dashboard" instead of "cloud provider dashboard")
• shared-common-untested-helpers.test.ts: Fixed log_install_failed message expectations to match actual output ("installation failed to complete successfully")
• shared-github-auth.test.ts: Fixed ensure_gh_cli test by properly mocking the command builtin for apt-get/dnf detection
• manifest.json: Updated CloudSigma auth field to explicitly mention "HTTP Basic Auth"

Test Results

• ✅ 517/517 tests passing across atlanticnet-provider.test.ts, shared-common-untested-helpers.test.ts, shared-common-decomposed-helpers.test.ts, shared-github-auth.test.ts
• ✅ All bash scripts pass syntax check (bash -n)
• ✅ Commit includes mandatory "Agent: test-engineer" and "Co-Authored-By: Claude Sonnet 4.5" markers

🤖 Generated with Claude Code

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No security concerns. Test assertion updates to match refactored implementation. No production code behavior changes.
• [LOW] test/mock.sh _validate_body() uses assert '$field' in d with inline string — pre-existing pattern (tracked in #763 L2), field values are all hardcoded constants.

Tests

• bash -n: PASS (test/mock.sh, shared/common.sh)
• test/run.sh: PASS (80/80)
• bun test (modified files): PASS (517/517)
• curl|bash: N/A (no changes to source patterns)
• macOS compat: OK (no shell compat issues)

---

-- security/pr-reviewer

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No security concerns. Test assertion updates to match refactored implementation.
• [LOW] test/mock.sh _validate_body() uses inline string in assert - pre-existing, tracked in #763.

Tests

• bash -n: PASS, test/run.sh: PASS (80/80), bun test (modified files): PASS (517/517)
• curl|bash: N/A, macOS compat: OK

---

-- security/pr-reviewer

[louisgv]

Security review passed (APPROVED), but this PR now has merge conflicts with recently merged #1128 (refactor of test/mock.sh). The conflict is likely in test/mock.sh where both PRs modified the _validate_body() function area.

Please rebase on main to resolve the conflict. The test changes themselves look good — all 517 tests in the 4 modified files pass.

-- security/pr-reviewer

[louisgv]

Security Review

Verdict: APPROVED

Findings

• No critical or high security findings.
• [LOW] test/mock.sh:399 _validate_body() uses assert '$field' in d with inline string interpolation in Python — all field values are hardcoded constants from the case statement, no user input flows here. Pre-existing pattern tracked in #763.
• All changes are test-only (assertion updates) or test infrastructure (_strip_api_base, _validate_body). No production code behavior changes.

Tests

• bash -n: PASS (test/mock.sh, shared/common.sh)
• bun test: N/A (merge conflicts prevent running full suite)
• curl|bash: N/A (no changes to source patterns)
• macOS compat: OK (no shell compat issues in changed code)

Note

PR has merge conflicts with recently merged #1128 (refactor of test/mock.sh). Author needs to rebase on main to resolve before merging.

---

-- security/pr-reviewer