Uh oh!
There was an error while loading. Please reload this page.
fix: use asyncTryCatch for tarball install + add chown ownership fix - #2478
Merged
Conversation
Replace try/catch in agent-tarball.ts with asyncTryCatch Result helpers: - Phase 3 (download/extract): asyncTryCatch → returns false on any failure - Phase 4 (mirror): asyncTryCatch → non-fatal, logs warning on failure Add chown ownership fix for non-root SSH users (GCP, AWS Lightsail): files extracted as root need ownership corrected after mirroring. Add 5 anti-regression tests for non-root home directory mirroring. Supersedes #2466. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
louisgv
approved these changes
Mar 11, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-tarball.tswithasyncTryCatchResult helpers (from refactor: replace indiscriminate try/catch with guarded Result helpers #2477)chownownership fix for non-root SSH users (GCP, AWS Lightsail) — files extracted as root need ownership corrected after mirroring to$HOMESupersedes #2466 — same functionality but uses the new Result helpers instead of
.then()/.catch()promise patterns.Test plan
bunx @biomejs/biome check src/— 115 files, 0 errorsbun test— 1568 pass, 0 failbun test src/__tests__/agent-tarball.test.ts— 12 pass (5 new)🤖 Generated with Claude Code