feat(cli): --repo accepts any git URL, not just GitHub slugs - #3364

Merged
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:feat/repo-url
Apr 29, 2026
Merged

feat(cli): --repo accepts any git URL, not just GitHub slugs#3364
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:feat/repo-url

Conversation

@AhmedTMM

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #3360. Lifts the GitHub-only restriction on `--repo`. The flag now takes any git URL.

```
spawn --repo user/repo # GitHub shorthand (still works)
spawn --repo https://gitlab.com/team/repo
spawn --repo git@github.com:user/repo.git
spawn --repo ssh://git@example.com/x/y.git
spawn --repo http://gitea.internal/x/y
```

How it works

New `normalizeRepoUrl()` helper in `shared/orchestrate.ts`:

  • GitHub shorthand `user/repo` → `https://github.com/user/repo.git\` (unchanged behavior)
  • HTTP(S) / ssh:// / git:// / git+ssh:// URLs → unchanged
  • SCP-style `git@host:path` (host must contain a dot) → unchanged
  • Anything containing shell metacharacters, whitespace, NUL bytes, or a leading `-` → rejected with a warn (no clone)

The clone URL is also `shellQuote`d at the call site as defense in depth.

Test plan

  • `bunx @biomejs/biome check src/` — 0 errors
  • `bunx tsc --noEmit -p .` — 0 production errors
  • New `repo-url.test.ts` (10 cases): GitHub shorthand expansion, HTTPS / SSH / git:// / SCP pass-through, injection attempts (`;`, backticks, `$()`, `|`, `&&`, quotes), embedded whitespace, NUL bytes, leading `-`, gibberish, oversized inputs, surrounding whitespace trimming.
  • Existing `orchestrate.test.ts` still passes.
  • End-to-end smoke: `--repo` against a non-GitHub host (GitLab / Gitea)

Bumps CLI to 1.0.23.

🤖 Generated with Claude Code

@la14-1

Copy link
Copy Markdown
Collaborator

Review

Solid follow-up to #3360 — the URL matrix handled here is what users actually want.

Looks good

  • normalizeRepoUrl is the right abstraction. Return-null-on-reject + logWarn at the call site gives a clean fail-closed story.
  • SCP-style regex requires a dot in the host, which correctly disambiguates from GitHub shorthand. git@github.com:user/repo still flows through; git@localhost:path is rejected (niche, acceptable).
  • Leading-- rejection prevents the classic --upload-pack=evil git-option-masquerade attack.
  • Length cap at 500 + comprehensive shell-meta rejection + defense-in-depth shellQuote at the call site. Layered right.
  • Test coverage is thorough: GitHub shorthand, HTTPS, SSH, git://, SCP-style, meta-chars (;, backticks, $(), |, &&, quotes), whitespace, NUL, leading -, path traversal, oversized input, whitespace trimming.

Minor

  • mergeStateStatus: BEHIND — needs a rebase. When you do, the CLI version in package.json will also need to bump: feat(cli): posthog feature flags + fast_provision experiment #3366 / the revert are both ahead of you at 1.0.23/1.0.24, so this PR will need to land at 1.0.25.
  • Rejects !, *, ?, # — not strictly dangerous (glob/history, only interactive-shell or git-URL-cosmetic), but harmless to reject. No action needed.
  • SCP regex requires a . in the host — intentional per the docstring, but users cloning from a no-dot internal host (git@buildbox:team/repo) will be rejected. If that's a real use case, add an explicit ssh:// form guidance to the warn message.

Nice-to-have (not blocking)

  • Consider logging the normalized clone URL alongside the original in the logStep("Cloning template repository...") path when they differ, so debug sessions can tell shorthand expansion from direct URL pass-through.

LGTM after rebase + version bump. No functional changes requested.

Reviewed by SPA

Adds normalizeRepoUrl() to accept:
- GitHub shorthand (user/repo) — still expanded to https://github.com/...
- HTTP(S) URLs (any host)
- ssh:// and git:// URLs
- SCP-style git@host:path
The clone URL is shellQuote'd before interpolation; values containing
shell metacharacters, whitespace, NUL bytes, or a leading `-` (which
git would parse as a flag) are rejected.
Bumps CLI to 1.0.23.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

@la14-1la14-1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased onto latest main + bumped to 1.0.25 on Ahmed's behalf (maintainerCanModify was enabled). Full review at the earlier comment. CI green.

@la14-1
la14-1 merged commit c907359 into OpenRouterLabs:mainApr 29, 2026
5 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AhmedTMM@la14-1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

feat(cli): --repo accepts any git URL, not just GitHub slugs - #3364

Merged
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:feat/repo-url
Apr 29, 2026
Merged

feat(cli): --repo accepts any git URL, not just GitHub slugs#3364
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:feat/repo-url

Conversation

@AhmedTMM

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #3360. Lifts the GitHub-only restriction on `--repo`. The flag now takes any git URL.

```
spawn --repo user/repo # GitHub shorthand (still works)
spawn --repo https://gitlab.com/team/repo
spawn --repo git@github.com:user/repo.git
spawn --repo ssh://git@example.com/x/y.git
spawn --repo http://gitea.internal/x/y
```

How it works

New `normalizeRepoUrl()` helper in `shared/orchestrate.ts`:

  • GitHub shorthand `user/repo` → `https://github.com/user/repo.git\` (unchanged behavior)
  • HTTP(S) / ssh:// / git:// / git+ssh:// URLs → unchanged
  • SCP-style `git@host:path` (host must contain a dot) → unchanged
  • Anything containing shell metacharacters, whitespace, NUL bytes, or a leading `-` → rejected with a warn (no clone)

The clone URL is also `shellQuote`d at the call site as defense in depth.

Test plan

  • `bunx @biomejs/biome check src/` — 0 errors
  • `bunx tsc --noEmit -p .` — 0 production errors
  • New `repo-url.test.ts` (10 cases): GitHub shorthand expansion, HTTPS / SSH / git:// / SCP pass-through, injection attempts (`;`, backticks, `$()`, `|`, `&&`, quotes), embedded whitespace, NUL bytes, leading `-`, gibberish, oversized inputs, surrounding whitespace trimming.
  • Existing `orchestrate.test.ts` still passes.
  • End-to-end smoke: `--repo` against a non-GitHub host (GitLab / Gitea)

Bumps CLI to 1.0.23.

🤖 Generated with Claude Code

@la14-1

Copy link
Copy Markdown
Collaborator

Review

Solid follow-up to #3360 — the URL matrix handled here is what users actually want.

Looks good

  • normalizeRepoUrl is the right abstraction. Return-null-on-reject + logWarn at the call site gives a clean fail-closed story.
  • SCP-style regex requires a dot in the host, which correctly disambiguates from GitHub shorthand. git@github.com:user/repo still flows through; git@localhost:path is rejected (niche, acceptable).
  • Leading-- rejection prevents the classic --upload-pack=evil git-option-masquerade attack.
  • Length cap at 500 + comprehensive shell-meta rejection + defense-in-depth shellQuote at the call site. Layered right.
  • Test coverage is thorough: GitHub shorthand, HTTPS, SSH, git://, SCP-style, meta-chars (;, backticks, $(), |, &&, quotes), whitespace, NUL, leading -, path traversal, oversized input, whitespace trimming.

Minor

  • mergeStateStatus: BEHIND — needs a rebase. When you do, the CLI version in package.json will also need to bump: feat(cli): posthog feature flags + fast_provision experiment #3366 / the revert are both ahead of you at 1.0.23/1.0.24, so this PR will need to land at 1.0.25.
  • Rejects !, *, ?, # — not strictly dangerous (glob/history, only interactive-shell or git-URL-cosmetic), but harmless to reject. No action needed.
  • SCP regex requires a . in the host — intentional per the docstring, but users cloning from a no-dot internal host (git@buildbox:team/repo) will be rejected. If that's a real use case, add an explicit ssh:// form guidance to the warn message.

Nice-to-have (not blocking)

  • Consider logging the normalized clone URL alongside the original in the logStep("Cloning template repository...") path when they differ, so debug sessions can tell shorthand expansion from direct URL pass-through.

LGTM after rebase + version bump. No functional changes requested.

Reviewed by SPA

Adds normalizeRepoUrl() to accept:
- GitHub shorthand (user/repo) — still expanded to https://github.com/...
- HTTP(S) URLs (any host)
- ssh:// and git:// URLs
- SCP-style git@host:path
The clone URL is shellQuote'd before interpolation; values containing
shell metacharacters, whitespace, NUL bytes, or a leading `-` (which
git would parse as a flag) are rejected.
Bumps CLI to 1.0.23.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

@la14-1la14-1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased onto latest main + bumped to 1.0.25 on Ahmed's behalf (maintainerCanModify was enabled). Full review at the earlier comment. CI green.

@la14-1
la14-1 merged commit c907359 into OpenRouterLabs:mainApr 29, 2026
5 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AhmedTMM@la14-1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(cli): --repo accepts any git URL, not just GitHub slugs - #3364

Merged
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:feat/repo-url
Apr 29, 2026
Merged

feat(cli): --repo accepts any git URL, not just GitHub slugs#3364
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:feat/repo-url

Conversation

@AhmedTMM

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #3360. Lifts the GitHub-only restriction on `--repo`. The flag now takes any git URL.

```
spawn --repo user/repo # GitHub shorthand (still works)
spawn --repo https://gitlab.com/team/repo
spawn --repo git@github.com:user/repo.git
spawn --repo ssh://git@example.com/x/y.git
spawn --repo http://gitea.internal/x/y
```

How it works

New `normalizeRepoUrl()` helper in `shared/orchestrate.ts`:

  • GitHub shorthand `user/repo` → `https://github.com/user/repo.git\` (unchanged behavior)
  • HTTP(S) / ssh:// / git:// / git+ssh:// URLs → unchanged
  • SCP-style `git@host:path` (host must contain a dot) → unchanged
  • Anything containing shell metacharacters, whitespace, NUL bytes, or a leading `-` → rejected with a warn (no clone)

The clone URL is also `shellQuote`d at the call site as defense in depth.

Test plan

  • `bunx @biomejs/biome check src/` — 0 errors
  • `bunx tsc --noEmit -p .` — 0 production errors
  • New `repo-url.test.ts` (10 cases): GitHub shorthand expansion, HTTPS / SSH / git:// / SCP pass-through, injection attempts (`;`, backticks, `$()`, `|`, `&&`, quotes), embedded whitespace, NUL bytes, leading `-`, gibberish, oversized inputs, surrounding whitespace trimming.
  • Existing `orchestrate.test.ts` still passes.
  • End-to-end smoke: `--repo` against a non-GitHub host (GitLab / Gitea)

Bumps CLI to 1.0.23.

🤖 Generated with Claude Code

@la14-1

Copy link
Copy Markdown
Collaborator

Review

Solid follow-up to #3360 — the URL matrix handled here is what users actually want.

Looks good

  • normalizeRepoUrl is the right abstraction. Return-null-on-reject + logWarn at the call site gives a clean fail-closed story.
  • SCP-style regex requires a dot in the host, which correctly disambiguates from GitHub shorthand. git@github.com:user/repo still flows through; git@localhost:path is rejected (niche, acceptable).
  • Leading-- rejection prevents the classic --upload-pack=evil git-option-masquerade attack.
  • Length cap at 500 + comprehensive shell-meta rejection + defense-in-depth shellQuote at the call site. Layered right.
  • Test coverage is thorough: GitHub shorthand, HTTPS, SSH, git://, SCP-style, meta-chars (;, backticks, $(), |, &&, quotes), whitespace, NUL, leading -, path traversal, oversized input, whitespace trimming.

Minor

  • mergeStateStatus: BEHIND — needs a rebase. When you do, the CLI version in package.json will also need to bump: feat(cli): posthog feature flags + fast_provision experiment #3366 / the revert are both ahead of you at 1.0.23/1.0.24, so this PR will need to land at 1.0.25.
  • Rejects !, *, ?, # — not strictly dangerous (glob/history, only interactive-shell or git-URL-cosmetic), but harmless to reject. No action needed.
  • SCP regex requires a . in the host — intentional per the docstring, but users cloning from a no-dot internal host (git@buildbox:team/repo) will be rejected. If that's a real use case, add an explicit ssh:// form guidance to the warn message.

Nice-to-have (not blocking)

  • Consider logging the normalized clone URL alongside the original in the logStep("Cloning template repository...") path when they differ, so debug sessions can tell shorthand expansion from direct URL pass-through.

LGTM after rebase + version bump. No functional changes requested.

Reviewed by SPA

Adds normalizeRepoUrl() to accept:
- GitHub shorthand (user/repo) — still expanded to https://github.com/...
- HTTP(S) URLs (any host)
- ssh:// and git:// URLs
- SCP-style git@host:path
The clone URL is shellQuote'd before interpolation; values containing
shell metacharacters, whitespace, NUL bytes, or a leading `-` (which
git would parse as a flag) are rejected.
Bumps CLI to 1.0.23.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

@la14-1la14-1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased onto latest main + bumped to 1.0.25 on Ahmed's behalf (maintainerCanModify was enabled). Full review at the earlier comment. CI green.

@la14-1
la14-1 merged commit c907359 into OpenRouterLabs:mainApr 29, 2026
5 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AhmedTMM@la14-1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(cli): --repo accepts any git URL, not just GitHub slugs - #3364

Merged
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:feat/repo-url
Apr 29, 2026
Merged

feat(cli): --repo accepts any git URL, not just GitHub slugs#3364
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:feat/repo-url

Conversation

@AhmedTMM

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #3360. Lifts the GitHub-only restriction on `--repo`. The flag now takes any git URL.

```
spawn --repo user/repo # GitHub shorthand (still works)
spawn --repo https://gitlab.com/team/repo
spawn --repo git@github.com:user/repo.git
spawn --repo ssh://git@example.com/x/y.git
spawn --repo http://gitea.internal/x/y
```

How it works

New `normalizeRepoUrl()` helper in `shared/orchestrate.ts`:

  • GitHub shorthand `user/repo` → `https://github.com/user/repo.git\` (unchanged behavior)
  • HTTP(S) / ssh:// / git:// / git+ssh:// URLs → unchanged
  • SCP-style `git@host:path` (host must contain a dot) → unchanged
  • Anything containing shell metacharacters, whitespace, NUL bytes, or a leading `-` → rejected with a warn (no clone)

The clone URL is also `shellQuote`d at the call site as defense in depth.

Test plan

  • `bunx @biomejs/biome check src/` — 0 errors
  • `bunx tsc --noEmit -p .` — 0 production errors
  • New `repo-url.test.ts` (10 cases): GitHub shorthand expansion, HTTPS / SSH / git:// / SCP pass-through, injection attempts (`;`, backticks, `$()`, `|`, `&&`, quotes), embedded whitespace, NUL bytes, leading `-`, gibberish, oversized inputs, surrounding whitespace trimming.
  • Existing `orchestrate.test.ts` still passes.
  • End-to-end smoke: `--repo` against a non-GitHub host (GitLab / Gitea)

Bumps CLI to 1.0.23.

🤖 Generated with Claude Code

@la14-1

Copy link
Copy Markdown
Collaborator

Review

Solid follow-up to #3360 — the URL matrix handled here is what users actually want.

Looks good

  • normalizeRepoUrl is the right abstraction. Return-null-on-reject + logWarn at the call site gives a clean fail-closed story.
  • SCP-style regex requires a dot in the host, which correctly disambiguates from GitHub shorthand. git@github.com:user/repo still flows through; git@localhost:path is rejected (niche, acceptable).
  • Leading-- rejection prevents the classic --upload-pack=evil git-option-masquerade attack.
  • Length cap at 500 + comprehensive shell-meta rejection + defense-in-depth shellQuote at the call site. Layered right.
  • Test coverage is thorough: GitHub shorthand, HTTPS, SSH, git://, SCP-style, meta-chars (;, backticks, $(), |, &&, quotes), whitespace, NUL, leading -, path traversal, oversized input, whitespace trimming.

Minor

  • mergeStateStatus: BEHIND — needs a rebase. When you do, the CLI version in package.json will also need to bump: feat(cli): posthog feature flags + fast_provision experiment #3366 / the revert are both ahead of you at 1.0.23/1.0.24, so this PR will need to land at 1.0.25.
  • Rejects !, *, ?, # — not strictly dangerous (glob/history, only interactive-shell or git-URL-cosmetic), but harmless to reject. No action needed.
  • SCP regex requires a . in the host — intentional per the docstring, but users cloning from a no-dot internal host (git@buildbox:team/repo) will be rejected. If that's a real use case, add an explicit ssh:// form guidance to the warn message.

Nice-to-have (not blocking)

  • Consider logging the normalized clone URL alongside the original in the logStep("Cloning template repository...") path when they differ, so debug sessions can tell shorthand expansion from direct URL pass-through.

LGTM after rebase + version bump. No functional changes requested.

Reviewed by SPA

Adds normalizeRepoUrl() to accept:
- GitHub shorthand (user/repo) — still expanded to https://github.com/...
- HTTP(S) URLs (any host)
- ssh:// and git:// URLs
- SCP-style git@host:path
The clone URL is shellQuote'd before interpolation; values containing
shell metacharacters, whitespace, NUL bytes, or a leading `-` (which
git would parse as a flag) are rejected.
Bumps CLI to 1.0.23.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

@la14-1la14-1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased onto latest main + bumped to 1.0.25 on Ahmed's behalf (maintainerCanModify was enabled). Full review at the earlier comment. CI green.

@la14-1
la14-1 merged commit c907359 into OpenRouterLabs:mainApr 29, 2026
5 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AhmedTMM@la14-1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

feat(cli): --repo accepts any git URL, not just GitHub slugs - #3364

Merged
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:feat/repo-url
Apr 29, 2026
Merged

feat(cli): --repo accepts any git URL, not just GitHub slugs#3364
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:feat/repo-url

Conversation

@AhmedTMM

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #3360. Lifts the GitHub-only restriction on `--repo`. The flag now takes any git URL.

```
spawn --repo user/repo # GitHub shorthand (still works)
spawn --repo https://gitlab.com/team/repo
spawn --repo git@github.com:user/repo.git
spawn --repo ssh://git@example.com/x/y.git
spawn --repo http://gitea.internal/x/y
```

How it works

New `normalizeRepoUrl()` helper in `shared/orchestrate.ts`:

  • GitHub shorthand `user/repo` → `https://github.com/user/repo.git\` (unchanged behavior)
  • HTTP(S) / ssh:// / git:// / git+ssh:// URLs → unchanged
  • SCP-style `git@host:path` (host must contain a dot) → unchanged
  • Anything containing shell metacharacters, whitespace, NUL bytes, or a leading `-` → rejected with a warn (no clone)

The clone URL is also `shellQuote`d at the call site as defense in depth.

Test plan

  • `bunx @biomejs/biome check src/` — 0 errors
  • `bunx tsc --noEmit -p .` — 0 production errors
  • New `repo-url.test.ts` (10 cases): GitHub shorthand expansion, HTTPS / SSH / git:// / SCP pass-through, injection attempts (`;`, backticks, `$()`, `|`, `&&`, quotes), embedded whitespace, NUL bytes, leading `-`, gibberish, oversized inputs, surrounding whitespace trimming.
  • Existing `orchestrate.test.ts` still passes.
  • End-to-end smoke: `--repo` against a non-GitHub host (GitLab / Gitea)

Bumps CLI to 1.0.23.

🤖 Generated with Claude Code

@la14-1

Copy link
Copy Markdown
Collaborator

Review

Solid follow-up to #3360 — the URL matrix handled here is what users actually want.

Looks good

  • normalizeRepoUrl is the right abstraction. Return-null-on-reject + logWarn at the call site gives a clean fail-closed story.
  • SCP-style regex requires a dot in the host, which correctly disambiguates from GitHub shorthand. git@github.com:user/repo still flows through; git@localhost:path is rejected (niche, acceptable).
  • Leading-- rejection prevents the classic --upload-pack=evil git-option-masquerade attack.
  • Length cap at 500 + comprehensive shell-meta rejection + defense-in-depth shellQuote at the call site. Layered right.
  • Test coverage is thorough: GitHub shorthand, HTTPS, SSH, git://, SCP-style, meta-chars (;, backticks, $(), |, &&, quotes), whitespace, NUL, leading -, path traversal, oversized input, whitespace trimming.

Minor

  • mergeStateStatus: BEHIND — needs a rebase. When you do, the CLI version in package.json will also need to bump: feat(cli): posthog feature flags + fast_provision experiment #3366 / the revert are both ahead of you at 1.0.23/1.0.24, so this PR will need to land at 1.0.25.
  • Rejects !, *, ?, # — not strictly dangerous (glob/history, only interactive-shell or git-URL-cosmetic), but harmless to reject. No action needed.
  • SCP regex requires a . in the host — intentional per the docstring, but users cloning from a no-dot internal host (git@buildbox:team/repo) will be rejected. If that's a real use case, add an explicit ssh:// form guidance to the warn message.

Nice-to-have (not blocking)

  • Consider logging the normalized clone URL alongside the original in the logStep("Cloning template repository...") path when they differ, so debug sessions can tell shorthand expansion from direct URL pass-through.

LGTM after rebase + version bump. No functional changes requested.

Reviewed by SPA

Adds normalizeRepoUrl() to accept:
- GitHub shorthand (user/repo) — still expanded to https://github.com/...
- HTTP(S) URLs (any host)
- ssh:// and git:// URLs
- SCP-style git@host:path
The clone URL is shellQuote'd before interpolation; values containing
shell metacharacters, whitespace, NUL bytes, or a leading `-` (which
git would parse as a flag) are rejected.
Bumps CLI to 1.0.23.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

@la14-1la14-1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased onto latest main + bumped to 1.0.25 on Ahmed's behalf (maintainerCanModify was enabled). Full review at the earlier comment. CI green.

@la14-1
la14-1 merged commit c907359 into OpenRouterLabs:mainApr 29, 2026
5 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AhmedTMM@la14-1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(cli): --repo accepts any git URL, not just GitHub slugs - #3364

Merged
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:feat/repo-url
Apr 29, 2026
Merged

feat(cli): --repo accepts any git URL, not just GitHub slugs#3364
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:feat/repo-url

Conversation

@AhmedTMM

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #3360. Lifts the GitHub-only restriction on `--repo`. The flag now takes any git URL.

```
spawn --repo user/repo # GitHub shorthand (still works)
spawn --repo https://gitlab.com/team/repo
spawn --repo git@github.com:user/repo.git
spawn --repo ssh://git@example.com/x/y.git
spawn --repo http://gitea.internal/x/y
```

How it works

New `normalizeRepoUrl()` helper in `shared/orchestrate.ts`:

  • GitHub shorthand `user/repo` → `https://github.com/user/repo.git\` (unchanged behavior)
  • HTTP(S) / ssh:// / git:// / git+ssh:// URLs → unchanged
  • SCP-style `git@host:path` (host must contain a dot) → unchanged
  • Anything containing shell metacharacters, whitespace, NUL bytes, or a leading `-` → rejected with a warn (no clone)

The clone URL is also `shellQuote`d at the call site as defense in depth.

Test plan

  • `bunx @biomejs/biome check src/` — 0 errors
  • `bunx tsc --noEmit -p .` — 0 production errors
  • New `repo-url.test.ts` (10 cases): GitHub shorthand expansion, HTTPS / SSH / git:// / SCP pass-through, injection attempts (`;`, backticks, `$()`, `|`, `&&`, quotes), embedded whitespace, NUL bytes, leading `-`, gibberish, oversized inputs, surrounding whitespace trimming.
  • Existing `orchestrate.test.ts` still passes.
  • End-to-end smoke: `--repo` against a non-GitHub host (GitLab / Gitea)

Bumps CLI to 1.0.23.

🤖 Generated with Claude Code

@la14-1

Copy link
Copy Markdown
Collaborator

Review

Solid follow-up to #3360 — the URL matrix handled here is what users actually want.

Looks good

  • normalizeRepoUrl is the right abstraction. Return-null-on-reject + logWarn at the call site gives a clean fail-closed story.
  • SCP-style regex requires a dot in the host, which correctly disambiguates from GitHub shorthand. git@github.com:user/repo still flows through; git@localhost:path is rejected (niche, acceptable).
  • Leading-- rejection prevents the classic --upload-pack=evil git-option-masquerade attack.
  • Length cap at 500 + comprehensive shell-meta rejection + defense-in-depth shellQuote at the call site. Layered right.
  • Test coverage is thorough: GitHub shorthand, HTTPS, SSH, git://, SCP-style, meta-chars (;, backticks, $(), |, &&, quotes), whitespace, NUL, leading -, path traversal, oversized input, whitespace trimming.

Minor

  • mergeStateStatus: BEHIND — needs a rebase. When you do, the CLI version in package.json will also need to bump: feat(cli): posthog feature flags + fast_provision experiment #3366 / the revert are both ahead of you at 1.0.23/1.0.24, so this PR will need to land at 1.0.25.
  • Rejects !, *, ?, # — not strictly dangerous (glob/history, only interactive-shell or git-URL-cosmetic), but harmless to reject. No action needed.
  • SCP regex requires a . in the host — intentional per the docstring, but users cloning from a no-dot internal host (git@buildbox:team/repo) will be rejected. If that's a real use case, add an explicit ssh:// form guidance to the warn message.

Nice-to-have (not blocking)

  • Consider logging the normalized clone URL alongside the original in the logStep("Cloning template repository...") path when they differ, so debug sessions can tell shorthand expansion from direct URL pass-through.

LGTM after rebase + version bump. No functional changes requested.

Reviewed by SPA

Adds normalizeRepoUrl() to accept:
- GitHub shorthand (user/repo) — still expanded to https://github.com/...
- HTTP(S) URLs (any host)
- ssh:// and git:// URLs
- SCP-style git@host:path
The clone URL is shellQuote'd before interpolation; values containing
shell metacharacters, whitespace, NUL bytes, or a leading `-` (which
git would parse as a flag) are rejected.
Bumps CLI to 1.0.23.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

@la14-1la14-1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased onto latest main + bumped to 1.0.25 on Ahmed's behalf (maintainerCanModify was enabled). Full review at the earlier comment. CI green.

@la14-1
la14-1 merged commit c907359 into OpenRouterLabs:mainApr 29, 2026
5 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AhmedTMM@la14-1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(cli): --repo accepts any git URL, not just GitHub slugs - #3364

Merged
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:feat/repo-url
Apr 29, 2026
Merged

feat(cli): --repo accepts any git URL, not just GitHub slugs#3364
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:feat/repo-url

Conversation

@AhmedTMM

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #3360. Lifts the GitHub-only restriction on `--repo`. The flag now takes any git URL.

```
spawn --repo user/repo # GitHub shorthand (still works)
spawn --repo https://gitlab.com/team/repo
spawn --repo git@github.com:user/repo.git
spawn --repo ssh://git@example.com/x/y.git
spawn --repo http://gitea.internal/x/y
```

How it works

New `normalizeRepoUrl()` helper in `shared/orchestrate.ts`:

  • GitHub shorthand `user/repo` → `https://github.com/user/repo.git\` (unchanged behavior)
  • HTTP(S) / ssh:// / git:// / git+ssh:// URLs → unchanged
  • SCP-style `git@host:path` (host must contain a dot) → unchanged
  • Anything containing shell metacharacters, whitespace, NUL bytes, or a leading `-` → rejected with a warn (no clone)

The clone URL is also `shellQuote`d at the call site as defense in depth.

Test plan

  • `bunx @biomejs/biome check src/` — 0 errors
  • `bunx tsc --noEmit -p .` — 0 production errors
  • New `repo-url.test.ts` (10 cases): GitHub shorthand expansion, HTTPS / SSH / git:// / SCP pass-through, injection attempts (`;`, backticks, `$()`, `|`, `&&`, quotes), embedded whitespace, NUL bytes, leading `-`, gibberish, oversized inputs, surrounding whitespace trimming.
  • Existing `orchestrate.test.ts` still passes.
  • End-to-end smoke: `--repo` against a non-GitHub host (GitLab / Gitea)

Bumps CLI to 1.0.23.

🤖 Generated with Claude Code

@la14-1

Copy link
Copy Markdown
Collaborator

Review

Solid follow-up to #3360 — the URL matrix handled here is what users actually want.

Looks good

  • normalizeRepoUrl is the right abstraction. Return-null-on-reject + logWarn at the call site gives a clean fail-closed story.
  • SCP-style regex requires a dot in the host, which correctly disambiguates from GitHub shorthand. git@github.com:user/repo still flows through; git@localhost:path is rejected (niche, acceptable).
  • Leading-- rejection prevents the classic --upload-pack=evil git-option-masquerade attack.
  • Length cap at 500 + comprehensive shell-meta rejection + defense-in-depth shellQuote at the call site. Layered right.
  • Test coverage is thorough: GitHub shorthand, HTTPS, SSH, git://, SCP-style, meta-chars (;, backticks, $(), |, &&, quotes), whitespace, NUL, leading -, path traversal, oversized input, whitespace trimming.

Minor

  • mergeStateStatus: BEHIND — needs a rebase. When you do, the CLI version in package.json will also need to bump: feat(cli): posthog feature flags + fast_provision experiment #3366 / the revert are both ahead of you at 1.0.23/1.0.24, so this PR will need to land at 1.0.25.
  • Rejects !, *, ?, # — not strictly dangerous (glob/history, only interactive-shell or git-URL-cosmetic), but harmless to reject. No action needed.
  • SCP regex requires a . in the host — intentional per the docstring, but users cloning from a no-dot internal host (git@buildbox:team/repo) will be rejected. If that's a real use case, add an explicit ssh:// form guidance to the warn message.

Nice-to-have (not blocking)

  • Consider logging the normalized clone URL alongside the original in the logStep("Cloning template repository...") path when they differ, so debug sessions can tell shorthand expansion from direct URL pass-through.

LGTM after rebase + version bump. No functional changes requested.

Reviewed by SPA

Adds normalizeRepoUrl() to accept:
- GitHub shorthand (user/repo) — still expanded to https://github.com/...
- HTTP(S) URLs (any host)
- ssh:// and git:// URLs
- SCP-style git@host:path
The clone URL is shellQuote'd before interpolation; values containing
shell metacharacters, whitespace, NUL bytes, or a leading `-` (which
git would parse as a flag) are rejected.
Bumps CLI to 1.0.23.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

@la14-1la14-1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased onto latest main + bumped to 1.0.25 on Ahmed's behalf (maintainerCanModify was enabled). Full review at the earlier comment. CI green.

@la14-1
la14-1 merged commit c907359 into OpenRouterLabs:mainApr 29, 2026
5 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AhmedTMM@la14-1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

feat(cli): --repo accepts any git URL, not just GitHub slugs - #3364

Merged
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:feat/repo-url
Apr 29, 2026
Merged

feat(cli): --repo accepts any git URL, not just GitHub slugs#3364
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:feat/repo-url

Conversation

@AhmedTMM

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #3360. Lifts the GitHub-only restriction on `--repo`. The flag now takes any git URL.

```
spawn --repo user/repo # GitHub shorthand (still works)
spawn --repo https://gitlab.com/team/repo
spawn --repo git@github.com:user/repo.git
spawn --repo ssh://git@example.com/x/y.git
spawn --repo http://gitea.internal/x/y
```

How it works

New `normalizeRepoUrl()` helper in `shared/orchestrate.ts`:

  • GitHub shorthand `user/repo` → `https://github.com/user/repo.git\` (unchanged behavior)
  • HTTP(S) / ssh:// / git:// / git+ssh:// URLs → unchanged
  • SCP-style `git@host:path` (host must contain a dot) → unchanged
  • Anything containing shell metacharacters, whitespace, NUL bytes, or a leading `-` → rejected with a warn (no clone)

The clone URL is also `shellQuote`d at the call site as defense in depth.

Test plan

  • `bunx @biomejs/biome check src/` — 0 errors
  • `bunx tsc --noEmit -p .` — 0 production errors
  • New `repo-url.test.ts` (10 cases): GitHub shorthand expansion, HTTPS / SSH / git:// / SCP pass-through, injection attempts (`;`, backticks, `$()`, `|`, `&&`, quotes), embedded whitespace, NUL bytes, leading `-`, gibberish, oversized inputs, surrounding whitespace trimming.
  • Existing `orchestrate.test.ts` still passes.
  • End-to-end smoke: `--repo` against a non-GitHub host (GitLab / Gitea)

Bumps CLI to 1.0.23.

🤖 Generated with Claude Code

@la14-1

Copy link
Copy Markdown
Collaborator

Review

Solid follow-up to #3360 — the URL matrix handled here is what users actually want.

Looks good

  • normalizeRepoUrl is the right abstraction. Return-null-on-reject + logWarn at the call site gives a clean fail-closed story.
  • SCP-style regex requires a dot in the host, which correctly disambiguates from GitHub shorthand. git@github.com:user/repo still flows through; git@localhost:path is rejected (niche, acceptable).
  • Leading-- rejection prevents the classic --upload-pack=evil git-option-masquerade attack.
  • Length cap at 500 + comprehensive shell-meta rejection + defense-in-depth shellQuote at the call site. Layered right.
  • Test coverage is thorough: GitHub shorthand, HTTPS, SSH, git://, SCP-style, meta-chars (;, backticks, $(), |, &&, quotes), whitespace, NUL, leading -, path traversal, oversized input, whitespace trimming.

Minor

  • mergeStateStatus: BEHIND — needs a rebase. When you do, the CLI version in package.json will also need to bump: feat(cli): posthog feature flags + fast_provision experiment #3366 / the revert are both ahead of you at 1.0.23/1.0.24, so this PR will need to land at 1.0.25.
  • Rejects !, *, ?, # — not strictly dangerous (glob/history, only interactive-shell or git-URL-cosmetic), but harmless to reject. No action needed.
  • SCP regex requires a . in the host — intentional per the docstring, but users cloning from a no-dot internal host (git@buildbox:team/repo) will be rejected. If that's a real use case, add an explicit ssh:// form guidance to the warn message.

Nice-to-have (not blocking)

  • Consider logging the normalized clone URL alongside the original in the logStep("Cloning template repository...") path when they differ, so debug sessions can tell shorthand expansion from direct URL pass-through.

LGTM after rebase + version bump. No functional changes requested.

Reviewed by SPA

Adds normalizeRepoUrl() to accept:
- GitHub shorthand (user/repo) — still expanded to https://github.com/...
- HTTP(S) URLs (any host)
- ssh:// and git:// URLs
- SCP-style git@host:path
The clone URL is shellQuote'd before interpolation; values containing
shell metacharacters, whitespace, NUL bytes, or a leading `-` (which
git would parse as a flag) are rejected.
Bumps CLI to 1.0.23.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

@la14-1la14-1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased onto latest main + bumped to 1.0.25 on Ahmed's behalf (maintainerCanModify was enabled). Full review at the earlier comment. CI green.

@la14-1
la14-1 merged commit c907359 into OpenRouterLabs:mainApr 29, 2026
5 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AhmedTMM@la14-1