Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/package.json
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
"name": "@openrouter/spawn",
"version": "1.0.24",
"version": "1.0.25",
"type": "module",
"bin": {
"spawn": "cli.js"
Expand Down
67 changes: 67 additions & 0 deletions packages/cli/src/__tests__/repo-url.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
// Unit tests for normalizeRepoUrl — accepts any sane git URL, rejects
// anything with shell metacharacters or that could be parsed as a git flag.

import { describe, expect, it } from "bun:test";
import { normalizeRepoUrl } from "../shared/orchestrate.js";

describe("normalizeRepoUrl", () => {
it("expands GitHub shorthand to a full HTTPS URL", () => {
expect(normalizeRepoUrl("openrouterteam/spawn")).toBe("https://github.com/openrouterteam/spawn.git");
expect(normalizeRepoUrl("user/my-repo")).toBe("https://github.com/user/my-repo.git");
expect(normalizeRepoUrl("user.name/repo.dot")).toBe("https://github.com/user.name/repo.dot.git");
});

it("passes through HTTPS URLs unchanged", () => {
expect(normalizeRepoUrl("https://github.com/user/repo.git")).toBe("https://github.com/user/repo.git");
expect(normalizeRepoUrl("https://gitlab.com/user/repo")).toBe("https://gitlab.com/user/repo");
expect(normalizeRepoUrl("http://gitea.example.internal/x/y")).toBe("http://gitea.example.internal/x/y");
expect(normalizeRepoUrl("https://bitbucket.org/team/repo.git")).toBe("https://bitbucket.org/team/repo.git");
});

it("passes through SSH URLs", () => {
expect(normalizeRepoUrl("ssh://git@github.com/user/repo.git")).toBe("ssh://git@github.com/user/repo.git");
expect(normalizeRepoUrl("git://github.com/user/repo.git")).toBe("git://github.com/user/repo.git");
});

it("passes through SCP-style SSH (git@host:path)", () => {
expect(normalizeRepoUrl("git@github.com:user/repo.git")).toBe("git@github.com:user/repo.git");
expect(normalizeRepoUrl("deploy@gitlab.example.com:team/repo")).toBe("deploy@gitlab.example.com:team/repo");
});

it("rejects shell metacharacters", () => {
expect(normalizeRepoUrl("user/repo; rm -rf /")).toBeNull();
expect(normalizeRepoUrl("user/repo`whoami`")).toBeNull();
expect(normalizeRepoUrl("$(curl evil)")).toBeNull();
expect(normalizeRepoUrl("user/repo|cat")).toBeNull();
expect(normalizeRepoUrl("user/repo && evil")).toBeNull();
expect(normalizeRepoUrl('user/"repo"')).toBeNull();
});

it("rejects embedded whitespace and NUL bytes", () => {
expect(normalizeRepoUrl("user / repo")).toBeNull();
expect(normalizeRepoUrl("user/re po")).toBeNull();
expect(normalizeRepoUrl("user\nrepo")).toBeNull();
expect(normalizeRepoUrl("user/repo\0")).toBeNull();
});

it("rejects leading `-` (git option masquerade)", () => {
expect(normalizeRepoUrl("--upload-pack=evil")).toBeNull();
expect(normalizeRepoUrl("-bad/repo")).toBeNull();
});

it("rejects gibberish that's neither a URL nor a slug", () => {
expect(normalizeRepoUrl("just-a-name")).toBeNull();
expect(normalizeRepoUrl("")).toBeNull();
expect(normalizeRepoUrl(" ")).toBeNull();
expect(normalizeRepoUrl("/etc/passwd")).toBeNull();
expect(normalizeRepoUrl("../../etc/passwd")).toBeNull();
});

it("rejects absurdly long inputs", () => {
expect(normalizeRepoUrl(`https://github.com/${"x".repeat(600)}/y`)).toBeNull();
});

it("trims surrounding whitespace before validating", () => {
expect(normalizeRepoUrl(" user/repo ")).toBe("https://github.com/user/repo.git");
});
});
2 changes: 1 addition & 1 deletion packages/cli/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -147,7 +147,7 @@ function checkUnknownFlags(args: string[]): void {
console.error(` ${pc.cyan("--reauth")} Force re-prompting for cloud credentials`);
console.error(` ${pc.cyan("--config <path>")} Load config from JSON file`);
console.error(` ${pc.cyan("--steps <list>")} Comma-separated setup steps to enable`);
console.error(` ${pc.cyan("--repo <user/repo>")} Clone a template repo and apply spawn.md`);
console.error(` ${pc.cyan("--repo <slug|url>")} Clone a template repo and apply spawn.md`);
console.error(` ${pc.cyan("--beta tarball")} Use pre-built tarball for agent install (repeatable)`);
console.error(` ${pc.cyan("--beta images")} Use pre-built DO marketplace images (faster boot)`);
console.error(` ${pc.cyan("--beta parallel")} Parallelize server boot with setup prompts`);
Expand Down
57 changes: 50 additions & 7 deletions packages/cli/src/shared/orchestrate.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,49 @@ function trackFunnel(step: string, extra: Record<string, unknown> = {}): void {
});
}

/**
* Normalize a `--repo` argument into a git clone URL.
*
* Accepts:
* - GitHub shorthand: user/repo → https://github.com/user/repo.git
* - HTTP(S) URL: https://host/path[.git] → unchanged
* - SSH URL: ssh://user@host/path → unchanged
* - SCP-style SSH: git@host:path → unchanged
* - git:// URL: git://host/path → unchanged
*
* Returns null for anything that contains shell metacharacters, whitespace,
* leading `-` (would be parsed as a git option), or doesn't look like a URL
* or `user/repo` slug at all. Defense in depth — the URL is always passed
* through `shellQuote` at the call site as well.
*/
export function normalizeRepoUrl(input: string): string | null {
const trimmed = input.trim();
if (trimmed.length === 0 || trimmed.length > 500) {
return null;
}
// No shell metacharacters, no whitespace, no NUL bytes
if (/[\s\0`$;&|<>(){}[\]"'\\!*?#]/.test(trimmed)) {
return null;
}
// Reject leading `-` so the URL can't masquerade as a git flag
if (trimmed.startsWith("-")) {
return null;
}
// Full URL with scheme
if (/^(https?|git|ssh|git\+ssh|git\+https?):\/\//i.test(trimmed)) {
return trimmed;
}
// SCP-style: user@host:path (host must contain a dot to disambiguate from GitHub shorthand)
if (/^[a-zA-Z0-9_.-]+@[a-zA-Z0-9.-]+\.[a-zA-Z0-9.-]+:[a-zA-Z0-9._/~-]+(\.git)?$/.test(trimmed)) {
return trimmed;
}
// GitHub shorthand: user/repo
if (/^[a-zA-Z0-9_.-]+\/[a-zA-Z0-9_.-]+$/.test(trimmed)) {
return `https://github.com/${trimmed}.git`;
}
return null;
}

/** Docker container name used by --beta docker deployments. */
export const DOCKER_CONTAINER_NAME = "spawn-agent";
/** Docker registry hosting spawn agent images. */
Expand DownExpand Up@@ -623,15 +666,15 @@ async function postInstall(
// MCP servers, setup commands).
let spawnMdConfig: import("./spawn-md.js").SpawnMdConfig | null = null;
let repoCloned = false;
const repoSlug = process.env.SPAWN_REPO;
if (repoSlug && cloud.cloudName !== "local") {
// Validate slug format (user/repo, no path traversal)
if (!/^[a-zA-Z0-9_.-]+\/[a-zA-Z0-9_.-]+$/.test(repoSlug)) {
logWarn(`Invalid repo slug: ${repoSlug} — skipping repo clone`);
const repoArg = process.env.SPAWN_REPO;
if (repoArg && cloud.cloudName !== "local") {
const cloneUrl = normalizeRepoUrl(repoArg);
if (!cloneUrl) {
logWarn(`Invalid --repo value: ${repoArg} — skipping repo clone`);
} else {
logStep("Cloning template repository...");
const cloneResult = await asyncTryCatch(() =>
cloud.runner.runServer(`git clone https://github.com/${repoSlug}.git ~/project`),
cloud.runner.runServer(`git clone ${shellQuote(cloneUrl)} ~/project`),
);
if (!cloneResult.ok) {
logWarn(`Repo clone failed (${getErrorMessage(cloneResult.error)}) — continuing without template`);
Expand All@@ -640,7 +683,7 @@ async function postInstall(
const { readRemoteSpawnMd } = await import("./spawn-md.js");
spawnMdConfig = await readRemoteSpawnMd(cloud.runner);
if (spawnMdConfig) {
logInfo(`Template loaded: ${spawnMdConfig.name ?? repoSlug}`);
logInfo(`Template loaded: ${spawnMdConfig.name ?? repoArg}`);
}
}
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/package.json
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
"name": "@openrouter/spawn",
"version": "1.0.24",
"version": "1.0.25",
"type": "module",
"bin": {
"spawn": "cli.js"
Expand Down
67 changes: 67 additions & 0 deletions packages/cli/src/__tests__/repo-url.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
// Unit tests for normalizeRepoUrl — accepts any sane git URL, rejects
// anything with shell metacharacters or that could be parsed as a git flag.

import { describe, expect, it } from "bun:test";
import { normalizeRepoUrl } from "../shared/orchestrate.js";

describe("normalizeRepoUrl", () => {
it("expands GitHub shorthand to a full HTTPS URL", () => {
expect(normalizeRepoUrl("openrouterteam/spawn")).toBe("https://github.com/openrouterteam/spawn.git");
expect(normalizeRepoUrl("user/my-repo")).toBe("https://github.com/user/my-repo.git");
expect(normalizeRepoUrl("user.name/repo.dot")).toBe("https://github.com/user.name/repo.dot.git");
});

it("passes through HTTPS URLs unchanged", () => {
expect(normalizeRepoUrl("https://github.com/user/repo.git")).toBe("https://github.com/user/repo.git");
expect(normalizeRepoUrl("https://gitlab.com/user/repo")).toBe("https://gitlab.com/user/repo");
expect(normalizeRepoUrl("http://gitea.example.internal/x/y")).toBe("http://gitea.example.internal/x/y");
expect(normalizeRepoUrl("https://bitbucket.org/team/repo.git")).toBe("https://bitbucket.org/team/repo.git");
});

it("passes through SSH URLs", () => {
expect(normalizeRepoUrl("ssh://git@github.com/user/repo.git")).toBe("ssh://git@github.com/user/repo.git");
expect(normalizeRepoUrl("git://github.com/user/repo.git")).toBe("git://github.com/user/repo.git");
});

it("passes through SCP-style SSH (git@host:path)", () => {
expect(normalizeRepoUrl("git@github.com:user/repo.git")).toBe("git@github.com:user/repo.git");
expect(normalizeRepoUrl("deploy@gitlab.example.com:team/repo")).toBe("deploy@gitlab.example.com:team/repo");
});

it("rejects shell metacharacters", () => {
expect(normalizeRepoUrl("user/repo; rm -rf /")).toBeNull();
expect(normalizeRepoUrl("user/repo`whoami`")).toBeNull();
expect(normalizeRepoUrl("$(curl evil)")).toBeNull();
expect(normalizeRepoUrl("user/repo|cat")).toBeNull();
expect(normalizeRepoUrl("user/repo && evil")).toBeNull();
expect(normalizeRepoUrl('user/"repo"')).toBeNull();
});

it("rejects embedded whitespace and NUL bytes", () => {
expect(normalizeRepoUrl("user / repo")).toBeNull();
expect(normalizeRepoUrl("user/re po")).toBeNull();
expect(normalizeRepoUrl("user\nrepo")).toBeNull();
expect(normalizeRepoUrl("user/repo\0")).toBeNull();
});

it("rejects leading `-` (git option masquerade)", () => {
expect(normalizeRepoUrl("--upload-pack=evil")).toBeNull();
expect(normalizeRepoUrl("-bad/repo")).toBeNull();
});

it("rejects gibberish that's neither a URL nor a slug", () => {
expect(normalizeRepoUrl("just-a-name")).toBeNull();
expect(normalizeRepoUrl("")).toBeNull();
expect(normalizeRepoUrl(" ")).toBeNull();
expect(normalizeRepoUrl("/etc/passwd")).toBeNull();
expect(normalizeRepoUrl("../../etc/passwd")).toBeNull();
});

it("rejects absurdly long inputs", () => {
expect(normalizeRepoUrl(`https://github.com/${"x".repeat(600)}/y`)).toBeNull();
});

it("trims surrounding whitespace before validating", () => {
expect(normalizeRepoUrl(" user/repo ")).toBe("https://github.com/user/repo.git");
});
});
2 changes: 1 addition & 1 deletion packages/cli/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -147,7 +147,7 @@ function checkUnknownFlags(args: string[]): void {
console.error(` ${pc.cyan("--reauth")} Force re-prompting for cloud credentials`);
console.error(` ${pc.cyan("--config <path>")} Load config from JSON file`);
console.error(` ${pc.cyan("--steps <list>")} Comma-separated setup steps to enable`);
console.error(` ${pc.cyan("--repo <user/repo>")} Clone a template repo and apply spawn.md`);
console.error(` ${pc.cyan("--repo <slug|url>")} Clone a template repo and apply spawn.md`);
console.error(` ${pc.cyan("--beta tarball")} Use pre-built tarball for agent install (repeatable)`);
console.error(` ${pc.cyan("--beta images")} Use pre-built DO marketplace images (faster boot)`);
console.error(` ${pc.cyan("--beta parallel")} Parallelize server boot with setup prompts`);
Expand Down
57 changes: 50 additions & 7 deletions packages/cli/src/shared/orchestrate.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,49 @@ function trackFunnel(step: string, extra: Record<string, unknown> = {}): void {
});
}

/**
* Normalize a `--repo` argument into a git clone URL.
*
* Accepts:
* - GitHub shorthand: user/repo → https://github.com/user/repo.git
* - HTTP(S) URL: https://host/path[.git] → unchanged
* - SSH URL: ssh://user@host/path → unchanged
* - SCP-style SSH: git@host:path → unchanged
* - git:// URL: git://host/path → unchanged
*
* Returns null for anything that contains shell metacharacters, whitespace,
* leading `-` (would be parsed as a git option), or doesn't look like a URL
* or `user/repo` slug at all. Defense in depth — the URL is always passed
* through `shellQuote` at the call site as well.
*/
export function normalizeRepoUrl(input: string): string | null {
const trimmed = input.trim();
if (trimmed.length === 0 || trimmed.length > 500) {
return null;
}
// No shell metacharacters, no whitespace, no NUL bytes
if (/[\s\0`$;&|<>(){}[\]"'\\!*?#]/.test(trimmed)) {
return null;
}
// Reject leading `-` so the URL can't masquerade as a git flag
if (trimmed.startsWith("-")) {
return null;
}
// Full URL with scheme
if (/^(https?|git|ssh|git\+ssh|git\+https?):\/\//i.test(trimmed)) {
return trimmed;
}
// SCP-style: user@host:path (host must contain a dot to disambiguate from GitHub shorthand)
if (/^[a-zA-Z0-9_.-]+@[a-zA-Z0-9.-]+\.[a-zA-Z0-9.-]+:[a-zA-Z0-9._/~-]+(\.git)?$/.test(trimmed)) {
return trimmed;
}
// GitHub shorthand: user/repo
if (/^[a-zA-Z0-9_.-]+\/[a-zA-Z0-9_.-]+$/.test(trimmed)) {
return `https://github.com/${trimmed}.git`;
}
return null;
}

/** Docker container name used by --beta docker deployments. */
export const DOCKER_CONTAINER_NAME = "spawn-agent";
/** Docker registry hosting spawn agent images. */
Expand DownExpand Up@@ -623,15 +666,15 @@ async function postInstall(
// MCP servers, setup commands).
let spawnMdConfig: import("./spawn-md.js").SpawnMdConfig | null = null;
let repoCloned = false;
const repoSlug = process.env.SPAWN_REPO;
if (repoSlug && cloud.cloudName !== "local") {
// Validate slug format (user/repo, no path traversal)
if (!/^[a-zA-Z0-9_.-]+\/[a-zA-Z0-9_.-]+$/.test(repoSlug)) {
logWarn(`Invalid repo slug: ${repoSlug} — skipping repo clone`);
const repoArg = process.env.SPAWN_REPO;
if (repoArg && cloud.cloudName !== "local") {
const cloneUrl = normalizeRepoUrl(repoArg);
if (!cloneUrl) {
logWarn(`Invalid --repo value: ${repoArg} — skipping repo clone`);
} else {
logStep("Cloning template repository...");
const cloneResult = await asyncTryCatch(() =>
cloud.runner.runServer(`git clone https://github.com/${repoSlug}.git ~/project`),
cloud.runner.runServer(`git clone ${shellQuote(cloneUrl)} ~/project`),
);
if (!cloneResult.ok) {
logWarn(`Repo clone failed (${getErrorMessage(cloneResult.error)}) — continuing without template`);
Expand All@@ -640,7 +683,7 @@ async function postInstall(
const { readRemoteSpawnMd } = await import("./spawn-md.js");
spawnMdConfig = await readRemoteSpawnMd(cloud.runner);
if (spawnMdConfig) {
logInfo(`Template loaded: ${spawnMdConfig.name ?? repoSlug}`);
logInfo(`Template loaded: ${spawnMdConfig.name ?? repoArg}`);
}
}
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/package.json
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
"name": "@openrouter/spawn",
"version": "1.0.24",
"version": "1.0.25",
"type": "module",
"bin": {
"spawn": "cli.js"
Expand Down
67 changes: 67 additions & 0 deletions packages/cli/src/__tests__/repo-url.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
// Unit tests for normalizeRepoUrl — accepts any sane git URL, rejects
// anything with shell metacharacters or that could be parsed as a git flag.

import { describe, expect, it } from "bun:test";
import { normalizeRepoUrl } from "../shared/orchestrate.js";

describe("normalizeRepoUrl", () => {
it("expands GitHub shorthand to a full HTTPS URL", () => {
expect(normalizeRepoUrl("openrouterteam/spawn")).toBe("https://github.com/openrouterteam/spawn.git");
expect(normalizeRepoUrl("user/my-repo")).toBe("https://github.com/user/my-repo.git");
expect(normalizeRepoUrl("user.name/repo.dot")).toBe("https://github.com/user.name/repo.dot.git");
});

it("passes through HTTPS URLs unchanged", () => {
expect(normalizeRepoUrl("https://github.com/user/repo.git")).toBe("https://github.com/user/repo.git");
expect(normalizeRepoUrl("https://gitlab.com/user/repo")).toBe("https://gitlab.com/user/repo");
expect(normalizeRepoUrl("http://gitea.example.internal/x/y")).toBe("http://gitea.example.internal/x/y");
expect(normalizeRepoUrl("https://bitbucket.org/team/repo.git")).toBe("https://bitbucket.org/team/repo.git");
});

it("passes through SSH URLs", () => {
expect(normalizeRepoUrl("ssh://git@github.com/user/repo.git")).toBe("ssh://git@github.com/user/repo.git");
expect(normalizeRepoUrl("git://github.com/user/repo.git")).toBe("git://github.com/user/repo.git");
});

it("passes through SCP-style SSH (git@host:path)", () => {
expect(normalizeRepoUrl("git@github.com:user/repo.git")).toBe("git@github.com:user/repo.git");
expect(normalizeRepoUrl("deploy@gitlab.example.com:team/repo")).toBe("deploy@gitlab.example.com:team/repo");
});

it("rejects shell metacharacters", () => {
expect(normalizeRepoUrl("user/repo; rm -rf /")).toBeNull();
expect(normalizeRepoUrl("user/repo`whoami`")).toBeNull();
expect(normalizeRepoUrl("$(curl evil)")).toBeNull();
expect(normalizeRepoUrl("user/repo|cat")).toBeNull();
expect(normalizeRepoUrl("user/repo && evil")).toBeNull();
expect(normalizeRepoUrl('user/"repo"')).toBeNull();
});

it("rejects embedded whitespace and NUL bytes", () => {
expect(normalizeRepoUrl("user / repo")).toBeNull();
expect(normalizeRepoUrl("user/re po")).toBeNull();
expect(normalizeRepoUrl("user\nrepo")).toBeNull();
expect(normalizeRepoUrl("user/repo\0")).toBeNull();
});

it("rejects leading `-` (git option masquerade)", () => {
expect(normalizeRepoUrl("--upload-pack=evil")).toBeNull();
expect(normalizeRepoUrl("-bad/repo")).toBeNull();
});

it("rejects gibberish that's neither a URL nor a slug", () => {
expect(normalizeRepoUrl("just-a-name")).toBeNull();
expect(normalizeRepoUrl("")).toBeNull();
expect(normalizeRepoUrl(" ")).toBeNull();
expect(normalizeRepoUrl("/etc/passwd")).toBeNull();
expect(normalizeRepoUrl("../../etc/passwd")).toBeNull();
});

it("rejects absurdly long inputs", () => {
expect(normalizeRepoUrl(`https://github.com/${"x".repeat(600)}/y`)).toBeNull();
});

it("trims surrounding whitespace before validating", () => {
expect(normalizeRepoUrl(" user/repo ")).toBe("https://github.com/user/repo.git");
});
});
2 changes: 1 addition & 1 deletion packages/cli/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -147,7 +147,7 @@ function checkUnknownFlags(args: string[]): void {
console.error(` ${pc.cyan("--reauth")} Force re-prompting for cloud credentials`);
console.error(` ${pc.cyan("--config <path>")} Load config from JSON file`);
console.error(` ${pc.cyan("--steps <list>")} Comma-separated setup steps to enable`);
console.error(` ${pc.cyan("--repo <user/repo>")} Clone a template repo and apply spawn.md`);
console.error(` ${pc.cyan("--repo <slug|url>")} Clone a template repo and apply spawn.md`);
console.error(` ${pc.cyan("--beta tarball")} Use pre-built tarball for agent install (repeatable)`);
console.error(` ${pc.cyan("--beta images")} Use pre-built DO marketplace images (faster boot)`);
console.error(` ${pc.cyan("--beta parallel")} Parallelize server boot with setup prompts`);
Expand Down
57 changes: 50 additions & 7 deletions packages/cli/src/shared/orchestrate.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,49 @@ function trackFunnel(step: string, extra: Record<string, unknown> = {}): void {
});
}

/**
* Normalize a `--repo` argument into a git clone URL.
*
* Accepts:
* - GitHub shorthand: user/repo → https://github.com/user/repo.git
* - HTTP(S) URL: https://host/path[.git] → unchanged
* - SSH URL: ssh://user@host/path → unchanged
* - SCP-style SSH: git@host:path → unchanged
* - git:// URL: git://host/path → unchanged
*
* Returns null for anything that contains shell metacharacters, whitespace,
* leading `-` (would be parsed as a git option), or doesn't look like a URL
* or `user/repo` slug at all. Defense in depth — the URL is always passed
* through `shellQuote` at the call site as well.
*/
export function normalizeRepoUrl(input: string): string | null {
const trimmed = input.trim();
if (trimmed.length === 0 || trimmed.length > 500) {
return null;
}
// No shell metacharacters, no whitespace, no NUL bytes
if (/[\s\0`$;&|<>(){}[\]"'\\!*?#]/.test(trimmed)) {
return null;
}
// Reject leading `-` so the URL can't masquerade as a git flag
if (trimmed.startsWith("-")) {
return null;
}
// Full URL with scheme
if (/^(https?|git|ssh|git\+ssh|git\+https?):\/\//i.test(trimmed)) {
return trimmed;
}
// SCP-style: user@host:path (host must contain a dot to disambiguate from GitHub shorthand)
if (/^[a-zA-Z0-9_.-]+@[a-zA-Z0-9.-]+\.[a-zA-Z0-9.-]+:[a-zA-Z0-9._/~-]+(\.git)?$/.test(trimmed)) {
return trimmed;
}
// GitHub shorthand: user/repo
if (/^[a-zA-Z0-9_.-]+\/[a-zA-Z0-9_.-]+$/.test(trimmed)) {
return `https://github.com/${trimmed}.git`;
}
return null;
}

/** Docker container name used by --beta docker deployments. */
export const DOCKER_CONTAINER_NAME = "spawn-agent";
/** Docker registry hosting spawn agent images. */
Expand DownExpand Up@@ -623,15 +666,15 @@ async function postInstall(
// MCP servers, setup commands).
let spawnMdConfig: import("./spawn-md.js").SpawnMdConfig | null = null;
let repoCloned = false;
const repoSlug = process.env.SPAWN_REPO;
if (repoSlug && cloud.cloudName !== "local") {
// Validate slug format (user/repo, no path traversal)
if (!/^[a-zA-Z0-9_.-]+\/[a-zA-Z0-9_.-]+$/.test(repoSlug)) {
logWarn(`Invalid repo slug: ${repoSlug} — skipping repo clone`);
const repoArg = process.env.SPAWN_REPO;
if (repoArg && cloud.cloudName !== "local") {
const cloneUrl = normalizeRepoUrl(repoArg);
if (!cloneUrl) {
logWarn(`Invalid --repo value: ${repoArg} — skipping repo clone`);
} else {
logStep("Cloning template repository...");
const cloneResult = await asyncTryCatch(() =>
cloud.runner.runServer(`git clone https://github.com/${repoSlug}.git ~/project`),
cloud.runner.runServer(`git clone ${shellQuote(cloneUrl)} ~/project`),
);
if (!cloneResult.ok) {
logWarn(`Repo clone failed (${getErrorMessage(cloneResult.error)}) — continuing without template`);
Expand All@@ -640,7 +683,7 @@ async function postInstall(
const { readRemoteSpawnMd } = await import("./spawn-md.js");
spawnMdConfig = await readRemoteSpawnMd(cloud.runner);
if (spawnMdConfig) {
logInfo(`Template loaded: ${spawnMdConfig.name ?? repoSlug}`);
logInfo(`Template loaded: ${spawnMdConfig.name ?? repoArg}`);
}
}
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/package.json
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
"name": "@openrouter/spawn",
"version": "1.0.24",
"version": "1.0.25",
"type": "module",
"bin": {
"spawn": "cli.js"
Expand Down
67 changes: 67 additions & 0 deletions packages/cli/src/__tests__/repo-url.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
// Unit tests for normalizeRepoUrl — accepts any sane git URL, rejects
// anything with shell metacharacters or that could be parsed as a git flag.

import { describe, expect, it } from "bun:test";
import { normalizeRepoUrl } from "../shared/orchestrate.js";

describe("normalizeRepoUrl", () => {
it("expands GitHub shorthand to a full HTTPS URL", () => {
expect(normalizeRepoUrl("openrouterteam/spawn")).toBe("https://github.com/openrouterteam/spawn.git");
expect(normalizeRepoUrl("user/my-repo")).toBe("https://github.com/user/my-repo.git");
expect(normalizeRepoUrl("user.name/repo.dot")).toBe("https://github.com/user.name/repo.dot.git");
});

it("passes through HTTPS URLs unchanged", () => {
expect(normalizeRepoUrl("https://github.com/user/repo.git")).toBe("https://github.com/user/repo.git");
expect(normalizeRepoUrl("https://gitlab.com/user/repo")).toBe("https://gitlab.com/user/repo");
expect(normalizeRepoUrl("http://gitea.example.internal/x/y")).toBe("http://gitea.example.internal/x/y");
expect(normalizeRepoUrl("https://bitbucket.org/team/repo.git")).toBe("https://bitbucket.org/team/repo.git");
});

it("passes through SSH URLs", () => {
expect(normalizeRepoUrl("ssh://git@github.com/user/repo.git")).toBe("ssh://git@github.com/user/repo.git");
expect(normalizeRepoUrl("git://github.com/user/repo.git")).toBe("git://github.com/user/repo.git");
});

it("passes through SCP-style SSH (git@host:path)", () => {
expect(normalizeRepoUrl("git@github.com:user/repo.git")).toBe("git@github.com:user/repo.git");
expect(normalizeRepoUrl("deploy@gitlab.example.com:team/repo")).toBe("deploy@gitlab.example.com:team/repo");
});

it("rejects shell metacharacters", () => {
expect(normalizeRepoUrl("user/repo; rm -rf /")).toBeNull();
expect(normalizeRepoUrl("user/repo`whoami`")).toBeNull();
expect(normalizeRepoUrl("$(curl evil)")).toBeNull();
expect(normalizeRepoUrl("user/repo|cat")).toBeNull();
expect(normalizeRepoUrl("user/repo && evil")).toBeNull();
expect(normalizeRepoUrl('user/"repo"')).toBeNull();
});

it("rejects embedded whitespace and NUL bytes", () => {
expect(normalizeRepoUrl("user / repo")).toBeNull();
expect(normalizeRepoUrl("user/re po")).toBeNull();
expect(normalizeRepoUrl("user\nrepo")).toBeNull();
expect(normalizeRepoUrl("user/repo\0")).toBeNull();
});

it("rejects leading `-` (git option masquerade)", () => {
expect(normalizeRepoUrl("--upload-pack=evil")).toBeNull();
expect(normalizeRepoUrl("-bad/repo")).toBeNull();
});

it("rejects gibberish that's neither a URL nor a slug", () => {
expect(normalizeRepoUrl("just-a-name")).toBeNull();
expect(normalizeRepoUrl("")).toBeNull();
expect(normalizeRepoUrl(" ")).toBeNull();
expect(normalizeRepoUrl("/etc/passwd")).toBeNull();
expect(normalizeRepoUrl("../../etc/passwd")).toBeNull();
});

it("rejects absurdly long inputs", () => {
expect(normalizeRepoUrl(`https://github.com/${"x".repeat(600)}/y`)).toBeNull();
});

it("trims surrounding whitespace before validating", () => {
expect(normalizeRepoUrl(" user/repo ")).toBe("https://github.com/user/repo.git");
});
});
2 changes: 1 addition & 1 deletion packages/cli/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -147,7 +147,7 @@ function checkUnknownFlags(args: string[]): void {
console.error(` ${pc.cyan("--reauth")} Force re-prompting for cloud credentials`);
console.error(` ${pc.cyan("--config <path>")} Load config from JSON file`);
console.error(` ${pc.cyan("--steps <list>")} Comma-separated setup steps to enable`);
console.error(` ${pc.cyan("--repo <user/repo>")} Clone a template repo and apply spawn.md`);
console.error(` ${pc.cyan("--repo <slug|url>")} Clone a template repo and apply spawn.md`);
console.error(` ${pc.cyan("--beta tarball")} Use pre-built tarball for agent install (repeatable)`);
console.error(` ${pc.cyan("--beta images")} Use pre-built DO marketplace images (faster boot)`);
console.error(` ${pc.cyan("--beta parallel")} Parallelize server boot with setup prompts`);
Expand Down
57 changes: 50 additions & 7 deletions packages/cli/src/shared/orchestrate.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,49 @@ function trackFunnel(step: string, extra: Record<string, unknown> = {}): void {
});
}

/**
* Normalize a `--repo` argument into a git clone URL.
*
* Accepts:
* - GitHub shorthand: user/repo → https://github.com/user/repo.git
* - HTTP(S) URL: https://host/path[.git] → unchanged
* - SSH URL: ssh://user@host/path → unchanged
* - SCP-style SSH: git@host:path → unchanged
* - git:// URL: git://host/path → unchanged
*
* Returns null for anything that contains shell metacharacters, whitespace,
* leading `-` (would be parsed as a git option), or doesn't look like a URL
* or `user/repo` slug at all. Defense in depth — the URL is always passed
* through `shellQuote` at the call site as well.
*/
export function normalizeRepoUrl(input: string): string | null {
const trimmed = input.trim();
if (trimmed.length === 0 || trimmed.length > 500) {
return null;
}
// No shell metacharacters, no whitespace, no NUL bytes
if (/[\s\0`$;&|<>(){}[\]"'\\!*?#]/.test(trimmed)) {
return null;
}
// Reject leading `-` so the URL can't masquerade as a git flag
if (trimmed.startsWith("-")) {
return null;
}
// Full URL with scheme
if (/^(https?|git|ssh|git\+ssh|git\+https?):\/\//i.test(trimmed)) {
return trimmed;
}
// SCP-style: user@host:path (host must contain a dot to disambiguate from GitHub shorthand)
if (/^[a-zA-Z0-9_.-]+@[a-zA-Z0-9.-]+\.[a-zA-Z0-9.-]+:[a-zA-Z0-9._/~-]+(\.git)?$/.test(trimmed)) {
return trimmed;
}
// GitHub shorthand: user/repo
if (/^[a-zA-Z0-9_.-]+\/[a-zA-Z0-9_.-]+$/.test(trimmed)) {
return `https://github.com/${trimmed}.git`;
}
return null;
}

/** Docker container name used by --beta docker deployments. */
export const DOCKER_CONTAINER_NAME = "spawn-agent";
/** Docker registry hosting spawn agent images. */
Expand DownExpand Up@@ -623,15 +666,15 @@ async function postInstall(
// MCP servers, setup commands).
let spawnMdConfig: import("./spawn-md.js").SpawnMdConfig | null = null;
let repoCloned = false;
const repoSlug = process.env.SPAWN_REPO;
if (repoSlug && cloud.cloudName !== "local") {
// Validate slug format (user/repo, no path traversal)
if (!/^[a-zA-Z0-9_.-]+\/[a-zA-Z0-9_.-]+$/.test(repoSlug)) {
logWarn(`Invalid repo slug: ${repoSlug} — skipping repo clone`);
const repoArg = process.env.SPAWN_REPO;
if (repoArg && cloud.cloudName !== "local") {
const cloneUrl = normalizeRepoUrl(repoArg);
if (!cloneUrl) {
logWarn(`Invalid --repo value: ${repoArg} — skipping repo clone`);
} else {
logStep("Cloning template repository...");
const cloneResult = await asyncTryCatch(() =>
cloud.runner.runServer(`git clone https://github.com/${repoSlug}.git ~/project`),
cloud.runner.runServer(`git clone ${shellQuote(cloneUrl)} ~/project`),
);
if (!cloneResult.ok) {
logWarn(`Repo clone failed (${getErrorMessage(cloneResult.error)}) — continuing without template`);
Expand All@@ -640,7 +683,7 @@ async function postInstall(
const { readRemoteSpawnMd } = await import("./spawn-md.js");
spawnMdConfig = await readRemoteSpawnMd(cloud.runner);
if (spawnMdConfig) {
logInfo(`Template loaded: ${spawnMdConfig.name ?? repoSlug}`);
logInfo(`Template loaded: ${spawnMdConfig.name ?? repoArg}`);
}
}
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/package.json
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
"name": "@openrouter/spawn",
"version": "1.0.24",
"version": "1.0.25",
"type": "module",
"bin": {
"spawn": "cli.js"
Expand Down
67 changes: 67 additions & 0 deletions packages/cli/src/__tests__/repo-url.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
// Unit tests for normalizeRepoUrl — accepts any sane git URL, rejects
// anything with shell metacharacters or that could be parsed as a git flag.

import { describe, expect, it } from "bun:test";
import { normalizeRepoUrl } from "../shared/orchestrate.js";

describe("normalizeRepoUrl", () => {
it("expands GitHub shorthand to a full HTTPS URL", () => {
expect(normalizeRepoUrl("openrouterteam/spawn")).toBe("https://github.com/openrouterteam/spawn.git");
expect(normalizeRepoUrl("user/my-repo")).toBe("https://github.com/user/my-repo.git");
expect(normalizeRepoUrl("user.name/repo.dot")).toBe("https://github.com/user.name/repo.dot.git");
});

it("passes through HTTPS URLs unchanged", () => {
expect(normalizeRepoUrl("https://github.com/user/repo.git")).toBe("https://github.com/user/repo.git");
expect(normalizeRepoUrl("https://gitlab.com/user/repo")).toBe("https://gitlab.com/user/repo");
expect(normalizeRepoUrl("http://gitea.example.internal/x/y")).toBe("http://gitea.example.internal/x/y");
expect(normalizeRepoUrl("https://bitbucket.org/team/repo.git")).toBe("https://bitbucket.org/team/repo.git");
});

it("passes through SSH URLs", () => {
expect(normalizeRepoUrl("ssh://git@github.com/user/repo.git")).toBe("ssh://git@github.com/user/repo.git");
expect(normalizeRepoUrl("git://github.com/user/repo.git")).toBe("git://github.com/user/repo.git");
});

it("passes through SCP-style SSH (git@host:path)", () => {
expect(normalizeRepoUrl("git@github.com:user/repo.git")).toBe("git@github.com:user/repo.git");
expect(normalizeRepoUrl("deploy@gitlab.example.com:team/repo")).toBe("deploy@gitlab.example.com:team/repo");
});

it("rejects shell metacharacters", () => {
expect(normalizeRepoUrl("user/repo; rm -rf /")).toBeNull();
expect(normalizeRepoUrl("user/repo`whoami`")).toBeNull();
expect(normalizeRepoUrl("$(curl evil)")).toBeNull();
expect(normalizeRepoUrl("user/repo|cat")).toBeNull();
expect(normalizeRepoUrl("user/repo && evil")).toBeNull();
expect(normalizeRepoUrl('user/"repo"')).toBeNull();
});

it("rejects embedded whitespace and NUL bytes", () => {
expect(normalizeRepoUrl("user / repo")).toBeNull();
expect(normalizeRepoUrl("user/re po")).toBeNull();
expect(normalizeRepoUrl("user\nrepo")).toBeNull();
expect(normalizeRepoUrl("user/repo\0")).toBeNull();
});

it("rejects leading `-` (git option masquerade)", () => {
expect(normalizeRepoUrl("--upload-pack=evil")).toBeNull();
expect(normalizeRepoUrl("-bad/repo")).toBeNull();
});

it("rejects gibberish that's neither a URL nor a slug", () => {
expect(normalizeRepoUrl("just-a-name")).toBeNull();
expect(normalizeRepoUrl("")).toBeNull();
expect(normalizeRepoUrl(" ")).toBeNull();
expect(normalizeRepoUrl("/etc/passwd")).toBeNull();
expect(normalizeRepoUrl("../../etc/passwd")).toBeNull();
});

it("rejects absurdly long inputs", () => {
expect(normalizeRepoUrl(`https://github.com/${"x".repeat(600)}/y`)).toBeNull();
});

it("trims surrounding whitespace before validating", () => {
expect(normalizeRepoUrl(" user/repo ")).toBe("https://github.com/user/repo.git");
});
});
2 changes: 1 addition & 1 deletion packages/cli/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -147,7 +147,7 @@ function checkUnknownFlags(args: string[]): void {
console.error(` ${pc.cyan("--reauth")} Force re-prompting for cloud credentials`);
console.error(` ${pc.cyan("--config <path>")} Load config from JSON file`);
console.error(` ${pc.cyan("--steps <list>")} Comma-separated setup steps to enable`);
console.error(` ${pc.cyan("--repo <user/repo>")} Clone a template repo and apply spawn.md`);
console.error(` ${pc.cyan("--repo <slug|url>")} Clone a template repo and apply spawn.md`);
console.error(` ${pc.cyan("--beta tarball")} Use pre-built tarball for agent install (repeatable)`);
console.error(` ${pc.cyan("--beta images")} Use pre-built DO marketplace images (faster boot)`);
console.error(` ${pc.cyan("--beta parallel")} Parallelize server boot with setup prompts`);
Expand Down
57 changes: 50 additions & 7 deletions packages/cli/src/shared/orchestrate.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,49 @@ function trackFunnel(step: string, extra: Record<string, unknown> = {}): void {
});
}

/**
* Normalize a `--repo` argument into a git clone URL.
*
* Accepts:
* - GitHub shorthand: user/repo → https://github.com/user/repo.git
* - HTTP(S) URL: https://host/path[.git] → unchanged
* - SSH URL: ssh://user@host/path → unchanged
* - SCP-style SSH: git@host:path → unchanged
* - git:// URL: git://host/path → unchanged
*
* Returns null for anything that contains shell metacharacters, whitespace,
* leading `-` (would be parsed as a git option), or doesn't look like a URL
* or `user/repo` slug at all. Defense in depth — the URL is always passed
* through `shellQuote` at the call site as well.
*/
export function normalizeRepoUrl(input: string): string | null {
const trimmed = input.trim();
if (trimmed.length === 0 || trimmed.length > 500) {
return null;
}
// No shell metacharacters, no whitespace, no NUL bytes
if (/[\s\0`$;&|<>(){}[\]"'\\!*?#]/.test(trimmed)) {
return null;
}
// Reject leading `-` so the URL can't masquerade as a git flag
if (trimmed.startsWith("-")) {
return null;
}
// Full URL with scheme
if (/^(https?|git|ssh|git\+ssh|git\+https?):\/\//i.test(trimmed)) {
return trimmed;
}
// SCP-style: user@host:path (host must contain a dot to disambiguate from GitHub shorthand)
if (/^[a-zA-Z0-9_.-]+@[a-zA-Z0-9.-]+\.[a-zA-Z0-9.-]+:[a-zA-Z0-9._/~-]+(\.git)?$/.test(trimmed)) {
return trimmed;
}
// GitHub shorthand: user/repo
if (/^[a-zA-Z0-9_.-]+\/[a-zA-Z0-9_.-]+$/.test(trimmed)) {
return `https://github.com/${trimmed}.git`;
}
return null;
}

/** Docker container name used by --beta docker deployments. */
export const DOCKER_CONTAINER_NAME = "spawn-agent";
/** Docker registry hosting spawn agent images. */
Expand DownExpand Up@@ -623,15 +666,15 @@ async function postInstall(
// MCP servers, setup commands).
let spawnMdConfig: import("./spawn-md.js").SpawnMdConfig | null = null;
let repoCloned = false;
const repoSlug = process.env.SPAWN_REPO;
if (repoSlug && cloud.cloudName !== "local") {
// Validate slug format (user/repo, no path traversal)
if (!/^[a-zA-Z0-9_.-]+\/[a-zA-Z0-9_.-]+$/.test(repoSlug)) {
logWarn(`Invalid repo slug: ${repoSlug} — skipping repo clone`);
const repoArg = process.env.SPAWN_REPO;
if (repoArg && cloud.cloudName !== "local") {
const cloneUrl = normalizeRepoUrl(repoArg);
if (!cloneUrl) {
logWarn(`Invalid --repo value: ${repoArg} — skipping repo clone`);
} else {
logStep("Cloning template repository...");
const cloneResult = await asyncTryCatch(() =>
cloud.runner.runServer(`git clone https://github.com/${repoSlug}.git ~/project`),
cloud.runner.runServer(`git clone ${shellQuote(cloneUrl)} ~/project`),
);
if (!cloneResult.ok) {
logWarn(`Repo clone failed (${getErrorMessage(cloneResult.error)}) — continuing without template`);
Expand All@@ -640,7 +683,7 @@ async function postInstall(
const { readRemoteSpawnMd } = await import("./spawn-md.js");
spawnMdConfig = await readRemoteSpawnMd(cloud.runner);
if (spawnMdConfig) {
logInfo(`Template loaded: ${spawnMdConfig.name ?? repoSlug}`);
logInfo(`Template loaded: ${spawnMdConfig.name ?? repoArg}`);
}
}
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/package.json
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
"name": "@openrouter/spawn",
"version": "1.0.24",
"version": "1.0.25",
"type": "module",
"bin": {
"spawn": "cli.js"
Expand Down
67 changes: 67 additions & 0 deletions packages/cli/src/__tests__/repo-url.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
// Unit tests for normalizeRepoUrl — accepts any sane git URL, rejects
// anything with shell metacharacters or that could be parsed as a git flag.

import { describe, expect, it } from "bun:test";
import { normalizeRepoUrl } from "../shared/orchestrate.js";

describe("normalizeRepoUrl", () => {
it("expands GitHub shorthand to a full HTTPS URL", () => {
expect(normalizeRepoUrl("openrouterteam/spawn")).toBe("https://github.com/openrouterteam/spawn.git");
expect(normalizeRepoUrl("user/my-repo")).toBe("https://github.com/user/my-repo.git");
expect(normalizeRepoUrl("user.name/repo.dot")).toBe("https://github.com/user.name/repo.dot.git");
});

it("passes through HTTPS URLs unchanged", () => {
expect(normalizeRepoUrl("https://github.com/user/repo.git")).toBe("https://github.com/user/repo.git");
expect(normalizeRepoUrl("https://gitlab.com/user/repo")).toBe("https://gitlab.com/user/repo");
expect(normalizeRepoUrl("http://gitea.example.internal/x/y")).toBe("http://gitea.example.internal/x/y");
expect(normalizeRepoUrl("https://bitbucket.org/team/repo.git")).toBe("https://bitbucket.org/team/repo.git");
});

it("passes through SSH URLs", () => {
expect(normalizeRepoUrl("ssh://git@github.com/user/repo.git")).toBe("ssh://git@github.com/user/repo.git");
expect(normalizeRepoUrl("git://github.com/user/repo.git")).toBe("git://github.com/user/repo.git");
});

it("passes through SCP-style SSH (git@host:path)", () => {
expect(normalizeRepoUrl("git@github.com:user/repo.git")).toBe("git@github.com:user/repo.git");
expect(normalizeRepoUrl("deploy@gitlab.example.com:team/repo")).toBe("deploy@gitlab.example.com:team/repo");
});

it("rejects shell metacharacters", () => {
expect(normalizeRepoUrl("user/repo; rm -rf /")).toBeNull();
expect(normalizeRepoUrl("user/repo`whoami`")).toBeNull();
expect(normalizeRepoUrl("$(curl evil)")).toBeNull();
expect(normalizeRepoUrl("user/repo|cat")).toBeNull();
expect(normalizeRepoUrl("user/repo && evil")).toBeNull();
expect(normalizeRepoUrl('user/"repo"')).toBeNull();
});

it("rejects embedded whitespace and NUL bytes", () => {
expect(normalizeRepoUrl("user / repo")).toBeNull();
expect(normalizeRepoUrl("user/re po")).toBeNull();
expect(normalizeRepoUrl("user\nrepo")).toBeNull();
expect(normalizeRepoUrl("user/repo\0")).toBeNull();
});

it("rejects leading `-` (git option masquerade)", () => {
expect(normalizeRepoUrl("--upload-pack=evil")).toBeNull();
expect(normalizeRepoUrl("-bad/repo")).toBeNull();
});

it("rejects gibberish that's neither a URL nor a slug", () => {
expect(normalizeRepoUrl("just-a-name")).toBeNull();
expect(normalizeRepoUrl("")).toBeNull();
expect(normalizeRepoUrl(" ")).toBeNull();
expect(normalizeRepoUrl("/etc/passwd")).toBeNull();
expect(normalizeRepoUrl("../../etc/passwd")).toBeNull();
});

it("rejects absurdly long inputs", () => {
expect(normalizeRepoUrl(`https://github.com/${"x".repeat(600)}/y`)).toBeNull();
});

it("trims surrounding whitespace before validating", () => {
expect(normalizeRepoUrl(" user/repo ")).toBe("https://github.com/user/repo.git");
});
});
2 changes: 1 addition & 1 deletion packages/cli/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -147,7 +147,7 @@ function checkUnknownFlags(args: string[]): void {
console.error(` ${pc.cyan("--reauth")} Force re-prompting for cloud credentials`);
console.error(` ${pc.cyan("--config <path>")} Load config from JSON file`);
console.error(` ${pc.cyan("--steps <list>")} Comma-separated setup steps to enable`);
console.error(` ${pc.cyan("--repo <user/repo>")} Clone a template repo and apply spawn.md`);
console.error(` ${pc.cyan("--repo <slug|url>")} Clone a template repo and apply spawn.md`);
console.error(` ${pc.cyan("--beta tarball")} Use pre-built tarball for agent install (repeatable)`);
console.error(` ${pc.cyan("--beta images")} Use pre-built DO marketplace images (faster boot)`);
console.error(` ${pc.cyan("--beta parallel")} Parallelize server boot with setup prompts`);
Expand Down
57 changes: 50 additions & 7 deletions packages/cli/src/shared/orchestrate.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,49 @@ function trackFunnel(step: string, extra: Record<string, unknown> = {}): void {
});
}

/**
* Normalize a `--repo` argument into a git clone URL.
*
* Accepts:
* - GitHub shorthand: user/repo → https://github.com/user/repo.git
* - HTTP(S) URL: https://host/path[.git] → unchanged
* - SSH URL: ssh://user@host/path → unchanged
* - SCP-style SSH: git@host:path → unchanged
* - git:// URL: git://host/path → unchanged
*
* Returns null for anything that contains shell metacharacters, whitespace,
* leading `-` (would be parsed as a git option), or doesn't look like a URL
* or `user/repo` slug at all. Defense in depth — the URL is always passed
* through `shellQuote` at the call site as well.
*/
export function normalizeRepoUrl(input: string): string | null {
const trimmed = input.trim();
if (trimmed.length === 0 || trimmed.length > 500) {
return null;
}
// No shell metacharacters, no whitespace, no NUL bytes
if (/[\s\0`$;&|<>(){}[\]"'\\!*?#]/.test(trimmed)) {
return null;
}
// Reject leading `-` so the URL can't masquerade as a git flag
if (trimmed.startsWith("-")) {
return null;
}
// Full URL with scheme
if (/^(https?|git|ssh|git\+ssh|git\+https?):\/\//i.test(trimmed)) {
return trimmed;
}
// SCP-style: user@host:path (host must contain a dot to disambiguate from GitHub shorthand)
if (/^[a-zA-Z0-9_.-]+@[a-zA-Z0-9.-]+\.[a-zA-Z0-9.-]+:[a-zA-Z0-9._/~-]+(\.git)?$/.test(trimmed)) {
return trimmed;
}
// GitHub shorthand: user/repo
if (/^[a-zA-Z0-9_.-]+\/[a-zA-Z0-9_.-]+$/.test(trimmed)) {
return `https://github.com/${trimmed}.git`;
}
return null;
}

/** Docker container name used by --beta docker deployments. */
export const DOCKER_CONTAINER_NAME = "spawn-agent";
/** Docker registry hosting spawn agent images. */
Expand DownExpand Up@@ -623,15 +666,15 @@ async function postInstall(
// MCP servers, setup commands).
let spawnMdConfig: import("./spawn-md.js").SpawnMdConfig | null = null;
let repoCloned = false;
const repoSlug = process.env.SPAWN_REPO;
if (repoSlug && cloud.cloudName !== "local") {
// Validate slug format (user/repo, no path traversal)
if (!/^[a-zA-Z0-9_.-]+\/[a-zA-Z0-9_.-]+$/.test(repoSlug)) {
logWarn(`Invalid repo slug: ${repoSlug} — skipping repo clone`);
const repoArg = process.env.SPAWN_REPO;
if (repoArg && cloud.cloudName !== "local") {
const cloneUrl = normalizeRepoUrl(repoArg);
if (!cloneUrl) {
logWarn(`Invalid --repo value: ${repoArg} — skipping repo clone`);
} else {
logStep("Cloning template repository...");
const cloneResult = await asyncTryCatch(() =>
cloud.runner.runServer(`git clone https://github.com/${repoSlug}.git ~/project`),
cloud.runner.runServer(`git clone ${shellQuote(cloneUrl)} ~/project`),
);
if (!cloneResult.ok) {
logWarn(`Repo clone failed (${getErrorMessage(cloneResult.error)}) — continuing without template`);
Expand All@@ -640,7 +683,7 @@ async function postInstall(
const { readRemoteSpawnMd } = await import("./spawn-md.js");
spawnMdConfig = await readRemoteSpawnMd(cloud.runner);
if (spawnMdConfig) {
logInfo(`Template loaded: ${spawnMdConfig.name ?? repoSlug}`);
logInfo(`Template loaded: ${spawnMdConfig.name ?? repoArg}`);
}
}
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/package.json
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
"name": "@openrouter/spawn",
"version": "1.0.24",
"version": "1.0.25",
"type": "module",
"bin": {
"spawn": "cli.js"
Expand Down
67 changes: 67 additions & 0 deletions packages/cli/src/__tests__/repo-url.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
// Unit tests for normalizeRepoUrl — accepts any sane git URL, rejects
// anything with shell metacharacters or that could be parsed as a git flag.

import { describe, expect, it } from "bun:test";
import { normalizeRepoUrl } from "../shared/orchestrate.js";

describe("normalizeRepoUrl", () => {
it("expands GitHub shorthand to a full HTTPS URL", () => {
expect(normalizeRepoUrl("openrouterteam/spawn")).toBe("https://github.com/openrouterteam/spawn.git");
expect(normalizeRepoUrl("user/my-repo")).toBe("https://github.com/user/my-repo.git");
expect(normalizeRepoUrl("user.name/repo.dot")).toBe("https://github.com/user.name/repo.dot.git");
});

it("passes through HTTPS URLs unchanged", () => {
expect(normalizeRepoUrl("https://github.com/user/repo.git")).toBe("https://github.com/user/repo.git");
expect(normalizeRepoUrl("https://gitlab.com/user/repo")).toBe("https://gitlab.com/user/repo");
expect(normalizeRepoUrl("http://gitea.example.internal/x/y")).toBe("http://gitea.example.internal/x/y");
expect(normalizeRepoUrl("https://bitbucket.org/team/repo.git")).toBe("https://bitbucket.org/team/repo.git");
});

it("passes through SSH URLs", () => {
expect(normalizeRepoUrl("ssh://git@github.com/user/repo.git")).toBe("ssh://git@github.com/user/repo.git");
expect(normalizeRepoUrl("git://github.com/user/repo.git")).toBe("git://github.com/user/repo.git");
});

it("passes through SCP-style SSH (git@host:path)", () => {
expect(normalizeRepoUrl("git@github.com:user/repo.git")).toBe("git@github.com:user/repo.git");
expect(normalizeRepoUrl("deploy@gitlab.example.com:team/repo")).toBe("deploy@gitlab.example.com:team/repo");
});

it("rejects shell metacharacters", () => {
expect(normalizeRepoUrl("user/repo; rm -rf /")).toBeNull();
expect(normalizeRepoUrl("user/repo`whoami`")).toBeNull();
expect(normalizeRepoUrl("$(curl evil)")).toBeNull();
expect(normalizeRepoUrl("user/repo|cat")).toBeNull();
expect(normalizeRepoUrl("user/repo && evil")).toBeNull();
expect(normalizeRepoUrl('user/"repo"')).toBeNull();
});

it("rejects embedded whitespace and NUL bytes", () => {
expect(normalizeRepoUrl("user / repo")).toBeNull();
expect(normalizeRepoUrl("user/re po")).toBeNull();
expect(normalizeRepoUrl("user\nrepo")).toBeNull();
expect(normalizeRepoUrl("user/repo\0")).toBeNull();
});

it("rejects leading `-` (git option masquerade)", () => {
expect(normalizeRepoUrl("--upload-pack=evil")).toBeNull();
expect(normalizeRepoUrl("-bad/repo")).toBeNull();
});

it("rejects gibberish that's neither a URL nor a slug", () => {
expect(normalizeRepoUrl("just-a-name")).toBeNull();
expect(normalizeRepoUrl("")).toBeNull();
expect(normalizeRepoUrl(" ")).toBeNull();
expect(normalizeRepoUrl("/etc/passwd")).toBeNull();
expect(normalizeRepoUrl("../../etc/passwd")).toBeNull();
});

it("rejects absurdly long inputs", () => {
expect(normalizeRepoUrl(`https://github.com/${"x".repeat(600)}/y`)).toBeNull();
});

it("trims surrounding whitespace before validating", () => {
expect(normalizeRepoUrl(" user/repo ")).toBe("https://github.com/user/repo.git");
});
});
2 changes: 1 addition & 1 deletion packages/cli/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -147,7 +147,7 @@ function checkUnknownFlags(args: string[]): void {
console.error(` ${pc.cyan("--reauth")} Force re-prompting for cloud credentials`);
console.error(` ${pc.cyan("--config <path>")} Load config from JSON file`);
console.error(` ${pc.cyan("--steps <list>")} Comma-separated setup steps to enable`);
console.error(` ${pc.cyan("--repo <user/repo>")} Clone a template repo and apply spawn.md`);
console.error(` ${pc.cyan("--repo <slug|url>")} Clone a template repo and apply spawn.md`);
console.error(` ${pc.cyan("--beta tarball")} Use pre-built tarball for agent install (repeatable)`);
console.error(` ${pc.cyan("--beta images")} Use pre-built DO marketplace images (faster boot)`);
console.error(` ${pc.cyan("--beta parallel")} Parallelize server boot with setup prompts`);
Expand Down
57 changes: 50 additions & 7 deletions packages/cli/src/shared/orchestrate.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,49 @@ function trackFunnel(step: string, extra: Record<string, unknown> = {}): void {
});
}

/**
* Normalize a `--repo` argument into a git clone URL.
*
* Accepts:
* - GitHub shorthand: user/repo → https://github.com/user/repo.git
* - HTTP(S) URL: https://host/path[.git] → unchanged
* - SSH URL: ssh://user@host/path → unchanged
* - SCP-style SSH: git@host:path → unchanged
* - git:// URL: git://host/path → unchanged
*
* Returns null for anything that contains shell metacharacters, whitespace,
* leading `-` (would be parsed as a git option), or doesn't look like a URL
* or `user/repo` slug at all. Defense in depth — the URL is always passed
* through `shellQuote` at the call site as well.
*/
export function normalizeRepoUrl(input: string): string | null {
const trimmed = input.trim();
if (trimmed.length === 0 || trimmed.length > 500) {
return null;
}
// No shell metacharacters, no whitespace, no NUL bytes
if (/[\s\0`$;&|<>(){}[\]"'\\!*?#]/.test(trimmed)) {
return null;
}
// Reject leading `-` so the URL can't masquerade as a git flag
if (trimmed.startsWith("-")) {
return null;
}
// Full URL with scheme
if (/^(https?|git|ssh|git\+ssh|git\+https?):\/\//i.test(trimmed)) {
return trimmed;
}
// SCP-style: user@host:path (host must contain a dot to disambiguate from GitHub shorthand)
if (/^[a-zA-Z0-9_.-]+@[a-zA-Z0-9.-]+\.[a-zA-Z0-9.-]+:[a-zA-Z0-9._/~-]+(\.git)?$/.test(trimmed)) {
return trimmed;
}
// GitHub shorthand: user/repo
if (/^[a-zA-Z0-9_.-]+\/[a-zA-Z0-9_.-]+$/.test(trimmed)) {
return `https://github.com/${trimmed}.git`;
}
return null;
}

/** Docker container name used by --beta docker deployments. */
export const DOCKER_CONTAINER_NAME = "spawn-agent";
/** Docker registry hosting spawn agent images. */
Expand DownExpand Up@@ -623,15 +666,15 @@ async function postInstall(
// MCP servers, setup commands).
let spawnMdConfig: import("./spawn-md.js").SpawnMdConfig | null = null;
let repoCloned = false;
const repoSlug = process.env.SPAWN_REPO;
if (repoSlug && cloud.cloudName !== "local") {
// Validate slug format (user/repo, no path traversal)
if (!/^[a-zA-Z0-9_.-]+\/[a-zA-Z0-9_.-]+$/.test(repoSlug)) {
logWarn(`Invalid repo slug: ${repoSlug} — skipping repo clone`);
const repoArg = process.env.SPAWN_REPO;
if (repoArg && cloud.cloudName !== "local") {
const cloneUrl = normalizeRepoUrl(repoArg);
if (!cloneUrl) {
logWarn(`Invalid --repo value: ${repoArg} — skipping repo clone`);
} else {
logStep("Cloning template repository...");
const cloneResult = await asyncTryCatch(() =>
cloud.runner.runServer(`git clone https://github.com/${repoSlug}.git ~/project`),
cloud.runner.runServer(`git clone ${shellQuote(cloneUrl)} ~/project`),
);
if (!cloneResult.ok) {
logWarn(`Repo clone failed (${getErrorMessage(cloneResult.error)}) — continuing without template`);
Expand All@@ -640,7 +683,7 @@ async function postInstall(
const { readRemoteSpawnMd } = await import("./spawn-md.js");
spawnMdConfig = await readRemoteSpawnMd(cloud.runner);
if (spawnMdConfig) {
logInfo(`Template loaded: ${spawnMdConfig.name ?? repoSlug}`);
logInfo(`Template loaded: ${spawnMdConfig.name ?? repoArg}`);
}
}
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/package.json
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
"name": "@openrouter/spawn",
"version": "1.0.24",
"version": "1.0.25",
"type": "module",
"bin": {
"spawn": "cli.js"
Expand Down
67 changes: 67 additions & 0 deletions packages/cli/src/__tests__/repo-url.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
// Unit tests for normalizeRepoUrl — accepts any sane git URL, rejects
// anything with shell metacharacters or that could be parsed as a git flag.

import { describe, expect, it } from "bun:test";
import { normalizeRepoUrl } from "../shared/orchestrate.js";

describe("normalizeRepoUrl", () => {
it("expands GitHub shorthand to a full HTTPS URL", () => {
expect(normalizeRepoUrl("openrouterteam/spawn")).toBe("https://github.com/openrouterteam/spawn.git");
expect(normalizeRepoUrl("user/my-repo")).toBe("https://github.com/user/my-repo.git");
expect(normalizeRepoUrl("user.name/repo.dot")).toBe("https://github.com/user.name/repo.dot.git");
});

it("passes through HTTPS URLs unchanged", () => {
expect(normalizeRepoUrl("https://github.com/user/repo.git")).toBe("https://github.com/user/repo.git");
expect(normalizeRepoUrl("https://gitlab.com/user/repo")).toBe("https://gitlab.com/user/repo");
expect(normalizeRepoUrl("http://gitea.example.internal/x/y")).toBe("http://gitea.example.internal/x/y");
expect(normalizeRepoUrl("https://bitbucket.org/team/repo.git")).toBe("https://bitbucket.org/team/repo.git");
});

it("passes through SSH URLs", () => {
expect(normalizeRepoUrl("ssh://git@github.com/user/repo.git")).toBe("ssh://git@github.com/user/repo.git");
expect(normalizeRepoUrl("git://github.com/user/repo.git")).toBe("git://github.com/user/repo.git");
});

it("passes through SCP-style SSH (git@host:path)", () => {
expect(normalizeRepoUrl("git@github.com:user/repo.git")).toBe("git@github.com:user/repo.git");
expect(normalizeRepoUrl("deploy@gitlab.example.com:team/repo")).toBe("deploy@gitlab.example.com:team/repo");
});

it("rejects shell metacharacters", () => {
expect(normalizeRepoUrl("user/repo; rm -rf /")).toBeNull();
expect(normalizeRepoUrl("user/repo`whoami`")).toBeNull();
expect(normalizeRepoUrl("$(curl evil)")).toBeNull();
expect(normalizeRepoUrl("user/repo|cat")).toBeNull();
expect(normalizeRepoUrl("user/repo && evil")).toBeNull();
expect(normalizeRepoUrl('user/"repo"')).toBeNull();
});

it("rejects embedded whitespace and NUL bytes", () => {
expect(normalizeRepoUrl("user / repo")).toBeNull();
expect(normalizeRepoUrl("user/re po")).toBeNull();
expect(normalizeRepoUrl("user\nrepo")).toBeNull();
expect(normalizeRepoUrl("user/repo\0")).toBeNull();
});

it("rejects leading `-` (git option masquerade)", () => {
expect(normalizeRepoUrl("--upload-pack=evil")).toBeNull();
expect(normalizeRepoUrl("-bad/repo")).toBeNull();
});

it("rejects gibberish that's neither a URL nor a slug", () => {
expect(normalizeRepoUrl("just-a-name")).toBeNull();
expect(normalizeRepoUrl("")).toBeNull();
expect(normalizeRepoUrl(" ")).toBeNull();
expect(normalizeRepoUrl("/etc/passwd")).toBeNull();
expect(normalizeRepoUrl("../../etc/passwd")).toBeNull();
});

it("rejects absurdly long inputs", () => {
expect(normalizeRepoUrl(`https://github.com/${"x".repeat(600)}/y`)).toBeNull();
});

it("trims surrounding whitespace before validating", () => {
expect(normalizeRepoUrl(" user/repo ")).toBe("https://github.com/user/repo.git");
});
});
2 changes: 1 addition & 1 deletion packages/cli/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -147,7 +147,7 @@ function checkUnknownFlags(args: string[]): void {
console.error(` ${pc.cyan("--reauth")} Force re-prompting for cloud credentials`);
console.error(` ${pc.cyan("--config <path>")} Load config from JSON file`);
console.error(` ${pc.cyan("--steps <list>")} Comma-separated setup steps to enable`);
console.error(` ${pc.cyan("--repo <user/repo>")} Clone a template repo and apply spawn.md`);
console.error(` ${pc.cyan("--repo <slug|url>")} Clone a template repo and apply spawn.md`);
console.error(` ${pc.cyan("--beta tarball")} Use pre-built tarball for agent install (repeatable)`);
console.error(` ${pc.cyan("--beta images")} Use pre-built DO marketplace images (faster boot)`);
console.error(` ${pc.cyan("--beta parallel")} Parallelize server boot with setup prompts`);
Expand Down
57 changes: 50 additions & 7 deletions packages/cli/src/shared/orchestrate.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,49 @@ function trackFunnel(step: string, extra: Record<string, unknown> = {}): void {
});
}

/**
* Normalize a `--repo` argument into a git clone URL.
*
* Accepts:
* - GitHub shorthand: user/repo → https://github.com/user/repo.git
* - HTTP(S) URL: https://host/path[.git] → unchanged
* - SSH URL: ssh://user@host/path → unchanged
* - SCP-style SSH: git@host:path → unchanged
* - git:// URL: git://host/path → unchanged
*
* Returns null for anything that contains shell metacharacters, whitespace,
* leading `-` (would be parsed as a git option), or doesn't look like a URL
* or `user/repo` slug at all. Defense in depth — the URL is always passed
* through `shellQuote` at the call site as well.
*/
export function normalizeRepoUrl(input: string): string | null {
const trimmed = input.trim();
if (trimmed.length === 0 || trimmed.length > 500) {
return null;
}
// No shell metacharacters, no whitespace, no NUL bytes
if (/[\s\0`$;&|<>(){}[\]"'\\!*?#]/.test(trimmed)) {
return null;
}
// Reject leading `-` so the URL can't masquerade as a git flag
if (trimmed.startsWith("-")) {
return null;
}
// Full URL with scheme
if (/^(https?|git|ssh|git\+ssh|git\+https?):\/\//i.test(trimmed)) {
return trimmed;
}
// SCP-style: user@host:path (host must contain a dot to disambiguate from GitHub shorthand)
if (/^[a-zA-Z0-9_.-]+@[a-zA-Z0-9.-]+\.[a-zA-Z0-9.-]+:[a-zA-Z0-9._/~-]+(\.git)?$/.test(trimmed)) {
return trimmed;
}
// GitHub shorthand: user/repo
if (/^[a-zA-Z0-9_.-]+\/[a-zA-Z0-9_.-]+$/.test(trimmed)) {
return `https://github.com/${trimmed}.git`;
}
return null;
}

/** Docker container name used by --beta docker deployments. */
export const DOCKER_CONTAINER_NAME = "spawn-agent";
/** Docker registry hosting spawn agent images. */
Expand DownExpand Up@@ -623,15 +666,15 @@ async function postInstall(
// MCP servers, setup commands).
let spawnMdConfig: import("./spawn-md.js").SpawnMdConfig | null = null;
let repoCloned = false;
const repoSlug = process.env.SPAWN_REPO;
if (repoSlug && cloud.cloudName !== "local") {
// Validate slug format (user/repo, no path traversal)
if (!/^[a-zA-Z0-9_.-]+\/[a-zA-Z0-9_.-]+$/.test(repoSlug)) {
logWarn(`Invalid repo slug: ${repoSlug} — skipping repo clone`);
const repoArg = process.env.SPAWN_REPO;
if (repoArg && cloud.cloudName !== "local") {
const cloneUrl = normalizeRepoUrl(repoArg);
if (!cloneUrl) {
logWarn(`Invalid --repo value: ${repoArg} — skipping repo clone`);
} else {
logStep("Cloning template repository...");
const cloneResult = await asyncTryCatch(() =>
cloud.runner.runServer(`git clone https://github.com/${repoSlug}.git ~/project`),
cloud.runner.runServer(`git clone ${shellQuote(cloneUrl)} ~/project`),
);
if (!cloneResult.ok) {
logWarn(`Repo clone failed (${getErrorMessage(cloneResult.error)}) — continuing without template`);
Expand All@@ -640,7 +683,7 @@ async function postInstall(
const { readRemoteSpawnMd } = await import("./spawn-md.js");
spawnMdConfig = await readRemoteSpawnMd(cloud.runner);
if (spawnMdConfig) {
logInfo(`Template loaded: ${spawnMdConfig.name ?? repoSlug}`);
logInfo(`Template loaded: ${spawnMdConfig.name ?? repoArg}`);
}
}
}
Expand Down
Loading