Uh oh!
There was an error while loading. Please reload this page.
fix: use log_step for progress messages in netcup scripts - #441
Merged
Conversation
All netcup agent scripts were using log_warn (yellow) for routine progress messages like "Installing...", "Setting up...", "Starting...". These should use log_step (cyan) which was added specifically for progress/status messages, reserving log_warn for actual warnings. Agent: ux-engineer Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
log_warn(yellow) withlog_step(cyan) for progress messages in all 9 netcup agent scripts andnetcup/lib/common.shlog_warnfor actual warnings: invalid user choices, fallback defaults, destructive operations (destroying VPS)log_warntolog_info(it's informational, not a warning)Context
PR #440 added
log_step(cyan) for progress/status messages to distinguish them fromlog_warn(yellow) which should be reserved for actual warnings. The netcup scripts were added after that convention was established but used the oldlog_warnpattern.Test plan
.shfiles passbash -nsyntax checkbun test)