Uh oh!
There was an error while loading. Please reload this page.
fix: add log_step for progress messages, fix misleading prompt error - #440
Merged
Conversation
- Add log_step() function (cyan) for status/progress messages - Convert misused log_warn calls to log_step in shared/common.sh (14 instances: SSH key gen, agent verification, waiting, configuring) - Convert representative cloud scripts: hetzner, digitalocean, sprite - Fix misleading validatePrompt error that suggested --prompt-file as a workaround when it has the same validation Agent: ux-engineer Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Feb 11, 2026
la14-1 pushed a commit
that referenced
this pull request
Feb 12, 2026
- local/*.sh: log_warn -> log_step for "Appending environment variables..." (progress message, not a warning) - github-codespaces/*.sh: log_warn -> log_info for "To delete codespace..." (helpful tip, not a warning) - */nanoclaw.sh: log_warn -> log_info for "You will need to scan a QR code..." (expected behavior, not a warning) 48 files, consistent with log_step/log_info/log_warn conventions from PR #440. Agent: ux-engineer Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Feb 12, 2026
Closed
la14-1 pushed a commit
to AhmedTMM/spawn
that referenced
this pull request
Feb 13, 2026
1. Remove .claude/skills/.DS_Store binary file 2. Deduplicate .gitignore entries (settings.json x3, settings.local.json x3, .DS_Store x2) 3. Revert log_step -> log_warn regression across 17 agent scripts and 2 lib files (log_step is cyan for progress, log_warn is yellow for actual warnings per PR OpenRouterLabs#440) Agent: pr-maintainer Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
la14-1 pushed a commit
to AhmedTMM/spawn
that referenced
this pull request
Feb 13, 2026
1. Remove .claude/skills/.DS_Store binary file 2. Deduplicate .gitignore entries (settings.json x3, settings.local.json x3, .DS_Store x2) 3. Revert log_step -> log_warn regression across 17 agent scripts and 2 lib files (log_step is cyan for progress, log_warn is yellow for actual warnings per PR OpenRouterLabs#440) Agent: pr-maintainer Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
la14-1 pushed a commit
that referenced
this pull request
Feb 13, 2026
1. Remove .claude/skills/.DS_Store binary file 2. Deduplicate .gitignore entries (settings.json x3, settings.local.json x3, .DS_Store x2) 3. Revert log_step -> log_warn regression across 17 agent scripts and 2 lib files (log_step is cyan for progress, log_warn is yellow for actual warnings per PR #440) Agent: pr-maintainer Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
la14-1 pushed a commit
that referenced
this pull request
Feb 13, 2026
1. Remove .claude/skills/.DS_Store binary file 2. Deduplicate .gitignore entries (settings.json x3, settings.local.json x3, .DS_Store x2) 3. Revert log_step -> log_warn regression across 17 agent scripts and 2 lib files (log_step is cyan for progress, log_warn is yellow for actual warnings per PR #440) Agent: pr-maintainer Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
la14-1 pushed a commit
that referenced
this pull request
Feb 13, 2026
1. Remove .claude/skills/.DS_Store binary file 2. Deduplicate .gitignore entries (settings.json x3, settings.local.json x3, .DS_Store x2) 3. Revert log_step -> log_warn regression across 17 agent scripts and 2 lib files (log_step is cyan for progress, log_warn is yellow for actual warnings per PR #440) Agent: pr-maintainer Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
la14-1 pushed a commit
that referenced
this pull request
Feb 13, 2026
1. Remove .claude/skills/.DS_Store binary file 2. Deduplicate .gitignore entries (settings.json x3, settings.local.json x3, .DS_Store x2) 3. Revert log_step -> log_warn regression across 17 agent scripts and 2 lib files (log_step is cyan for progress, log_warn is yellow for actual warnings per PR #440) Agent: pr-maintainer Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
log_step()function (cyan colored) toshared/common.shfor progress/status messages, distinct fromlog_warn(yellow) which should be reserved for actual warningslog_warntolog_stepinshared/common.sh(14 instances: SSH key generation, agent verification, waiting/polling, configuring agents, API token prompts, SSH key registration)validatePrompterror message that suggested--prompt-fileas a workaround, when--prompt-filegoes through the same validation and would produce the same errorWhy
The codebase had ~1600 instances of
log_warn(yellow warning color) being used for normal progress messages like "Verifying installation...", "Setting up environment variables...", and "Starting Claude Code...". This made the output look alarming when nothing was wrong. The newlog_stepfunction provides a proper semantic distinction:log_info(green) = success/completionlog_step(cyan) = progress/statuslog_warn(yellow) = actual warningslog_error(red) = errorsTest plan
bash -npasses on all modified.shfilesbun testpasses (3815 tests, 0 failures)Agent: ux-engineer