Uh oh!
There was an error while loading. Please reload this page.
Conversation
… (green) In-progress actions (installing, starting, connecting...) should use log_step (cyan) to visually distinguish them from completion messages which use log_info (green). This makes it easier for users to see at a glance what is happening vs what has finished. Changes: - cli/install.sh: add log_step function, use it for install progress - shared/common.sh: OAuth flow and non-interactive exec messages - Cloud libs: interactive_session, auth, and cleanup messages - Agent scripts: gateway startup and session opening messages Agent: ux-engineer Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
la14-1
left a comment
There was a problem hiding this comment.
Reviewed by pr-maintainer: Clean log_info -> log_step conversion for in-progress messages across install.sh, cloud libs, and shared/common.sh. Consistent with the log_step (cyan) convention. No security or compat concerns. LGTM.
louisgv
left a comment
There was a problem hiding this comment.
Security Review
Verdict: APPROVED
Findings
No security issues found. This PR makes purely cosmetic changes — replacing log_info with log_step for in-progress messages across 11 shell files, and adding a log_step function to cli/install.sh.
All changes are limited to logging function name substitutions. No new user input handling, no command execution changes, no credential exposure, no modified control flow.
The new log_step function in cli/install.sh correctly uses printf (not echo -e) and follows the same pattern as existing logging functions in that file.
Tests
- bash -n: PASS (all 11 .sh files)
- bun test: N/A (no .ts changes)
- curl|bash pattern: OK (source/eval fallback patterns untouched)
- macOS compat: OK (uses printf, no echo -e, no bash 4+ features)
Automated security review by spawn security team
Summary
log_step(cyan) instead oflog_info(green) for in-progress action messages across 11 fileslog_stepfunction tocli/install.sh(which had its own logging functions withoutlog_step)Files changed
cli/install.sh-- addlog_step, use for install/download/clone progressshared/common.sh-- OAuth flow messages (server start, browser open, code exchange, non-interactive exec)render/lib/common.sh,koyeb/lib/common.sh,railway/lib/common.sh-- interactive session startionos/lib/common.sh-- Ubuntu image lookupgithub-codespaces/lib/common.sh-- auth, SSH session, codespace deletioncontabo/openclaw.sh,ionos/openclaw.sh,render/openclaw.sh-- gateway startupgithub-codespaces/claude.sh-- session openingContext
PR #440 and PR #757 established the convention that
log_step(cyan) should be used for in-progress messages, whilelog_info(green) is for completion/result messages. Several files still usedlog_infofor in-progress actions.Note on #753
Issue #753 mentioned
echo -eincli/install.sh:24-26. This was already fixed -- install.sh usesprintffor colored output, notecho -e.Test plan
bash -npasses on all 11 modified .sh filesbun testpasses (6190/6204 -- 14 pre-existing failures unrelated to this change)Agent: ux-engineer