Align TrafficLight with OpenDRIVE and OpenSCENARIO

[adrianschultz]

Reference to a related issue in the repository

#611

Add a description

I changed the traffic lights according to the description in #611

Changes to be reviewed are only in osi_trafficlight.proto
The other changes are documented in #584 and #613 and should be reviewed there.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

• My suggestion follows the style and contributors guidelines.
• I have taken care about the documentation.
• I have done the DCO signoff.
• My changes generate no errors when passing CI tests.
• I have successfully implemented and tested my fix/feature locally.
• Appropriate reviewer(s) are assigned.

[clemenshabedank]

I wonder if this really should be deprecated for OSI. For OpenSCENARIO and the agent model use case it is probably a good idea to describe traffic lights with a phase as you suggest in this PR. But the (semantic) color might still be an interesting input for sensor models... Maybe it could be similar to the separation of logical and physical information for lanes which was introduced in PR599.

[adrianschultz]

For this pull request we (the Harmonization group) agreed on waiting for the outcome of the potential OSI, OpenSCENARIO and OpenDRIVE workshop on dynamic traffic signals/signs.

[jdsika]

Maybe we can add @arauschert here for some input regarding the harmonization with OpenSceanrio

[arauschert]

Maybe we can add @arauschert here for some input regarding the harmonization with OpenSceanrio

Sure. Please invite me, if there are any discussion meetings. From my POV we first have to decide, what OSI shall represent:

1. the instantaneous perceivable state (e.g. ON/OFF) or the current interpreted phase (e.g. constant/flashing/off)
2. only one light bulb or the whole traffic light box including one or multiple light

I would also separate the issue of missing icons for U-turn, bicycles and tram, which can be easily fixed (v3.x) from the harmonization issue (v4)

[thempen]

WG meeting Harmonization response:

After termonology is clear, please update.
Check icons if values are missing there.
Consider combined semantic meaning, e.g. red+yellow on german traffic ligts has a special meaning.

[thomassedlmayer]

Harmonization WG 2023/03/01: @adrianschultz Is this topic still open and will you adapt the PR by the mentioned issues? Or should we close this PR?

[thempen]

OtherModels & Harmonization group meeting result: Closed. If needed again, reopen new issue / PR.