Skip to content

Better press page - #196

Merged
kylemh merged 36 commits into
OperationCode:masterfrom
dirtyredz:BetterPressPage
Oct 3, 2018
Merged

Better press page#196
kylemh merged 36 commits into
OperationCode:masterfrom
dirtyredz:BetterPressPage

Conversation

@dirtyredz

Copy link
Copy Markdown
Contributor

Description of changes

Adds "In The News" section to the Press page.
Fixes minor styling issues.
Updates testing for common button component for handling onClick.

Issue Resolved

Fixes#171
As it now adds the missing article links.

Screenshots/GIFs

inthenews
inthenewsexpanded
inthenewsresponsive1
inthenewsresponsive2

@vercel

vercelBot commented Oct 3, 2018

Copy link
Copy Markdown

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@dirtyredz

Copy link
Copy Markdown
ContributorAuthor

Looks like a few updates have been made since ive opened this branch.

@kylemh

kylemh commented Oct 3, 2018

Copy link
Copy Markdown
Member

🤖 This is a bot 🤖

🎉 Deployed Storybook preview! 🎉

Click the link at the bottom of this comment to see it live.

Built with commit cc2c97d

https://deploy-preview-196--operation-code-storybook.netlify.com

@dirtyredz

Copy link
Copy Markdown
ContributorAuthor

Styles were pulled from OperationCode/operationcode_frontend#1024

@kylemh

kylemh commented Oct 3, 2018

Copy link
Copy Markdown
Member

The conflicts are going to be pretty rough to resolve 😥

I recommend closing this PR and copy-pasting to the correct spots, as I moved some folders around (I simply wanted to modularize content).

Thanks so much for working to simplify this! I love the direction your going.

When you're done porting over, you can ignore test coverage for the data structure containing all the links via changing jest.config.js - there's no logic to test there.

@dirtyredz

dirtyredz commented Oct 3, 2018

Copy link
Copy Markdown
ContributorAuthor

Will Do

@dirtyredz

Copy link
Copy Markdown
ContributorAuthor

@kylemh Merged/Updated and moved the new PressLinks into the Press directory. should be ready for a merge.

@kylemhkylemh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work. Solid test coverage and it looks super clean.

Mostly variable naming changes and some edits in the testing. I gave you the tools needed to accomplish your UI for the "show all" button.

Comment threadcomponents/Press/PressLinks/LinkGroup.js Outdated
Comment threadcomponents/Press/PressLinks/LinkGroup.js Outdated
Comment threadcomponents/Press/PressLinks/LinkGroup.js Outdated
Comment threadcomponents/Press/PressLinks/LinkGroup.js Outdated
Comment threadcomponents/Press/PressLinks/LinkGroup.js Outdated
Comment threadcomponents/_common_/Button/Button.js Outdated
Comment threadcomponents/_common_/Button/__tests__/Button.test.js Outdated
Comment threadjest.config.js Outdated
Comment threadpages/styles/press.css Outdated
@dirtyredz

Copy link
Copy Markdown
ContributorAuthor

All make these fixes asap, and thanks for taking the time to explain yourself on the changes. It helps me better understand what your wanting, making it easier for me to help you guys out.

@kylemh

Copy link
Copy Markdown
Member

No problem at all @dirtyredz - hopefully it's useful info. Feel free to @ me on Slack at any moment. Let's get you a shirt in addition to those stickers 😉

@dirtyredz

dirtyredz commented Oct 3, 2018

Copy link
Copy Markdown
ContributorAuthor

just need to work on the button aria portion

@dirtyredz

Copy link
Copy Markdown
ContributorAuthor

There we go, that should resolve everything. Again thanks for the collaboration very helpful!!

@kylemhkylemh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more switch + remove that snapshot test

this is HUGE FOR US 😁

Comment threadcomponents/Press/PressLinks/PressLinks.js Outdated
Comment threadcomponents/_common_/Button/__tests__/Button.test.js
@kylemh

kylemh commented Oct 3, 2018

Copy link
Copy Markdown
Member

I made some commits to make small edits to things I didn't wanna bother you about - be sure to pull and update snapshot tests - the build should resolve again

@dirtyredz

Copy link
Copy Markdown
ContributorAuthor

ugh, I ALWAYS forget to update component names... lol, thanks for those fixes. Ill pull and resolve the remaining reviews.

@dirtyredzdirtyredz left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dirtyredzdirtyredz left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... I was totally being lazy one this one, cant get nothing past you.

@kylemhkylemh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible work.

@dirtyredz

Copy link
Copy Markdown
ContributorAuthor

Thank you, and great job yourself keeping me on my toes.

@dirtyredz

Copy link
Copy Markdown
ContributorAuthor

Tonight ill do a PR for updated Linting rules specifically alpha order and imports.

@kylemh

Copy link
Copy Markdown
Member

@dirtyredz less about keeping you on your toes and more about me being nitpicky.

Thanks ahead of time for doing that issue!

@kylemh

Copy link
Copy Markdown
Member

@dirtyredz will you do me the favor of pulling changes and pushing snapshot updates?

@dirtyredz

Copy link
Copy Markdown
ContributorAuthor

sure

@kylemh
kylemh merged commit 8e89c38 into OperationCode:masterOct 3, 2018
@dirtyredz
dirtyredz deleted the BetterPressPage branch October 3, 2018 23:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@dirtyredz@kylemh