Uh oh!
There was an error while loading. Please reload this page.
Fixes #1017: Adds media highlights to Operation Code website: General - #1024
Fixes #1017: Adds media highlights to Operation Code website: General#1024cyph3r-m00n wants to merge 3 commits into
Conversation
Thanks so much for your continued contributions! For all of those anchor tags, we have an OutboundLink component that ties into our analytics. Could you switch to those? |
cyph3r-m00n
commented
Aug 6, 2018
@kylemh For sure! I'll Check that out now! |
cyph3r-m00n
commented
Aug 6, 2018
@kylemh All of the Anchor tags have been changed to use the OutboundLink component! |
@cyph3r-m00n - I mean this component: https://github.com/OperationCode/operationcode_frontend/blob/master/src/shared/components/outboundLink/outboundLink.js No need to import |
| @media screen and (min-width: 415px) and (max-width: 1280px) { | ||
| .logos > .imgBox { | ||
| width: 350px; |
There was a problem hiding this comment.
I don't see any elements with the class .imgBox in the markup - so is there any need for this CSS rule?
| > | ||
| Operation Code Looks to Help Veterans Land IT Careers | ||
| </ReactGA.OutboundLink> | ||
| </li> |
There was a problem hiding this comment.
The list-items could use some vertical space between them on mobile to provide visual separation between elements. I suggest adjusting the line-height for the all <li> elements, and adjusting the margin-top for adjacent sibling <li> elements:
.item {
line-height: 1;
}
.item + .item {
margin-top: 5px;
}
Due to the small width of mobile screens, for the <ul> element, the bullets can probably be removed, and the padding can be adjusted:
.list {
list-style: none;
padding: 0 20px;
}
jjhampton
left a comment
There was a problem hiding this comment.
Looks good, thanks for the contrib @cyph3r-m00n ! Only a few minor changes requested - please see comments that @kylemh and I already posted.
Description of changes
Adds Media Highlights to Press Page
Issue Resolved
Fixes#1017