') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); ci: pin go-task version to avoid intermittent setup failures by prql-bot · Pull Request #5836 · PRQL/prql · GitHub
Skip to content

ci: pin go-task version to avoid intermittent setup failures - #5836

Merged
max-sixty merged 1 commit into
mainfrom
fix/ci-25015144215
Apr 28, 2026
Merged

ci: pin go-task version to avoid intermittent setup failures#5836
max-sixty merged 1 commit into
mainfrom
fix/ci-25015144215

Conversation

@prql-bot

@prql-botprql-bot commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator

Problem

test-php failed on main in run 25015144215 (commit da7ce0e) with ##[error]unable to get latest version from go-task/setup-task@v1. The same error broke build-web and test-prqlc-c in the prior main run 25007961050 — so this is a recurring failure mode, not a one-off.

Root cause: the action defaults to version: 3.x and resolves the concrete release via https://api.github.com/repos/go-task/task/releases?per_page=100. When that response is empty (rate limit, transient API hiccup), installer.ts throws unable to get latest version. max-retries: 3 only re-tries the HTTP call, not the empty-result branch.

Solution

Pin version: 3.50.0 (the current latest task release, published 2026-04-13) at every go-task/setup-task@v1 call site. The action's computeVersion short-circuits when semver.valid(version) is true, skipping the API lookup entirely — so a concrete semver eliminates the failure mode.

Updated four sites:

  • .github/workflows/test-php.yaml
  • .github/workflows/build-web.yaml
  • .github/workflows/test-prqlc-c.yaml
  • .github/actions/tend-setup/action.yaml (also covers tend-* workflows that consume this composite action)

The commented-out reference in .github/workflows/tests.yaml:293 was left untouched.

Testing

Can only be verified end-to-end by CI. The change is mechanical — a value pinned in YAML — and matches the action's documented behavior.

Automated fix for failed run 25015144215.

@prql-bot@claude
ci: pin go-task version to avoid intermittent setup failures
1a0633a
The default `version: 3.x` makes `go-task/setup-task@v1` resolve the
latest tag via the GitHub releases API. That call has failed twice in
the last few hours on main with `unable to get latest version`,
breaking test-php (run 25015144215) and build-web/test-prqlc-c
(run 25007961050). Pinning a concrete semver makes the action skip
the API call entirely (`semver.valid(version)` short-circuits in
the action's installer.ts).
Co-Authored-By: Claude <noreply@anthropic.com>
@max-sixty

max-sixty commented Apr 27, 2026

Copy link
Copy Markdown
Member

ok, and then bump this in our weekly maintenance task

@prql-botprql-bot mentioned this pull request Apr 27, 2026
Merged
@prql-bot

prql-bot commented Apr 27, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Opened #5840 to add the bump to running-tend's weekly section. Note that workflows.weekly is currently disabled in .config/tend.toml, so the task is defined but won't actually run until weekly is re-enabled — flagged that in the PR description.

@max-sixty

max-sixty commented Apr 28, 2026

Copy link
Copy Markdown
Member

Note that workflows.weekly is currently disabled in .config/tend.toml, so the task is defined but won't actually run until weekly is re-enabled — flagged that in the PR description.

why? can we re-enable?

@prql-bot

prql-bot commented Apr 28, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Historical artifact. The setting was added in #5727 when the workflow was named renovate and only auto-opened dependency-update PRs — the comment "Dependabot already handles dependency updates" still describes that scope. #5760 regenerated the tend workflows and renamed [workflows.renovate] → [workflows.weekly], but the enabled = false and its comment carried over verbatim without revisiting whether the original justification still applied.

The renamed weekly skill does more than the old renovate one: it (1) reviews open dependency PRs and approves safe ones (patch/minor with green CI), and (2) runs any repo-specific weekly tasks defined in running-tend — which now includes the go-task pin bump from #5840. Neither of those overlaps with what Dependabot itself does, so re-enabling looks safe.

Happy to open a follow-up PR flipping enabled = true and removing the stale comment if you'd like.

@max-sixty
max-sixty merged commit a0c651e into mainApr 28, 2026
40 checks passed
@max-sixty
max-sixty deleted the fix/ci-25015144215 branch April 28, 2026 00:18
@max-sixty

max-sixty commented Apr 28, 2026

Copy link
Copy Markdown
Member

Happy to open a follow-up PR flipping enabled = true and removing the stale comment if you'd like.

yes please

@prql-botprql-bot mentioned this pull request Apr 28, 2026
Merged
@prql-bot

prql-bot commented Apr 28, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Opened #5842.

This was referenced Apr 28, 2026
Closed
Closed
@prql-botprql-bot mentioned this pull request May 17, 2026
Merged
@prql-botprql-bot mentioned this pull request Jul 5, 2026
Merged
This was referenced Aug 12, 2026
Closed
Open
@prql-botprql-bot mentioned this pull request Aug 23, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prql-bot@max-sixty