Uh oh!
There was an error while loading. Please reload this page.
Add parsing for Hallowing Flame mods - #9544
Merged
LocalIdentity merged 3 commits intoMar 14, 2026
Merged
Conversation
Signed-off-by: Paliak <91493239+Paliak@users.noreply.github.com>
Paliakforce-pushed
the
add-hallow-flame-parsing
branch
from
March 12, 2026 19:38
7fac435 to
0380d9bCompareUh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Paliak <91493239+Paliak@users.noreply.github.com>
Paliak
marked this pull request as ready for review
March 13, 2026 18:05
LocalIdentity
approved these changes
Mar 14, 2026
Uh oh!
There was an error while loading. Please reload this page.
NDari pushed a commit
to NDari/PathOfBuilding
that referenced
this pull request
Mar 31, 2026
* FEAT: impl handling for hallowing flame Signed-off-by: Paliak <91493239+Paliak@users.noreply.github.com> * FIX: space indentation Signed-off-by: Paliak <91493239+Paliak@users.noreply.github.com> --------- Signed-off-by: Paliak <91493239+Paliak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Add mod parsing and related config options for Hallowing flame.
Main caveat of this pr is that
Attacks with this Weapon inflict Hallowing Flame on Hitwill cause the hallowing flame config option to show up regardless of whether thewith this Weapon on Hitpart is satisfied by the current skill.