Uh oh!
There was an error while loading. Please reload this page.
Add config option for Hallowing Flame magnitude - #9676
Merged
LocalIdentity merged 2 commits intoApr 11, 2026
Conversation
Signed-off-by: Paliak <91493239+Paliak@users.noreply.github.com>
LocalIdentity
approved these changes
Apr 11, 2026
Uh oh!
There was an error while loading. Please reload this page.
LocalIdentity pushed a commit
that referenced
this pull request
Apr 20, 2026
PR #9676 added code to allow the support gem to grant a global effect but this had the effect of scaling other global effects by the number of skills in the build and was ignoring their effect conditions e.g. Ancient Skull 50% inc damage was applying 20 times to player skills in a build
LocalIdentity added a commit
that referenced
this pull request
Apr 20, 2026
* Fix some buffs applying incorrectly to the player PR #9676 added code to allow the support gem to grant a global effect but this had the effect of scaling other global effects by the number of skills in the build and was ignoring their effect conditions e.g. Ancient Skull 50% inc damage was applying 20 times to player skills in a build * Farrul beast aura's now count as ally auras Stops Ichimonjji from blocking their effect * Stop Flicker strike buff stacking --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
In #9544 i added support for hallowing flame but i forgot to add handling for the Hallow support gem. The currently implemented approach assumed that all hallowing flames applied by a given player have the same magnitude which turned out to not be correct.
After discussing it on Discord the general conclusion is that the only sensible way of handling hallowing flame magnitude mods would be to add a config option.
This Pr add this option which is pre-filled with a total of global hallowing magnitude increase by default.
Link to a build that showcases this PR: