Skip to content

GSoC 2021: Enhancing clang-bind - #14

Open
diivm wants to merge 1 commit into
PointCloudLibrary:masterfrom
diivm:gsoc-2021/clang-bind
Open

GSoC 2021: Enhancing clang-bind#14
diivm wants to merge 1 commit into
PointCloudLibrary:masterfrom
diivm:gsoc-2021/clang-bind

Conversation

@diivm

Copy link
Copy Markdown

No description provided.

@diivm

Copy link
Copy Markdown
Author

@kunaltyagi@larshg
Please have a look.

Comment threadgsoc-2021/clang-bind.md Outdated
@larshg

Copy link
Copy Markdown

Overall it looks good.

Comment threadgsoc-2021/clang-bind.md Outdated
Comment threadgsoc-2021/clang-bind.md Outdated
Comment on lines +135 to +136
3. Create the API directory `build/.cmake/api/v1/query`.
4. Create the file `build/.cmake/api/v1/query/codemodel-v2` and leave it empty.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a small script (in the code base and reference it here):

* Configure your project build as normal
* Run `mkdir -p .cmake/api/v1/query && touch .cmake/api/v1/query/codemodel-v2` in the root of the cmake build tree (usually the `build` folder)
* `cmake .` to reconfigure cmake

PS: Do we need the project to be built before we start working?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Have a look at the shell script](https://github.com/PointCloudLibrary/clang-bind/blob/7bdcbcdf3d7bbc9ad706a5184d634f4524d29428/init_bindings.sh#L19-L21).

Do we need the project to be built before we start working?

Yes. We need both cmake-file-api and compilation db.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant: do we need to build PCL before starting with PCL bindings or just PCL's CMake configured?

@diivm
diivmforce-pushed the gsoc-2021/clang-bind branch from 6211bfd to 77fe26dCompareAugust 30, 2021 18:47
@diivm
diivmforce-pushed the gsoc-2021/clang-bind branch from 77fe26d to 8abcbb5CompareAugust 30, 2021 19:56

@kunaltyagikunaltyagi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roughly LGTM. Will merge once you're happy @divmadan

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@diivm@larshg@kunaltyagi