Skip to content
This repository was archived by the owner on Aug 6, 2026. It is now read-only.

fix: Fix stacked chevrons in project select dropdowns - #1981

Merged
charlesvien merged 2 commits into
mainfrom
05-02-fix_stacked_chevrons_in_project_select_dropdowns
May 4, 2026
Merged

fix: Fix stacked chevrons in project select dropdowns#1981
charlesvien merged 2 commits into
mainfrom
05-02-fix_stacked_chevrons_in_project_select_dropdowns

Conversation

@charlesvien

@charlesviencharlesvien commented May 2, 2026

Copy link
Copy Markdown
Member

Problem

all: "unset" on dropdown buttons nukes display: flex, causing the chevron icon to stack below the label text instead of sitting inline.

image (60)

Changes

  1. Remove all: "unset" inline style from both org and project dropdown buttons
  2. Replace with appearance-none Tailwind class for button reset
  3. Move boxShadow and fontFamily from inline styles to Tailwind utilities

How did you test this?

Manually

@charlesviencharlesvien changed the title Fix stacked chevrons in project select dropdownsfix: Fix stacked chevrons in project select dropdownsMay 2, 2026
@greptile-apps

Copy link
Copy Markdown
Contributor
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---### Issue 1 of 1
apps/code/src/renderer/features/onboarding/components/ProjectSelectStep.tsx:170
**`font-inherit` may not be a valid Tailwind v4 utility**`font-inherit` is not a built-in Tailwind v4 font-family utility — Tailwind maps `font-{x}` to `var(--font-x)`, so `font-inherit` would look for a `--font-inherit` CSS variable that isn't defined in `@theme`. Functionally this is harmless (font-family will naturally inherit from the parent since `appearance-none` doesn't reset it), but the class is a no-op. The correct arbitrary-value syntax for an explicit `font-family: inherit` declaration would be `font-[inherit]`. The same applies on line 262.
```suggestion className="box-border flex w-full cursor-pointer appearance-none items-center justify-between rounded-[10px] border border-(--gray-a3) bg-(--color-panel-solid) px-[14px] py-[10px] font-[inherit] text-sm shadow-[0_1px_3px_rgba(0,0,0,0.04),0_1px_2px_rgba(0,0,0,0.02)]"```

Reviews (1): Last reviewed commit: "Fix stacked chevrons in project select d..." | Re-trigger Greptile

Comment threadapps/code/src/renderer/features/onboarding/components/ProjectSelectStep.tsx Outdated
@charlesvien
charlesvienforce-pushed the 05-02-fix_stacked_chevrons_in_project_select_dropdowns branch 2 times, most recently from aaa1c0d to 833d5a4CompareMay 4, 2026 01:38
@charlesvienGraphite App

charlesvien commented May 4, 2026

Copy link
Copy Markdown
MemberAuthor

Merge activity

  • May 4, 6:05 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 4, 6:07 PM UTC: Graphite rebased this pull request as part of a merge.
  • May 4, 6:16 PM UTC: @charlesvien merged this pull request with Graphite.

@charlesvien
charlesvien changed the base branch from 05-02-enrich_attachment-only_task_descriptions_for_title_generation to graphite-base/1981May 4, 2026 18:05
@charlesvien
charlesvien changed the base branch from graphite-base/1981 to mainMay 4, 2026 18:05
@charlesvien
charlesvienforce-pushed the 05-02-fix_stacked_chevrons_in_project_select_dropdowns branch from 833d5a4 to bc321b3CompareMay 4, 2026 18:06
@charlesvien
charlesvien merged commit 97cf196 into mainMay 4, 2026
16 checks passed
@charlesvien
charlesvien deleted the 05-02-fix_stacked_chevrons_in_project_select_dropdowns branch May 4, 2026 18:16
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@charlesvien@jonathanlab