Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Aug 6, 2026. It is now read-only.
fix: Debounce releases and skip empty tags in code workflow - #1983
Merged
charlesvien merged 10 commits intoMay 4, 2026
Conversation
MemberAuthor
This was referenced May 2, 2026
This was referenced May 3, 2026
charlesvienforce-pushed
the
05-02-fix_stacked_chevrons_in_project_select_dropdowns
branch
from
May 3, 2026 08:53
e396426 to
b936821Comparecharlesvienforce-pushed
the
05-02-skip_empty_releases_in_code_tag_workflow
branch
from
May 3, 2026 08:53
9e4a4a8 to
231aed4Comparecharlesvien
marked this pull request as ready for review
May 3, 2026 17:55
Contributor
Prompt To Fix All With AIFix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---### Issue 1 of 2
.github/scripts/compute-release-tag.sh:41
**`base_tag` output is never consumed**
The script outputs `base_tag=$LATEST_TAG` on stdout, but the workflow only parses `tag=` from `$RESULT` (via `grep '^tag='`). The `base_tag` line goes into `$RESULT` and is silently discarded. Per simplicity rule #4, this is a superfluous part — either remove the `base_tag` echo or consume it in the workflow (e.g. enrich the "Creating tag" log line).
### Issue 2 of 2
.github/scripts/compute-release-tag.test.sh:68-159
**Tests not parameterised**
Every test case repeats the same `setup_repo` → `run_script` → `assert_*` → `teardown_repo` pattern. The team convention is to prefer parameterised tests. A data-driven table of `(description, setup_commands, expected_exit, expected_stdout_contains, expected_stderr_contains)` tuples iterated by a single `run_test` function would eliminate the repetition and make adding new cases trivial.
Reviews (1): Last reviewed commit: "Harden test cleanup and TMPDIR fallback" | Re-trigger Greptile |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
charlesvienforce-pushed
the
05-02-skip_empty_releases_in_code_tag_workflow
branch
from
May 3, 2026 23:13
231aed4 to
ccfdb79Comparecharlesvienforce-pushed
the
05-02-fix_stacked_chevrons_in_project_select_dropdowns
branch
from
May 3, 2026 23:13
b936821 to
aaa1c0dComparecharlesvienforce-pushed
the
05-02-skip_empty_releases_in_code_tag_workflow
branch
from
May 4, 2026 01:38
ccfdb79 to
ae2ccdaComparecharlesvienforce-pushed
the
05-02-fix_stacked_chevrons_in_project_select_dropdowns
branch
from
May 4, 2026 01:38
aaa1c0d to
833d5a4Comparejonathanlab
approved these changes
May 4, 2026
jonathanlab
left a comment
Contributor
There was a problem hiding this comment.
LGTM, lets try this and see if we like it
MemberAuthor
Merge activity
|
charlesvien
changed the base branch from
05-02-fix_stacked_chevrons_in_project_select_dropdowns
to
graphite-base/1983May 4, 2026 18:06
charlesvienforce-pushed
the
05-02-skip_empty_releases_in_code_tag_workflow
branch
from
May 4, 2026 18:17
ae2ccda to
7ba8c45CompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
Scheduled releases can fire mid stack merge (we all use Graphite) and the workflow crashes trying to create tags that already exist.
Changes
How did you test this?
I did not, we should make a simple ACT tooling setup to test this stuff easily.