workspace/didChangeConfiguration: InvalidOperationException: An attempt was made to transition a task to a final state when it had already completed.

[dkattan]

PowerShellEditorServices/src/PowerShellEditorServices/Extensions/EditorObject.cs

Line 140 in a12edc9

s_editorObjectReady.SetResult(true);

Consider using TrySetResult to prevent this exception when the editor is re-initialized or sends a workspace/didChangeConfiguration request

Rob Holt (@rjmholt)

[dkattan]

Also consider checking that incomingSettings.Powershell isn't null before using it in ConfigurationHandler.SendFeatureChangesTelemetry:

PowerShellEditorServices/src/PowerShellEditorServices/Services/Workspace/Handlers/ConfigurationHandler.cs

Line 161 in a12edc9

if (incomingSettings.Powershell.ScriptAnalysis.Enable == false &&

The MonacoLanguageClient sends an empty settings object along with workspace/didChangeConfiguration and it throws an exception.

{"jsonrpc":"2.0","method":"workspace/didChangeConfiguration","params":{"settings":{}}}

Tyler James Leonhardt (@TylerLeonhardt)

[andyleejordan]

I see two different bugs here in one issue, but will get them addressed.

[dkattan]

I included both in the same issue since the repro steps are the same for both.

[andyleejordan]

Rob Holt (@rjmholt) Should we consider changing all uses of SetResult to TrySetResult? When do we actually ever want the server to crash?