Uh oh!
There was an error while loading. Please reload this page.
Prevent some exceptions - #1500
Merged
Merged
Conversation
This was actually the documented parameter, but at some point it changed to take a file. It was better to use the `_workspaceService` service directly and safely attempt to get the file than to require the user to do that beforehand.
Used by the `MonacoLanguageClient`. Because it has no real file backing, we had to check that no file was returned in the prior commit.
As it can fail if the editor is being re-initialized.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Andy Jordan (andyleejordan)
commented
Jun 15, 2021
MemberAuthor
Rob Holt (@rjmholt) Applied. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Andy Jordan (andyleejordan)force-pushed
the
andschwa/fixes
branch
from
June 15, 2021 22:09
2a140bd to
5cdfd8aCompareAndy Jordan (andyleejordan)
enabled auto-merge
June 15, 2021 22:14
Rob Holt (rjmholt)
approved these changes
Jun 15, 2021
Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>
Andy Jordan (andyleejordan)force-pushed
the
andschwa/fixes
branch
from
June 16, 2021 02:39
9dbb7eb to
f917e9bCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#1495, #1498, and #1476.