Skip to content

Export data from Movimiento table. - #36

Merged
NicolasSandoval merged 12 commits into
PyAr:masterfrom
Juerodriguez:fix-10-exportfiles
Jul 10, 2021
Merged

Export data from Movimiento table.#36
NicolasSandoval merged 12 commits into
PyAr:masterfrom
Juerodriguez:fix-10-exportfiles

Conversation

@Juerodriguez

@JuerodriguezJuerodriguez commented Jun 23, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Resumen

closeJuerodriguez#11

Este PR permite descargar todos los archivos de la tabla movimiento en un zip
Corresponde a la issue: #10.

Checklist

  • Variables, funciones y comentarios en Español
  • Corrector ortográfico ok
  • Cdigo Python cumple PEP8
  • Cobertura de tests con Playwright
  • Revisores asignados (pares & al menos 1 mentor)

Screenshots

Captura de pantalla de 2021-06-23 13-12-02

test_upload_expedientes_chromium.mp4
test_download_chromium.mp4

@Juerodriguez

Juerodriguez commented Jun 25, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Cambie el formato de videos de playwright a mp4 para hacer posible la subida de los mismos a github @eamanu@marian-vignau

eamanu
eamanu reviewed Jun 25, 2021
View reviewed changes
Comment threadcontrollers/expedientes.py Outdated
Comment threadcontrollers/expedientes.py Outdated
Comment threadcontrollers/expedientes.py Outdated
Comment threadcontrollers/expedientes.py Outdated
@eamanu

eamanu commented Jun 25, 2021

Copy link
Copy Markdown
Collaborator

@Juerodriguez also check that tests are failling https://github.com/PyAr/OpenLex/pull/36/checks?check_run_id=2911412429

Let me know if you need help

@Juerodriguez
git pull upstream master
e5c2d85
git push origin masterMerge branch 'master' of https://github.com/Juerodriguez/OpenLex into fix-10-exportfiles
@Juerodriguez

Juerodriguez commented Jun 25, 2021

Copy link
Copy Markdown
ContributorAuthor

@Juerodriguez also check that tests are failling https://github.com/PyAr/OpenLex/pull/36/checks?check_run_id=2911412429

Let me know if you need help

I could see that this dont work because I forget commit one line change.
Now I upload that with suggest changes

@JuerodriguezJuerodriguez mentioned this pull request Jul 1, 2021
Merged
5 tasks
@Juerodriguez
Juerodriguez requested a review from eamanuJuly 2, 2021 23:44
eamanu
eamanu approved these changes Jul 10, 2021
View reviewed changes
Comment threadcontrollers/expedientes.py
@eamanueamanu mentioned this pull request Jul 10, 2021
Open
NicolasSandoval
NicolasSandoval approved these changes Jul 10, 2021
View reviewed changes

@NicolasSandovalNicolasSandoval left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NicolasSandoval
NicolasSandoval merged commit 0aa15f6 into PyAr:masterJul 10, 2021
@eamanueamanu mentioned this pull request Jul 10, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eamanueamanueamanu approved these changes
@NicolasSandovalNicolasSandovalNicolasSandoval approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Organize zip download by folders

3 participants

@Juerodriguez@eamanu@NicolasSandoval